- User Since
- Jan 28 2015, 2:26 PM (142 w, 2 d)
Tue, Oct 17
Fri, Oct 13
@anna This patch causes the following polly test to fail in the reverse iteration builder:
Thu, Oct 12
Wed, Oct 11
@ahatanak This patch causes the following make check failure in the reverse iteration bot:
This revert causes the following make check failures in the reverse iteration bot:
Mon, Sep 25
Sep 18 2017
Sep 15 2017
Sep 7 2017
Patch no longer needed/valid.
Patch no longer valid.
Patch no longer needed/valid.
No longer needed.
Sep 6 2017
Made changes in the text based on comments:
Ping for reviews please.
Sep 5 2017
Sep 3 2017
I had accidentally pushed a wrong patch to this commit. Fixed it now.
NFC. Made the static_assert the first statement in the test.
Added DenseMap test for pointer-like keys.
Sep 1 2017
The thing I am concerned with here is whether changing SmallPtrSet to a SetVector can potentially slow down the Static Analyzer? ExplodedNode seem to be used heavily in the analyzer and I can see it being iterated upon in several places.
Aug 31 2017
Aug 29 2017
Do you think using SetVector instead of DenseSet will impact compile-time? The other option we have is to add the TypeIds into a SmallVector and sort it before iteration.
This will fix the following unit tests which failed in the reverse iteration buildbot (http://lab.llvm.org:8011/builders/reverse-iteration/builds/23/steps/check_all/logs/stdio)
Aug 28 2017
Aug 24 2017
This is needed to un-break the bots. Will go ahead and commit this.
This test causes failure on the bots: http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/4861/steps/test-stage1-compiler/logs/stdio
@dblaikie Could you please take a look at this? If you have no objections then can we merge this?
Aug 23 2017
Minor styling fixes - changed <typename>* to <typename> *.
Aug 21 2017
#Included PointerLikeTypeTraits.h in ReverseIteration.h.
Aug 17 2017
I see this has already been done in https://reviews.llvm.org/rL310667. My sources seem to have been outdated. Abandoning this one.
Adopted @dblaikie 's changes for pointer-like traits.
Aug 12 2017
Probably a layering violation to include this here. Also seems like a narrow solution - would require more special casing here for other types that are like these two whenever they might get used in a map eventually, etc.
Yes, this is true. But I cannot think of a way of overcoming this.
Addressed comments in the unit test.
Moved unittests/ADT/ReverseIteration.cpp to unittests/Support/ReverseIteration.cpp.
Aug 9 2017
Checked if type is pointer-like without adding a new trait. Instead used PointerLikeTypeTraits::NumLowBitsAvailable.
Aug 7 2017
This patch does 3 things:
Aug 6 2017
We removed -reverse-iterate flag and the base definition for PointerLikeTypeTraits here, we need https://reviews.llvm.org/D36386
which removes clang unit test which used -reverse-iterate and marks member functions of PointerLikeTypeTraits
as public to get past a compilation error.
Aug 2 2017
Aug 1 2017
LGTM. However, I would wait for someone more aware of buildbots to +1 this.
Added Victor Leschuk as reviewer since Galina is on vacation.