- User Since
- Jan 28 2015, 2:26 PM (159 w, 4 d)
Fri, Feb 16
Thu, Feb 8
Related compiler-rt patch: https://reviews.llvm.org/D43106
Thu, Feb 1
For now, by setting the full triple (riscv-unknown-linux-gnu) we are able to invoke the correct gnu linker. So will abandon this patch.
Wed, Jan 31
Mon, Jan 29
Dec 7 2017
Dec 6 2017
Dec 4 2017
Dec 1 2017
This seems to be the last outstanding issue uncovered by D39245. I have already fixed all the other failures. Getting this patch in would unblock me to get D39245 (and subsequent patches to convert std::sort to llvm::sort) merged. Could the reviewers please review this patch? Thanks!
Nov 30 2017
Nov 29 2017
Nov 28 2017
Nov 27 2017
Ping for reviews please.
Nov 21 2017
This is fixed in D39898. Abandoning this.
Nov 20 2017
Ping for reviews please.
I am no longer able to reproduce this failure. Probably got fixed sometime last week. Maybe in D38830?
Fixed another instance of non-deterministic ordering causing failure in CodeGen/X86/switch.ll.
Nov 19 2017
Added a stronger sorting predicate instead of stable sort.
This is the order of options observed when the candidates are randomly shuffled:
In HexagonShuffler.h, the lessCore and lessCVI comparators sort insts based on the number of units set. Now, two insts can have the same units set so their relative ordering is not defined.
We could add an index field as a tie-breaker but that would mean changes to function APIs which I felt could be an overkill. Hence, I went with the simpler approach to just use stable_sort instead.
Please let me know your thoughts on this.
Nov 18 2017
Added comment to explain what's going on.
Nov 17 2017
Could you please add a few tests? Also please remember to add llvm-commits as subscriber to your patches.
Nov 16 2017
Nov 15 2017
Could you please add some tests?
@asb I cherry-picked this patch and was able to compile a simple program for elf triple. By manually adding a few libs on the link line I was also able to make it link for linux triple.
Could you please respond to the comment about risv32-ld? Other than that this patch LGTM!
Nov 14 2017
Nov 13 2017
Fixed the sorting order for stable_sort.
Ping 2 for reviews please.
Nov 12 2017
Although this patches fixes the above unit test failures, the generated code is very different from the one that the tests expect. As a result, these tests need to be adjusted. Could the reviewers please comment/suggest on whether it is ok to fix the tests as a result of this change?