mgrang (Mandeep Singh Grang)
http://livgently.com

Projects

User does not belong to any projects.

User Details

User Since
Jan 28 2015, 2:26 PM (142 w, 2 d)

Recent Activity

Tue, Oct 17

mgrang created D39025: [GVNSink] Fix failing GVNSink tests in the reverse iteration bot.
Tue, Oct 17, 5:16 PM

Fri, Oct 13

mgrang updated subscribers of rL315683: [SCEV] Teach SCEV to find maxBECount when loop endbound is variant.

Thanks @mgrang for pointing the failure. I do see the polly test case and this would kick in because the end bound of the outer loop is variant (bb7 is the latch of outer loop).

https://github.com/llvm-mirror/polly/blob/master/test/Isl/CodeGen/large-numbers-in-boundary-context.ll

However, I'm not sure of how that changes the br i1 false to br i1 true. I think polly might be incorrectly using the result of the maxBECount?

Fri, Oct 13, 1:38 PM
mgrang updated subscribers of rL315683: [SCEV] Teach SCEV to find maxBECount when loop endbound is variant.

@anna This patch causes the following polly test to fail in the reverse iteration builder:
http://lab.llvm.org:8011/builders/reverse-iteration/builds/487

Fri, Oct 13, 12:20 PM

Thu, Oct 12

mgrang added a comment to rL313717: [Sema][ObjC] Warn about mismatches in attributes between overriding and.

OK, I committed a patch in r315639 to fix the test.

Thu, Oct 12, 4:31 PM
mgrang added a comment to rL313717: [Sema][ObjC] Warn about mismatches in attributes between overriding and.

I think the right way to fix this is to merge the ObjCMethodDecls before iterating over the overridden methods in Sema::CheckObjCMethodOverridesmergeObjCMethodDecls so that NSReturnsRetainedAttr is propagated to the overriding method before the diagnostics are printed. If we just want to fix the nondeterminism, we can just stop using SmallPtrSet for OverrideSearch::Overridden.

Thu, Oct 12, 12:37 PM

Wed, Oct 11

mgrang added a comment to D38821: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb.

LGTM.

Wed, Oct 11, 3:14 PM
mgrang added a comment to D36111: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb.

@mgrang, did you ever get to completing this? I've got a need for this now (only __dmb so far), and if you don't have time, I can try to finish it.

Wed, Oct 11, 12:35 PM
mgrang added a comment to rL313701: Revert "[GVNSink] Remove dependency on SmallPtrSet iteration order.".

I do not plan to address these at the moment, because the order is consistent in the pass and doesn't affect correctness or what gets optimized.
If someone else wants to try to make everything reverse order clean, they are welcome to, it's not a priority for me.

I will point out that it looks like in some cases people are fixing symptoms of reverse order issues without paying enough attention to how the logic is actually used. That is going to cause more bugs, not less

Wed, Oct 11, 12:14 PM
mgrang added a comment to rL313717: [Sema][ObjC] Warn about mismatches in attributes between overriding and.

Yes, I'll take a look today, Thank you for letting me know, I didn't know this commit was causing bots to fail.

Do I just have to run cmake with "-DLLVM_REVERSE_ITERATION:BOOL=ON" to reproduce the failure on my machine?

Wed, Oct 11, 12:07 PM
mgrang added a comment to rL313717: [Sema][ObjC] Warn about mismatches in attributes between overriding and.

@ahatanak This patch causes the following make check failure in the reverse iteration bot:
http://lab.llvm.org:8011/builders/reverse-iteration

Wed, Oct 11, 11:07 AM
mgrang updated subscribers of rL313701: Revert "[GVNSink] Remove dependency on SmallPtrSet iteration order.".
Wed, Oct 11, 11:05 AM
mgrang added a comment to rL313701: Revert "[GVNSink] Remove dependency on SmallPtrSet iteration order.".

This revert causes the following make check failures in the reverse iteration bot:
http://lab.llvm.org:8011/builders/reverse-iteration

Wed, Oct 11, 11:04 AM

Mon, Sep 25

mgrang accepted D38011: [zorg] Update the scheduler for the reverse iterator builder.

LGTM.

Mon, Sep 25, 5:02 AM

Sep 18 2017

mgrang added a comment to D38011: [zorg] Update the scheduler for the reverse iterator builder.

LGTM.

Sep 18 2017, 5:28 PM

Sep 15 2017

mgrang committed rL313388: [llvm] Fix some typos. NFC..
[llvm] Fix some typos. NFC.
Sep 15 2017, 1:03 PM
mgrang closed D37922: [llvm] Fix some typos. NFC. by committing rL313388: [llvm] Fix some typos. NFC..
Sep 15 2017, 1:03 PM
mgrang added a comment to D37922: [llvm] Fix some typos. NFC..

LGTM. Thanks, Mandeep. These type of changes generally don't require pre-approval, btw.

Sep 15 2017, 12:59 PM
mgrang created D37922: [llvm] Fix some typos. NFC..
Sep 15 2017, 12:48 PM

Sep 7 2017

mgrang abandoned D26214: [llvm] Implement support for -defsym assembler option.

Patch no longer needed/valid.

Sep 7 2017, 11:00 AM
mgrang abandoned D27745: [llvm] Turn off reverse iteration of SmallPtrSet by default.

Patch no longer valid.

Sep 7 2017, 11:00 AM
mgrang added a comment to D26214: [llvm] Implement support for -defsym assembler option.

Patch no longer needed/valid.

Sep 7 2017, 11:00 AM
mgrang abandoned D25891: [llvm] Convert iterable SmallPtrSet's to SmallSetVector's in Codegen.

No longer needed.

Sep 7 2017, 10:57 AM

Sep 6 2017

mgrang added inline comments to D29934: [RISCV 12/n] Codegen support for memory operations.
Sep 6 2017, 5:34 PM
mgrang added inline comments to D29933: [RISCV 11/n] Initial codegen support for ALU operations.
Sep 6 2017, 5:32 PM
mgrang added inline comments to D29937: [RISCV 15/n] Implement lowering of ISD::SELECT_CC.
Sep 6 2017, 5:15 PM
mgrang added inline comments to D23568: [RISCV 10/10] Add common fixups and relocations.
Sep 6 2017, 5:10 PM
mgrang added inline comments to D23566: [RISCV 8/10] Add support for all RV32I instructions.
Sep 6 2017, 4:55 PM
mgrang committed rL312677: [StaticAnalyzer] Fix failures due to the iteration order of ExplodedNode.
[StaticAnalyzer] Fix failures due to the iteration order of ExplodedNode
Sep 6 2017, 3:56 PM
mgrang closed D37400: [StaticAnalyzer] Fix failures due to the iteration order of ExplodedNode by committing rL312677: [StaticAnalyzer] Fix failures due to the iteration order of ExplodedNode.
Sep 6 2017, 3:56 PM
mgrang added inline comments to D37400: [StaticAnalyzer] Fix failures due to the iteration order of ExplodedNode.
Sep 6 2017, 3:52 PM
mgrang updated the diff for D37400: [StaticAnalyzer] Fix failures due to the iteration order of ExplodedNode.

Addressed comments.

Sep 6 2017, 3:51 PM
mgrang committed rL312667: [docs] Add a note on iteration of unordered containers to coding standards.
[docs] Add a note on iteration of unordered containers to coding standards
Sep 6 2017, 1:21 PM
mgrang closed D37525: [docs] Add a note on iteration of unordered containers to coding standards by committing rL312667: [docs] Add a note on iteration of unordered containers to coding standards.
Sep 6 2017, 1:21 PM
mgrang updated the diff for D37525: [docs] Add a note on iteration of unordered containers to coding standards.

Addressed comments.

Sep 6 2017, 1:12 PM
mgrang updated the diff for D37525: [docs] Add a note on iteration of unordered containers to coding standards.
Sep 6 2017, 12:35 PM
mgrang added inline comments to D37525: [docs] Add a note on iteration of unordered containers to coding standards.
Sep 6 2017, 12:32 PM
mgrang updated the diff for D37525: [docs] Add a note on iteration of unordered containers to coding standards.

Made changes in the text based on comments:

Sep 6 2017, 12:31 PM
mgrang created D37525: [docs] Add a note on iteration of unordered containers to coding standards.
Sep 6 2017, 11:55 AM
mgrang added a reviewer for D37400: [StaticAnalyzer] Fix failures due to the iteration order of ExplodedNode: nikhgupt.
Sep 6 2017, 11:04 AM
mgrang added a comment to D37400: [StaticAnalyzer] Fix failures due to the iteration order of ExplodedNode.

Ping for reviews please.

Sep 6 2017, 10:26 AM

Sep 5 2017

mgrang committed rL312574: [unittests] Add reverse iteration unit test for pointer-like keys.
[unittests] Add reverse iteration unit test for pointer-like keys
Sep 5 2017, 1:41 PM
mgrang closed D37241: [unittests] Add reverse iteration unit test for pointer-like keys by committing rL312574: [unittests] Add reverse iteration unit test for pointer-like keys.
Sep 5 2017, 1:41 PM
mgrang added inline comments to D37241: [unittests] Add reverse iteration unit test for pointer-like keys.
Sep 5 2017, 12:55 PM
mgrang updated the diff for D37241: [unittests] Add reverse iteration unit test for pointer-like keys.

Addressed comments.

Sep 5 2017, 12:50 PM

Sep 3 2017

mgrang updated the diff for D37400: [StaticAnalyzer] Fix failures due to the iteration order of ExplodedNode.

I had accidentally pushed a wrong patch to this commit. Fixed it now.

Sep 3 2017, 9:21 PM
mgrang updated the diff for D37241: [unittests] Add reverse iteration unit test for pointer-like keys.

NFC. Made the static_assert the first statement in the test.

Sep 3 2017, 9:19 PM
mgrang updated the diff for D37400: [StaticAnalyzer] Fix failures due to the iteration order of ExplodedNode.
Sep 3 2017, 9:18 PM
mgrang added inline comments to D37241: [unittests] Add reverse iteration unit test for pointer-like keys.
Sep 3 2017, 12:06 AM
mgrang updated the diff for D37241: [unittests] Add reverse iteration unit test for pointer-like keys.

Added DenseMap test for pointer-like keys.

Sep 3 2017, 12:00 AM

Sep 1 2017

mgrang added a comment to D37400: [StaticAnalyzer] Fix failures due to the iteration order of ExplodedNode.

The thing I am concerned with here is whether changing SmallPtrSet to a SetVector can potentially slow down the Static Analyzer? ExplodedNode seem to be used heavily in the analyzer and I can see it being iterated upon in several places.

Sep 1 2017, 2:21 PM
mgrang created D37400: [StaticAnalyzer] Fix failures due to the iteration order of ExplodedNode.
Sep 1 2017, 2:19 PM

Aug 31 2017

mgrang committed rL312273: [polly] Fix non-deterministic output due to iteration of unordered ScopArrayInfo.
[polly] Fix non-deterministic output due to iteration of unordered ScopArrayInfo
Aug 31 2017, 1:11 PM
mgrang closed D37349: [polly] Fix non-deterministic output due to iteration of unordered ScopArrayInfo by committing rL312273: [polly] Fix non-deterministic output due to iteration of unordered ScopArrayInfo.
Aug 31 2017, 1:11 PM
mgrang added inline comments to D37349: [polly] Fix non-deterministic output due to iteration of unordered ScopArrayInfo.
Aug 31 2017, 1:09 PM
mgrang updated the diff for D37349: [polly] Fix non-deterministic output due to iteration of unordered ScopArrayInfo.
Aug 31 2017, 1:08 PM
mgrang created D37349: [polly] Fix non-deterministic output due to iteration of unordered ScopArrayInfo.
Aug 31 2017, 12:39 PM

Aug 29 2017

mgrang closed D37284: [cfi] Fixed non-determinism in codegen due to DenseSet iteration order.
Aug 29 2017, 9:50 PM
mgrang committed rL312098: [cfi] Fixed non-determinism in codegen due to DenseSet iteration order.
[cfi] Fixed non-determinism in codegen due to DenseSet iteration order
Aug 29 2017, 9:48 PM
mgrang added a comment to D37284: [cfi] Fixed non-determinism in codegen due to DenseSet iteration order.

Do you think using SetVector instead of DenseSet will impact compile-time? The other option we have is to add the TypeIds into a SmallVector and sort it before iteration.

Aug 29 2017, 6:12 PM
mgrang added a comment to D37284: [cfi] Fixed non-determinism in codegen due to DenseSet iteration order.

This will fix the following unit tests which failed in the reverse iteration buildbot (http://lab.llvm.org:8011/builders/reverse-iteration/builds/23/steps/check_all/logs/stdio)

Aug 29 2017, 6:10 PM
mgrang created D37284: [cfi] Fixed non-determinism in codegen due to DenseSet iteration order.
Aug 29 2017, 6:08 PM

Aug 28 2017

mgrang created D37241: [unittests] Add reverse iteration unit test for pointer-like keys.
Aug 28 2017, 6:12 PM
mgrang added a comment to D37204: [AArch64] Support COFF linker directives.

LGTM.

Aug 28 2017, 10:44 AM

Aug 24 2017

mgrang committed rL311741: [unittests] Remove reverse iteration tests which use pointer-like keys.
[unittests] Remove reverse iteration tests which use pointer-like keys
Aug 24 2017, 6:12 PM
mgrang closed D37128: [unittests] Remove reverse iteration tests which use pointer-like keys by committing rL311741: [unittests] Remove reverse iteration tests which use pointer-like keys.
Aug 24 2017, 6:12 PM
mgrang accepted D37128: [unittests] Remove reverse iteration tests which use pointer-like keys.

This is needed to un-break the bots. Will go ahead and commit this.

Aug 24 2017, 6:08 PM
mgrang updated the diff for D37128: [unittests] Remove reverse iteration tests which use pointer-like keys.
Aug 24 2017, 6:07 PM
mgrang added a comment to D37128: [unittests] Remove reverse iteration tests which use pointer-like keys.

This test causes failure on the bots: http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/4861/steps/test-stage1-compiler/logs/stdio

Aug 24 2017, 5:13 PM
mgrang added a reviewer for D37128: [unittests] Remove reverse iteration tests which use pointer-like keys: efriedma.
Aug 24 2017, 5:13 PM
mgrang created D37128: [unittests] Remove reverse iteration tests which use pointer-like keys.
Aug 24 2017, 5:13 PM
mgrang committed rL311730: [ADT] Enable reverse iteration for DenseMap.
[ADT] Enable reverse iteration for DenseMap
Aug 24 2017, 4:04 PM
mgrang closed D35043: [ADT] Enable reverse iteration for DenseMap by committing rL311730: [ADT] Enable reverse iteration for DenseMap.
Aug 24 2017, 4:03 PM
mgrang added a comment to D36386: [clang] Remove unit test which uses reverse-iterate flag.

sounds good - so long as other tests would fail if the fix this test was testing wasn't present (on a reverse iteration enabled build)

Aug 24 2017, 3:45 PM
mgrang committed rL311720: [clang] Remove unit test which uses reverse-iterate flag.
[clang] Remove unit test which uses reverse-iterate flag
Aug 24 2017, 3:41 PM
mgrang closed D36386: [clang] Remove unit test which uses reverse-iterate flag by committing rL311720: [clang] Remove unit test which uses reverse-iterate flag.
Aug 24 2017, 3:41 PM
mgrang added a comment to D35043: [ADT] Enable reverse iteration for DenseMap.

@dblaikie Could you please take a look at this? If you have no objections then can we merge this?

Aug 24 2017, 11:29 AM

Aug 23 2017

mgrang updated the diff for D35043: [ADT] Enable reverse iteration for DenseMap.

Minor styling fixes - changed <typename>* to <typename> *.

Aug 23 2017, 10:50 AM

Aug 21 2017

mgrang updated the diff for D35043: [ADT] Enable reverse iteration for DenseMap.

#Included PointerLikeTypeTraits.h in ReverseIteration.h.

Aug 21 2017, 1:08 PM

Aug 17 2017

mgrang abandoned D36846: [polly] Define PointerLikeTypeTraits as struct in response to related llvm change.

I see this has already been done in https://reviews.llvm.org/rL310667. My sources seem to have been outdated. Abandoning this one.

Aug 17 2017, 1:39 PM
mgrang created D36846: [polly] Define PointerLikeTypeTraits as struct in response to related llvm change.
Aug 17 2017, 1:26 PM
mgrang updated the diff for D35043: [ADT] Enable reverse iteration for DenseMap.

Adopted @dblaikie 's changes for pointer-like traits.

Aug 17 2017, 1:23 PM
mgrang updated the diff for D36386: [clang] Remove unit test which uses reverse-iterate flag.
Aug 17 2017, 1:23 PM

Aug 12 2017

mgrang added a comment to D35043: [ADT] Enable reverse iteration for DenseMap.

Probably a layering violation to include this here. Also seems like a narrow solution - would require more special casing here for other types that are like these two whenever they might get used in a map eventually, etc.

Yes, this is true. But I cannot think of a way of overcoming this.

Aug 12 2017, 1:15 PM
mgrang updated the diff for D35043: [ADT] Enable reverse iteration for DenseMap.

Addressed comments in the unit test.
Moved unittests/ADT/ReverseIteration.cpp to unittests/Support/ReverseIteration.cpp.

Aug 12 2017, 1:09 PM

Aug 9 2017

mgrang committed rL310502: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb.
[COFF, ARM64] Add MS builtins __dmb, __dsb, __isb
Aug 9 2017, 10:59 AM
mgrang closed D36110: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb by committing rL310502: [COFF, ARM64] Add MS builtins __dmb, __dsb, __isb.
Aug 9 2017, 10:59 AM
mgrang updated the diff for D35043: [ADT] Enable reverse iteration for DenseMap.

Addressed comments.
Checked if type is pointer-like without adding a new trait. Instead used PointerLikeTypeTraits::NumLowBitsAvailable.

Aug 9 2017, 1:40 AM

Aug 7 2017

mgrang added a comment to D36386: [clang] Remove unit test which uses reverse-iterate flag.

This patch does 3 things:

Aug 7 2017, 12:08 PM
mgrang added a comment to D36105: [AArch64] Ignore stdcall and similar on aarch64/windows.

Ping @mgrang, can you check the above with MSVC? I'd like to move forward with this in one form or another.

Aug 7 2017, 11:42 AM

Aug 6 2017

mgrang added a comment to D35043: [ADT] Enable reverse iteration for DenseMap.

We removed -reverse-iterate flag and the base definition for PointerLikeTypeTraits here, we need https://reviews.llvm.org/D36386
which removes clang unit test which used -reverse-iterate and marks member functions of PointerLikeTypeTraits
as public to get past a compilation error.

Aug 6 2017, 10:43 PM
mgrang created D36386: [clang] Remove unit test which uses reverse-iterate flag.
Aug 6 2017, 10:39 PM
mgrang updated the diff for D35043: [ADT] Enable reverse iteration for DenseMap.
Aug 6 2017, 10:26 PM
mgrang added inline comments to D35043: [ADT] Enable reverse iteration for DenseMap.
Aug 6 2017, 11:52 AM
mgrang added inline comments to D35043: [ADT] Enable reverse iteration for DenseMap.
Aug 6 2017, 2:16 AM
mgrang updated the diff for D35043: [ADT] Enable reverse iteration for DenseMap.
Aug 6 2017, 2:11 AM
mgrang updated the diff for D35043: [ADT] Enable reverse iteration for DenseMap.

Addressed comments.

Aug 6 2017, 2:09 AM
mgrang accepted D36363: [test] Remove an unintentional -x cl flag in an aarch64-windows test.

LGTM.

Aug 6 2017, 12:03 AM

Aug 2 2017

mgrang accepted D36203: [zorg] Add buildbot with reverse iteration enabled.
Aug 2 2017, 12:26 PM

Aug 1 2017

mgrang added a comment to D36203: [zorg] Add buildbot with reverse iteration enabled.

LGTM. However, I would wait for someone more aware of buildbots to +1 this.

Aug 1 2017, 6:22 PM
mgrang added a comment to D36203: [zorg] Add buildbot with reverse iteration enabled.

Added Victor Leschuk as reviewer since Galina is on vacation.

Aug 1 2017, 6:22 PM