mgrang (Mandeep Singh Grang)
http://livgently.com

Projects

User does not belong to any projects.

User Details

User Since
Jan 28 2015, 2:26 PM (197 w, 6 d)

Recent Activity

Yesterday

mgrang updated the diff for D54359: [InstCombine] Remove a couple of asserts based on incorrect assumptions.

Addressed comments.

Tue, Nov 13, 11:42 AM
mgrang added a comment to D54359: [InstCombine] Remove a couple of asserts based on incorrect assumptions.

@craig.topper Could you please review this? This is a blocker for our internal release.

Tue, Nov 13, 10:51 AM

Sun, Nov 11

mgrang updated the diff for D54359: [InstCombine] Remove a couple of asserts based on incorrect assumptions.

Simplified unit test.

Sun, Nov 11, 11:17 AM

Fri, Nov 9

mgrang updated the summary of D54359: [InstCombine] Remove a couple of asserts based on incorrect assumptions.
Fri, Nov 9, 3:05 PM
mgrang added a comment to D54359: [InstCombine] Remove a couple of asserts based on incorrect assumptions.

Consider this case:

Fri, Nov 9, 3:03 PM
mgrang created D54359: [InstCombine] Remove a couple of asserts based on incorrect assumptions.
Fri, Nov 9, 3:03 PM

Thu, Nov 8

mgrang committed rL346469: [COFF, ARM64] Add support for MSVC buffer security check.
[COFF, ARM64] Add support for MSVC buffer security check
Thu, Nov 8, 6:51 PM
mgrang closed D54248: [COFF, ARM64] Add support for MSVC buffer security check.
Thu, Nov 8, 6:51 PM
mgrang added inline comments to D53540: [COFF, ARM64] Implement support for SEH extensions __try/__except/__finally.
Thu, Nov 8, 12:14 PM
mgrang added inline comments to D53540: [COFF, ARM64] Implement support for SEH extensions __try/__except/__finally.
Thu, Nov 8, 11:05 AM
mgrang added a comment to D54248: [COFF, ARM64] Add support for MSVC buffer security check.

Is there any existing test case for the mingw mode of the stack protector for aarch64? If not, can you add one at the same time, to show that it doesn't change with this patch (i.e. still uses __stack_chk_*).

Thu, Nov 8, 11:01 AM

Wed, Nov 7

mgrang created D54248: [COFF, ARM64] Add support for MSVC buffer security check.
Wed, Nov 7, 5:53 PM
mgrang committed rL346337: [LoopSink] Do not sink instructions into non-cold blocks.
[LoopSink] Do not sink instructions into non-cold blocks
Wed, Nov 7, 10:28 AM
mgrang closed D54181: [LoopSink] Do not sink instructions into non-cold blocks.
Wed, Nov 7, 10:28 AM

Tue, Nov 6

mgrang updated the diff for D54181: [LoopSink] Do not sink instructions into non-cold blocks.

Addressed comments.

Tue, Nov 6, 3:49 PM
mgrang created D54181: [LoopSink] Do not sink instructions into non-cold blocks.
Tue, Nov 6, 1:16 PM

Mon, Nov 5

mgrang committed rC346208: [COFF, ARM64] Implement InterlockedDecrement*_* builtins.
[COFF, ARM64] Implement InterlockedDecrement*_* builtins
Mon, Nov 5, 9:11 PM
mgrang committed rL346208: [COFF, ARM64] Implement InterlockedDecrement*_* builtins.
[COFF, ARM64] Implement InterlockedDecrement*_* builtins
Mon, Nov 5, 9:10 PM
mgrang closed D54068: [COFF, ARM64] Implement InterlockedDecrement*_* builtins.
Mon, Nov 5, 9:10 PM
mgrang committed rL346207: [COFF, ARM64] Implement InterlockedIncrement*_* builtins.
[COFF, ARM64] Implement InterlockedIncrement*_* builtins
Mon, Nov 5, 9:08 PM
mgrang committed rC346207: [COFF, ARM64] Implement InterlockedIncrement*_* builtins.
[COFF, ARM64] Implement InterlockedIncrement*_* builtins
Mon, Nov 5, 9:08 PM
mgrang closed D54067: [COFF, ARM64] Implement InterlockedIncrement*_* builtins.
Mon, Nov 5, 9:08 PM
mgrang committed rC346206: [COFF, ARM64] Implement InterlockedAnd*_* builtins.
[COFF, ARM64] Implement InterlockedAnd*_* builtins
Mon, Nov 5, 9:05 PM
mgrang closed D54066: [COFF, ARM64] Implement InterlockedAnd*_* builtins.
Mon, Nov 5, 9:05 PM
mgrang committed rL346206: [COFF, ARM64] Implement InterlockedAnd*_* builtins.
[COFF, ARM64] Implement InterlockedAnd*_* builtins
Mon, Nov 5, 9:05 PM
mgrang committed rC346205: [COFF, ARM64] Implement InterlockedXor*_* builtins.
[COFF, ARM64] Implement InterlockedXor*_* builtins
Mon, Nov 5, 8:58 PM
mgrang committed rL346205: [COFF, ARM64] Implement InterlockedXor*_* builtins.
[COFF, ARM64] Implement InterlockedXor*_* builtins
Mon, Nov 5, 8:57 PM
mgrang closed D54063: [COFF, ARM64] Implement InterlockedOr*_* builtins.
Mon, Nov 5, 8:53 PM
mgrang committed rL346192: Revert "[COFF, ARM64] Implement InterlockedXor*_* builtins".
Revert "[COFF, ARM64] Implement InterlockedXor*_* builtins"
Mon, Nov 5, 5:17 PM
mgrang committed rC346192: Revert "[COFF, ARM64] Implement InterlockedXor*_* builtins".
Revert "[COFF, ARM64] Implement InterlockedXor*_* builtins"
Mon, Nov 5, 5:16 PM
mgrang committed rL346191: [COFF, ARM64] Implement InterlockedXor*_* builtins.
[COFF, ARM64] Implement InterlockedXor*_* builtins
Mon, Nov 5, 5:15 PM
mgrang committed rC346191: [COFF, ARM64] Implement InterlockedXor*_* builtins.
[COFF, ARM64] Implement InterlockedXor*_* builtins
Mon, Nov 5, 5:15 PM
mgrang closed D54065: [COFF, ARM64] Implement InterlockedXor*_* builtins.
Mon, Nov 5, 5:14 PM
mgrang committed rL346190: [COFF, ARM64] Implement InterlockedOr*_* builtins.
[COFF, ARM64] Implement InterlockedOr*_* builtins
Mon, Nov 5, 5:14 PM
mgrang committed rC346190: [COFF, ARM64] Implement InterlockedOr*_* builtins.
[COFF, ARM64] Implement InterlockedOr*_* builtins
Mon, Nov 5, 5:14 PM
mgrang committed rL346189: [COFF, ARM64] Implement InterlockedCompareExchange*_* builtins.
[COFF, ARM64] Implement InterlockedCompareExchange*_* builtins
Mon, Nov 5, 4:39 PM
mgrang committed rC346189: [COFF, ARM64] Implement InterlockedCompareExchange*_* builtins.
[COFF, ARM64] Implement InterlockedCompareExchange*_* builtins
Mon, Nov 5, 4:39 PM
mgrang closed D54062: [COFF, ARM64] Implement InterlockedCompareExchange*_* builtins.
Mon, Nov 5, 4:39 PM
mgrang updated the diff for D54062: [COFF, ARM64] Implement InterlockedCompareExchange*_* builtins.
Mon, Nov 5, 4:24 PM
mgrang abandoned D44410: [GlobalISel] Extend booleans based on the target's BooleanContent.

This is fixed in D47425. Abandoning this patch.

Mon, Nov 5, 12:55 PM
mgrang added inline comments to D54062: [COFF, ARM64] Implement InterlockedCompareExchange*_* builtins.
Mon, Nov 5, 12:33 PM

Fri, Nov 2

mgrang created D54068: [COFF, ARM64] Implement InterlockedDecrement*_* builtins.
Fri, Nov 2, 10:41 PM
mgrang created D54067: [COFF, ARM64] Implement InterlockedIncrement*_* builtins.
Fri, Nov 2, 10:04 PM
mgrang created D54066: [COFF, ARM64] Implement InterlockedAnd*_* builtins.
Fri, Nov 2, 9:32 PM
mgrang created D54065: [COFF, ARM64] Implement InterlockedXor*_* builtins.
Fri, Nov 2, 9:20 PM
mgrang created D54063: [COFF, ARM64] Implement InterlockedOr*_* builtins.
Fri, Nov 2, 6:13 PM
mgrang created D54062: [COFF, ARM64] Implement InterlockedCompareExchange*_* builtins.
Fri, Nov 2, 5:40 PM
mgrang committed rC346044: [COFF, ARM64] Implement InterlockedExchange*_* builtins.
[COFF, ARM64] Implement InterlockedExchange*_* builtins
Fri, Nov 2, 2:20 PM
mgrang committed rL346044: [COFF, ARM64] Implement InterlockedExchange*_* builtins.
[COFF, ARM64] Implement InterlockedExchange*_* builtins
Fri, Nov 2, 2:20 PM
mgrang closed D54046: [COFF, ARM64] Implement InterlockedExchange*_* builtins.
Fri, Nov 2, 2:20 PM
mgrang created D54046: [COFF, ARM64] Implement InterlockedExchange*_* builtins.
Fri, Nov 2, 1:35 PM
mgrang committed rC346024: [COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.sponentry.
[COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.sponentry
Fri, Nov 2, 11:24 AM
mgrang committed rL346024: [COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.sponentry.
[COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.sponentry
Fri, Nov 2, 11:24 AM
mgrang closed D53998: [COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.sponentry.
Fri, Nov 2, 11:24 AM
mgrang accepted D53998: [COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.sponentry.

Since this is the same as D53684, we can go ahead and close this.

Fri, Nov 2, 11:12 AM

Thu, Nov 1

mgrang closed D53997: [gold-plugin] Fix a bunch of build warnings.
Thu, Nov 1, 4:38 PM
mgrang committed rL345910: [gold-plugin] Fix a bunch of build warnings.
[gold-plugin] Fix a bunch of build warnings
Thu, Nov 1, 4:36 PM
mgrang committed rL345909: [COFF, ARM64] Implement Intrinsic.sponentry for AArch64.
[COFF, ARM64] Implement Intrinsic.sponentry for AArch64
Thu, Nov 1, 4:24 PM
mgrang closed D53996: [COFF, ARM64] Implement Intrinsic.sponentry for AArch64.
Thu, Nov 1, 4:24 PM
mgrang updated the diff for D53997: [gold-plugin] Fix a bunch of build warnings.
Thu, Nov 1, 4:23 PM
mgrang committed rL345892: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic.
[COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic
Thu, Nov 1, 2:27 PM
mgrang closed D53962: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic.
Thu, Nov 1, 2:27 PM
mgrang removed a dependency for D53962: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic: D53960: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic.
Thu, Nov 1, 2:25 PM
mgrang removed a dependent revision for D53960: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic: D53962: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic.
Thu, Nov 1, 2:25 PM
mgrang updated the diff for D53962: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic.

The previous version failed to apply cleanly. So had to rebase.

Thu, Nov 1, 2:22 PM
mgrang created D53997: [gold-plugin] Fix a bunch of build warnings.
Thu, Nov 1, 2:20 PM
mgrang added a comment to D53997: [gold-plugin] Fix a bunch of build warnings.

Fixed the following warnings:

Thu, Nov 1, 2:20 PM
mgrang updated the diff for D53962: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic.
Thu, Nov 1, 1:48 PM
mgrang committed rC345872: Revert "[COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic..
Revert "[COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.
Thu, Nov 1, 11:40 AM
mgrang committed rL345872: Revert "[COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic..
Revert "[COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.
Thu, Nov 1, 11:40 AM
mgrang committed rL345863: Revert "[COFF, ARM64] Implement Intrinsic.sponentry for AArch64".
Revert "[COFF, ARM64] Implement Intrinsic.sponentry for AArch64"
Thu, Nov 1, 10:57 AM
mgrang updated subscribers of rL345791: [COFF, ARM64] Implement Intrinsic.sponentry for AArch64.
Thu, Nov 1, 10:57 AM

Wed, Oct 31

mgrang closed D53960: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic.
Wed, Oct 31, 6:40 PM
mgrang committed rC345808: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic.
[COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic
Wed, Oct 31, 6:38 PM
mgrang committed rL345808: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic.
[COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic
Wed, Oct 31, 6:38 PM
mgrang added inline comments to D53962: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic.
Wed, Oct 31, 5:59 PM
mgrang updated the diff for D53962: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic.
Wed, Oct 31, 5:49 PM
mgrang added a dependency for D53962: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic: D53960: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic.
Wed, Oct 31, 5:42 PM
mgrang added a dependent revision for D53960: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic: D53962: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic.
Wed, Oct 31, 5:42 PM
mgrang added a comment to D53962: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic.
Wed, Oct 31, 5:41 PM
mgrang created D53962: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic.
Wed, Oct 31, 5:41 PM
mgrang created D53960: [COFF, ARM64] Implement llvm.addressofreturnaddress intrinsic.
Wed, Oct 31, 5:41 PM
mgrang committed rC345792: [COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.sponentry.
[COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.sponentry
Wed, Oct 31, 4:20 PM
mgrang committed rL345792: [COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.sponentry.
[COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.sponentry
Wed, Oct 31, 4:20 PM
mgrang closed D53684: [COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.sponentry.
Wed, Oct 31, 4:20 PM
mgrang committed rL345791: [COFF, ARM64] Implement Intrinsic.sponentry for AArch64.
[COFF, ARM64] Implement Intrinsic.sponentry for AArch64
Wed, Oct 31, 4:18 PM
mgrang closed D53673: [COFF, ARM64] Implement Intrinsic.sponentry for AArch64.
Wed, Oct 31, 4:18 PM
mgrang added a dependency for D53540: [COFF, ARM64] Implement support for SEH extensions __try/__except/__finally: D53541: [COFF, ARM64] Support SEH for ARM64 Windows.
Wed, Oct 31, 12:54 PM
mgrang added a comment to D53540: [COFF, ARM64] Implement support for SEH extensions __try/__except/__finally.

Will push more comprehensive tests for ARM64 SEH soon.

Wed, Oct 31, 12:54 PM
mgrang added a dependent revision for D53541: [COFF, ARM64] Support SEH for ARM64 Windows: D53540: [COFF, ARM64] Implement support for SEH extensions __try/__except/__finally.
Wed, Oct 31, 12:54 PM
mgrang updated the diff for D53540: [COFF, ARM64] Implement support for SEH extensions __try/__except/__finally.
Wed, Oct 31, 12:52 PM
mgrang updated the diff for D53541: [COFF, ARM64] Support SEH for ARM64 Windows.

Updated the patch with the following changes:

Wed, Oct 31, 12:44 PM
mgrang added inline comments to D53051: [llvm-tapi] initial commit, supports ELF text stubs.
Wed, Oct 31, 12:02 PM
mgrang added inline comments to D53945: [TextAPI] TBD Reader/Writer.
Wed, Oct 31, 12:00 PM

Tue, Oct 30

mgrang committed rL345641: [COFF, ARM64] Make sure to forward arguments from vararg to musttail vararg.
[COFF, ARM64] Make sure to forward arguments from vararg to musttail vararg
Tue, Oct 30, 1:48 PM
mgrang closed D53843: Make sure to forward arguments from vararg to musttail vararg.
Tue, Oct 30, 1:48 PM

Mon, Oct 29

mgrang retitled D53843: Make sure to forward arguments from vararg to musttail vararg from Make sure to forward arguments from vararg to musttail vararg to [COFF, ARM64] Make sure to forward arguments from vararg to musttail vararg.
Mon, Oct 29, 4:06 PM

Wed, Oct 24

mgrang added inline comments to D53673: [COFF, ARM64] Implement Intrinsic.sponentry for AArch64.
Wed, Oct 24, 3:01 PM
mgrang retitled D53673: [COFF, ARM64] Implement Intrinsic.sponentry for AArch64 from Implement Intrinsic.sponentry for AArch64 to [COFF, ARM64] Implement Intrinsic.sponentry for AArch64.
Wed, Oct 24, 3:01 PM
mgrang added reviewers for D53673: [COFF, ARM64] Implement Intrinsic.sponentry for AArch64: rnk, compnerd, mstorsjo, efriedma.
Wed, Oct 24, 2:43 PM