In D102107#3417452, @dhruvachak wrote:

I added https://github.com/llvm/llvm-project/issues/54654 documenting what I found when testing this patch on amdgpu.

@ggeorgakoudis Can you please rebase this patch on top of main? Thanks.

In D120573#3415517, @abidmalikwaterloo wrote:

Are you going to work on it? Just confirming. I am working on D122255. The code generation part for the dynamic condition is useful. However, my understanding is that it is not according to the OpenMP 5.2 specification. Correct me if I am wrong.

Fix tentative parsing reverting
Fix device codegen for metadirectives

I'm not expert on this to review but I'm interested as a user. @samvv are you still working on this? Do you have any input from the community?

Rebase, address comment, update few tests

Ping @vsk :)

Ping!

Update tests
Fix for attributes to kmpc_alloc_aggregate_arg
Do not emit allocations if there are no arguments in the aggregate

TODO update tests

Update the interface for allocating/sharing the struct aggregate
Simplify invoking tasks

Update for comments

LGTM

In D102107#3029825, @pdhaliwal wrote:

Apologies for late reply. Most of the tests now do not try to call malloc, so no page fault errors. But all of them are producing wrong results. For e.g. declare_mapper_target.cpp produces Sum = 132608 with the patch applied. Similarly for other tests as well. So don't know what's happening yet.

In D102107#3028386, @ronlieb wrote:

i backed up to your reverted patch, and applied this one.
I see some new errors

libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_target.cpp
libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_target_data.cpp
libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_target_data_enter_exit.cpp
libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_target_update.cpp
libomptarget :: amdgcn-amd-amdhsa :: offloading/parallel_offloading_map.cpp
libomptarget :: amdgcn-amd-amdhsa :: offloading/taskloop_offload_nowait.cpp

Dont know if Jon is around, so i will ask Singh @pdhaliwal if he can dig into it a bit more.

@pdhaliwal @JonChesterfield @ronlieb I updated the aggregate argument memory allocation to use an alloca instead of malloc'ing in SPMD mode, which should resolve your issue. Could someone please test the updated patch and give me feedback before landing?

Update memory allocation for aggregate argument.
Introduce runtime interface to allocate from local memory,
when in SPMD mode, or heap, when in generic.

Ping @vsk

In D102107#3013233, @ronlieb wrote:

seeing buildbot failures after this patch landed https://lab.llvm.org/staging/#/builders/183/builds/1598

Rebase and update tests

Fix for clang-tidy

Update interface for comments

Remove unnecessary comments.

Add previous, upper bound to aggregate for combined distributed directives.
Update tests.

LGTM, waiting for tests

LGTM, clang-format, does it need tests?

Great! Thanks Joseph.

Rebase, update tests

Rebase, update tests

Add tests

Code cleanup

Update for sensible access to __kmpc_is_spmd_guarded_exec_mode

Fix for comments

Thanks @GMNGeoffrey, fixed in https://github.com/llvm/llvm-project/commit/eaab880e45860192e5e52dba7f694f639f4dbcb7

Fix for comments

Add tests

LGTM

Fix for comments

Rebase

Fix for comments

Fix formatting

Fixed in another revision (see description)