Page MenuHomePhabricator

ggeorgakoudis (Giorgis Georgakoudis)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 20 2019, 5:55 PM (131 w, 5 d)

Recent Activity

Mon, Jun 27

ggeorgakoudis committed rWa58fd0bf5c79: Update LLPP notification date (authored by ggeorgakoudis).
Update LLPP notification date
Mon, Jun 27, 11:49 AM · Restricted Project

Tue, Jun 7

ggeorgakoudis committed rW435dd6ba1537: Update submission page for LLPP'22 (authored by ggeorgakoudis).
Update submission page for LLPP'22
Tue, Jun 7, 10:00 AM · Restricted Project

Mon, Jun 6

ggeorgakoudis committed rWeda31d669bb9: Update LLPP'22 webpage (authored by ggeorgakoudis).
Update LLPP'22 webpage
Mon, Jun 6, 12:12 PM · Restricted Project

Apr 28 2022

ggeorgakoudis committed rW1e3ef82239a6: Add LLPP@ICPP 2022 workshop page (authored by ggeorgakoudis).
Add LLPP@ICPP 2022 workshop page
Apr 28 2022, 10:46 AM · Restricted Project

Apr 6 2022

ggeorgakoudis added a comment to D102107: [OpenMP] Codegen aggregate for outlined function captures.

I added https://github.com/llvm/llvm-project/issues/54654 documenting what I found when testing this patch on amdgpu.

@ggeorgakoudis Can you please rebase this patch on top of main? Thanks.

Apr 6 2022, 4:30 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 5 2022

ggeorgakoudis added a comment to D120573: [OpenMP] Support runtime user conditions in metadirective.

Are you going to work on it? Just confirming. I am working on D122255. The code generation part for the dynamic condition is useful. However, my understanding is that it is not according to the OpenMP 5.2 specification. Correct me if I am wrong.

Apr 5 2022, 2:10 PM · Restricted Project, Restricted Project, Restricted Project

Mar 23 2022

ggeorgakoudis added inline comments to D120573: [OpenMP] Support runtime user conditions in metadirective.
Mar 23 2022, 7:11 AM · Restricted Project, Restricted Project, Restricted Project

Mar 9 2022

ggeorgakoudis updated the diff for D120573: [OpenMP] Support runtime user conditions in metadirective.

Fix tentative parsing reverting
Fix device codegen for metadirectives

Mar 9 2022, 10:03 AM · Restricted Project, Restricted Project, Restricted Project

Feb 25 2022

ggeorgakoudis updated the summary of D120573: [OpenMP] Support runtime user conditions in metadirective.
Feb 25 2022, 10:33 AM · Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis requested review of D120573: [OpenMP] Support runtime user conditions in metadirective.
Feb 25 2022, 10:28 AM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2022

ggeorgakoudis added a comment to D102555: [libclang] Enhance support for source-to-source rewriting.

I'm not expert on this to review but I'm interested as a user. @samvv are you still working on this? Do you have any input from the community?

Feb 24 2022, 11:56 PM · Restricted Project

Dec 1 2021

ggeorgakoudis updated the diff for D102107: [OpenMP] Codegen aggregate for outlined function captures.

Rebase, address comment, update few tests

Dec 1 2021, 11:35 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis added a comment to D96854: [CodeExtractor] Enable partial aggregate arguments.

Ping @vsk :)

Dec 1 2021, 9:25 AM · Restricted Project
ggeorgakoudis added a comment to D102107: [OpenMP] Codegen aggregate for outlined function captures.

Ping!

Dec 1 2021, 9:23 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 11 2021

ggeorgakoudis updated the diff for D102107: [OpenMP] Codegen aggregate for outlined function captures.

Update tests
Fix for attributes to kmpc_alloc_aggregate_arg
Do not emit allocations if there are no arguments in the aggregate

Nov 11 2021, 10:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 9 2021

ggeorgakoudis added a comment to D102107: [OpenMP] Codegen aggregate for outlined function captures.

TODO update tests

Nov 9 2021, 7:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis requested review of D102107: [OpenMP] Codegen aggregate for outlined function captures.
Nov 9 2021, 7:44 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis updated the diff for D102107: [OpenMP] Codegen aggregate for outlined function captures.

Update the interface for allocating/sharing the struct aggregate
Simplify invoking tasks

Nov 9 2021, 7:44 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 1 2021

ggeorgakoudis added inline comments to D96854: [CodeExtractor] Enable partial aggregate arguments.
Nov 1 2021, 11:05 AM · Restricted Project
ggeorgakoudis updated the diff for D96854: [CodeExtractor] Enable partial aggregate arguments.

Update for comments

Nov 1 2021, 11:05 AM · Restricted Project
ggeorgakoudis accepted D112892: [OpenMP][FIX] Ensure guarding uses proper global name.
Nov 1 2021, 8:49 AM · Restricted Project
ggeorgakoudis added a comment to D112892: [OpenMP][FIX] Ensure guarding uses proper global name.

LGTM

Nov 1 2021, 8:48 AM · Restricted Project

Sep 29 2021

ggeorgakoudis added a comment to D102107: [OpenMP] Codegen aggregate for outlined function captures.

Apologies for late reply. Most of the tests now do not try to call malloc, so no page fault errors. But all of them are producing wrong results. For e.g. declare_mapper_target.cpp produces Sum = 132608 with the patch applied. Similarly for other tests as well. So don't know what's happening yet.

Sep 29 2021, 10:36 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 28 2021

ggeorgakoudis added a comment to D102107: [OpenMP] Codegen aggregate for outlined function captures.

i backed up to your reverted patch, and applied this one.
I see some new errors

libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_target.cpp
libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_target_data.cpp
libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_target_data_enter_exit.cpp
libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_target_update.cpp
libomptarget :: amdgcn-amd-amdhsa :: offloading/parallel_offloading_map.cpp
libomptarget :: amdgcn-amd-amdhsa :: offloading/taskloop_offload_nowait.cpp

Dont know if Jon is around, so i will ask Singh @pdhaliwal if he can dig into it a bit more.

Sep 28 2021, 5:28 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis added a comment to D102107: [OpenMP] Codegen aggregate for outlined function captures.

@pdhaliwal @JonChesterfield @ronlieb I updated the aggregate argument memory allocation to use an alloca instead of malloc'ing in SPMD mode, which should resolve your issue. Could someone please test the updated patch and give me feedback before landing?

Sep 28 2021, 10:29 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis updated the diff for D102107: [OpenMP] Codegen aggregate for outlined function captures.

Update memory allocation for aggregate argument.
Introduce runtime interface to allocate from local memory,
when in SPMD mode, or heap, when in generic.

Sep 28 2021, 10:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis reopened D102107: [OpenMP] Codegen aggregate for outlined function captures.
Sep 28 2021, 10:01 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 21 2021

ggeorgakoudis added a comment to D96854: [CodeExtractor] Enable partial aggregate arguments.

Ping @vsk

Sep 21 2021, 6:07 PM · Restricted Project
ggeorgakoudis added a reverting change for rG1d66649adf28: [OpenMP] Codegen aggregate for outlined function captures: rGac90dfc43a01: Revert "[OpenMP] Codegen aggregate for outlined function captures".
Sep 21 2021, 1:22 PM
ggeorgakoudis committed rGac90dfc43a01: Revert "[OpenMP] Codegen aggregate for outlined function captures" (authored by ggeorgakoudis).
Revert "[OpenMP] Codegen aggregate for outlined function captures"
Sep 21 2021, 1:22 PM
ggeorgakoudis added a reverting change for D102107: [OpenMP] Codegen aggregate for outlined function captures: rGac90dfc43a01: Revert "[OpenMP] Codegen aggregate for outlined function captures".
Sep 21 2021, 1:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis added a comment to D102107: [OpenMP] Codegen aggregate for outlined function captures.

seeing buildbot failures after this patch landed https://lab.llvm.org/staging/#/builders/183/builds/1598

Sep 21 2021, 11:46 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis closed D102107: [OpenMP] Codegen aggregate for outlined function captures.
Sep 21 2021, 10:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis committed rG1d66649adf28: [OpenMP] Codegen aggregate for outlined function captures (authored by ggeorgakoudis).
[OpenMP] Codegen aggregate for outlined function captures
Sep 21 2021, 10:51 AM
ggeorgakoudis updated the diff for D102107: [OpenMP] Codegen aggregate for outlined function captures.

Rebase and update tests

Sep 21 2021, 10:34 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 20 2021

ggeorgakoudis updated the diff for D102107: [OpenMP] Codegen aggregate for outlined function captures.

Fix for clang-tidy

Sep 20 2021, 5:14 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis added a reviewer for D110114: [OMPIRBuilder] Generate aggregate argument for parallel region outlined functions: jhuber6.
Sep 20 2021, 4:51 PM · Restricted Project, Restricted Project
ggeorgakoudis updated the summary of D110114: [OMPIRBuilder] Generate aggregate argument for parallel region outlined functions.
Sep 20 2021, 4:50 PM · Restricted Project, Restricted Project
ggeorgakoudis requested review of D110114: [OMPIRBuilder] Generate aggregate argument for parallel region outlined functions.
Sep 20 2021, 4:45 PM · Restricted Project, Restricted Project

Sep 17 2021

ggeorgakoudis updated the diff for D96854: [CodeExtractor] Enable partial aggregate arguments.

Update interface for comments

Sep 17 2021, 10:26 AM · Restricted Project

Sep 16 2021

ggeorgakoudis requested review of D102107: [OpenMP] Codegen aggregate for outlined function captures.
Sep 16 2021, 4:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis updated the diff for D102107: [OpenMP] Codegen aggregate for outlined function captures.

Remove unnecessary comments.

Sep 16 2021, 4:57 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis updated the diff for D102107: [OpenMP] Codegen aggregate for outlined function captures.

Add previous, upper bound to aggregate for combined distributed directives.
Update tests.

Sep 16 2021, 4:52 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 15 2021

ggeorgakoudis abandoned D106423: [Attributor] Force simplication callback updates.
Sep 15 2021, 6:18 AM · Restricted Project

Sep 2 2021

ggeorgakoudis accepted D109070: [OpenMP] Group side-effects to improve guarding efficiency.
Sep 2 2021, 1:01 PM · Restricted Project

Sep 1 2021

ggeorgakoudis added a comment to D109070: [OpenMP] Group side-effects to improve guarding efficiency.

LGTM, waiting for tests

Sep 1 2021, 9:35 AM · Restricted Project

Aug 12 2021

ggeorgakoudis committed rG60e643fe05f5: [OpenMP][Fix] Fix disable spmdization option (authored by ggeorgakoudis).
[OpenMP][Fix] Fix disable spmdization option
Aug 12 2021, 5:59 PM
ggeorgakoudis closed D108001: [OpenMP][Fix] Fix disable spmdization option.
Aug 12 2021, 5:59 PM · Restricted Project
ggeorgakoudis updated the summary of D108001: [OpenMP][Fix] Fix disable spmdization option.
Aug 12 2021, 5:57 PM · Restricted Project
ggeorgakoudis updated the summary of D108001: [OpenMP][Fix] Fix disable spmdization option.
Aug 12 2021, 2:59 PM · Restricted Project
ggeorgakoudis added a reviewer for D108001: [OpenMP][Fix] Fix disable spmdization option: jhuber6.
Aug 12 2021, 2:50 PM · Restricted Project
ggeorgakoudis requested review of D108001: [OpenMP][Fix] Fix disable spmdization option.
Aug 12 2021, 2:49 PM · Restricted Project

Aug 11 2021

ggeorgakoudis added a comment to D107178: [OpenMP][C-API] Introduce the OpenMP-IR-Builder C-API.

LGTM, clang-format, does it need tests?

Aug 11 2021, 10:24 AM · Restricted Project

Aug 5 2021

ggeorgakoudis added a comment to D107579: [Attributor]Fix PR51249: Stores from memory intrinsics incorrectly being replaced by undef.

Great! Thanks Joseph.

Aug 5 2021, 11:56 AM · Restricted Project, Restricted Project

Aug 4 2021

ggeorgakoudis committed rG29a3e3dd7bed: [OpenMPOpt] Expand SPMDization with guarding for target parallel regions (authored by ggeorgakoudis).
[OpenMPOpt] Expand SPMDization with guarding for target parallel regions
Aug 4 2021, 11:50 AM
ggeorgakoudis closed D106892: [OpenMPOpt] Expand SPMDization with guarding for target parallel regions.
Aug 4 2021, 11:49 AM · Restricted Project

Aug 3 2021

ggeorgakoudis updated the diff for D106892: [OpenMPOpt] Expand SPMDization with guarding for target parallel regions.

Rebase, update tests

Aug 3 2021, 5:32 PM · Restricted Project

Jul 28 2021

ggeorgakoudis updated the diff for D102107: [OpenMP] Codegen aggregate for outlined function captures.

Rebase, update tests

Jul 28 2021, 2:06 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 27 2021

ggeorgakoudis updated the summary of D106892: [OpenMPOpt] Expand SPMDization with guarding for target parallel regions.
Jul 27 2021, 9:11 PM · Restricted Project
ggeorgakoudis updated the diff for D106892: [OpenMPOpt] Expand SPMDization with guarding for target parallel regions.

Add tests

Jul 27 2021, 9:03 PM · Restricted Project
ggeorgakoudis reopened D102107: [OpenMP] Codegen aggregate for outlined function captures.
Jul 27 2021, 11:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis requested review of D106892: [OpenMPOpt] Expand SPMDization with guarding for target parallel regions.
Jul 27 2021, 10:34 AM · Restricted Project

Jul 24 2021

ggeorgakoudis updated the diff for D106746: [OpenMPOpt] Expand SPMDization with guarding.

Code cleanup

Jul 24 2021, 10:39 AM · Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis retitled D106746: [OpenMPOpt] Expand SPMDization with guarding from [OpenMPOpt][WIP] Expand SPMDization with guarding to [OpenMPOpt] Expand SPMDization with guarding.
Jul 24 2021, 7:51 AM · Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis updated the diff for D106746: [OpenMPOpt] Expand SPMDization with guarding.

Update for sensible access to __kmpc_is_spmd_guarded_exec_mode

Jul 24 2021, 7:50 AM · Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis retitled D106746: [OpenMPOpt] Expand SPMDization with guarding from [OpenMPOpt][WIP] Expand SPMDIzation with guarding to [OpenMPOpt][WIP] Expand SPMDization with guarding.
Jul 24 2021, 6:47 AM · Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis updated the summary of D106746: [OpenMPOpt] Expand SPMDization with guarding.
Jul 24 2021, 6:33 AM · Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis requested review of D106746: [OpenMPOpt] Expand SPMDization with guarding.
Jul 24 2021, 6:19 AM · Restricted Project, Restricted Project, Restricted Project

Jul 23 2021

ggeorgakoudis committed rGf97de4cb0be4: [OpenMPOpt] Move dedup runtime calls after init for target regions (authored by ggeorgakoudis).
[OpenMPOpt] Move dedup runtime calls after init for target regions
Jul 23 2021, 5:54 AM
ggeorgakoudis closed D106556: [OpenMPOpt] Move dedup runtime calls after init for target regions.
Jul 23 2021, 5:54 AM · Restricted Project

Jul 22 2021

ggeorgakoudis added inline comments to D106556: [OpenMPOpt] Move dedup runtime calls after init for target regions.
Jul 22 2021, 7:10 PM · Restricted Project
ggeorgakoudis updated the diff for D106556: [OpenMPOpt] Move dedup runtime calls after init for target regions.

Fix for comments

Jul 22 2021, 7:03 PM · Restricted Project
ggeorgakoudis added a comment to D105634: [OpenMP] Use AAHeapToStack/AAHeapToShared analysis in SPMDization.

Thanks @GMNGeoffrey, fixed in https://github.com/llvm/llvm-project/commit/eaab880e45860192e5e52dba7f694f639f4dbcb7

Jul 22 2021, 6:25 PM · Restricted Project
ggeorgakoudis committed rGeaab880e4586: [Attributor][Fix] Add overrides for AA2HS analysis (authored by ggeorgakoudis).
[Attributor][Fix] Add overrides for AA2HS analysis
Jul 22 2021, 6:22 PM
ggeorgakoudis committed rGf8c40ed8f8e7: [OpenMP] Use AAHeapToStack/AAHeapToShared analysis in SPMDization (authored by ggeorgakoudis).
[OpenMP] Use AAHeapToStack/AAHeapToShared analysis in SPMDization
Jul 22 2021, 6:09 PM
ggeorgakoudis closed D105634: [OpenMP] Use AAHeapToStack/AAHeapToShared analysis in SPMDization.
Jul 22 2021, 6:08 PM · Restricted Project
ggeorgakoudis updated the diff for D105634: [OpenMP] Use AAHeapToStack/AAHeapToShared analysis in SPMDization.

Fix for comments

Jul 22 2021, 3:22 PM · Restricted Project
ggeorgakoudis updated the summary of D106556: [OpenMPOpt] Move dedup runtime calls after init for target regions.
Jul 22 2021, 8:20 AM · Restricted Project
ggeorgakoudis requested review of D106556: [OpenMPOpt] Move dedup runtime calls after init for target regions.
Jul 22 2021, 8:16 AM · Restricted Project

Jul 21 2021

ggeorgakoudis updated the diff for D105634: [OpenMP] Use AAHeapToStack/AAHeapToShared analysis in SPMDization.

Add tests

Jul 21 2021, 6:37 PM · Restricted Project
ggeorgakoudis committed rG3f71b425b208: [Attributor] Preserve BBs and instructions added in AA manifests (authored by ggeorgakoudis).
[Attributor] Preserve BBs and instructions added in AA manifests
Jul 21 2021, 11:27 AM
ggeorgakoudis closed D106383: [Attributor] Preserve BBs and instructions added in AA manifests.
Jul 21 2021, 11:27 AM · Restricted Project
ggeorgakoudis accepted D106460: [OpenMP] Add new execution mode for SPMD execution with Generic semantics.
Jul 21 2021, 11:11 AM · Restricted Project, Restricted Project
ggeorgakoudis added a comment to D106460: [OpenMP] Add new execution mode for SPMD execution with Generic semantics.

LGTM

Jul 21 2021, 11:11 AM · Restricted Project, Restricted Project
ggeorgakoudis added inline comments to D106460: [OpenMP] Add new execution mode for SPMD execution with Generic semantics.
Jul 21 2021, 10:52 AM · Restricted Project, Restricted Project
ggeorgakoudis updated the summary of D106383: [Attributor] Preserve BBs and instructions added in AA manifests.
Jul 21 2021, 10:32 AM · Restricted Project
ggeorgakoudis committed rGb0e06e1fc004: [Attributor][NFC] Modify isAssumedHeapToStack for const argument (authored by ggeorgakoudis).
[Attributor][NFC] Modify isAssumedHeapToStack for const argument
Jul 21 2021, 10:28 AM
ggeorgakoudis closed D106418: [Attributor][NFC] Modify isAssumedHeapToStack for const argument.
Jul 21 2021, 10:28 AM · Restricted Project
ggeorgakoudis committed rG5a682d9b9109: [OpenMP] Expose libomptarget function to get HW thread id (authored by ggeorgakoudis).
[OpenMP] Expose libomptarget function to get HW thread id
Jul 21 2021, 10:26 AM
ggeorgakoudis closed D106323: [OpenMP] Expose libomptarget function to get HW thread id.
Jul 21 2021, 10:26 AM · Restricted Project, Restricted Project
ggeorgakoudis updated the diff for D106383: [Attributor] Preserve BBs and instructions added in AA manifests.

Fix for comments

Jul 21 2021, 1:56 AM · Restricted Project
ggeorgakoudis updated the diff for D106418: [Attributor][NFC] Modify isAssumedHeapToStack for const argument.

Rebase

Jul 21 2021, 1:51 AM · Restricted Project
ggeorgakoudis updated the summary of D106418: [Attributor][NFC] Modify isAssumedHeapToStack for const argument.
Jul 21 2021, 1:07 AM · Restricted Project
ggeorgakoudis retitled D106418: [Attributor][NFC] Modify isAssumedHeapToStack for const argument from [Attributor][NFC] Add a const argument isAssumedHeapToStack to [Attributor][NFC] Modify isAssumedHeapToStack for const argument.
Jul 21 2021, 1:07 AM · Restricted Project
ggeorgakoudis updated the diff for D106418: [Attributor][NFC] Modify isAssumedHeapToStack for const argument.

Fix for comments

Jul 21 2021, 1:05 AM · Restricted Project
ggeorgakoudis updated the diff for D106323: [OpenMP] Expose libomptarget function to get HW thread id.

Fix formatting

Jul 21 2021, 12:19 AM · Restricted Project, Restricted Project

Jul 20 2021

ggeorgakoudis abandoned D102105: [OpenMP][NFC] Refactor cc tests for implicit simd check.

Fixed in another revision (see description)

Jul 20 2021, 11:43 PM · Restricted Project
ggeorgakoudis updated the summary of D106423: [Attributor] Force simplication callback updates.
Jul 20 2021, 11:08 PM · Restricted Project
ggeorgakoudis updated the summary of D106423: [Attributor] Force simplication callback updates.
Jul 20 2021, 11:07 PM · Restricted Project
ggeorgakoudis requested review of D106423: [Attributor] Force simplication callback updates.
Jul 20 2021, 10:56 PM · Restricted Project