Page MenuHomePhabricator

ggeorgakoudis (Giorgis Georgakoudis)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 20 2019, 5:55 PM (78 w, 6 d)

Recent Activity

Yesterday

ggeorgakoudis added a comment to D104714: [UpdateCCTestChecks] Support --check-globals.

LGMT too!

Wed, Jun 23, 6:53 AM · Restricted Project, Restricted Project

Tue, Jun 15

ggeorgakoudis updated the diff for D102107: [OpenMP] Codegen aggregate for outlined function captures.

Update non-remark tests

Tue, Jun 15, 3:17 PM · Restricted Project, Restricted Project
ggeorgakoudis added a reviewer for D102107: [OpenMP] Codegen aggregate for outlined function captures: jhuber6.
Tue, Jun 15, 2:56 PM · Restricted Project, Restricted Project
ggeorgakoudis added a comment to D102107: [OpenMP] Codegen aggregate for outlined function captures.

(This is not offload-specific, right?)
This does not bring any compatibility issues, right?

Tue, Jun 15, 2:52 PM · Restricted Project, Restricted Project
ggeorgakoudis updated the diff for D102107: [OpenMP] Codegen aggregate for outlined function captures.

Rebase to NewGlobalization and amend

Tue, Jun 15, 10:31 AM · Restricted Project, Restricted Project

Sun, Jun 13

ggeorgakoudis accepted D101977: [OpenMP] Create custom state machines for generic target regions.

LGTM, minor comment

Sun, Jun 13, 11:09 AM · Restricted Project

Tue, Jun 8

ggeorgakoudis committed rW48718abac493: Move LLPP author notification and add PC member (authored by ggeorgakoudis).
Move LLPP author notification and add PC member
Tue, Jun 8, 6:05 PM

May 24 2021

ggeorgakoudis committed rW5ccb897378ff: Extend LLPP submission date (authored by ggeorgakoudis).
Extend LLPP submission date
May 24 2021, 1:16 PM
ggeorgakoudis added a comment to D102107: [OpenMP] Codegen aggregate for outlined function captures.

This allows us to remove the switch in the device runtime, right?

May 24 2021, 8:44 AM · Restricted Project, Restricted Project

May 22 2021

ggeorgakoudis updated the diff for D102107: [OpenMP] Codegen aggregate for outlined function captures.

Use non-aggregate captured args and outlining for ordered codegen

May 22 2021, 9:03 PM · Restricted Project, Restricted Project
ggeorgakoudis updated the summary of D102107: [OpenMP] Codegen aggregate for outlined function captures.
May 22 2021, 9:56 AM · Restricted Project, Restricted Project
ggeorgakoudis updated the diff for D102107: [OpenMP] Codegen aggregate for outlined function captures.

Add tests

May 22 2021, 9:35 AM · Restricted Project, Restricted Project

May 21 2021

ggeorgakoudis added a comment to D96854: [CodeExtractor] Enable partial aggregate arguments.

Ping @vsk! Waiting for your decision :)

May 21 2021, 12:21 PM · Restricted Project

May 18 2021

ggeorgakoudis updated the summary of D102105: [OpenMP][NFC] Refactor cc tests for implicit simd check.
May 18 2021, 1:15 PM · Restricted Project
ggeorgakoudis updated the summary of D102105: [OpenMP][NFC] Refactor cc tests for implicit simd check.
May 18 2021, 1:14 PM · Restricted Project
ggeorgakoudis updated the diff for D102105: [OpenMP][NFC] Refactor cc tests for implicit simd check.

Update for correct implicit checks

May 18 2021, 1:12 PM · Restricted Project
ggeorgakoudis added a comment to D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks.

No, it is not required. Most probably, needed to simplify test checks, nothing else.

Thanks. I'd like to remove the "REQUIRES: x86-registered-target", the -O1 for CHECK6,10, and regenerate the CHECK lines. Unfortunately I am seeing this mangling issue (https://bugs.llvm.org/show_bug.cgi?id=49767) when running the script. @ggeorgakoudis, how did you get past this to generate the CHECK lines in your change?

May 18 2021, 12:45 PM · Restricted Project
ggeorgakoudis updated the diff for D101974: [Utils][WIP] Refactor script for cc tests.

Update correction for implicit simd checks

May 18 2021, 11:55 AM · Restricted Project

May 17 2021

ggeorgakoudis added inline comments to D102558: [Utils] Check for generated functions inline if possible.
May 17 2021, 5:19 PM · Restricted Project, Restricted Project
ggeorgakoudis added inline comments to D101977: [OpenMP] Create custom state machines for generic target regions.
May 17 2021, 4:04 PM · Restricted Project
ggeorgakoudis added a comment to D101977: [OpenMP] Create custom state machines for generic target regions.

LG, some remarks

May 17 2021, 4:02 PM · Restricted Project

May 15 2021

ggeorgakoudis committed rW6f07a0384aca: Update LLPP CFP with submission guidelines (authored by ggeorgakoudis).
Update LLPP CFP with submission guidelines
May 15 2021, 9:51 AM

May 12 2021

ggeorgakoudis committed rWe265b85cebda: Update LLPP workshop with CFP and more info (authored by ggeorgakoudis).
Update LLPP workshop with CFP and more info
May 12 2021, 11:22 AM

May 9 2021

ggeorgakoudis added a comment to D96854: [CodeExtractor] Enable partial aggregate arguments.
In D96854#2709726, @vsk wrote:

Oh, I think I see what you meant - was it that the CE analysis cache can be re-used? The motivation there was eliminating quadratic compile-time for repeated outlining (D68616); with that change some cached analysis of the caller became reusable, but not the extractor instance itself.

May 9 2021, 12:54 AM · Restricted Project

May 8 2021

ggeorgakoudis updated the summary of D102105: [OpenMP][NFC] Refactor cc tests for implicit simd check.
May 8 2021, 10:42 AM · Restricted Project
ggeorgakoudis updated the summary of D102107: [OpenMP] Codegen aggregate for outlined function captures.
May 8 2021, 8:17 AM · Restricted Project, Restricted Project
ggeorgakoudis requested review of D102107: [OpenMP] Codegen aggregate for outlined function captures.
May 8 2021, 8:16 AM · Restricted Project, Restricted Project
ggeorgakoudis updated the summary of D102105: [OpenMP][NFC] Refactor cc tests for implicit simd check.
May 8 2021, 8:08 AM · Restricted Project
ggeorgakoudis requested review of D102105: [OpenMP][NFC] Refactor cc tests for implicit simd check.
May 8 2021, 7:59 AM · Restricted Project
ggeorgakoudis updated the diff for D101974: [Utils][WIP] Refactor script for cc tests.

Update fopenmp-simd handling to avoid duplicate implicit checks

May 8 2021, 7:36 AM · Restricted Project
ggeorgakoudis added a reviewer for D101974: [Utils][WIP] Refactor script for cc tests: jhuber6.
May 8 2021, 5:08 AM · Restricted Project

May 6 2021

ggeorgakoudis updated the diff for D101974: [Utils][WIP] Refactor script for cc tests.

Update regex for removing old checklines

May 6 2021, 9:39 AM · Restricted Project
ggeorgakoudis added a comment to D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks.

I've required X86 target for this test to get our bots green again.

May 6 2021, 9:31 AM · Restricted Project

May 5 2021

ggeorgakoudis requested review of D101974: [Utils][WIP] Refactor script for cc tests.
May 5 2021, 11:33 PM · Restricted Project
ggeorgakoudis closed D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks.
May 5 2021, 8:10 PM · Restricted Project
ggeorgakoudis committed rG207b08a9130b: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks (authored by ggeorgakoudis).
[OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks
May 5 2021, 8:09 PM
ggeorgakoudis committed rGf97b843d8819: [OpenMP] Fix non-determinism in clang copyin codegen (authored by ggeorgakoudis).
[OpenMP] Fix non-determinism in clang copyin codegen
May 5 2021, 7:24 PM
ggeorgakoudis closed D101952: [OpenMP] Fix non-determinism in clang copyin codegen.
May 5 2021, 7:24 PM · Restricted Project
ggeorgakoudis updated the diff for D101952: [OpenMP] Fix non-determinism in clang copyin codegen.

Update for comments

May 5 2021, 6:34 PM · Restricted Project
ggeorgakoudis updated the summary of D101952: [OpenMP] Fix non-determinism in clang copyin codegen.
May 5 2021, 6:28 PM · Restricted Project
ggeorgakoudis updated the diff for D101952: [OpenMP] Fix non-determinism in clang copyin codegen.

Update by Johanne's correction on the source of non-determinism

May 5 2021, 6:05 PM · Restricted Project
ggeorgakoudis requested review of D101952: [OpenMP] Fix non-determinism in clang copyin codegen.
May 5 2021, 3:48 PM · Restricted Project
ggeorgakoudis updated the diff for D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks.

More updates to tests

May 5 2021, 3:18 PM · Restricted Project
ggeorgakoudis updated the diff for D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks.

Update tests

May 5 2021, 2:39 PM · Restricted Project
ggeorgakoudis committed rG78a7d8c4dd10: [Utils][NFC] Rename replace-function-regex in update_cc_test_checks (authored by ggeorgakoudis).
[Utils][NFC] Rename replace-function-regex in update_cc_test_checks
May 5 2021, 2:19 PM
ggeorgakoudis closed D101934: [Utils][NFC] Rename replace-function-regex in update_cc_test_checks.
May 5 2021, 2:19 PM · Restricted Project, Restricted Project
ggeorgakoudis updated the summary of D101934: [Utils][NFC] Rename replace-function-regex in update_cc_test_checks.
May 5 2021, 11:53 AM · Restricted Project, Restricted Project
ggeorgakoudis requested review of D101934: [Utils][NFC] Rename replace-function-regex in update_cc_test_checks.
May 5 2021, 11:51 AM · Restricted Project, Restricted Project

May 4 2021

ggeorgakoudis reopened D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks.
May 4 2021, 5:16 PM · Restricted Project
ggeorgakoudis added a reverting change for rG956cae2f09b2: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks: rGf016c06abb1d: Revert "[OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks".
May 4 2021, 5:13 PM
ggeorgakoudis committed rGf016c06abb1d: Revert "[OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks" (authored by ggeorgakoudis).
Revert "[OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks"
May 4 2021, 5:13 PM
ggeorgakoudis added a reverting change for D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks: rGf016c06abb1d: Revert "[OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks".
May 4 2021, 5:13 PM · Restricted Project
ggeorgakoudis closed D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks.
May 4 2021, 5:00 PM · Restricted Project
ggeorgakoudis committed rG956cae2f09b2: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks (authored by ggeorgakoudis).
[OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks
May 4 2021, 4:59 PM
ggeorgakoudis updated the summary of D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks.
May 4 2021, 12:54 PM · Restricted Project
ggeorgakoudis requested review of D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks.
May 4 2021, 12:48 PM · Restricted Project
ggeorgakoudis committed rG92f2c39f915a: [Utils] Run non-filecheck runlines in-order in update_cc_test_checks (authored by ggeorgakoudis).
[Utils] Run non-filecheck runlines in-order in update_cc_test_checks
May 4 2021, 12:06 PM
ggeorgakoudis closed D101683: [Utils] Run non-filecheck runlines in-order in update_cc_test_checks.
May 4 2021, 12:06 PM · Restricted Project, Restricted Project
ggeorgakoudis updated the summary of D101683: [Utils] Run non-filecheck runlines in-order in update_cc_test_checks.
May 4 2021, 12:03 PM · Restricted Project, Restricted Project
ggeorgakoudis committed rG313ee609e16b: [OpenMP] Fix non-determinism in clang task codegen (lastprivates) (authored by ggeorgakoudis).
[OpenMP] Fix non-determinism in clang task codegen (lastprivates)
May 4 2021, 11:57 AM
ggeorgakoudis closed D101800: [OpenMP] Fix non-determinism in clang task codegen (lastprivates).
May 4 2021, 11:56 AM · Restricted Project

May 3 2021

ggeorgakoudis added inline comments to D101509: An attempt to abandon omptarget out-of-tree builds..
May 3 2021, 5:09 PM · Restricted Project
ggeorgakoudis requested review of D101800: [OpenMP] Fix non-determinism in clang task codegen (lastprivates).
May 3 2021, 4:35 PM · Restricted Project
ggeorgakoudis committed rG404fa9a6cf7c: [Utils] Add prof metadata to matched unnamed values (authored by ggeorgakoudis).
[Utils] Add prof metadata to matched unnamed values
May 3 2021, 3:15 PM
ggeorgakoudis closed D101742: [Utils] Add prof metadata to matched unnamed values.
May 3 2021, 3:15 PM · Restricted Project
ggeorgakoudis updated the diff for D101742: [Utils] Add prof metadata to matched unnamed values.

Update test

May 3 2021, 11:23 AM · Restricted Project
ggeorgakoudis committed rGa27ca15dd083: [OpenMP] Fix non-determinism in clang task codegen (authored by ggeorgakoudis).
[OpenMP] Fix non-determinism in clang task codegen
May 3 2021, 10:35 AM
ggeorgakoudis closed D101739: [OpenMP] Fix non-determinism in clang task codegen.
May 3 2021, 10:34 AM · Restricted Project

May 2 2021

ggeorgakoudis added a comment to D101742: [Utils] Add prof metadata to matched unnamed values.

Does this update need a test?

May 2 2021, 11:53 PM · Restricted Project
ggeorgakoudis added a reviewer for D101742: [Utils] Add prof metadata to matched unnamed values: jdoerfert.
May 2 2021, 11:50 PM · Restricted Project
ggeorgakoudis requested review of D101742: [Utils] Add prof metadata to matched unnamed values.
May 2 2021, 11:50 PM · Restricted Project
ggeorgakoudis requested review of D101739: [OpenMP] Fix non-determinism in clang task codegen.
May 2 2021, 9:53 PM · Restricted Project

Apr 30 2021

ggeorgakoudis requested review of D101683: [Utils] Run non-filecheck runlines in-order in update_cc_test_checks.
Apr 30 2021, 9:54 PM · Restricted Project, Restricted Project
ggeorgakoudis added a comment to D101312: [Utils] Do not remove comments in llc test script.

I'm trying to understand the functionality you want to achieve. Doesn't using different prefixes avoid merging already? The test does not seem to exercise your extensions.

Apr 30 2021, 8:40 AM · Restricted Project

Apr 29 2021

ggeorgakoudis added a comment to D95976: [OpenMP] Simplify offloading parallel call codegen.

Please update the test with a NFC commit.

Apr 29 2021, 10:14 AM · Restricted Project, Restricted Project, Restricted Project

Apr 23 2021

ggeorgakoudis added a comment to D101123: [OpenMP] Avoid reading uninitialized parallel level values.

Does this work correctly with a nested parallel region in SPMD mode? I think the zeroing-out of the parallel-level is needed for this case.

The parallel level in SPMD mode can never be zero. It is 1 in the beginning and then can only be higher as we enter serialized parallel regions (Inc/Dec level in *_serialized_parallel).

Apr 23 2021, 9:32 AM · Restricted Project
ggeorgakoudis added a comment to D101123: [OpenMP] Avoid reading uninitialized parallel level values.

Does this work correctly with a nested parallel region in SPMD mode? I think the zeroing-out of the parallel-level is needed for this case.

Apr 23 2021, 7:42 AM · Restricted Project

Apr 22 2021

ggeorgakoudis added a comment to D96854: [CodeExtractor] Enable partial aggregate arguments.

@vsk I'll re-structure the implementation to use internal state and an addArgExludedFromAggregate interface. I don't have/can't think right now a use case for the flexibility I'm proposing.

Apr 22 2021, 10:47 AM · Restricted Project

Apr 21 2021

ggeorgakoudis added a comment to D96854: [CodeExtractor] Enable partial aggregate arguments.
In D96854#2695426, @vsk wrote:

for example it makes possible to extract the same region with different exclusions without creating another CodeExtractor instance,

As extractCodeRegion mutates the original function, I assumed it was not possible to reuse a CodeExtractor instance in this way. Is there an in-tree example of CE instance reuse I can take a look at?

Apr 21 2021, 10:35 PM · Restricted Project
ggeorgakoudis committed rGa2dbfb6b72db: [OpenMP] Simplify offloading parallel call codegen (authored by ggeorgakoudis).
[OpenMP] Simplify offloading parallel call codegen
Apr 21 2021, 6:46 PM
ggeorgakoudis closed D95976: [OpenMP] Simplify offloading parallel call codegen.
Apr 21 2021, 6:46 PM · Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis updated the diff for D95976: [OpenMP] Simplify offloading parallel call codegen.

Fix clang-format

Apr 21 2021, 11:42 AM · Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis updated the diff for D95976: [OpenMP] Simplify offloading parallel call codegen.

Add tests, reduce microtask cases to avoid stack problems

Apr 21 2021, 9:06 AM · Restricted Project, Restricted Project, Restricted Project

Apr 19 2021

ggeorgakoudis updated the diff for D95976: [OpenMP] Simplify offloading parallel call codegen.

Fix

Apr 19 2021, 10:51 AM · Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis added inline comments to D95976: [OpenMP] Simplify offloading parallel call codegen.
Apr 19 2021, 12:55 AM · Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis updated the diff for D95976: [OpenMP] Simplify offloading parallel call codegen.

Update for comments, fixes

Apr 19 2021, 12:49 AM · Restricted Project, Restricted Project, Restricted Project

Apr 16 2021

ggeorgakoudis added inline comments to D95976: [OpenMP] Simplify offloading parallel call codegen.
Apr 16 2021, 2:46 PM · Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis updated the diff for D95976: [OpenMP] Simplify offloading parallel call codegen.

Update for comments, fix for windows fix

Apr 16 2021, 2:43 PM · Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis updated the diff for D95976: [OpenMP] Simplify offloading parallel call codegen.

Fix for getThreadLimit

Apr 16 2021, 7:12 AM · Restricted Project, Restricted Project, Restricted Project

Apr 15 2021

ggeorgakoudis added a comment to D95976: [OpenMP] Simplify offloading parallel call codegen.

Hi @Meinersbur (got word you are a windows user), @jdoerfert, could I ask your help in detecting why the clang tests on windows are failing? There are two failures I'm spotting, one is that calls to llvm.nvvm intrinsics seem transposed (https://reviews.llvm.org/harbormaster/unit/view/552591/) and another that attribute regexes are not recognized (https://reviews.llvm.org/harbormaster/unit/view/552593/ at nvptx_target_codegen.cpp:723:17). Maybe there is something else I'm missing and I'd appreciate the extra eyeballing on the problem.

Apr 15 2021, 7:39 AM · Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis added a reviewer for D95976: [OpenMP] Simplify offloading parallel call codegen: Meinersbur.
Apr 15 2021, 7:30 AM · Restricted Project, Restricted Project, Restricted Project

Apr 14 2021

ggeorgakoudis updated the diff for D95976: [OpenMP] Simplify offloading parallel call codegen.

Fix llvm test

Apr 14 2021, 2:09 PM · Restricted Project, Restricted Project, Restricted Project

Apr 13 2021

ggeorgakoudis updated the diff for D95976: [OpenMP] Simplify offloading parallel call codegen.

Add aux-triple to one test, check unit test builder on windows

Apr 13 2021, 9:11 AM · Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis updated the summary of D95976: [OpenMP] Simplify offloading parallel call codegen.
Apr 13 2021, 7:27 AM · Restricted Project, Restricted Project, Restricted Project
ggeorgakoudis updated the diff for D95976: [OpenMP] Simplify offloading parallel call codegen.

Add tests, update OpenMPOpt, rebase to main

Apr 13 2021, 7:15 AM · Restricted Project, Restricted Project, Restricted Project

Mar 30 2021

ggeorgakoudis added a comment to D96854: [CodeExtractor] Enable partial aggregate arguments.
In D96854#2645458, @vsk wrote:

Thanks for explaining. I'd suggest making ExcludedAggArgs part of a CodeExtractor instances internal state: e.g. the client may call CE.addArgExludedFromAggregate(Value *) some number of times before CE.extractCodeRegion(). This way, the client doesn't need to maintain a SetVector, and the rest of the interface isn't polluted with an option that's specific to the AggregateArg case.

Mar 30 2021, 7:07 AM · Restricted Project

Mar 26 2021

ggeorgakoudis committed rG8bc2c662d9c0: [Utils] Add prefix parameter in update test checks to avoid FileCheck conflicts (authored by ggeorgakoudis).
[Utils] Add prefix parameter in update test checks to avoid FileCheck conflicts
Mar 26 2021, 11:50 AM
ggeorgakoudis closed D99415: [Utils] Add prefix parameter in update test checks to avoid FileCheck conflicts.
Mar 26 2021, 11:50 AM · Restricted Project, Restricted Project
ggeorgakoudis updated the diff for D99415: [Utils] Add prefix parameter in update test checks to avoid FileCheck conflicts.

Update for comments

Mar 26 2021, 10:25 AM · Restricted Project, Restricted Project
ggeorgakoudis updated the summary of D99415: [Utils] Add prefix parameter in update test checks to avoid FileCheck conflicts.
Mar 26 2021, 6:38 AM · Restricted Project, Restricted Project