Page MenuHomePhabricator

saiislam (Saiyedul Islam)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 15 2019, 2:59 AM (185 w, 1 d)

Recent Activity

Tue, May 23

saiislam added inline comments to D150998: [OpenMP] Fix using the target ID when using the new driver.
Tue, May 23, 7:54 AM · Restricted Project, Unknown Object (Project)

Mon, May 22

saiislam added inline comments to D150998: [OpenMP] Fix using the target ID when using the new driver.
Mon, May 22, 7:29 AM · Restricted Project, Unknown Object (Project)

Jan 18 2023

saiislam added inline comments to D142022: [Clang][OpenMP] Fix handling of -mcode-object-version for OpenMP.
Jan 18 2023, 9:39 AM · Restricted Project, Unknown Object (Project)
saiislam updated the diff for D142022: [Clang][OpenMP] Fix handling of -mcode-object-version for OpenMP.

Removed the unnecessary call to getArgs() and added test cases.

Jan 18 2023, 9:38 AM · Restricted Project, Unknown Object (Project)
saiislam added inline comments to D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5.
Jan 18 2023, 7:31 AM · Restricted Project, Unknown Object (Project), Restricted Project
saiislam requested review of D142022: [Clang][OpenMP] Fix handling of -mcode-object-version for OpenMP.
Jan 18 2023, 7:29 AM · Restricted Project, Unknown Object (Project)

Jan 11 2023

saiislam added a comment to D140784: [OpenMP][AMDGPU] Introduce new matadata fields for code object 5.

Ping.

Jan 11 2023, 1:49 AM · Restricted Project, Restricted Project
saiislam added a comment to D140783: [OpenMP][AMDGPU] Extract code object version from the ELF.

Ping.

Jan 11 2023, 1:41 AM · Restricted Project, Restricted Project

Jan 4 2023

saiislam added inline comments to D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5.
Jan 4 2023, 7:08 AM · Restricted Project, Unknown Object (Project), Restricted Project
saiislam updated the summary of D140784: [OpenMP][AMDGPU] Introduce new matadata fields for code object 5.
Jan 4 2023, 6:56 AM · Restricted Project, Restricted Project
saiislam added a comment to D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5.

Thanks everyone for your review and comments!
I am going to address all of them in a series of smaller patches starting with D140784.

Jan 4 2023, 5:42 AM · Restricted Project, Unknown Object (Project), Restricted Project
saiislam requested review of D140973: [OpenMP][AMDGPU] Support of cov5 in the next gen plugin.
Jan 4 2023, 5:40 AM · Restricted Project, Restricted Project
saiislam added inline comments to D140783: [OpenMP][AMDGPU] Extract code object version from the ELF.
Jan 4 2023, 12:18 AM · Restricted Project, Restricted Project
saiislam updated the diff for D140783: [OpenMP][AMDGPU] Extract code object version from the ELF.

Fixed usage of CodeObjectVersion and ImplicitArgs size in the old plugin.
A separate patch will be required to support cov5 for the next gen plugin.

Jan 4 2023, 12:17 AM · Restricted Project, Restricted Project

Dec 30 2022

saiislam requested review of D140784: [OpenMP][AMDGPU] Introduce new matadata fields for code object 5.
Dec 30 2022, 9:45 AM · Restricted Project, Restricted Project
saiislam requested review of D140783: [OpenMP][AMDGPU] Extract code object version from the ELF.
Dec 30 2022, 9:44 AM · Restricted Project, Restricted Project

Dec 9 2022

saiislam requested review of D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5.
Dec 9 2022, 11:10 AM · Restricted Project, Unknown Object (Project), Restricted Project

Oct 21 2022

saiislam accepted D134974: [OpenMP] Add map clause to the LIT test on use_device_addr clause.

LGTM!

Oct 21 2022, 12:33 PM · Unknown Object (Project), Restricted Project

Oct 12 2022

saiislam accepted D135724: [HIP] Fix unbundling archive.

Thank you!
It is fixing our OpenMP smoke test failure.

Oct 12 2022, 4:21 AM · Unknown Object (Project), Restricted Project

Sep 23 2022

saiislam added a comment to D134546: [clang-offload-bundler] extracting compatible bundle entry.

The patch looks fine to me.
Please wait for @tra 's final review.

Sep 23 2022, 10:58 AM · Unknown Object (Project), Restricted Project

Sep 12 2022

saiislam accepted D132643: [OpenMP] Extend lit test for parallel for simd construct.

LGTM. Thank!

Sep 12 2022, 11:06 AM · Unknown Object (Project), Restricted Project

Sep 6 2022

saiislam committed rG0cecc6e8e27c: [OpenMP] Add lit test for metadirective device arch inspired (authored by animeshk-amd).
[OpenMP] Add lit test for metadirective device arch inspired
Sep 6 2022, 5:11 AM · Unknown Object (Project), Restricted Project
saiislam closed D131763: [OpenMP] Add lit test for metadirective device arch inspired from sollve.
Sep 6 2022, 5:11 AM · Unknown Object (Project), Restricted Project

Sep 5 2022

saiislam accepted D131763: [OpenMP] Add lit test for metadirective device arch inspired from sollve.

LGTM. Thanks!

Sep 5 2022, 3:13 AM · Unknown Object (Project), Restricted Project
saiislam added a comment to D132965: [amdgpu] Drop multiple calls to hsa_init.

I think we can not remove this initialization.

Sep 5 2022, 12:12 AM · Restricted Project, Restricted Project
saiislam added a comment to D127769: [Libomptarget] Add checks for AMDGPU TargetID using new image info.

Apologies for the delay in response.

Sep 5 2022, 12:10 AM · Restricted Project, Restricted Project

Sep 4 2022

saiislam accepted D132607: [OffloadPackager] Add ability to extract images from other file types.

LGTM. Thanks!

Sep 4 2022, 11:51 PM · Unknown Object (Project), Restricted Project

Aug 16 2022

saiislam added a comment to D131763: [OpenMP] Add lit test for metadirective device arch inspired from sollve.

This doesn't actually test much, only once case/compilation is covered. In the second function nothing specific to LLVM as impl is checked.

The second function, is the only place in llvm-project where vendor(llvm) is being tested for a non-error test.

Really?

ag 'vendor\(llvm\)' clang/test/OpenMP --files-with-matches                                                                                                                                                                

clang/test/OpenMP/begin_declare_variant_messages.c
clang/test/OpenMP/begin_declare_variant_using_messages.cpp
clang/test/OpenMP/declare_variant_ast_print.c
clang/test/OpenMP/declare_variant_ast_print.cpp
clang/test/OpenMP/declare_variant_implementation_vendor_codegen.cpp
clang/test/OpenMP/declare_variant_messages.cpp
clang/test/OpenMP/declare_variant_mixed_codegen.cpp
clang/test/OpenMP/metadirective_ast_print.c
clang/test/OpenMP/metadirective_implementation_codegen.c
clang/test/OpenMP/nvptx_declare_variant_implementation_vendor_codegen.cpp
clang/test/OpenMP/declare_variant_messages.c
clang/test/OpenMP/metadirective_empty.cpp
clang/test/OpenMP/metadirective_implementation_codegen.cpp

That said, the above function still doesn't test anything wrt. llvm as impl anyway. We could just as well match amd or nvidia and the check lines still match just fine.

Aug 16 2022, 1:26 AM · Unknown Object (Project), Restricted Project

Aug 12 2022

saiislam added a comment to D131763: [OpenMP] Add lit test for metadirective device arch inspired from sollve.

This doesn't actually test much, only once case/compilation is covered. In the second function nothing specific to LLVM as impl is checked.

Aug 12 2022, 7:44 AM · Unknown Object (Project), Restricted Project

Aug 11 2022

saiislam accepted D131401: [Libomptarget] Replace libelf with LLVM's Elf libraries.

LGTM. Thanks!

Aug 11 2022, 5:52 AM · Restricted Project, Restricted Project

Jul 27 2022

saiislam accepted D129635: [OpenMP] Update the default version of OpenMP to 5.1.

In the multi-company OpenMP meeting, it was decided to defer this update.
So, please don't land this patch yet.

Jul 27 2022, 6:53 AM · Restricted Project, Unknown Object (Project), Restricted Project

Jul 26 2022

saiislam committed rG4075a811ad99: [Libomptarget] Add checks for AMDGPU TargetID using new image info (authored by saiislam).
[Libomptarget] Add checks for AMDGPU TargetID using new image info
Jul 26 2022, 12:45 AM · Restricted Project, Restricted Project

Jul 25 2022

saiislam added a reverting change for rG281eb9223cf2: Revert "Revert "[Libomptarget] Add checks for AMDGPU TargetID using new image…: rG4cf30c5157a6: Revert "Revert "Revert "[Libomptarget] Add checks for AMDGPU TargetID using new….
Jul 25 2022, 9:36 AM · Restricted Project, Restricted Project
saiislam committed rG4cf30c5157a6: Revert "Revert "Revert "[Libomptarget] Add checks for AMDGPU TargetID using new… (authored by saiislam).
Revert "Revert "Revert "[Libomptarget] Add checks for AMDGPU TargetID using new…
Jul 25 2022, 9:36 AM · Restricted Project, Restricted Project
saiislam added a reverting change for rG8cbf4a386b67: Revert "[Libomptarget] Add checks for AMDGPU TargetID using new image info": rG281eb9223cf2: Revert "Revert "[Libomptarget] Add checks for AMDGPU TargetID using new image….
Jul 25 2022, 6:33 AM · Restricted Project, Restricted Project
saiislam committed rG281eb9223cf2: Revert "Revert "[Libomptarget] Add checks for AMDGPU TargetID using new image… (authored by saiislam).
Revert "Revert "[Libomptarget] Add checks for AMDGPU TargetID using new image…
Jul 25 2022, 6:33 AM · Restricted Project, Restricted Project
saiislam added a reverting change for rG471f2abc62d9: [Libomptarget] Add checks for AMDGPU TargetID using new image info: rG8cbf4a386b67: Revert "[Libomptarget] Add checks for AMDGPU TargetID using new image info".
Jul 25 2022, 3:34 AM · Restricted Project, Restricted Project
saiislam committed rG8cbf4a386b67: Revert "[Libomptarget] Add checks for AMDGPU TargetID using new image info" (authored by saiislam).
Revert "[Libomptarget] Add checks for AMDGPU TargetID using new image info"
Jul 25 2022, 3:34 AM · Restricted Project, Restricted Project
saiislam added a reverting change for D127769: [Libomptarget] Add checks for AMDGPU TargetID using new image info: rG8cbf4a386b67: Revert "[Libomptarget] Add checks for AMDGPU TargetID using new image info".
Jul 25 2022, 3:34 AM · Restricted Project, Restricted Project
saiislam committed rG471f2abc62d9: [Libomptarget] Add checks for AMDGPU TargetID using new image info (authored by saiislam).
[Libomptarget] Add checks for AMDGPU TargetID using new image info
Jul 25 2022, 2:45 AM · Restricted Project, Restricted Project
saiislam closed D127769: [Libomptarget] Add checks for AMDGPU TargetID using new image info.
Jul 25 2022, 2:44 AM · Restricted Project, Restricted Project

Jul 24 2022

saiislam updated the diff for D127769: [Libomptarget] Add checks for AMDGPU TargetID using new image info.

Updated with StringMap and StringRef ADTs. Also refactored based on new formating style.

Jul 24 2022, 10:47 AM · Restricted Project, Restricted Project

Jul 20 2022

saiislam added reviewers for D129635: [OpenMP] Update the default version of OpenMP to 5.1: ABataev, RaviNarayanaswamy, dreachem.
Jul 20 2022, 5:29 AM · Restricted Project, Unknown Object (Project), Restricted Project

Jul 13 2022

saiislam added a comment to D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march.

Sorry never noticed this revision. The purpose of this patch seems to be supporting something like this

clang input.c -fopenmp -fopenmp-targets=nvptx64 -Xopenmp-target=nvptx64 -march=sm_70 -Xopenmp-target=nvptx64 -march=sm_80

Right now the above works if you replace -march= with --offload-arch=. Currently the offloading tools use a "bound" architecture to tie a specific architecture with a job, which is what allows us to offload to multiple architectures. If there is no bound architecture gives, we instead use the -march= option, and if that is not present we derive it. It would be possible to set the bound architecture via -march if we wanted to. But I'm not sure if it's necessary given that it would just be an alternate syntax for --offload-arch=.

Jul 13 2022, 10:25 AM · Unknown Object (Project), Restricted Project

Jul 12 2022

saiislam accepted D127304: [LinkerWrapper] Embed OffloadBinaries for OpenMP offloading images.

Thanks, LGTM!

Jul 12 2022, 6:09 AM · Restricted Project, Unknown Object (Project)

Jul 5 2022

saiislam accepted D128997: [Libomptarget][NFC] Make Libomptarget use the LLVM naming convention.

Leftovers, if any, can be covered in a follow-up patch.

Jul 5 2022, 10:38 AM · Restricted Project, Restricted Project

Jun 22 2022

saiislam added a comment to D127769: [Libomptarget] Add checks for AMDGPU TargetID using new image info.

Ping

Jun 22 2022, 8:15 AM · Restricted Project, Restricted Project

Jun 17 2022

saiislam updated the summary of D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march.
Jun 17 2022, 12:17 PM · Unknown Object (Project), Restricted Project
saiislam updated the diff for D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march.

clang-formatted.

Jun 17 2022, 12:16 PM · Unknown Object (Project), Restricted Project
saiislam requested review of D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march.
Jun 17 2022, 12:11 PM · Unknown Object (Project), Restricted Project

Jun 14 2022

saiislam added a comment to D127769: [Libomptarget] Add checks for AMDGPU TargetID using new image info.

The control flow here is quite complicated and it's not immediately obvious why things are being stashed in a map. I vaguely recall the rules for choosing compatible images by target ID being complicated and undocumented.

Did you reverse engineer this from the HIP implementation, or is there now documentation for how the +/-/any stuff is meant to resolve?

Jun 14 2022, 11:52 PM · Restricted Project, Restricted Project
saiislam updated the diff for D127769: [Libomptarget] Add checks for AMDGPU TargetID using new image info.

Added comments for parseTargeID() .

Jun 14 2022, 11:52 PM · Restricted Project, Restricted Project
saiislam updated the diff for D127769: [Libomptarget] Add checks for AMDGPU TargetID using new image info.

Forgot to invert the condition in an if block.

Jun 14 2022, 10:54 AM · Restricted Project, Restricted Project
saiislam requested review of D127769: [Libomptarget] Add checks for AMDGPU TargetID using new image info.
Jun 14 2022, 10:41 AM · Restricted Project, Restricted Project

Jun 8 2022

saiislam added a comment to D126836: [LIBOMPTARGET] Adding AMD to llvm-omp-device-info.

I have added the HSA_ISA_INFO_NAME, made the function static, and removed
the unused elements in the enums.

Jun 8 2022, 4:28 AM · Restricted Project, Restricted Project

Jun 2 2022

saiislam added a comment to D126836: [LIBOMPTARGET] Adding AMD to llvm-omp-device-info.

Could you please add support for HSA_ISA_INFO_NAME using hsa_isa_get_info_alt?
This one gives triple and target ID information, like amdgcn-amd-amdhsa--gfx908:sramecc-:xnack-

Jun 2 2022, 1:00 AM · Restricted Project, Restricted Project

Jun 1 2022

saiislam updated the diff for D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries.

Added the multi-entry logic in libomptarget. Yet to move the image compatibility testing to plugin.

Jun 1 2022, 7:47 AM · Restricted Project, Unknown Object (Project), Restricted Project

May 26 2022

saiislam added a comment to D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries.

Thanks for the detailed review. I will update rest of the patch soon.

May 26 2022, 12:09 PM · Restricted Project, Unknown Object (Project), Restricted Project
saiislam updated the diff for D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries.

Addressed some simple review changes. Will update remaining in the next iteration.

May 26 2022, 12:08 PM · Restricted Project, Unknown Object (Project), Restricted Project

May 25 2022

saiislam updated the diff for D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries.

Changed the embedding scheme to add ImageInfo field in __tgt_device_image.

May 25 2022, 7:06 AM · Restricted Project, Unknown Object (Project), Restricted Project

May 6 2022

saiislam accepted D125050: [OpenMP] Try to Infer target triples using the offloading architecture.

Thanks!
LGTM.

May 6 2022, 9:46 AM · Unknown Object (Project), Restricted Project
saiislam added a comment to D125092: [OpenMP] Add basic support for properly handling static libraries.

Ideally we could just put this on the linker itself, but nvlink doesn't seem to support .a files.

May 6 2022, 9:42 AM · Unknown Object (Project), Restricted Project
saiislam added a comment to D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries.

I'm suggesting instead we define a new __tgt_device_image and a new __tgt_register_lib function to support this. This new __tgt_device_image will simply contain a pointer to an optional information struct.

struct __tgt_device_image_v2 {
  void* 	ImageStart;
  void* 	ImageEnd;
  __tgt_offload_entry* 	EntriesBegin;
  __tgt_offload_entry* 	EntriesEnd;
  __tgt_image_into*  ImageInfo;
};

This new struct breaks the ABI with the old __tgt_device_image because these are put into an array and we change the size, but we should be able to provide backwards compatibility by copying from the old format to the new format and creating a new array. We can detect the new vs. old ABI by expecting that existing applications will call the __tgt_register_image function. We will create a new __tgt_register_image_v2 function for example that all new programs will call. In libomptarget we then change __tgt_register_image to do the necessary translation.

struct __tgt_bin_desc {                                                                                                                                                                  
  int32_t NumDeviceImages;           // Number of device types supported                                                                                                                   
  __tgt_device_image *DeviceImages;  // Array of device images (1 per dev. type)                                                        
  __tgt_offload_entry *HostEntriesBegin; // Begin of table with all host entries                                                           
  __tgt_offload_entry *HostEntriesEnd;   // End of table (non inclusive)                                                                                                           
};

EXTERN void __tgt_register_lib(__tgt_bin_desc *desc) {
  __tgt_device_image_v2 *new_image = alloc_new_version(desc);
  desc->DeviceImages = new_Image;
  __tgt_register_lib_v2(desc);
}

EXTERN void __tgt_unregister_lib(__tgt_bin_desc *desc) {
  __tgt_unregister_lib_v2(desc);
  dealloc(desc->DeviceImages);
}

Now the rest of libomptarget solely uses the new format, and we check if information is available by seeing that the ImageInfo field is non-null.

May 6 2022, 3:33 AM · Restricted Project, Unknown Object (Project), Restricted Project
saiislam added a comment to D125050: [OpenMP] Try to Infer target triples using the offloading architecture.

Looks good to me.

May 6 2022, 3:30 AM · Unknown Object (Project), Restricted Project

May 2 2022

saiislam added inline comments to D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP.
May 2 2022, 6:44 AM · Unknown Object (Project), Restricted Project
saiislam added inline comments to D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP.
May 2 2022, 5:28 AM · Unknown Object (Project), Restricted Project
saiislam added inline comments to D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP.
May 2 2022, 5:20 AM · Unknown Object (Project), Restricted Project

May 1 2022

saiislam added inline comments to D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP.
May 1 2022, 10:41 PM · Unknown Object (Project), Restricted Project

Apr 28 2022

saiislam added a comment to D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries.

need a test for the generated registration code

Apr 28 2022, 3:20 AM · Restricted Project, Unknown Object (Project), Restricted Project

Apr 27 2022

saiislam requested review of D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries.
Apr 27 2022, 6:07 AM · Restricted Project, Unknown Object (Project), Restricted Project

Apr 12 2022

saiislam committed rG54a6cc340560: [libomptarget][amdgpu] Add hidden_heap_v1 kernarg metadata (authored by saiislam).
[libomptarget][amdgpu] Add hidden_heap_v1 kernarg metadata
Apr 12 2022, 8:59 PM · Restricted Project, Restricted Project
saiislam closed D123527: [libomptarget][amdgpu] Add hidden_heap_v1 kernarg metadata.
Apr 12 2022, 8:58 PM · Restricted Project, Restricted Project

Apr 11 2022

saiislam requested review of D123527: [libomptarget][amdgpu] Add hidden_heap_v1 kernarg metadata.
Apr 11 2022, 11:07 AM · Restricted Project, Restricted Project

Apr 8 2022

saiislam committed rG0f6cbdee5761: [clang-offload-bundler] fix "no output file" issue with -outputs (authored by scchan).
[clang-offload-bundler] fix "no output file" issue with -outputs
Apr 8 2022, 10:12 AM · Unknown Object (Project), Restricted Project
saiislam closed D123387: [clang-offload-bundler] fix "no output file" issue with -outputs.
Apr 8 2022, 10:12 AM · Restricted Project, Unknown Object (Project)
saiislam accepted D123387: [clang-offload-bundler] fix "no output file" issue with -outputs.

Does this mean without this fix clang-offload-bundler emits an error if -outputs option not given? How could the lit tests passed?

Apr 8 2022, 9:45 AM · Restricted Project, Unknown Object (Project)

Mar 30 2022

saiislam added a comment to D122069: [Object] Add binary format for bundling offloading metadata.

Hey @jhuber6 , as discussed in multi-company meeting, I think that we will need at least an arch field somewhere in this. We would like to create multi-arch binaries so that runtime can load the compatible one on its own.
You may even consider using TargetID Format to store the list of archs.

Mar 30 2022, 8:09 AM · Restricted Project, Unknown Object (Project), Restricted Project

Mar 29 2022

saiislam accepted D122652: [libomptarget][test] add return 0 to map_back_race.cpp.

LGTM

Mar 29 2022, 6:42 AM · Restricted Project, Restricted Project

Mar 2 2022

saiislam committed rG1e78d07dc9cd: [clang-offload-bundler] Fix typo in a test case (authored by saiislam).
[clang-offload-bundler] Fix typo in a test case
Mar 2 2022, 5:34 AM · Restricted Project

Mar 1 2022

saiislam committed rG7a02abf06ff9: [clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous… (authored by saiislam).
[clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous…
Mar 1 2022, 11:56 PM · Restricted Project
saiislam closed D120697: [clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous archive library.
Mar 1 2022, 11:56 PM · Restricted Project, Unknown Object (Project)

Feb 28 2022

saiislam requested review of D120697: [clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous archive library.
Feb 28 2022, 10:46 PM · Restricted Project, Unknown Object (Project)

Feb 22 2022

saiislam added a comment to D120271: [Clang] Add offload kind to embedded offload object.

Will it be possible to use Bundle Entry ID format [1] for naming sections and being sort of the the primary key to refer an offload object?
The arch string following the triple will be just offload-arch (or march, or mcpu) for others, but for amdgpu it may contain some more information.

Feb 22 2022, 9:43 AM · Restricted Project, Unknown Object (Project)

Feb 8 2022

saiislam committed rG4db88a54b6d4: [OpenMP][Clang] Move partial support of reverse offload to a future version (authored by saiislam).
[OpenMP][Clang] Move partial support of reverse offload to a future version
Feb 8 2022, 11:13 PM
saiislam closed D119256: [OpenMP][Clang] Move partial support of reverse offload to a future version.
Feb 8 2022, 11:12 PM · Restricted Project, Unknown Object (Project)
saiislam requested review of D119256: [OpenMP][Clang] Move partial support of reverse offload to a future version.
Feb 8 2022, 8:44 AM · Restricted Project, Unknown Object (Project)

Feb 4 2022

saiislam committed rGae9c0740648f: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading (authored by saiislam).
[OpenMP][Clang] Allow ancestor device modifier only with reverse offloading
Feb 4 2022, 4:17 AM
saiislam closed D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading.
Feb 4 2022, 4:17 AM · Unknown Object (Project)

Feb 3 2022

saiislam updated the diff for D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading.

Restored device ancestor codegen unit test with requires reverese_offload.

Feb 3 2022, 5:26 AM · Unknown Object (Project)
saiislam added inline comments to D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading.
Feb 3 2022, 5:14 AM · Unknown Object (Project)
saiislam requested review of D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading.
Feb 3 2022, 3:49 AM · Unknown Object (Project)

Jan 31 2022

saiislam added a comment to D116544: [Clang] Introduce Clang Linker Wrapper Tool.

Can you please add this tool's doc in clang/docs?

Jan 31 2022, 9:26 AM · Unknown Object (Project)

Jan 27 2022

saiislam added a comment to rG876b5ea96bf5: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective….

ParseOpenMP.cpp was part of the "previously 100% clang-formatted files" ./clang/docs/tools/clang-formatted-files.txt

This commit contains code changes that are not clang-formatted

--- a/clang/lib/Parse/ParseOpenMP.cpp
+++ b/clang/lib/Parse/ParseOpenMP.cpp
@@ -2210,12 +2210,12 @@ Parser::DeclGroupPtrTy Parser::ParseOpenMPDeclarativeDirectiveWithExtDecl(
     VariantMatchInfo VMI;
     TI.getAsVariantMatchInfo(ASTCtx, VMI);

-    std::function<void(StringRef)> DiagUnknownTrait = [this, Loc](
-                                                          StringRef ISATrait) {
-      // TODO Track the selector locations in a way that is accessible here to
-      // improve the diagnostic location.
-      Diag(Loc, diag::warn_unknown_declare_variant_isa_trait) << ISATrait;
-    };
+    std::function<void(StringRef)> DiagUnknownTrait =
+        [this, Loc](StringRef ISATrait) {
+          // TODO Track the selector locations in a way that is accessible here
+          // to improve the diagnostic location.
+          Diag(Loc, diag::warn_unknown_declare_variant_isa_trait) << ISATrait;
+        };
     TargetOMPContext OMPCtx(
         ASTCtx, std::move(DiagUnknownTrait),
         /* CurrentFunctionDecl */ nullptr,
@@ -2551,12 +2551,12 @@ Parser::ParseOpenMPDeclarativeOrExecutableDirective(ParsedStmtContext StmtCtx) {
     TPA.Revert();
     // End of the first iteration. Parser is reset to the start of metadirective

-    std::function<void(StringRef)> DiagUnknownTrait = [this, Loc](
-                                                          StringRef ISATrait) {
-      // TODO Track the selector locations in a way that is accessible here to
-      // improve the diagnostic location.
-      Diag(Loc, diag::warn_unknown_declare_variant_isa_trait) << ISATrait;
-    };
+    std::function<void(StringRef)> DiagUnknownTrait =
+        [this, Loc](StringRef ISATrait) {
+          // TODO Track the selector locations in a way that is accessible here
+          // to improve the diagnostic location.
+          Diag(Loc, diag::warn_unknown_declare_variant_isa_trait) << ISATrait;
+        };
     TargetOMPContext OMPCtx(ASTContext, std::move(DiagUnknownTrait),
                             /* CurrentFunctionDecl */ nullptr,
                             ArrayRef<llvm::omp::TraitProperty>());
Jan 27 2022, 1:03 AM
saiislam committed rG52fddcdd9c90: [clang-format] Format ParseOpenMP.cpp changes (authored by saiislam).
[clang-format] Format ParseOpenMP.cpp changes
Jan 27 2022, 1:02 AM

Jan 19 2022

saiislam added a comment to D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool.

It seems that this patch along with D117156 and D117246 is giving patch application failed error [https://buildkite.com/llvm-project/diff-checks/builds/82688].
arc patch is also giving the same error.

Jan 19 2022, 11:18 AM · Restricted Project, Unknown Object (Project)
saiislam committed rG6ee965471363: [Doc] Fix wrong indentation (authored by saiislam).
[Doc] Fix wrong indentation
Jan 19 2022, 3:16 AM
saiislam committed rG0731f6ba4f57: [Doc] Add documentation for the clang-offload-wrapper tool (NFC) (authored by saiislam).
[Doc] Add documentation for the clang-offload-wrapper tool (NFC)
Jan 19 2022, 2:46 AM
saiislam closed D117120: [Doc] Add documentation for the clang-offload-wrapper tool (NFC).
Jan 19 2022, 2:46 AM · Unknown Object (Project)

Jan 18 2022

saiislam added a comment to D117120: [Doc] Add documentation for the clang-offload-wrapper tool (NFC).

Ping :-)

Jan 18 2022, 9:03 AM · Restricted Project

Jan 12 2022

saiislam requested review of D117120: [Doc] Add documentation for the clang-offload-wrapper tool (NFC).
Jan 12 2022, 7:55 AM · Restricted Project