Page MenuHomePhabricator

saiislam (Saiyedul Islam)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 15 2019, 2:59 AM (137 w, 6 d)

Recent Activity

Tue, Jul 5

saiislam accepted D128997: [Libomptarget][NFC] Make Libomptarget use the LLVM naming convention.

Leftovers, if any, can be covered in a follow-up patch.

Tue, Jul 5, 10:38 AM · Unknown Object (Project), Restricted Project

Wed, Jun 22

saiislam added a comment to D127769: [Libomptarget] Add checks for AMDGPU TargetID using new image info.

Ping

Wed, Jun 22, 8:15 AM · Restricted Project, Unknown Object (Project)

Fri, Jun 17

saiislam updated the summary of D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march.
Fri, Jun 17, 12:17 PM · Unknown Object (Project), Restricted Project
saiislam updated the diff for D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march.

clang-formatted.

Fri, Jun 17, 12:16 PM · Unknown Object (Project), Restricted Project
saiislam requested review of D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march.
Fri, Jun 17, 12:11 PM · Unknown Object (Project), Restricted Project

Tue, Jun 14

saiislam added a comment to D127769: [Libomptarget] Add checks for AMDGPU TargetID using new image info.

The control flow here is quite complicated and it's not immediately obvious why things are being stashed in a map. I vaguely recall the rules for choosing compatible images by target ID being complicated and undocumented.

Did you reverse engineer this from the HIP implementation, or is there now documentation for how the +/-/any stuff is meant to resolve?

Tue, Jun 14, 11:52 PM · Restricted Project, Unknown Object (Project)
saiislam updated the diff for D127769: [Libomptarget] Add checks for AMDGPU TargetID using new image info.

Added comments for parseTargeID() .

Tue, Jun 14, 11:52 PM · Restricted Project, Unknown Object (Project)
saiislam updated the diff for D127769: [Libomptarget] Add checks for AMDGPU TargetID using new image info.

Forgot to invert the condition in an if block.

Tue, Jun 14, 10:54 AM · Restricted Project, Unknown Object (Project)
saiislam requested review of D127769: [Libomptarget] Add checks for AMDGPU TargetID using new image info.
Tue, Jun 14, 10:41 AM · Restricted Project, Unknown Object (Project)

Wed, Jun 8

saiislam added a comment to D126836: [LIBOMPTARGET] Adding AMD to llvm-omp-device-info.

I have added the HSA_ISA_INFO_NAME, made the function static, and removed
the unused elements in the enums.

Wed, Jun 8, 4:28 AM · Restricted Project, Unknown Object (Project)

Jun 2 2022

saiislam added a comment to D126836: [LIBOMPTARGET] Adding AMD to llvm-omp-device-info.

Could you please add support for HSA_ISA_INFO_NAME using hsa_isa_get_info_alt?
This one gives triple and target ID information, like amdgcn-amd-amdhsa--gfx908:sramecc-:xnack-

Jun 2 2022, 1:00 AM · Restricted Project, Unknown Object (Project)

Jun 1 2022

saiislam updated the diff for D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries.

Added the multi-entry logic in libomptarget. Yet to move the image compatibility testing to plugin.

Jun 1 2022, 7:47 AM · Unknown Object (Project), Unknown Object (Project), Restricted Project

May 26 2022

saiislam added a comment to D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries.

Thanks for the detailed review. I will update rest of the patch soon.

May 26 2022, 12:09 PM · Unknown Object (Project), Unknown Object (Project), Restricted Project
saiislam updated the diff for D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries.

Addressed some simple review changes. Will update remaining in the next iteration.

May 26 2022, 12:08 PM · Unknown Object (Project), Unknown Object (Project), Restricted Project

May 25 2022

saiislam updated the diff for D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries.

Changed the embedding scheme to add ImageInfo field in __tgt_device_image.

May 25 2022, 7:06 AM · Unknown Object (Project), Unknown Object (Project), Restricted Project

May 6 2022

saiislam accepted D125050: [OpenMP] Try to Infer target triples using the offloading architecture.

Thanks!
LGTM.

May 6 2022, 9:46 AM · Unknown Object (Project), Restricted Project
saiislam added a comment to D125092: [OpenMP] Add basic support for properly handling static libraries.

Ideally we could just put this on the linker itself, but nvlink doesn't seem to support .a files.

May 6 2022, 9:42 AM · Unknown Object (Project), Restricted Project
saiislam added a comment to D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries.

I'm suggesting instead we define a new __tgt_device_image and a new __tgt_register_lib function to support this. This new __tgt_device_image will simply contain a pointer to an optional information struct.

struct __tgt_device_image_v2 {
  void* 	ImageStart;
  void* 	ImageEnd;
  __tgt_offload_entry* 	EntriesBegin;
  __tgt_offload_entry* 	EntriesEnd;
  __tgt_image_into*  ImageInfo;
};

This new struct breaks the ABI with the old __tgt_device_image because these are put into an array and we change the size, but we should be able to provide backwards compatibility by copying from the old format to the new format and creating a new array. We can detect the new vs. old ABI by expecting that existing applications will call the __tgt_register_image function. We will create a new __tgt_register_image_v2 function for example that all new programs will call. In libomptarget we then change __tgt_register_image to do the necessary translation.

struct __tgt_bin_desc {                                                                                                                                                                  
  int32_t NumDeviceImages;           // Number of device types supported                                                                                                                   
  __tgt_device_image *DeviceImages;  // Array of device images (1 per dev. type)                                                        
  __tgt_offload_entry *HostEntriesBegin; // Begin of table with all host entries                                                           
  __tgt_offload_entry *HostEntriesEnd;   // End of table (non inclusive)                                                                                                           
};

EXTERN void __tgt_register_lib(__tgt_bin_desc *desc) {
  __tgt_device_image_v2 *new_image = alloc_new_version(desc);
  desc->DeviceImages = new_Image;
  __tgt_register_lib_v2(desc);
}

EXTERN void __tgt_unregister_lib(__tgt_bin_desc *desc) {
  __tgt_unregister_lib_v2(desc);
  dealloc(desc->DeviceImages);
}

Now the rest of libomptarget solely uses the new format, and we check if information is available by seeing that the ImageInfo field is non-null.

May 6 2022, 3:33 AM · Unknown Object (Project), Unknown Object (Project), Restricted Project
saiislam added a comment to D125050: [OpenMP] Try to Infer target triples using the offloading architecture.

Looks good to me.

May 6 2022, 3:30 AM · Unknown Object (Project), Restricted Project

May 2 2022

saiislam added inline comments to D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP.
May 2 2022, 6:44 AM · Unknown Object (Project), Restricted Project
saiislam added inline comments to D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP.
May 2 2022, 5:28 AM · Unknown Object (Project), Restricted Project
saiislam added inline comments to D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP.
May 2 2022, 5:20 AM · Unknown Object (Project), Restricted Project

May 1 2022

saiislam added inline comments to D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP.
May 1 2022, 10:41 PM · Unknown Object (Project), Restricted Project

Apr 28 2022

saiislam added a comment to D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries.

need a test for the generated registration code

Apr 28 2022, 3:20 AM · Unknown Object (Project), Unknown Object (Project), Restricted Project

Apr 27 2022

saiislam requested review of D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries.
Apr 27 2022, 6:07 AM · Unknown Object (Project), Unknown Object (Project), Restricted Project

Apr 12 2022

saiislam committed rG54a6cc340560: [libomptarget][amdgpu] Add hidden_heap_v1 kernarg metadata (authored by saiislam).
[libomptarget][amdgpu] Add hidden_heap_v1 kernarg metadata
Apr 12 2022, 8:59 PM · Unknown Object (Project), Restricted Project
saiislam closed D123527: [libomptarget][amdgpu] Add hidden_heap_v1 kernarg metadata.
Apr 12 2022, 8:58 PM · Unknown Object (Project), Restricted Project

Apr 11 2022

saiislam requested review of D123527: [libomptarget][amdgpu] Add hidden_heap_v1 kernarg metadata.
Apr 11 2022, 11:07 AM · Unknown Object (Project), Restricted Project

Apr 8 2022

saiislam committed rG0f6cbdee5761: [clang-offload-bundler] fix "no output file" issue with -outputs (authored by scchan).
[clang-offload-bundler] fix "no output file" issue with -outputs
Apr 8 2022, 10:12 AM · Unknown Object (Project), Restricted Project
saiislam closed D123387: [clang-offload-bundler] fix "no output file" issue with -outputs.
Apr 8 2022, 10:12 AM · Restricted Project, Unknown Object (Project)
saiislam accepted D123387: [clang-offload-bundler] fix "no output file" issue with -outputs.

Does this mean without this fix clang-offload-bundler emits an error if -outputs option not given? How could the lit tests passed?

Apr 8 2022, 9:45 AM · Restricted Project, Unknown Object (Project)

Mar 30 2022

saiislam added a comment to D122069: [Object] Add binary format for bundling offloading metadata.

Hey @jhuber6 , as discussed in multi-company meeting, I think that we will need at least an arch field somewhere in this. We would like to create multi-arch binaries so that runtime can load the compatible one on its own.
You may even consider using TargetID Format to store the list of archs.

Mar 30 2022, 8:09 AM · Restricted Project, Unknown Object (Project), Restricted Project

Mar 29 2022

saiislam accepted D122652: [libomptarget][test] add return 0 to map_back_race.cpp.

LGTM

Mar 29 2022, 6:42 AM · Unknown Object (Project), Restricted Project

Mar 2 2022

saiislam committed rG1e78d07dc9cd: [clang-offload-bundler] Fix typo in a test case (authored by saiislam).
[clang-offload-bundler] Fix typo in a test case
Mar 2 2022, 5:34 AM · Restricted Project

Mar 1 2022

saiislam committed rG7a02abf06ff9: [clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous… (authored by saiislam).
[clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous…
Mar 1 2022, 11:56 PM · Restricted Project
saiislam closed D120697: [clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous archive library.
Mar 1 2022, 11:56 PM · Restricted Project, Unknown Object (Project)

Feb 28 2022

saiislam requested review of D120697: [clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous archive library.
Feb 28 2022, 10:46 PM · Restricted Project, Unknown Object (Project)

Feb 22 2022

saiislam added a comment to D120271: [Clang] Add offload kind to embedded offload object.

Will it be possible to use Bundle Entry ID format [1] for naming sections and being sort of the the primary key to refer an offload object?
The arch string following the triple will be just offload-arch (or march, or mcpu) for others, but for amdgpu it may contain some more information.

Feb 22 2022, 9:43 AM · Restricted Project, Unknown Object (Project)

Feb 8 2022

saiislam committed rG4db88a54b6d4: [OpenMP][Clang] Move partial support of reverse offload to a future version (authored by saiislam).
[OpenMP][Clang] Move partial support of reverse offload to a future version
Feb 8 2022, 11:13 PM
saiislam closed D119256: [OpenMP][Clang] Move partial support of reverse offload to a future version.
Feb 8 2022, 11:12 PM · Restricted Project, Unknown Object (Project)
saiislam requested review of D119256: [OpenMP][Clang] Move partial support of reverse offload to a future version.
Feb 8 2022, 8:44 AM · Restricted Project, Unknown Object (Project)

Feb 4 2022

saiislam committed rGae9c0740648f: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading (authored by saiislam).
[OpenMP][Clang] Allow ancestor device modifier only with reverse offloading
Feb 4 2022, 4:17 AM
saiislam closed D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading.
Feb 4 2022, 4:17 AM · Unknown Object (Project)

Feb 3 2022

saiislam updated the diff for D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading.

Restored device ancestor codegen unit test with requires reverese_offload.

Feb 3 2022, 5:26 AM · Unknown Object (Project)
saiislam added inline comments to D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading.
Feb 3 2022, 5:14 AM · Unknown Object (Project)
saiislam requested review of D118887: [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading.
Feb 3 2022, 3:49 AM · Unknown Object (Project)

Jan 31 2022

saiislam added a comment to D116544: [Clang] Introduce Clang Linker Wrapper Tool.

Can you please add this tool's doc in clang/docs?

Jan 31 2022, 9:26 AM · Unknown Object (Project)

Jan 27 2022

saiislam added a comment to rG876b5ea96bf5: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective….

ParseOpenMP.cpp was part of the "previously 100% clang-formatted files" ./clang/docs/tools/clang-formatted-files.txt

This commit contains code changes that are not clang-formatted

--- a/clang/lib/Parse/ParseOpenMP.cpp
+++ b/clang/lib/Parse/ParseOpenMP.cpp
@@ -2210,12 +2210,12 @@ Parser::DeclGroupPtrTy Parser::ParseOpenMPDeclarativeDirectiveWithExtDecl(
     VariantMatchInfo VMI;
     TI.getAsVariantMatchInfo(ASTCtx, VMI);

-    std::function<void(StringRef)> DiagUnknownTrait = [this, Loc](
-                                                          StringRef ISATrait) {
-      // TODO Track the selector locations in a way that is accessible here to
-      // improve the diagnostic location.
-      Diag(Loc, diag::warn_unknown_declare_variant_isa_trait) << ISATrait;
-    };
+    std::function<void(StringRef)> DiagUnknownTrait =
+        [this, Loc](StringRef ISATrait) {
+          // TODO Track the selector locations in a way that is accessible here
+          // to improve the diagnostic location.
+          Diag(Loc, diag::warn_unknown_declare_variant_isa_trait) << ISATrait;
+        };
     TargetOMPContext OMPCtx(
         ASTCtx, std::move(DiagUnknownTrait),
         /* CurrentFunctionDecl */ nullptr,
@@ -2551,12 +2551,12 @@ Parser::ParseOpenMPDeclarativeOrExecutableDirective(ParsedStmtContext StmtCtx) {
     TPA.Revert();
     // End of the first iteration. Parser is reset to the start of metadirective

-    std::function<void(StringRef)> DiagUnknownTrait = [this, Loc](
-                                                          StringRef ISATrait) {
-      // TODO Track the selector locations in a way that is accessible here to
-      // improve the diagnostic location.
-      Diag(Loc, diag::warn_unknown_declare_variant_isa_trait) << ISATrait;
-    };
+    std::function<void(StringRef)> DiagUnknownTrait =
+        [this, Loc](StringRef ISATrait) {
+          // TODO Track the selector locations in a way that is accessible here
+          // to improve the diagnostic location.
+          Diag(Loc, diag::warn_unknown_declare_variant_isa_trait) << ISATrait;
+        };
     TargetOMPContext OMPCtx(ASTContext, std::move(DiagUnknownTrait),
                             /* CurrentFunctionDecl */ nullptr,
                             ArrayRef<llvm::omp::TraitProperty>());
Jan 27 2022, 1:03 AM
saiislam committed rG52fddcdd9c90: [clang-format] Format ParseOpenMP.cpp changes (authored by saiislam).
[clang-format] Format ParseOpenMP.cpp changes
Jan 27 2022, 1:02 AM

Jan 19 2022

saiislam added a comment to D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool.

It seems that this patch along with D117156 and D117246 is giving patch application failed error [https://buildkite.com/llvm-project/diff-checks/builds/82688].
arc patch is also giving the same error.

Jan 19 2022, 11:18 AM · Restricted Project, Unknown Object (Project)
saiislam committed rG6ee965471363: [Doc] Fix wrong indentation (authored by saiislam).
[Doc] Fix wrong indentation
Jan 19 2022, 3:16 AM
saiislam committed rG0731f6ba4f57: [Doc] Add documentation for the clang-offload-wrapper tool (NFC) (authored by saiislam).
[Doc] Add documentation for the clang-offload-wrapper tool (NFC)
Jan 19 2022, 2:46 AM
saiislam closed D117120: [Doc] Add documentation for the clang-offload-wrapper tool (NFC).
Jan 19 2022, 2:46 AM · Unknown Object (Project)

Jan 18 2022

saiislam added a comment to D117120: [Doc] Add documentation for the clang-offload-wrapper tool (NFC).

Ping :-)

Jan 18 2022, 9:03 AM · Unknown Object (Project)

Jan 12 2022

saiislam requested review of D117120: [Doc] Add documentation for the clang-offload-wrapper tool (NFC).
Jan 12 2022, 7:55 AM · Unknown Object (Project)

Jan 11 2022

saiislam committed rG876b5ea96bf5: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective… (authored by saiislam).
[OpenMP][Clang] Allow passing target features in ISA trait for metadirective…
Jan 11 2022, 9:26 PM
saiislam closed D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause.
Jan 11 2022, 9:26 PM · Unknown Object (Project)
saiislam updated the diff for D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause.
  1. Used a common diagnostic warning warn_unknown_declare_variant_isa_trait for ParseOpenMP and SemaOpenMP for decalre variant and metadirectives.
  2. Split lit codegen tests into two files, one requiring amdgpu-registered target and another for host only.
  3. Added warning message lit test at an appropriate place.
Jan 11 2022, 3:51 AM · Unknown Object (Project)

Jan 10 2022

saiislam added inline comments to D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause.
Jan 10 2022, 7:06 AM · Unknown Object (Project)
saiislam updated the diff for D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause.

Fixed the lit test failing in pre-check build bot.

Jan 10 2022, 6:41 AM · Unknown Object (Project)

Jan 7 2022

saiislam updated the diff for D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause.

Added diagnostic remarks for when ISA trait is not selected.

Jan 7 2022, 9:42 AM · Unknown Object (Project)

Jan 6 2022

saiislam updated the diff for D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause.

Added target specific tests for ISA traits, for CPU as well as GPU.

Jan 6 2022, 8:40 AM · Unknown Object (Project)
saiislam added a comment to D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause.

Can you make the test check for the diagnose message? Also, do we have a test to verify an isa trait is properly handled?

Jan 6 2022, 8:39 AM · Unknown Object (Project)

Jan 4 2022

saiislam committed rG49f23afdc345: [OpenMP] Add nec and nvidia as compiler vendors for OpenMP (authored by saiislam).
[OpenMP] Add nec and nvidia as compiler vendors for OpenMP
Jan 4 2022, 4:31 AM
saiislam closed D116540: [OpenMP] Add nec and nvidia as compiler vendors for OpenMP.
Jan 4 2022, 4:31 AM · Unknown Object (Project), Restricted Project
saiislam added a comment to D111545: [Clang][NFC] Fix multiline comment prefixes in function headers.

Nit: That is more correct, but actually, you normally make the comment match the param name (I think there might even be a clang-tidy check for that?)

i.e.

/*isBitCodeSDL=*/
Jan 4 2022, 3:54 AM · Unknown Object (Project)
saiislam committed rG32357266fd05: [Clang][NFC] Fix multiline comment prefixes in function headers (authored by saiislam).
[Clang][NFC] Fix multiline comment prefixes in function headers
Jan 4 2022, 3:54 AM
saiislam closed D111545: [Clang][NFC] Fix multiline comment prefixes in function headers.
Jan 4 2022, 3:53 AM · Unknown Object (Project)

Jan 3 2022

saiislam added a comment to D116540: [OpenMP] Add nec and nvidia as compiler vendors for OpenMP.
  1. I don't know why "pgi" is present here as a vendor. Should it be renamed as nvidia instead? @Meinersbur @tra

It was in the spec list and I would not remove it now.

Specs 5.0 and 5.1 linked above doesn't contain PGI as a vendor. But, we can leave it as is.

Jan 3 2022, 11:12 AM · Unknown Object (Project), Restricted Project
saiislam retitled D116540: [OpenMP] Add nec and nvidia as compiler vendors for OpenMP from [OpenMP] Add nvidia as a compiler vendor for OpenMP to [OpenMP] Add nec and nvidia as compiler vendors for OpenMP.
Jan 3 2022, 11:03 AM · Unknown Object (Project), Restricted Project
saiislam updated the diff for D116540: [OpenMP] Add nec and nvidia as compiler vendors for OpenMP.
  1. Added nec as compiler vendor.
  2. Fixed clang test cases.
Jan 3 2022, 11:02 AM · Unknown Object (Project), Restricted Project
saiislam requested review of D116549: [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause.
Jan 3 2022, 10:46 AM · Unknown Object (Project)
saiislam updated subscribers of D116540: [OpenMP] Add nec and nvidia as compiler vendors for OpenMP.
  1. I don't know why "pgi" is present here as a vendor. Should it be renamed as nvidia instead? @Meinersbur @tra
  2. Should "cray" be renamed as "hpe" here? @sandoval
  3. Should this vendor list be reordered as per Spec 5.1 [https://www.openmp.org/wp-content/uploads/OpenMP-API-Additional-Definitions-2-0.pdf] ?
Jan 3 2022, 9:05 AM · Unknown Object (Project), Restricted Project
saiislam requested review of D116540: [OpenMP] Add nec and nvidia as compiler vendors for OpenMP.
Jan 3 2022, 8:59 AM · Unknown Object (Project), Restricted Project
saiislam updated the diff for D111545: [Clang][NFC] Fix multiline comment prefixes in function headers.

Updated comments as per suggestion. Apologies for the delay.

Jan 3 2022, 8:40 AM · Unknown Object (Project)

Oct 12 2021

saiislam added inline comments to D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper.
Oct 12 2021, 9:16 AM · Unknown Object (Project)
saiislam committed rGf56548829c4c: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper (authored by saiislam).
[Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper
Oct 12 2021, 9:16 AM
saiislam closed D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper.
Oct 12 2021, 9:16 AM · Unknown Object (Project)
saiislam updated the diff for D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper.

clang-format(ed).

Oct 12 2021, 5:16 AM · Unknown Object (Project)
saiislam updated the summary of D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper.
Oct 12 2021, 5:14 AM · Unknown Object (Project)
saiislam updated the diff for D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper.

Thanks, Michael and Artem!

Oct 12 2021, 5:14 AM · Unknown Object (Project)
saiislam updated the diff for D111545: [Clang][NFC] Fix multiline comment prefixes in function headers.

Used comment style for named parameters.

Oct 12 2021, 3:56 AM · Unknown Object (Project)

Oct 11 2021

saiislam added inline comments to D105191: [Clang][OpenMP] Add partial support for Static Device Libraries.
Oct 11 2021, 6:55 AM · Unknown Object (Project)
saiislam requested review of D111545: [Clang][NFC] Fix multiline comment prefixes in function headers.
Oct 11 2021, 6:54 AM · Unknown Object (Project)
saiislam updated the diff for D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper.

Fixed typo

Oct 11 2021, 5:12 AM · Unknown Object (Project)
saiislam updated the summary of D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper.
Oct 11 2021, 5:06 AM · Unknown Object (Project)
saiislam updated the diff for D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper.
  1. Changed the option from path to nvlink-command.
  2. Command line arguments are now parsed using proper API.
Oct 11 2021, 5:05 AM · Unknown Object (Project)

Oct 9 2021

saiislam added a comment to rG35ebe4cc24f8: [Clang][OpenMP] Add partial support for Static Device Libraries.

This has broken the openmp-offload-cuda buildbots. For instance: http://meinersbur.de:8011/#/builders/1/builds/1516

******************** TEST 'libomptarget :: nvptx64-nvidia-cuda :: api/omp_get_num_devices.c' FAILED ********************
Script:
--
: 'RUN: at line 1';   /home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/./bin/clang -fopenmp  -fno-experimental-isel --cuda-path=/usr/local/cuda  -I /home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.src/openmp/libomptarget/test -I /home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -L /home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libomptarget -L /home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src  -Wl,-rpath,/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libomptarget -Wl,-rpath,/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -Wl,-rpath,/usr/local/cuda/lib64 --libomptarget-nvptx-bc-path=/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libomptarget -fopenmp-targets=nvptx64-nvidia-cuda /home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.src/openmp/libomptarget/test/api/omp_get_num_devices.c -o /home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libomptarget/test/nvptx64-nvidia-cuda/api/Output/omp_get_num_devices.c.tmp && /home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libomptarget/test/nvptx64-nvidia-cuda/api/Output/omp_get_num_devices.c.tmp | /home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/./bin/FileCheck /home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.src/openmp/libomptarget/test/api/omp_get_num_devices.c
--
Exit Code: 1
Command Output (stdout):
--
$ ":" "RUN: at line 1"
note: command had no output on stdout or stderr
$ "/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/./bin/clang" "-fopenmp" "-fno-experimental-isel" "--cuda-path=/usr/local/cuda" "-I" "/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.src/openmp/libomptarget/test" "-I" "/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src" "-L" "/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libomptarget" "-L" "/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src" "-Wl,-rpath,/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libomptarget" "-Wl,-rpath,/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src" "-Wl,-rpath,/usr/local/cuda/lib64" "--libomptarget-nvptx-bc-path=/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libomptarget" "-fopenmp-targets=nvptx64-nvidia-cuda" "/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.src/openmp/libomptarget/test/api/omp_get_num_devices.c" "-o" "/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libomptarget/test/nvptx64-nvidia-cuda/api/Output/omp_get_num_devices.c.tmp"
# command stderr:
warning: linking module '/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libomptarget/libomptarget-nvptx-sm_61.bc': Linking two modules of different target triples: '/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libomptarget/libomptarget-nvptx-sm_61.bc' is 'nvptx64' whereas '/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.src/openmp/libomptarget/test/api/omp_get_num_devices.c' is 'nvptx64-nvidia-cuda'
 [-Wlinker-warnings]
1 warning generated.
/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/bin/clang-nvlink-wrapper: error: unable to find 'nvlink' in path
clang-14: error: nvlink command failed with exit code 1 (use -v to see invocation)
error: command failed with exit status: 1
--
********************

On the buildbot, nvlink is not in $PATH. Please use the nvlink executable in the path passed by --cuda-path

Oct 9 2021, 5:16 AM
saiislam requested review of D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper.
Oct 9 2021, 5:14 AM · Unknown Object (Project)

Oct 8 2021

saiislam added a comment to rG35ebe4cc24f8: [Clang][OpenMP] Add partial support for Static Device Libraries.

Thanks for reporting. Taking a look.

Oct 8 2021, 5:51 PM
saiislam committed rG35ebe4cc24f8: [Clang][OpenMP] Add partial support for Static Device Libraries (authored by saiislam).
[Clang][OpenMP] Add partial support for Static Device Libraries
Oct 8 2021, 2:38 AM

Oct 7 2021

saiislam added a reverting change for rG4c4117089599: [Clang][OpenMP] Add partial support for Static Device Libraries: rG94e2b0258a17: Revert "[Clang][OpenMP] Add partial support for Static Device Libraries".
Oct 7 2021, 7:14 AM
saiislam committed rG94e2b0258a17: Revert "[Clang][OpenMP] Add partial support for Static Device Libraries" (authored by saiislam).
Revert "[Clang][OpenMP] Add partial support for Static Device Libraries"
Oct 7 2021, 7:14 AM
saiislam added a reverting change for rG06404d5488ea: [Clang][OpenMP] Fix windows buildbot failure for D105191: rG3eb44f4d28df: Revert "[Clang][OpenMP] Fix windows buildbot failure for D105191".
Oct 7 2021, 7:14 AM
saiislam committed rG3eb44f4d28df: Revert "[Clang][OpenMP] Fix windows buildbot failure for D105191" (authored by saiislam).
Revert "[Clang][OpenMP] Fix windows buildbot failure for D105191"
Oct 7 2021, 7:14 AM
saiislam added a reverting change for D105191: [Clang][OpenMP] Add partial support for Static Device Libraries: rG94e2b0258a17: Revert "[Clang][OpenMP] Add partial support for Static Device Libraries".
Oct 7 2021, 7:14 AM · Restricted Project
saiislam added a reverting change for rG2baf7ad6d27f: [Clang][OpenMP] Fix fat archive tests for Mac and Windows: rG1097f48e3dc3: Revert "[Clang][OpenMP] Fix fat archive tests for Mac and Windows".
Oct 7 2021, 7:14 AM
saiislam committed rG1097f48e3dc3: Revert "[Clang][OpenMP] Fix fat archive tests for Mac and Windows" (authored by saiislam).
Revert "[Clang][OpenMP] Fix fat archive tests for Mac and Windows"
Oct 7 2021, 7:14 AM
saiislam added a reverting change for D111311: [Clang][OpenMP] Fix fat archive tests for Mac and Windows: rG1097f48e3dc3: Revert "[Clang][OpenMP] Fix fat archive tests for Mac and Windows".
Oct 7 2021, 7:14 AM · Restricted Project
saiislam added a comment to D105191: [Clang][OpenMP] Add partial support for Static Device Libraries.

Fix didn't help, still broken at least on Windows: http://45.33.8.238/win/46515/step_7.txt

Oct 7 2021, 6:50 AM · Restricted Project