User Details
- User Since
- Nov 15 2019, 2:59 AM (185 w, 1 d)
Tue, May 23
Mon, May 22
Jan 18 2023
Removed the unnecessary call to getArgs() and added test cases.
Jan 11 2023
Ping.
Ping.
Jan 4 2023
Thanks everyone for your review and comments!
I am going to address all of them in a series of smaller patches starting with D140784.
Fixed usage of CodeObjectVersion and ImplicitArgs size in the old plugin.
A separate patch will be required to support cov5 for the next gen plugin.
Dec 30 2022
Dec 9 2022
Oct 21 2022
LGTM!
Oct 12 2022
Thank you!
It is fixing our OpenMP smoke test failure.
Sep 23 2022
The patch looks fine to me.
Please wait for @tra 's final review.
Sep 12 2022
LGTM. Thank!
Sep 6 2022
Sep 5 2022
LGTM. Thanks!
I think we can not remove this initialization.
Apologies for the delay in response.
Sep 4 2022
LGTM. Thanks!
Aug 16 2022
Aug 12 2022
Aug 11 2022
LGTM. Thanks!
Jul 27 2022
In the multi-company OpenMP meeting, it was decided to defer this update.
So, please don't land this patch yet.
Jul 26 2022
Jul 25 2022
Jul 24 2022
Updated with StringMap and StringRef ADTs. Also refactored based on new formating style.
Jul 20 2022
Jul 13 2022
Jul 12 2022
Thanks, LGTM!
Jul 5 2022
Leftovers, if any, can be covered in a follow-up patch.
Jun 22 2022
Ping
Jun 17 2022
clang-formatted.
Jun 14 2022
Added comments for parseTargeID() .
Forgot to invert the condition in an if block.
Jun 8 2022
Jun 2 2022
Could you please add support for HSA_ISA_INFO_NAME using hsa_isa_get_info_alt?
This one gives triple and target ID information, like amdgcn-amd-amdhsa--gfx908:sramecc-:xnack-
Jun 1 2022
Added the multi-entry logic in libomptarget. Yet to move the image compatibility testing to plugin.
May 26 2022
Thanks for the detailed review. I will update rest of the patch soon.
Addressed some simple review changes. Will update remaining in the next iteration.
May 25 2022
Changed the embedding scheme to add ImageInfo field in __tgt_device_image.
May 6 2022
Thanks!
LGTM.
Ideally we could just put this on the linker itself, but nvlink doesn't seem to support .a files.
Looks good to me.
May 2 2022
May 1 2022
Apr 28 2022
Apr 27 2022
Apr 12 2022
Apr 11 2022
Apr 8 2022
Mar 30 2022
Hey @jhuber6 , as discussed in multi-company meeting, I think that we will need at least an arch field somewhere in this. We would like to create multi-arch binaries so that runtime can load the compatible one on its own.
You may even consider using TargetID Format to store the list of archs.
Mar 29 2022
LGTM
Mar 2 2022
Mar 1 2022
Feb 28 2022
Feb 22 2022
Will it be possible to use Bundle Entry ID format [1] for naming sections and being sort of the the primary key to refer an offload object?
The arch string following the triple will be just offload-arch (or march, or mcpu) for others, but for amdgpu it may contain some more information.
Feb 8 2022
Feb 4 2022
Feb 3 2022
Restored device ancestor codegen unit test with requires reverese_offload.
Jan 31 2022
Can you please add this tool's doc in clang/docs?
Jan 27 2022
Jan 19 2022
It seems that this patch along with D117156 and D117246 is giving patch application failed error [https://buildkite.com/llvm-project/diff-checks/builds/82688].
arc patch is also giving the same error.
Jan 18 2022
Ping :-)