Meinersbur (Michael Kruse)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 17 2015, 7:07 AM (126 w, 5 d)

Recent Activity

Sun, Nov 19

Meinersbur updated the diff for D40122: [WIP] Add isl to LLVM repository..

Remove duplicated empty lines.

Sun, Nov 19, 1:31 PM
Meinersbur added a comment to D39971: Port ScopInfo to the isl cpp bindings.

Looks great (whatever you decide to to with the inline comment)

Sun, Nov 19, 10:25 AM

Thu, Nov 16

Meinersbur added a comment to D40126: [Polly] [PCGCodeGen] Change printf to outs() to prevent garbled output. [NFC].

Shouldn't this actually go to errs() instead?

Thu, Nov 16, 7:39 AM
Meinersbur added a reviewer for D40122: [WIP] Add isl to LLVM repository.: philip.pfaffe.
Thu, Nov 16, 5:22 AM
Meinersbur added a dependency for D40122: [WIP] Add isl to LLVM repository.: D40123: Add isl and imath..
Thu, Nov 16, 5:18 AM
Meinersbur added a dependent revision for D40123: Add isl and imath.: D40122: [WIP] Add isl to LLVM repository..
Thu, Nov 16, 5:18 AM
Meinersbur created D40123: Add isl and imath..
Thu, Nov 16, 5:18 AM
Meinersbur created D40122: [WIP] Add isl to LLVM repository..
Thu, Nov 16, 5:10 AM

Tue, Nov 14

Meinersbur added a comment to D39971: Port ScopInfo to the isl cpp bindings.

I cannot apply this patch, arcanist always tries to apply it on git sha1 85a1620 (current trunk without D39979).

Tue, Nov 14, 7:40 AM
Meinersbur accepted D39971: Port ScopInfo to the isl cpp bindings.

LGTM, only nitpicks. Thanks for your work.

Tue, Nov 14, 7:28 AM
Meinersbur added a dependent revision for D39979: [Polly][SI] Fix a potential use-after-free: D39971: Port ScopInfo to the isl cpp bindings.
Tue, Nov 14, 7:27 AM
Meinersbur added a dependency for D39971: Port ScopInfo to the isl cpp bindings: D39979: [Polly][SI] Fix a potential use-after-free.
Tue, Nov 14, 7:27 AM
Meinersbur accepted D39979: [Polly][SI] Fix a potential use-after-free.

LGMT, thanks.

Tue, Nov 14, 6:35 AM

Thu, Nov 9

Meinersbur committed rL317808: Update formatting to reflect change in clang-format. NFC..
Update formatting to reflect change in clang-format. NFC.
Thu, Nov 9, 8:33 AM

Mon, Nov 6

Meinersbur committed rL317495: [ForwardOpTree] Limit isl operations of known content reload..
[ForwardOpTree] Limit isl operations of known content reload.
Mon, Nov 6, 9:49 AM
Meinersbur accepted D39683: [Polly] Fix using order, as this caused a test failure (NFC) .

LGTM, fails for me too. Probably caused by change in clang-format: rL317325

Mon, Nov 6, 6:23 AM

Tue, Oct 31

Meinersbur committed rL317008: [ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values..
[ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values.
Tue, Oct 31, 9:12 AM
Meinersbur closed D39333: [Polly][ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values. by committing rL317008: [ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values..
Tue, Oct 31, 9:12 AM · Restricted Project
Meinersbur committed rL316995: [DeLICM] Fix wrong assumed access execution order..
[DeLICM] Fix wrong assumed access execution order.
Tue, Oct 31, 5:50 AM
Meinersbur abandoned D38308: [Polly][isl++] Define dump() functions in translation unit. NFC..

Abandon because the alternative was committed

Tue, Oct 31, 3:31 AM

Mon, Oct 30

Meinersbur added inline comments to D39333: [Polly][ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values..
Mon, Oct 30, 7:33 AM · Restricted Project
Meinersbur updated the diff for D39333: [Polly][ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values..
  • Address Siddharth's remarks
  • Fix one more TODO
Mon, Oct 30, 7:17 AM · Restricted Project
Meinersbur updated the diff for D39333: [Polly][ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values..
  • Introduce isNormalizable to resolve TODO
  • Remove unused function attributes in test-case
  • Add example to NormalizedPHI doxygen
Mon, Oct 30, 3:01 AM · Restricted Project

Fri, Oct 27

Meinersbur committed rL316769: [ForwardOpTree] Use space indention. NFC..
[ForwardOpTree] Use space indention. NFC.
Fri, Oct 27, 7:49 AM
Meinersbur committed rL316766: [ForwardOpTree] Reload know values..
[ForwardOpTree] Reload know values.
Fri, Oct 27, 7:26 AM
Meinersbur closed D39325: [Polly][ForwardOpTree] Reload know values. by committing rL316766: [ForwardOpTree] Reload know values..
Fri, Oct 27, 7:26 AM · Restricted Project
Meinersbur added a comment to D39364: [Polly][acc] Do not statically dispatch into IslNodeBuilder's createFor.

For me this is OK. We cannot reliably test undefined behavior. Tools like TypeSanitizer exist for this purpose.

Fri, Oct 27, 4:51 AM
Meinersbur accepted D39364: [Polly][acc] Do not statically dispatch into IslNodeBuilder's createFor.

LGTM

Fri, Oct 27, 2:23 AM

Thu, Oct 26

Meinersbur added a dependent revision for D39325: [Polly][ForwardOpTree] Reload know values.: D39333: [Polly][ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values..
Thu, Oct 26, 8:40 AM · Restricted Project
Meinersbur added a dependency for D39333: [Polly][ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values.: D39325: [Polly][ForwardOpTree] Reload know values..
Thu, Oct 26, 8:40 AM · Restricted Project
Meinersbur updated the diff for D39333: [Polly][ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values..

Add selfrefphi test case

Thu, Oct 26, 8:39 AM · Restricted Project
Meinersbur created D39333: [Polly][ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values..
Thu, Oct 26, 8:19 AM · Restricted Project
Meinersbur created D39325: [Polly][ForwardOpTree] Reload know values..
Thu, Oct 26, 1:41 AM · Restricted Project
Meinersbur committed rL316642: [DeLICM] Add more tests for loop layouts. NFC..
[DeLICM] Add more tests for loop layouts. NFC.
Thu, Oct 26, 1:03 AM

Tue, Oct 24

Meinersbur committed rL316464: [opt] Initialize WriteBitcode pass..
[opt] Initialize WriteBitcode pass.
Tue, Oct 24, 10:17 AM
Meinersbur closed D39223: [opt] Initialize WriteBitcode pass. by committing rL316464: [opt] Initialize WriteBitcode pass..
Tue, Oct 24, 10:17 AM
Meinersbur added a comment to D39223: [opt] Initialize WriteBitcode pass..

Alternatively, is there an initializeBitcode{Reader/Writer}() function that initializes all passes from the Bitcode lib?

The reader and writer are in separate libraries, aren't they?

Tue, Oct 24, 10:00 AM
Meinersbur committed rL316459: [ZoneAlgo] Translate addArrayWriteAccess to isl++. NFC..
[ZoneAlgo] Translate addArrayWriteAccess to isl++. NFC.
Tue, Oct 24, 9:40 AM
Meinersbur committed rL316445: [ISLTools] Translate computeReachingWrite to isl++. NFC..
[ISLTools] Translate computeReachingWrite to isl++. NFC.
Tue, Oct 24, 8:20 AM
Meinersbur committed rL316432: [DeLICM] Do not try to map to multiple array elements..
[DeLICM] Do not try to map to multiple array elements.
Tue, Oct 24, 6:05 AM
Meinersbur created D39223: [opt] Initialize WriteBitcode pass..
Tue, Oct 24, 1:40 AM

Oct 20 2017

Meinersbur added a comment to D38953: Updating the TipsAndTricks.rst documentation of Polly related to bugpoint.

Could you check whether this works for you:

Oct 20 2017, 6:51 PM · Restricted Project

Oct 17 2017

Meinersbur added a comment to D38953: Updating the TipsAndTricks.rst documentation of Polly related to bugpoint.

Thanks for improving our documentation!

Oct 17 2017, 1:52 PM · Restricted Project

Oct 6 2017

Meinersbur added a comment to D37337: [Polly] Split statements on encountering store instructions..

Please add at least one test case where a basic block is successfully split up and check that there are two statements now.

Oct 6 2017, 2:13 AM · Restricted Project

Oct 5 2017

Meinersbur committed rL314983: [ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option..
[ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option.
Oct 5 2017, 6:44 AM
Meinersbur closed D38403: [Polly][ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option. by committing rL314983: [ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option..
Oct 5 2017, 6:44 AM · Restricted Project
Meinersbur updated the diff for D38403: [Polly][ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option..
  • Address comments
  • Fix return instead of continue bug
Oct 5 2017, 4:13 AM · Restricted Project

Oct 4 2017

Meinersbur added inline comments to D38403: [Polly][ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option..
Oct 4 2017, 4:08 PM · Restricted Project
Meinersbur added a comment to D37337: [Polly] Split statements on encountering store instructions..

@Meinersbur : After your commit rL314665, these tests no longer fail.

Oct 4 2017, 9:59 AM · Restricted Project
Meinersbur added a comment to D38403: [Polly][ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option..

Hi Michael,

thanks for the update. Is the commit message up-to-date (AKA is the WIP still open or has it been resolved). Would be good to know before I start a more in-depth review!

Oct 4 2017, 5:57 AM · Restricted Project
Meinersbur updated the summary of D38403: [Polly][ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option..
Oct 4 2017, 5:55 AM · Restricted Project
Meinersbur added a comment to D38403: [Polly][ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option..

ForwardOpTree cannot forward everything, only 'speculatable' instructions and loads that are known to not have changed.

Ok. So, this option will, in future cover https://reviews.llvm.org/D37337#859617 ?

Oct 4 2017, 5:32 AM · Restricted Project
Meinersbur retitled D38403: [Polly][ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option. from [Polly][ScopBuilder][WIP] Introduce -polly-stmt-granularity=scalar-indep option. to [Polly][ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option..
Oct 4 2017, 5:26 AM · Restricted Project
Meinersbur updated the diff for D38403: [Polly][ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option..
  • Add unit tests
  • Refactor
  • Handle scalar dependencies due to incoming values
  • Add comments
Oct 4 2017, 5:26 AM · Restricted Project
Meinersbur committed rL314900: [ScopBuilder] Introduce -polly-stmt-granularity option. NFC..
[ScopBuilder] Introduce -polly-stmt-granularity option. NFC.
Oct 4 2017, 5:20 AM

Oct 2 2017

Meinersbur committed rL314664: [ScopBuilder] Build invariant loads separately..
[ScopBuilder] Build invariant loads separately.
Oct 2 2017, 4:43 AM
Meinersbur committed rL314665: [ScopBuilder] Iterate over statement instructions. NFC..
[ScopBuilder] Iterate over statement instructions. NFC.
Oct 2 2017, 4:43 AM
Meinersbur committed rL314663: [ScopBuilder] Build escaping dependencies separately..
[ScopBuilder] Build escaping dependencies separately.
Oct 2 2017, 4:43 AM
Meinersbur committed rL314662: [ScopBuilder] Specialize exit block handling. NFC..
[ScopBuilder] Specialize exit block handling. NFC.
Oct 2 2017, 4:43 AM
Meinersbur committed rL314661: [ForwardOpTree] Fix out-of-quota in assertion..
[ForwardOpTree] Fix out-of-quota in assertion.
Oct 2 2017, 4:42 AM

Oct 1 2017

Meinersbur committed rL314636: [ScopDetect] Do not add loads out of the SCoP to required invariant loads..
[ScopDetect] Do not add loads out of the SCoP to required invariant loads.
Oct 1 2017, 3:21 PM

Sep 29 2017

Meinersbur committed rL314525: [Polly] Add dumpPw() and dumpExpanded() functions. NFC..
[Polly] Add dumpPw() and dumpExpanded() functions. NFC.
Sep 29 2017, 8:47 AM
Meinersbur closed D38349: [Polly] Add dumpPw() and dumpExpanded() functions. NFC. by committing rL314525: [Polly] Add dumpPw() and dumpExpanded() functions. NFC..
Sep 29 2017, 8:47 AM
Meinersbur committed rL314519: [ScopBuilder] Fix typo. NFC..
[ScopBuilder] Fix typo. NFC.
Sep 29 2017, 8:14 AM
Meinersbur closed D38322: [Polly] Fix typo. NFC. by committing rL314519: [ScopBuilder] Fix typo. NFC..
Sep 29 2017, 8:14 AM · Restricted Project
Meinersbur added a comment to D38403: [Polly][ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option..

@Meinersbur : A quick q. Even if the split introduced new scalar dependences, wouldnt forward op tree pass take care of it?

Sep 29 2017, 8:07 AM · Restricted Project
Meinersbur created D38403: [Polly][ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option..
Sep 29 2017, 7:23 AM · Restricted Project

Sep 28 2017

Meinersbur added inline comments to D37337: [Polly] Split statements on encountering store instructions..
Sep 28 2017, 4:31 AM · Restricted Project
Meinersbur committed rL314395: [Support] Force instantiation of isl dump() methods. NFC..
[Support] Force instantiation of isl dump() methods. NFC.
Sep 28 2017, 2:52 AM
Meinersbur closed D38198: [Polly][Support] Force instatiation of isl dump() methods. NFC. by committing rL314395: [Support] Force instantiation of isl dump() methods. NFC..
Sep 28 2017, 2:52 AM · Restricted Project
Meinersbur created D38349: [Polly] Add dumpPw() and dumpExpanded() functions. NFC..
Sep 28 2017, 2:49 AM

Sep 27 2017

Meinersbur added a comment to D38198: [Polly][Support] Force instatiation of isl dump() methods. NFC..

For reference: the alternative is D38308.

Sep 27 2017, 2:25 AM · Restricted Project
Meinersbur updated the summary of D38308: [Polly][isl++] Define dump() functions in translation unit. NFC..
Sep 27 2017, 2:24 AM
Meinersbur created D38308: [Polly][isl++] Define dump() functions in translation unit. NFC..
Sep 27 2017, 1:25 AM

Sep 25 2017

Meinersbur created D38198: [Polly][Support] Force instatiation of isl dump() methods. NFC..
Sep 25 2017, 5:02 AM · Restricted Project

Sep 22 2017

Meinersbur committed rL313976: polly-update-format after change in clang-format. NFC..
polly-update-format after change in clang-format. NFC.
Sep 22 2017, 4:32 AM

Sep 21 2017

Meinersbur committed rL313902: [DeLICM] Allow non-injective PHIRead->PHIWrite mapping..
[DeLICM] Allow non-injective PHIRead->PHIWrite mapping.
Sep 21 2017, 12:10 PM

Sep 20 2017

Meinersbur committed rL313750: [ScheduleOptimizer] Fix and test schedule tree statistics..
[ScheduleOptimizer] Fix and test schedule tree statistics.
Sep 20 2017, 4:54 AM

Sep 19 2017

Meinersbur committed rL313690: [ForwardOpTree] Allow out-of-quota in examination part of forwardTree..
[ForwardOpTree] Allow out-of-quota in examination part of forwardTree.
Sep 19 2017, 3:55 PM
Meinersbur closed D37984: [Polly][ForwardOpTree] Allow out-of-quota in examination part of forwardTree. by committing rL313690: [ForwardOpTree] Allow out-of-quota in examination part of forwardTree..
Sep 19 2017, 3:54 PM · Restricted Project
Meinersbur accepted D37982: [Polly][WIP] Create polly statement for every instruction..
Sep 19 2017, 2:01 PM
Meinersbur added a comment to D37982: [Polly][WIP] Create polly statement for every instruction..

Thanks, looks good. I'll commit after D37337.

Sep 19 2017, 2:00 PM
Meinersbur added a comment to D37337: [Polly] Split statements on encountering store instructions..

Please add at least one test case for the new feature (splitting at stores).

Sep 19 2017, 1:51 PM · Restricted Project

Sep 18 2017

Meinersbur created D37984: [Polly][ForwardOpTree] Allow out-of-quota in examination part of forwardTree..
Sep 18 2017, 10:57 AM · Restricted Project
Meinersbur committed rL313546: [ForwardOpTree] Test the max operations quota..
[ForwardOpTree] Test the max operations quota.
Sep 18 2017, 10:45 AM
Meinersbur committed rL313527: [test] Enable -polly-codegen-verify for regression tests..
[test] Enable -polly-codegen-verify for regression tests.
Sep 18 2017, 5:35 AM
Meinersbur closed D37969: [Polly][test] Enable -polly-codegen-verify for regression tests. by committing rL313527: [test] Enable -polly-codegen-verify for regression tests..
Sep 18 2017, 5:35 AM · Restricted Project
Meinersbur committed rL313526: [ForwardOptTree] Remove redundant simplify(). NFC..
[ForwardOptTree] Remove redundant simplify(). NFC.
Sep 18 2017, 5:29 AM
Meinersbur created D37969: [Polly][test] Enable -polly-codegen-verify for regression tests..
Sep 18 2017, 4:48 AM · Restricted Project
Meinersbur added a comment to D37337: [Polly] Split statements on encountering store instructions..

Sorry for my absence for a while, a paper submission deadline came in the way.

Sep 18 2017, 4:06 AM · Restricted Project

Sep 9 2017

Meinersbur added a comment to D37571: [Polly][CodegenCleanup] Update cleanup passes according (old) PassManagerBuilder..

LGTM. It would be great to actually have a testcase for this, so we'd be able to see any changes earlier.

Sep 9 2017, 2:50 PM
Meinersbur committed rL312875: [CodegenCleanup] Update cleanup passes according (old) PassManagerBuilder..
[CodegenCleanup] Update cleanup passes according (old) PassManagerBuilder.
Sep 9 2017, 2:45 PM
Meinersbur closed D37571: [Polly][CodegenCleanup] Update cleanup passes according (old) PassManagerBuilder. by committing rL312875: [CodegenCleanup] Update cleanup passes according (old) PassManagerBuilder..
Sep 9 2017, 2:45 PM

Sep 7 2017

Meinersbur updated the diff for D37571: [Polly][CodegenCleanup] Update cleanup passes according (old) PassManagerBuilder..

Add ExpensiveCombines argument.

Sep 7 2017, 8:12 AM
Meinersbur created D37571: [Polly][CodegenCleanup] Update cleanup passes according (old) PassManagerBuilder..
Sep 7 2017, 8:11 AM

Sep 6 2017

Meinersbur committed rL312663: Revert "[ScopDetect/Info] Look through PHIs that follow an error block".
Revert "[ScopDetect/Info] Look through PHIs that follow an error block"
Sep 6 2017, 12:07 PM
Meinersbur committed rL312632: [test] Add forgotten REQUIRES: line..
[test] Add forgotten REQUIRES: line.
Sep 6 2017, 6:12 AM
Meinersbur committed rL312630: [ZoneAlgo] Handle non-StoreInst/LoadInst MemoryAccesses including memset..
[ZoneAlgo] Handle non-StoreInst/LoadInst MemoryAccesses including memset.
Sep 6 2017, 5:42 AM
Meinersbur closed D37362: [Polly][ZoneAlgo] Handle non-StoreInst/LoadInst MemoryAccesses including memset. by committing rL312630: [ZoneAlgo] Handle non-StoreInst/LoadInst MemoryAccesses including memset..
Sep 6 2017, 5:42 AM

Sep 3 2017

Meinersbur added a comment to D37424: [ForwardOp] Remove read accesses for all instructions that have been moved.

I assume that not everyone subscribed to llvm-commits knows that "ForwardOpTree"/"ForwardOp" is a component of Polly. The tag "[Polly]" might still be useful.

Sep 3 2017, 12:05 PM · Restricted Project