Page MenuHomePhabricator

Meinersbur (Michael Kruse)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 17 2015, 7:07 AM (291 w, 1 d)

Recent Activity

Wed, Jan 6

Meinersbur accepted D93778: [test-suite] Support Fortran tests in CMake infrastructure..

I expected more changes to be necessary, to make it work with litsupport modules, perf/timeit, statistics, compile time (Interestingly, CMAKE_Fortran_COMPILE_OBJECT is already defined), LNT, ... . But if we find they don't work yet, we can fix that later.

Wed, Jan 6, 2:41 PM
Meinersbur added inline comments to D93778: [test-suite] Support Fortran tests in CMake infrastructure..
Wed, Jan 6, 11:47 AM

Tue, Jan 5

Meinersbur added inline comments to D93665: [LoopNest] Allow empty basic blocks without loops.
Tue, Jan 5, 11:45 AM · Restricted Project
Meinersbur added inline comments to D93778: [test-suite] Support Fortran tests in CMake infrastructure..
Tue, Jan 5, 9:41 AM
Meinersbur accepted D94094: [DDG] Fix duplicate edge removal during pi-block formation.

Consider clang-format before pushing to main.

Tue, Jan 5, 9:36 AM · Restricted Project
Meinersbur accepted D93949: [DDG] Data Dependence Graph - DOT printer tests.

LGTM

Tue, Jan 5, 9:18 AM · Restricted Project
Meinersbur added reviewers for D93778: [test-suite] Support Fortran tests in CMake infrastructure.: aemerson, tra, kristof.beyls, lenary.
Tue, Jan 5, 8:41 AM
Meinersbur added inline comments to D93778: [test-suite] Support Fortran tests in CMake infrastructure..
Tue, Jan 5, 8:36 AM

Mon, Jan 4

Meinersbur accepted D93686: [LoopUnroll] Fix a crash.

LGTM, thank you.

Mon, Jan 4, 6:13 PM · Restricted Project
Meinersbur accepted D93665: [LoopNest] Allow empty basic blocks without loops.

LGTM

Mon, Jan 4, 10:06 AM · Restricted Project

Tue, Dec 22

Meinersbur added a comment to D93665: [LoopNest] Allow empty basic blocks without loops.

Alternatively, we could rely on SimplifyCFG to remote such empty BBs?

Tue, Dec 22, 1:48 PM · Restricted Project
Meinersbur added a comment to D84410: [LAA] Dynamically allocate RuntimeCheckingPtrGroup (NFC)..

I don't understand the motivation. Sharing RuntimeCheckingPtrGroup between multiple objects will increase coupling between them.

Tue, Dec 22, 1:35 PM · Restricted Project
Meinersbur added inline comments to D84411: [LoopVersion] Pass RuntimePointerChecking directly..
Tue, Dec 22, 1:11 PM · Restricted Project
Meinersbur added inline comments to D93686: [LoopUnroll] Fix a crash.
Tue, Dec 22, 11:10 AM · Restricted Project

Fri, Dec 18

Meinersbur added a comment to D93136: [test-suite] ClamAV CMake fix..

I would have done an unequal: if (NOT TARGET_OS STREQUAL "Darwin"). libIntl is part of the GNU user space environment, not the kernel, e.g. also apply to GNU/kFreeBSD.

Fri, Dec 18, 2:51 PM
Meinersbur added inline comments to D92974: [OpenMPIRBuilder] Implement tileLoops..
Fri, Dec 18, 1:05 PM · Restricted Project
Meinersbur updated the diff for D92974: [OpenMPIRBuilder] Implement tileLoops..
  • Address reviews
Fri, Dec 18, 1:04 PM · Restricted Project

Thu, Dec 17

Meinersbur added a comment to D92974: [OpenMPIRBuilder] Implement tileLoops..

ping

Thu, Dec 17, 12:56 PM · Restricted Project

Dec 15 2020

Meinersbur accepted D93136: [test-suite] ClamAV CMake fix..

LGTM

Dec 15 2020, 11:00 PM
Meinersbur added a comment to D93136: [test-suite] ClamAV CMake fix..

You are right, FindGettext seems to look for some commands, not the library.

Dec 15 2020, 10:29 AM

Dec 14 2020

Meinersbur added a comment to D90159: [DDG] Data Dependence Graph - DOT printer .

Can I help fixing the Windows build problem?

Dec 14 2020, 8:07 PM · Restricted Project, Restricted Project
Meinersbur requested review of D93268: [OpenMPIRBuilder] Implement collapseLoops..
Dec 14 2020, 7:41 PM · Restricted Project
Meinersbur accepted D90159: [DDG] Data Dependence Graph - DOT printer .

Thanks. Still LGTM.

Dec 14 2020, 1:24 PM · Restricted Project, Restricted Project
Meinersbur committed rG2aa43358060c: [flang] Fix copy elision assumption. (authored by Meinersbur).
[flang] Fix copy elision assumption.
Dec 14 2020, 12:08 PM
Meinersbur closed D88797: [flang] Fix copy elision assumption..
Dec 14 2020, 12:08 PM · Restricted Project, Restricted Project
Meinersbur accepted D93155: [test-suite] 7zip CMake fix..

LGTM

Dec 14 2020, 8:05 AM
Meinersbur retitled D93155: [test-suite] 7zip CMake fix. from 7zip CMake fix to [test-suite] 7zip CMake fix..
Dec 14 2020, 8:04 AM
Meinersbur requested changes to D93136: [test-suite] ClamAV CMake fix..

Usually system introspection happens in the top-level CMakeLists.txt, but test-suite allows to selectively include subdirs, so it is a good location to do here.

Dec 14 2020, 8:02 AM

Dec 11 2020

Meinersbur committed rG5577fb229d3c: [tests][OpenMPIRBuilder] Use EXPECT_EQ instead ASSERT_EQ. (authored by Meinersbur).
[tests][OpenMPIRBuilder] Use EXPECT_EQ instead ASSERT_EQ.
Dec 11 2020, 9:51 AM
Meinersbur committed rGba0265a8d865: [OpenMPIRBuilder] Various changes required for tileLoops. (authored by Meinersbur).
[OpenMPIRBuilder] Various changes required for tileLoops.
Dec 11 2020, 9:38 AM
Meinersbur closed D93088: [OpenMPIRBuilder] Various changes required for tileLoops..
Dec 11 2020, 9:37 AM · Restricted Project

Dec 10 2020

Meinersbur updated the diff for D92974: [OpenMPIRBuilder] Implement tileLoops..
  • Avoid pre-merge check warning about using auto for an iterator.
Dec 10 2020, 11:13 PM · Restricted Project
Meinersbur updated the diff for D92974: [OpenMPIRBuilder] Implement tileLoops..
  • Extract changes not directly related to tileLoop into D93088
  • Address pre-merge checks
Dec 10 2020, 11:03 PM · Restricted Project
Meinersbur requested review of D93088: [OpenMPIRBuilder] Various changes required for tileLoops..
Dec 10 2020, 10:43 PM · Restricted Project
Meinersbur committed rG86abc9a1192b: [OpenMPIRBuilder] Fix typo. NFC. (authored by Meinersbur).
[OpenMPIRBuilder] Fix typo. NFC.
Dec 10 2020, 10:16 PM
Meinersbur added inline comments to D92974: [OpenMPIRBuilder] Implement tileLoops..
Dec 10 2020, 10:12 PM · Restricted Project
Meinersbur added inline comments to D92055: [mlir] Add translation of omp.wsloop to LLVM IR.
Dec 10 2020, 9:26 PM · Restricted Project
Meinersbur committed rGbc633fe46bbe: [Polly] Consider InvalidContext to determine partial READ. (authored by Meinersbur).
[Polly] Consider InvalidContext to determine partial READ.
Dec 10 2020, 8:29 PM
Meinersbur added inline comments to D92055: [mlir] Add translation of omp.wsloop to LLVM IR.
Dec 10 2020, 10:31 AM · Restricted Project
Meinersbur abandoned D88793: [flang] Fix assumptions on std::forward_list iterator implementation..

Obsoleted by D91210

Dec 10 2020, 8:36 AM · Restricted Project, Restricted Project

Dec 9 2020

Meinersbur added inline comments to D92055: [mlir] Add translation of omp.wsloop to LLVM IR.
Dec 9 2020, 4:36 PM · Restricted Project
Meinersbur accepted D90159: [DDG] Data Dependence Graph - DOT printer .

Thanks, LGTM.

Dec 9 2020, 4:24 PM · Restricted Project, Restricted Project
Meinersbur added inline comments to D92055: [mlir] Add translation of omp.wsloop to LLVM IR.
Dec 9 2020, 3:25 PM · Restricted Project
Meinersbur added inline comments to D92974: [OpenMPIRBuilder] Implement tileLoops..
Dec 9 2020, 3:07 PM · Restricted Project
Meinersbur requested review of D92974: [OpenMPIRBuilder] Implement tileLoops..
Dec 9 2020, 2:46 PM · Restricted Project

Dec 8 2020

Meinersbur added inline comments to D92055: [mlir] Add translation of omp.wsloop to LLVM IR.
Dec 8 2020, 6:12 PM · Restricted Project
Meinersbur accepted D92849: [OpenMPIRBuilder] Put the barrier in the exit block in createWorkshapeLoop.

LGTM

Dec 8 2020, 9:02 AM · Restricted Project
Meinersbur added a comment to D92055: [mlir] Add translation of omp.wsloop to LLVM IR.

OMPBuilder part looks good to me, but probably an MLIR person should accept this patch.

Dec 8 2020, 8:59 AM · Restricted Project

Dec 7 2020

Meinersbur committed rG6249bfeefeed: [Polly][CodeGen] Remove use of ScalarEvolution. (authored by Meinersbur).
[Polly][CodeGen] Remove use of ScalarEvolution.
Dec 7 2020, 1:23 PM
Meinersbur accepted D92476: [OpenMPIRBuilder] introduce createStaticWorkshareLoop.

LGTM

Dec 7 2020, 10:20 AM · Restricted Project, Restricted Project

Dec 2 2020

Meinersbur accepted D91653: [LLVMFrontend][openacc] Add basic unit tests for functions in LLVMFrontendOpenACC.

Sorry for the wait. Phabricator did not send me notifications for the all the updates. Anyone has an idea why?

Dec 2 2020, 11:16 AM · Restricted Project
Meinersbur added inline comments to D92476: [OpenMPIRBuilder] introduce createStaticWorkshareLoop.
Dec 2 2020, 11:12 AM · Restricted Project, Restricted Project
Meinersbur added inline comments to D92476: [OpenMPIRBuilder] introduce createStaticWorkshareLoop.
Dec 2 2020, 11:09 AM · Restricted Project, Restricted Project
Meinersbur added inline comments to D92476: [OpenMPIRBuilder] introduce createStaticWorkshareLoop.
Dec 2 2020, 11:05 AM · Restricted Project, Restricted Project

Nov 27 2020

Meinersbur added a comment to D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function.

Looking at CodeGenFunction::GenerateOpenMPCapturedVars, the condition if (!CurField->getType()->isAnyPointerType()) seems to match what is done here, but I wonder whether it is always necessary. Is the additional indirection necessary for pointer-sized data types (e.g. intptr_t, or smaller)?

Nov 27 2020, 6:56 PM · Restricted Project, Restricted Project, Restricted Project
Meinersbur added a comment to D92055: [mlir] Add translation of omp.wsloop to LLVM IR.

So why not creating a OpenMPIRBuilder::createWorksharingLoop that can be used by clang as well?

Nov 27 2020, 6:26 PM · Restricted Project

Nov 25 2020

Meinersbur added a comment to D92055: [mlir] Add translation of omp.wsloop to LLVM IR.

The intent was to create a OpenMPIRBuilder::createWorksharingLoop that takes a CanonicalLoop as an argument to be workshared. The heavy lifting would be done by createWorksharingLoop such that its logic does not need to be duplicated by clang and the OpenMP dialect.

Nov 25 2020, 11:19 PM · Restricted Project

Nov 18 2020

Meinersbur added a comment to D91641: [CMake] Fix ExtensionDependencies.inc with multiple extensions.

There seems to be one set of braces too much, makes me wonder how it ever worked.

The « extra » set of brace was for list initialization, using that rule (from https://en.cppreference.com/w/cpp/language/list_initialization)

Otherwise, the constructors of T are considered, in two phases: 

    All constructors that take std::initializer_list as the only argument, or as the first argument if the remaining arguments have default values, are examined, and matched by overload resolution against a single argument of type std::initializer_list 

   If the previous stage does not produce a match, all constructors of T participate in overload resolution against the set of arguments that consists of the elements of the braced-init-list, with the restriction that only non-narrowing conversions are allowed. If this stage produces an explicit constructor  as the best match for a copy-list-initialization, compilation fails (note, in simple copy-initialization, explicit constructors are not considered at all).
Nov 18 2020, 10:50 AM · Restricted Project
Meinersbur committed rZORGdcfc5b668f39: Updates to ALCF Theta Buildbot (authored by naromero77).
Updates to ALCF Theta Buildbot
Nov 18 2020, 7:05 AM
Meinersbur closed D91400: Updates to ALCF Theta Buildbot.
Nov 18 2020, 7:05 AM · Restricted Project

Nov 17 2020

Meinersbur added a comment to D91536: honor Python2_EXECUTABLE and Python3_EXECUTABLE when they are passed to cmake.

Thank you for you the fix!

Nov 17 2020, 3:51 PM · Restricted Project
Meinersbur committed rG16de50895e96: honor Python2_EXECUTABLE and Python3_EXECUTABLE when they are passed to cmake (authored by robertu94).
honor Python2_EXECUTABLE and Python3_EXECUTABLE when they are passed to cmake
Nov 17 2020, 3:49 PM
Meinersbur closed D91536: honor Python2_EXECUTABLE and Python3_EXECUTABLE when they are passed to cmake.
Nov 17 2020, 3:49 PM · Restricted Project
Meinersbur added inline comments to D86071: [MLIR][OpenMP] Add omp.wsloop operation.
Nov 17 2020, 3:41 PM · Restricted Project, Restricted Project
Meinersbur accepted D91536: honor Python2_EXECUTABLE and Python3_EXECUTABLE when they are passed to cmake.

There might be other cmake configuration parameters used for introspection, such as ZLIB_INCLUDE_DIR (if using zlib), <PackageName>_ROOT etc.

Nov 17 2020, 2:57 PM · Restricted Project
Meinersbur added inline comments to D91653: [LLVMFrontend][openacc] Add basic unit tests for functions in LLVMFrontendOpenACC.
Nov 17 2020, 2:49 PM · Restricted Project
Meinersbur accepted D91641: [CMake] Fix ExtensionDependencies.inc with multiple extensions.

From the array element type, the compiler should know which type to brace-initialize. There seems to be one set of braces too much, makes me wonder how it ever worked.

Nov 17 2020, 2:43 PM · Restricted Project
Meinersbur added a reviewer for D91641: [CMake] Fix ExtensionDependencies.inc with multiple extensions: serge-sans-paille.
Nov 17 2020, 2:39 PM · Restricted Project
Meinersbur committed rG8fb4417d82bc: [LLVMFronted][tests] Add basic OpenMP parsing tests. (authored by Meinersbur).
[LLVMFronted][tests] Add basic OpenMP parsing tests.
Nov 17 2020, 1:45 PM
Meinersbur closed D91643: [LLVMFronted][tests] Add basic OpenMP parsing tests..
Nov 17 2020, 1:45 PM · Restricted Project, Restricted Project
Meinersbur requested review of D91643: [LLVMFronted][tests] Add basic OpenMP parsing tests..
Nov 17 2020, 9:36 AM · Restricted Project, Restricted Project

Nov 16 2020

Meinersbur committed rG33ca0b0ea619: [Polly] Add override qualifiers. (authored by Meinersbur).
[Polly] Add override qualifiers.
Nov 16 2020, 7:30 PM
Meinersbur committed rGfc115f2e73a2: [Polly] Move SimplifyVisitor into polly namespace. (authored by Meinersbur).
[Polly] Move SimplifyVisitor into polly namespace.
Nov 16 2020, 5:00 PM
Meinersbur added a comment to D91470: Switch libLLVMFrontendOpenACC to be a regular CMake library and not a "component".

We should dig in the OpenMP side as well.

What do you mean by that?

I mean that commenting out OMP.cpp here: https://github.com/llvm/llvm-project/blob/master/llvm/lib/Frontend/OpenMP/CMakeLists.txt#L6 and running ninja check-llvm just works.

Nov 16 2020, 2:54 PM · Restricted Project

Nov 14 2020

Meinersbur added inline comments to D91461: [build] normalize components dependencies.
Nov 14 2020, 8:57 PM · Restricted Project

Nov 13 2020

Meinersbur added a comment to D91468: [llvm] Add OpenACC as a dependency to llvm-config.

Is this obsolete after D91470 has been committed?

Nov 13 2020, 7:24 PM · Restricted Project
Meinersbur added a comment to D91470: Switch libLLVMFrontendOpenACC to be a regular CMake library and not a "component".

Like IRBuilder and OpenMPIRBuilder, I think the OpenACC stuff is meant to be used by frontends outside of LLVM (in the sense of /llvm/*) and thus should be exposed as a component and llvm-config, but tested independently of those outside users. OpenACC is standardized for C/C++ as well.

Nov 13 2020, 7:23 PM · Restricted Project
Meinersbur added a comment to D91461: [build] normalize components dependencies.

This looks like an overdue fix. Thanks.

Nov 13 2020, 2:04 PM · Restricted Project
Meinersbur updated subscribers of D90848: llvmbuildectomy - part 2.

There was an inconsistency in the LLVMBuild.txt for LLVM Frontend: OpenACC wasn't listed but it was part of the CMake infrastructure. A side effect of the llvmbuildectomy has been to remove that inconsistency and register OpenACC as a regular component.

Nov 13 2020, 1:53 PM · Restricted Project

Nov 12 2020

Meinersbur committed rG243511a24e5a: [Polly] Fix memory leak. (authored by Meinersbur).
[Polly] Fix memory leak.
Nov 12 2020, 6:05 PM

Nov 11 2020

Meinersbur accepted D91210: [flang][MSVC] Use list<Message> rather than forward_list<> in Messages.

LGTM

Nov 11 2020, 2:44 PM · Restricted Project, Restricted Project
Meinersbur accepted D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0.

Thanks, I wasn't aware of this. Looks like other opt -passes='default<O#>' tests also look at if it present or not.

Nov 11 2020, 2:33 PM · Restricted Project, Restricted Project
Meinersbur committed rGc8a0e27cfb83: [Polly][OpTree] Fix mid-processing change of access kind. (authored by Meinersbur).
[Polly][OpTree] Fix mid-processing change of access kind.
Nov 11 2020, 2:23 PM
Meinersbur committed rGc1cf51e77701: [Polly][OpTree] Better report applied changes. (authored by Meinersbur).
[Polly][OpTree] Better report applied changes.
Nov 11 2020, 2:22 PM
Meinersbur requested changes to D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0.

Could you try configuring LLVM with -DLLVM_BYE_LINK_INTO_TOOLS=ON? I assume the test will break because it unconditionally adds a FunctionPass.

Nov 11 2020, 9:04 AM · Restricted Project, Restricted Project

Nov 10 2020

Meinersbur accepted D90848: llvmbuildectomy - part 2.

This looks like a major simplification of the build system. Code looks good, I confirmed it is working for my Windows build, Polly (i.e. statically linked pass plugins) is listed with --libs.

Nov 10 2020, 4:26 PM · Restricted Project
Meinersbur accepted D90687: [LV] Clamp VF hint when unsafe.

Thanks, looks good to me.

Nov 10 2020, 1:46 PM · Restricted Project
Meinersbur committed rGe408935bb533: [Polly][ScopBuilder] Use only modeled instructions to compute statement… (authored by Meinersbur).
[Polly][ScopBuilder] Use only modeled instructions to compute statement…
Nov 10 2020, 1:31 PM
Meinersbur committed rZORG487c8cb1080a: Worker for Theta supercomputer at ALCF with Flang builder (authored by naromero77).
Worker for Theta supercomputer at ALCF with Flang builder
Nov 10 2020, 12:39 PM
Meinersbur closed D90986: Worker for Theta supercomputer at ALCF with Flang builder.
Nov 10 2020, 12:39 PM · Restricted Project

Nov 9 2020

Meinersbur added a comment to D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0.

My point is that it is possible for a pass plugin (such as llvm/examples/Bye) that can add themselves to the -O0 pipeline. If those plugins are linked statically, it will break tests that assume that no passes are added at those extension points.

Nov 9 2020, 6:13 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0.

Are there passes that should be running at -O0 that aren't target specific? Otherwise the callbacks should only add passes if the optimization level isn't -O0.

Nov 9 2020, 5:51 PM · Restricted Project, Restricted Project
Meinersbur committed rGe5dba2d7e5a6: [OMPIRBuilder] Start 'Create' methods with lower case. NFC. (authored by Meinersbur).
[OMPIRBuilder] Start 'Create' methods with lower case. NFC.
Nov 9 2020, 5:35 PM
Meinersbur closed D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC..
Nov 9 2020, 5:35 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Meinersbur updated the diff for D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC..

Last update pushed only the change

Nov 9 2020, 4:46 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Meinersbur updated the diff for D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC..

Missed reference of CreateXXXX in comments

Nov 9 2020, 4:44 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Meinersbur requested review of D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC..
Nov 9 2020, 4:39 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Meinersbur added inline comments to D90687: [LV] Clamp VF hint when unsafe.
Nov 9 2020, 4:26 PM · Restricted Project
Meinersbur added a comment to D90848: llvmbuildectomy - part 2.

Thanks for your effort. I love it. Seems to remove complexities of the buildsystem and the ugly split of having to define library dependencies in two files.

Nov 9 2020, 4:07 PM · Restricted Project
Meinersbur updated subscribers of D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0.

Did you consider just removing the -NEXT suffix? Polly might not be the only case, other statically linked pass-plugins may also insert themselves at extension points.

Nov 9 2020, 3:55 PM · Restricted Project, Restricted Project