Page MenuHomePhabricator

Meinersbur (Michael Kruse)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 17 2015, 7:07 AM (388 w, 3 d)

Recent Activity

Thu, Nov 17

Meinersbur added a comment to D137774: [openmp] Create a local llvm-lit script when building openmp standalone.

Why not using env LIT_FILTER=<testname> ninja check-openmp environment variable to run individual tests?

Thu, Nov 17, 2:35 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D137772: [openmp] [test] Set __COMPAT_LAYER=RunAsInvoker when running tests on Windows.

since it may think some of them are installers - executables with "dispatch" in the name may hit a heuristic looking for "patch"

Thu, Nov 17, 2:31 PM · Restricted Project, Restricted Project
Meinersbur accepted D137744: [openmp] Only try to add the -mrtm flag on i386/x86_64.

LGTM

Thu, Nov 17, 2:19 PM · Restricted Project, Restricted Project
Meinersbur accepted D137747: [openmp] [test] Fix warnings about printf format mismatches on Windows.

LGTM

Thu, Nov 17, 2:18 PM · Restricted Project, Restricted Project

Wed, Nov 16

Meinersbur added a comment to D137461: [LoopInterchange] Refactor and rewrite validDepInterchange().

The two changes (Direction == '*' and checking the dep vector before doing the interchange) may add safety, but also cause tests to fail. @bmahjour suggested we could mark those as XFAIL and fix in a followup-patch, if not directly handled in this patch. Thing that I think are two strict:

Wed, Nov 16, 10:20 AM · Restricted Project, Restricted Project, Restricted Project
Meinersbur added inline comments to D135808: [LoopInterchange] Correcting the profitability checking for vectorization.
Wed, Nov 16, 9:37 AM · Restricted Project, Restricted Project, Restricted Project
Meinersbur added a comment to D135808: [LoopInterchange] Correcting the profitability checking for vectorization.

Macro testcase:

Wed, Nov 16, 7:16 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Nov 14

Meinersbur added a comment to D132594: [flang] Fix msvc 17.3 build..

Microsoft's bugtracker indicates that this was fixed in msvc 19.34.31933 / VS17.4

Mon, Nov 14, 10:41 AM · Restricted Project, Restricted Project
Herald added a reviewer for D124823: [OpenMPIRBuilder] Introduce OMPRegionInfo managing the stack of OpenMP region constructs.: nicolasvasilache.

ping

Mon, Nov 14, 9:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, Nov 11

Meinersbur added reviewers for D137470: [Offloading] Initial support for registering offloading entries on COFF targets: mstorsjo, Bigcheese.
Fri, Nov 11, 2:44 PM · Restricted Project, Restricted Project, Restricted Project
Meinersbur accepted D137461: [LoopInterchange] Refactor and rewrite validDepInterchange().

This involves a deep copy of the entire DepMatrix. I still find that acceptable to gain a much more logical dependency checking.

Fri, Nov 11, 2:39 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Nov 10

Meinersbur updated the diff for D115218: [CodeExtractor] Refactor extractCodeRegion, fix parameter index confusion..
  • Rebase
  • Address review
Thu, Nov 10, 9:26 PM · Restricted Project, Restricted Project
Meinersbur added inline comments to D115218: [CodeExtractor] Refactor extractCodeRegion, fix parameter index confusion..
Thu, Nov 10, 9:23 PM · Restricted Project, Restricted Project

Wed, Nov 9

Meinersbur added a comment to D115218: [CodeExtractor] Refactor extractCodeRegion, fix parameter index confusion..

Ping

Wed, Nov 9, 5:26 PM · Restricted Project, Restricted Project
Herald added a project to D101717: [zorg] Parse Ninja output.: Restricted Project.

Ping

Wed, Nov 9, 10:07 AM · Restricted Project, Restricted Project

Tue, Nov 8

Meinersbur accepted D136415: [LSR] Check if terminating value is safe to expand before transformation.

LGTM

Tue, Nov 8, 7:20 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Nov 3

Meinersbur added a comment to D137338: Fix dupe word typos.

Changes in /polly/ look good to me.

Thu, Nov 3, 8:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Wed, Nov 2

Meinersbur added a reviewer for D136415: [LSR] Check if terminating value is safe to expand before transformation: Restricted Project.
Wed, Nov 2, 8:51 AM · Restricted Project, Restricted Project, Restricted Project
Meinersbur abandoned D136277: [LoopInterchange] Simplify DepMatrix to a dependency vector..

Abandon as discussed in the LoopWG call. It coarsens the analysis when compile time wasn't a problem.

Wed, Nov 2, 8:30 AM · Restricted Project, Restricted Project
Meinersbur updated the summary of D136277: [LoopInterchange] Simplify DepMatrix to a dependency vector..
Wed, Nov 2, 8:11 AM · Restricted Project, Restricted Project

Tue, Nov 1

Meinersbur added a comment to D132703: [LAA] Use BTC to rule out dependences if one ptr is loop invariant..

It is a bit irritating that the current logic does not consider which direction the pointers are traveling. E.g. Src = &D[0] and Sink = %D[1+ i] never overlap (with non-negative i), but the code seems to consider Src before or after Sink symmetrically. But that's what the current code does. Changing that as @reames suggested computing memory regions relative to the base pointer might require more some effort, but this smaller change looks fine to me.

Tue, Nov 1, 4:40 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D136277: [LoopInterchange] Simplify DepMatrix to a dependency vector..

Is the size of dependency matrix proving to be problematic for certain workloads?

Tue, Nov 1, 4:14 PM · Restricted Project, Restricted Project
Meinersbur updated the summary of D136277: [LoopInterchange] Simplify DepMatrix to a dependency vector..
Tue, Nov 1, 2:42 PM · Restricted Project, Restricted Project
Meinersbur added a reviewer for D137168: [OpenMP][mingw] Fix build for aarch64 target: pulidocr.
Tue, Nov 1, 9:32 AM · Restricted Project, Restricted Project

Oct 27 2022

Meinersbur added inline comments to D136415: [LSR] Check if terminating value is safe to expand before transformation.
Oct 27 2022, 1:35 PM · Restricted Project, Restricted Project, Restricted Project
Meinersbur accepted D136784: [Clang] Improve diagnostic message for loop hint pragma.

LGTM

Oct 27 2022, 1:17 PM · Restricted Project, Restricted Project
Meinersbur added inline comments to D136626: [docs][NewPM] Move pass plugin documentation into existing new PM docs.
Oct 27 2022, 1:11 PM · Restricted Project, Restricted Project
Meinersbur added a reviewer for D136626: [docs][NewPM] Move pass plugin documentation into existing new PM docs: pfaffe.
Oct 27 2022, 12:49 PM · Restricted Project, Restricted Project
Meinersbur accepted D136621: [polly] Remove legacy pass manager hooks.

LGTM

Oct 27 2022, 12:27 PM · Restricted Project, Restricted Project

Oct 26 2022

Meinersbur added a comment to D136621: [polly] Remove legacy pass manager hooks.

MaximalStaticExpansion expansion was actually already ported to the NPM in D125870. I made the NPM pass builder use it in rGb150d34c47ef.

Oct 26 2022, 3:37 PM · Restricted Project, Restricted Project
Meinersbur committed rGb150d34c47ef: [Polly] Add support for -polly-enable-mse with NPM. (authored by Meinersbur).
[Polly] Add support for -polly-enable-mse with NPM.
Oct 26 2022, 3:32 PM · Restricted Project
Meinersbur committed rGbb90d7ee3943: [Polly] Add support for -polly-export with NPM. (authored by Meinersbur).
[Polly] Add support for -polly-export with NPM.
Oct 26 2022, 3:22 PM · Restricted Project
Meinersbur updated subscribers of D136621: [polly] Remove legacy pass manager hooks.

Some other Polly options become inaccessible using any pipeline builder: PollyACC (-polly-target), static expansion (-polly-enable-mse), polyhedral info (-polly-enable-polyhedralinfo), and JSON export (-polly-export).

Oct 26 2022, 12:11 PM · Restricted Project, Restricted Project
Meinersbur added inline comments to D136102: [LoopSimplify] Update loop-metadata ID after loop-simplify splitting out new outer loop.
Oct 26 2022, 9:57 AM · Restricted Project, Restricted Project
Meinersbur added inline comments to D136621: [polly] Remove legacy pass manager hooks.
Oct 26 2022, 8:52 AM · Restricted Project, Restricted Project
Meinersbur added a comment to D136621: [polly] Remove legacy pass manager hooks.

-enable-new-pm is going to be removed from opt? What is that patch doing that?

Oct 26 2022, 8:50 AM · Restricted Project, Restricted Project
Meinersbur accepted D136261: Introduce range based singleton searches for loop queries.

LGTM. thank you for the update.

Oct 26 2022, 8:47 AM · Restricted Project, Restricted Project
Meinersbur accepted D134823: [LSR][RISCV] Pre-commit test case for D126043.

LGTM

Oct 26 2022, 8:38 AM · Restricted Project, Restricted Project
Meinersbur accepted D126043: [LSR] Drop LSR solution if it is less profitable than baseline.

LGTM, and sorry for the delay.

Oct 26 2022, 8:38 AM · Restricted Project, Restricted Project

Oct 25 2022

Meinersbur added inline comments to D136102: [LoopSimplify] Update loop-metadata ID after loop-simplify splitting out new outer loop.
Oct 25 2022, 3:01 PM · Restricted Project, Restricted Project

Oct 24 2022

Meinersbur committed rG0c849adf4f97: [Polly][docs] Avoid use of code-block:: guess. (authored by Meinersbur).
[Polly][docs] Avoid use of code-block:: guess.
Oct 24 2022, 5:55 PM · Restricted Project

Oct 20 2022

Meinersbur committed rGb4b7fa234cfa: [Polly] Ensure -polly-detect-keep-going still eventually rejects invalid… (authored by Meinersbur).
[Polly] Ensure -polly-detect-keep-going still eventually rejects invalid…
Oct 20 2022, 11:35 AM · Restricted Project

Oct 19 2022

Meinersbur added a comment to D136261: Introduce range based singleton searches for loop queries.

Thank you for the patch.

Oct 19 2022, 11:29 PM · Restricted Project, Restricted Project
Meinersbur requested review of D136277: [LoopInterchange] Simplify DepMatrix to a dependency vector..
Oct 19 2022, 11:08 AM · Restricted Project, Restricted Project
Meinersbur added a comment to D135808: [LoopInterchange] Correcting the profitability checking for vectorization.

Could you add a test case that is not considered profitable where before it was not?

Oct 19 2022, 12:20 AM · Restricted Project, Restricted Project, Restricted Project

Oct 18 2022

Meinersbur accepted D134930: [LoopInterchange] Do not interchange when a reduction phi in all subloops of the outer loop is not recognizable.

LGTM. Thank you.

Oct 18 2022, 11:08 PM · Restricted Project, Restricted Project

Sep 21 2022

Meinersbur accepted D132055: [LoopInterchange][PR57148] Ensure LCSSA form after loop interchnange.

LGTM

Sep 21 2022, 8:21 AM · Restricted Project, Restricted Project, Restricted Project

Sep 6 2022

Meinersbur added a comment to D133344: [mlir][Math] Add constant folder for RoundEvenOp..

This caused the Windows build to fail:

Sep 6 2022, 11:40 PM · Restricted Project, Restricted Project

Aug 25 2022

Meinersbur added a comment to D131919: Move googletest to the third-party directory.

Semi-OT: polly\lib\External has 3 more third-party libraries. Two of them have been heavily modified in-tree, the third has just a custom CMakeLists.txt.
Should these eventually also be moved?

Aug 25 2022, 11:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 24 2022

Meinersbur committed rG71d80cd6ed77: [flang] Fix msvc 17.3 build. (authored by Meinersbur).
[flang] Fix msvc 17.3 build.
Aug 24 2022, 2:49 PM · Restricted Project, Restricted Project
Meinersbur closed D132594: [flang] Fix msvc 17.3 build..
Aug 24 2022, 2:48 PM · Restricted Project, Restricted Project
Meinersbur updated the diff for D132594: [flang] Fix msvc 17.3 build..

Add source comment explaining this is a workaround

Aug 24 2022, 1:49 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D132594: [flang] Fix msvc 17.3 build..

msvc bug report: https://developercommunity.visualstudio.com/t/Regression:-nested-closure-assumes-wrong/10130223

Aug 24 2022, 1:40 PM · Restricted Project, Restricted Project
Meinersbur requested review of D132594: [flang] Fix msvc 17.3 build..
Aug 24 2022, 12:38 PM · Restricted Project, Restricted Project

Aug 18 2022

Meinersbur accepted D131526: [OMPIRBuilder] Add support for safelen clause.

LGTM

Aug 18 2022, 8:39 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 10 2022

Meinersbur added inline comments to D131526: [OMPIRBuilder] Add support for safelen clause.
Aug 10 2022, 7:54 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 8 2022

Meinersbur added inline comments to D114336: [Polly] Generalize the pattern matching to the case of tensor contractions..
Aug 8 2022, 3:53 PM · Restricted Project, Restricted Project
Meinersbur committed rG8c0979c8f772: [flang][test] Don't require .exe suffix. (authored by Meinersbur).
[flang][test] Don't require .exe suffix.
Aug 8 2022, 2:57 PM · Restricted Project, Restricted Project

Aug 3 2022

Meinersbur added a comment to D130851: [MLIR][OpenMP] Unroll Construct operation.
  • The full clause does not have an operand, it is more similar to a flag like nowait.

nowait is unitAtt. full can be treated the same way. I am considering it as boolean with 0 as false and 1 as true <

Aug 3 2022, 10:05 AM · Restricted Project, Restricted Project
Meinersbur added a comment to D129127: ManagedStatic: remove from DynamicLibrary.

I am responsible for one of the buildbots that failed (https://lab.llvm.org/buildbot/#/builders/172). If you don't have access to a Windows machine to reproduce the problem, I could help.

Aug 3 2022, 9:53 AM · Restricted Project, Restricted Project
Meinersbur added inline comments to D130615: [OpenMP][IRBuilder] Added if clause to task.
Aug 3 2022, 9:22 AM · Restricted Project, Restricted Project

Aug 2 2022

Meinersbur added a comment to D131000: [OpenMP][libomp] Detect if test compiler has omp.h.

The test doesn't become disabled. It uses the generated omp.h instead. This is the only test that attempts to use the system omp.h (or test compiler's omp.h). The original purpose was to test GCC compatibility of depobj which GCC defines differently than our omp.h.

Aug 2 2022, 3:42 PM · Restricted Project, Restricted Project
Meinersbur accepted D130188: [DependenceAnalysis][PR56275] Normalize dependence analysis results to be non-negative when required.

LGTM, but with a renaming suggestion.

Aug 2 2022, 12:08 PM · Restricted Project, Restricted Project, Restricted Project
Meinersbur added a comment to D130851: [MLIR][OpenMP] Unroll Construct operation.

I am not familiar with the MLIR tablegen format, but there might two issues:

Aug 2 2022, 12:04 PM · Restricted Project, Restricted Project
Meinersbur accepted D114336: [Polly] Generalize the pattern matching to the case of tensor contractions..

Thank you Gareev. I think the description can still be improved, I but we should also move forward and can improve iteratively.

Aug 2 2022, 11:55 AM · Restricted Project, Restricted Project
Meinersbur accepted D130189: [LoopInterchange][PR56275] Fix legality in dependence vectors.

LGTM, thank you

Aug 2 2022, 11:24 AM · Restricted Project, Restricted Project, Restricted Project
Meinersbur added inline comments to D130926: [OpenMP][libomp] Copy OpenMP headers to clang build directory.
Aug 2 2022, 11:21 AM · Restricted Project, Restricted Project
Meinersbur added a comment to D131000: [OpenMP][libomp] Detect if test compiler has omp.h.

Rather than disabling the test, did you consider adding an -I${CMAKE_CURRENT_BINARY_DIR}/runtime/src (where omp.h resides) to the clang test flags? Even if there is an omp.h already on the system, libomp's header should be used instead since it may contain new symbols not yet present in the system's omp.h. It might even be -isystem to treat it like a system header.

Aug 2 2022, 11:21 AM · Restricted Project, Restricted Project

Aug 1 2022

Meinersbur added a comment to D130926: [OpenMP][libomp] Copy OpenMP headers to clang build directory.

Ideally, it would use the that comes with libomp (${CMAKE_BINARY_DIR}/runtime/src/omp.hin the build dir, generated from https://github.com/llvm/llvm-project/blob/main/openmp/runtime/src/include/omp.h.var). Only the install script copies it over to ${CMAKE_INSTALL_DIR}/lib/clang/15.0.0/include/omp.h where it can actually be found.

Aug 1 2022, 1:30 PM · Restricted Project, Restricted Project

Jul 29 2022

Meinersbur added inline comments to D129131: Remove uses of llvm_shutdown.
Jul 29 2022, 12:00 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Meinersbur accepted D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.

LGTM, this turned out really nice. Thank you!

Jul 29 2022, 11:36 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 28 2022

Meinersbur added a comment to D115218: [CodeExtractor] Refactor extractCodeRegion, fix parameter index confusion..

ping

Jul 28 2022, 9:27 AM · Restricted Project, Restricted Project
Meinersbur added inline comments to D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.
Jul 28 2022, 8:46 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 26 2022

Meinersbur committed rGfe0e5b3e43b7: [Polly] Insert !dbg metadata for emitted CallInsts. (authored by Meinersbur).
[Polly] Insert !dbg metadata for emitted CallInsts.
Jul 26 2022, 5:45 PM · Restricted Project

Jul 25 2022

Meinersbur added inline comments to D130189: [LoopInterchange][PR56275] Fix legality in dependence vectors.
Jul 25 2022, 2:36 PM · Restricted Project, Restricted Project, Restricted Project
Meinersbur requested changes to D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR.
Jul 25 2022, 2:28 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Meinersbur added inline comments to D130188: [DependenceAnalysis][PR56275] Normalize dependence analysis results to be non-negative when required.
Jul 25 2022, 1:53 PM · Restricted Project, Restricted Project, Restricted Project
Meinersbur added a comment to D128261: [Fortran] Relax relative tolerance for FCVS tests.

My conclusion is different. If gfortran's output is correct according to the Fortran standard, it should pass the test as well. Running the test-suite with other compilers than Clang/Flang was always helpful in testing the integrity of the tests themselves.

Jul 25 2022, 1:20 PM · Restricted Project, Restricted Project

Jul 22 2022

Meinersbur added inline comments to D130188: [DependenceAnalysis][PR56275] Normalize dependence analysis results to be non-negative when required.
Jul 22 2022, 1:12 PM · Restricted Project, Restricted Project, Restricted Project
Meinersbur added a comment to D130188: [DependenceAnalysis][PR56275] Normalize dependence analysis results to be non-negative when required.

I think I would prefer the request for normalization on the depends() call, rather that the DependenceInfo constructor. This keeps it closer to the code that either expects normalized dependencies, or dependencies that expect it to correspond to which instructions were passed as either Src or Dst. Also, If DependenceInfo would be used as an analysis in a pass manager, having a NeedsNormalize=true instance of DependenceInfo in the analysis cache will break any pass that expect the other interpretation.

Jul 22 2022, 1:05 PM · Restricted Project, Restricted Project, Restricted Project
Meinersbur added a comment to D130189: [LoopInterchange][PR56275] Fix legality in dependence vectors.

As mentioned in https://github.com/llvm/llvm-project/issues/56275#issuecomment-1183363002, I think both directions need to be considered. < or > of the Dependence object mingels relation between the Src/Dst argument. Here, it is interpreted as the direction of the loop.

Jul 22 2022, 1:04 PM · Restricted Project, Restricted Project, Restricted Project
Meinersbur added inline comments to D130188: [DependenceAnalysis][PR56275] Normalize dependence analysis results to be non-negative when required.
Jul 22 2022, 12:26 PM · Restricted Project, Restricted Project, Restricted Project

Jul 19 2022

Meinersbur accepted D128877: [LoopCacheAnalysis] Fix a type mismatch bug in cost calculation.

Thanks Michael for your suggestion, I've updated the patch accordingly.

I'm just wondering if you meant A[trunc]=42 in your example? Also I'm a bit confused if the loop actually iterates over A twice? It looks to me the variable i loops from 0x0100 to 0x01FF, hence trunc loops from A[0x00] to A[0xFF] so seems like it just iterates once?

Jul 19 2022, 12:59 PM · Restricted Project, Restricted Project, Restricted Project
Meinersbur accepted D129992: [clang][OpenMP] Add IRBuilder support for taskgroup.

LGTM

Jul 19 2022, 12:54 PM · Restricted Project, Restricted Project

Jul 18 2022

Meinersbur committed rT6703097ffa34: [fpcmp] Use non-floating point parsing by default. (authored by Meinersbur).
[fpcmp] Use non-floating point parsing by default.
Jul 18 2022, 2:30 PM · Restricted Project
Meinersbur closed D129017: [fpcmp] Use non-floating point parsing by default..
Jul 18 2022, 2:30 PM · Restricted Project
Meinersbur added inline comments to D128877: [LoopCacheAnalysis] Fix a type mismatch bug in cost calculation.
Jul 18 2022, 12:47 PM · Restricted Project, Restricted Project, Restricted Project
Meinersbur added inline comments to D129992: [clang][OpenMP] Add IRBuilder support for taskgroup.
Jul 18 2022, 12:46 PM · Restricted Project, Restricted Project
Meinersbur added inline comments to D129017: [fpcmp] Use non-floating point parsing by default..
Jul 18 2022, 12:30 PM · Restricted Project
Meinersbur updated the diff for D129017: [fpcmp] Use non-floating point parsing by default..
  • Collapse fprintf calls
Jul 18 2022, 12:30 PM · Restricted Project

Jul 11 2022

Meinersbur added a comment to D128811: [MLIR][Presburger] introduce MPInt to support fast arbitrary precision in Presburger.

This error is:

C:\PROGRA~1\MICROS~4\2022\COMMUN~1\VC\Tools\MSVC\1431~1.311\bin\Hostx64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DMLIR_CUDA_CONVERSIONS_ENABLED=0 -DMLIR_ROCM_CONVERSIONS_ENABLED=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\build\tools\mlir\lib\Analysis\Presburger -IC:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\mlir\lib\Analysis\Presburger -IC:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\build\include -IC:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\llvm\include -IC:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\mlir\include -IC:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\build\tools\mlir\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd4324 -w14062 -we4238 /Gw /MD /O2 /Ob2  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Fotools\mlir\lib\Analysis\Presburger\CMakeFiles\obj.MLIRPresburger.dir\MPInt.cpp.obj /Fdtools\mlir\lib\Analysis\Presburger\CMakeFiles\obj.MLIRPresburger.dir\ /FS -c C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\mlir\lib\Analysis\Presburger\MPInt.cpp
C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\mlir\lib\Analysis\Presburger\MPInt.cpp(15): error C2039: 'hash_value': is not a member of 'mlir::presburger'
C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\mlir\include\mlir/Analysis/Presburger/MPInt.h(24): note: see declaration of 'mlir::presburger'
C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\mlir\lib\Analysis\Presburger\MPInt.cpp(16): error C2248: 'mlir::presburger::MPInt::isSmall': cannot access private member declared in class 'mlir::presburger::MPInt'
C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\mlir\include\mlir/Analysis/Presburger/MPInt.h(108): note: see declaration of 'mlir::presburger::MPInt::isSmall'
C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\mlir\include\mlir/Analysis/Presburger/MPInt.h(75): note: see declaration of 'mlir::presburger::MPInt'
C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\mlir\lib\Analysis\Presburger\MPInt.cpp(17): error C2248: 'mlir::presburger::MPInt::valSmall': cannot access private member declared in class 'mlir::presburger::MPInt'
C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\mlir\include\mlir/Analysis/Presburger/MPInt.h(78): note: see declaration of 'mlir::presburger::MPInt::valSmall'
C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\mlir\include\mlir/Analysis/Presburger/MPInt.h(75): note: see declaration of 'mlir::presburger::MPInt'
C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\mlir\lib\Analysis\Presburger\MPInt.cpp(18): error C2248: 'mlir::presburger::MPInt::valLarge': cannot access private member declared in class 'mlir::presburger::MPInt'
C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\mlir\include\mlir/Analysis/Presburger/MPInt.h(79): note: see declaration of 'mlir::presburger::MPInt::valLarge'
C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\mlir\include\mlir/Analysis/Presburger/MPInt.h(75): note: see declaration of 'mlir::presburger::MPInt'
Jul 11 2022, 5:01 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D127399: [OpenMP] Ensure createXXX functions will always call updateToLocation.
if (!CGF.HaveInsertPoint())                                                                                                                                                                                                                              
   return;

appears 35 times in CGOpenMPRuntime.cpp

Jul 11 2022, 12:41 PM · Restricted Project, Restricted Project
Meinersbur accepted D129339: [SingleSource] Add initial vectorizer tests with recurrences..

The macro DEFINE_SCALAR_AND_VECTOR_FN2 will be confused if one of the arguments itself contains a comma. For instance, one cannot write int for2 = 22, for1 = 33; for int for2 = 22; int for1 = 33; in the patch. But the macro is not general-purpose anyway.

Jul 11 2022, 8:32 AM · Restricted Project
Meinersbur added a comment to D128877: [LoopCacheAnalysis] Fix a type mismatch bug in cost calculation.

I don't think we can rely on isKnownNegative

Jul 11 2022, 8:20 AM · Restricted Project, Restricted Project, Restricted Project

Jul 7 2022

Meinersbur accepted D129149: [OMPIRBuilder] Add support for simdlen clause.

LGTM

Jul 7 2022, 10:46 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Meinersbur accepted D129297: [LSR] Fix bug - check if loop has preheader before calling isInductionPHI.

In the interest to not block @nathanchance with a crashing compiler, I suggest to commit as soon as possible. However, a complete patch would also include a regression test.

Jul 7 2022, 10:35 AM · Restricted Project, Restricted Project
Meinersbur added a comment to D127399: [OpenMP] Ensure createXXX functions will always call updateToLocation.

Because that is the clang pattern and we want/need to be compatible.

Jul 7 2022, 10:30 AM · Restricted Project, Restricted Project

Jul 6 2022

Meinersbur added a comment to D114845: [llvm] [Debuginfod] DebuginfodCollection and DebuginfodServer for tracking local debuginfo..

I think this causes link errors in shared library builds:

Jul 6 2022, 1:58 PM · Restricted Project, Restricted Project
Meinersbur updated the diff for D129017: [fpcmp] Use non-floating point parsing by default..
  • Advance pointer on match
Jul 6 2022, 12:44 PM · Restricted Project
Meinersbur added a comment to D123177: [libomptarget] Add device RTL to regression test dependencies..

Openmp as a llvm_project as opposed to a llvm_runtime can be built with GCC to get the host side of openmp working without the target offloading part. However GCC can't build the devicertl.

Jul 6 2022, 12:32 PM · Restricted Project, Restricted Project