Meinersbur (Michael Kruse)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 17 2015, 7:07 AM (118 w, 4 d)

Recent Activity

Fri, Sep 22

Meinersbur committed rL313976: polly-update-format after change in clang-format. NFC..
polly-update-format after change in clang-format. NFC.
Fri, Sep 22, 4:32 AM

Thu, Sep 21

Meinersbur committed rL313902: [DeLICM] Allow non-injective PHIRead->PHIWrite mapping..
[DeLICM] Allow non-injective PHIRead->PHIWrite mapping.
Thu, Sep 21, 12:10 PM

Wed, Sep 20

Meinersbur committed rL313750: [ScheduleOptimizer] Fix and test schedule tree statistics..
[ScheduleOptimizer] Fix and test schedule tree statistics.
Wed, Sep 20, 4:54 AM

Tue, Sep 19

Meinersbur committed rL313690: [ForwardOpTree] Allow out-of-quota in examination part of forwardTree..
[ForwardOpTree] Allow out-of-quota in examination part of forwardTree.
Tue, Sep 19, 3:55 PM
Meinersbur closed D37984: [Polly][ForwardOpTree] Allow out-of-quota in examination part of forwardTree. by committing rL313690: [ForwardOpTree] Allow out-of-quota in examination part of forwardTree..
Tue, Sep 19, 3:54 PM · Restricted Project
Meinersbur accepted D37982: [Polly] Create polly statement for every instruction..
Tue, Sep 19, 2:01 PM
Meinersbur added a comment to D37982: [Polly] Create polly statement for every instruction..

Thanks, looks good. I'll commit after D37337.

Tue, Sep 19, 2:00 PM
Meinersbur added a comment to D37337: [Polly] Split statements on encountering store instructions..

Please add at least one test case for the new feature (splitting at stores).

Tue, Sep 19, 1:51 PM · Restricted Project

Mon, Sep 18

Meinersbur created D37984: [Polly][ForwardOpTree] Allow out-of-quota in examination part of forwardTree..
Mon, Sep 18, 10:57 AM · Restricted Project
Meinersbur committed rL313546: [ForwardOpTree] Test the max operations quota..
[ForwardOpTree] Test the max operations quota.
Mon, Sep 18, 10:45 AM
Meinersbur committed rL313527: [test] Enable -polly-codegen-verify for regression tests..
[test] Enable -polly-codegen-verify for regression tests.
Mon, Sep 18, 5:35 AM
Meinersbur closed D37969: [Polly][test] Enable -polly-codegen-verify for regression tests. by committing rL313527: [test] Enable -polly-codegen-verify for regression tests..
Mon, Sep 18, 5:35 AM · Restricted Project
Meinersbur committed rL313526: [ForwardOptTree] Remove redundant simplify(). NFC..
[ForwardOptTree] Remove redundant simplify(). NFC.
Mon, Sep 18, 5:29 AM
Meinersbur created D37969: [Polly][test] Enable -polly-codegen-verify for regression tests..
Mon, Sep 18, 4:48 AM · Restricted Project
Meinersbur added a comment to D37337: [Polly] Split statements on encountering store instructions..

Sorry for my absence for a while, a paper submission deadline came in the way.

Mon, Sep 18, 4:06 AM · Restricted Project

Sat, Sep 9

Meinersbur added a comment to D37571: [Polly][CodegenCleanup] Update cleanup passes according (old) PassManagerBuilder..

LGTM. It would be great to actually have a testcase for this, so we'd be able to see any changes earlier.

Sat, Sep 9, 2:50 PM
Meinersbur committed rL312875: [CodegenCleanup] Update cleanup passes according (old) PassManagerBuilder..
[CodegenCleanup] Update cleanup passes according (old) PassManagerBuilder.
Sat, Sep 9, 2:45 PM
Meinersbur closed D37571: [Polly][CodegenCleanup] Update cleanup passes according (old) PassManagerBuilder. by committing rL312875: [CodegenCleanup] Update cleanup passes according (old) PassManagerBuilder..
Sat, Sep 9, 2:45 PM

Thu, Sep 7

Meinersbur updated the diff for D37571: [Polly][CodegenCleanup] Update cleanup passes according (old) PassManagerBuilder..

Add ExpensiveCombines argument.

Thu, Sep 7, 8:12 AM
Meinersbur created D37571: [Polly][CodegenCleanup] Update cleanup passes according (old) PassManagerBuilder..
Thu, Sep 7, 8:11 AM

Wed, Sep 6

Meinersbur committed rL312663: Revert "[ScopDetect/Info] Look through PHIs that follow an error block".
Revert "[ScopDetect/Info] Look through PHIs that follow an error block"
Wed, Sep 6, 12:07 PM
Meinersbur committed rL312632: [test] Add forgotten REQUIRES: line..
[test] Add forgotten REQUIRES: line.
Wed, Sep 6, 6:12 AM
Meinersbur committed rL312630: [ZoneAlgo] Handle non-StoreInst/LoadInst MemoryAccesses including memset..
[ZoneAlgo] Handle non-StoreInst/LoadInst MemoryAccesses including memset.
Wed, Sep 6, 5:42 AM
Meinersbur closed D37362: [Polly][ZoneAlgo] Handle non-StoreInst/LoadInst MemoryAccesses including memset. by committing rL312630: [ZoneAlgo] Handle non-StoreInst/LoadInst MemoryAccesses including memset..
Wed, Sep 6, 5:42 AM

Sun, Sep 3

Meinersbur added a comment to D37424: [ForwardOp] Remove read accesses for all instructions that have been moved.

I assume that not everyone subscribed to llvm-commits knows that "ForwardOpTree"/"ForwardOp" is a component of Polly. The tag "[Polly]" might still be useful.

Sun, Sep 3, 12:05 PM · Restricted Project
Meinersbur added a comment to D37424: [ForwardOp] Remove read accesses for all instructions that have been moved.

The entire return FD_ForwardTree might be useless for forwarding loads, we always want to forward a load if it is accessed through its scalar (which is always the case, forwardOperandTrees only ever tries to forward scalars). This might be the better patch:

diff --git a/lib/Transform/ForwardOpTree.cpp b/lib/Transform/ForwardOpTree.cpp
index 894f8097..8f44cf33 100644
--- a/lib/Transform/ForwardOpTree.cpp
+++ b/lib/Transform/ForwardOpTree.cpp
@@ -420,7 +420,7 @@ public:
     //   do not add another MemoryAccess.
     MemoryAccess *Access = TargetStmt->getArrayAccessOrNULLFor(LI);
     if (Access && !DoIt)
-      return FD_CanForwardLeaf;
+      return FD_CanForwardTree;
Sun, Sep 3, 9:35 AM · Restricted Project
Meinersbur committed rL312446: [ForwardOpTree] Fix typos. NFC..
[ForwardOpTree] Fix typos. NFC.
Sun, Sep 3, 9:11 AM
Meinersbur added a comment to D37424: [ForwardOp] Remove read accesses for all instructions that have been moved.

Hi Tobias.

Sun, Sep 3, 8:57 AM · Restricted Project
Meinersbur added a comment to D37424: [ForwardOp] Remove read accesses for all instructions that have been moved.

Forwarded instructions may have uses remaining in the same statement, removing the MemoryAccess will leave it without a value to use and crash in codegen. This is why removing access has to be deferred to -polly-simplify.

Sun, Sep 3, 6:59 AM · Restricted Project

Fri, Sep 1

Meinersbur committed rL312324: Fix Memory Access of failing tests..
Fix Memory Access of failing tests.
Fri, Sep 1, 4:40 AM
Meinersbur closed D37147: [Polly] Fix Memory Access of failing tests. by committing rL312324: Fix Memory Access of failing tests..
Fri, Sep 1, 4:40 AM · Restricted Project
Meinersbur added a comment to D37147: [Polly] Fix Memory Access of failing tests..

Thanks. committed as r312324.

Fri, Sep 1, 4:40 AM · Restricted Project

Thu, Aug 31

Meinersbur accepted D37340: [Polly] Run GVN during the cleanup.

Any reason to use NewGVN instead of (old) GVN?

Thu, Aug 31, 5:06 PM
Meinersbur created D37362: [Polly][ZoneAlgo] Handle non-StoreInst/LoadInst MemoryAccesses including memset..
Thu, Aug 31, 5:01 PM
Meinersbur added a comment to D37147: [Polly] Fix Memory Access of failing tests..

I get a compilation error:
error C2181: illegal else without matching if.

Thu, Aug 31, 9:31 AM · Restricted Project
Meinersbur accepted D37298: [ForwardOpTree] Allow forwarding in the presence of region statements.

LGTM, I have no more correctness concerns.

Thu, Aug 31, 7:54 AM · Restricted Project
Meinersbur accepted D37147: [Polly] Fix Memory Access of failing tests..
Thu, Aug 31, 6:29 AM · Restricted Project
Meinersbur added a comment to D37147: [Polly] Fix Memory Access of failing tests..

Unfortunately the patch does apply to current trunk. Could rebase it? Thank you.

Thu, Aug 31, 6:29 AM · Restricted Project
Meinersbur added a comment to D37298: [ForwardOpTree] Allow forwarding in the presence of region statements.

Your test cases check that the movement of non-load scalars to/from region works now (Which is amazing!). A test that checks that a load is not forwarded in case there is an (unpredictable) write in a region is missing. It might load the content written the store instead of the original value.

Thu, Aug 31, 5:02 AM · Restricted Project

Wed, Aug 30

Meinersbur added inline comments to D37298: [ForwardOpTree] Allow forwarding in the presence of region statements.
Wed, Aug 30, 10:04 AM · Restricted Project
Meinersbur added inline comments to D37298: [ForwardOpTree] Allow forwarding in the presence of region statements.
Wed, Aug 30, 8:35 AM · Restricted Project
Meinersbur accepted D37296: [ScopInfo] Use statement lists for entry blocks of region statements.

I don't see any correctness issues: LGTM.

Wed, Aug 30, 6:42 AM · Restricted Project
Meinersbur committed rL312118: [ScopBuilder/ScopInfo] Move reduction detection to ScopBuilder. NFC..
[ScopBuilder/ScopInfo] Move reduction detection to ScopBuilder. NFC.
Wed, Aug 30, 6:06 AM
Meinersbur committed rL312117: [ScopBuilder/ScopInfo] Move ScopStmt::collectSurroundingLoops to ScopBuilder..
[ScopBuilder/ScopInfo] Move ScopStmt::collectSurroundingLoops to ScopBuilder.
Wed, Aug 30, 6:06 AM
Meinersbur committed rL312116: [ScopBuilder/ScopInfo] Move ScopStmt::buildDomain to ScopBuilder. NFC..
[ScopBuilder/ScopInfo] Move ScopStmt::buildDomain to ScopBuilder. NFC.
Wed, Aug 30, 6:06 AM
Meinersbur committed rL312115: [ScopBuilder/ScopInfo] Move ScopStmt::buildAccessRelations to ScopBuilder. NFC..
[ScopBuilder/ScopInfo] Move ScopStmt::buildAccessRelations to ScopBuilder. NFC.
Wed, Aug 30, 6:06 AM
Meinersbur committed rL312114: [ScopBuilder/ScopInfo] Move and inline Scop::init into ScopBuilder::buildScop..
[ScopBuilder/ScopInfo] Move and inline Scop::init into ScopBuilder::buildScop.
Wed, Aug 30, 6:05 AM
Meinersbur committed rL312113: [ScopBuilder] Report to dbgs() on SCoP bailout. NFC..
[ScopBuilder] Report to dbgs() on SCoP bailout. NFC.
Wed, Aug 30, 4:53 AM
Meinersbur added a comment to D37147: [Polly] Fix Memory Access of failing tests..

The culprit is

void Scop::removeFromStmtMap(ScopStmt &Stmt) {
  if (Stmt.isRegionStmt())
    for (BasicBlock *BB : Stmt.getRegion()->blocks()) {
      StmtMap.erase(BB);
      for (Instruction &Inst : *BB)
        InstStmtMap.erase(&Inst);
  } else {
    StmtMap.erase(Stmt.getBasicBlock()); // <-- here
    for (Instruction *Inst : Stmt.getInstructions())
      InstStmtMap.erase(Inst);
  }
}

It removes all statements associated with the BB, not just the one passed. After the operation, StmtMap contains no more statement for that BB, even if previously it had more than one.

Wed, Aug 30, 4:15 AM · Restricted Project
Meinersbur closed D36402: [Polly] Introduce metadata for splitting of scop statement. by committing rL312107: [ScopBuilder] Introduce metadata for splitting scop statement..
Wed, Aug 30, 3:14 AM · Restricted Project
Meinersbur accepted D36402: [Polly] Introduce metadata for splitting of scop statement..
Wed, Aug 30, 3:14 AM · Restricted Project

Tue, Aug 29

Meinersbur committed rL312021: Do not consider mem intrinsics as error..
Do not consider mem intrinsics as error.
Tue, Aug 29, 11:30 AM
Meinersbur committed rL312020: Skip ignored intrinsics..
Skip ignored intrinsics.
Tue, Aug 29, 11:30 AM

Mon, Aug 28

Meinersbur committed rL311929: [ZoneAlgo] More fine-grained bail-out..
[ZoneAlgo] More fine-grained bail-out.
Mon, Aug 28, 1:40 PM
Meinersbur closed D37219: [Polly][ZoneAlgo] More fine-grained bail-out. by committing rL311929: [ZoneAlgo] More fine-grained bail-out..
Mon, Aug 28, 1:40 PM
Meinersbur added a comment to D37147: [Polly] Fix Memory Access of failing tests..

Together with D36402, I don't see any tests failing.

Mon, Aug 28, 1:36 PM · Restricted Project
Meinersbur added a comment to D36402: [Polly] Introduce metadata for splitting of scop statement..

LGTM. There is just the unnecessary field Count. Can you remove it (And also run polly-update-format)? Many Thanks.

Mon, Aug 28, 12:52 PM · Restricted Project
Meinersbur created D37219: [Polly][ZoneAlgo] More fine-grained bail-out..
Mon, Aug 28, 9:36 AM
Meinersbur committed rL311888: [PM] Properly require and preserve OptimizationRemarkEmitter. NFCI..
[PM] Properly require and preserve OptimizationRemarkEmitter. NFCI.
Mon, Aug 28, 7:09 AM
Meinersbur closed D37010: [Polly][PM] Properly require and preservation of OptimizationRemarkEmitter. by committing rL311888: [PM] Properly require and preserve OptimizationRemarkEmitter. NFCI..
Mon, Aug 28, 7:08 AM · Restricted Project
Meinersbur committed rL311885: [ZoneAlgo] Print rejection reasons to llvm::dbgs(). NFC..
[ZoneAlgo] Print rejection reasons to llvm::dbgs(). NFC.
Mon, Aug 28, 4:25 AM

Aug 25 2017

Meinersbur committed rL311774: Normlize to LF line endings..
Normlize to LF line endings.
Aug 25 2017, 5:40 AM

Aug 23 2017

Meinersbur added inline comments to D37010: [Polly][PM] Properly require and preservation of OptimizationRemarkEmitter..
Aug 23 2017, 7:18 AM · Restricted Project
Meinersbur committed rL311553: Add more statistics..
Add more statistics.
Aug 23 2017, 6:52 AM
Meinersbur closed D37049: [Polly] Add various statistics. by committing rL311553: Add more statistics..
Aug 23 2017, 6:52 AM · Restricted Project
Meinersbur updated the diff for D37049: [Polly] Add various statistics..
  • Fix warnings in NDEBUG builds.
  • Add some more statistics.
Aug 23 2017, 6:42 AM · Restricted Project
Meinersbur committed rL311551: [ScopDetect] Include zero-iteration loops in loop count..
[ScopDetect] Include zero-iteration loops in loop count.
Aug 23 2017, 6:31 AM
Meinersbur committed rL311550: [ScopInliner] Fix hidden overload warning. NFC..
[ScopInliner] Fix hidden overload warning. NFC.
Aug 23 2017, 6:08 AM
Meinersbur committed rL311549: [MaximumStaticExpansion] Avoid warning in release builds..
[MaximumStaticExpansion] Avoid warning in release builds.
Aug 23 2017, 5:54 AM
Meinersbur committed rL311548: [PPCGCodeGen] Fix compiler warning: '<': signed/unsigned mismatch. NFC..
[PPCGCodeGen] Fix compiler warning: '<': signed/unsigned mismatch. NFC.
Aug 23 2017, 5:46 AM
Meinersbur committed rL311547: [ScopInfo] Remove stray semicolon. NFC..
[ScopInfo] Remove stray semicolon. NFC.
Aug 23 2017, 5:36 AM

Aug 22 2017

Meinersbur created D37049: [Polly] Add various statistics..
Aug 22 2017, 7:25 PM · Restricted Project
Meinersbur accepted D37028: [IRBuilder] Only emit alias scop metadata for arrays, but not scalars.

LGTM!

Aug 22 2017, 2:51 PM · Restricted Project
Meinersbur committed rL311472: [ScopInfo] Fix typos in comment. NFC..
[ScopInfo] Fix typos in comment. NFC.
Aug 22 2017, 10:34 AM
Meinersbur committed rL311469: [ScopDetection] Add stat for total number of loops..
[ScopDetection] Add stat for total number of loops.
Aug 22 2017, 10:13 AM
Meinersbur committed rL311470: [test] Do not pipe binary data to FileCheck..
[test] Do not pipe binary data to FileCheck.
Aug 22 2017, 10:13 AM
Meinersbur added inline comments to D37010: [Polly][PM] Properly require and preservation of OptimizationRemarkEmitter..
Aug 22 2017, 8:59 AM · Restricted Project
Meinersbur added inline comments to D37010: [Polly][PM] Properly require and preservation of OptimizationRemarkEmitter..
Aug 22 2017, 8:57 AM · Restricted Project
Meinersbur added inline comments to D36402: [Polly] Introduce metadata for splitting of scop statement..
Aug 22 2017, 6:57 AM · Restricted Project
Meinersbur created D37010: [Polly][PM] Properly require and preservation of OptimizationRemarkEmitter..
Aug 22 2017, 6:06 AM · Restricted Project

Aug 21 2017

Meinersbur committed rL311404: [test] Add some test cases for computeArrayUnused..
[test] Add some test cases for computeArrayUnused.
Aug 21 2017, 4:06 PM
Meinersbur committed rL311403: [DeLICM] Fix unused zone for writes without in-between read..
[DeLICM] Fix unused zone for writes without in-between read.
Aug 21 2017, 4:06 PM
Meinersbur committed rL311395: SPEC2017: Add initial CMakeLists..
SPEC2017: Add initial CMakeLists.
Aug 21 2017, 3:37 PM
Meinersbur closed D36717: [test-suite] Add SPEC CPU 2017 by committing rL311395: SPEC2017: Add initial CMakeLists..
Aug 21 2017, 3:36 PM
Meinersbur committed rL311385: fpmc: Add -i option to ignore whitespace changes..
fpmc: Add -i option to ignore whitespace changes.
Aug 21 2017, 2:21 PM
Meinersbur closed D36768: [test-suite] Add -i option to fpcmp to ignore whitespace changes. by committing rL311385: fpmc: Add -i option to ignore whitespace changes..
Aug 21 2017, 2:21 PM
Meinersbur added inline comments to D36768: [test-suite] Add -i option to fpcmp to ignore whitespace changes..
Aug 21 2017, 10:09 AM
Meinersbur added a comment to D36768: [test-suite] Add -i option to fpcmp to ignore whitespace changes..

Can somebody give their ok for the most recent diff update? Then I'll commit to trunk (and SPEC CPU 2017 which depends on this as well)

Aug 21 2017, 9:25 AM
Meinersbur added inline comments to D36460: [Polly][MatMul] Make MatMul detection independent of internal isl representations..
Aug 21 2017, 6:01 AM

Aug 20 2017

Meinersbur added a comment to D36939: [Polly] Codegen for simple full function Scops.

Nice work!

Aug 20 2017, 3:06 PM
Meinersbur committed rL311302: [MatMul] Make MatMul detection independent of internal isl representations..
[MatMul] Make MatMul detection independent of internal isl representations.
Aug 20 2017, 2:32 PM
Meinersbur closed D36460: [Polly][MatMul] Make MatMul detection independent of internal isl representations. by committing rL311302: [MatMul] Make MatMul detection independent of internal isl representations..
Aug 20 2017, 2:32 PM
Meinersbur accepted D36460: [Polly][MatMul] Make MatMul detection independent of internal isl representations..
Aug 20 2017, 2:29 PM
Meinersbur added a comment to D36926: [Polly][WIP] Clear DependenceInfo after expansion.

This patch adds support for -polly-mse to the new PassManager infrastructure.

Aug 20 2017, 2:25 PM
Meinersbur added a reviewer for D36926: [Polly][WIP] Clear DependenceInfo after expansion: philip.pfaffe.
Aug 20 2017, 2:25 PM
Meinersbur accepted D36647: [Polly][WIP] Scalar fully indexed expansion.
Aug 20 2017, 2:14 PM

Aug 19 2017

Meinersbur added inline comments to D36791: [Polly][Bug fix] Wrong dependences filtering during Fully Indexed expansion.
Aug 19 2017, 12:30 PM

Aug 18 2017

Meinersbur accepted D36791: [Polly][Bug fix] Wrong dependences filtering during Fully Indexed expansion.

Andreas, are you going to commit this?

Aug 18 2017, 7:53 AM
Meinersbur added inline comments to D36791: [Polly][Bug fix] Wrong dependences filtering during Fully Indexed expansion.
Aug 18 2017, 7:34 AM
Meinersbur updated the diff for D36768: [test-suite] Add -i option to fpcmp to ignore whitespace changes..

fpcmp: Fix endless loop in non-whitespace case

Aug 18 2017, 5:15 AM