Page MenuHomePhabricator

Meinersbur (Michael Kruse)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 17 2015, 7:07 AM (204 w, 4 d)

Recent Activity

Fri, May 10

Meinersbur committed rG2698390c68b5: [ZoneAlgo] Fix PHI inconsistency in invalid contexts. (authored by Meinersbur).
[ZoneAlgo] Fix PHI inconsistency in invalid contexts.
Fri, May 10, 11:37 AM
Meinersbur committed rL360454: [ZoneAlgo] Fix PHI inconsistency in invalid contexts..
[ZoneAlgo] Fix PHI inconsistency in invalid contexts.
Fri, May 10, 11:37 AM

Thu, May 9

Meinersbur added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur, I've tested and reviewed this patch, I'm curious about Polly's team opinion on the changes in current state?

Thu, May 9, 8:33 PM · Restricted Project

Thu, May 2

Meinersbur added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Do you intent to use this interface for a specific external project, or is it to avoid direct references to Polly?

Thu, May 2, 8:07 PM · Restricted Project

Tue, Apr 30

Meinersbur added a comment to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, induction variable, and guard branch..

Generally, I'd prefer to use ScalarEvolution over inspecting (and expecting specific) instructions in a loop, whenever possible. Some canonicalization passes are designed for this. In particular, IndVarSimplify used to make canonical loops (i.e. start at zero, increment by one). r133502 introduced -disable-iv-rewrite to rely more on ScalarEvolution instead of "opcode/pattern matching" (cite from the commit message). -enable-iv-rewrite=false was made the default in r139579 after finding that it slows down many benchmarks. It was completely removed in r153260.

Tue, Apr 30, 1:07 PM · Restricted Project
Meinersbur added reviewers for D61116: [test-suite] MultiSource/Benchmarks/DOE-ProxyApps-C/RSBench: change *CMAKE* target name only: homerdin, MatzeB.
Tue, Apr 30, 11:19 AM · Restricted Project
Meinersbur added a comment to D61116: [test-suite] MultiSource/Benchmarks/DOE-ProxyApps-C/RSBench: change *CMAKE* target name only.

llvm_multisource has an option "PREFIX" that can be used to disambiguate target names. However, in my experience when using it collecting metrics does not work as reliable with this options.

Tue, Apr 30, 11:19 AM · Restricted Project

Wed, Apr 24

Meinersbur added a comment to D61091: Enable LoopVectorization by default..

Having both -- -disable-loop-vectorization and -vectorize-loops -- is somewhat confusing. Could we have a tri-state cl::opt which, when not specified, uses OptLevel > 1 && SizeLevel < 2 dis-/enable the vectorizer? Similar to -disable-loop-unrolling.

Wed, Apr 24, 4:27 PM · Restricted Project
Meinersbur added inline comments to D61081: LLVM OpenMP Backend -- Fix "static chunked" scheduling.
Wed, Apr 24, 12:49 PM · Restricted Project

Tue, Apr 23

Meinersbur accepted D61035: Fix unused variable warning in LoopFusion pass.

LGTM

Tue, Apr 23, 2:37 PM · Restricted Project

Apr 19 2019

Meinersbur added inline comments to D55851: Implement basic loop fusion pass.
Apr 19 2019, 9:05 AM · Restricted Project

Apr 18 2019

Meinersbur added inline comments to D59723: [NewPassManager] Adding pass tuning options: loop vectorize..
Apr 18 2019, 10:41 AM · Restricted Project
Meinersbur added a comment to D60872: Add new warning knob for unknown attribute namespaces.

Thanks for coming up with this patch.

Apr 18 2019, 10:22 AM

Apr 16 2019

Meinersbur added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, induction variable, and guard branch..
Apr 16 2019, 5:26 PM · Restricted Project
Meinersbur committed rGf73bba3b1409: [Test] Remove obsolete test. (authored by Meinersbur).
[Test] Remove obsolete test.
Apr 16 2019, 9:44 AM
Meinersbur committed rL358507: [Test] Remove obsolete test..
[Test] Remove obsolete test.
Apr 16 2019, 9:43 AM
Meinersbur committed rC358507: [Test] Remove obsolete test..
[Test] Remove obsolete test.
Apr 16 2019, 9:43 AM
Meinersbur closed D60749: [Test] Remove obsolete test..
Apr 16 2019, 9:43 AM · Restricted Project
Meinersbur added a comment to D55290: [docs] Update llvm.loop metadata documentation..

ping

Apr 16 2019, 9:31 AM · Restricted Project
Meinersbur added a comment to D58202: [Polly][ScheduleOptimizer] Hoist extension nodes after schedule optimization..

ping

Apr 16 2019, 9:30 AM · Restricted Project
Meinersbur added a comment to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, induction variable, and guard branch..

Are you planning to add more users of this interface?

Apr 16 2019, 8:45 AM · Restricted Project

Apr 15 2019

Meinersbur created D60749: [Test] Remove obsolete test..
Apr 15 2019, 8:24 PM · Restricted Project

Apr 11 2019

Meinersbur added a comment to D51963: [Polly] Really fix Windows builds..

When applying this patch to the current trunk, I get:

CMake Error at tools/polly/lib/CMakeLists.txt:116 (add_llvm_loadable_module):
  Unknown CMake command "add_llvm_loadable_module".
Apr 11 2019, 2:27 PM · Restricted Project
Meinersbur accepted D55851: Implement basic loop fusion pass.

Generally, LGTM; with some smaller suggestions.

Apr 11 2019, 12:00 PM · Restricted Project

Apr 5 2019

Meinersbur added a comment to D60266: [LoopUnroll] Rotate loop, when optimizing for size and can fully unroll a loop..

Like D59832, #pragma clang loop unroll/#pragma unroll might require a loop rotation as well to successfully unroll?

Apr 5 2019, 6:28 AM · Restricted Project

Apr 1 2019

Meinersbur added a comment to D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation..

@dmgreen Thank you for the review!

Apr 1 2019, 11:41 AM · Restricted Project, Restricted Project
Meinersbur committed rG58e7642669bf: [CodeGen] Generate follow-up metadata for loops with more than one… (authored by Meinersbur).
[CodeGen] Generate follow-up metadata for loops with more than one…
Apr 1 2019, 10:51 AM
Meinersbur committed rL357415: [CodeGen] Generate follow-up metadata for loops with more than one….
[CodeGen] Generate follow-up metadata for loops with more than one…
Apr 1 2019, 10:50 AM
Meinersbur committed rC357415: [CodeGen] Generate follow-up metadata for loops with more than one….
[CodeGen] Generate follow-up metadata for loops with more than one…
Apr 1 2019, 10:50 AM
Meinersbur closed D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation..
Apr 1 2019, 10:50 AM · Restricted Project, Restricted Project

Mar 28 2019

Meinersbur committed rG031bb1655664: Apply include-what-you-use #include removal suggestions. NFC. (authored by Meinersbur).
Apply include-what-you-use #include removal suggestions. NFC.
Mar 28 2019, 1:19 PM
Meinersbur committed rL357209: Apply include-what-you-use #include removal suggestions. NFC..
Apply include-what-you-use #include removal suggestions. NFC.
Mar 28 2019, 1:18 PM

Mar 27 2019

Meinersbur added a comment to D59832: [LoopRotation] Allow loop header duplication if vectorization is forced.

If you feel strongly about this I can explore rotating the loop in the vectorizer when I have a bit more time.

Mar 27 2019, 10:07 AM · Restricted Project
Meinersbur added a comment to D59832: [LoopRotation] Allow loop header duplication if vectorization is forced.

This might be a more general problem, other passes might expect a normalized form as well, such as UnrollAndJam and LoopDistribute.

Mar 27 2019, 9:00 AM · Restricted Project

Mar 26 2019

Meinersbur committed rOMP356998: [libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option..
[libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option.
Mar 26 2019, 8:19 AM
Meinersbur committed rGd97d5ebcfa4b: [libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option. (authored by Meinersbur).
[libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option.
Mar 26 2019, 8:19 AM
Meinersbur added a comment to D55952: [libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option..

@grokos Thank you for the review!

Mar 26 2019, 8:19 AM · Restricted Project, Restricted Project
Meinersbur committed rL356998: [libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option..
[libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option.
Mar 26 2019, 8:18 AM
Meinersbur closed D55952: [libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option..
Mar 26 2019, 8:17 AM · Restricted Project, Restricted Project

Mar 25 2019

Meinersbur added a comment to D59263: Moving ManagedMemoryRewritePass when hybrid option is selected.

Done. Thanks for the patch!

Mar 25 2019, 4:30 PM · Restricted Project, Restricted Project
Meinersbur committed rGea40d5b05b8b: Moving ManagedMemoryRewritePass when hybrid option is selected (authored by Meinersbur).
Moving ManagedMemoryRewritePass when hybrid option is selected
Mar 25 2019, 4:26 PM
Meinersbur committed rL356965: Moving ManagedMemoryRewritePass when hybrid option is selected.
Moving ManagedMemoryRewritePass when hybrid option is selected
Mar 25 2019, 4:26 PM
Meinersbur closed D59263: Moving ManagedMemoryRewritePass when hybrid option is selected.
Mar 25 2019, 4:26 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation..

This could maybe do with a few extra tests. Am I correct in saying something like this:

#pragma unroll_and_jam(4)
for(int j = 0; j < n; j++) {
  #pragma unroll(4)
  for(int k = 0; k < n; k++) {
    x[j*n+k] = 10;
  }
}

would end up with a llvm.loop.unroll_and_jam.followup_inner with a llvm.loop.unroll_count?

Mar 25 2019, 1:41 PM · Restricted Project, Restricted Project
Meinersbur updated the diff for D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation..
  • Rebase
  • Add two test cases for all attributes combined (as inner and outer loop for of an unroll-and-jam)
  • Of two nested unroll-and-jams, apply the inner first
  • Typos and comment clarification
  • Add missing llvm.loop.isvectorized when attributes are split between BeforeJam and AfterJam
Mar 25 2019, 1:39 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D59263: Moving ManagedMemoryRewritePass when hybrid option is selected.

Do you need help with landing the patch?

Mar 25 2019, 9:08 AM · Restricted Project, Restricted Project

Mar 24 2019

Meinersbur added inline comments to D55952: [libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option..
Mar 24 2019, 1:28 PM · Restricted Project, Restricted Project

Mar 19 2019

Meinersbur added a comment to D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation..

ping

Mar 19 2019, 1:50 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D58202: [Polly][ScheduleOptimizer] Hoist extension nodes after schedule optimization..

ping

Mar 19 2019, 1:50 PM · Restricted Project
Meinersbur added a comment to D55290: [docs] Update llvm.loop metadata documentation..

ping

Mar 19 2019, 1:50 PM · Restricted Project
Meinersbur added a comment to D55952: [libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option..

ping

Mar 19 2019, 1:50 PM · Restricted Project, Restricted Project
Meinersbur added inline comments to D58736: [System Model] Introduce a target system model.
Mar 19 2019, 9:58 AM · Restricted Project

Mar 18 2019

Meinersbur committed rG89251edefcb4: [CodeGen] LLVM OpenMP Backend. (authored by Meinersbur).
[CodeGen] LLVM OpenMP Backend.
Mar 18 2019, 8:18 PM
Meinersbur added a comment to D58736: [System Model] Introduce a target system model.

Thank you for pushing this forward and sorry for the delay.

Mar 18 2019, 3:50 PM · Restricted Project

Mar 14 2019

Meinersbur added inline comments to D57598: [VPLAN] Determine Vector Width programmatically..
Mar 14 2019, 1:38 PM · Restricted Project
Meinersbur added inline comments to D57598: [VPLAN] Determine Vector Width programmatically..
Mar 14 2019, 12:28 PM · Restricted Project

Mar 12 2019

Meinersbur accepted D59263: Moving ManagedMemoryRewritePass when hybrid option is selected.

LGTM

Mar 12 2019, 9:57 AM · Restricted Project, Restricted Project

Mar 11 2019

Meinersbur updated the diff for D55952: [libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option..
  • Undo whitespace change
Mar 11 2019, 4:47 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D55952: [libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option..

Sorry for the delay. I missed your reply during the holidays.

Mar 11 2019, 4:45 PM · Restricted Project, Restricted Project
Meinersbur updated the diff for D55952: [libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option..
  • Define OMPTARGET_DEBUG preprocessor symbol if LIBOMPTARGET_ENABLE_DEBUG
  • Fix regression test execution
Mar 11 2019, 4:43 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D58202: [Polly][ScheduleOptimizer] Hoist extension nodes after schedule optimization..

ping

Mar 11 2019, 2:32 PM · Restricted Project
Meinersbur added a comment to D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation..

The Polly-powered additional transformations now also generate this kind of metadata.

Mar 11 2019, 2:32 PM · Restricted Project, Restricted Project
Herald added a project to D55290: [docs] Update llvm.loop metadata documentation.: Restricted Project.

ping

Mar 11 2019, 2:25 PM · Restricted Project

Mar 8 2019

Meinersbur committed rG65c5821e3fac: [RegionPass] Fix forgotten "!". (authored by Meinersbur).
[RegionPass] Fix forgotten "!".
Mar 8 2019, 1:02 PM
Meinersbur committed rL355733: [RegionPass] Fix forgotten "!"..
[RegionPass] Fix forgotten "!".
Mar 8 2019, 1:02 PM

Feb 25 2019

Meinersbur committed rG0336c75c365a: [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier. (authored by Meinersbur).
[OpenMP 5.0] Parsing/sema support for from clause with mapper modifier.
Feb 25 2019, 12:34 PM
Meinersbur committed rC354817: [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier..
[OpenMP 5.0] Parsing/sema support for from clause with mapper modifier.
Feb 25 2019, 12:34 PM
Meinersbur committed rL354817: [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier..
[OpenMP 5.0] Parsing/sema support for from clause with mapper modifier.
Feb 25 2019, 12:34 PM
Meinersbur closed D58638: [OpenMP 5.0] Parsing/sema support for from clause with mapper modifier.
Feb 25 2019, 12:33 PM · Restricted Project, Restricted Project, Restricted Project
Meinersbur added a comment to D58535: [OptRemarks] Make OptRemarks more generic: rename OptRemarks to Remarks.

What is the motivation of the rename? What are the plans for more generic OptRemarks?

Feb 25 2019, 8:43 AM · Restricted Project

Feb 22 2019

Meinersbur committed rG01f670df8f37: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier. (authored by Meinersbur).
[OpenMP 5.0] Parsing/sema support for to clause with mapper modifier.
Feb 22 2019, 2:29 PM
Meinersbur committed rC354698: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier..
[OpenMP 5.0] Parsing/sema support for to clause with mapper modifier.
Feb 22 2019, 2:29 PM
Meinersbur committed rL354698: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier..
[OpenMP 5.0] Parsing/sema support for to clause with mapper modifier.
Feb 22 2019, 2:29 PM
Meinersbur closed D58523: [OpenMP 5.0] Parsing/sema support for to clause with mapper modifier.
Feb 22 2019, 2:29 PM · Restricted Project, Restricted Project, Restricted Project

Feb 19 2019

Meinersbur committed rG4304e9d14399: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier. (authored by Meinersbur).
[OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Feb 19 2019, 8:40 AM
Meinersbur committed rC354347: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier..
[OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Feb 19 2019, 8:40 AM
Meinersbur committed rL354347: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier..
[OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Feb 19 2019, 8:39 AM
Meinersbur closed D58074: [OpenMP 5.0] Parsing/sema support for map clause with mapper modifier.
Feb 19 2019, 8:39 AM · Restricted Project, Restricted Project, Restricted Project

Feb 18 2019

Meinersbur added inline comments to D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation..
Feb 18 2019, 9:19 AM · Restricted Project, Restricted Project

Feb 13 2019

Meinersbur created D58202: [Polly][ScheduleOptimizer] Hoist extension nodes after schedule optimization..
Feb 13 2019, 12:54 PM · Restricted Project

Feb 12 2019

Meinersbur committed rL353864: Remove completed project.
Remove completed project
Feb 12 2019, 9:47 AM

Feb 11 2019

Meinersbur committed rG77a614a6e154: Refactor setAlreadyUnrolled() and setAlreadyVectorized(). (authored by Meinersbur).
Refactor setAlreadyUnrolled() and setAlreadyVectorized().
Feb 11 2019, 11:46 AM
Meinersbur committed rL353738: Refactor setAlreadyUnrolled() and setAlreadyVectorized()..
Refactor setAlreadyUnrolled() and setAlreadyVectorized().
Feb 11 2019, 11:45 AM
Meinersbur closed D57566: Refactor setAlreadyUnrolled() and setAlreadyVectorized()..
Feb 11 2019, 11:45 AM · Restricted Project
Meinersbur updated the diff for D57566: Refactor setAlreadyUnrolled() and setAlreadyVectorized()..
  • Use APInt to construct constant in metadata
  • Undo unnecessary test case changes
Feb 11 2019, 9:40 AM · Restricted Project

Feb 8 2019

Meinersbur created D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation..
Feb 8 2019, 2:35 PM · Restricted Project, Restricted Project

Feb 4 2019

Meinersbur committed rG70560a0a2cce: [WarnMissedTransforms] Do not warn about already vectorized loops. (authored by Meinersbur).
[WarnMissedTransforms] Do not warn about already vectorized loops.
Feb 4 2019, 11:57 AM
Meinersbur committed rL353082: [WarnMissedTransforms] Do not warn about already vectorized loops..
[WarnMissedTransforms] Do not warn about already vectorized loops.
Feb 4 2019, 11:56 AM
Meinersbur closed D57542: [WarnMissedTransforms] Do not warn about already vectorized loops..
Feb 4 2019, 11:55 AM · Restricted Project
Meinersbur updated the diff for D57566: Refactor setAlreadyUnrolled() and setAlreadyVectorized()..
  • Use a TemporaryMDNode instead of nullptr
Feb 4 2019, 10:12 AM · Restricted Project

Feb 1 2019

Meinersbur committed rL352906: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive..
[OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.
Feb 1 2019, 12:25 PM
Meinersbur committed rC352906: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive..
[OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.
Feb 1 2019, 12:25 PM
Meinersbur closed D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.
Feb 1 2019, 12:25 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive.

@lildmh Thanks for the patch. I can commit this patch for you. The tests run fine on my machine. However, for committing on other's behalf, we were asked to make the contributor aware that the contribution will be published under a new license. Are you OK with the new license?

Feb 1 2019, 11:43 AM · Restricted Project, Restricted Project

Jan 31 2019

Meinersbur created D57566: Refactor setAlreadyUnrolled() and setAlreadyVectorized()..
Jan 31 2019, 10:36 PM · Restricted Project
Meinersbur created D57542: [WarnMissedTransforms] Do not warn about already vectorized loops..
Jan 31 2019, 1:39 PM · Restricted Project

Jan 28 2019

Meinersbur accepted D57260: Check bool attribute value in getOptionalBoolLoopAttribute..

Thanks for catching this. Looks like I did not think about calling getZExtValue on ConstantInt, but didn't notive because ConstantInt* converts to bool implicitly.

Jan 28 2019, 5:48 PM

Jan 25 2019

Meinersbur added a comment to D56928: Support attribute used in member funcs of class templates.

Thanks for looking into my almost 6 year old bug!

Jan 25 2019, 3:54 PM · Restricted Project
Meinersbur added a comment to D57260: Check bool attribute value in getOptionalBoolLoopAttribute..

The check hasVectorizeTransformation(L) in front checks whether vectorization is forced by the user. It is not necessary that the user also fixes the simd width/interleave count. Hence, the warning is valid in this case. It is the same behavior as before rL348944 (which I tried to replicate).

Jan 25 2019, 3:39 PM

Jan 11 2019

Meinersbur added a comment to D56403: add pragmas to control Software Pipelining optimisation.
In D56403#1353857, @alexey.lapshin wrote:

Would it be OK to integrate this patch in it`s current state and create another patch for warning about missed transformation for #pragma clang loop pipeline ?

Jan 11 2019, 12:43 PM