User Details
User Details
- User Since
- Jun 17 2015, 7:07 AM (431 w, 4 d)
Aug 25 2023
Aug 25 2023
Meinersbur added inline comments to D155765: [OpenMP Dialect] Add omp.canonical_loop operation..
Aug 2 2023
Aug 2 2023
Meinersbur added a comment to D156548: [TestSuite][OpenMP] Update expected pass list for external SOLLVE V&V test suite.
I get the following failures with this path on latest clang (rGd6f1880c629d629d03914ad564b4d7b188ada444):
******************** Failed Tests (7): test-suite :: External/sollve_vv/omptargetvv-test_loop_order_reproducible-51_order-c.test test-suite :: External/sollve_vv/omptargetvv-test_omp_num_teams_env_2-51_env_var-c.test test-suite :: External/sollve_vv/omptargetvv-test_omp_places_env_ll_caches-51_env_var-c.test test-suite :: External/sollve_vv/omptargetvv-test_omp_places_env_numa_domains-51_env_var-c.test test-suite :: External/sollve_vv/omptargetvv-test_omp_teams_thread_limit_env_2-51_env_var-c.test test-suite :: External/sollve_vv/omptargetvv-test_taskwait_depend-50_taskwait-c.test test-suite :: External/sollve_vv/omptargetvv-test_teams_region_routines-51_runtime_calls-c.test
Aug 2 2023, 9:16 AM · Restricted Project
Jul 31 2023
Jul 31 2023
Meinersbur added a comment to D156218: Add an MLIR example of some mimimal example of MLIR setup.
I think this broke the Windows build: https://lab.llvm.org/buildbot/#/builders/172/builds/29434. To investigate the issue, I took the buildbot offline to investigate. The error is:
[1/2] Building RC object tools\mlir\examples\minimal-opt\CMakeFiles\mlir-minimal-opt-can...zen-win\flang-x86_64-windows\llvm-project\llvm\resources\windows_version_resource.rc.res FAILED: tools/mlir/examples/minimal-opt/CMakeFiles/mlir-minimal-opt-canonicalize.dir/C_/Users/buildbot-worker/minipc-ryzen-win/flang-x86_64-windows/llvm-project/llvm/resources/windows_version_resource.rc.res C:/PROGRA~1/CMake/bin/cmcldeps.exe RC C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\llvm\resources\windows_version_resource.rc tools\mlir\examples\minimal-opt\CMakeFiles\mlir-minimal-opt-canonicalize.dir\C_\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\llvm\resources\windows_version_resource.rc.res.d tools\mlir\examples\minimal-opt\CMakeFiles\mlir-minimal-opt-canonicalize.dir\C_\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\llvm\resources\windows_version_resource.rc.res "Note: including file: " "C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x64/cl.exe" C:\PROGRA~2\WI3CF2~1\10\bin\100220~1.0\x64\rc.exe -DGTEST_HAS_RTTI=0 -DMLIR_CUDA_CONVERSIONS_ENABLED=0 -DMLIR_INCLUDE_TESTS -DMLIR_ROCM_CONVERSIONS_ENABLED=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_ENABLE_HARDENED_MODE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -DRC_FILE_VERSION=\"0\" -DRC_INTERNAL_NAME=\"mlir-minimal-opt-canonicalize\" -DRC_PRODUCT_NAME=\"LLVM\" -DRC_PRODUCT_VERSION=\"0\" -DRC_VERSION_FIELD_1=18 -DRC_VERSION_FIELD_2=0 -DRC_VERSION_FIELD_3=0 -DRC_VERSION_FIELD_4=0 -I C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\build\tools\mlir\examples\minimal-opt -I C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\mlir\examples\minimal-opt -I C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\build\include -I C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\llvm\include -I C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\mlir\include -I C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\build\tools\mlir\include -DWIN32 /nologo /fo tools\mlir\examples\minimal-opt\CMakeFiles\mlir-minimal-opt-canonicalize.dir\C_\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\llvm\resources\windows_version_resource.rc.res C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\llvm\resources\windows_version_resource.rc C:\Users\buildbot-worker\minipc-ryzen-win\flang-x86_64-windows\llvm-project\llvm\resources\windows_version_resource.rc: fatal error C1083: Cannot open compiler generated file: 'windows_version_resource.i': No such file or directory ninja: build stopped: subcommand failed.`
Jul 28 2023
Jul 28 2023
Meinersbur added a comment to D156548: [TestSuite][OpenMP] Update expected pass list for external SOLLVE V&V test suite.
Thank you for the update. Please allow me some time to test the changes on my machine.
Jul 28 2023, 10:15 AM · Restricted Project
Jul 21 2023
Jul 21 2023
Meinersbur added a reviewer for D155765: [OpenMP Dialect] Add omp.canonical_loop operation.: jdenny.
Jul 19 2023
Jul 19 2023
Meinersbur requested review of D155765: [OpenMP Dialect] Add omp.canonical_loop operation..
May 24 2023
May 24 2023
Meinersbur added inline comments to D147658: OpenMP Canonical Loop Operation for OMP Dialect (WIP).
May 17 2023
May 17 2023
Meinersbur added inline comments to D144226: [Loop-Interchange] Allow inner-loop only reductions.
Apr 26 2023
Apr 26 2023
Meinersbur added a comment to D144226: [Loop-Interchange] Allow inner-loop only reductions.
Can you summarize the algorithm in the description, in particular what a "removablePHIs" is and what distinguishes a inner-only reduction from an inner reduction?
LGTM
Mar 9 2023
Mar 9 2023
[Polly] Fix plugin build.
Mar 9 2023, 8:57 AM · Restricted Project
Mar 8 2023
Mar 8 2023
[Polly] Remove Polly-ACC.
Mar 8 2023, 3:35 PM · Restricted Project
[flang] Fix linker test on Windows.
Meinersbur added a comment to D142580: [Polly] Remove Polly-ACC..
@grosser ping
Meinersbur committed rG42cd38c01e5b: [Polly] Remove -polly-vectorizer=polly. (authored by Meinersbur).
[Polly] Remove -polly-vectorizer=polly.
Mar 8 2023, 10:55 AM · Restricted Project
Meinersbur added inline comments to D144377: [clang] Add #pragma clang loop [no]prefetch() (part1).
Feb 22 2023
Feb 22 2023
Meinersbur requested review of D144592: [flang] Fix linker test on Windows..
Feb 21 2023
Feb 21 2023
LGTM, but some description of what is tested would be useful. I would not expect people to search for the initial commit, find D132063 in the comment, and hope that Phabricator is still up.
Feb 21 2023, 10:00 PM · Restricted Project
LGTM
Feb 21 2023, 9:51 PM · Restricted Project
In the NPM, Polly uses buildFunctionSimplificationPipeline to cleanup after Polly. This was for the legacy pass manager.
Meinersbur added a comment to D144377: [clang] Add #pragma clang loop [no]prefetch() (part1).
Can we also see the code that makes use of the new metadata?
Feb 8 2023
Feb 8 2023
Sorry, neglected reviews around the holidays.
Feb 8 2023, 6:39 AM · Restricted Project
Feb 5 2023
Feb 5 2023
Meinersbur added a comment to D143325: [Driver] Add -mllvm= as an alias for -mllvm.
This patch broke the Flang buildbot, e.g. https://lab.llvm.org/buildbot/#/builders/172/builds/23305
Jan 26 2023
Jan 26 2023
Meinersbur requested review of D142640: [Polly] Remove -polly-vectorizer=polly..
Meinersbur updated the diff for D142580: [Polly] Remove Polly-ACC..
Also remove pet.h
Meinersbur updated the diff for D142580: [Polly] Remove Polly-ACC..
Invert patch.
Jan 25 2023
Jan 25 2023
Meinersbur requested review of D142580: [Polly] Remove Polly-ACC..
Meinersbur committed rGd327667d8afd: [Polly] Remove failing Polly-ACC test. (authored by Meinersbur).
[Polly] Remove failing Polly-ACC test.
Jan 25 2023, 9:13 AM · Restricted Project
Meinersbur added a comment to D142308: [Polly] Fix a if condition in isl_coalesce.ci.
Thank you for the patch. However, we do not patch ISL in the LLVM directly, but instead report upstream to isl-development@googlegroups.com and then update the LLVM copy.
Meinersbur committed rGa749e09e184b: [Polly] Update ISL to isl-0.25-193-g8621c60c. (authored by Meinersbur).
[Polly] Update ISL to isl-0.25-193-g8621c60c.
Jan 25 2023, 8:48 AM · Restricted Project
Meinersbur added a comment to D142255: [WIP] Loop peeling opportunity for identity operators.
The approach looks good to me. Got some smaller remarks, nothing critical since it doesn't affect correctness.
Jan 11 2023
Jan 11 2023
Sorry I didn't find time to review it.
Jan 4 2023
Jan 4 2023
Meinersbur added a comment to D138411: Enable OMPD tests.
The test ompd-test::test_ompd_get_icv_from_scope.c is (still?) failing on the openmp-offload-cuda-runtime buildbot:
******************** TEST 'ompd-test :: api_tests/test_ompd_get_icv_from_scope.c' FAILED ********************
Script:
--
: 'RUN: at line 1'; /home/buildbot-worker/minipc-1050ti-linux/rundir/llvm.build/./bin/clang -fopenmp -g -gdwarf-4 /home/buildbot-worker/src/llvm-project/openmp/libompd/test/api_tests/test_ompd_get_icv_from_scope.c -o /home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/api_tests/Output/test_ompd_get_icv_from_scope.c.tmp -I /home/buildbot-worker/minipc-1050ti-linux/rundir/llvm.src/openmp/libompd/test -I /home/buildbot-worker/minipc-1050ti-linux/rundir/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -L /home/buildbot-worker/minipc-1050ti-linux/rundir/llvm.build/runtimes/runtimes-bins/openmp/runtime/src 2>&1 | tee /home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/api_tests/Output/test_ompd_get_icv_from_scope.c.tmp.compile
: 'RUN: at line 2'; env OMP_DEBUG=enabled gdb -x /home/buildbot-worker/minipc-1050ti-linux/rundir/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/../gdb-plugin/python-module/ompd/__init__.py -x /home/buildbot-worker/src/llvm-project/openmp/libompd/test/api_tests/test_ompd_get_icv_from_scope.c.cmd /home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/api_tests/Output/test_ompd_get_icv_from_scope.c.tmp 2>&1 | tee /home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/api_tests/Output/test_ompd_get_icv_from_scope.c.tmp.out | /home/buildbot-worker/minipc-1050ti-linux/rundir/llvm.build/./bin/FileCheck /home/buildbot-worker/src/llvm-project/openmp/libompd/test/api_tests/test_ompd_get_icv_from_scope.c
--
Exit Code: 1
Command Output (stdout):
--
$ ":" "RUN: at line 1"
$ "/home/buildbot-worker/minipc-1050ti-linux/rundir/llvm.build/./bin/clang" "-fopenmp" "-g" "-gdwarf-4" "/home/buildbot-worker/src/llvm-project/openmp/libompd/test/api_tests/test_ompd_get_icv_from_scope.c" "-o" "/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/api_tests/Output/test_ompd_get_icv_from_scope.c.tmp" "-I" "/home/buildbot-worker/minipc-1050ti-linux/rundir/llvm.src/openmp/libompd/test" "-I" "/home/buildbot-worker/minipc-1050ti-linux/rundir/llvm.build/runtimes/runtimes-bins/openmp/runtime/src" "-L" "/home/buildbot-worker/minipc-1050ti-linux/rundir/llvm.build/runtimes/runtimes-bins/openmp/runtime/src"
$ "tee" "/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/api_tests/Output/test_ompd_get_icv_from_scope.c.tmp.compile"
$ ":" "RUN: at line 2"
$ "env" "OMP_DEBUG=enabled" "gdb" "-x" "/home/buildbot-worker/minipc-1050ti-linux/rundir/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/../gdb-plugin/python-module/ompd/__init__.py" "-x" "/home/buildbot-worker/src/llvm-project/openmp/libompd/test/api_tests/test_ompd_get_icv_from_scope.c.cmd" "/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/api_tests/Output/test_ompd_get_icv_from_scope.c.tmp"
$ "tee" "/home/buildbot-worker/minipc-1050ti-linux/openmp-offload-cuda-runtime/llvm.build/runtimes/runtimes-bins/openmp/libompd/test/api_tests/Output/test_ompd_get_icv_from_scope.c.tmp.out"
$ "/home/buildbot-worker/minipc-1050ti-linux/rundir/llvm.build/./bin/FileCheck" "/home/buildbot-worker/src/llvm-project/openmp/libompd/test/api_tests/test_ompd_get_icv_from_scope.c"
# command stderr:
/home/buildbot-worker/src/llvm-project/openmp/libompd/test/api_tests/test_ompd_get_icv_from_scope.c:29:15: error: CHECK-NOT: excluded string found in input
// CHECK-NOT: Failed
^
<stdin>:62:1: note: found here
Failed. with return code = 0
^~~~~~
Input file: <stdin>
Check file: /home/buildbot-worker/src/llvm-project/openmp/libompd/test/api_tests/test_ompd_get_icv_from_scope.c
-dump-input=help explains the following input dump.
Input was:
<<<<<<
.
.
.
57: Success.
58: Testing "ompd_get_icv_from_scope with thread_handle"...
59: Test: With Correct Arguments.
60: Success.
61: Test: with nthreads_var for ompd_rc_incomplete.
62: Failed. with return code = 0
not:29 !~~~~~ error: no match expected
63: Testing "ompd_get_icv_from_scope with parallel_handle"...
64: Test: With Correct Arguments.
65: Success.
66: Testing "ompd_get_icv_from_scope with task_handle"...
67: Test: With Correct Arguments.
.
.
.
>>>>>>
error: command failed with exit status: 1
--
********************Dec 24 2022
Dec 24 2022
Meinersbur added a comment to D135174: [SLP]Redesign vectorization of the gather nodes..
This patch caused https://github.com/llvm/llvm-project/issues/59693.
Dec 21 2022
Dec 21 2022
Meinersbur committed rT36e96bd4ad38: [SOLLVE V&V] Disable failing expect-pass tests. (authored by Meinersbur).
[SOLLVE V&V] Disable failing expect-pass tests.
Dec 21 2022, 7:53 AM · Restricted Project
Dec 5 2022
Dec 5 2022
Meinersbur committed rG6ccd163c1c33: [Polly] Use std::nullopt to unbreak build. (authored by Meinersbur).
[Polly] Use std::nullopt to unbreak build.
Dec 5 2022, 3:54 PM · Restricted Project
Nov 17 2022
Nov 17 2022
Meinersbur added a comment to D137774: [openmp] Create a local llvm-lit script when building openmp standalone.
Why not using env LIT_FILTER=<testname> ninja check-openmp environment variable to run individual tests?
Meinersbur added a comment to D137772: [openmp] [test] Set __COMPAT_LAYER=RunAsInvoker when running tests on Windows.
since it may think some of them are installers - executables with "dispatch" in the name may hit a heuristic looking for "patch"
LGTM
Meinersbur accepted D137747: [openmp] [test] Fix warnings about printf format mismatches on Windows.
LGTM
Nov 16 2022
Nov 16 2022
Meinersbur added a comment to D137461: [LoopInterchange] Refactor and rewrite validDepInterchange().
The two changes (Direction == '*' and checking the dep vector before doing the interchange) may add safety, but also cause tests to fail. @bmahjour suggested we could mark those as XFAIL and fix in a followup-patch, if not directly handled in this patch. Thing that I think are two strict:
Meinersbur added inline comments to D135808: [LoopInterchange] Correcting the profitability check.
Meinersbur added a comment to D135808: [LoopInterchange] Correcting the profitability check.
Nov 14 2022
Nov 14 2022
Meinersbur added a comment to D132594: [flang] Fix msvc 17.3 build..
Microsoft's bugtracker indicates that this was fixed in msvc 19.34.31933 / VS17.4
Herald added a reviewer for D124823: [OpenMPIRBuilder] Introduce OMPRegionInfo managing the stack of OpenMP region constructs.: nicolasvasilache.
ping
Nov 14 2022, 9:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Nov 11 2022
Nov 11 2022
This involves a deep copy of the entire DepMatrix. I still find that acceptable to gain a much more logical dependency checking.
Nov 10 2022
Nov 10 2022
Meinersbur updated the diff for D115218: [CodeExtractor] Refactor extractCodeRegion, fix parameter index confusion..
- Rebase
- Address review
Meinersbur added inline comments to D115218: [CodeExtractor] Refactor extractCodeRegion, fix parameter index confusion..
Nov 9 2022
Nov 9 2022
Meinersbur added a comment to D115218: [CodeExtractor] Refactor extractCodeRegion, fix parameter index confusion..
Ping
Ping
Nov 8 2022
Nov 8 2022
Meinersbur accepted D136415: [LSR] Check if terminating value is safe to expand before transformation.
LGTM
Nov 3 2022
Nov 3 2022
Meinersbur added a comment to D137338: Fix dupe word typos.
Changes in /polly/ look good to me.
Nov 3 2022, 8:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Nov 2 2022
Nov 2 2022
Meinersbur added a reviewer for D136415: [LSR] Check if terminating value is safe to expand before transformation: Restricted Project.
Abandon as discussed in the LoopWG call. It coarsens the analysis when compile time wasn't even a problem.
Meinersbur updated the summary of D136277: [LoopInterchange] Simplify DepMatrix to a dependency vector..
Nov 1 2022
Nov 1 2022
Meinersbur added a comment to D132703: [LAA] Use BTC to rule out dependences if one ptr is loop invariant..
It is a bit irritating that the current logic does not consider which direction the pointers are traveling. E.g. Src = &D[0] and Sink = %D[1+ i] never overlap (with non-negative i), but the code seems to consider Src before or after Sink symmetrically. But that's what the current code does. Changing that as @reames suggested computing memory regions relative to the base pointer might require more some effort, but this smaller change looks fine to me.
Meinersbur added a comment to D136277: [LoopInterchange] Simplify DepMatrix to a dependency vector..
Meinersbur updated the summary of D136277: [LoopInterchange] Simplify DepMatrix to a dependency vector..
Oct 27 2022
Oct 27 2022
Meinersbur added inline comments to D136415: [LSR] Check if terminating value is safe to expand before transformation.
LGTM
Meinersbur added inline comments to D136626: [docs][NewPM] Move pass plugin documentation into existing new PM docs.
Meinersbur added a reviewer for D136626: [docs][NewPM] Move pass plugin documentation into existing new PM docs: pfaffe.
LGTM
Oct 26 2022
Oct 26 2022
Meinersbur added a comment to D136621: [polly] Remove legacy pass manager hooks.
MaximalStaticExpansion expansion was actually already ported to the NPM in D125870. I made the NPM pass builder use it in rGb150d34c47ef.
Meinersbur committed rGb150d34c47ef: [Polly] Add support for -polly-enable-mse with NPM. (authored by Meinersbur).
[Polly] Add support for -polly-enable-mse with NPM.
Oct 26 2022, 3:32 PM · Restricted Project
Meinersbur committed rGbb90d7ee3943: [Polly] Add support for -polly-export with NPM. (authored by Meinersbur).
[Polly] Add support for -polly-export with NPM.
Oct 26 2022, 3:22 PM · Restricted Project
Meinersbur updated subscribers of D136621: [polly] Remove legacy pass manager hooks.
Some other Polly options become inaccessible using any pipeline builder: PollyACC (-polly-target), static expansion (-polly-enable-mse), polyhedral info (-polly-enable-polyhedralinfo), and JSON export (-polly-export).
Meinersbur added inline comments to D136102: [LoopSimplify] Update loop-metadata ID after loop-simplify splitting out new outer loop.
Meinersbur added inline comments to D136621: [polly] Remove legacy pass manager hooks.
Meinersbur added a comment to D136621: [polly] Remove legacy pass manager hooks.
-enable-new-pm is going to be removed from opt? What is that patch doing that?
LGTM. thank you for the update.
LGTM
LGTM, and sorry for the delay.
Oct 25 2022
Oct 25 2022
Meinersbur added inline comments to D136102: [LoopSimplify] Update loop-metadata ID after loop-simplify splitting out new outer loop.
Oct 24 2022
Oct 24 2022
Meinersbur committed rG0c849adf4f97: [Polly][docs] Avoid use of code-block:: guess. (authored by Meinersbur).
[Polly][docs] Avoid use of code-block:: guess.
Oct 24 2022, 5:55 PM · Restricted Project
Oct 20 2022
Oct 20 2022
Meinersbur committed rGb4b7fa234cfa: [Polly] Ensure -polly-detect-keep-going still eventually rejects invalid… (authored by Meinersbur).
[Polly] Ensure -polly-detect-keep-going still eventually rejects invalid…
Oct 20 2022, 11:35 AM · Restricted Project
Oct 19 2022
Oct 19 2022
Meinersbur added a comment to D136261: Introduce range based singleton searches for loop queries.
Thank you for the patch.
Meinersbur requested review of D136277: [LoopInterchange] Simplify DepMatrix to a dependency vector..
Meinersbur added a comment to D135808: [LoopInterchange] Correcting the profitability check.
Could you add a test case that is not considered profitable where before it was not?
Oct 18 2022
Oct 18 2022
Meinersbur accepted D134930: [LoopInterchange] Do not interchange when a reduction phi in all subloops of the outer loop is not recognizable.
LGTM. Thank you.
Sep 21 2022
Sep 21 2022
LGTM
Sep 6 2022
Sep 6 2022
Meinersbur added a comment to D133344: [mlir][Math] Add constant folder for RoundEvenOp..
This caused the Windows build to fail:
Aug 25 2022
Aug 25 2022
Meinersbur added a comment to D131919: Move googletest to the third-party directory.
Semi-OT: polly\lib\External has 3 more third-party libraries. Two of them have been heavily modified in-tree, the third has just a custom CMakeLists.txt.
Should these eventually also be moved?
Aug 25 2022, 11:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Aug 24 2022
Aug 24 2022
[flang] Fix msvc 17.3 build.
Meinersbur updated the diff for D132594: [flang] Fix msvc 17.3 build..
Add source comment explaining this is a workaround
Meinersbur added a comment to D132594: [flang] Fix msvc 17.3 build..
Meinersbur requested review of D132594: [flang] Fix msvc 17.3 build..
Aug 18 2022
Aug 18 2022
LGTM
Aug 18 2022, 8:39 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Aug 10 2022
Aug 10 2022
Meinersbur added inline comments to D131526: [OMPIRBuilder] Add support for safelen clause.
Aug 10 2022, 7:54 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Aug 8 2022
Aug 8 2022
Meinersbur added inline comments to D114336: [Polly] Generalize the pattern matching to the case of tensor contractions..
Meinersbur committed rG8c0979c8f772: [flang][test] Don't require .exe suffix. (authored by Meinersbur).
[flang][test] Don't require .exe suffix.
Aug 3 2022
Aug 3 2022
Meinersbur added a comment to D130851: [MLIR][OpenMP] Unroll Construct operation.
Meinersbur added a comment to D129127: ManagedStatic: remove from DynamicLibrary.
I am responsible for one of the buildbots that failed (https://lab.llvm.org/buildbot/#/builders/172). If you don't have access to a Windows machine to reproduce the problem, I could help.
Meinersbur added inline comments to D130615: [OpenMP][IRBuilder] Added if clause to task.