Meinersbur (Michael Kruse)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 17 2015, 7:07 AM (140 w, 2 d)

Recent Activity

Wed, Feb 21

Meinersbur added a comment to D43536: [LV] Quick workaround for PR36311, vectorizer's isUniform() abuse triggers assert in SCEV.

LGTM, however I am not the right person to approve patches to the LoopVectorizer.

Wed, Feb 21, 8:24 PM

Tue, Feb 20

Meinersbur added a comment to D43536: [LV] Quick workaround for PR36311, vectorizer's isUniform() abuse triggers assert in SCEV.

Is it worthwhile to add a regression test that would trigger the assertion?

Tue, Feb 20, 5:06 PM

Mon, Feb 12

Meinersbur committed rL324934: [ScopBuilder] scalar-indep: Fix mutually referencing PHIs..
[ScopBuilder] scalar-indep: Fix mutually referencing PHIs.
Mon, Feb 12, 1:11 PM

Fri, Feb 2

Meinersbur closed D42151: [Polly][ScopBuilder] Make -polly-stmt-granularity=scalar-indep the default..
Fri, Feb 2, 11:01 PM · Restricted Project
Meinersbur added a comment to D42151: [Polly][ScopBuilder] Make -polly-stmt-granularity=scalar-indep the default..

Waiting for confirmation this is ok before committing

Fri, Feb 2, 10:03 PM · Restricted Project
Meinersbur updated the diff for D42151: [Polly][ScopBuilder] Make -polly-stmt-granularity=scalar-indep the default..

Instead of adding -polly-stmt-granulairy=bb globally, only add the flag to the tests that need it.

Fri, Feb 2, 9:50 PM · Restricted Project
Meinersbur committed rL324168: [ScopInfo] Allow epilogues to be the main statement of a BB..
[ScopInfo] Allow epilogues to be the main statement of a BB.
Fri, Feb 2, 9:46 PM
Meinersbur committed rL324112: Run clang-format after r324003. NFC..
Run clang-format after r324003. NFC.
Fri, Feb 2, 10:14 AM

Jan 23 2018

Meinersbur committed rL323284: [ScopBuilder] Prefer PHI Write accesses in the statement the incoming value is….
[ScopBuilder] Prefer PHI Write accesses in the statement the incoming value is…
Jan 23 2018, 4:00 PM
Meinersbur closed D42147: [Polly][ScopBuilder] Prefer PHI Write accesses in the statement the incoming value is defined..
Jan 23 2018, 4:00 PM · Restricted Project
Meinersbur committed rL323283: [VirtualInst] Derive correct use kind of PHI operands. NFC..
[VirtualInst] Derive correct use kind of PHI operands. NFC.
Jan 23 2018, 4:00 PM

Jan 19 2018

Meinersbur added a comment to D42147: [Polly][ScopBuilder] Prefer PHI Write accesses in the statement the incoming value is defined..
Program                                                                        leone_F30_statementnaming_indep  leone_G30_epilogue_indep diff
Jan 19 2018, 4:50 AM · Restricted Project

Jan 18 2018

Meinersbur updated the diff for D42147: [Polly][ScopBuilder] Prefer PHI Write accesses in the statement the incoming value is defined..
  • Rebase
Jan 18 2018, 7:48 AM · Restricted Project
Meinersbur committed rL322852: [ScopBuilder] Revise statement naming when there are multiple statements per BB..
[ScopBuilder] Revise statement naming when there are multiple statements per BB.
Jan 18 2018, 7:18 AM
Meinersbur committed rL322851: [ScopInfo] Pass name to ScopStmt ctor. NFC..
[ScopInfo] Pass name to ScopStmt ctor. NFC.
Jan 18 2018, 7:18 AM
Meinersbur closed D42136: [Polly][ScopBuilder] Revise statement naming when there are multiple statements per BB..
Jan 18 2018, 7:18 AM · Restricted Project
Meinersbur added a comment to D42142: [Polly] [WIP] Adding Live-Range Reordering for Polly.

@bollu I agree DependenceInfo would be a good place to compute the conditional dependencies. However, as long we don't have another consumer for this data, it doesn't seem important to me.

Jan 18 2018, 5:17 AM

Jan 17 2018

Meinersbur added a comment to D42142: [Polly] [WIP] Adding Live-Range Reordering for Polly.

@bollu Alex added the code duplication because I suggested him to do so. IMHO the live-range reordering should not depend on ppcg at all. ppcg is not written as a library so in terms of software quality, we should not use it as one. On the llvm mailing list we currently discuss the inclusion of isl. I don't think we will not do the same for ppcg, meaning that if live-range reordering depends on it, we would have to remove it again should Polly be included into LLVM main.

Jan 17 2018, 5:02 AM

Jan 16 2018

Meinersbur added dependencies for D42151: [Polly][ScopBuilder] Make -polly-stmt-granularity=scalar-indep the default.: D42136: [Polly][ScopBuilder] Revise statement naming when there are multiple statements per BB., D42147: [Polly][ScopBuilder] Prefer PHI Write accesses in the statement the incoming value is defined..
Jan 16 2018, 5:02 PM · Restricted Project
Meinersbur added a dependent revision for D42136: [Polly][ScopBuilder] Revise statement naming when there are multiple statements per BB.: D42151: [Polly][ScopBuilder] Make -polly-stmt-granularity=scalar-indep the default..
Jan 16 2018, 5:02 PM · Restricted Project
Meinersbur created D42151: [Polly][ScopBuilder] Make -polly-stmt-granularity=scalar-indep the default..
Jan 16 2018, 5:01 PM · Restricted Project
Meinersbur added a comment to D42142: [Polly] [WIP] Adding Live-Range Reordering for Polly.

Hi Alex,

Jan 16 2018, 4:44 PM
Meinersbur created D42147: [Polly][ScopBuilder] Prefer PHI Write accesses in the statement the incoming value is defined..
Jan 16 2018, 4:39 PM · Restricted Project
Meinersbur added a reviewer for D42136: [Polly][ScopBuilder] Revise statement naming when there are multiple statements per BB.: nandini12396.
Jan 16 2018, 4:31 PM · Restricted Project
Meinersbur retitled D42136: [Polly][ScopBuilder] Revise statement naming when there are multiple statements per BB. from [Polly][StmtBuilder] Revise statement naming when there are multiple statements per BB. to [Polly][ScopBuilder] Revise statement naming when there are multiple statements per BB..
Jan 16 2018, 2:59 PM · Restricted Project
Meinersbur updated the summary of D42136: [Polly][ScopBuilder] Revise statement naming when there are multiple statements per BB..
Jan 16 2018, 2:53 PM · Restricted Project
Meinersbur created D42136: [Polly][ScopBuilder] Revise statement naming when there are multiple statements per BB..
Jan 16 2018, 2:52 PM · Restricted Project
Meinersbur accepted D42129: [polly] [ScopInfo] Don't use isl_val_get_num_si..

Fallback value can be discussed separately, it also exists in the current codebase.

Jan 16 2018, 2:36 PM
Meinersbur added inline comments to D42129: [polly] [ScopInfo] Don't use isl_val_get_num_si..
Jan 16 2018, 2:01 PM
Meinersbur added inline comments to D42129: [polly] [ScopInfo] Don't use isl_val_get_num_si..
Jan 16 2018, 1:51 PM
Meinersbur committed rL322581: [IslTools] dumpPw: Dump same structure pieces together..
[IslTools] dumpPw: Dump same structure pieces together.
Jan 16 2018, 10:41 AM

Jan 15 2018

Meinersbur retitled D40122: Add isl to LLVM repository. from [WIP] Add isl to LLVM repository. to Add isl to LLVM repository..
Jan 15 2018, 9:31 AM
Meinersbur updated the summary of D40122: Add isl to LLVM repository..
Jan 15 2018, 8:47 AM
Meinersbur updated the summary of D40122: Add isl to LLVM repository..
Jan 15 2018, 8:26 AM
Meinersbur updated the diff for D40122: Add isl to LLVM repository..
  • Include isl conditionally using LLVM_INCLUDE_ISL (defaults to OFF)
  • Fix include paths (llvm-config and install)
  • Use -w flag only for gcc/clang
Jan 15 2018, 8:15 AM

Jan 12 2018

Meinersbur committed rL322376: [CMake] Use only keyword-version of target_link_library. NFC..
[CMake] Use only keyword-version of target_link_library. NFC.
Jan 12 2018, 8:11 AM

Jan 3 2018

Meinersbur added a comment to D41694: [Polly][ScopInfo] Remove RunTimeChecksMaxAccessDisjuncts bail-out condition..

I'd rather remove the number of magic constants that make impactful decisions. If the goal is to reduce the computational overhead, I'd recommend to take the convex hull before lexmin/lexmin, not bail-out.

Jan 3 2018, 7:31 AM · Restricted Project
Meinersbur created D41694: [Polly][ScopInfo] Remove RunTimeChecksMaxAccessDisjuncts bail-out condition..
Jan 3 2018, 2:43 AM · Restricted Project
Meinersbur created D41692: [Polly][WIP] Remove immediate dominator heuristic for error block detection..
Jan 3 2018, 2:20 AM · Restricted Project

Dec 21 2017

Meinersbur committed rL321329: Fix isl out-of-quota errors affecting later quota guards..
Fix isl out-of-quota errors affecting later quota guards.
Dec 21 2017, 5:11 PM

Dec 11 2017

Meinersbur added a comment to D36056: [Polly] Pass around Domain of BB to getPwAff(). NFC..

@Meinersbur : I dont know what to do with the Context in buildConditionSets(). Could you please suggest?

Dec 11 2017, 8:37 AM
Meinersbur added a comment to D37337: [Polly] Split statements on encountering store instructions..

I filed a bug for this option: http://llvm.org/PR35623 .

Dec 11 2017, 7:17 AM · Restricted Project
Meinersbur committed rL320360: [ScopBuilder] Split statements on encountering store instructions..
[ScopBuilder] Split statements on encountering store instructions.
Dec 11 2017, 4:52 AM
Meinersbur closed D37337: [Polly] Split statements on encountering store instructions. by committing rL320360: [ScopBuilder] Split statements on encountering store instructions..
Dec 11 2017, 4:52 AM · Restricted Project
Meinersbur accepted D37337: [Polly] Split statements on encountering store instructions..

LGTM, going to committ...

Dec 11 2017, 4:51 AM · Restricted Project

Dec 10 2017

Meinersbur committed rL320336: [ScopBuilder] Fix typo. NFC..
[ScopBuilder] Fix typo. NFC.
Dec 10 2017, 2:57 PM
Meinersbur closed D41047: [Polly] Fix typo. NFC by committing rL320336: [ScopBuilder] Fix typo. NFC..
Dec 10 2017, 2:57 PM
Meinersbur accepted D41047: [Polly] Fix typo. NFC.

Oops, embarrassing type by me. Thanks a lot.

Dec 10 2017, 2:56 PM

Dec 6 2017

Meinersbur accepted D40803: Port SCEVAffinator to the isl c++ bindings.
Dec 6 2017, 12:48 PM

Dec 4 2017

Meinersbur added a comment to D40803: Port SCEVAffinator to the isl c++ bindings.

After removing the isl memory annotations: LGTM.

Dec 4 2017, 3:07 PM
Meinersbur accepted D40791: [Polly] update to latest clang-format. [NFC].

Do you know which revision/changes in clang-format caused this?

Dec 4 2017, 2:47 PM · Restricted Project

Dec 1 2017

Meinersbur added a comment to D40369: Support sext, zext and trunc instructions in SCEV delinearization algorithm (new revision).

Thanks Alex for the patch. I just see it now. As Eli is mentioning already, could you separate the patch into separate differentials?

Dec 1 2017, 8:39 AM

Nov 30 2017

Meinersbur committed rL319426: Update format after clang-format change. NFC..
Update format after clang-format change. NFC.
Nov 30 2017, 4:06 AM

Nov 27 2017

Meinersbur added inline comments to D40492: Handle Top-Level-Regions in polly::isHoistableLoad.
Nov 27 2017, 8:11 AM · Restricted Project

Nov 21 2017

Meinersbur committed rL318795: Run polly-update-format. NFC..
Run polly-update-format. NFC.
Nov 21 2017, 11:26 AM

Nov 19 2017

Meinersbur updated the diff for D40122: Add isl to LLVM repository..

Remove duplicated empty lines.

Nov 19 2017, 1:31 PM
Meinersbur added a comment to D39971: Port ScopInfo to the isl cpp bindings.

Looks great (whatever you decide to to with the inline comment)

Nov 19 2017, 10:25 AM

Nov 16 2017

Meinersbur added a comment to D40126: [Polly] [PCGCodeGen] Change printf to outs() to prevent garbled output. [NFC].

Shouldn't this actually go to errs() instead?

Nov 16 2017, 7:39 AM
Meinersbur added a reviewer for D40122: Add isl to LLVM repository.: philip.pfaffe.
Nov 16 2017, 5:22 AM
Meinersbur added a dependency for D40122: Add isl to LLVM repository.: D40123: Add isl and imath..
Nov 16 2017, 5:18 AM
Meinersbur added a dependent revision for D40123: Add isl and imath.: D40122: Add isl to LLVM repository..
Nov 16 2017, 5:18 AM
Meinersbur created D40123: Add isl and imath..
Nov 16 2017, 5:18 AM
Meinersbur created D40122: Add isl to LLVM repository..
Nov 16 2017, 5:10 AM

Nov 14 2017

Meinersbur added a comment to D39971: Port ScopInfo to the isl cpp bindings.

I cannot apply this patch, arcanist always tries to apply it on git sha1 85a1620 (current trunk without D39979).

Nov 14 2017, 7:40 AM
Meinersbur accepted D39971: Port ScopInfo to the isl cpp bindings.

LGTM, only nitpicks. Thanks for your work.

Nov 14 2017, 7:28 AM
Meinersbur added a dependent revision for D39979: [Polly][SI] Fix a potential use-after-free: D39971: Port ScopInfo to the isl cpp bindings.
Nov 14 2017, 7:27 AM
Meinersbur added a dependency for D39971: Port ScopInfo to the isl cpp bindings: D39979: [Polly][SI] Fix a potential use-after-free.
Nov 14 2017, 7:27 AM
Meinersbur accepted D39979: [Polly][SI] Fix a potential use-after-free.

LGMT, thanks.

Nov 14 2017, 6:35 AM

Nov 9 2017

Meinersbur committed rL317808: Update formatting to reflect change in clang-format. NFC..
Update formatting to reflect change in clang-format. NFC.
Nov 9 2017, 8:33 AM

Nov 6 2017

Meinersbur committed rL317495: [ForwardOpTree] Limit isl operations of known content reload..
[ForwardOpTree] Limit isl operations of known content reload.
Nov 6 2017, 9:49 AM
Meinersbur accepted D39683: [Polly] Fix using order, as this caused a test failure (NFC) .

LGTM, fails for me too. Probably caused by change in clang-format: rL317325

Nov 6 2017, 6:23 AM

Oct 31 2017

Meinersbur committed rL317008: [ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values..
[ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values.
Oct 31 2017, 9:12 AM
Meinersbur closed D39333: [Polly][ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values. by committing rL317008: [ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values..
Oct 31 2017, 9:12 AM · Restricted Project
Meinersbur committed rL316995: [DeLICM] Fix wrong assumed access execution order..
[DeLICM] Fix wrong assumed access execution order.
Oct 31 2017, 5:50 AM
Meinersbur abandoned D38308: [Polly][isl++] Define dump() functions in translation unit. NFC..

Abandon because the alternative was committed

Oct 31 2017, 3:31 AM

Oct 30 2017

Meinersbur added inline comments to D39333: [Polly][ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values..
Oct 30 2017, 7:33 AM · Restricted Project
Meinersbur updated the diff for D39333: [Polly][ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values..
  • Address Siddharth's remarks
  • Fix one more TODO
Oct 30 2017, 7:17 AM · Restricted Project
Meinersbur updated the diff for D39333: [Polly][ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values..
  • Introduce isNormalizable to resolve TODO
  • Remove unused function attributes in test-case
  • Add example to NormalizedPHI doxygen
Oct 30 2017, 3:01 AM · Restricted Project

Oct 27 2017

Meinersbur committed rL316769: [ForwardOpTree] Use space indention. NFC..
[ForwardOpTree] Use space indention. NFC.
Oct 27 2017, 7:49 AM
Meinersbur committed rL316766: [ForwardOpTree] Reload know values..
[ForwardOpTree] Reload know values.
Oct 27 2017, 7:26 AM
Meinersbur closed D39325: [Polly][ForwardOpTree] Reload know values. by committing rL316766: [ForwardOpTree] Reload know values..
Oct 27 2017, 7:26 AM · Restricted Project
Meinersbur added a comment to D39364: [Polly][acc] Do not statically dispatch into IslNodeBuilder's createFor.

For me this is OK. We cannot reliably test undefined behavior. Tools like TypeSanitizer exist for this purpose.

Oct 27 2017, 4:51 AM
Meinersbur accepted D39364: [Polly][acc] Do not statically dispatch into IslNodeBuilder's createFor.

LGTM

Oct 27 2017, 2:23 AM

Oct 26 2017

Meinersbur added a dependent revision for D39325: [Polly][ForwardOpTree] Reload know values.: D39333: [Polly][ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values..
Oct 26 2017, 8:40 AM · Restricted Project
Meinersbur added a dependency for D39333: [Polly][ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values.: D39325: [Polly][ForwardOpTree] Reload know values..
Oct 26 2017, 8:40 AM · Restricted Project
Meinersbur updated the diff for D39333: [Polly][ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values..

Add selfrefphi test case

Oct 26 2017, 8:39 AM · Restricted Project
Meinersbur created D39333: [Polly][ZoneAlgo/ForwardOpTree] Normalize PHIs to their known incoming values..
Oct 26 2017, 8:19 AM · Restricted Project
Meinersbur created D39325: [Polly][ForwardOpTree] Reload know values..
Oct 26 2017, 1:41 AM · Restricted Project
Meinersbur committed rL316642: [DeLICM] Add more tests for loop layouts. NFC..
[DeLICM] Add more tests for loop layouts. NFC.
Oct 26 2017, 1:03 AM

Oct 24 2017

Meinersbur committed rL316464: [opt] Initialize WriteBitcode pass..
[opt] Initialize WriteBitcode pass.
Oct 24 2017, 10:17 AM
Meinersbur closed D39223: [opt] Initialize WriteBitcode pass. by committing rL316464: [opt] Initialize WriteBitcode pass..
Oct 24 2017, 10:17 AM
Meinersbur added a comment to D39223: [opt] Initialize WriteBitcode pass..

Alternatively, is there an initializeBitcode{Reader/Writer}() function that initializes all passes from the Bitcode lib?

The reader and writer are in separate libraries, aren't they?

Oct 24 2017, 10:00 AM
Meinersbur committed rL316459: [ZoneAlgo] Translate addArrayWriteAccess to isl++. NFC..
[ZoneAlgo] Translate addArrayWriteAccess to isl++. NFC.
Oct 24 2017, 9:40 AM
Meinersbur committed rL316445: [ISLTools] Translate computeReachingWrite to isl++. NFC..
[ISLTools] Translate computeReachingWrite to isl++. NFC.
Oct 24 2017, 8:20 AM
Meinersbur committed rL316432: [DeLICM] Do not try to map to multiple array elements..
[DeLICM] Do not try to map to multiple array elements.
Oct 24 2017, 6:05 AM
Meinersbur created D39223: [opt] Initialize WriteBitcode pass..
Oct 24 2017, 1:40 AM

Oct 20 2017

Meinersbur added a comment to D38953: Updating the TipsAndTricks.rst documentation of Polly related to bugpoint.

Could you check whether this works for you:

Oct 20 2017, 6:51 PM · Restricted Project

Oct 17 2017

Meinersbur added a comment to D38953: Updating the TipsAndTricks.rst documentation of Polly related to bugpoint.

Thanks for improving our documentation!

Oct 17 2017, 1:52 PM · Restricted Project

Oct 6 2017

Meinersbur added a comment to D37337: [Polly] Split statements on encountering store instructions..

Please add at least one test case where a basic block is successfully split up and check that there are two statements now.

Oct 6 2017, 2:13 AM · Restricted Project

Oct 5 2017

Meinersbur committed rL314983: [ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option..
[ScopBuilder] Introduce -polly-stmt-granularity=scalar-indep option.
Oct 5 2017, 6:44 AM