Page MenuHomePhabricator

abidmalikwaterloo (Abid)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2020, 2:43 PM (124 w, 3 d)

Recent Activity

Tue, May 24

abidmalikwaterloo added a comment to D122255: Meta directive runtime support.

Should I update the patch? I am waiting for quick feedback on the concept of handling conditions.

Tue, May 24, 9:32 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added inline comments to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..
Tue, May 24, 9:23 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added inline comments to D105584: [MLIR][OpenMP] Distribute Construct Operation.
Tue, May 24, 9:04 AM · Restricted Project, Restricted Project, Restricted Project

Wed, May 18

abidmalikwaterloo added inline comments to D105584: [MLIR][OpenMP] Distribute Construct Operation.
Wed, May 18, 11:28 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added inline comments to D105584: [MLIR][OpenMP] Distribute Construct Operation.
Wed, May 18, 9:07 AM · Restricted Project, Restricted Project, Restricted Project

Mon, May 16

abidmalikwaterloo added inline comments to D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.
Mon, May 16, 9:57 AM · Restricted Project, Restricted Project

Fri, May 13

abidmalikwaterloo added a comment to D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.

This patch need rebasing and some formating.

Fri, May 13, 7:58 AM · Restricted Project, Restricted Project
abidmalikwaterloo added inline comments to D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.
Fri, May 13, 7:57 AM · Restricted Project, Restricted Project
abidmalikwaterloo updated the diff for D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

Rebase the patch and clean some formatting as needed

Fri, May 13, 7:21 AM · Restricted Project, Restricted Project, Restricted Project

Thu, May 12

abidmalikwaterloo added a comment to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

Do we have any comments on this? I can submit the "assembly format" later. Need the operation definition for the next step : lowering to LLVM IR

Thu, May 12, 12:01 PM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo updated the diff for D105584: [MLIR][OpenMP] Distribute Construct Operation.

Added the assembly format, dist_schedule parser support

Thu, May 12, 8:32 AM · Restricted Project, Restricted Project, Restricted Project

Tue, May 3

abidmalikwaterloo added a comment to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

I have updated the summary.

Tue, May 3, 12:11 PM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added a comment to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

Looks okay to me, please wait for Kiran/Valentin's comments. Also, will you be adding an assembly format/verifier for this later?

Yes

The summary says the map clause is not supported but there are map operands in the patch. Can we get these two in sync - we should either update the summary or remove map-related operands.

Also, please rebase before further reviews.

Will do

Tue, May 3, 12:09 PM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo updated the summary of D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..
Tue, May 3, 12:09 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Apr 28

abidmalikwaterloo added a comment to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

Looks okay to me, please wait for Kiran/Valentin's comments. Also, will you be adding an assembly format/verifier for this later?

Yes

The summary says the map clause is not supported but there are map operands in the patch. Can we get these two in sync - we should either update the summary or remove map-related operands.

Also, please rebase before further reviews.

Will do

Do you or did you work on the rest of the lowering to OpenMPIRBuilder/LLVM IR? Might be good to have the broader pictures sometime before designing the operation.

Thu, Apr 28, 2:23 AM · Restricted Project, Restricted Project, Restricted Project

Apr 26 2022

abidmalikwaterloo edited reviewers for D105584: [MLIR][OpenMP] Distribute Construct Operation, added: shraiysh; removed: sameeranjoshi.
Apr 26 2022, 7:58 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added a comment to D105584: [MLIR][OpenMP] Distribute Construct Operation.

Based on the feedback from other patches. This also needs an assembly format!

Apr 26 2022, 7:57 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added a comment to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

Looks okay to me, please wait for Kiran/Valentin's comments. Also, will you be adding an assembly format/verifier for this later?

Yes

The summary says the map clause is not supported but there are map operands in the patch. Can we get these two in sync - we should either update the summary or remove map-related operands.

Also, please rebase before further reviews.

Will do

Apr 26 2022, 6:49 AM · Restricted Project, Restricted Project, Restricted Project

Apr 25 2022

abidmalikwaterloo added a comment to D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.

This has been taken care of. I think need to abandon this patch?

Apr 25 2022, 1:39 PM · Restricted Project, Restricted Project
abidmalikwaterloo added a comment to D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.

This has been taken care of. I think need to abandon this patch?

Apr 25 2022, 1:39 PM · Restricted Project, Restricted Project
abidmalikwaterloo added a comment to D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.

Unfortunately, there have been several developments since we last looked at this patch. This includes using assembly format for the printer/parser instead of the custom printTargetOp/parseTargetOp. See the following for reference.
https://github.com/llvm/llvm-project/blob/6f73bd781305266a747055875ce8352e5a36c809/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td#L115

Apr 25 2022, 11:42 AM · Restricted Project, Restricted Project
abidmalikwaterloo added a reviewer for D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.: shraiysh.
Apr 25 2022, 10:19 AM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct: Restricted Project.

Are there any other issues with the patch? I will clean it and submit it?

Apr 25 2022, 9:40 AM · Restricted Project, Restricted Project

Apr 19 2022

abidmalikwaterloo requested review of D124040: Basic Support for otherwise clause.
Apr 19 2022, 1:44 PM · Restricted Project, Restricted Project, Restricted Project

Apr 17 2022

abidmalikwaterloo updated the diff for D122255: Meta directive runtime support.

Cleaned the code and added tests.

Apr 17 2022, 12:54 PM · Restricted Project, Restricted Project, Restricted Project

Apr 14 2022

abidmalikwaterloo added a comment to D122255: Meta directive runtime support.

The last update removed all previous updates. Can you point me to the correct way to do it?
I did the following :
arc patch D122255
"did something/cleaning"
git commit -a --amend
arc diff

Apr 14 2022, 2:57 AM · Restricted Project, Restricted Project, Restricted Project

Apr 13 2022

abidmalikwaterloo updated the diff for D122255: Meta directive runtime support.

Added tests

Apr 13 2022, 7:24 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo updated the diff for D122255: Meta directive runtime support.

I update it but it created a new patch D123598.
I marked it Abandon. Not sure how to delete it.
I am submitting it again after cleaning the codes
and adding some basic tests.

Apr 13 2022, 6:58 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo abandoned D123598: Clean the code, formated and add basic tests for the patch..
Apr 13 2022, 6:54 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo updated the diff for D123598: Clean the code, formated and add basic tests for the patch..

I submitted update but it created a new patch D123598.
I marked it abandon and submitting it again.

Apr 13 2022, 6:53 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo abandoned D123598: Clean the code, formated and add basic tests for the patch..
Apr 13 2022, 3:39 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added a comment to D122255: Meta directive runtime support.

There should be an update to D122255. It should not create the new one.D123598
--->
I did the following :
arc patch D122255
"did something/cleaning"
git commit -a
arc diff
---->

Apr 13 2022, 2:41 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added a comment to D123598: Clean the code, formated and add basic tests for the patch..

It. should update D122255. It should not create the new one.
--->
I used the following
arc patch D122255
"did something"
git commit -a
arc diff
---->

Apr 13 2022, 2:38 AM · Restricted Project, Restricted Project, Restricted Project

Apr 12 2022

abidmalikwaterloo accepted D123575: [mlir][OpenMP] Added omp.task.

LGTM

Apr 12 2022, 5:49 AM · Restricted Project, Restricted Project
abidmalikwaterloo requested review of D123598: Clean the code, formated and add basic tests for the patch..
Apr 12 2022, 5:41 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added inline comments to D123575: [mlir][OpenMP] Added omp.task.
Apr 12 2022, 2:49 AM · Restricted Project, Restricted Project
abidmalikwaterloo added inline comments to D123575: [mlir][OpenMP] Added omp.task.
Apr 12 2022, 2:20 AM · Restricted Project, Restricted Project

Mar 29 2022

abidmalikwaterloo added a comment to D120573: [OpenMP] Support runtime user conditions in metadirective.

Are you going to work on it? Just confirming. I am working on D122255. The code generation part for the dynamic condition is useful. However, my understanding is that it is not according to the OpenMP 5.2 specification. Correct me if I am wrong.

Mar 29 2022, 5:38 PM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added a comment to D122255: Meta directive runtime support.

would it make sense to submit separate patches for when (OMPC_when) and otherwise (OMPC_otherwise) clauses? The D120573 also has OMPC_when support.

Mar 29 2022, 12:18 PM · Restricted Project, Restricted Project, Restricted Project

Mar 23 2022

abidmalikwaterloo added inline comments to D120573: [OpenMP] Support runtime user conditions in metadirective.
Mar 23 2022, 8:37 AM · Restricted Project, Restricted Project, Restricted Project

Mar 22 2022

abidmalikwaterloo added inline comments to D120573: [OpenMP] Support runtime user conditions in metadirective.
Mar 22 2022, 3:53 PM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added inline comments to D120573: [OpenMP] Support runtime user conditions in metadirective.
Mar 22 2022, 3:43 PM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added a comment to D122255: Meta directive runtime support.

Is it okay if I can put comments on the patch?

Mar 22 2022, 1:54 PM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added a comment to D120573: [OpenMP] Support runtime user conditions in metadirective.

Does anyone implement/take care of the "otherwise" clause? If I am correct, OpenMP 5.2 supports otherwise instead of the default for meta directive.

Mar 22 2022, 1:49 PM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo updated subscribers of D122255: Meta directive runtime support.

I quickly went through the D120573. There are many overlapping.

Mar 22 2022, 1:45 PM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo requested review of D122255: Meta directive runtime support.
Mar 22 2022, 12:48 PM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.: Restricted Project.

Sorry for the delay. Will work on it

Mar 22 2022, 8:08 AM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D105584: [MLIR][OpenMP] Distribute Construct Operation: Restricted Project.

I have time now I will start looking them and would like finish them ASAP

Mar 22 2022, 8:03 AM · Restricted Project, Restricted Project, Restricted Project

Jan 17 2022

abidmalikwaterloo added a comment to D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.

Will try to finalize this week.

Jan 17 2022, 8:02 AM · Restricted Project, Restricted Project
abidmalikwaterloo added a comment to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

Will try to finalize this week.

Jan 17 2022, 8:02 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added a comment to D105584: [MLIR][OpenMP] Distribute Construct Operation.

I was busy. I will try to finalize this week.

Jan 17 2022, 8:02 AM · Restricted Project, Restricted Project, Restricted Project

Oct 22 2021

abidmalikwaterloo updated the diff for D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

Correct indentation for comments

Oct 22 2021, 12:04 PM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added inline comments to D105584: [MLIR][OpenMP] Distribute Construct Operation.
Oct 22 2021, 6:30 AM · Restricted Project, Restricted Project, Restricted Project

Oct 18 2021

abidmalikwaterloo updated the diff for D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

made changes in the data enter operation

Oct 18 2021, 6:03 PM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added a comment to D105584: [MLIR][OpenMP] Distribute Construct Operation.

change the default collapse value from 0 to 1

Oct 18 2021, 2:28 PM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo updated the diff for D105584: [MLIR][OpenMP] Distribute Construct Operation.

change the collapse defualt value from 0 to 1

Oct 18 2021, 2:27 PM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo updated the diff for D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.

remove the builder as per suggested by the reviewer

Oct 18 2021, 2:09 PM · Restricted Project, Restricted Project
abidmalikwaterloo added inline comments to D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write.
Oct 18 2021, 7:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added inline comments to D105584: [MLIR][OpenMP] Distribute Construct Operation.
Oct 18 2021, 2:20 AM · Restricted Project, Restricted Project, Restricted Project

Oct 14 2021

abidmalikwaterloo added a comment to D105584: [MLIR][OpenMP] Distribute Construct Operation.

ping!

Oct 14 2021, 7:06 AM · Restricted Project, Restricted Project, Restricted Project

Oct 5 2021

abidmalikwaterloo added inline comments to D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.
Oct 5 2021, 10:27 AM · Restricted Project, Restricted Project
abidmalikwaterloo added inline comments to D105584: [MLIR][OpenMP] Distribute Construct Operation.
Oct 5 2021, 7:38 AM · Restricted Project, Restricted Project, Restricted Project

Sep 24 2021

abidmalikwaterloo updated the diff for D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

Remove space as mentioned by the reviewer

Sep 24 2021, 4:16 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added inline comments to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..
Sep 24 2021, 4:11 AM · Restricted Project, Restricted Project, Restricted Project

Sep 20 2021

abidmalikwaterloo updated the diff for D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.

Did the code alignments and corrected the codes as per reviewers' comments.

Sep 20 2021, 10:29 AM · Restricted Project, Restricted Project

Sep 17 2021

abidmalikwaterloo updated the diff for D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

Made changes to alignment
Made AnyType to AnyInteger for map_type_modifier

Sep 17 2021, 8:26 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added inline comments to D105584: [MLIR][OpenMP] Distribute Construct Operation.
Sep 17 2021, 7:39 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo updated the diff for D105584: [MLIR][OpenMP] Distribute Construct Operation.

Made changes based on the reviewers' comments.

Sep 17 2021, 7:36 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo updated the diff for D105581: [MLIR][OpenMP] Teams Construct Operation.

Made changes to the length of comments as per advised by the reviewer.

Sep 17 2021, 6:51 AM · Restricted Project
abidmalikwaterloo abandoned D109964: Change the length of line. Make it within 80..
Sep 17 2021, 6:42 AM · Restricted Project
abidmalikwaterloo requested review of D109964: Change the length of line. Make it within 80..
Sep 17 2021, 6:41 AM · Restricted Project

Sep 15 2021

abidmalikwaterloo added inline comments to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..
Sep 15 2021, 11:09 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo abandoned D109829: Correct alighment for the distribute operation.
Sep 15 2021, 8:02 AM · Restricted Project
abidmalikwaterloo requested review of D109829: Correct alighment for the distribute operation.
Sep 15 2021, 7:46 AM · Restricted Project

Sep 14 2021

abidmalikwaterloo updated the diff for D105584: [MLIR][OpenMP] Distribute Construct Operation.

rebase the patch branch with the main branch

Sep 14 2021, 6:02 PM · Restricted Project, Restricted Project, Restricted Project

Sep 13 2021

abidmalikwaterloo updated the diff for D105581: [MLIR][OpenMP] Teams Construct Operation.

rebase the branch to main to remove the redundent code

Sep 13 2021, 6:50 PM · Restricted Project

Sep 7 2021

abidmalikwaterloo added inline comments to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..
Sep 7 2021, 5:29 AM · Restricted Project, Restricted Project, Restricted Project

Sep 2 2021

abidmalikwaterloo added inline comments to D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.
Sep 2 2021, 1:24 PM · Restricted Project, Restricted Project
abidmalikwaterloo added a comment to D105584: [MLIR][OpenMP] Distribute Construct Operation.

This patch has the same problem as the patch https://reviews.llvm.org/D105581/new/. The branching needs to be done from the main. The parsing part should not be there.

Sep 2 2021, 1:20 PM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added a comment to D105581: [MLIR][OpenMP] Teams Construct Operation.

I think your patch is still mixing with the previous one.

@kiranchandramohan
What is the solution to remove this confusionn? This patch does not need the basic parsing patch for target operation. I feel my branching was not correctly done which created this confusion.

You likely did your patch from a branch other than main so you have remaining of the previous patches work.
Apply your patch on a fresh branch from main and fix the problematic diffs

Sep 2 2021, 1:12 PM · Restricted Project

Sep 1 2021

abidmalikwaterloo added a comment to D105581: [MLIR][OpenMP] Teams Construct Operation.

I think your patch is still mixing with the previous one.

@kiranchandramohan
What is the solution to remove this confusionn? This patch does not need the basic parsing patch for target operation. I feel my branching was not correctly done which created this confusion.

Sep 1 2021, 9:02 AM · Restricted Project

Jul 23 2021

abidmalikwaterloo added inline comments to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..
Jul 23 2021, 8:19 AM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added a reviewer for D105584: [MLIR][OpenMP] Distribute Construct Operation: kiranchandramohan.
Jul 23 2021, 6:11 AM · Restricted Project, Restricted Project, Restricted Project

Jul 22 2021

abidmalikwaterloo updated the diff for D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.

Add spaces which were accidently removed OpenMPDialect.cpp
Change SmallVector<int,3> to SmallVector<int>
Change const int to constexpr int
Made changes as per reviewer's comments

Jul 22 2021, 12:50 PM · Restricted Project, Restricted Project
abidmalikwaterloo added inline comments to D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.
Jul 22 2021, 9:28 AM · Restricted Project, Restricted Project

Jul 21 2021

abidmalikwaterloo added inline comments to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..
Jul 21 2021, 7:40 AM · Restricted Project, Restricted Project, Restricted Project

Jul 20 2021

abidmalikwaterloo added inline comments to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..
Jul 20 2021, 11:14 AM · Restricted Project, Restricted Project, Restricted Project

Jul 18 2021

abidmalikwaterloo updated the diff for D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

Added test example for exit data operation

Jul 18 2021, 6:23 PM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo updated the diff for D105581: [MLIR][OpenMP] Teams Construct Operation.

Resumbitting the patch as the previous one was missing some codes

Jul 18 2021, 2:11 PM · Restricted Project
abidmalikwaterloo added a comment to D105581: [MLIR][OpenMP] Teams Construct Operation.

Here is a simple example of interaction:

func @omp_compute(%x: memref<1024xf32>, %y: memref<1024xf32>,
  %n: index, %a: f32, %N:i32) -> memref<1024xf32> {
  %c0 = constant 0 : index
  %c1 = constant 1 : index
  %c0 = constant 0 : index
  %c1 = constant 1 : index
Jul 18 2021, 7:20 AM · Restricted Project

Jul 15 2021

abidmalikwaterloo added inline comments to D105581: [MLIR][OpenMP] Teams Construct Operation.
Jul 15 2021, 6:21 PM · Restricted Project
abidmalikwaterloo added a comment to D105581: [MLIR][OpenMP] Teams Construct Operation.

Let me submit it again. Most of the stuff is still on my machine but did not appear or seemed removed.

Jul 15 2021, 2:56 PM · Restricted Project
abidmalikwaterloo added inline comments to D105581: [MLIR][OpenMP] Teams Construct Operation.
Jul 15 2021, 1:18 PM · Restricted Project
abidmalikwaterloo updated the diff for D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

Revised for indentation as pinpointed by the reviewer.

Jul 15 2021, 12:55 PM · Restricted Project, Restricted Project, Restricted Project
abidmalikwaterloo added inline comments to D105581: [MLIR][OpenMP] Teams Construct Operation.
Jul 15 2021, 8:25 AM · Restricted Project

Jul 14 2021

abidmalikwaterloo updated the diff for D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

Added map clase support to target data, enter data and exit data
Revised according to the reviewer's comments
Added a test case
Used snake_case format

Jul 14 2021, 8:27 AM · Restricted Project, Restricted Project, Restricted Project

Jul 12 2021

abidmalikwaterloo updated the diff for D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.

Remove std:array<int,3> and replace it with SmallVector<int,3>

Jul 12 2021, 6:08 PM · Restricted Project, Restricted Project
abidmalikwaterloo updated the diff for D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.

Made changes according to the reviewrs' comments and feedback.

Jul 12 2021, 6:06 PM · Restricted Project, Restricted Project
abidmalikwaterloo added inline comments to D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.
Jul 12 2021, 5:22 PM · Restricted Project, Restricted Project
abidmalikwaterloo added inline comments to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..
Jul 12 2021, 1:18 PM · Restricted Project, Restricted Project, Restricted Project