Added -fopenmp-simd check to reduction_compound_op.cpp
Regenerated checks for nvptx_target_parallel_reduction_codegen_tbaa_PR46146.cpp since it uses complex reduction with operator+=.

May 6 2021, 5:26 PM · Restricted Project

mikerice added inline comments to D101941: [OpenMP] Use compound operators for reduction combiner if available..

May 6 2021, 2:13 PM · Restricted Project

May 5 2021

mikerice updated the diff for D101941: [OpenMP] Use compound operators for reduction combiner if available..

Used script for the test. Fixed clang-format issue.

May 5 2021, 3:42 PM · Restricted Project

mikerice added inline comments to D101941: [OpenMP] Use compound operators for reduction combiner if available..

May 5 2021, 2:15 PM · Restricted Project

mikerice requested review of D101941: [OpenMP] Use compound operators for reduction combiner if available..

May 5 2021, 1:44 PM · Restricted Project

May 4 2021

mikerice added inline comments to D99905: [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'.

May 4 2021, 4:02 PM · Restricted Project

mikerice updated the diff for D99905: [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'.

Addressed review comments.

May 4 2021, 4:01 PM · Restricted Project

mikerice added a comment to D99905: [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'.

Ping. @jdoerfert any comments on this? Anyone else?

May 4 2021, 9:56 AM · Restricted Project

May 3 2021

mikerice updated the diff for D99905: [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'.

Rebased

May 3 2021, 12:49 PM · Restricted Project

Apr 9 2021

mikerice updated the diff for D99905: [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'.

Addressed review comments, fixed switch warning.

Apr 9 2021, 9:23 AM · Restricted Project

mikerice added inline comments to D99905: [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'.

Apr 9 2021, 8:36 AM · Restricted Project

mikerice updated the diff for D99905: [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'.

Remove unused variable.

Apr 9 2021, 8:35 AM · Restricted Project

Apr 8 2021

mikerice added a comment to D99905: [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'.

Thanks for taking a look at this.

Apr 8 2021, 2:10 PM · Restricted Project

mikerice updated the diff for D99905: [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'.

Addressed review comments.

Apr 8 2021, 2:10 PM · Restricted Project

Apr 5 2021

mikerice requested review of D99905: [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'.

Apr 5 2021, 4:09 PM · Restricted Project

Apr 2 2021

mikerice committed rG2165c0d389c0: [OPENMP][DOCS]Update status of the supported constructs, NFC. (authored by mikerice).

[OPENMP][DOCS]Update status of the supported constructs, NFC.

Apr 2 2021, 12:35 PM

mikerice added a comment to D99537: [OPENMP51]Initial support for the dispatch directive.

@jyu2 is currently working on the novariants and nocontext clauses. We are still working on the overall construct so I'm not sure yet what more we will have to contribute.

Apr 2 2021, 9:27 AM · Restricted Project, Restricted Project

Mar 30 2021

mikerice committed rGb7899ba0e8b7: [OPENMP51]Initial support for the dispatch directive. (authored by mikerice).

[OPENMP51]Initial support for the dispatch directive.

Mar 30 2021, 2:22 PM

mikerice closed D99537: [OPENMP51]Initial support for the dispatch directive.

Mar 30 2021, 2:22 PM · Restricted Project, Restricted Project

mikerice updated the diff for D99537: [OPENMP51]Initial support for the dispatch directive.

Addressed review comment.

Mar 30 2021, 12:56 PM · Restricted Project, Restricted Project

mikerice updated the diff for D99537: [OPENMP51]Initial support for the dispatch directive.

Addressed review comments.

Mar 30 2021, 12:07 PM · Restricted Project, Restricted Project

mikerice added inline comments to D99537: [OPENMP51]Initial support for the dispatch directive.

Mar 30 2021, 11:56 AM · Restricted Project, Restricted Project

mikerice added inline comments to D99537: [OPENMP51]Initial support for the dispatch directive.

Mar 30 2021, 8:30 AM · Restricted Project, Restricted Project

Mar 29 2021

mikerice added a comment to D99537: [OPENMP51]Initial support for the dispatch directive.

Thanks for the review.

Mar 29 2021, 5:47 PM · Restricted Project, Restricted Project

mikerice requested review of D99537: [OPENMP51]Initial support for the dispatch directive.

Mar 29 2021, 1:29 PM · Restricted Project, Restricted Project

Mar 18 2021

mikerice committed rGc2f8e158f57c: [OPENMP51]Support for the 'destroy' clause with interop variable. (authored by mikerice).

[OPENMP51]Support for the 'destroy' clause with interop variable.

Mar 18 2021, 9:17 AM

mikerice closed D98834: [OPENMP51]Support for the 'destroy' clause with interop variable.

Mar 18 2021, 9:16 AM · Restricted Project, Restricted Project

Mar 17 2021

mikerice requested review of D98834: [OPENMP51]Support for the 'destroy' clause with interop variable.

Mar 17 2021, 6:22 PM · Restricted Project, Restricted Project

mikerice committed rGc615927c8e38: [OPENMP51]Initial support for the use clause. (authored by mikerice).

[OPENMP51]Initial support for the use clause.

Mar 17 2021, 4:10 PM

mikerice closed D98815: [OPENMP51]Initial support for the use clause.

Mar 17 2021, 4:09 PM · Restricted Project, Restricted Project

mikerice requested review of D98815: [OPENMP51]Initial support for the use clause.

Mar 17 2021, 1:52 PM · Restricted Project, Restricted Project

mikerice committed rG410f09af09b9: [OPENMP51]Initial support for the interop directive. (authored by mikerice).

[OPENMP51]Initial support for the interop directive.

Mar 17 2021, 9:43 AM

mikerice closed D98558: [OPENMP51]Initial support for the interop directive.

Mar 17 2021, 9:42 AM · Restricted Project, Restricted Project

Mar 16 2021

mikerice added inline comments to D98558: [OPENMP51]Initial support for the interop directive.

Mar 16 2021, 7:45 PM · Restricted Project, Restricted Project

mikerice updated the diff for D98558: [OPENMP51]Initial support for the interop directive.

Addressed review comments.

Mar 16 2021, 2:28 PM · Restricted Project, Restricted Project

mikerice added inline comments to D98558: [OPENMP51]Initial support for the interop directive.

Mar 16 2021, 2:27 PM · Restricted Project, Restricted Project

mikerice updated the diff for D98558: [OPENMP51]Initial support for the interop directive.

Addressed review comments. Added line to flang to fix build error.

Mar 16 2021, 1:32 PM · Restricted Project, Restricted Project

Mar 15 2021

mikerice added a comment to D98558: [OPENMP51]Initial support for the interop directive.

It looks like adding the new clause breaks the flang build. Anyone know how to address that?

Mar 15 2021, 5:56 PM · Restricted Project, Restricted Project

mikerice updated the diff for D98558: [OPENMP51]Initial support for the interop directive.

Fixed clang-format.

Mar 15 2021, 5:53 PM · Restricted Project, Restricted Project

mikerice updated the diff for D98558: [OPENMP51]Initial support for the interop directive.

Split original patch. Now includes just the directive plus the 'init' clause.

Mar 15 2021, 1:40 PM · Restricted Project, Restricted Project

mikerice added inline comments to D98558: [OPENMP51]Initial support for the interop directive.

Mar 15 2021, 11:09 AM · Restricted Project, Restricted Project

mikerice updated the diff for D98558: [OPENMP51]Initial support for the interop directive.

Addressed comments, fixed clang-formatting.

Mar 15 2021, 9:37 AM · Restricted Project, Restricted Project

mikerice added a comment to D98558: [OPENMP51]Initial support for the interop directive.

Thanks for the review.

Mar 15 2021, 9:35 AM · Restricted Project, Restricted Project

Mar 12 2021

mikerice requested review of D98558: [OPENMP51]Initial support for the interop directive.

Mar 12 2021, 2:40 PM · Restricted Project, Restricted Project

Feb 2 2021

mikerice committed rGca98c15f2335: [OpenMP] Fix iterations calculation for dependent counters. (authored by mikerice).

[OpenMP] Fix iterations calculation for dependent counters.

Feb 2 2021, 10:11 AM

mikerice closed D95834: [OpenMP] Fix iterations calculation for dependent counters.

Feb 2 2021, 10:11 AM · Restricted Project

Feb 1 2021

mikerice requested review of D95834: [OpenMP] Fix iterations calculation for dependent counters.

Feb 1 2021, 4:29 PM · Restricted Project

Jan 31 2021

mikerice committed rGe94a35a744b7: [OpenMP] Fix comment and assertion strings (NFC). (authored by mikerice).

[OpenMP] Fix comment and assertion strings (NFC).

Jan 31 2021, 5:21 PM

Jan 5 2021

mikerice added inline comments to D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait.

Jan 5 2021, 5:00 PM · Restricted Project, Restricted Project

Dec 1 2020

mikerice added reviewers for D90943: Fix for Bug25668. Clang is asserting when lookup argument is a class that hasn't been instantiated.: lildmh, ABataev.

Dec 1 2020, 9:41 AM

Nov 25 2020

mikerice added a comment to D90943: Fix for Bug25668. Clang is asserting when lookup argument is a class that hasn't been instantiated..

The best I can tell the underlying OpenMP problem is the lookup code in buildUserDefinedMapperRef. In this code if there is no mapper-id (like this test) the name is changed to "default" but the Loc is not set. If we set the location to something (StartLoc is handy here) all is well.

Nov 25 2020, 4:11 PM

Nov 19 2020

mikerice added inline comments to D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`.

Nov 19 2020, 4:45 PM · Restricted Project, Restricted Project

Sep 24 2020

mikerice accepted D88179: [OPENMP]PR47606: Do not update the lastprivate item if it was captured by reference as firstprivate data member..

LGTM. Thanks Alexey.

Sep 24 2020, 8:39 AM · Restricted Project

Jun 4 2020

mikerice added a comment to D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region..

Is it possible to have the same problem with other directives, like 'omp single' or 'omp master'? I haven't seen any test fail for those yet though.

Jun 4 2020, 1:51 PM · Restricted Project, Restricted Project

Apr 7 2020

mikerice accepted D77290: [OpenMP] Specialize OpenMP calls after template instantiation.

This looks like the right change to me.

Apr 7 2020, 11:23 AM · Restricted Project

mikerice added a comment to D77290: [OpenMP] Specialize OpenMP calls after template instantiation.

My reasoning is that the generic TreeTransform does semantic analysis on CallExpr and this seems to be related semantic analysis that would need to be redone when the call changed as well. Say someone codes up a new subclass of TreeTransform that maybe changes one of the arguments. If ActOnOpenMPCall is not called does that create a broken AST?

Apr 7 2020, 9:44 AM · Restricted Project

Apr 6 2020

mikerice added inline comments to D77290: [OpenMP] Specialize OpenMP calls after template instantiation.

Apr 6 2020, 6:01 PM · Restricted Project

mikerice accepted D77252: [OpenMP] Try to find an existing base for `omp begin/end declare variant`.

LGTM. I did run the math_cpp11 tests. I don't have a cuda environment so it was probably of limited value. I didn't see any failures that seemed related to this during the compiles.

Apr 6 2020, 10:18 AM · Restricted Project

mikerice accepted D77414: [OpenMP] Add match_{all,any,none} declare variant selector extensions..

Looks okay to me.

Apr 6 2020, 9:44 AM · Restricted Project

Apr 5 2020

mikerice added inline comments to D77414: [OpenMP] Add match_{all,any,none} declare variant selector extensions..

Apr 5 2020, 5:06 PM · Restricted Project

Apr 4 2020

mikerice added a comment to D77252: [OpenMP] Try to find an existing base for `omp begin/end declare variant`.

I just moved your lookup code and tried to get the same info from the declarator. The function looks like this:

Apr 4 2020, 6:06 PM · Restricted Project

mikerice added inline comments to D77252: [OpenMP] Try to find an existing base for `omp begin/end declare variant`.

Apr 4 2020, 1:49 PM · Restricted Project

mikerice added inline comments to D77290: [OpenMP] Specialize OpenMP calls after template instantiation.

Apr 4 2020, 10:04 AM · Restricted Project

Apr 3 2020

mikerice added inline comments to D77290: [OpenMP] Specialize OpenMP calls after template instantiation.

Apr 3 2020, 1:33 PM · Restricted Project

Jul 17 2019

mikerice committed rG552c2c09d354: [OPENMP]Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field (authored by mikerice).

[OPENMP]Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field

Jul 17 2019, 8:21 AM

mikerice committed rL366336: [OPENMP]Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field.

[OPENMP]Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field

Jul 17 2019, 8:20 AM

mikerice closed D64842: [OPENMP] Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field.

Jul 17 2019, 8:20 AM · Restricted Project

Jul 16 2019

mikerice created D64842: [OPENMP] Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field.

Jul 16 2019, 5:20 PM · Restricted Project

May 8 2019

mikerice added a comment to D61646: Include corecrt.h/vcruntime.h to improve MS compatibility.

For the most part, these headers are going to be included in almost every compilation unit anyway since they will come in through other C/C++ library headers. So this would presumably affect only a small numbers of compilation units that only include stddef.h and none of the others.

May 8 2019, 12:45 PM · Restricted Project

mikerice committed rGa0933bd8ec15: Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS… (authored by mikerice).

Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS…

May 8 2019, 10:14 AM

mikerice committed rC360271: Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS.

Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS

May 8 2019, 10:13 AM

mikerice committed rL360271: Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS.

Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS

May 8 2019, 10:13 AM

mikerice closed D61646: Include corecrt.h/vcruntime.h to improve MS compatibility.

May 8 2019, 10:13 AM · Restricted Project