Page MenuHomePhabricator

mikerice (Mike Rice)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 3 2016, 9:02 AM (347 w, 3 d)

Recent Activity

Feb 14 2023

mikerice accepted D144015: [OpenMP]Fix PR55970: Miscompile of collapse(3) with non-rectangular loop nest..

LGTM. Thanks!

Feb 14 2023, 9:40 AM · Restricted Project, Restricted Project, Restricted Project

Feb 7 2023

mikerice committed rGe716b0204a5a: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct (authored by mdfazlay).
[OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct
Feb 7 2023, 12:10 PM · Restricted Project, Restricted Project
mikerice closed D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct.
Feb 7 2023, 12:10 PM · Restricted Project, Restricted Project
mikerice committed rGd27fb5efc5f2: [Serialization] Add support for (de)serializing #pragma pack (authored by DHowett-MSFT).
[Serialization] Add support for (de)serializing #pragma pack
Feb 7 2023, 11:41 AM · Restricted Project, Restricted Project
mikerice closed D143410: [Serialization] Add support for (de)serializing #pragma pack.
Feb 7 2023, 11:41 AM · Restricted Project, Restricted Project
mikerice accepted D143410: [Serialization] Add support for (de)serializing #pragma pack.

LGTM. Thanks for taking care of this.

Feb 7 2023, 9:34 AM · Restricted Project, Restricted Project

Feb 6 2023

mikerice added a comment to D143410: [Serialization] Add support for (de)serializing #pragma pack.

While this fixes the assertion failure and the immediate issue of whether packing _works_ inside delay-parsed templates in a PCH, it does reveal a follow-on issue that I can't quite trace out.

c++
template <typename T>
void foo() {
#pragma pack(push, 1)
#pragma pack(show)
#pragma pack(pop)
}

results in...

unterminated '#pragma pack (push, ...)' at end of file
Feb 6 2023, 1:50 PM · Restricted Project, Restricted Project
mikerice added inline comments to D143410: [Serialization] Add support for (de)serializing #pragma pack.
Feb 6 2023, 10:48 AM · Restricted Project, Restricted Project
mikerice added a comment to D138453: [clang] Add serialization for loop hint annotation tokens.
Feb 6 2023, 8:33 AM · Restricted Project, Restricted Project

Jan 23 2023

mikerice accepted D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics.

LGTM too.

Jan 23 2023, 9:08 AM · Restricted Project, Restricted Project

Nov 29 2022

mikerice committed rGc52053bd9961: [clang] Fix buildbot failure in delayed-template-with-pragma.cpp (authored by mikerice).
[clang] Fix buildbot failure in delayed-template-with-pragma.cpp
Nov 29 2022, 11:54 AM · Restricted Project, Restricted Project
mikerice committed rG530eb263c0ec: [clang] Add serialization for loop hint annotation tokens (authored by mikerice).
[clang] Add serialization for loop hint annotation tokens
Nov 29 2022, 10:56 AM · Restricted Project, Restricted Project
mikerice closed D138453: [clang] Add serialization for loop hint annotation tokens.
Nov 29 2022, 10:56 AM · Restricted Project, Restricted Project
mikerice added a comment to D138453: [clang] Add serialization for loop hint annotation tokens.

ping, anything else needed for this?

Nov 29 2022, 8:07 AM · Restricted Project, Restricted Project

Nov 22 2022

mikerice added inline comments to D138453: [clang] Add serialization for loop hint annotation tokens.
Nov 22 2022, 1:17 PM · Restricted Project, Restricted Project
mikerice updated the diff for D138453: [clang] Add serialization for loop hint annotation tokens.

Bump the AST version.
Add an entry to the release notes.

Nov 22 2022, 1:17 PM · Restricted Project, Restricted Project

Nov 21 2022

mikerice requested review of D138453: [clang] Add serialization for loop hint annotation tokens.
Nov 21 2022, 12:03 PM · Restricted Project, Restricted Project

Nov 18 2022

mikerice committed rG56c166017055: [OpenMP] Initial parsing/sema for 'strict' modifier with 'num_tasks' clause (authored by mdfazlay).
[OpenMP] Initial parsing/sema for 'strict' modifier with 'num_tasks' clause
Nov 18 2022, 4:27 PM · Restricted Project, Restricted Project, Restricted Project
mikerice closed D138328: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'num_tasks' clause on 'taskloop' construct.
Nov 18 2022, 4:27 PM · Restricted Project, Restricted Project, Restricted Project

Nov 17 2022

mikerice committed rGab9eac762c35: [OpenMP] Initial parsing/sema for 'strict' modifier with 'grainsize' clause (authored by mdfazlay).
[OpenMP] Initial parsing/sema for 'strict' modifier with 'grainsize' clause
Nov 17 2022, 9:00 PM · Restricted Project, Restricted Project, Restricted Project
mikerice closed D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct.
Nov 17 2022, 8:59 PM · Restricted Project, Restricted Project, Restricted Project

Nov 15 2022

mikerice accepted D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC.
Nov 15 2022, 1:22 PM · Restricted Project, Restricted Project
mikerice added a comment to D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC.

I haven't dealt much with the loop hint attributes, but two of my coworkers have done extensive work in our downstream (@jyu2 and @mikerice), and likely have feedback about how this affects downstream feedback.

Nov 15 2022, 8:58 AM · Restricted Project, Restricted Project

Nov 4 2022

mikerice committed rGc954cfeb57a1: Some uses of the preprocessor can result in multiple target regions on the (authored by mikerice).
Some uses of the preprocessor can result in multiple target regions on the
Nov 4 2022, 1:03 PM · Restricted Project, Restricted Project, Restricted Project
mikerice closed D134816: [OpenMP] Account for the possibility of multiple target regions per line.
Nov 4 2022, 1:02 PM · Restricted Project, Restricted Project, Restricted Project
mikerice updated the diff for D134816: [OpenMP] Account for the possibility of multiple target regions per line.

Use underscore as count separator.

Nov 4 2022, 9:04 AM · Restricted Project, Restricted Project, Restricted Project

Nov 3 2022

mikerice updated the diff for D134816: [OpenMP] Account for the possibility of multiple target regions per line.

Rebase and update for new location of the OffloadEntriesInfoManager.

Nov 3 2022, 10:52 AM · Restricted Project, Restricted Project, Restricted Project
mikerice added a comment to D134816: [OpenMP] Account for the possibility of multiple target regions per line.

The cleanup and migration patches are in now. We can proceed with this improvement. @mikerice are you going to work on this, or did you want me to?

Nov 3 2022, 7:55 AM · Restricted Project, Restricted Project, Restricted Project

Oct 28 2022

mikerice added inline comments to D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info.
Oct 28 2022, 11:00 AM · Restricted Project, Restricted Project, Restricted Project
mikerice added a comment to D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info.

When I have a fix, is there a way for me to test my code on the buildbot? I don't seem to be able to reproduce the problem on my machine.

Oct 28 2022, 10:41 AM · Restricted Project, Restricted Project, Restricted Project

Oct 27 2022

mikerice added inline comments to D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info.
Oct 27 2022, 3:53 PM · Restricted Project, Restricted Project, Restricted Project

Oct 24 2022

mikerice added inline comments to D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info.
Oct 24 2022, 12:26 PM · Restricted Project, Restricted Project, Restricted Project

Oct 18 2022

mikerice added a comment to D134816: [OpenMP] Account for the possibility of multiple target regions per line.

> I think it makes sense to do your cleanup first, then migrate to OMPIRbuilder, and do this feature improvement last. That way we have parity first then extend the functionality.

Oct 18 2022, 1:49 PM · Restricted Project, Restricted Project, Restricted Project

Oct 14 2022

mikerice added inline comments to D134816: [OpenMP] Account for the possibility of multiple target regions per line.
Oct 14 2022, 3:19 PM · Restricted Project, Restricted Project, Restricted Project
mikerice added a comment to D134816: [OpenMP] Account for the possibility of multiple target regions per line.

Did you try to call SM.getPresumedLoc(Loc, false); in getTargetEntryUniqueInfo instead?

Oct 14 2022, 11:57 AM · Restricted Project, Restricted Project, Restricted Project
mikerice updated the diff for D134816: [OpenMP] Account for the possibility of multiple target regions per line.

rebase

Oct 14 2022, 10:29 AM · Restricted Project, Restricted Project, Restricted Project

Oct 13 2022

mikerice added inline comments to D71989: [OpenMP][IRBuilder] `omp task` support.
Oct 13 2022, 10:36 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 28 2022

mikerice requested review of D134816: [OpenMP] Account for the possibility of multiple target regions per line.
Sep 28 2022, 10:37 AM · Restricted Project, Restricted Project, Restricted Project

Aug 22 2022

mikerice committed rG129904d5041f: [OpenMP][NFC] Use OMPInteropInfo in the OMPDeclareVariantAttr attribute (authored by mikerice).
[OpenMP][NFC] Use OMPInteropInfo in the OMPDeclareVariantAttr attribute
Aug 22 2022, 10:49 AM · Restricted Project, Restricted Project
mikerice closed D132270: [OpenMP][NFC] Use OMPInteropInfo in the OMPDeclareVariantAttr attribute.
Aug 22 2022, 10:49 AM · Restricted Project, Restricted Project
mikerice updated the diff for D132270: [OpenMP][NFC] Use OMPInteropInfo in the OMPDeclareVariantAttr attribute.

Add a default constructor and use emplace_back in a couple places.

Aug 22 2022, 8:52 AM · Restricted Project, Restricted Project

Aug 19 2022

mikerice requested review of D132270: [OpenMP][NFC] Use OMPInteropInfo in the OMPDeclareVariantAttr attribute.
Aug 19 2022, 5:36 PM · Restricted Project, Restricted Project

Aug 18 2022

mikerice committed rG89167e3c5b00: [OpenMP][NFC] Refactor code for interop parts of 'init' and 'append_args'… (authored by mikerice).
[OpenMP][NFC] Refactor code for interop parts of 'init' and 'append_args'…
Aug 18 2022, 5:14 PM · Restricted Project, Restricted Project
mikerice closed D132171: [OpenMP][NFC] Refactor code for interop parts of 'init' and 'append_args' clauses.
Aug 18 2022, 5:14 PM · Restricted Project, Restricted Project
mikerice requested review of D132171: [OpenMP][NFC] Refactor code for interop parts of 'init' and 'append_args' clauses.
Aug 18 2022, 1:16 PM · Restricted Project, Restricted Project

Aug 11 2022

mikerice committed rGdd4c838da30a: [OpenMP] Allow data members in interop init/use/destroy clauses (authored by mikerice).
[OpenMP] Allow data members in interop init/use/destroy clauses
Aug 11 2022, 9:40 AM · Restricted Project, Restricted Project
mikerice closed D131222: [OpenMP] Allow data members in interop init/use/destroy clauses.
Aug 11 2022, 9:40 AM · Restricted Project, Restricted Project
mikerice added inline comments to D131222: [OpenMP] Allow data members in interop init/use/destroy clauses.
Aug 11 2022, 7:57 AM · Restricted Project, Restricted Project
mikerice updated the diff for D131222: [OpenMP] Allow data members in interop init/use/destroy clauses.

Fix formatting.

Aug 11 2022, 7:56 AM · Restricted Project, Restricted Project

Aug 9 2022

mikerice updated the diff for D131222: [OpenMP] Allow data members in interop init/use/destroy clauses.

Added uses in static member functions to tests.

Aug 9 2022, 8:28 AM · Restricted Project, Restricted Project
mikerice added a comment to D131222: [OpenMP] Allow data members in interop init/use/destroy clauses.

To include static data members in the message and be correct in C or C++ we need three cases:

In C:
expected variable of type 'omp_interop_t'

In a C++ non-member function:
expected variable or static data member of type 'omp_interop_t'

In a C++ member function:
expected variable, static data member, or non-static data member of current class of type 'omp_interop_t'

This seems to exactly describe the situation to me. Maybe I am missing the point.
Feel free to make specific recommendations to help move this along.

You can’t use non-static member functions in static member function.

Aug 9 2022, 8:25 AM · Restricted Project, Restricted Project

Aug 8 2022

mikerice updated the diff for D131222: [OpenMP] Allow data members in interop init/use/destroy clauses.

To include static data members in the message and be correct in C or C++ we need three cases:

Aug 8 2022, 2:37 PM · Restricted Project, Restricted Project

Aug 5 2022

mikerice updated the diff for D131222: [OpenMP] Allow data members in interop init/use/destroy clauses.

Changed message to match old message. Prints 'variable' or 'data member' depending on context.

Aug 5 2022, 12:17 PM · Restricted Project, Restricted Project
mikerice updated the diff for D131222: [OpenMP] Allow data members in interop init/use/destroy clauses.

Added optional type to diagnostic given in getPrivateItem().

Aug 5 2022, 11:29 AM · Restricted Project, Restricted Project
mikerice added inline comments to D131222: [OpenMP] Allow data members in interop init/use/destroy clauses.
Aug 5 2022, 10:12 AM · Restricted Project, Restricted Project
mikerice updated the diff for D131222: [OpenMP] Allow data members in interop init/use/destroy clauses.

Use getPrivateItem() for interop variables.

Aug 5 2022, 10:12 AM · Restricted Project, Restricted Project
mikerice added a comment to D131222: [OpenMP] Allow data members in interop init/use/destroy clauses.

Is it allowed to be a field per OpenMP standard?

Aug 5 2022, 7:38 AM · Restricted Project, Restricted Project

Aug 4 2022

mikerice requested review of D131222: [OpenMP] Allow data members in interop init/use/destroy clauses.
Aug 4 2022, 4:39 PM · Restricted Project, Restricted Project

Jul 1 2022

mikerice committed rG38bcd483dd46: [OpenMP] Initial parsing and semantic support for 'parallel masked taskloop… (authored by mdfazlay).
[OpenMP] Initial parsing and semantic support for 'parallel masked taskloop…
Jul 1 2022, 9:06 AM · Restricted Project, Restricted Project, Restricted Project
mikerice closed D128946: [OpenMP] Initial parsing and semantic support for 'parallel masked taskloop simd' construct.
Jul 1 2022, 9:05 AM · Restricted Project, Restricted Project, Restricted Project

Jun 30 2022

mikerice committed rGd64ba896d376: [OpenMP] Initial parsing and sema support for 'parallel masked taskloop'… (authored by mdfazlay).
[OpenMP] Initial parsing and sema support for 'parallel masked taskloop'…
Jun 30 2022, 11:45 AM · Restricted Project, Restricted Project, Restricted Project
mikerice closed D128834: [OpenMP] Initial parsing and sema support for 'parallel masked taskloop' construct.
Jun 30 2022, 11:44 AM · Restricted Project, Restricted Project, Restricted Project

Jun 28 2022

mikerice committed rG73e5d7bdff51: [OpenMP] Initial parsing and sema support for 'masked taskloop simd' construct (authored by mdfazlay).
[OpenMP] Initial parsing and sema support for 'masked taskloop simd' construct
Jun 28 2022, 3:32 PM · Restricted Project, Restricted Project, Restricted Project
mikerice closed D128693: [OpenMP] Initial parsing and sema support for 'masked taskloop simd' construct.
Jun 28 2022, 3:31 PM · Restricted Project, Restricted Project, Restricted Project

Jun 24 2022

mikerice committed rG42bb88e2aaee: [OpenMP] Initial parsing and sema support for 'masked taskloop' construct (authored by mdfazlay).
[OpenMP] Initial parsing and sema support for 'masked taskloop' construct
Jun 24 2022, 10:01 AM · Restricted Project, Restricted Project, Restricted Project
mikerice closed D128478: [OpenMP] Initial parsing and sema support for 'masked taskloop' construct.
Jun 24 2022, 10:01 AM · Restricted Project, Restricted Project, Restricted Project

Jun 22 2022

mikerice committed rGa35141d39501: [OpenMP] Add handling cases when filter(tid) appears with default(none) (authored by mdfazlay).
[OpenMP] Add handling cases when filter(tid) appears with default(none)
Jun 22 2022, 5:46 PM · Restricted Project, Restricted Project
mikerice closed D128397: Add handling cases when filter(tid) appears with deafult(none).
Jun 22 2022, 5:46 PM · Restricted Project, Restricted Project

Jun 2 2022

mikerice committed rG48d6a6c9add9: [OpenMP][NFC] update status for 'omp_all_memory' directive to 'done' (authored by mikerice).
[OpenMP][NFC] update status for 'omp_all_memory' directive to 'done'
Jun 2 2022, 5:32 PM · Restricted Project, Restricted Project

May 26 2022

mikerice committed rG0a5cfbf7b2e8: [OpenMP] Use the align clause value from 'omp allocate' for globals (authored by mikerice).
[OpenMP] Use the align clause value from 'omp allocate' for globals
May 26 2022, 9:52 AM · Restricted Project, Restricted Project
mikerice closed D126426: [OpenMP] Use the align clause value from 'omp allocate' for globals.
May 26 2022, 9:52 AM · Restricted Project, Restricted Project

May 25 2022

mikerice requested review of D126426: [OpenMP] Use the align clause value from 'omp allocate' for globals.
May 25 2022, 3:30 PM · Restricted Project, Restricted Project
mikerice added a comment to D126331: [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'.

Cool! Can we have that for begin declare variant too :D ?

May 25 2022, 2:37 PM · Restricted Project, Restricted Project
mikerice committed rGba3f85390bde: [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target' (authored by mikerice).
[OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'
May 25 2022, 10:35 AM · Restricted Project, Restricted Project
mikerice closed D126331: [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'.
May 25 2022, 10:34 AM · Restricted Project, Restricted Project

May 24 2022

mikerice committed rG239094cdee8e: [OpenMP] Add codegen for 'omp_all_memory' reserved locator. (authored by mikerice).
[OpenMP] Add codegen for 'omp_all_memory' reserved locator.
May 24 2022, 3:46 PM · Restricted Project, Restricted Project
mikerice closed D126321: [OpenMP] Add codegen for 'omp_all_memory' reserved locator.
May 24 2022, 3:46 PM · Restricted Project, Restricted Project
mikerice requested review of D126331: [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'.
May 24 2022, 2:31 PM · Restricted Project, Restricted Project
mikerice requested review of D126321: [OpenMP] Add codegen for 'omp_all_memory' reserved locator.
May 24 2022, 1:07 PM · Restricted Project, Restricted Project
mikerice committed rG9ba937112fa6: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator (authored by mikerice).
[OpenMP] Add parsing/sema support for omp_all_memory reserved locator
May 24 2022, 10:37 AM · Restricted Project, Restricted Project
mikerice closed D125828: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator.
May 24 2022, 10:37 AM · Restricted Project, Restricted Project
mikerice added inline comments to D125828: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator.
May 24 2022, 8:56 AM · Restricted Project, Restricted Project
mikerice updated the diff for D125828: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator.

Add a function to parse reserved locators.

May 24 2022, 8:55 AM · Restricted Project, Restricted Project

May 23 2022

mikerice added a comment to D125828: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator.

Thanks for the review @ABataev. Any more comments on this update?

May 23 2022, 8:28 AM · Restricted Project, Restricted Project

May 19 2022

mikerice updated the diff for D125828: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator.

Use dependency kind to represent 'omp_all_memory' which fits nicely for codegen.
Add struct to OMPDependClause to reduce parameter passing.
Move OpenMPVarListDataTy so it can be shared between parsing and sema to reduce parameters in calls.

May 19 2022, 9:51 AM · Restricted Project, Restricted Project

May 17 2022

mikerice updated the diff for D125828: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator.

Added the source location of 'omp_all_memory' to the clause.

May 17 2022, 2:44 PM · Restricted Project, Restricted Project
mikerice requested review of D125828: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator.
May 17 2022, 12:16 PM · Restricted Project, Restricted Project

May 13 2022

mikerice committed rG0d67c8a51d61: [OpenMP] Fix declare simd use on in-class member template function (authored by mikerice).
[OpenMP] Fix declare simd use on in-class member template function
May 13 2022, 8:28 AM · Restricted Project, Restricted Project
mikerice closed D125493: [clang][OpenMP] Fix declare simd use on in-class member template function.
May 13 2022, 8:28 AM · Restricted Project, Restricted Project

May 12 2022

mikerice updated the diff for D125493: [clang][OpenMP] Fix declare simd use on in-class member template function.

Return Decl only when a single Decl.
Test that error is still given if multiple Decls.

May 12 2022, 3:56 PM · Restricted Project, Restricted Project
mikerice added inline comments to D125493: [clang][OpenMP] Fix declare simd use on in-class member template function.
May 12 2022, 3:54 PM · Restricted Project, Restricted Project
mikerice requested review of D125493: [clang][OpenMP] Fix declare simd use on in-class member template function.
May 12 2022, 12:10 PM · Restricted Project, Restricted Project

May 11 2022

mikerice committed rG772b0c44a429: [OpenMP] Fix mangling for linear parameters with negative stride (authored by mikerice).
[OpenMP] Fix mangling for linear parameters with negative stride
May 11 2022, 2:03 PM · Restricted Project, Restricted Project
mikerice closed D125406: [OpenMP] Fix mangling for linear parameters with negative stride.
May 11 2022, 2:03 PM · Restricted Project, Restricted Project
mikerice requested review of D125406: [OpenMP] Fix mangling for linear parameters with negative stride.
May 11 2022, 11:36 AM · Restricted Project, Restricted Project

May 10 2022

mikerice committed rG0dbaef61b56f: [OpenMP] Fix mangling for linear modifiers with variable stride (authored by mikerice).
[OpenMP] Fix mangling for linear modifiers with variable stride
May 10 2022, 2:13 PM · Restricted Project, Restricted Project
mikerice closed D125330: [OpenMP] Fix mangling for linear modifiers with variable stride.
May 10 2022, 2:13 PM · Restricted Project, Restricted Project
mikerice requested review of D125330: [OpenMP] Fix mangling for linear modifiers with variable stride.
May 10 2022, 11:36 AM · Restricted Project, Restricted Project
mikerice committed rG1a02519bc504: [OpenMP] Add mangling support for linear modifiers (ref,uval,val) (authored by mikerice).
[OpenMP] Add mangling support for linear modifiers (ref,uval,val)
May 10 2022, 9:57 AM · Restricted Project, Restricted Project
mikerice closed D125269: [OpenMP] Add mangling support for linear modifiers (ref, uval, val).
May 10 2022, 9:57 AM · Restricted Project, Restricted Project