Page MenuHomePhabricator

mikerice (Mike Rice)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 3 2016, 9:02 AM (307 w, 6 d)

Recent Activity

Today

mikerice committed rG73e5d7bdff51: [OpenMP] Initial parsing and sema support for 'masked taskloop simd' construct (authored by mdfazlay).
[OpenMP] Initial parsing and sema support for 'masked taskloop simd' construct
Tue, Jun 28, 3:32 PM · Restricted Project, Restricted Project, Restricted Project
mikerice closed D128693: [OpenMP] Initial parsing and sema support for 'masked taskloop simd' construct.
Tue, Jun 28, 3:31 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 24

mikerice committed rG42bb88e2aaee: [OpenMP] Initial parsing and sema support for 'masked taskloop' construct (authored by mdfazlay).
[OpenMP] Initial parsing and sema support for 'masked taskloop' construct
Fri, Jun 24, 10:01 AM · Restricted Project, Restricted Project, Restricted Project
mikerice closed D128478: [OpenMP] Initial parsing and sema support for 'masked taskloop' construct.
Fri, Jun 24, 10:01 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 22

mikerice committed rGa35141d39501: [OpenMP] Add handling cases when filter(tid) appears with default(none) (authored by mdfazlay).
[OpenMP] Add handling cases when filter(tid) appears with default(none)
Wed, Jun 22, 5:46 PM · Restricted Project, Restricted Project
mikerice closed D128397: Add handling cases when filter(tid) appears with deafult(none).
Wed, Jun 22, 5:46 PM · Restricted Project, Restricted Project

Thu, Jun 2

mikerice committed rG48d6a6c9add9: [OpenMP][NFC] update status for 'omp_all_memory' directive to 'done' (authored by mikerice).
[OpenMP][NFC] update status for 'omp_all_memory' directive to 'done'
Thu, Jun 2, 5:32 PM · Restricted Project, Restricted Project

May 26 2022

mikerice committed rG0a5cfbf7b2e8: [OpenMP] Use the align clause value from 'omp allocate' for globals (authored by mikerice).
[OpenMP] Use the align clause value from 'omp allocate' for globals
May 26 2022, 9:52 AM · Restricted Project, Restricted Project
mikerice closed D126426: [OpenMP] Use the align clause value from 'omp allocate' for globals.
May 26 2022, 9:52 AM · Restricted Project, Restricted Project

May 25 2022

mikerice requested review of D126426: [OpenMP] Use the align clause value from 'omp allocate' for globals.
May 25 2022, 3:30 PM · Restricted Project, Restricted Project
mikerice added a comment to D126331: [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'.

Cool! Can we have that for begin declare variant too :D ?

May 25 2022, 2:37 PM · Restricted Project, Restricted Project
mikerice committed rGba3f85390bde: [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target' (authored by mikerice).
[OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'
May 25 2022, 10:35 AM · Restricted Project, Restricted Project
mikerice closed D126331: [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'.
May 25 2022, 10:34 AM · Restricted Project, Restricted Project

May 24 2022

mikerice committed rG239094cdee8e: [OpenMP] Add codegen for 'omp_all_memory' reserved locator. (authored by mikerice).
[OpenMP] Add codegen for 'omp_all_memory' reserved locator.
May 24 2022, 3:46 PM · Restricted Project, Restricted Project
mikerice closed D126321: [OpenMP] Add codegen for 'omp_all_memory' reserved locator.
May 24 2022, 3:46 PM · Restricted Project, Restricted Project
mikerice requested review of D126331: [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'.
May 24 2022, 2:31 PM · Restricted Project, Restricted Project
mikerice requested review of D126321: [OpenMP] Add codegen for 'omp_all_memory' reserved locator.
May 24 2022, 1:07 PM · Restricted Project, Restricted Project
mikerice committed rG9ba937112fa6: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator (authored by mikerice).
[OpenMP] Add parsing/sema support for omp_all_memory reserved locator
May 24 2022, 10:37 AM · Restricted Project, Restricted Project
mikerice closed D125828: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator.
May 24 2022, 10:37 AM · Restricted Project, Restricted Project
mikerice added inline comments to D125828: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator.
May 24 2022, 8:56 AM · Restricted Project, Restricted Project
mikerice updated the diff for D125828: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator.

Add a function to parse reserved locators.

May 24 2022, 8:55 AM · Restricted Project, Restricted Project

May 23 2022

mikerice added a comment to D125828: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator.

Thanks for the review @ABataev. Any more comments on this update?

May 23 2022, 8:28 AM · Restricted Project, Restricted Project

May 19 2022

mikerice updated the diff for D125828: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator.

Use dependency kind to represent 'omp_all_memory' which fits nicely for codegen.
Add struct to OMPDependClause to reduce parameter passing.
Move OpenMPVarListDataTy so it can be shared between parsing and sema to reduce parameters in calls.

May 19 2022, 9:51 AM · Restricted Project, Restricted Project

May 17 2022

mikerice updated the diff for D125828: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator.

Added the source location of 'omp_all_memory' to the clause.

May 17 2022, 2:44 PM · Restricted Project, Restricted Project
mikerice requested review of D125828: [OpenMP] Add parsing/sema support for omp_all_memory reserved locator.
May 17 2022, 12:16 PM · Restricted Project, Restricted Project

May 13 2022

mikerice committed rG0d67c8a51d61: [OpenMP] Fix declare simd use on in-class member template function (authored by mikerice).
[OpenMP] Fix declare simd use on in-class member template function
May 13 2022, 8:28 AM · Restricted Project, Restricted Project
mikerice closed D125493: [clang][OpenMP] Fix declare simd use on in-class member template function.
May 13 2022, 8:28 AM · Restricted Project, Restricted Project

May 12 2022

mikerice updated the diff for D125493: [clang][OpenMP] Fix declare simd use on in-class member template function.

Return Decl only when a single Decl.
Test that error is still given if multiple Decls.

May 12 2022, 3:56 PM · Restricted Project, Restricted Project
mikerice added inline comments to D125493: [clang][OpenMP] Fix declare simd use on in-class member template function.
May 12 2022, 3:54 PM · Restricted Project, Restricted Project
mikerice requested review of D125493: [clang][OpenMP] Fix declare simd use on in-class member template function.
May 12 2022, 12:10 PM · Restricted Project, Restricted Project

May 11 2022

mikerice committed rG772b0c44a429: [OpenMP] Fix mangling for linear parameters with negative stride (authored by mikerice).
[OpenMP] Fix mangling for linear parameters with negative stride
May 11 2022, 2:03 PM · Restricted Project, Restricted Project
mikerice closed D125406: [OpenMP] Fix mangling for linear parameters with negative stride.
May 11 2022, 2:03 PM · Restricted Project, Restricted Project
mikerice requested review of D125406: [OpenMP] Fix mangling for linear parameters with negative stride.
May 11 2022, 11:36 AM · Restricted Project, Restricted Project

May 10 2022

mikerice committed rG0dbaef61b56f: [OpenMP] Fix mangling for linear modifiers with variable stride (authored by mikerice).
[OpenMP] Fix mangling for linear modifiers with variable stride
May 10 2022, 2:13 PM · Restricted Project, Restricted Project
mikerice closed D125330: [OpenMP] Fix mangling for linear modifiers with variable stride.
May 10 2022, 2:13 PM · Restricted Project, Restricted Project
mikerice requested review of D125330: [OpenMP] Fix mangling for linear modifiers with variable stride.
May 10 2022, 11:36 AM · Restricted Project, Restricted Project
mikerice committed rG1a02519bc504: [OpenMP] Add mangling support for linear modifiers (ref,uval,val) (authored by mikerice).
[OpenMP] Add mangling support for linear modifiers (ref,uval,val)
May 10 2022, 9:57 AM · Restricted Project, Restricted Project
mikerice closed D125269: [OpenMP] Add mangling support for linear modifiers (ref, uval, val).
May 10 2022, 9:57 AM · Restricted Project, Restricted Project

May 9 2022

mikerice requested review of D125269: [OpenMP] Add mangling support for linear modifiers (ref, uval, val).
May 9 2022, 2:19 PM · Restricted Project, Restricted Project

May 3 2022

mikerice committed rG37471cf2c3fd: [clang][OpenMP] Local variable alignment incorrect with align clause (authored by ddpagan).
[clang][OpenMP] Local variable alignment incorrect with align clause
May 3 2022, 1:21 PM · Restricted Project, Restricted Project
mikerice closed D124676: [clang][OpenMP] Local variable alignment incorrect with align clause.
May 3 2022, 1:20 PM · Restricted Project, Restricted Project

Mar 24 2022

mikerice added a comment to D122247: [OpenMP] Initial parsing/sema for the 'omp parallel loop' construct.
Mar 24 2022, 9:20 AM · Restricted Project, Restricted Project
mikerice committed rGf82ec5532b2f: [OpenMP] Initial parsing/sema for the 'omp target parallel loop' construct (authored by mikerice).
[OpenMP] Initial parsing/sema for the 'omp target parallel loop' construct
Mar 24 2022, 9:19 AM · Restricted Project
mikerice closed D122359: [OpenMP] Initial parsing/sema for the 'omp target parallel loop' construct.
Mar 24 2022, 9:19 AM · Restricted Project, Restricted Project, Restricted Project

Mar 23 2022

mikerice requested review of D122359: [OpenMP] Initial parsing/sema for the 'omp target parallel loop' construct.
Mar 23 2022, 3:58 PM · Restricted Project, Restricted Project, Restricted Project
mikerice closed D122247: [OpenMP] Initial parsing/sema for the 'omp parallel loop' construct.
Mar 23 2022, 12:02 PM · Restricted Project, Restricted Project

Mar 22 2022

mikerice committed rG2cedaee6f738: [OpenMP] Initial parsing/sema for the 'omp parallel loop' construct (authored by mikerice).
[OpenMP] Initial parsing/sema for the 'omp parallel loop' construct
Mar 22 2022, 1:56 PM · Restricted Project
mikerice requested review of D122247: [OpenMP] Initial parsing/sema for the 'omp parallel loop' construct.
Mar 22 2022, 11:35 AM · Restricted Project, Restricted Project

Mar 18 2022

mikerice committed rG6bd8dc91b89d: [OpenMP] Initial parsing/sema for the 'omp target teams loop' construct (authored by mikerice).
[OpenMP] Initial parsing/sema for the 'omp target teams loop' construct
Mar 18 2022, 2:06 PM · Restricted Project
mikerice closed D122028: [OpenMP] Initial parsing/sema for the 'omp target teams loop' construct.
Mar 18 2022, 2:06 PM · Restricted Project, Restricted Project, Restricted Project
mikerice requested review of D122028: [OpenMP] Initial parsing/sema for the 'omp target teams loop' construct.
Mar 18 2022, 12:32 PM · Restricted Project, Restricted Project, Restricted Project

Mar 16 2022

mikerice committed rG79f661edc13d: [OpenMP] Initial parsing/sema for the 'omp teams loop' construct (authored by mikerice).
[OpenMP] Initial parsing/sema for the 'omp teams loop' construct
Mar 16 2022, 2:51 PM · Restricted Project
mikerice closed D121713: [OpenMP] Initial parsing/sema for the 'omp teams loop' construct.
Mar 16 2022, 2:51 PM · Restricted Project, Restricted Project, Restricted Project
mikerice updated the diff for D121713: [OpenMP] Initial parsing/sema for the 'omp teams loop' construct.

Address review comments.

Mar 16 2022, 1:36 PM · Restricted Project, Restricted Project, Restricted Project

Mar 15 2022

mikerice added inline comments to D121713: [OpenMP] Initial parsing/sema for the 'omp teams loop' construct.
Mar 15 2022, 3:53 PM · Restricted Project, Restricted Project, Restricted Project
mikerice requested review of D121713: [OpenMP] Initial parsing/sema for the 'omp teams loop' construct.
Mar 15 2022, 9:25 AM · Restricted Project, Restricted Project, Restricted Project

Feb 17 2022

mikerice added a comment to D119979: [OpenMP] Diagnose bad 'omp declare variant' that references itself.

What's the use case? I wasn't aware of any. We saw it from someone who did it accidently and caused the compiler to crash in codegen.

Feb 17 2022, 10:57 AM · Restricted Project
mikerice committed rG383f3a467c92: [OpenMP] Diagnose bad 'omp declare variant' that references itself. (authored by mikerice).
[OpenMP] Diagnose bad 'omp declare variant' that references itself.
Feb 17 2022, 10:37 AM
mikerice closed D119979: [OpenMP] Diagnose bad 'omp declare variant' that references itself.
Feb 17 2022, 10:36 AM · Restricted Project

Feb 16 2022

mikerice requested review of D119979: [OpenMP] Diagnose bad 'omp declare variant' that references itself.
Feb 16 2022, 2:33 PM · Restricted Project

Feb 14 2022

mikerice committed rG83a407d176f8: [OpenMP]Fix parsing of OpenMP directive nested in a metadirective (authored by mikerice).
[OpenMP]Fix parsing of OpenMP directive nested in a metadirective
Feb 14 2022, 4:33 PM
mikerice closed D119761: [OpenMP]Fix parsing of OpenMP directive nested in a metadirective.
Feb 14 2022, 4:33 PM · Restricted Project
mikerice updated the diff for D119761: [OpenMP]Fix parsing of OpenMP directive nested in a metadirective.

Use a parameter for ReadDirectiveWithinMetadirective.

Feb 14 2022, 1:37 PM · Restricted Project
mikerice requested review of D119761: [OpenMP]Fix parsing of OpenMP directive nested in a metadirective.
Feb 14 2022, 11:58 AM · Restricted Project

Jan 14 2022

mikerice committed rG3d5b9fb3e3cd: [OpenMP] Fix problems with the declare variant append_args clause (authored by mikerice).
[OpenMP] Fix problems with the declare variant append_args clause
Jan 14 2022, 11:15 AM
mikerice closed D117172: [OpenMP] Fix problems with the declare variant append_args clause.
Jan 14 2022, 11:15 AM · Restricted Project
mikerice updated the diff for D117172: [OpenMP] Fix problems with the declare variant append_args clause.

Added whitespace to the test.

Jan 14 2022, 9:21 AM · Restricted Project
mikerice updated the diff for D117172: [OpenMP] Fix problems with the declare variant append_args clause.

Addressed review comments.

Jan 14 2022, 8:54 AM · Restricted Project
mikerice added inline comments to D117172: [OpenMP] Fix problems with the declare variant append_args clause.
Jan 14 2022, 8:52 AM · Restricted Project

Jan 13 2022

mikerice added inline comments to D117172: [OpenMP] Fix problems with the declare variant append_args clause.
Jan 13 2022, 4:41 PM · Restricted Project
mikerice added inline comments to D117172: [OpenMP] Fix problems with the declare variant append_args clause.
Jan 13 2022, 3:26 PM · Restricted Project
mikerice added inline comments to D117172: [OpenMP] Fix problems with the declare variant append_args clause.
Jan 13 2022, 2:22 PM · Restricted Project
mikerice added inline comments to D117172: [OpenMP] Fix problems with the declare variant append_args clause.
Jan 13 2022, 10:28 AM · Restricted Project

Jan 12 2022

mikerice added inline comments to D117172: [OpenMP] Fix problems with the declare variant append_args clause.
Jan 12 2022, 4:34 PM · Restricted Project
mikerice requested review of D117172: [OpenMP] Fix problems with the declare variant append_args clause.
Jan 12 2022, 4:05 PM · Restricted Project

Jan 7 2022

mikerice abandoned D116823: Remove function bitcast constants that are not linked in the IR.

Thanks for looking at this. We've found another case that event this patch doesn't handle so we'll try to deal with this some other way.

Jan 7 2022, 7:12 PM
mikerice requested review of D116823: Remove function bitcast constants that are not linked in the IR.
Jan 7 2022, 10:21 AM

Dec 17 2021

mikerice accepted D115902: [OPENMP]Look through member function call base during implicit DSA analysis..

LGTM.

Dec 17 2021, 9:38 AM · Restricted Project

Dec 16 2021

mikerice committed rG2d0bf1439727: [clang] Cleanup unneeded Function nullptr checks [NFC] (authored by mikerice).
[clang] Cleanup unneeded Function nullptr checks [NFC]
Dec 16 2021, 8:29 AM
mikerice closed D115817: [clang] Cleanup unneeded Function nullptr checks [NFC].
Dec 16 2021, 8:28 AM · Restricted Project

Dec 15 2021

mikerice added inline comments to D115817: [clang] Cleanup unneeded Function nullptr checks [NFC].
Dec 15 2021, 1:51 PM · Restricted Project
mikerice requested review of D115817: [clang] Cleanup unneeded Function nullptr checks [NFC].
Dec 15 2021, 11:50 AM · Restricted Project

Dec 13 2021

mikerice added a comment to D115561: [Clang][OpenMP] Add the support for atomic compare in parser.

Note you'll want to add a line to flang/lib/Semantics/check-omp-structure.cpp for the new clause or the flang build will fail.

Dec 13 2021, 1:16 PM · Restricted Project, Restricted Project, Restricted Project

Dec 2 2021

mikerice accepted D114546: [OPENMP]Fix PR52117: Crash caused by target region inside of task construct..

Looks okay to me.

Dec 2 2021, 3:57 PM · Restricted Project
mikerice accepted D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct..

LGTM

Dec 2 2021, 12:55 PM · Restricted Project
mikerice accepted D114560: [OPENMP]Fix PR51327: Range based for loop not working if range's type is a template..

LG

Dec 2 2021, 11:25 AM · Restricted Project
mikerice accepted D114653: [OPENMP]Fix error emission for dependent expressions in iterators for depend clauses..

LGTM.

Dec 2 2021, 11:04 AM · Restricted Project

Nov 17 2021

mikerice committed rG69f35f896912: [OpenMP] Add version macro support for 5.1 and 5.2 (authored by mikerice).
[OpenMP] Add version macro support for 5.1 and 5.2
Nov 17 2021, 10:51 AM
mikerice closed D114102: [OpenMP] Add version macro support for 5.1 and 5.2.
Nov 17 2021, 10:51 AM · Restricted Project
mikerice requested review of D114102: [OpenMP] Add version macro support for 5.1 and 5.2.
Nov 17 2021, 9:33 AM · Restricted Project

Nov 4 2021

mikerice committed rG4eac7bcf1af1: [OpenMP] Add parsing/sema/serialization for 'bind' clause. (authored by mikerice).
[OpenMP] Add parsing/sema/serialization for 'bind' clause.
Nov 4 2021, 2:41 PM
mikerice closed D113154: [OpenMP] Add parsing/sema/serialization for 'bind' clause.
Nov 4 2021, 2:41 PM · Restricted Project, Restricted Project, Restricted Project
mikerice updated the diff for D113154: [OpenMP] Add parsing/sema/serialization for 'bind' clause.

Added version to clause.

Nov 4 2021, 1:58 PM · Restricted Project, Restricted Project, Restricted Project
mikerice added inline comments to D113154: [OpenMP] Add parsing/sema/serialization for 'bind' clause.
Nov 4 2021, 1:56 PM · Restricted Project, Restricted Project, Restricted Project
mikerice updated the diff for D113154: [OpenMP] Add parsing/sema/serialization for 'bind' clause.

Allow 'loop' without bind clause.
Use readEnum/writeEnum in serialization.

Nov 4 2021, 10:22 AM · Restricted Project, Restricted Project, Restricted Project
mikerice added inline comments to D113154: [OpenMP] Add parsing/sema/serialization for 'bind' clause.
Nov 4 2021, 8:35 AM · Restricted Project, Restricted Project, Restricted Project

Nov 3 2021

mikerice requested review of D113154: [OpenMP] Add parsing/sema/serialization for 'bind' clause.
Nov 3 2021, 5:32 PM · Restricted Project, Restricted Project, Restricted Project

Oct 29 2021

mikerice committed rG72c373644fc3: [OpenMP] Add triple to run lines to avoid message differences (authored by mikerice).
[OpenMP] Add triple to run lines to avoid message differences
Oct 29 2021, 9:21 AM

Oct 28 2021

mikerice committed rG6f9c25167d16: [OpenMP] Initial parsing/sema for the 'omp loop' construct (authored by mikerice).
[OpenMP] Initial parsing/sema for the 'omp loop' construct
Oct 28 2021, 8:27 AM
mikerice closed D112499: [OpenMP] Initial parsing/sema for the 'omp loop' construct.
Oct 28 2021, 8:27 AM · Restricted Project, Restricted Project