Page MenuHomePhabricator

mikerice (Mike Rice)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 3 2016, 9:02 AM (163 w, 4 h)

Recent Activity

Jul 17 2019

mikerice committed rG552c2c09d354: [OPENMP]Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field (authored by mikerice).
[OPENMP]Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field
Jul 17 2019, 8:21 AM
mikerice committed rL366336: [OPENMP]Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field.
[OPENMP]Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field
Jul 17 2019, 8:20 AM
mikerice closed D64842: [OPENMP] Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field.
Jul 17 2019, 8:20 AM · Restricted Project

Jul 16 2019

mikerice created D64842: [OPENMP] Fix crash in LoopCounterRefChecker when MemberExpr is not Var or Field.
Jul 16 2019, 5:20 PM · Restricted Project

May 8 2019

mikerice added a comment to D61646: Include corecrt.h/vcruntime.h to improve MS compatibility.

For the most part, these headers are going to be included in almost every compilation unit anyway since they will come in through other C/C++ library headers. So this would presumably affect only a small numbers of compilation units that only include stddef.h and none of the others.

May 8 2019, 12:45 PM · Restricted Project
mikerice committed rGa0933bd8ec15: Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS… (authored by mikerice).
Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS…
May 8 2019, 10:14 AM
mikerice committed rC360271: Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS.
Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS
May 8 2019, 10:13 AM
mikerice committed rL360271: Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS.
Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS
May 8 2019, 10:13 AM
mikerice closed D61646: Include corecrt.h/vcruntime.h to improve MS compatibility.
May 8 2019, 10:13 AM · Restricted Project

May 7 2019

mikerice updated the diff for D61646: Include corecrt.h/vcruntime.h to improve MS compatibility.

Added comments as requested.

May 7 2019, 4:14 PM · Restricted Project
mikerice created D61646: Include corecrt.h/vcruntime.h to improve MS compatibility.
May 7 2019, 11:03 AM · Restricted Project

Apr 29 2019

mikerice committed rG5550aa002309: When skipping code at the start of a file during PCH use, Preprocessor::Lex is… (authored by mikerice).
When skipping code at the start of a file during PCH use, Preprocessor::Lex is…
Apr 29 2019, 2:21 PM
mikerice committed rL359506: When skipping code at the start of a file during PCH use, Preprocessor::Lex.
When skipping code at the start of a file during PCH use, Preprocessor::Lex
Apr 29 2019, 2:21 PM
mikerice committed rC359506: When skipping code at the start of a file during PCH use, Preprocessor::Lex.
When skipping code at the start of a file during PCH use, Preprocessor::Lex
Apr 29 2019, 2:21 PM
mikerice closed D61217: Fix PCH skipping to handle all Lexers.
Apr 29 2019, 2:21 PM · Restricted Project

Apr 26 2019

mikerice created D61217: Fix PCH skipping to handle all Lexers.
Apr 26 2019, 5:07 PM · Restricted Project

Sep 20 2018

mikerice committed rC342666: [OPENMP] Fix spelling of getLoopCounter (NFC).
[OPENMP] Fix spelling of getLoopCounter (NFC)
Sep 20 2018, 10:22 AM
mikerice committed rL342666: [OPENMP] Fix spelling of getLoopCounter (NFC).
[OPENMP] Fix spelling of getLoopCounter (NFC)
Sep 20 2018, 10:22 AM

Sep 11 2018

mikerice committed rL341963: [clang-cl, PCH] Support for /Yc and /Yu without filename and #pragma hdrstop.
[clang-cl, PCH] Support for /Yc and /Yu without filename and #pragma hdrstop
Sep 11 2018, 10:13 AM
mikerice committed rC341963: [clang-cl, PCH] Support for /Yc and /Yu without filename and #pragma hdrstop.
[clang-cl, PCH] Support for /Yc and /Yu without filename and #pragma hdrstop
Sep 11 2018, 10:12 AM
mikerice closed D51391: [clang-cl,PCH] Add support for #pragma hdrstop.
Sep 11 2018, 10:12 AM

Sep 10 2018

mikerice updated the diff for D51391: [clang-cl,PCH] Add support for #pragma hdrstop.

Updated to use two options: -pch-through-header-create and -pch-through-header-use.

Sep 10 2018, 10:40 AM

Sep 4 2018

mikerice added inline comments to D51391: [clang-cl,PCH] Add support for #pragma hdrstop.
Sep 4 2018, 4:45 PM
mikerice updated the diff for D51391: [clang-cl,PCH] Add support for #pragma hdrstop.

Thanks for the review. Updated based on comments from Hans.

Sep 4 2018, 4:44 PM

Aug 29 2018

mikerice committed rL340934: [OPENMP] Create non-const ident_t objects..
[OPENMP] Create non-const ident_t objects.
Aug 29 2018, 8:46 AM
mikerice committed rC340934: [OPENMP] Create non-const ident_t objects..
[OPENMP] Create non-const ident_t objects.
Aug 29 2018, 8:46 AM
mikerice closed D51331: [OPENMP] Create non-const ident_t structs..
Aug 29 2018, 8:46 AM
mikerice closed D51331: [OPENMP] Create non-const ident_t structs..
Aug 29 2018, 8:46 AM

Aug 28 2018

mikerice created D51391: [clang-cl,PCH] Add support for #pragma hdrstop.
Aug 28 2018, 4:56 PM

Aug 27 2018

mikerice created D51331: [OPENMP] Create non-const ident_t structs..
Aug 27 2018, 4:52 PM
mikerice added inline comments to D50522: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD env var.
Aug 27 2018, 10:44 AM

Aug 23 2018

mikerice added a comment to D49496: hdrstop proof of concept.

I've made good progress on this. My lit tests are working. I will try it on the tests in our test suites and maybe I will have a patch for review in a few days.

Aug 23 2018, 4:21 PM

Aug 17 2018

mikerice committed rL340082: test commit: add a comment.
test commit: add a comment
Aug 17 2018, 2:17 PM
mikerice committed rC340082: test commit: add a comment.
test commit: add a comment
Aug 17 2018, 2:17 PM

Aug 16 2018

mikerice added a reviewer for D50640: Fix for bug 38508 - Don't do PCH processing when only generating preprocessor output: erichkeane.
Aug 16 2018, 8:18 PM
mikerice added a comment to D50640: Fix for bug 38508 - Don't do PCH processing when only generating preprocessor output.

Thanks! Do you need someone to land this?

Aug 16 2018, 3:37 PM
mikerice added a comment to D50640: Fix for bug 38508 - Don't do PCH processing when only generating preprocessor output.

How does the gcc driver codepath handle this?

Aug 16 2018, 2:49 PM
mikerice updated the diff for D50640: Fix for bug 38508 - Don't do PCH processing when only generating preprocessor output.

Added a -verify test to ensure no warnings on successful PCH use.

Aug 16 2018, 2:49 PM

Aug 13 2018

mikerice added a reviewer for D50640: Fix for bug 38508 - Don't do PCH processing when only generating preprocessor output: thakis.
Aug 13 2018, 9:00 AM
mikerice created D50640: Fix for bug 38508 - Don't do PCH processing when only generating preprocessor output.
Aug 13 2018, 8:59 AM

Jul 24 2018

mikerice added a comment to D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers.

Also, were you planning on also adding support for the (filename-less version of) hdrstop pragma? After this change, that should probably be fairly straightforward.

Jul 24 2018, 3:18 PM

Jul 5 2018

mikerice added inline comments to D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers.
Jul 5 2018, 9:57 AM

Jun 27 2018

mikerice added inline comments to D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers.
Jun 27 2018, 6:21 AM
mikerice updated the diff for D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers.

Thanks for the review. Updated based on comments.

Jun 27 2018, 6:21 AM

Jun 18 2018

mikerice added a comment to D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers.

Ping. This can significantly improve compile time for projects that use the common /Yc<header.h> /Yu<header.h> PCH mechanism.

Jun 18 2018, 8:06 AM

May 23 2018

mikerice added a comment to D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers.

Ping. Still looking for a reviewer, mostly Lex and clang-cl driver changes.

May 23 2018, 2:26 PM

May 18 2018

mikerice added inline comments to D46667: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file.
May 18 2018, 11:24 AM
mikerice updated the diff for D46667: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file.

Sorry for the delay in getting back to this. I've found that we are using many OpenMP directives not just simd. We'd like to continue doing that.

May 18 2018, 10:04 AM

May 16 2018

mikerice added a comment to D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers.
May 16 2018, 3:00 PM

May 13 2018

mikerice updated the diff for D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers.

Added warning when macro is defined when skipping. Also fixed skipping so directives are completely ignored expect for #include and #define.

May 13 2018, 8:17 AM
mikerice added a comment to D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers.

Thanks for taking a look at the patch. I added a warning as suggested. I also fixed skipping so it ignores all directives except #include and now #define.

May 13 2018, 8:14 AM

May 9 2018

mikerice added a comment to D46667: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file.
  1. It probably makes sense to allow omp simd with OpenCL. Some people here have been successfully using it anyway.
  2. I can give that a try.
May 9 2018, 8:46 PM
mikerice created D46667: [OpenCL, OpenMP] Fix crash when OpenMP used in OpenCL file.
May 9 2018, 5:28 PM
mikerice created D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers.
May 9 2018, 11:12 AM

Nov 8 2017

mikerice added inline comments to D38798: [OpenMP] Support for implicit "declare target" functions - Sema patch.
Nov 8 2017, 3:04 PM · Restricted Project

Aug 8 2017

mikerice created D36473: Fix broken getAttributeSpellingListIndex for pragma attributes.
Aug 8 2017, 9:36 AM

Jul 25 2017

mikerice created D35854: Fix double destruction of objects when OpenMP construct is canceled.
Jul 25 2017, 1:54 PM

Sep 15 2016

mikerice updated subscribers of D24615: [OpenMP] clang doesnt diagnose if there is a lexical block around a for stmt for OpenMP loops. It is technically not allowed in the OpenMP standard.
Sep 15 2016, 11:58 AM