Rename vpopc/vmandnot/vmornot to vcpop/vmandn/vmorn assembler mnemonic.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
- Build Status
Buildable 126834 Build 184177: arc lint + arc unit
Event Timeline
LGTM in general. My comments are all about comments. I know the old names are kept as aliases but I still think it's better to reference the "real" instructions where we can.
llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp | ||
---|---|---|
2468 | Comment here | |
2486 | Comment here too | |
llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp | ||
896 | Comment needs updating | |
llvm/lib/Target/RISCV/RISCVISelLowering.cpp | ||
4167 | Comment needs updating here and below | |
4201 | Stale mnemonic name here | |
llvm/lib/Target/RISCV/RISCVISelLowering.h | ||
266 | Nit: comment needs updating too |
llvm/lib/Target/RISCV/RISCVInstrInfoV.td | ||
---|---|---|
1372 | Probably not worth having a blank line between vmandnot and vmornot | |
llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td | ||
4018 | To be consistent with line 4683 // 16.2. Vector count population in mask vcpop.m | |
llvm/test/MC/RISCV/rvv/aliases.s | ||
82 | line "a2, v4, v0.t" up with the previous line. | |
85 | Same here | |
88 | And here |
llvm/lib/Target/RISCV/RISCVInstrInfoV.td | ||
---|---|---|
1374 | Ugh, spec mandating aliases for the pre-ratified names... this is just going to encourage people who don't know any better to use the old names and you'll never be able to kill it off :( | |
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-mask-logic.ll | ||
4 | Revert (how do you even manage that, the NOTE line is autogenerated...) |
I think this looks good other than the whitespace in fixed-vectors-mask-logic.ll that Jessica commented on.
llvm/lib/Target/RISCV/RISCVInstrInfoV.td | ||
---|---|---|
1372 | This still applies |
clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmand.c | ||
---|---|---|
97–98 | Was this test manually updated? I'm not sure how we could still expect to see test_vmandnot_mm_b8. Please use update_cc_test_checks if you haven't already. |
Updated all tests by script update_cc_test_checks and update_llc_test_checks.
@frasercrmck Yes, I used sed to update tests and I don't know why I had unexpected result...
Thanks for you double check!
Was this test manually updated? I'm not sure how we could still expect to see test_vmandnot_mm_b8. Please use update_cc_test_checks if you haven't already.