This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Update Zba, Zbb, Zbc, and Zbs version from 0.93 to 1.0.
ClosedPublic

Authored by craig.topper on Sep 28 2021, 5:29 PM.

Details

Summary

I've removed the Zbs W instructions that are not part of the frozen spec.

References to B as an extension name have been removed. Tests are updated or split accordingly.

Diff Detail

Event Timeline

craig.topper created this revision.Sep 28 2021, 5:29 PM
craig.topper requested review of this revision.Sep 28 2021, 5:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 28 2021, 5:29 PM
kito-cheng added inline comments.Sep 28 2021, 5:44 PM
llvm/lib/Target/RISCV/RISCVInstrInfoB.td
504 ↗(On Diff #375746)

Those instruction are gone since 0.94 draft, and not add back on 1.0, so I think that should removed once we upgrade to 1.0.

528 ↗(On Diff #375746)

Same here.

Remove Zbs W instructions.

craig.topper edited the summary of this revision. (Show Details)Sep 28 2021, 6:04 PM

We might need to update the version output for ELF attribute too, but I would prefer waiting https://reviews.llvm.org/D105168 instead of bump version in many place every time...

Update attributes as well

We might need to update the version output for ELF attribute too, but I would prefer waiting https://reviews.llvm.org/D105168 instead of bump version in many place every time...

Done. Waiting for D105168 wouldn't prevent needing to update the tests so I went ahead and did it.

asb added a comment.Sep 30 2021, 8:01 AM

Should we rename RISCVInstrInfoB.td? Should we remove b0p93 from march parsing?

I think so.

craig.topper edited the summary of this revision. (Show Details)

Drop experimental-b. Update tests accordingly.
Rename RISCVInstrInfoB.td RISCVInstrInfoZb.td

Remove hasStdExtB from RISCVSubtarget.h

Rebase after removal of Zbproposedc

Would it be better to break this patch down into smaller parts. Maybe removing +experimental-b and the associated test changes first?

Split the removal of B to a separate patch D111338

Herald added a project: Restricted Project. · View Herald TranscriptOct 12 2021, 10:02 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Add back dropped changes to RISCV.td

clang/lib/Driver/ToolChains/Arch/RISCV.cpp
62–64

Need format here?

This revision is now accepted and ready to land.Oct 14 2021, 5:26 AM