Page MenuHomePhabricator

[RISCV] Add support for fixed vector MULHU/MULHS.
ClosedPublic

Authored by craig.topper on Feb 17 2021, 9:33 PM.

Details

Summary

This uses to division by constant optimization to use MULHU/MULHS.

Diff Detail

Event Timeline

craig.topper created this revision.Feb 17 2021, 9:33 PM
craig.topper requested review of this revision.Feb 17 2021, 9:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2021, 9:33 PM
Herald added a subscriber: MaskRay. · View Herald Transcript
arcbbb accepted this revision.Feb 18 2021, 1:09 AM

LGTM

This revision is now accepted and ready to land.Feb 18 2021, 1:09 AM

The test report suggests that something's failing? Does one of these tests depend on D96921?

LLVM ERROR: Cannot select: t51: nxv1i64 = bitcast t69
  t69: nxv2i32,ch = RISCVISD::VLE_VL<(load 16 from constant-pool)> t0, t75, Constant:i32<4>

The test report suggests that something's failing? Does one of these tests depend on D96921?

LLVM ERROR: Cannot select: t51: nxv1i64 = bitcast t69
  t69: nxv2i32,ch = RISCVISD::VLE_VL<(load 16 from constant-pool)> t0, t75, Constant:i32<4>

Yes I forgot to set the parent revision

frasercrmck accepted this revision.Feb 18 2021, 1:38 AM

Yes I forgot to set the parent revision

No worries. LGTM.

This revision was landed with ongoing or failed builds.Feb 18 2021, 9:15 AM
This revision was automatically updated to reflect the committed changes.