Differential D74815

[AsmPrinter] Change alignment of .stack_sizes from 1 to PointerSize
AbandonedPublic
Actions

Authored by MaskRay on Feb 18 2020, 11:29 PM.

Details

Reviewers

grimar

Summary

Fixes problem 1 of https://bugs.llvm.org/show_bug.cgi?id=36717

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	0 ms	LLVM.DebugInfo/COFF::Unknown Unit Message ("") Test has no run line!
	0 ms	LLVM.DebugInfo/X86::Unknown Unit Message ("") Test has no run line!

Event Timeline

MaskRay created this revision.Feb 18 2020, 11:29 PM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 18 2020, 11:29 PM

Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript

Harbormaster failed remote builds in B46784: Diff 245332!Feb 19 2020, 12:13 AM

Seems the following comment https://bugs.llvm.org/show_bug.cgi?id=36717#c2 from @jhenderson was never answered.
Can you explain why it is a problem?

respindola removed a reviewer: respindola.Feb 19 2020, 7:06 AM

In D74815#1882132, @grimar wrote:

Seems the following comment https://bugs.llvm.org/show_bug.cgi?id=36717#c2 from @jhenderson was never answered.
Can you explain why it is a problem?

I was very late at my time when I was making the change. The size is encoded in uleb128, so............ the output section naturally contains unaligned entries. An alignment will be a bad idea.

A symbolic relocation referencing a local symbol is fine. If it references a global symbol, there could be problems like https://sourceware.org/bugzilla/show_bug.cgi?id=24896