Page MenuHomePhabricator

[AsmPrinter] Change alignment of .stack_sizes from 1 to PointerSize
AbandonedPublic

Authored by MaskRay on Feb 18 2020, 11:29 PM.

Details

Reviewers
grimar
Summary

Diff Detail

Unit TestsFailed

Event Timeline

MaskRay created this revision.Feb 18 2020, 11:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 18 2020, 11:29 PM

Seems the following comment https://bugs.llvm.org/show_bug.cgi?id=36717#c2 from @jhenderson was never answered.
Can you explain why it is a problem?

MaskRay abandoned this revision.Feb 19 2020, 9:16 AM

Seems the following comment https://bugs.llvm.org/show_bug.cgi?id=36717#c2 from @jhenderson was never answered.
Can you explain why it is a problem?

I was very late at my time when I was making the change. The size is encoded in uleb128, so............ the output section naturally contains unaligned entries. An alignment will be a bad idea.

A symbolic relocation referencing a local symbol is fine. If it references a global symbol, there could be problems like https://sourceware.org/bugzilla/show_bug.cgi?id=24896