Page MenuHomePhabricator

[WebAssembly] Don't crash when gnu-style pubnames are requested
AcceptedPublic

Authored by loladiro on Dec 6 2019, 4:36 PM.

Details

Summary

Julia started emitting these after upgrading to LLVM8, causing crashes
in LLVM when targetting WebAssembly. I'm not entirely convinced that
these sections are useful for WebAssembly since the wasm debugging
story isn't entirely fleshed out yet, but at least we shouldn't crash
here while we figure out the right answer.

Event Timeline

loladiro created this revision.Dec 6 2019, 4:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2019, 4:36 PM
dschuff accepted this revision.Dec 12 2019, 10:51 AM
This revision is now accepted and ready to land.Dec 12 2019, 10:51 AM

I have be working on CL that does basically a superset of this to support -gsplit-dwarf. But maybe can land this first.

llvm/test/DebugInfo/WebAssembly/gnu-public-names-tu.ll
2

How does -generate-type-units related to clang option -ggnu-pubnames

Can this test case be reduced to something more minimal?

(sorry.. I wrote those comments a while back and forgot to hit send)..

I have be working on CL that does basically a superset of this to support -gsplit-dwarf. But maybe can land this first.

I'm happy to just leave this as is and carry locally until your CL is done.