Page MenuHomePhabricator

vchuravy (Valentin Churavy)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2015, 8:17 AM (240 w, 5 d)

Recent Activity

Fri, Jan 17

vchuravy added a comment to D72586: [MLIR] Move from add_llvm_library to add_llvm_component_library.

Are there other LLVM subproject who inject themselves into the global llvm shared library? Should we have a libMLIR.so instead?

Fri, Jan 17, 5:51 AM · Restricted Project

Tue, Jan 14

Herald added a project to D44485: [MC] Always emit relocations for same-section function references: Restricted Project.
Tue, Jan 14, 1:42 AM · Restricted Project
vchuravy added a project to D44650: Fix build of llvm-cfi-verify on mingw32: Unknown Object (Project).
Tue, Jan 14, 1:33 AM · Unknown Object (Project), Restricted Project
vchuravy added a project to D34078: Enable support for floating-point division reductions: Unknown Object (Project).
Tue, Jan 14, 1:33 AM · Unknown Object (Project)
vchuravy added a comment to D27629: Fix unwind info relocation with large code model on AArch64.

Is there anything else to do? We (Julia) have been carrying this patch for a while.

Tue, Jan 14, 1:33 AM · Restricted Project, Unknown Object (Project)
vchuravy updated the diff for D27629: Fix unwind info relocation with large code model on AArch64.

move test and rebase

Tue, Jan 14, 1:23 AM · Restricted Project, Unknown Object (Project)
vchuravy updated the summary of D27629: Fix unwind info relocation with large code model on AArch64.
Tue, Jan 14, 1:23 AM · Restricted Project, Unknown Object (Project)
vchuravy added a project to D27629: Fix unwind info relocation with large code model on AArch64: Unknown Object (Project).
Tue, Jan 14, 1:23 AM · Restricted Project, Unknown Object (Project)
vchuravy added a project to D50010: [VNCoercion] Disallow coercion between different ni addrspaces: Unknown Object (Project).
Tue, Jan 14, 1:13 AM · Unknown Object (Project), Restricted Project
vchuravy updated the summary of D50010: [VNCoercion] Disallow coercion between different ni addrspaces.
Tue, Jan 14, 1:13 AM · Unknown Object (Project), Restricted Project
vchuravy updated the diff for D50010: [VNCoercion] Disallow coercion between different ni addrspaces.

clang format

Tue, Jan 14, 1:13 AM · Unknown Object (Project), Restricted Project
vchuravy updated the diff for D50010: [VNCoercion] Disallow coercion between different ni addrspaces.
Tue, Jan 14, 12:17 AM · Unknown Object (Project), Restricted Project
vchuravy changed the repository for D50010: [VNCoercion] Disallow coercion between different ni addrspaces from rL LLVM to rG LLVM Github Monorepo.
Tue, Jan 14, 12:07 AM · Unknown Object (Project), Restricted Project
vchuravy commandeered D50010: [VNCoercion] Disallow coercion between different ni addrspaces.
Tue, Jan 14, 12:07 AM · Unknown Object (Project), Restricted Project

Sun, Jan 12

Herald updated subscribers of D72554: [mlir] support building with BUILD_SHARED_LIBS=ON.
Sun, Jan 12, 6:25 AM

Sun, Dec 22

vchuravy committed rGfb0ccff6e56b: [SelectionDAG] Copy FP flags when visiting a binary instruction. (authored by vchuravy).
[SelectionDAG] Copy FP flags when visiting a binary instruction.
Sun, Dec 22, 11:31 AM
vchuravy closed D71495: [SelectionDAG] Copy FP flags when visiting a binary instruction..
Sun, Dec 22, 11:31 AM · Restricted Project

Dec 21 2019

vchuravy updated the diff for D71495: [SelectionDAG] Copy FP flags when visiting a binary instruction..

clang-format

Dec 21 2019, 5:08 AM · Restricted Project
vchuravy updated the diff for D71495: [SelectionDAG] Copy FP flags when visiting a binary instruction..
update PR
Dec 21 2019, 2:42 AM · Restricted Project

Dec 18 2019

vchuravy updated the diff for D71495: [SelectionDAG] Copy FP flags when visiting a binary instruction..
  • reduce test
  • update test
Dec 18 2019, 10:28 AM · Restricted Project
vchuravy added a comment to D71495: [SelectionDAG] Copy FP flags when visiting a binary instruction..

It's not clear to me where the bug is. I see this debug output:

Detected a reduction operation:  %34 = fadd fast <4 x double> %vec.phi, %30
Creating new node: t36: v4f64 = fadd vector-reduction t35, t30 <-- dropped all other FMF

So that seems like we just accidentally cleared FMF by setting vector-reduction. If so, then a better fix would be after line 3127?

Dec 18 2019, 10:28 AM · Restricted Project

Dec 16 2019

vchuravy committed rG38dd2d50924a: git-llvm: Add option to push to Github with SSH (authored by vchuravy).
git-llvm: Add option to push to Github with SSH
Dec 16 2019, 2:01 PM
vchuravy closed D71534: git-llvm: Add option to push to Github with SSH.
Dec 16 2019, 2:01 PM · Restricted Project
vchuravy created D71534: git-llvm: Add option to push to Github with SSH.
Dec 16 2019, 1:45 AM · Restricted Project
vchuravy committed rG5c29e8c65fe3: [CodegenPrepare] Guard against degenerate branches (authored by vchuravy).
[CodegenPrepare] Guard against degenerate branches
Dec 16 2019, 1:27 AM
vchuravy closed D66657: [CodegenPrepare] Guard against degenerate branches.
Dec 16 2019, 1:27 AM · Restricted Project

Dec 14 2019

vchuravy added a comment to D66657: [CodegenPrepare] Guard against degenerate branches.

Sorry that it took so long for me to finish this.

Dec 14 2019, 8:43 AM · Restricted Project
vchuravy updated the diff for D66657: [CodegenPrepare] Guard against degenerate branches.
  • update aaccording to comments
Dec 14 2019, 8:43 AM · Restricted Project

Dec 13 2019

vchuravy updated the summary of D71495: [SelectionDAG] Copy FP flags when visiting a binary instruction..
Dec 13 2019, 3:27 PM · Restricted Project
vchuravy updated the summary of D71495: [SelectionDAG] Copy FP flags when visiting a binary instruction..
Dec 13 2019, 3:19 PM · Restricted Project
vchuravy created D71495: [SelectionDAG] Copy FP flags when visiting a binary instruction..
Dec 13 2019, 3:18 PM · Restricted Project

Nov 30 2019

vchuravy updated the diff for D66035: [WebAssembly] WIP: Add support for reference types.
  • fix AS in anyref testfile
Nov 30 2019, 3:02 PM · Restricted Project, Restricted Project

Nov 28 2019

vchuravy added inline comments to D66035: [WebAssembly] WIP: Add support for reference types.
Nov 28 2019, 12:23 PM · Restricted Project, Restricted Project
vchuravy updated the diff for D66035: [WebAssembly] WIP: Add support for reference types.

restore previous changes

Nov 28 2019, 12:22 PM · Restricted Project, Restricted Project
vchuravy updated the diff for D66035: [WebAssembly] WIP: Add support for reference types.

support old DL modules

Nov 28 2019, 12:11 PM · Restricted Project, Restricted Project

Nov 27 2019

vchuravy added a comment to D66035: [WebAssembly] WIP: Add support for reference types.

Rebased onto current master and added an initial test. (I will start adding more as I start integrating this with the rest of the toolchain)

Nov 27 2019, 7:52 PM · Restricted Project, Restricted Project
vchuravy updated the diff for D66035: [WebAssembly] WIP: Add support for reference types.
  • add test for passing anyref through a function
  • fix wrong name for funcref
  • fixes and formatting
  • fix error message
Nov 27 2019, 7:52 PM · Restricted Project, Restricted Project

Oct 2 2019

vchuravy updated the diff for D66035: [WebAssembly] WIP: Add support for reference types.
  • change anyref AS to 256
  • fix some comments and address nit
Oct 2 2019, 1:37 PM · Restricted Project, Restricted Project
vchuravy added a comment to D66035: [WebAssembly] WIP: Add support for reference types.

Keno has asked me to take this over for him and I will work on getting this into shape so that it can get landed.

Oct 2 2019, 1:37 PM · Restricted Project, Restricted Project
vchuravy commandeered D66035: [WebAssembly] WIP: Add support for reference types.
Oct 2 2019, 1:31 PM · Restricted Project, Restricted Project

Sep 27 2019

vchuravy added reviewers for D66657: [CodegenPrepare] Guard against degenerate branches: ributzka, spatel.
Sep 27 2019, 9:19 AM · Restricted Project

Aug 23 2019

vchuravy created D66657: [CodegenPrepare] Guard against degenerate branches.
Aug 23 2019, 8:19 AM · Restricted Project

Aug 20 2019

vchuravy added a comment to D66401: [TargetMachine] Don't try to create COFFSTUB references on windows on non-COFF.

Thanks Martin for the quick response and fix. My minimal test-case works and I am in the progress of testing our full build.

Aug 20 2019, 4:11 AM · Restricted Project

Aug 18 2019

Herald added a project to D51590: [MinGW] Move code for indicating "potentially not DSO local" into shouldAssumeDSOLocal. NFCI.: Restricted Project.

This broke Julia downstream (https://github.com/JuliaLang/julia/pull/32712#issuecomment-521206577). In Julia we emit JIT'ed code on MINGW as ELF+Static relocation model (https://github.com/JuliaLang/julia/blob/be3b04b29654a463b4dc899a228b5f53e862cdde/src/codegen.cpp#L7653-L7669), due us having issues with COFF support in RuntimeDyld.

Aug 18 2019, 3:30 AM · Restricted Project

May 5 2019

Herald added a project to D50929: [llvm-mca] Introduce the llvm-mca library and organize the directory accordingly. NFC.: Restricted Project.
May 5 2019, 12:23 PM · Restricted Project

Jul 23 2018

vchuravy accepted D44892: Add PerfJITEventListener for perf profiling support..

It indeed does! Thanks!

Jul 23 2018, 9:48 AM · Restricted Project

Jul 10 2018

vchuravy requested changes to D44892: Add PerfJITEventListener for perf profiling support..
Jul 10 2018, 9:23 AM · Restricted Project

Jul 5 2018

vchuravy updated the diff for D27629: Fix unwind info relocation with large code model on AArch64.

Update to current master and consolidate tests

Jul 5 2018, 3:09 PM · Restricted Project, Unknown Object (Project)
vchuravy commandeered D27629: Fix unwind info relocation with large code model on AArch64.
Jul 5 2018, 3:05 PM · Restricted Project, Unknown Object (Project)

Apr 19 2018

vchuravy accepted D45819: If conversion update.

From my side this looks good and it fixes my more complicated test-case in Julia as well.

Apr 19 2018, 9:08 AM
vchuravy abandoned D45218: [if-converter] Handle BB that terminate in ret during diamond conversion.

Superseded by https://reviews.llvm.org/D45819

Apr 19 2018, 8:20 AM

Apr 4 2018

Herald updated subscribers of D23749: [NVPTX] Add NVPTXHoistAddrSpaceCast pass..
Apr 4 2018, 7:26 AM

Apr 3 2018

vchuravy updated the diff for D45218: [if-converter] Handle BB that terminate in ret during diamond conversion.

@nemanjai correctly noted that the both branches are equal and we can simplify this,
by making sure that we don't fall over the iterator and then removing both BB.

Apr 3 2018, 9:30 PM
vchuravy updated the summary of D45218: [if-converter] Handle BB that terminate in ret during diamond conversion.
Apr 3 2018, 11:31 AM
vchuravy created D45218: [if-converter] Handle BB that terminate in ret during diamond conversion.
Apr 3 2018, 11:27 AM

Mar 25 2018

Herald updated subscribers of D27629: Fix unwind info relocation with large code model on AArch64.
Mar 25 2018, 1:30 PM · Restricted Project, Unknown Object (Project)

Mar 20 2018

vchuravy added a comment to D27296: Don't assume mingw is providing SSP functions.

Is the x86_64-pc-windows-itanium the right platform triple?

Mar 20 2018, 10:32 AM
vchuravy updated the diff for D27296: Don't assume mingw is providing SSP functions.
  • update for windows-itanium and add tests
Mar 20 2018, 10:29 AM
vchuravy added a comment to D27296: Don't assume mingw is providing SSP functions.

Sorry about that - I tested it with a build tree that was a couple weeks old. For some reason I got that failure there, but it does indeed seem to work with the latest trunk version. No idea what changed inbetween.

Mar 20 2018, 8:27 AM

Mar 19 2018

vchuravy added reviewers for D44650: Fix build of llvm-cfi-verify on mingw32: dschuff, skatkov.
Mar 19 2018, 4:19 PM · Unknown Object (Project), Restricted Project
vchuravy created D44650: Fix build of llvm-cfi-verify on mingw32.
Mar 19 2018, 4:16 PM · Unknown Object (Project), Restricted Project
vchuravy added a comment to D27296: Don't assume mingw is providing SSP functions.

Hm I can't reproduce the failure you are seeing. I added your example as a test case and started extending the tests in Codegen/X86/stack-protector.ll to also cover mingw (there still lots of cases to go there).

Mar 19 2018, 2:32 PM
vchuravy updated the diff for D27296: Don't assume mingw is providing SSP functions.

rebase

Mar 19 2018, 2:32 PM
vchuravy updated the diff for D27296: Don't assume mingw is providing SSP functions.

Start adding test for ssp and sspstrong for mingw32

Mar 19 2018, 1:54 PM
vchuravy added a comment to D43781: Make AddrSpaceCast noops on PPC.

Thanks! Can you land this for me I don't have the commit bit.

Mar 19 2018, 9:09 AM
vchuravy updated the diff for D43781: Make AddrSpaceCast noops on PPC.

update tests to use FileCheck

Mar 19 2018, 9:09 AM
vchuravy added a comment to D43781: Make AddrSpaceCast noops on PPC.

@nemanjai I added two test cases the first taken from ARM.addrspacecast.ll and the second from a bug that the Julia frontend hit.

Mar 19 2018, 7:57 AM
vchuravy updated the diff for D43781: Make AddrSpaceCast noops on PPC.

fix typos

Mar 19 2018, 7:49 AM
vchuravy updated the diff for D43781: Make AddrSpaceCast noops on PPC.

add tests for addrspaces noops on PPC

Mar 19 2018, 7:42 AM

Mar 17 2018

vchuravy added a comment to D27296: Don't assume mingw is providing SSP functions.

@mstorsjo Thanks for your feedback. Might I ask how you tested this? Did you simply compiled clang as well and run the testsuite?

Mar 17 2018, 4:03 PM
vchuravy updated the diff for D27296: Don't assume mingw is providing SSP functions.

Rebase onto master

Mar 17 2018, 2:38 PM
vchuravy added a comment to D27296: Don't assume mingw is providing SSP functions.

In the progress of updating the Julia frontend to LLVM 6.0.0 I encountered this issue again.
Julia is using mingw for our windows support and as far as I understand mingw doesn't provide __security_cookie and __security_check_cookie
as part of the runtime (https://sourceforge.net/p/mingw-w64/mailman/message/27235169/). I suspect partly due to the fact that the version of
msvcrt.dll that mingw only has the symbols in an external static library (bufferoverflowU.lib). On the other hand mingw does provide libssp.

Mar 17 2018, 2:02 PM

Feb 26 2018

vchuravy added reviewers for D43781: Make AddrSpaceCast noops on PPC: power-llvm-team, hfinkel.
Feb 26 2018, 1:18 PM
vchuravy created D43781: Make AddrSpaceCast noops on PPC.
Feb 26 2018, 1:17 PM

Jul 6 2017

vchuravy added a comment to D28990: Align i128 to 16 bytes.

@echristo I noticed that you reverted r294702 shortly after it landed. What needs to be done to get it working?

Jul 6 2017, 6:21 PM

Feb 13 2017

vchuravy abandoned D27296: Don't assume mingw is providing SSP functions.
Feb 13 2017, 6:04 PM

Jan 4 2017

vchuravy updated the diff for D28221: Add check for AVX512 support before assuming skylake processor is SKX..

address review comments

Jan 4 2017, 2:22 PM
vchuravy updated the diff for D28221: Add check for AVX512 support before assuming skylake processor is SKX..

SKX: Defensively check for AVX512

Jan 4 2017, 2:12 PM
vchuravy added a comment to D28221: Add check for AVX512 support before assuming skylake processor is SKX..

@craig.topper should we still have a feature gate for 0x55? SKX is not on the market yet so we can't verify this yet.

Jan 4 2017, 2:10 AM
vchuravy updated the diff for D28221: Add check for AVX512 support before assuming skylake processor is SKX..

Add model id 0x55 as SKX and consolidate 0x4e & 0x5e into SKL

Jan 4 2017, 2:08 AM

Jan 3 2017

vchuravy added a comment to D28221: Add check for AVX512 support before assuming skylake processor is SKX..

Related issue for clang https://llvm.org/bugs/show_bug.cgi?id=27003 shows that the model id for i5-6200U is also 4e. I also grouped the two Skylake ids together.

Jan 3 2017, 1:20 AM
vchuravy updated the diff for D28221: Add check for AVX512 support before assuming skylake processor is SKX..

groups the model id for skylake and checks for AVX512 to differentiate between SKL and SKX

Jan 3 2017, 1:17 AM

Jan 2 2017

vchuravy updated subscribers of D28221: Add check for AVX512 support before assuming skylake processor is SKX..
Jan 2 2017, 6:34 PM
vchuravy retitled D28221: Add check for AVX512 support before assuming skylake processor is SKX. from to Add check for AVX512 support before assuming skylake processor is SKX..
Jan 2 2017, 6:32 PM
vchuravy abandoned D27653: Make check for atomic alignment target dependent.
Jan 2 2017, 6:25 PM

Dec 11 2016

vchuravy retitled D27653: Make check for atomic alignment target dependent from to Make check for atomic alignment target dependent.
Dec 11 2016, 1:38 PM
vchuravy added a reviewer for D27653: Make check for atomic alignment target dependent: craig.topper.
Dec 11 2016, 1:38 PM

Dec 9 2016

vchuravy updated subscribers of D27296: Don't assume mingw is providing SSP functions.
Dec 9 2016, 8:04 AM
vchuravy added a comment to D27610: CMake is funky on detecting Intel 17 as GCC compatible..

btw, would it work with icl.exe on windows?

As far as I know Intel on Windows is capable off handling gnu-style options, but I don't have a test system.

Dec 9 2016, 8:03 AM
vchuravy added a reviewer for D27610: CMake is funky on detecting Intel 17 as GCC compatible.: chapuni.
Dec 9 2016, 3:59 AM
vchuravy retitled D27610: CMake is funky on detecting Intel 17 as GCC compatible. from to CMake is funky on detecting Intel 17 as GCC compatible..
Dec 9 2016, 3:59 AM

Dec 1 2016

vchuravy added a comment to D27296: Don't assume mingw is providing SSP functions.

I should also note the mingw64 provides "libssp" so the MSVCRT functions are not needed on this target.

Dec 1 2016, 5:58 AM
vchuravy added reviewers for D27296: Don't assume mingw is providing SSP functions: craig.topper, etienne.bergeron.
Dec 1 2016, 2:28 AM
vchuravy added a comment to D27296: Don't assume mingw is providing SSP functions.

The Julia project is currently evaluating updating LLVM from 3.7 to 3.9 and we are working on making sure that it will continue to work on all supported platforms.
We currently support Windows through Mingw and encountered LLVM ERROR: Program used external function '__atomic_store' which could not be resolved! in JIT'ed code.
So far we did not need MSVCRT as a runtime library with Mingw, greatly simplifying deployment.

Dec 1 2016, 2:24 AM
vchuravy retitled D27296: Don't assume mingw is providing SSP functions from to Don't assume mingw is providing SSP functions.
Dec 1 2016, 2:11 AM

Oct 31 2016

vchuravy added a comment to D25865: Fix llvm-shlib cmake build.

Since I am new to LLVM I was wondering what the process of landing this is?

Oct 31 2016, 6:50 PM

Oct 23 2016

vchuravy updated the diff for D25865: Fix llvm-shlib cmake build.

Address review comments

Oct 23 2016, 9:08 PM

Oct 21 2016

vchuravy added reviewers for D25865: Fix llvm-shlib cmake build: axw, beanz.
Oct 21 2016, 1:34 AM
vchuravy retitled D25865: Fix llvm-shlib cmake build from to Fix llvm-shlib cmake build.
Oct 21 2016, 1:33 AM

Sep 27 2016

vchuravy updated subscribers of D24951: Import/adapt the SLEEF vector math-function library as an LLVM runtime.
Sep 27 2016, 6:53 AM