We talked at LLVMdev and the reason why it wasn't done where non-temporal memory ops. The LLVM langref and the C standard says nothing about them, but currently this is the only way to obtain a fence operation that affects them.

Backported this for Julia to 13 & 14 and this fixes our build!

This looks great. Is this safe to backport to LLVM13 or LLVM14?

This is great, we have been carrying https://github.com/JuliaLang/julia/blob/a0093d2ffb7ba1d35071543e581c26b96a772d39/deps/patches/llvm7-symver-jlprefix.patch

👏

We are starting to use a Github fork to manage our (yet to upstream) patch-set. I am expecting contributors to open PRs to add new patches that we accumulate.
This reduces resource usage when users force-push or add multiple commits to a branch.

bump

Rebase onto main

Improve and simplify test

@loladiro does this impact us? Julia does support running under valgrind, see https://docs.julialang.org/en/v1/devdocs/valgrind/,
and IIRC that extends to JIT'ed code.

Update test for adding dependencies and clang-format

Update unittests

Update docs

Apply changes from lhames

Regarding the MaterializationResponsibility API: it would be good to add the addDependencies and addDependenciesForAll methods. These declare dependencies for each materializing symbol so that ORC can track them in its dependence graph, which in turn ensures that lookups remain safe regardless of what threads the symbols are being materialized on. These methods are an essential part of the MaterializationResponsibility API.

Address part of the review

add first draft of docs and unit test for MaterializationResponisibility

clang-format and rebase

Add comment and clang-format

address review

Address review comments

Create separate MaterializationUnit's

Use MaterializationResponsibility::replace

Use IRLayer::emit instead of LLJIT::add

@lhames this currently fails with

That does seem to indeed fix all the remaining issues with Float16 that the Julia testsuite covers :)

Abandoned in favour of D94980

Good to go from the Julia side.

This fixed a whole set of bugs for us but it also seems to have caused a regression.
https://github.com/JuliaLang/julia/issues/38859

Looks good from the Julia side, this does indeed fix the upstream bug. Thanks @nemanjai!

Rebase commit onto main

Thanks! I rebased the PR and landed it.

Bump for review. We (Julia) have been carrying this one for a while.