Page MenuHomePhabricator

vchuravy (Valentin Churavy)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2015, 8:17 AM (362 w, 5 d)

Recent Activity

Mon, May 2

vchuravy updated subscribers of D124779: [Sanitizers] Fix compilation on musl 32bit.
Mon, May 2, 9:25 AM · Restricted Project, Restricted Project
vchuravy requested review of D124779: [Sanitizers] Fix compilation on musl 32bit.
Mon, May 2, 9:24 AM · Restricted Project, Restricted Project
vchuravy updated subscribers of D124770: [Sanitizers] Guard FP_XSTATE_MAGIC1 usage by GLIBC version.
Mon, May 2, 7:54 AM · Restricted Project, Restricted Project
vchuravy requested review of D124770: [Sanitizers] Guard FP_XSTATE_MAGIC1 usage by GLIBC version.
Mon, May 2, 7:07 AM · Restricted Project, Restricted Project

Jan 31 2022

vchuravy added a project to D118672: [cmake][NFC] Configuration for libLLVM.so symbol versioning: Restricted Project.
Jan 31 2022, 6:04 PM · Restricted Project, Restricted Project
vchuravy accepted D118672: [cmake][NFC] Configuration for libLLVM.so symbol versioning.

This is great, we have been carrying https://github.com/JuliaLang/julia/blob/a0093d2ffb7ba1d35071543e581c26b96a772d39/deps/patches/llvm7-symver-jlprefix.patch

Jan 31 2022, 6:04 PM · Restricted Project, Restricted Project

Nov 5 2021

vchuravy added a comment to D113247: [VE] Make VE official.

👏

Nov 5 2021, 9:45 AM · Restricted Project, Restricted Project

Oct 24 2021

vchuravy added a reviewer for D92210: Don't sink ptrtoint/inttoptr sequences into non-noop addrspacecasts.: arsenm.
Oct 24 2021, 1:50 PM · Restricted Project, Restricted Project

Oct 21 2021

vchuravy abandoned D75072: [SCEV] Record NI types in add exprs.
Oct 21 2021, 12:02 PM · Restricted Project, Restricted Project

Oct 11 2021

vchuravy added a comment to D111499: [GHA] Cancel intermediate builds on PRs.

We are starting to use a Github fork to manage our (yet to upstream) patch-set. I am expecting contributors to open PRs to add new patches that we accumulate.
This reduces resource usage when users force-push or add multiple commits to a branch.

Oct 11 2021, 10:27 AM · Restricted Project

Oct 9 2021

vchuravy requested review of D111499: [GHA] Cancel intermediate builds on PRs.
Oct 9 2021, 2:08 PM · Restricted Project

Oct 1 2021

vchuravy added a project to D110979: Re-apply the fix on DwarfEHPrepare and add a test: Restricted Project.
Oct 1 2021, 4:40 PM · Restricted Project, Restricted Project

Sep 29 2021

vchuravy added a comment to D92210: Don't sink ptrtoint/inttoptr sequences into non-noop addrspacecasts..

bump

Sep 29 2021, 12:20 PM · Restricted Project, Restricted Project

Sep 14 2021

vchuravy resigned from D72550: [SCCIterator] Fix another potential use-after-free.
Sep 14 2021, 2:57 PM · Restricted Project

Sep 2 2021

vchuravy updated subscribers of D109203: [X86] Don't clobber EBX in stackprobes.
Sep 2 2021, 10:52 PM · Restricted Project

Aug 28 2021

vchuravy updated the diff for D75072: [SCEV] Record NI types in add exprs.

Rebase onto main

Aug 28 2021, 9:04 AM · Restricted Project, Restricted Project
vchuravy added a project to D97435: [Aarch64] Correct register class for pseudo instructions: Restricted Project.
Aug 28 2021, 8:41 AM · Restricted Project, Restricted Project
vchuravy added inline comments to D94813: [MergeICmps] Don't merge icmps derived from pointers with addressspaces.
Aug 28 2021, 4:10 AM · Restricted Project

Aug 27 2021

vchuravy committed rG4cacb5cad052: [MergeICmps] Don't merge icmps derived from pointers with addressspaces (authored by vchuravy).
[MergeICmps] Don't merge icmps derived from pointers with addressspaces
Aug 27 2021, 1:15 PM
vchuravy closed D94813: [MergeICmps] Don't merge icmps derived from pointers with addressspaces.
Aug 27 2021, 1:15 PM · Restricted Project
vchuravy updated the diff for D94813: [MergeICmps] Don't merge icmps derived from pointers with addressspaces.

Improve and simplify test

Aug 27 2021, 1:14 PM · Restricted Project

Jul 23 2021

vchuravy added a project to D106613: Bad SLPVectorization shufflevector replacement, resulting in write to wrong memory location: Restricted Project.
Jul 23 2021, 2:53 AM · Restricted Project, Restricted Project

Jul 18 2021

vchuravy added a reverting change for rGa56fe117e04f: Revert "[Orc] Add verylazy example for C-bindings": rG3321f4821e09: Reland [Orc] Add verylazy example for C-bindings.
Jul 18 2021, 12:18 PM
vchuravy committed rG3321f4821e09: Reland [Orc] Add verylazy example for C-bindings (authored by vchuravy).
Reland [Orc] Add verylazy example for C-bindings
Jul 18 2021, 12:18 PM
vchuravy added a reverting change for rGb5a6ad8c893a: [Orc] Add verylazy example for C-bindings: rGa56fe117e04f: Revert "[Orc] Add verylazy example for C-bindings".
Jul 18 2021, 7:22 AM
vchuravy committed rGa56fe117e04f: Revert "[Orc] Add verylazy example for C-bindings" (authored by vchuravy).
Revert "[Orc] Add verylazy example for C-bindings"
Jul 18 2021, 7:22 AM
vchuravy added a reverting change for D104799: [Orc] Add verylazy example for C-bindings: rGa56fe117e04f: Revert "[Orc] Add verylazy example for C-bindings".
Jul 18 2021, 7:22 AM · Restricted Project
vchuravy committed rGb5a6ad8c893a: [Orc] Add verylazy example for C-bindings (authored by vchuravy).
[Orc] Add verylazy example for C-bindings
Jul 18 2021, 3:07 AM
vchuravy closed D104799: [Orc] Add verylazy example for C-bindings.
Jul 18 2021, 3:07 AM · Restricted Project
vchuravy committed rG0c164ea9e687: [MLIR][CAPI] On MINGW don't link against libMLIR (authored by vchuravy).
[MLIR][CAPI] On MINGW don't link against libMLIR
Jul 18 2021, 3:06 AM
vchuravy closed D106169: [MLIR][CAPI] On MINGW don't link against libMLIR.
Jul 18 2021, 3:06 AM · Restricted Project

Jul 17 2021

vchuravy updated subscribers of D106206: Remove the NotUnderValgrind caching flag.

@loladiro does this impact us? Julia does support running under valgrind, see https://docs.julialang.org/en/v1/devdocs/valgrind/,
and IIRC that extends to JIT'ed code.

Jul 17 2021, 5:50 AM · Restricted Project, Restricted Project
vchuravy added a project to D106206: Remove the NotUnderValgrind caching flag: Restricted Project.
Jul 17 2021, 5:47 AM · Restricted Project, Restricted Project

Jul 16 2021

vchuravy added a reviewer for D106169: [MLIR][CAPI] On MINGW don't link against libMLIR: stephenneuendorffer.
Jul 16 2021, 11:09 AM · Restricted Project
vchuravy added a reviewer for D106169: [MLIR][CAPI] On MINGW don't link against libMLIR: stellaraccident.
Jul 16 2021, 11:09 AM · Restricted Project
vchuravy requested review of D106169: [MLIR][CAPI] On MINGW don't link against libMLIR.
Jul 16 2021, 11:08 AM · Restricted Project

Jul 15 2021

vchuravy abandoned D73156: [clang] Build clang-shlib on mingw.
Jul 15 2021, 11:46 AM · Restricted Project
vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

Update test for adding dependencies and clang-format

Jul 15 2021, 8:49 AM · Restricted Project

Jul 12 2021

vchuravy added inline comments to D104799: [Orc] Add verylazy example for C-bindings.
Jul 12 2021, 8:34 AM · Restricted Project
vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

Update unittests

Jul 12 2021, 8:32 AM · Restricted Project
vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

Update docs

Jul 12 2021, 4:49 AM · Restricted Project
vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

Apply changes from lhames

Jul 12 2021, 4:16 AM · Restricted Project

Jul 11 2021

vchuravy added a comment to D104799: [Orc] Add verylazy example for C-bindings.

Regarding the MaterializationResponsibility API: it would be good to add the addDependencies and addDependenciesForAll methods. These declare dependencies for each materializing symbol so that ORC can track them in its dependence graph, which in turn ensures that lookups remain safe regardless of what threads the symbols are being materialized on. These methods are an essential part of the MaterializationResponsibility API.

Jul 11 2021, 1:11 PM · Restricted Project
vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

Address part of the review

Jul 11 2021, 1:01 PM · Restricted Project

Jul 2 2021

vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

add first draft of docs and unit test for MaterializationResponisibility

Jul 2 2021, 10:49 AM · Restricted Project

Jul 1 2021

vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

clang-format and rebase

Jul 1 2021, 12:58 PM · Restricted Project
vchuravy committed rG45e8a0befbc8: [Orc] At CBindings for LazyRexports (authored by vchuravy).
[Orc] At CBindings for LazyRexports
Jul 1 2021, 12:52 PM
vchuravy closed D104672: [Orc] At CBindings for LazyRexports.
Jul 1 2021, 12:52 PM · Restricted Project
vchuravy updated the diff for D104672: [Orc] At CBindings for LazyRexports.

Add comment and clang-format

Jul 1 2021, 8:35 AM · Restricted Project
vchuravy added a comment to D104672: [Orc] At CBindings for LazyRexports.

address review

Jul 1 2021, 8:20 AM · Restricted Project
vchuravy updated the diff for D104672: [Orc] At CBindings for LazyRexports.

Address review comments

Jul 1 2021, 8:20 AM · Restricted Project

Jun 30 2021

vchuravy committed rG9762f12c6c60: [Orc] Run the examples as part of the tests (authored by vchuravy).
[Orc] Run the examples as part of the tests
Jun 30 2021, 12:45 PM
vchuravy closed D104637: [Orc] Run the examples as part of the tests.
Jun 30 2021, 12:45 PM · Restricted Project
vchuravy committed rG69e0f790e032: [Orc] Fix name of LLVMOrcIRTransformLayerSetTransform (authored by vchuravy).
[Orc] Fix name of LLVMOrcIRTransformLayerSetTransform
Jun 30 2021, 12:44 PM
vchuravy closed D104840: [Orc] Fix name of LLVMOrcIRTransformLayerSetTransform.
Jun 30 2021, 12:44 PM · Restricted Project

Jun 27 2021

vchuravy added a project to D103052: Do not patch FDE symbols in RuntimeDyld, on targets that use non-absolute symbol relocations in `.eh_frame`: Restricted Project.
Jun 27 2021, 12:42 AM · Restricted Project, Restricted Project, Restricted Project

Jun 26 2021

vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

Create separate MaterializationUnit's

Jun 26 2021, 7:27 AM · Restricted Project

Jun 25 2021

vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

Use MaterializationResponsibility::replace

Jun 25 2021, 12:14 PM · Restricted Project

Jun 23 2021

vchuravy updated the diff for D104799: [Orc] Add verylazy example for C-bindings.

Use IRLayer::emit instead of LLJIT::add

Jun 23 2021, 11:45 PM · Restricted Project
vchuravy requested review of D104840: [Orc] Fix name of LLVMOrcIRTransformLayerSetTransform.
Jun 23 2021, 10:51 PM · Restricted Project
vchuravy added a comment to D104799: [Orc] Add verylazy example for C-bindings.

@lhames this currently fails with

Jun 23 2021, 10:54 AM · Restricted Project
vchuravy requested review of D104799: [Orc] Add verylazy example for C-bindings.
Jun 23 2021, 10:52 AM · Restricted Project

Jun 21 2021

vchuravy requested review of D104672: [Orc] At CBindings for LazyRexports.
Jun 21 2021, 2:26 PM · Restricted Project
vchuravy requested review of D104637: [Orc] Run the examples as part of the tests.
Jun 21 2021, 5:39 AM · Restricted Project

Jun 17 2021

vchuravy added a project to D104480: [Orc] add C-API for transform layer: Restricted Project.
Jun 17 2021, 11:56 AM · Restricted Project, Restricted Project
vchuravy requested review of D104480: [Orc] add C-API for transform layer.
Jun 17 2021, 11:55 AM · Restricted Project, Restricted Project

May 14 2021

vchuravy updated subscribers of D102471: New tag for ittapi - fix an error related to cross-compiling ITTAPI in LLVM with mingw.
May 14 2021, 9:07 AM · Restricted Project

May 10 2021

vchuravy added inline comments to D102097: [CompilerRT] Sanitizer compilation on musl systems.
May 10 2021, 10:06 AM · Restricted Project

May 7 2021

vchuravy added inline comments to D102097: [CompilerRT] Sanitizer compilation on musl systems.
May 7 2021, 5:29 PM · Restricted Project
vchuravy updated subscribers of D102097: [CompilerRT] Sanitizer compilation on musl systems.
May 7 2021, 5:28 PM · Restricted Project
vchuravy requested review of D102097: [CompilerRT] Sanitizer compilation on musl systems.
May 7 2021, 5:23 PM · Restricted Project

Feb 16 2021

vchuravy added a project to D96283: [DAGCombine] Do not remove masking argument to FP16_TO_FP for some targets: Restricted Project.
Feb 16 2021, 7:27 PM · Restricted Project, Restricted Project

Jan 19 2021

vchuravy accepted D94980: [PowerPC] Do not emit HW loop with half precision operations.

That does seem to indeed fix all the remaining issues with Float16 that the Julia testsuite covers :)

Jan 19 2021, 7:20 PM · Restricted Project
vchuravy abandoned D94828: [PowerPC] Disable CTR loops containing floating point conversion on half-precision.

Abandoned in favour of D94980

Jan 19 2021, 7:19 PM · Restricted Project, Restricted Project

Jan 15 2021

vchuravy added reviewers for D94813: [MergeICmps] Don't merge icmps derived from pointers with addressspaces: courbet, MaskRay, jyknight.
Jan 15 2021, 9:37 PM · Restricted Project
vchuravy added a reviewer for D94828: [PowerPC] Disable CTR loops containing floating point conversion on half-precision: Restricted Project.
Jan 15 2021, 2:32 PM · Restricted Project, Restricted Project
vchuravy requested review of D94828: [PowerPC] Disable CTR loops containing floating point conversion on half-precision.
Jan 15 2021, 2:32 PM · Restricted Project, Restricted Project
vchuravy retitled D94813: [MergeICmps] Don't merge icmps derived from pointers with addressspaces from [MergeICmps] Don't merge icmps derived frm pointers with addressspaces to [MergeICmps] Don't merge icmps derived from pointers with addressspaces.
Jan 15 2021, 2:27 PM · Restricted Project
vchuravy accepted D94058: [PowerPC] Sign extend comparison operand for signed atomic comparisons.

Good to go from the Julia side.

Jan 15 2021, 11:26 AM · Restricted Project
vchuravy added a reviewer for D94813: [MergeICmps] Don't merge icmps derived from pointers with addressspaces: Restricted Project.
Jan 15 2021, 11:12 AM · Restricted Project
vchuravy requested review of D94813: [MergeICmps] Don't merge icmps derived from pointers with addressspaces.
Jan 15 2021, 11:12 AM · Restricted Project

Jan 5 2021

vchuravy updated subscribers of D94058: [PowerPC] Sign extend comparison operand for signed atomic comparisons.
Jan 5 2021, 7:57 AM · Restricted Project

Dec 16 2020

vchuravy added a comment to D92906: [PowerPC] Restore stack ptr from frame ptr with setjmp.

This fixed a whole set of bugs for us but it also seems to have caused a regression.
https://github.com/JuliaLang/julia/issues/38859

Dec 16 2020, 5:30 PM · Restricted Project

Dec 9 2020

vchuravy accepted D92906: [PowerPC] Restore stack ptr from frame ptr with setjmp.

Looks good from the Julia side, this does indeed fix the upstream bug. Thanks @nemanjai!

Dec 9 2020, 10:35 AM · Restricted Project
vchuravy updated subscribers of D92906: [PowerPC] Restore stack ptr from frame ptr with setjmp.
Dec 9 2020, 5:00 AM · Restricted Project

Dec 7 2020

vchuravy updated the diff for D75072: [SCEV] Record NI types in add exprs.

Rebase commit onto main

Dec 7 2020, 6:04 PM · Restricted Project, Restricted Project
vchuravy commandeered D75072: [SCEV] Record NI types in add exprs.
Dec 7 2020, 5:38 PM · Restricted Project, Restricted Project
vchuravy added a comment to D50010: [VNCoercion] Disallow coercion between different ni addrspaces.

Thanks! I rebased the PR and landed it.

Dec 7 2020, 5:21 PM · Restricted Project, Restricted Project
vchuravy committed rG700cf7dcc927: [VNCoercion] Disallow coercion between different ni addrspaces (authored by vchuravy).
[VNCoercion] Disallow coercion between different ni addrspaces
Dec 7 2020, 5:20 PM
vchuravy closed D50010: [VNCoercion] Disallow coercion between different ni addrspaces.
Dec 7 2020, 5:20 PM · Restricted Project, Restricted Project

Dec 6 2020

vchuravy added a comment to D50010: [VNCoercion] Disallow coercion between different ni addrspaces.

Bump for review. We (Julia) have been carrying this one for a while.

Dec 6 2020, 10:58 AM · Restricted Project, Restricted Project

Nov 27 2020

vchuravy updated subscribers of D86837: Allow specifying AA info when constructing certain libcalls.
Nov 27 2020, 5:13 PM · Restricted Project

Nov 23 2020

vchuravy added a comment to D75072: [SCEV] Record NI types in add exprs.

@reames I think you are the right person to review this. Any objections?
We have been carrying this on the Julia side. I can rebase this on master if that would help (LLVM 11 version is available here https://github.com/JuliaLang/julia/blob/master/deps/patches/llvm-11-D75072-SCEV-add-type.patch)

Nov 23 2020, 5:41 PM · Restricted Project, Restricted Project
vchuravy added a reviewer for D73156: [clang] Build clang-shlib on mingw: mstorsjo.
Nov 23 2020, 5:17 PM · Restricted Project
vchuravy added a comment to D88630: [clang/CMake] Respect LLVM_TOOLS_INSTALL_DIR.

Well, I've tested it and it doesn't seem to break anything for us (Gentoo) but I don't really understand why you'd have a different install dir for LLVM and Clang.

Nov 23 2020, 5:12 PM · Restricted Project
vchuravy committed rG4bc88a0e9a2e: Enable support for floating-point division reductions (authored by yuyichao).
Enable support for floating-point division reductions
Nov 23 2020, 5:06 PM
vchuravy closed D34078: Enable support for floating-point division reductions.
Nov 23 2020, 5:06 PM · Restricted Project, Restricted Project
vchuravy abandoned D89211: [RTDYLD] add debug statements for resolveX86Relocation.
Nov 23 2020, 4:06 PM · Restricted Project

Nov 6 2020

vchuravy abandoned D44650: Fix build of llvm-cfi-verify on mingw32.

In favor of https://reviews.llvm.org/D90969

Nov 6 2020, 1:53 PM · Restricted Project, Restricted Project

Nov 3 2020

vchuravy accepted D90722: [RTDYLD] support absolute relocations where needed.

Looks good from my side. @lhames should sign off though.

Nov 3 2020, 3:01 PM · Restricted Project