Page MenuHomePhabricator

vchuravy (Valentin Churavy)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2015, 8:17 AM (279 w, 5 d)

Recent Activity

Yesterday

vchuravy added a comment to rGc068e9c8c123: [Support][CommandLine] Delete unused llvm::cl::ParseEnvrironmentOptions.

It is questionable for a downstream project to parse and interpret LLVM internal options directly. It should at least to have a -mllvm or --plugin-opt= prefix.

Mon, Oct 19, 6:33 AM

Sun, Oct 18

vchuravy added a comment to rGc068e9c8c123: [Support][CommandLine] Delete unused llvm::cl::ParseEnvrironmentOptions.

Yeah, I basically copy-and-pasted the original implementation, since we are indeed parsing this from the environment. https://github.com/JuliaLang/julia/pull/38092/commits/72c2136dfad7a535dba563c0f37f3c70da5558a2

Sun, Oct 18, 10:05 PM
vchuravy added a comment to rGc068e9c8c123: [Support][CommandLine] Delete unused llvm::cl::ParseEnvrironmentOptions.

@MaskRay why was it necessary to delete this? It is used by downstream projects (like Julia). I agree that it isn't too much hassle to implement, but every tool that uses LLVM as a library will have to write a version themselves.

Sun, Oct 18, 6:52 PM

Mon, Oct 12

vchuravy updated the diff for D89241: [RTDYLD] be more defensive about relocations with empty symbol names.

clang-format

Mon, Oct 12, 7:58 AM · Restricted Project
vchuravy requested review of D89241: [RTDYLD] be more defensive about relocations with empty symbol names.
Mon, Oct 12, 7:55 AM · Restricted Project
vchuravy added a comment to D89211: [RTDYLD] add debug statements for resolveX86Relocation.

I think this can be very noisy as the number of relocations can be very large.

Mon, Oct 12, 7:00 AM · Restricted Project

Sun, Oct 11

vchuravy updated the diff for D89211: [RTDYLD] add debug statements for resolveX86Relocation.

Fix typo

Sun, Oct 11, 11:23 AM · Restricted Project
vchuravy requested review of D89211: [RTDYLD] add debug statements for resolveX86Relocation.
Sun, Oct 11, 11:21 AM · Restricted Project

Thu, Oct 8

vchuravy accepted D88846: [mlir] Improve LLVM shlib support.
Thu, Oct 8, 11:52 AM · Restricted Project

Jul 27 2020

vchuravy abandoned D66035: [WebAssembly] WIP: Add support for reference types.

I am interested in continuing this work and have a patch in progress based on the current available one here. Should I post the new patch here or under a new bug?

Jul 27 2020, 7:30 AM · Restricted Project, Restricted Project

Jul 17 2020

vchuravy updated subscribers of D84031: Clear NewGEPBases after finish using them in CodeGenPrep pass.
Jul 17 2020, 8:54 AM · Restricted Project

Jul 14 2020

vchuravy added a reviewer for D83800: Support PC relative relocation on AArch64 and PPC64 in RelocationResolver: nemanjai.
Jul 14 2020, 11:50 AM · Restricted Project

May 4 2020

vchuravy abandoned D78771: Add dependency edges between generated headers and users.

Abandoned in favour of @stephenneuendorffer recent list of changes.

May 4 2020, 6:54 AM · Restricted Project, Restricted Project
vchuravy accepted D79067: [MLIR] Fix libMLIR.so and LLVM_LINK_LLVM_DYLIB.
May 4 2020, 6:54 AM · Restricted Project
vchuravy accepted D79241: [cmake] Ensure that LINK_LIBS are dependencies for object library targets.
May 4 2020, 6:54 AM · Restricted Project

Apr 29 2020

vchuravy added a comment to D78773: Adjust libMLIR building to more closely follow libClang.

@vchuravy, What's your plan with this patch? I think this should land and I've started building on top of it.

Apr 29 2020, 7:29 PM · Restricted Project, Restricted Project
vchuravy added a comment to D44485: [MC] Always emit relocations for same-section function references.

Right the issue for is that LLVM6 used to accept and compile it without issue:

Apr 29 2020, 4:46 PM · Restricted Project
Herald added a reviewer for D73702: [WIP][mlir] enable conversion materialization for 1-1 type conversions: herhut.
Apr 29 2020, 6:56 AM · Restricted Project

Apr 24 2020

vchuravy added a comment to D78773: Adjust libMLIR building to more closely follow libClang.

Does this get us closer to fixing LLVM_LINK_LLVM_DYLIB?

Apr 24 2020, 10:49 AM · Restricted Project, Restricted Project
vchuravy added a comment to D78771: Add dependency edges between generated headers and users.

Ultimately, the solution may be to just generate all the headers before building everything else, which means that all mlir libraries would have a dependence on all IncGen targets. That isn't great, but I think it's better than the fix proposed in this review.

Apr 24 2020, 10:48 AM · Restricted Project, Restricted Project
vchuravy added a comment to D78773: Adjust libMLIR building to more closely follow libClang.

With ninja all dependencies edges are fine, but with Makefiles it indeed still complains about missing edges to the generated headers.

Apr 24 2020, 9:09 AM · Restricted Project, Restricted Project
vchuravy updated the diff for D78773: Adjust libMLIR building to more closely follow libClang.

small fixes and use MLIR_STATIC_LIBS

Apr 24 2020, 9:09 AM · Restricted Project, Restricted Project

Apr 23 2020

vchuravy added a reviewer for D78773: Adjust libMLIR building to more closely follow libClang: rriddle.
Apr 23 2020, 4:52 PM · Restricted Project, Restricted Project
vchuravy added inline comments to D78771: Add dependency edges between generated headers and users.
Apr 23 2020, 4:52 PM · Restricted Project, Restricted Project
vchuravy added reviewers for D78773: Adjust libMLIR building to more closely follow libClang: mehdi_amini, stephenneuendorffer.
Apr 23 2020, 4:52 PM · Restricted Project, Restricted Project
vchuravy added a reviewer for D78771: Add dependency edges between generated headers and users: stephenneuendorffer.
Apr 23 2020, 4:52 PM · Restricted Project, Restricted Project
vchuravy created D78773: Adjust libMLIR building to more closely follow libClang.
Apr 23 2020, 4:52 PM · Restricted Project, Restricted Project
Herald added a reviewer for D78771: Add dependency edges between generated headers and users: herhut.
Apr 23 2020, 4:52 PM · Restricted Project, Restricted Project

Apr 15 2020

vchuravy added a comment to D78196: [PowerPC] Clear the set of symbols that need to be updated in MCTargetStreamer.

We do reuse the constructed pass pipeline more than once, but that is a supported configuration see -compile-twice in LLC (as an example https://reviews.llvm.org/D17712)

Apr 15 2020, 10:57 AM · Restricted Project
vchuravy accepted D78196: [PowerPC] Clear the set of symbols that need to be updated in MCTargetStreamer.

I am unable to reproduce the issue with this patch applied. 👍

Apr 15 2020, 7:05 AM · Restricted Project

Mar 31 2020

vchuravy added a comment to D77133: [mlir] Add an out-of-tree dialect example.

This is fantastic, thanks.

Mar 31 2020, 1:11 PM · Restricted Project
vchuravy committed rGcba15d1b5c54: Add manually overriding of the darwin SDK version (authored by vchuravy).
Add manually overriding of the darwin SDK version
Mar 31 2020, 10:02 AM
vchuravy closed D77026: Add manually overriding of the darwin SDK version.
Mar 31 2020, 10:01 AM · Restricted Project

Mar 29 2020

vchuravy updated the diff for D77026: Add manually overriding of the darwin SDK version.

Allow for manually specifying the darwin SDK version

Mar 29 2020, 8:52 PM · Restricted Project
vchuravy added inline comments to D77026: Add manually overriding of the darwin SDK version.
Mar 29 2020, 8:52 PM · Restricted Project
vchuravy retitled D77026: Add manually overriding of the darwin SDK version from Add caching to darwin SDK version lookup to Add manually overriding of the darwin SDK version.
Mar 29 2020, 8:52 PM · Restricted Project
vchuravy updated subscribers of D77026: Add manually overriding of the darwin SDK version.
Mar 29 2020, 6:44 PM · Restricted Project
vchuravy created D77026: Add manually overriding of the darwin SDK version.
Mar 29 2020, 6:43 PM · Restricted Project
vchuravy updated subscribers of D73156: [clang] Build clang-shlib on mingw.
Mar 29 2020, 6:43 PM · Restricted Project

Feb 21 2020

vchuravy added inline comments to D73130: [MLIR] Add support for libMLIR.so.
Feb 21 2020, 3:25 PM · Restricted Project
vchuravy added a comment to D74867: [MLIR] add out of tree version of mlir-opt.

This is good to have as a test, but I assume that eventually we would want to have the equivalent of LLVM_LINK_LLVM_DYLIB.

Feb 21 2020, 3:16 PM · Restricted Project
vchuravy added a comment to D74864: [MLIR] Move from using target_link_libraries to LINK_LIBS for llvm libraries..

@mehdi_amini and I had a conversation on discord about libMLIR.so and I think we allayed all fears that this would lock us into being stuck with a libMLIR.so if we want to eventually go down the path of including it as part of libMLIR.so
So I think we are good to go ahead with this.

Feb 21 2020, 3:16 PM · Restricted Project

Feb 20 2020

vchuravy added a comment to D74864: [MLIR] Move from using target_link_libraries to LINK_LIBS for llvm libraries..

I asked in another revision, but I don't think I got an answer: what is the story for the circular dependency if we were to use MLIR in LLVM in the future? I'd be worried about adding barriers into this and I have some memory of a previous discussion that keeping a single .so would be somehow required?

Feb 20 2020, 8:21 AM · Restricted Project

Feb 19 2020

vchuravy added inline comments to D74864: [MLIR] Move from using target_link_libraries to LINK_LIBS for llvm libraries..
Feb 19 2020, 6:34 PM · Restricted Project

Feb 8 2020

vchuravy updated the diff for D73130: [MLIR] Add support for libMLIR.so.

Properly implement shared library similar to clang-shlib

Feb 8 2020, 7:29 PM · Restricted Project
vchuravy retitled D73130: [MLIR] Add support for libMLIR.so from [mlir] Strawman PR for shared library support to [mlir] Shared library support.
Feb 8 2020, 7:29 PM · Restricted Project

Feb 2 2020

vchuravy added a comment to D68292: [CMake] Disable building all Darwin libraries (except builtins) for macOS i386 when the SDK is >= 10.15..

This broke cross-compilation from Linux for us, since we don't have xcodebuild/xcrun . We currently build with

Feb 2 2020, 8:21 AM · Restricted Project, Restricted Project

Jan 28 2020

vchuravy added a comment to D72822: [mlir] Replace AbstractOperation::classof with a ClassID instance..

I built a shared library (D73130) and run into the case that my HasParent<FuncOp> trait failed to verify.

Jan 28 2020, 2:25 PM · Restricted Project

Jan 23 2020

vchuravy added a comment to D44485: [MC] Always emit relocations for same-section function references.

Just as a note, Julia currently reverts this patch. IIRC it caused issue with gcc/mingw32 which we use for linking.
My notes from back then are fairly limited and another team member did the git bisect.

Jan 23 2020, 5:35 AM · Restricted Project

Jan 21 2020

vchuravy added a comment to D73156: [clang] Build clang-shlib on mingw.

Some additional context. We [Julia] is cross-compiling LLVM from Linux to mingw32
as part of an automatic buildsystem for our binary dependencies. The corresponding PR is https://github.com/JuliaPackaging/Yggdrasil/pull/417

Jan 21 2020, 7:13 PM · Restricted Project
vchuravy added a reviewer for D73156: [clang] Build clang-shlib on mingw: tstellar.
Jan 21 2020, 7:13 PM · Restricted Project
vchuravy created D73156: [clang] Build clang-shlib on mingw.
Jan 21 2020, 7:13 PM · Restricted Project
vchuravy added inline comments to D73130: [MLIR] Add support for libMLIR.so.
Jan 21 2020, 12:23 PM · Restricted Project
vchuravy created D73130: [MLIR] Add support for libMLIR.so.
Jan 21 2020, 12:23 PM · Restricted Project
vchuravy added a reviewer for D73130: [MLIR] Add support for libMLIR.so: stephenneuendorffer.
Jan 21 2020, 12:23 PM · Restricted Project

Jan 17 2020

vchuravy added a comment to D72586: [MLIR] Move from add_llvm_library to add_llvm_component_library.

Are there other LLVM subproject who inject themselves into the global llvm shared library? Should we have a libMLIR.so instead?

Jan 17 2020, 5:51 AM · Restricted Project

Jan 14 2020

Herald added a project to D44485: [MC] Always emit relocations for same-section function references: Restricted Project.
Jan 14 2020, 1:42 AM · Restricted Project
vchuravy added a project to D44650: Fix build of llvm-cfi-verify on mingw32: Unknown Object (Project).
Jan 14 2020, 1:33 AM · Unknown Object (Project), Restricted Project
vchuravy added a project to D34078: Enable support for floating-point division reductions: Unknown Object (Project).
Jan 14 2020, 1:33 AM · Unknown Object (Project)
vchuravy added a comment to D27629: Fix unwind info relocation with large code model on AArch64.

Is there anything else to do? We (Julia) have been carrying this patch for a while.

Jan 14 2020, 1:33 AM · Restricted Project, Unknown Object (Project)
vchuravy updated the diff for D27629: Fix unwind info relocation with large code model on AArch64.

move test and rebase

Jan 14 2020, 1:23 AM · Restricted Project, Unknown Object (Project)
vchuravy updated the summary of D27629: Fix unwind info relocation with large code model on AArch64.
Jan 14 2020, 1:23 AM · Restricted Project, Unknown Object (Project)
vchuravy added a project to D27629: Fix unwind info relocation with large code model on AArch64: Unknown Object (Project).
Jan 14 2020, 1:23 AM · Restricted Project, Unknown Object (Project)
vchuravy added a project to D50010: [VNCoercion] Disallow coercion between different ni addrspaces: Unknown Object (Project).
Jan 14 2020, 1:13 AM · Unknown Object (Project), Restricted Project
vchuravy updated the summary of D50010: [VNCoercion] Disallow coercion between different ni addrspaces.
Jan 14 2020, 1:13 AM · Unknown Object (Project), Restricted Project
vchuravy updated the diff for D50010: [VNCoercion] Disallow coercion between different ni addrspaces.

clang format

Jan 14 2020, 1:13 AM · Unknown Object (Project), Restricted Project
vchuravy updated the diff for D50010: [VNCoercion] Disallow coercion between different ni addrspaces.
Jan 14 2020, 12:17 AM · Unknown Object (Project), Restricted Project
vchuravy changed the repository for D50010: [VNCoercion] Disallow coercion between different ni addrspaces from rL LLVM to rG LLVM Github Monorepo.
Jan 14 2020, 12:07 AM · Unknown Object (Project), Restricted Project
vchuravy commandeered D50010: [VNCoercion] Disallow coercion between different ni addrspaces.
Jan 14 2020, 12:07 AM · Unknown Object (Project), Restricted Project

Dec 22 2019

vchuravy committed rGfb0ccff6e56b: [SelectionDAG] Copy FP flags when visiting a binary instruction. (authored by vchuravy).
[SelectionDAG] Copy FP flags when visiting a binary instruction.
Dec 22 2019, 11:31 AM
vchuravy closed D71495: [SelectionDAG] Copy FP flags when visiting a binary instruction..
Dec 22 2019, 11:31 AM · Restricted Project

Dec 21 2019

vchuravy updated the diff for D71495: [SelectionDAG] Copy FP flags when visiting a binary instruction..

clang-format

Dec 21 2019, 5:08 AM · Restricted Project
vchuravy updated the diff for D71495: [SelectionDAG] Copy FP flags when visiting a binary instruction..
update PR
Dec 21 2019, 2:42 AM · Restricted Project

Dec 18 2019

vchuravy updated the diff for D71495: [SelectionDAG] Copy FP flags when visiting a binary instruction..
  • reduce test
  • update test
Dec 18 2019, 10:28 AM · Restricted Project
vchuravy added a comment to D71495: [SelectionDAG] Copy FP flags when visiting a binary instruction..

It's not clear to me where the bug is. I see this debug output:

Detected a reduction operation:  %34 = fadd fast <4 x double> %vec.phi, %30
Creating new node: t36: v4f64 = fadd vector-reduction t35, t30 <-- dropped all other FMF

So that seems like we just accidentally cleared FMF by setting vector-reduction. If so, then a better fix would be after line 3127?

Dec 18 2019, 10:28 AM · Restricted Project

Dec 16 2019

vchuravy committed rG38dd2d50924a: git-llvm: Add option to push to Github with SSH (authored by vchuravy).
git-llvm: Add option to push to Github with SSH
Dec 16 2019, 2:01 PM
vchuravy closed D71534: git-llvm: Add option to push to Github with SSH.
Dec 16 2019, 2:01 PM · Restricted Project
vchuravy created D71534: git-llvm: Add option to push to Github with SSH.
Dec 16 2019, 1:45 AM · Restricted Project
vchuravy committed rG5c29e8c65fe3: [CodegenPrepare] Guard against degenerate branches (authored by vchuravy).
[CodegenPrepare] Guard against degenerate branches
Dec 16 2019, 1:27 AM
vchuravy closed D66657: [CodegenPrepare] Guard against degenerate branches.
Dec 16 2019, 1:27 AM · Restricted Project

Dec 14 2019

vchuravy added a comment to D66657: [CodegenPrepare] Guard against degenerate branches.

Sorry that it took so long for me to finish this.

Dec 14 2019, 8:43 AM · Restricted Project
vchuravy updated the diff for D66657: [CodegenPrepare] Guard against degenerate branches.
  • update aaccording to comments
Dec 14 2019, 8:43 AM · Restricted Project

Dec 13 2019

vchuravy updated the summary of D71495: [SelectionDAG] Copy FP flags when visiting a binary instruction..
Dec 13 2019, 3:27 PM · Restricted Project
vchuravy updated the summary of D71495: [SelectionDAG] Copy FP flags when visiting a binary instruction..
Dec 13 2019, 3:19 PM · Restricted Project
vchuravy created D71495: [SelectionDAG] Copy FP flags when visiting a binary instruction..
Dec 13 2019, 3:18 PM · Restricted Project

Nov 30 2019

vchuravy updated the diff for D66035: [WebAssembly] WIP: Add support for reference types.
  • fix AS in anyref testfile
Nov 30 2019, 3:02 PM · Restricted Project, Restricted Project

Nov 28 2019

vchuravy added inline comments to D66035: [WebAssembly] WIP: Add support for reference types.
Nov 28 2019, 12:23 PM · Restricted Project, Restricted Project
vchuravy updated the diff for D66035: [WebAssembly] WIP: Add support for reference types.

restore previous changes

Nov 28 2019, 12:22 PM · Restricted Project, Restricted Project
vchuravy updated the diff for D66035: [WebAssembly] WIP: Add support for reference types.

support old DL modules

Nov 28 2019, 12:11 PM · Restricted Project, Restricted Project

Nov 27 2019

vchuravy added a comment to D66035: [WebAssembly] WIP: Add support for reference types.

Rebased onto current master and added an initial test. (I will start adding more as I start integrating this with the rest of the toolchain)

Nov 27 2019, 7:52 PM · Restricted Project, Restricted Project
vchuravy updated the diff for D66035: [WebAssembly] WIP: Add support for reference types.
  • add test for passing anyref through a function
  • fix wrong name for funcref
  • fixes and formatting
  • fix error message
Nov 27 2019, 7:52 PM · Restricted Project, Restricted Project

Oct 2 2019

vchuravy updated the diff for D66035: [WebAssembly] WIP: Add support for reference types.
  • change anyref AS to 256
  • fix some comments and address nit
Oct 2 2019, 1:37 PM · Restricted Project, Restricted Project
vchuravy added a comment to D66035: [WebAssembly] WIP: Add support for reference types.

Keno has asked me to take this over for him and I will work on getting this into shape so that it can get landed.

Oct 2 2019, 1:37 PM · Restricted Project, Restricted Project
vchuravy commandeered D66035: [WebAssembly] WIP: Add support for reference types.
Oct 2 2019, 1:31 PM · Restricted Project, Restricted Project

Sep 27 2019

vchuravy added reviewers for D66657: [CodegenPrepare] Guard against degenerate branches: ributzka, spatel.
Sep 27 2019, 9:19 AM · Restricted Project

Aug 23 2019

vchuravy created D66657: [CodegenPrepare] Guard against degenerate branches.
Aug 23 2019, 8:19 AM · Restricted Project

Aug 20 2019

vchuravy added a comment to D66401: [TargetMachine] Don't try to create COFFSTUB references on windows on non-COFF.

Thanks Martin for the quick response and fix. My minimal test-case works and I am in the progress of testing our full build.

Aug 20 2019, 4:11 AM · Restricted Project

Aug 18 2019

Herald added a project to D51590: [MinGW] Move code for indicating "potentially not DSO local" into shouldAssumeDSOLocal. NFCI.: Restricted Project.

This broke Julia downstream (https://github.com/JuliaLang/julia/pull/32712#issuecomment-521206577). In Julia we emit JIT'ed code on MINGW as ELF+Static relocation model (https://github.com/JuliaLang/julia/blob/be3b04b29654a463b4dc899a228b5f53e862cdde/src/codegen.cpp#L7653-L7669), due us having issues with COFF support in RuntimeDyld.

Aug 18 2019, 3:30 AM · Restricted Project

May 5 2019

Herald added a project to D50929: [llvm-mca] Introduce the llvm-mca library and organize the directory accordingly. NFC.: Restricted Project.
May 5 2019, 12:23 PM · Restricted Project

Jul 23 2018

vchuravy accepted D44892: Add PerfJITEventListener for perf profiling support..

It indeed does! Thanks!

Jul 23 2018, 9:48 AM · Restricted Project