- User Since
- Nov 12 2013, 11:44 AM (488 w, 2 d)
Feb 1 2023
Nov 2 2022
Oct 31 2022
Oct 25 2022
Oct 21 2022
Oct 18 2022
- Remove bulk-memory and nontrapping-fptoint.
- Add a comment about what "generic" means.
Oct 17 2022
- Merge the comments for heap_base and heap_end.
Oct 14 2022
Oct 13 2022
- Address review feedback
- Fix indentation.
- Use a memory location instead of a wasm global, and support threads.
- Use llvm-objdump -d in tests.
Aug 31 2022
Instead of adding new test files, add tests to existing test files.
Aug 20 2022
Aug 15 2022
In curious why memorytExports is a set of strings rather than an optional string. Is there a need for exporting the memory with multiple names?
Jul 20 2022
Jul 19 2022
LGTM too. For testing, I think it would work to make a copy of llvm/test/CodeGen/WebAssembly/tls-local-exec.ll and change its thread_local(localexec)s to thread_locals.
Jun 29 2022
Jun 27 2022
Jun 15 2022
Jun 1 2022
May 31 2022
May 20 2022
Update tests to use -mcpu=mvp to avoid breaking their target features when -mcpu=generic changes. And update target-features.ll to for the new -mcpu=generic features.
Add tests for -mcpu=mvp and -mcpu=bleeding-edge.
Add a driver test, and add release notes.
May 16 2022
Mar 14 2022
Mar 9 2022
The overall approach here makes sense to me. The tests test/CodeGen/WebAssembly/global_dtors.ll and test/CodeGen/WebAssembly/lower-global-dtors.ll cover the main interesting corner cases that we've hit with this pass; they currently have wasm targets and wasm-specific CHECK lines, but could likely be ported to other targets.
Jul 21 2021
Looks good to me too!
Jul 9 2021
Jun 23 2021
Do we still intend to unify Emscripten's ABI with wasm32-unknown-unknown or wasm32-wasi eventually? This is talking a step away from that.
May 6 2021
Apr 28 2021
Looking at the ld documentation for export-dynamic-symbol:
I'm a little confused by the name "export-dynamic-symbol". I understand it's an ELF flag, though it seems to have a slightly different meaning here. What would you think about adding a warning when using this flag is -experimental-pic isn't passed, similar to what we do with -shared?
Apr 13 2021
Great, thanks! And yes, switching to roundeven for both scalar and SIMD ISel sounds right to me.
This looks good to me! Could you briefly comment here on what the issue with llvm.roundeven is?
Feb 26 2021
Feb 25 2021
Feb 11 2021
Feb 10 2021
I don't see a way to do this with weak symbols, and an install script would be yet-another moving part that we'd have to make on end-user systems.
It's to ensure that older LLVM works with newer WASI libc, and newer clang works with older WASI libc. New-style commands require [lld support]. We can assume that if clang is updated, lld has the requisite support.
Feb 4 2021
Jan 4 2021
Oct 13 2020
Abandoned in favor of https://reviews.llvm.org/D89290 .
Oct 12 2020
Either patch works for me. Yours is shorter :-).
LGTM; thanks for fixing this!
I've finished addressing the review comments, so this is now ready for review again.
Sep 30 2020
Address review feedback.
Thanks! Description updated, fixes applied, and landed in https://reviews.llvm.org/rG6cd8511e5932