- User Since
- Nov 12 2013, 11:44 AM (395 w, 4 d)
May 6 2021
Apr 28 2021
Looking at the ld documentation for export-dynamic-symbol:
I'm a little confused by the name "export-dynamic-symbol". I understand it's an ELF flag, though it seems to have a slightly different meaning here. What would you think about adding a warning when using this flag is -experimental-pic isn't passed, similar to what we do with -shared?
Apr 13 2021
Great, thanks! And yes, switching to roundeven for both scalar and SIMD ISel sounds right to me.
This looks good to me! Could you briefly comment here on what the issue with llvm.roundeven is?
Feb 26 2021
Feb 25 2021
Feb 11 2021
Feb 10 2021
I don't see a way to do this with weak symbols, and an install script would be yet-another moving part that we'd have to make on end-user systems.
It's to ensure that older LLVM works with newer WASI libc, and newer clang works with older WASI libc. New-style commands require [lld support]. We can assume that if clang is updated, lld has the requisite support.
Feb 4 2021
Jan 4 2021
Oct 13 2020
Abandoned in favor of https://reviews.llvm.org/D89290 .
Oct 12 2020
Either patch works for me. Yours is shorter :-).
LGTM; thanks for fixing this!
I've finished addressing the review comments, so this is now ready for review again.
Sep 30 2020
Address review feedback.
Thanks! Description updated, fixes applied, and landed in https://reviews.llvm.org/rG6cd8511e5932
Aug 21 2020
Aug 5 2020
Ah, it seems the reason I didn't see this is that I wasn't using -flax-vector-conversions=none. Thanks for fixing this!
Aug 4 2020
I've now opened https://github.com/WebAssembly/wasi-sdk/pull/151/ to remove the --no-threads from wasi-sdk, which was a workaround for an old bug that has long been fixed.
Aug 3 2020
- Update clang/test/CodeGen/builtins-wasm.c.
Aug 2 2020
- Reorganize the code a little so that we don't have to call mark multiple times.
- Fix a bug where we weren't considering calls from constructors as keeping other constructors live.
- Add a few more tests.
Aug 1 2020
Jul 31 2020
Address review feedback.
Jun 25 2020
- Rename -emscripten-pic to -experimental-pic
- Change the warning text to say "not stable" rather than "not yet implemented"
Jun 16 2020
This change looks fine to me, though if you wanted to minimize the amount of code being emitted by the linker, another option would be to look into whether LLVM's FixFunctionBitcasts could handle this -- there should be a bitcast in the llvm.global_ctors array.
Jun 12 2020
Landed in 66042959590d6db9d2a12803a16476d4e3508f3f.
- Address review feedback
- Mark callCtors live in the MarkLive pass rather than in the Writer pass.
Run clang-format and fix lint warnings.
Use the return value of handleUndefined instead of doing a separate lookup, which avoids a redundant lookup and handles LazySymbols properly.
Jun 11 2020
Jun 4 2020
Jun 3 2020
I apologize again for the major delay. I've now updated the patch and addressed all of your comments.
- Add tests for redeclaration behavior
- Remove disabled tests (previously marked with FIXMEs)
- Made the mismatch warning more informative.
May 11 2020
Looks good to me.
Apr 23 2020
Apr 13 2020
This addresses the review feedback from earlier. To answer this question:
Rebase, update, add a test, and add basic error reporting.
Apr 11 2020
Looks good! I don't have anything to add beyond Thomas' review comments.
Apr 7 2020
Apr 6 2020
Apr 4 2020
On some 32-bit x86 hosts, particularly those that use x87 arithmetic, loading and storing with floating-point types can change the NaN bit pattern. To preserve the bit pattern reliably, MCOperand should represent floating-point immediates by representing the bits in int32_t for 32-bit and int64_t for 64-bit. Codegen and MC don't usually look at the value, but where they do need to interpret it as a floating-point value, they can reinterpret the bits on demand.
Mar 30 2020
Cool, LGTM, with optional suggestion for signed char below:
Mar 27 2020
Very cool, thanks for putting this together!
Mar 26 2020
Instead of creating a new LLVM-IR-level attribute here, could you have clang translate the attribute to "wasm-export-name", to keep the LLVM-IR level simpler?
Mar 18 2020
The commit description says "not ordered to group destructors with common associated objects" but it looks this patch is doing grouping by associated object. Is that intentional?
- Add a comment.
- Add a test of two destructors with different priorities and the same associated object.
Feb 19 2020
Looks good, with the clang-format lint fixed :-).
Jan 15 2020
@sbc100 Friendly ping :-).
Jan 13 2020
Dec 21 2019
Address review feedback.
I apologize for the extraordinary delays here; at long last, I've now addressed your feedback.
Dec 20 2019
To support a transition to the new system, temporarily define a __main_void alias for no-argument main. This allows libc to detect whether it's calling old-style or new-style main and do the right thing.
Dec 17 2019
This updates the main vs __main_argc_argv patch so that it doesn't apply to Emscripten targets, following the discussion in https://github.com/WebAssembly/tool-conventions/pull/134.
Dec 16 2019
Nov 27 2019
Nov 26 2019
I've done some more experimenting with this, and it turns out not to work very well, because calls to these functions get generated after LTO runs, so I'll abandon this.