Page MenuHomePhabricator

sunfish (Dan Gohman)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2013, 11:44 AM (275 w, 3 d)

Recent Activity

Thu, Feb 7

sunfish added a comment to D57874: [WebAssembly] Make thread-related options consistent.
  • -matomics means -mthread-model posix
Thu, Feb 7, 5:05 PM · Restricted Project, Restricted Project
sunfish committed rGe086afa7a313: [WebAssembly] Update test output after rL353474. NFC. (authored by sunfish).
[WebAssembly] Update test output after rL353474. NFC.
Thu, Feb 7, 2:35 PM
sunfish committed rG29874cea31ce: [WebAssembly] Fix imported function symbol names that differ from their import… (authored by sunfish).
[WebAssembly] Fix imported function symbol names that differ from their import…
Thu, Feb 7, 2:04 PM
sunfish committed rG9b84eeaa3ee8: [WebAssembly] Fix imported function symbol names that differ from their import… (authored by sunfish).
[WebAssembly] Fix imported function symbol names that differ from their import…
Thu, Feb 7, 2:01 PM
sunfish added a comment to D57874: [WebAssembly] Make thread-related options consistent.

That sounds reasonable to me too.

Thu, Feb 7, 11:34 AM · Restricted Project, Restricted Project
sunfish added a comment to D57632: [WebAssembly] Fix imported function symbol names that differ from their import names in the .o format.

Looking good.

Can we can a test in the MC/WebAssembly and lld/test/wasm?

Thu, Feb 7, 11:31 AM · Restricted Project
sunfish updated the diff for D57632: [WebAssembly] Fix imported function symbol names that differ from their import names in the .o format.
  • Add MC/WebAssembly and lld tests
  • Set the WASM_SYMBOL_NAME_EXPLICIT flag when a symbols name differs from its import name.
Thu, Feb 7, 11:31 AM · Restricted Project

Tue, Feb 5

sunfish added inline comments to D57620: Optimize printf calls that don't use 128-bit floating-point values.
Tue, Feb 5, 5:58 AM · Restricted Project

Mon, Feb 4

sunfish updated the diff for D57620: Optimize printf calls that don't use 128-bit floating-point values.
  • Rename printf_no_Lf to __small_printf.
  • Add more tests.
  • Split out enabling the iprintf optimization for WASI, to be submitted in a separate patch later.
Mon, Feb 4, 5:34 PM · Restricted Project
sunfish planned changes to D57620: Optimize printf calls that don't use 128-bit floating-point values.
Mon, Feb 4, 5:34 PM · Restricted Project
sunfish updated the diff for D57632: [WebAssembly] Fix imported function symbol names that differ from their import names in the .o format.
  • Use a symbol flag to indicate when a custom symbol name is present.
  • Revert the version number bump.
  • Allow globals and events to have custom symbol names too, for consistency.
Mon, Feb 4, 3:13 PM · Restricted Project

Fri, Feb 1

sunfish created D57632: [WebAssembly] Fix imported function symbol names that differ from their import names in the .o format.
Fri, Feb 1, 5:12 PM · Restricted Project
sunfish created D57620: Optimize printf calls that don't use 128-bit floating-point values.
Fri, Feb 1, 2:24 PM · Restricted Project
sunfish added a comment to D57602: [WebAssembly] Add an import_field function attribute.

Do you could also achieve this I guess by renaming pwsix.read function itself to pwsix.__read? But I guess it makes sense to allow the use to control all 3 parts of the name separately.

Fri, Feb 1, 12:02 PM · Restricted Project, Restricted Project
sunfish created D57603: [WebAssembly] Add codegen support for the import_field attribute.
Fri, Feb 1, 10:38 AM · Restricted Project
sunfish created D57602: [WebAssembly] Add an import_field function attribute.
Fri, Feb 1, 10:32 AM · Restricted Project, Restricted Project
sunfish added a comment to D57577: Make predefined FLT16 macros conditional on support for the type.

I think WebAssembly is in the same situation as most other architectures, as discussed here:

Fri, Feb 1, 7:00 AM · Restricted Project, Restricted Project

Mon, Jan 28

sunfish added a comment to D57323: [WebAssembly] Enable main-function signature rewriting for WASI.
Mon, Jan 28, 4:45 PM
sunfish updated the diff for D57323: [WebAssembly] Enable main-function signature rewriting for WASI.
  • Remove the target constraint, allowing the main rewrite logic to work on all wasm32 targets.
  • Remove the now-unneeded "wasm-temporary-workarounds" flag altogether.
  • This uncovered some bugs with wrappers for main when main is only a declaration; fix those as well.
Mon, Jan 28, 4:40 PM
sunfish added a comment to D57323: [WebAssembly] Enable main-function signature rewriting for WASI.

I mean with your fix we don't need this to be wasi specific do we?

Mon, Jan 28, 3:37 PM
sunfish added a comment to D57323: [WebAssembly] Enable main-function signature rewriting for WASI.

I tried to enable this by default recently but had to revert: https://reviews.llvm.org/D54117.

I'm fine for this to land in the mean time but you might want to be aware of this issue.

Mon, Jan 28, 2:06 PM
sunfish created D57323: [WebAssembly] Enable main-function signature rewriting for WASI.
Mon, Jan 28, 5:19 AM

Thu, Jan 24

sunfish created D57160: [WebAssembly] Add an import_module function attribute.
Thu, Jan 24, 8:18 AM
sunfish updated the summary of D57155: [WebAssembly] Add a __wasi__ target macro.
Thu, Jan 24, 6:43 AM
sunfish created D57155: [WebAssembly] Add a __wasi__ target macro.
Thu, Jan 24, 6:43 AM
sunfish created D57154: [WebAssembly] Support __float128.
Thu, Jan 24, 6:37 AM
sunfish created D57153: [WebAssembly] Factor commonality between wasm32 and wasm64 in test/Preprocessor/init.c.
Thu, Jan 24, 6:35 AM

Jan 14 2019

sunfish accepted D56681: [WebAssembly] Update release notes.

LGTM.

Jan 14 2019, 6:03 PM
sunfish accepted D56091: [WebAssembly] Don't add IMPLICIT_DEFs in PrepareForLiveIntervals.

Sorry for the delay here. Yes, let's land this.

Jan 14 2019, 12:42 PM · Restricted Project
sunfish added a comment to D56553: [WebAssembly] Support multilibs for wasm32 and add a wasm OS that uses it.

Can you make change to llvm and clang at the same time? I thought that was not possible..

Jan 14 2019, 12:34 PM
sunfish added a comment to D56553: [WebAssembly] Support multilibs for wasm32 and add a wasm OS that uses it.

Title updated.

Jan 14 2019, 12:33 PM
sunfish retitled D56553: [WebAssembly] Support multilibs for wasm32 and add a wasm OS that uses it from [WebAssembly] Support multilibs for wasm32 to [WebAssembly] Support multilibs for wasm32 and add a wasm OS that uses it.
Jan 14 2019, 12:21 PM
sunfish added a comment to D56553: [WebAssembly] Support multilibs for wasm32 and add a wasm OS that uses it.

Or, here's another idea: What if we *just* add "include/wasm-$OS" and don't add "wasm32-$OS" or "wasm64-$OS"-specific include directories? Most headers for wasm will probably be shared between the two, and for anything that really can't be, we always have the __wasm32__ and __wasm64__ predefined macros.

Jan 14 2019, 12:13 PM
sunfish added a comment to D56553: [WebAssembly] Support multilibs for wasm32 and add a wasm OS that uses it.

One difference between the multilib style and multi-arch style is whether any headers can be shared between the 2 arches. Historically at least, with bitness-flavored variants of the same architecture there were common headers used by both, and it was just the library directories that needed to be different. I've heard anecdotally that this is not the case for ARM though.

Jan 14 2019, 12:08 PM
sunfish added a comment to D56553: [WebAssembly] Support multilibs for wasm32 and add a wasm OS that uses it.

Ooo - a new OS is born!

Jan 14 2019, 11:59 AM
sunfish updated the diff for D56553: [WebAssembly] Support multilibs for wasm32 and add a wasm OS that uses it.

Per @sbc100's comment, this update switches to full multilib paths.

Jan 14 2019, 10:22 AM
sunfish retitled D56553: [WebAssembly] Support multilibs for wasm32 and add a wasm OS that uses it from [WebAssembly] Change the default lib path for wasm32 to be lib32 to [WebAssembly] Support multilibs for wasm32.
Jan 14 2019, 10:20 AM
sunfish resigned from D41941: [WebAssembly] Change int_fast16_t to 32-bit.
Jan 14 2019, 8:17 AM

Jan 13 2019

sunfish created D56648: [WebAssembly] Add a release notes blurb.
Jan 13 2019, 3:55 AM
sunfish created D56645: [WebAssembly] Remove old intrinsics.
Jan 13 2019, 12:38 AM

Jan 10 2019

sunfish closed D43540: [WebAssembly] Enable -Werror=strict-prototypes by default.
Jan 10 2019, 11:11 AM
sunfish added a comment to D43540: [WebAssembly] Enable -Werror=strict-prototypes by default.

With https://reviews.llvm.org/D48471 and related work, it's not less urgent to do this. And since there were objections to having target-specific warnings anyway, let's close this.

Jan 10 2019, 11:10 AM
sunfish added a comment to D56094: [WebAssembly] Fix stack pointer store check in RegStackify.

@aheejin The issue is that the current code doesn't distinguish between reading and writing of the stack pointer. Calls don't effectively modify the stack pointer, but they do read the stack pointer. Instructions which modify the stack pointer shouldn't be reordered past calls.

Jan 10 2019, 10:55 AM
sunfish added a comment to D45796: [WebAssembly] Support imports from custom module names.

This patch has a review. Is it ready to land?

Jan 10 2019, 10:49 AM · Restricted Project
sunfish added a comment to D41941: [WebAssembly] Change int_fast16_t to 32-bit.

As @nw points out, clang's lib/Headers/stdint.h doesn't support this yet. Unless anyone feels strongly, I now propose we close this and just leave int_fast16_t/uint_fast16_t as-is.

Jan 10 2019, 10:49 AM
sunfish added a comment to D56553: [WebAssembly] Support multilibs for wasm32 and add a wasm OS that uses it.

From a survey and some testing, Emscripten doesn't appear to rely on these paths, so this just affects things like wasmception and the waterfall, which should be straightforward to update.

Jan 10 2019, 10:30 AM
sunfish created D56553: [WebAssembly] Support multilibs for wasm32 and add a wasm OS that uses it.
Jan 10 2019, 10:10 AM

Dec 13 2018

sunfish added a comment to D55467: [WebAssembly] Optimize Irreducible Control Flow.

Do we know what part of the optimizer or codegen is introducing the irreducible control flow in malloc?

Not for malloc - I think @jgravelle-google may have been looking into that though?

Dec 13 2018, 2:21 PM

Dec 10 2018

sunfish added a comment to D55467: [WebAssembly] Optimize Irreducible Control Flow.

Do we know what part of the optimizer or codegen is introducing the irreducible control flow in malloc?

Dec 10 2018, 2:13 PM

Nov 13 2018

sunfish added inline comments to D54249: [WebAssembly] Initial support for shared objects (-shared).
Nov 13 2018, 12:39 PM
sunfish added a comment to rL346773: [WebAssembly] Mark immediates.ll as XFAILed on MIPS hosts.

-mnan and --with-nan= are MIPS target options, however I'm asking about targeting WebAssembly with a MIPS host.

Nov 13 2018, 11:38 AM
sunfish added a comment to rL346773: [WebAssembly] Mark immediates.ll as XFAILed on MIPS hosts.

If I write C code like this:

Nov 13 2018, 11:04 AM

Nov 11 2018

sunfish added inline comments to D54287: [WebAssembly] Implement TargetLowering hooks for vectors.
Nov 11 2018, 6:45 PM

Oct 18 2018

sunfish added a comment to D53396: [WebAssembly] Fixup main signature by default.

Can we remove the optional altogether now, and just always do the fixup?

Oct 18 2018, 7:01 AM

Oct 3 2018

sunfish accepted D52580: Refactor WasmSignature and use it for MCSymbolWasm.

LGTM. In the future it's possible we could need to hold the signatures somewhere other than the AsmPrinter, however we can figure that out later, when it's more clear what the MC AsmParser layer will need.

Oct 3 2018, 2:36 PM

Sep 27 2018

sunfish added a comment to D52450: [Intrinsic] Add llvm.minnan and llvm.maxnan instrinsic functions.

That's true, except that if the semantics of the LLVM intrinsics were not as strict as the semantics of the WebAssembly instructions, then there would be no way for programmers to access WebAssembly's exact semantics at the source level, which is the whole point of implementing these intrinsics at all.

Sep 27 2018, 4:45 PM
sunfish added a comment to D52450: [Intrinsic] Add llvm.minnan and llvm.maxnan instrinsic functions.

WebAssembly's handling of +0/-0 *does* match IEEE 754-2018, so these intrinsics (whether target-independent or not) need to be changed to match those semantics as well. I will have to investigate whether the fminnan and fmaxnan ISel DAG nodes are already being used in ways that do not respect these semantics. If they are, we will need new ISel DAG nodes as well.

Sep 27 2018, 3:03 PM
sunfish added inline comments to D52580: Refactor WasmSignature and use it for MCSymbolWasm.
Sep 27 2018, 12:21 PM
sunfish added inline comments to D52450: [Intrinsic] Add llvm.minnan and llvm.maxnan instrinsic functions.
Sep 27 2018, 9:57 AM

Sep 24 2018

sunfish added a comment to D52372: [WebAssembly] SIMD conversions.
  1. Is it correct to translate those llvm instructions to saturating versions of wasm instructions? For example, for scalars, we had a patch that implemented the saturating behavior. Don't we need a similar thing for vectors too?
Sep 24 2018, 5:20 PM

Sep 21 2018

sunfish added a comment to D43675: [WebAssembly] Rename imported/exported memory symbol to __linear_memory.

The prompt here is that the LLVM wasm backend will be leaving "experimental" status. That means in about 6 months, it'll be part of an LLVM release. Once that happens, it'll be harder to make changes like this.

Sep 21 2018, 9:26 AM

Sep 20 2018

sunfish added a comment to D43211: [WebAssembly] promote from experimental to normal target.

Woah! This a big step people! Congratulations.

Sep 20 2018, 8:34 PM
sunfish added a comment to D43675: [WebAssembly] Rename imported/exported memory symbol to __linear_memory.

@sbc100 @ncw Can you comment on the status of this issue? Is this still something we want to fix before we consider the basic ABI to be basically stable?

Sep 20 2018, 4:27 PM
sunfish updated subscribers of D43211: [WebAssembly] promote from experimental to normal target.

https://reviews.llvm.org/D50568 is now fixed!

Sep 20 2018, 4:22 PM

Sep 4 2018

sunfish added a comment to D51447: [WebAssembly] clang-format (NFC).

On one hand, clang-format -style=LLVM really isn't the one exclusive formatting style of LLVM. CodingStandards.rst repeatedly emphasizes this. When we're working in LLVM outside of wasm-specific code, we need to respect the existing code formatting which isn't always clang-formatted, or locally reformat it as needed when making changes, so it's not a bad idea for us to get used to working that way anyway. And we accept patches that aren't clang-formatted.

Sep 4 2018, 2:53 PM

Aug 29 2018

sunfish added a comment to D51447: [WebAssembly] clang-format (NFC).

I guess I don't have a strong opinion here. The code is already pretty close to clang-format's interpretation of LLVM style, so looking at the actual diffs you're right that it doesn't seem to be a big change. Changes like those in WebAssemblyLowerBrUnless.cpp are a little unfortunate, but tolerable.

Aug 29 2018, 1:23 PM
sunfish added a comment to D51447: [WebAssembly] clang-format (NFC).

The LLVM coding standards say "we explicitly do not want patches that do large-scale reformatting of existing code". They suggest that reformatting should be done to address specific readability issues or to prepare an area for subsequent changes.

Aug 29 2018, 11:50 AM

Aug 22 2018

sunfish added a comment to D50277: [WebAssembly] Support for atomic fences.

We discussed how to implement fences here, and I think the general consensus was even though it may not be strictly necessary to emit atomicrmw for some cases, it can be user friendly and also might help support legacy builtins like __sync_synchronize(). And IMHO it is a single instruction anyway and fences are generally expected to be expensive, so no significant harm will be done. Does anyone have more concerns on this? If not, can we land this?

Aug 22 2018, 4:15 PM · Restricted Project

Aug 16 2018

sunfish accepted D48273: [WebAssembly] CFG stackify support for exception handling.

This looks ok to land now.

Aug 16 2018, 3:58 PM

Aug 8 2018

sunfish added a comment to D40526: [WebAssembly] Change size_t to `unsigned long`.

Is this related to the issue reported in the thread here?

Aug 8 2018, 10:32 AM

Jul 24 2018

sunfish accepted D44030: [WebAssembly] Tidy up handling of global symbol relocations.

First, I apologize, I'm not sure how I lost track of this patch and didn't see the pings.

Jul 24 2018, 9:42 PM
sunfish added a comment to D43211: [WebAssembly] promote from experimental to normal target.

https://reviews.llvm.org/D40526 has now landed. Is there anything else we should do before leaving "experimental" status?

Jul 24 2018, 9:34 PM

Jul 23 2018

sunfish added a comment to D49517: [WebAssembly] Ensure all bitcasts that would be invalid in wasm are removed by FixFunctionBitcasts pass.

Interesting, so you are proposing delaying the error until link time but still producing a valid wasm binary?

Jul 23 2018, 5:56 PM
sunfish added a comment to D49194: [WebAssembly] Add tests for weaker memory consistency orderings.
In D49194#1172051, @jfb wrote:

I have a talk for you! https://youtu.be/IB57wIf9W1k?t=52m20s
I talk about volatile in a few places, but 52m20s is the main one. Basically I'm advocating for something similar to the weird MSVC x86 volatile behavior because some users write code like a loop which updates a volatile variable which another thread reads, and expect it to stay in the loop (not hoisted out). Lowering to regular load / store breaks the guarantee that volatiles effects touch the variable's bytes once per source event. Such user code should really use atomic, but we don't need to be pedants about it.

Jul 23 2018, 3:09 PM
sunfish added a comment to D49194: [WebAssembly] Add tests for weaker memory consistency orderings.
In D49194#1170428, @jfb wrote:

For the record, I'm opposed to having the WebAssembly backend translate asm volatile(""::: "memory") differently from other targets in LLVM or GCC, which to my knowledge always translate it to a no-op, even on platforms with hardware fence instructions.

I think it should lower and not error out, and thought should be put into what it should lower to. No-op seems fine to me, but I'd like to hear a rationale.

Jul 23 2018, 10:15 AM

Jul 20 2018

sunfish added a comment to D49194: [WebAssembly] Add tests for weaker memory consistency orderings.

For the record, I'm opposed to having the WebAssembly backend translate asm volatile(""::: "memory") differently from other targets in LLVM or GCC, which to my knowledge always translate it to a no-op, even on platforms with hardware fence instructions.

Jul 20 2018, 1:40 PM
sunfish added a comment to D49517: [WebAssembly] Ensure all bitcasts that would be invalid in wasm are removed by FixFunctionBitcasts pass.

Ah, that's useful context, thanks. That'd be good to mention in the commit message and/or comments somewhere. Also, please add a testcase which approximates that use case.

Jul 20 2018, 1:34 PM

Jul 19 2018

sunfish requested changes to D49517: [WebAssembly] Ensure all bitcasts that would be invalid in wasm are removed by FixFunctionBitcasts pass.

Not all types are valid to cast to all other types. But beyond that, normal native platforms don't insert non-trivial casts in such situations, so even in many cases where it's valid to cast, it doesn't seem like programmers could reasonably expect a non-trivial cast to happen. What kinds of use cases are motivating this?

Jul 19 2018, 1:06 PM

Jul 17 2018

sunfish added a comment to D48985: [WebAssembly] Converted to stack based instructions in MC..

I'm not deeply familiar with MC's Asm parsing support, but this looks like a good direction to go.

Jul 17 2018, 3:43 PM

Jul 11 2018

sunfish accepted D46500: [WebAssembly] CFG sort support for exception handling.
Jul 11 2018, 10:06 AM

Jul 10 2018

sunfish added a comment to D40526: [WebAssembly] Change size_t to `unsigned long`.

I've now refreshed the emscripten patches and am hoping they can land soon.

Jul 10 2018, 4:28 PM
sunfish added a comment to D43211: [WebAssembly] promote from experimental to normal target.

Indeed; after discussing this with a few other folks, I think this is getting close.

Jul 10 2018, 3:56 PM

Jun 25 2018

sunfish accepted D48471: [WebAssembly] Add pass to infer prototypes for prototype-less functions.

My biggest concern here is that this pass shouldn't affect prototype-possessing functions, and that appears to be satisfied :-).

Jun 25 2018, 8:36 AM

Jun 22 2018

sunfish accepted D48443: [WebAssembly] Add no-prototype attribute to prototype-less C functions.

I haven't thought through all the possibilities related to !FD->doesThisDeclarationHaveABody(), but overall this looks good.

Jun 22 2018, 2:18 PM

May 30 2018

sunfish added a comment to D46805: If some platforms do not support an attribute, we should exclude the platform.

@rsmith -- do the object file formats listed look correct to you?

They look at least plausible. We should be able to test whether LLVM can actually emit aliases on each of these targets easily enough...

However, I get this error for any WAsm compilation I try:

fatal error: error in backend: section size does not fit in a uint32_t

... so I have no idea if aliases are/will be supported there. Perhaps @sunfish can tell us :)

May 30 2018, 5:46 PM

May 18 2018

sunfish added a comment to D47006: [NFC] fix getOperandNo in PredIterator..

This looks right to me, but just to make sure I understand, has this been broken since r228400?

May 18 2018, 1:31 PM

Apr 9 2018

sunfish accepted D44873: [WebAssembly] Change std::sort to llvm::sort in response to r327219.

LGTM.

Apr 9 2018, 11:25 AM

Apr 4 2018

sunfish accepted D45297: [WebAssembly] Allow for the creation of user-defined custom sections.

Looks good to me. Thanks!

Apr 4 2018, 4:17 PM

Mar 8 2018

sunfish added a comment to D43097: [WebAssembly] Allow for the creation of user-defined custom sections.

This user-defined custom sections patch should be ready to go now.

Mar 8 2018, 12:26 PM
sunfish added reviewers for D43097: [WebAssembly] Allow for the creation of user-defined custom sections: sbc100, ncw.
Mar 8 2018, 12:25 PM

Mar 2 2018

sunfish added a comment to D40526: [WebAssembly] Change size_t to `unsigned long`.

We want to coordinate landing this with corresponding changes in Emscripten. Since this is an ABI change, Emscripten needs to figure out how to manage it. See here for ongoing discussion.

Mar 2 2018, 11:11 AM
sunfish added a comment to D43211: [WebAssembly] promote from experimental to normal target.

Indeed; I don't anticipate LLVM will be using mem.grow or mem.size itself. But, clang has __builtin_wasm_mem_grow and __builtin_wasm_mem_size, to allow standard libraries to use them. It's desirable that the names of these builtins, and the corresponding LLVM IR intrinsics, match the names in the official WebAssembly documentation.

Mar 2 2018, 10:57 AM

Feb 27 2018

sunfish added a comment to D43211: [WebAssembly] promote from experimental to normal target.

We should probably also wait for the WebAssembly committee to settle on final instruction names.

Feb 27 2018, 6:22 AM

Feb 23 2018

sunfish added a comment to D43675: [WebAssembly] Rename imported/exported memory symbol to __linear_memory.

I'm not very familiar with the Emscripten parts of this, but some grepping in the emscripten tree found these lines:

src/preamble.js:    env['memory'] = Module['wasmMemory'];
src/preamble.js:    env['memory'] = providedBuffer;
src/preamble.js:    assert(env['memory'] instanceof ArrayBuffer);
Feb 23 2018, 9:09 AM

Feb 20 2018

sunfish created D43540: [WebAssembly] Enable -Werror=strict-prototypes by default.
Feb 20 2018, 5:21 PM

Feb 15 2018

sunfish added a comment to D43212: [WebAssembly] Update ADT/TripleTest.cpp now that default file format has changed.

The new tests look good, but it'd be good to keep testing "wasm32-unknown-unknown-wasm" and "wasm64-unknown-unknown-wasm" here too.

Feb 15 2018, 10:09 AM

Feb 12 2018

sunfish added a comment to rL324966: [WebAssembly] Update ADT/TripleTest.cpp now that default file format has changed.

Please restore the "-wasm" forms of these tests too.

Feb 12 2018, 3:55 PM
sunfish accepted D43212: [WebAssembly] Update ADT/TripleTest.cpp now that default file format has changed.

The new tests look good, but it'd be good to keep testing "wasm32-unknown-unknown-wasm" and "wasm64-unknown-unknown-wasm" here too.

Feb 12 2018, 3:51 PM
sunfish added a reviewer for D43211: [WebAssembly] promote from experimental to normal target: sunfish.

I think it's getting closer. IMO we should at least land https://reviews.llvm.org/D43147 and https://reviews.llvm.org/D40526 first, and address any follow-up issues.

Feb 12 2018, 3:14 PM

Feb 9 2018

sunfish added a comment to D43097: [WebAssembly] Allow for the creation of user-defined custom sections.

I think it's because writeBytes is defined to be passed data from an MCFragment's getContents(), which is a SmallVectorImpl<char>. That's the case here too, though the code that does the getContents() is a little separated from the writeBytes. Following @ncw's suggestion, I created a struct type, which not only avoids repeating the type name, but also makes the use of it cleaner than std::pair.

Feb 9 2018, 2:58 PM