Page MenuHomePhabricator

[OpenMP][IR-Builder] Introduce "pragma omp parallel" code generation
ClosedPublic

Authored by jdoerfert on Nov 11 2019, 10:25 PM.

Details

Summary

This patch combines the emitParallel logic prototyped in D61953 with
the OpenMPIRBuilder (D69785) and introduces CreateParallel.

Diff Detail

Event Timeline

jdoerfert created this revision.Nov 11 2019, 10:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 11 2019, 10:25 PM

This needs an update later today.

Add more tests and a version working with the clang integration (next patch)

Generally acceptable, However wondering about future plans regarding:

  1. There are many aspects of the OMP parallel implementation that can be reused with other directives (i.e. 'If' clause, privatization clauses), any plans to outline?
  2. plans for implementing reduction clause?

Apologies I screwed my Herald rule!

Generally acceptable, However wondering about future plans regarding:

  1. There are many aspects of the OMP parallel implementation that can be reused with other directives (i.e. 'If' clause, privatization clauses), any plans to outline?
  2. plans for implementing reduction clause?

We will outline as soon as the second use case comes in. We will need to add reductions, in a follow up.

fghanim accepted this revision.Nov 20 2019, 11:39 AM
This revision is now accepted and ready to land.Nov 20 2019, 11:39 AM
This revision was automatically updated to reflect the committed changes.