- User Since
- Jan 8 2015, 1:53 PM (209 w, 5 d)
Mon, Jan 14
Fri, Dec 21
Fixed a typo.
Nice. Thank you for adding the tests.
Wed, Dec 19
The tests you have only check the end result and do not directly verify the new functionality the patch adds.
Tue, Dec 18
You probably want to remove libcalls.patch from the patch diff.
Dec 14 2018
Dec 13 2018
Dec 12 2018
Dec 11 2018
Dec 7 2018
jlebar@ LGTM'ed via email.
Landed in rL348662
Here the behaviour of unsupported instructions is changed to match the behaviour of explicit intrinsics calls.
Dec 6 2018
Dec 5 2018
Dec 4 2018
It appears that what you're trying to do is to add "/usr/lib/cuda" on Ubuntu and Debian when --cuda-path=/usr is specified.
This is a rather odd thing to do. In the end only one of those paths will be in effect and that's the path that should be specified via --cuda-path. The fact that you want to add /usr/cuda/lib in this case suggests that /usr is the wrong path and /usr/lib/cuda is the correct one. It sounds like you need to change your build system and tell clang the correct path.
I'm not sure that's something that needs to be fixed in clang.
Nov 30 2018
Nov 15 2018
Nov 13 2018
Do I understand it correctly that the bug appears to affect HIP compilation only?
Nov 9 2018
Nov 6 2018
I'm not convinced that nvcc's behavior is a good guide for clang's defaults.
Oct 24 2018
Oct 22 2018
Oct 5 2018
This particular change is largely cosmetic. I've just spotted this nit while I was debugging a different problem.
Oct 2 2018
Oct 1 2018
Sep 25 2018
It's unfortunate that lit does not scrub the environment in order to make tests hermetic.
Sep 24 2018
Great to see someone beating me to add support for a new CUDA version. :-)
I've posted my patch in D52438. It's very similar to yours with a couple of other necessary changes.
Sep 21 2018
Overall the patch look OK. I'll take a closer look on Monday.
Added '>=' and '>>=' to the list of tokens that may indicate the end of the
empty template argument list.
Sep 20 2018
Sep 19 2018
The patch does not seem to match the description and appears to have nothing to do with rearranging include paths. Could you check if these are the changes you intended to send for review.
Sep 18 2018
Renamed last instance of 'Matches' -> 'PreventedBy'.
Updated assertion message.
Sep 17 2018
- Check that D is non-null
Addressed Richard's comments.
Moved clang-tidy changes into separate review D52179.
Sep 13 2018
Sep 7 2018
@jlebar Justin, can you take a look?
Sep 4 2018
Updated the changes according to Matthias' comments.
How about D51663?
Your patch above *almost* works, except that each test variant wants to create the same symlink $BUILD/ExternalCUDA/$TEST.teferece_output -> $SRC/External/CUDA/$TEST.reference_output. If symlinks are created at different points in time ninja manages to avoid conflicts, but typically I get one or two attempts to create the symlink launches simultaneously and one of them fails with "symlink already exists". Perhaps the symlink target name should be uniquified in some way.