- User Since
- Jan 8 2015, 1:53 PM (166 w, 6 d)
Fixed intrinsic names in clang's test.
Wrapped long lines, fixed whitespace and formatting issues.
Mon, Mar 19
Wow. There were 50 patches in the stack. Thank you, again, for making tablegen better.
Thu, Mar 15
Wed, Mar 14
Just in time. :-) I've ran into the broken foreach-in-multiclass yesterday.
You may want to split the patch into smaller pieces -- per leaf directory, for example.
That way potential reviewers would at least be able to see the changes (hundreds of files in one patch is a bit too much), and the subset of changes would be small enough for someone to own it (or at least familiar enough with it to give approval).
Tue, Mar 13
The patch is no longer needed after recent tablegen improvements by @nhaehnle.
This change is no longer needed due to the recent improvements in tablegen made by @nhaehnle.
Removed temp vars that are no longer needed after recent tblgen improvements.
Fri, Mar 9
What happens now when someone attempts to cast a variable name?
Will the !cast remain unresolved or will we see a "symbol X not found" error? Both would be somewhat confusing as that X may be something that is obviously there (e.g. template parameter). I'd rather see an explicit error telling me exactly what's wrong. Something like "!cast to a local symbol is not allowed".
Wed, Mar 7
This change should come with an update to the docs.
Tue, Mar 6
One test nit. Perhaps should be fixed in a separate patch before this one. LGTM otherwise.
Mon, Mar 5
One nit. LGTM otherwise.
LGTM. Few minor style questions.
Thu, Mar 1
Wed, Feb 28
Test nit. LGTM otherwise.
Tue, Feb 27
Mon, Feb 26
Great! Thank you for including different uses of NAME inside a multiclass.
Yay! Another of my favorite complaints about tablegen will be gone! Thank you!
Looks good overall, except for that concern about static pool and using tablegen as a library.
Few minor nits/suggestions. LGTM otherwise.
Fri, Feb 23
My brain is fried by now. I'll get back to this patch on Monday.
I'm glad the tests work now, though I suspect it's mostly due to your other changes.
Few nits on the test. LGTM otherwise.
Hooray! Now we'll have proper temp variables in !foreach !
The change looks good to me, but you should get OK from someone familiar with the back-end.
Thu, Feb 22
I'd fold D43561 into this patch.
Upon review of D43562 I think this patch should be folded into it -- it's just a small part of removing resolveListElementReference().
Please add more details. Description says what the patch does, but not why. There must be the reason for this change, but I can only guess what it is.
The major difference appears to be that now we do call resolveReferences() for each element, while resolveElementReferences() in the old code effectively just returns getElement(i). If resolving references is the purpose of the change, then patch description should reflect that. Also, if that's the case, perhaps it would be better to fix the problem in the List->resolveListElementReference() and make it actually do the reference resolution the name implies.