Page MenuHomePhabricator

modocache (Brian Gesiak)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 16 2014, 1:10 AM (257 w, 5 h)

Recent Activity

Thu, Jan 10

modocache added a comment to D56509: [AST] Remove ASTContext from getThisType (NFC).

Great, thanks for the review!

Thu, Jan 10, 7:16 PM
modocache committed rCTE350916: Adapt to CXXMethodDecl::getThisType change (NFC).
Adapt to CXXMethodDecl::getThisType change (NFC)
Thu, Jan 10, 6:16 PM
modocache committed rL350916: Adapt to CXXMethodDecl::getThisType change (NFC).
Adapt to CXXMethodDecl::getThisType change (NFC)
Thu, Jan 10, 6:16 PM
modocache committed rL350914: [AST] Remove ASTContext from getThisType (NFC).
[AST] Remove ASTContext from getThisType (NFC)
Thu, Jan 10, 5:58 PM
modocache committed rC350914: [AST] Remove ASTContext from getThisType (NFC).
[AST] Remove ASTContext from getThisType (NFC)
Thu, Jan 10, 5:58 PM
modocache closed D56509: [AST] Remove ASTContext from getThisType (NFC).
Thu, Jan 10, 5:58 PM

Wed, Jan 9

modocache updated the diff for D56243: [coroutines] Experimenting with __builtin_coro_frame_max_size.

Remove obsoleted code I accidentally included.

Wed, Jan 9, 12:31 PM
modocache updated the diff for D56243: [coroutines] Experimenting with __builtin_coro_frame_max_size.

Thanks for the offline review @GorNishanov! This revision allows constexpr usages of __builtin_coro_frame_max_size.

Wed, Jan 9, 12:28 PM
modocache created D56509: [AST] Remove ASTContext from getThisType (NFC).
Wed, Jan 9, 11:35 AM

Sun, Jan 6

modocache added a comment to D56271: [SemaCXX] Fix ICE for unexpanded parameter pack.

Thank you for the review!

Sun, Jan 6, 7:37 PM
modocache committed rC350501: [SemaCXX] Fix ICE for unexpanded parameter pack.
[SemaCXX] Fix ICE for unexpanded parameter pack
Sun, Jan 6, 7:30 PM
modocache committed rL350501: [SemaCXX] Fix ICE for unexpanded parameter pack.
[SemaCXX] Fix ICE for unexpanded parameter pack
Sun, Jan 6, 7:30 PM
modocache closed D56271: [SemaCXX] Fix ICE for unexpanded parameter pack.
Sun, Jan 6, 7:30 PM

Thu, Jan 3

modocache created D56271: [SemaCXX] Fix ICE for unexpanded parameter pack.
Thu, Jan 3, 7:31 AM

Wed, Jan 2

modocache created D56243: [coroutines] Experimenting with __builtin_coro_frame_max_size.
Wed, Jan 2, 8:48 PM

Fri, Dec 21

modocache requested changes to D55966: Ensure coro split pass only spills variables dominated by CoroBegin.

Excellent progress! Thanks for working on this.

Fri, Dec 21, 2:33 PM

Dec 19 2018

modocache added a comment to D55216: [bugpoint][PR29027] Reduce function attributes.

Thanks for the reviews, @reames! As a follow-up to this, I also have https://reviews.llvm.org/D55601 out for review, if you're interested -- it improves the reduction logic added in this patch.

Dec 19 2018, 6:11 AM

Dec 18 2018

modocache committed rL349601: [bugpoint][PR29027] Reduce function attributes.
[bugpoint][PR29027] Reduce function attributes
Dec 18 2018, 7:45 PM
modocache closed D55216: [bugpoint][PR29027] Reduce function attributes.
Dec 18 2018, 7:45 PM

Dec 17 2018

modocache added a comment to D55216: [bugpoint][PR29027] Reduce function attributes.

Friendly ping! I believe I addressed all of the code review comments. @MatzeB, you created the bug report https://bugs.llvm.org/show_bug.cgi?id=29027, is this implementation what you had in mind?

Dec 17 2018, 5:33 AM

Dec 12 2018

modocache created D55601: [bugpoint] Add ability to reduce to zero elements.
Dec 12 2018, 7:25 AM

Dec 11 2018

modocache accepted D55160: [coroutines] Improve suspend point simplification.

LGTM! As it happens I was reading this code the other day and wondering why it wasn't able to eliminate a suspend point I'd been looking at. I'll try it again and see if this new behavior is able to eliminate -- thanks!

Dec 11 2018, 7:54 AM

Dec 10 2018

modocache requested changes to D55160: [coroutines] Improve suspend point simplification.

Sorry for the wait! Mostly nits, but also I think the while condition might be inverted? It seems like, as is, it would never execute the body of the loop...?

Dec 10 2018, 6:43 PM

Dec 9 2018

modocache committed rL348734: [bugpoint] Find 'opt', etc., in bugpoint directory.
[bugpoint] Find 'opt', etc., in bugpoint directory
Dec 9 2018, 5:00 PM
modocache closed D54884: [bugpoint] Find 'opt', etc., in bugpoint directory.
Dec 9 2018, 5:00 PM
modocache committed rL348733: Re-commit "[IR] Add NODISCARD to attribute functions".
Re-commit "[IR] Add NODISCARD to attribute functions"
Dec 9 2018, 2:39 PM
modocache committed rL348732: [AMDGPU] Fix discarded result of addAttribute.
[AMDGPU] Fix discarded result of addAttribute
Dec 9 2018, 2:00 PM
modocache closed D55435: [AMDGPU] Fix discarded result of addAttribute.
Dec 9 2018, 2:00 PM
modocache added inline comments to D55216: [bugpoint][PR29027] Reduce function attributes.
Dec 9 2018, 10:21 AM
modocache updated the diff for D55216: [bugpoint][PR29027] Reduce function attributes.

Thanks for the review, @reames! I implemented each of your suggestions, but I had a small excuse for not using the variable name Suffix.

Dec 9 2018, 10:20 AM
modocache updated the diff for D55435: [AMDGPU] Fix discarded result of addAttribute.

I see, thanks @arsenm! I think this variable fits those criteria so I changed it back to using a dollar-sign prefix. Variable names notwithstanding, does the implementation change seem OK to everyone? It fixes what I believe is clearly a programming error. Landing this change will unblock me from LLVM_NODISCARD to these functions and so preventing another case of this same error.

Dec 9 2018, 9:03 AM
modocache updated the diff for D54884: [bugpoint] Find 'opt', etc., in bugpoint directory.

Search the bugpoint directory first, and only fall back to PATH if the program isn't there.

Dec 9 2018, 8:49 AM
modocache added a comment to D54884: [bugpoint] Find 'opt', etc., in bugpoint directory.

Thanks @MatzeB! I'll change this to search in the bugpoint directory first, and fall back to the PATH.

Dec 9 2018, 8:44 AM
modocache added inline comments to D55435: [AMDGPU] Fix discarded result of addAttribute.
Dec 9 2018, 8:15 AM
modocache updated the diff for D55435: [AMDGPU] Fix discarded result of addAttribute.

Thanks for the review, @nhaehnle! I changed the FileCheck variable NOUNWIND_READONLY to not use a dollar-sign prefix. I'm not sure why the other lines in this test do, but I left them alone for now. Any other suggestions for this, or is it good to go?

Dec 9 2018, 7:28 AM

Dec 7 2018

modocache created D55435: [AMDGPU] Fix discarded result of addAttribute.
Dec 7 2018, 7:10 AM

Dec 5 2018

modocache committed rL348375: Revert "[IR] Add NODISCARD to attribute functions".
Revert "[IR] Add NODISCARD to attribute functions"
Dec 5 2018, 7:59 AM
modocache added a comment to D55217: [IR] Add NODISCARD to attribute functions.

Oops, sorry, I didn't check hard enough. There's code for AMDGPU that runs up against this warning, causing some buildbots to fail: http://lab.llvm.org:8011/builders/lld-perf-testsuite/builds/9637/steps/build-bin%2Flld/logs/stdio

Dec 5 2018, 7:55 AM
modocache added a comment to D55217: [IR] Add NODISCARD to attribute functions.

Thanks! Yup, I confirmed no new warnings when building check-llvm and check-clang.

Dec 5 2018, 7:45 AM
modocache committed rL348372: [IR] Add NODISCARD to attribute functions.
[IR] Add NODISCARD to attribute functions
Dec 5 2018, 7:37 AM
modocache closed D55217: [IR] Add NODISCARD to attribute functions.
Dec 5 2018, 7:36 AM

Dec 3 2018

modocache created D55217: [IR] Add NODISCARD to attribute functions.
Dec 3 2018, 7:07 AM
modocache created D55216: [bugpoint][PR29027] Reduce function attributes.
Dec 3 2018, 6:58 AM

Nov 28 2018

modocache added reviewers for D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules: manmanren, bruno.

Friendly ping! Could someone recommend a reviewer for this? Or is there something wrong with the patch?

Nov 28 2018, 7:27 PM
modocache added a comment to D54884: [bugpoint] Find 'opt', etc., in bugpoint directory.

Friendly ping! I like this patch because it saves me the keystrokes of typing --opt-command every time I run bugpoint. Please give it a look and let me know if I can improve anything.

Nov 28 2018, 6:03 AM

Nov 25 2018

modocache created D54884: [bugpoint] Find 'opt', etc., in bugpoint directory.
Nov 25 2018, 8:51 PM

Nov 5 2018

modocache accepted D53212: inhereit LLVM_ENABLE_LIBXML2.

Sorry to have let this languish! LGTM.

Nov 5 2018, 9:38 AM

Nov 3 2018

modocache committed rL346074: [coroutines] Fix fallthrough warning on try/catch.
[coroutines] Fix fallthrough warning on try/catch
Nov 3 2018, 3:38 PM
modocache committed rC346074: [coroutines] Fix fallthrough warning on try/catch.
[coroutines] Fix fallthrough warning on try/catch
Nov 3 2018, 3:37 PM
modocache closed D54075: [coroutines] Fix fallthrough warning on try/catch.
Nov 3 2018, 3:37 PM
modocache added a comment to D54075: [coroutines] Fix fallthrough warning on try/catch.

Great, thanks!

Nov 3 2018, 3:37 PM
modocache created D54075: [coroutines] Fix fallthrough warning on try/catch.
Nov 3 2018, 12:02 PM

Oct 30 2018

modocache abandoned D53860: [SemaCXX] Don't check base's dtor is accessible.

Yes, thanks @rsmith! And sorry @ahatanak for the trouble of explaining your code here.

Oct 30 2018, 7:36 PM

Oct 29 2018

modocache added a comment to D53860: [SemaCXX] Don't check base's dtor is accessible.

Here's a compiler explorer link demonstrating that GCC 8.2 and Clang 7.0.0 compile the example code, but Clang trunk emits an error: https://godbolt.org/z/l3baI_

Oct 29 2018, 10:00 PM
modocache created D53860: [SemaCXX] Don't check base's dtor is accessible.
Oct 29 2018, 9:58 PM

Oct 15 2018

modocache added a comment to D44672: [CodeGen] Disable UBSan for coroutine functions.

Oh, I'm sorry I let this languish! I'll address your comments later this week, @vsk. Thanks so much for the review!

Oct 15 2018, 5:08 PM

Oct 7 2018

modocache committed rC343949: [coro]Pass rvalue reference for named local variable to return_value.
[coro]Pass rvalue reference for named local variable to return_value
Oct 7 2018, 8:14 PM
modocache committed rL343949: [coro]Pass rvalue reference for named local variable to return_value.
[coro]Pass rvalue reference for named local variable to return_value
Oct 7 2018, 8:10 PM
modocache closed D51741: [coro]Pass rvalue reference for named local variable to return_value.
Oct 7 2018, 8:10 PM

Sep 26 2018

modocache accepted D51741: [coro]Pass rvalue reference for named local variable to return_value.

This is great, thanks! Sorry for letting it languish. I defer to @GorNishanov, but I don't see why this couldn't go in now and if there're any edge cases I'm missing we can address those in another patch. I pulled this down and played around with it, and everything seemed OK to me.

Sep 26 2018, 8:20 AM

Sep 3 2018

modocache added a comment to D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest".

Excellent, I think pushing this along with D50410 revealed the true error, as an MSAN buildbot tells use there's a use of an uninitialized value: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/23176/steps/check-clang%20msan/logs/stdio

Sep 3 2018, 11:18 AM
modocache committed rL341333: Revert r341329 due to MSAN error.
Revert r341329 due to MSAN error
Sep 3 2018, 11:14 AM
modocache committed rL341329: Re-push "[Option] Fix PR37006 prefix choice in findNearest".
Re-push "[Option] Fix PR37006 prefix choice in findNearest"
Sep 3 2018, 10:32 AM
modocache closed D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest".
Sep 3 2018, 10:32 AM
modocache committed rC341327: Removing -debug-info-macros from option suggestions test.
Removing -debug-info-macros from option suggestions test
Sep 3 2018, 9:56 AM
modocache committed rL341327: Removing -debug-info-macros from option suggestions test.
Removing -debug-info-macros from option suggestions test
Sep 3 2018, 9:56 AM
modocache closed D50410: Removing -debug-info-macros from option suggestions test.
Sep 3 2018, 9:56 AM
modocache accepted D51386: Add some context to fatal verifier errors.

Nice! This seems like a plain improvement in terms of debugging, thanks.

Sep 3 2018, 9:42 AM
modocache accepted D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest".

Thanks! I'll land D50410, then this, and monitor the buildbots to see what happens. If they fail again I may revert this once again. Thanks again for looking into this, sorry for the delay in landing it.

Sep 3 2018, 9:18 AM

Aug 28 2018

modocache added reviewers for D51333: Diagnose likely typos in include statements: aaron.ballman, erikjv.

This looks good to me, but maybe some people who've modified this part of the codebase before could review this as well? @aaron.ballman added a fix-it for angled/quoted strings in rL160406, and more recently @erikjv modified some of this code in rL285057. If anyone could suggest other reviewers that would be great as well!

Aug 28 2018, 9:47 AM

Aug 15 2018

modocache accepted D50410: Removing -debug-info-macros from option suggestions test.

I don't have access to the PS4 SDK, but this is the most plausible explanation I've seen for why I was experiencing issues on these platforms. Thanks for this!

Aug 15 2018, 1:35 PM

Jul 14 2018

modocache committed rC337103: Add caching when looking up coroutine_traits.
Add caching when looking up coroutine_traits
Jul 14 2018, 11:27 AM
modocache committed rL337103: Add caching when looking up coroutine_traits.
Add caching when looking up coroutine_traits
Jul 14 2018, 11:27 AM
modocache closed D48981: Add caching when looking up coroutine_traits.
Jul 14 2018, 11:26 AM
modocache accepted D48981: Add caching when looking up coroutine_traits.

Yup, LGTM! I'll land this now.

Jul 14 2018, 11:04 AM

Jul 10 2018

modocache committed rC336750: [SemaCXX] Remove comment from coroutines test, NFC.
[SemaCXX] Remove comment from coroutines test, NFC
Jul 10 2018, 6:06 PM
modocache committed rL336750: [SemaCXX] Remove comment from coroutines test, NFC.
[SemaCXX] Remove comment from coroutines test, NFC
Jul 10 2018, 6:05 PM
modocache committed rL336748: Remove qualtype qualifier in coroutine error to prevent assert in debug.
Remove qualtype qualifier in coroutine error to prevent assert in debug
Jul 10 2018, 5:51 PM
modocache committed rC336748: Remove qualtype qualifier in coroutine error to prevent assert in debug.
Remove qualtype qualifier in coroutine error to prevent assert in debug
Jul 10 2018, 5:51 PM
modocache closed D49099: Remove qualtype qualifier in coroutine error to prevent assert in debug.
Jul 10 2018, 5:50 PM
modocache added a comment to D49099: Remove qualtype qualifier in coroutine error to prevent assert in debug.

If you don't have commit access, let me know here if you'd like me to commit this on your behalf.

Jul 10 2018, 6:31 AM
modocache accepted D49099: Remove qualtype qualifier in coroutine error to prevent assert in debug.

Excellent, thanks!

Jul 10 2018, 6:18 AM

Jul 5 2018

modocache resigned from D48981: Add caching when looking up coroutine_traits.

This LGTM but I'll just wait for @GorNishanov to accept the patch, just in case I'm missing something. I'd be happy to commit this for you once Gor accepts! :)

Jul 5 2018, 11:07 AM

Jul 3 2018

modocache added inline comments to D48863: [Sema] Explain coroutine_traits template in diag.
Jul 3 2018, 4:13 PM
modocache updated the diff for D48863: [Sema] Explain coroutine_traits template in diag.

Oops, apologies, I included a line I shouldn't have in the previous diff.

Jul 3 2018, 12:29 PM

Jul 2 2018

modocache created D48863: [Sema] Explain coroutine_traits template in diag.
Jul 2 2018, 8:25 PM

Jun 26 2018

modocache committed rC335655: [AST] Fix typo in LazyOffsetPtr::get docs (NFC).
[AST] Fix typo in LazyOffsetPtr::get docs (NFC)
Jun 26 2018, 1:10 PM
modocache committed rL335655: [AST] Fix typo in LazyOffsetPtr::get docs (NFC).
[AST] Fix typo in LazyOffsetPtr::get docs (NFC)
Jun 26 2018, 1:10 PM

Jun 23 2018

modocache committed rL335422: [Coroutines] Less IR for noexcept await_resume.
[Coroutines] Less IR for noexcept await_resume
Jun 23 2018, 12:02 PM
modocache committed rC335422: [Coroutines] Less IR for noexcept await_resume.
[Coroutines] Less IR for noexcept await_resume
Jun 23 2018, 12:02 PM
modocache closed D47673: [Coroutines] Less IR for noexcept await_resume.
Jun 23 2018, 12:02 PM
modocache closed D47673: [Coroutines] Less IR for noexcept await_resume.
Jun 23 2018, 12:02 PM
modocache updated the diff for D47673: [Coroutines] Less IR for noexcept await_resume.

Great, thanks @GorNishanov! I moved the 'can throw' logic into a function called 'memberCallExpressionCanThrow', to convey that some dyn_cast'ing is going on.

Jun 23 2018, 11:39 AM
modocache committed rL335420: [Sema] isValidCoroutineContext FIXME and citations.
[Sema] isValidCoroutineContext FIXME and citations
Jun 23 2018, 11:05 AM
modocache committed rC335420: [Sema] isValidCoroutineContext FIXME and citations.
[Sema] isValidCoroutineContext FIXME and citations
Jun 23 2018, 11:05 AM
modocache closed D48519: [Sema] isValidCoroutineContext FIXME and citations.
Jun 23 2018, 11:05 AM
modocache updated the diff for D48519: [Sema] isValidCoroutineContext FIXME and citations.

Great, thanks for the review! I added a reference to N4499.

Jun 23 2018, 10:32 AM
modocache added inline comments to D48519: [Sema] isValidCoroutineContext FIXME and citations.
Jun 23 2018, 8:49 AM
modocache added a comment to D48519: [Sema] isValidCoroutineContext FIXME and citations.

Also @GorNishanov I'm curious about your two cents on whether comments like these are valuable. If you think they are I may add a few more with post-commit review.

Jun 23 2018, 8:47 AM
modocache created D48519: [Sema] isValidCoroutineContext FIXME and citations.
Jun 23 2018, 8:46 AM