modocache (Brian Gesiak)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 16 2014, 1:10 AM (204 w, 2 d)

Recent Activity

Yesterday

modocache committed rL322520: [docs] Only LLVM IR bitstreams begin with 'BC'.
[docs] Only LLVM IR bitstreams begin with 'BC'
Mon, Jan 15, 1:24 PM
modocache closed D42002: [docs] Only LLVM IR bitstreams begin with 'BC'.
Mon, Jan 15, 1:24 PM
modocache added a comment to D42004: [Driver] Suggest valid integrated tools.

Great, thanks for the review @bkramer!

Mon, Jan 15, 1:08 PM
modocache committed rL322517: [Driver] Suggest valid integrated tools.
[Driver] Suggest valid integrated tools
Mon, Jan 15, 1:07 PM
modocache committed rC322517: [Driver] Suggest valid integrated tools.
[Driver] Suggest valid integrated tools
Mon, Jan 15, 1:07 PM
modocache closed D42004: [Driver] Suggest valid integrated tools.
Mon, Jan 15, 1:07 PM

Sun, Jan 14

modocache updated the diff for D41820: [coroutines] Pass coro func args to promise ctor.

Thanks for the great review, @GorNishanov! You were exactly right, I had to remove the assert. I've taken all of your other suggestions as well. Let me know if anything else stands out at you. Also, thanks for the question, @EricWF, I added some comments to make it clear that this is an implementation of an experimental feature that has yet to be formally proposed.

Sun, Jan 14, 9:53 AM

Sat, Jan 13

modocache added a comment to D42005: [docs] Use monospace for PCH option flags.

Great, thanks for the review, @aaron.ballman!

Sat, Jan 13, 10:35 AM
modocache committed rL322447: [docs] Use monospace for PCH option flags.
[docs] Use monospace for PCH option flags
Sat, Jan 13, 10:35 AM
modocache committed rC322447: [docs] Use monospace for PCH option flags.
[docs] Use monospace for PCH option flags
Sat, Jan 13, 10:35 AM
modocache closed D42005: [docs] Use monospace for PCH option flags.
Sat, Jan 13, 10:35 AM
modocache added a comment to D42001: [Driver] Add "did you mean?" suggestions to -cc1as.

Thanks, @v.g.vassilev!

Sat, Jan 13, 9:16 AM
modocache committed rC322445: [Driver] Add "did you mean?" suggestions to -cc1as.
[Driver] Add "did you mean?" suggestions to -cc1as
Sat, Jan 13, 9:12 AM
modocache committed rL322445: [Driver] Add "did you mean?" suggestions to -cc1as.
[Driver] Add "did you mean?" suggestions to -cc1as
Sat, Jan 13, 9:12 AM
modocache closed D42001: [Driver] Add "did you mean?" suggestions to -cc1as.
Sat, Jan 13, 9:12 AM
modocache added a comment to D42002: [docs] Only LLVM IR bitstreams begin with 'BC'.

Yup, I totally agree, it would have been nice if in practice 'BC' was used by all LLVM IR bitstream formats. I wonder if it would possible, one day, to change the magic numbers for the major formats from Clang (and Swift) such that they do begin with 'BC'? Or are there too many clients that rely on the existing magic numbers? For example, does Apple's Xcode parse the magic numbers for serialized diagnostics somehow?

Sat, Jan 13, 8:22 AM

Fri, Jan 12

modocache created D42005: [docs] Use monospace for PCH option flags.
Fri, Jan 12, 11:43 AM
modocache created D42004: [Driver] Suggest valid integrated tools.
Fri, Jan 12, 11:10 AM
modocache created D42002: [docs] Only LLVM IR bitstreams begin with 'BC'.
Fri, Jan 12, 10:33 AM
modocache abandoned D36847: [Support] Add reentrant start/stop Timer methods.

Thanks for the reviews, everyone! I'll try to come up with something better here, and submit it in its own diff at a later date.

Fri, Jan 12, 10:32 AM
modocache abandoned D36848: [CodeGen] Use reentrant methods to time IR gen.
Fri, Jan 12, 10:31 AM
modocache created D42001: [Driver] Add "did you mean?" suggestions to -cc1as.
Fri, Jan 12, 10:30 AM
modocache updated the diff for D41979: [bcanalyzer] Recognize more stream types.

Add tests directly to the LLVM test suite. Thanks, @davide!

Fri, Jan 12, 9:21 AM
modocache added inline comments to D41980: Add tests for llvm-bcanalyzer stream types.
Fri, Jan 12, 9:04 AM
modocache added a comment to D41979: [bcanalyzer] Recognize more stream types.

Very smart idea, @davide! I'll do that.

Fri, Jan 12, 9:01 AM
modocache added a comment to D41979: [bcanalyzer] Recognize more stream types.

@davide I mentioned this in the "Test Plan" above, but I'm not sure how to test this without relying upon Clang. I do have a diff up for review that adds tests for this to the Clang repository, though: https://reviews.llvm.org/D41980. Maybe I'm missing something, though -- do you have any tips on how to test this entirely in the LLVM repo, so that I can include tests in this diff?

Fri, Jan 12, 7:38 AM

Thu, Jan 11

modocache created D41980: Add tests for llvm-bcanalyzer stream types.
Thu, Jan 11, 9:34 PM
modocache created D41979: [bcanalyzer] Recognize more stream types.
Thu, Jan 11, 9:33 PM

Wed, Jan 10

modocache added a comment to D41912: [Driver] Test for correct '--version' suggestion.

Thanks, will do next time :)

Wed, Jan 10, 12:25 PM
modocache committed rL322220: [Driver] Test for correct '--version' suggestion.
[Driver] Test for correct '--version' suggestion
Wed, Jan 10, 12:25 PM
modocache committed rC322220: [Driver] Test for correct '--version' suggestion.
[Driver] Test for correct '--version' suggestion
Wed, Jan 10, 12:25 PM
modocache closed D41912: [Driver] Test for correct '--version' suggestion.
Wed, Jan 10, 12:24 PM
modocache created D41912: [Driver] Test for correct '--version' suggestion.
Wed, Jan 10, 11:29 AM

Tue, Jan 9

modocache added a comment to D41867: [Frontend] Remove unused FileMgr in pp arg parse.

Great, thanks for the review, @v.g.vassilev!

Tue, Jan 9, 1:29 PM
modocache committed rL322118: [Frontend] Remove unused FileMgr in pp arg parse.
[Frontend] Remove unused FileMgr in pp arg parse
Tue, Jan 9, 1:28 PM
modocache committed rC322118: [Frontend] Remove unused FileMgr in pp arg parse.
[Frontend] Remove unused FileMgr in pp arg parse
Tue, Jan 9, 1:28 PM
modocache closed D41867: [Frontend] Remove unused FileMgr in pp arg parse.
Tue, Jan 9, 1:28 PM
modocache added a comment to D41873: [Option] For typo '-foo', suggest '--foo'.

Great, thanks for the quick review, @jroelofs!

Tue, Jan 9, 11:39 AM
modocache committed rL322109: [Option] For typo '-foo', suggest '--foo'.
[Option] For typo '-foo', suggest '--foo'
Tue, Jan 9, 11:39 AM
modocache closed D41873: [Option] For typo '-foo', suggest '--foo'.
Tue, Jan 9, 11:39 AM
modocache created D41873: [Option] For typo '-foo', suggest '--foo'.
Tue, Jan 9, 10:50 AM
modocache created D41867: [Frontend] Remove unused FileMgr in pp arg parse.
Tue, Jan 9, 8:09 AM

Mon, Jan 8

modocache created D41820: [coroutines] Pass coro func args to promise ctor.
Mon, Jan 8, 6:15 AM

Fri, Jan 5

modocache committed rL321917: [Driver] Suggest correctly spelled driver options.
[Driver] Suggest correctly spelled driver options
Fri, Jan 5, 4:27 PM
modocache committed rC321917: [Driver] Suggest correctly spelled driver options.
[Driver] Suggest correctly spelled driver options
Fri, Jan 5, 4:26 PM
modocache closed D41733: [Driver] Suggest correctly spelled driver options.
Fri, Jan 5, 4:26 PM
modocache committed rL321881: [llvm-mt] Remove platform-specific path in test.
[llvm-mt] Remove platform-specific path in test
Fri, Jan 5, 10:24 AM
modocache added a comment to D41732: [Option] Add 'findNearest' method to catch typos.

Great, thanks for the reviews, everyone! Some of you have already commented on https://reviews.llvm.org/D41733, which adds "did you mean?" suggestions to Clang, but let me know if there's anything else I can do on that revision.

Fri, Jan 5, 9:13 AM
modocache committed rL321877: [Option] Add 'findNearest' method to catch typos.
[Option] Add 'findNearest' method to catch typos
Fri, Jan 5, 9:12 AM
modocache closed D41732: [Option] Add 'findNearest' method to catch typos.
Fri, Jan 5, 9:11 AM
modocache updated the diff for D41732: [Option] Add 'findNearest' method to catch typos.

Fixed a dangling reference to concatenated string and re-ran clang-format. Thanks, @jroelofs!

Fri, Jan 5, 5:43 AM
modocache updated the diff for D41733: [Driver] Suggest correctly spelled driver options.

Test -Xclang as well. Thanks, @v.g.vassilev!

Fri, Jan 5, 5:33 AM
modocache updated the diff for D41732: [Option] Add 'findNearest' method to catch typos.

Remove unnecessary branch for RHS.empty(). Thanks, @jroelofs!

Fri, Jan 5, 4:34 AM
modocache added inline comments to D41732: [Option] Add 'findNearest' method to catch typos.
Fri, Jan 5, 4:29 AM

Thu, Jan 4

modocache updated the diff for D41733: [Driver] Suggest correctly spelled driver options.

Add 'did you mean' suggestions for -cc1 invocations as well.

Thu, Jan 4, 4:52 PM
modocache added a comment to D41733: [Driver] Suggest correctly spelled driver options.

Thank you, @bruno! Good idea, I'll add a -cc1 invocation test.

Thu, Jan 4, 3:58 PM
modocache updated the summary of D41732: [Option] Add 'findNearest' method to catch typos.
Thu, Jan 4, 3:53 PM
modocache updated the diff for D41732: [Option] Add 'findNearest' method to catch typos.

Thanks for the review, @jroelofs! I think I addressed your comments and adopted your suggestions.

Thu, Jan 4, 3:52 PM
modocache created D41733: [Driver] Suggest correctly spelled driver options.
Thu, Jan 4, 10:07 AM
modocache created D41732: [Option] Add 'findNearest' method to catch typos.
Thu, Jan 4, 10:07 AM

Sep 29 2017

modocache added a comment to D38389: [CMake] Remove `CMAKE_.*_OUTPUT_DIRECTORY` (NFCI).

Reverted in https://reviews.llvm.org/rL314551.

Sep 29 2017, 12:53 PM
modocache added a comment to rL314550: [CMake] Remove `CMAKE_.*_OUTPUT_DIRECTORY` (NFCI).

Reverted in https://reviews.llvm.org/rL314551.

Sep 29 2017, 12:52 PM
modocache committed rL314551: Revert "[CMake] Remove `CMAKE_.*_OUTPUT_DIRECTORY` (NFCI)".
Revert "[CMake] Remove `CMAKE_.*_OUTPUT_DIRECTORY` (NFCI)"
Sep 29 2017, 12:52 PM
modocache added a comment to D38389: [CMake] Remove `CMAKE_.*_OUTPUT_DIRECTORY` (NFCI).

It turns out polly makes use of these variables. I'll revert this for now and try again after taking a closer look at polly.

Sep 29 2017, 12:50 PM
modocache added a comment to D38389: [CMake] Remove `CMAKE_.*_OUTPUT_DIRECTORY` (NFCI).

Thanks @beanz! I'll keep an eye on the bots. Here goes nothing! :)

Sep 29 2017, 12:38 PM
modocache committed rL314550: [CMake] Remove `CMAKE_.*_OUTPUT_DIRECTORY` (NFCI).
[CMake] Remove `CMAKE_.*_OUTPUT_DIRECTORY` (NFCI)
Sep 29 2017, 12:36 PM
modocache closed D38389: [CMake] Remove `CMAKE_.*_OUTPUT_DIRECTORY` (NFCI).
Sep 29 2017, 12:36 PM

Sep 28 2017

modocache committed rL314486: [CMake] Fix typo "Wraning" (NFC).
[CMake] Fix typo "Wraning" (NFC)
Sep 28 2017, 7:49 PM
modocache created D38389: [CMake] Remove `CMAKE_.*_OUTPUT_DIRECTORY` (NFCI).
Sep 28 2017, 7:38 PM

Sep 27 2017

modocache added a comment to D38317: [CMake] Fix typo: "in-tree" -> "in-source" (NFC).

Great, thanks @beanz! I wanted to make sure I was understanding the terminology :)

Sep 27 2017, 2:39 PM
modocache committed rL314348: [CMake] Fix typo: "in-tree" -> "in-source" (NFC).
[CMake] Fix typo: "in-tree" -> "in-source" (NFC)
Sep 27 2017, 2:39 PM
modocache closed D38317: [CMake] Fix typo: "in-tree" -> "in-source" (NFC).
Sep 27 2017, 2:39 PM
modocache created D38317: [CMake] Fix typo: "in-tree" -> "in-source" (NFC).
Sep 27 2017, 7:07 AM

Sep 19 2017

modocache accepted D38033: cmake: fix .git-dir detection with using git-rev-parse (regression since 4.0).

Thanks for the improvement!

Sep 19 2017, 11:14 AM · Restricted Project

Sep 13 2017

modocache committed rL313164: [CFG] Fix typo in docblock: blocsk/blocks.
[CFG] Fix typo in docblock: blocsk/blocks
Sep 13 2017, 11:03 AM

Aug 30 2017

modocache committed rL312164: [ARM] Use Swift error registers on non-Darwin targets.
[ARM] Use Swift error registers on non-Darwin targets
Aug 30 2017, 1:05 PM
modocache closed D35835: [ARM] Use Swift error registers on non-Darwin targets.
Aug 30 2017, 1:05 PM
modocache updated the diff for D35835: [ARM] Use Swift error registers on non-Darwin targets.

Added some tests to test/CodeGen/ARM/swifterror.ll, also courtesy of John Holdsworth.

Aug 30 2017, 11:43 AM

Aug 23 2017

modocache updated the diff for D36847: [Support] Add reentrant start/stop Timer methods.

Replace Running member with StartCount.

Aug 23 2017, 8:09 AM

Aug 22 2017

modocache updated the diff for D36848: [CodeGen] Use reentrant methods to time IR gen.

Use startReentrantTimer and stopReentrantTimer

Aug 22 2017, 9:33 AM
modocache added a comment to D36847: [Support] Add reentrant start/stop Timer methods.

One downside of separate startReentrantTimer and stopReentrantTimer methods is that we may need to add a bool IsReentrant parameter to the initializer of TimeRegion, in order to support the way it's used in https://reviews.llvm.org/D36946.

Aug 22 2017, 8:51 AM
modocache updated the diff for D36847: [Support] Add reentrant start/stop Timer methods.

Instead of using virtual methods, add Timer::startReentrantTimer and Timer::stopReentrantTimer. @MatzeB, let me know if this isn't what you had in mind -- thanks!

Aug 22 2017, 8:40 AM
modocache planned changes to D36847: [Support] Add reentrant start/stop Timer methods.

Thanks for the suggestions, @MatzeB! I'll try to get rid of the added vtable.

Aug 22 2017, 7:22 AM

Aug 21 2017

modocache added a comment to D36847: [Support] Add reentrant start/stop Timer methods.

Friendly ping -- does anyone have any thoughts here?

Aug 21 2017, 9:53 AM

Aug 19 2017

modocache added inline comments to D36492: [time-report] Add preprocessor timer.
Aug 19 2017, 1:15 PM

Aug 18 2017

modocache committed rL311168: [Lexicon] Add "GEP".
[Lexicon] Add "GEP"
Aug 18 2017, 8:38 AM

Aug 17 2017

modocache created D36848: [CodeGen] Use reentrant methods to time IR gen.
Aug 17 2017, 2:00 PM
modocache created D36847: [Support] Add reentrant start/stop Timer methods.
Aug 17 2017, 1:58 PM

Aug 16 2017

modocache planned changes to D36492: [time-report] Add preprocessor timer.
Aug 16 2017, 2:02 PM
modocache added a comment to D36492: [time-report] Add preprocessor timer.

Friendly ping! I think this is ready to be reviewed. It adds an additional row, Preprocessing, to the Miscellaneous Ungrouped Timers section of the clang -ftime-report output:

Aug 16 2017, 11:57 AM

Aug 15 2017

modocache updated subscribers of D36492: [time-report] Add preprocessor timer.

Oops, sorry, didn't mean to remove the subscribers. arc diff --verbatim strikes again.

Aug 15 2017, 9:57 AM
modocache updated the diff for D36492: [time-report] Add preprocessor timer.

Add PreprocessorOptions::getTimer, and move the timer to the top of Preprocessor::Lex().

Aug 15 2017, 9:54 AM

Aug 14 2017

modocache committed rL310838: [Parse] Fix typo in header docs (NFC).
[Parse] Fix typo in header docs (NFC)
Aug 14 2017, 7:30 AM

Aug 13 2017

modocache committed rL310810: [opt-viewer] Listify `dict_items` for Py3 indexing.
[opt-viewer] Listify `dict_items` for Py3 indexing
Aug 13 2017, 9:20 PM
modocache closed D36630: [opt-viewer] Listify `dict_items` for Py3 indexing.
Aug 13 2017, 9:20 PM
modocache added a comment to D36630: [opt-viewer] Listify `dict_items` for Py3 indexing.

Great, thanks!

Aug 13 2017, 9:20 PM

Aug 11 2017

modocache created D36630: [opt-viewer] Listify `dict_items` for Py3 indexing.
Aug 11 2017, 11:47 AM
modocache committed rL310741: [opt-viewer] Decode HTML bytes for Python 3.
[opt-viewer] Decode HTML bytes for Python 3
Aug 11 2017, 11:07 AM
modocache closed D36624: [opt-viewer] Decode HTML bytes for Python 3.
Aug 11 2017, 11:07 AM
modocache added a comment to D36624: [opt-viewer] Decode HTML bytes for Python 3.

I double-checked this diff worked when run on a directory containing a single YAML file, using Python 2, and it appeared to work. Let me know if it breaks anything for any of your workflows!

Aug 11 2017, 11:05 AM