Page MenuHomePhabricator

modocache (Brian Gesiak)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 16 2014, 1:10 AM (265 w, 2 d)

Recent Activity

Yesterday

modocache added a comment to D59189: [perf][DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces".

Friendly ping, @sylvestre.ledru! I'm also experiencing this build error. It looks like other diffs have been submitted to fix this, such as https://reviews.llvm.org/D59162, but it was abandoned in favor of this patch. It'd be great if you could commit this one.

Mon, Mar 18, 11:46 AM · Restricted Project

Fri, Mar 15

modocache committed rG9db9b1a17501: [coroutines][PR40978] Emit error for co_yield within catch block (authored by modocache).
[coroutines][PR40978] Emit error for co_yield within catch block
Fri, Mar 15, 1:26 PM
modocache committed rL356296: [coroutines][PR40978] Emit error for co_yield within catch block.
[coroutines][PR40978] Emit error for co_yield within catch block
Fri, Mar 15, 1:26 PM
modocache committed rC356296: [coroutines][PR40978] Emit error for co_yield within catch block.
[coroutines][PR40978] Emit error for co_yield within catch block
Fri, Mar 15, 1:25 PM
modocache closed D59076: [coroutines][PR40978] Emit error for co_yield within catch block.
Fri, Mar 15, 1:25 PM · Restricted Project
modocache added a comment to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

Great, thanks for the reviews, everyone!

Fri, Mar 15, 1:25 PM · Restricted Project
modocache added a comment to D58920: [Modules][PR39287] Consolidate multiple std's.

I realize this isn't the correct solution, but would any would-be reviewers like to comment on the problem? Whether it's here or on the Bugzilla report https://bugs.llvm.org/show_bug.cgi?id=39287, as a newcomer to Clang modules I could use some help understanding whether this sort of behavior is expected, or if there are known workarounds. Any and all comments appreciated!

Fri, Mar 15, 9:55 AM · Restricted Project

Thu, Mar 14

modocache updated the diff for D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

OK, I've responded to all your review comments -- thank you! Please give this another look when you get a chance. I would like to emit note diagnostics pointing to the catch blocks, but I've left that as a FIXME for now.

Thu, Mar 14, 3:12 PM · Restricted Project
modocache updated the diff for D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

Remove unused function parameter.

Thu, Mar 14, 2:20 PM · Restricted Project
modocache updated the diff for D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

Thank you for the reviews! This revision fixes the nested try/catch behavior. I still need to modify this such that semantic analysis continues for the rest of the function body.

Thu, Mar 14, 1:49 PM · Restricted Project

Mon, Mar 11

modocache committed rGd7b68132d8f2: [coroutines][PR40979] Ignore unreachable uses across suspend points (authored by modocache).
[coroutines][PR40979] Ignore unreachable uses across suspend points
Mon, Mar 11, 11:32 AM
modocache committed rL355852: [coroutines][PR40979] Ignore unreachable uses across suspend points.
[coroutines][PR40979] Ignore unreachable uses across suspend points
Mon, Mar 11, 11:32 AM
modocache closed D59068: [coroutines][PR40979] Ignore unreachable uses across suspend points.
Mon, Mar 11, 11:32 AM · Restricted Project
modocache updated the diff for D59068: [coroutines][PR40979] Ignore unreachable uses across suspend points.

Thanks @GorNishanov! I moved the call into splitCoroutine. I'll land this now.

Mon, Mar 11, 11:17 AM · Restricted Project
modocache committed rG4349dc76fa08: [Utils] Extract EliminateUnreachableBlocks (NFC) (authored by modocache).
[Utils] Extract EliminateUnreachableBlocks (NFC)
Mon, Mar 11, 10:54 AM
modocache committed rL355846: [Utils] Extract EliminateUnreachableBlocks (NFC).
[Utils] Extract EliminateUnreachableBlocks (NFC)
Mon, Mar 11, 10:54 AM
modocache closed D59069: [Utils] Extract EliminateUnreachableBlocks (NFC).
Mon, Mar 11, 10:53 AM · Restricted Project
modocache updated the diff for D59069: [Utils] Extract EliminateUnreachableBlocks (NFC).

Oops! Thanks for pointing that out @davide -- I had meant to pass them through to the DeleteDeadBlocks but forgot. Should be good now!

Mon, Mar 11, 6:53 AM · Restricted Project

Fri, Mar 8

modocache added a comment to D59069: [Utils] Extract EliminateUnreachableBlocks (NFC).

Friendly ping! I thought this might be easier to review if I split it up from https://reviews.llvm.org/D59068, which fixes a bug in coroutines and has already been accepted. This diff is an NFC but is necessary to land the bug fix.

Fri, Mar 8, 9:27 AM · Restricted Project

Thu, Mar 7

modocache committed rG4e467043fbb5: [CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC) (authored by modocache).
[CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC)
Thu, Mar 7, 12:44 PM
modocache committed rL355634: [CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC).
[CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC)
Thu, Mar 7, 12:44 PM
modocache closed D59064: [CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC).
Thu, Mar 7, 12:44 PM · Restricted Project
modocache added a comment to D59064: [CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC).

Thanks for the review!

Thu, Mar 7, 12:44 PM · Restricted Project
modocache added inline comments to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.
Thu, Mar 7, 12:03 PM · Restricted Project
modocache updated the diff for D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

Add test case for executing a lambda using co_yield within a catch block.

Thu, Mar 7, 11:51 AM · Restricted Project
modocache added inline comments to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.
Thu, Mar 7, 11:48 AM · Restricted Project

Wed, Mar 6

modocache added inline comments to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.
Wed, Mar 6, 11:16 PM · Restricted Project
modocache created D59076: [coroutines][PR40978] Emit error for co_yield within catch block.
Wed, Mar 6, 10:19 PM · Restricted Project
modocache updated the summary of D59068: [coroutines][PR40979] Ignore unreachable uses across suspend points.
Wed, Mar 6, 6:52 PM · Restricted Project
modocache created D59069: [Utils] Extract EliminateUnreachableBlocks (NFC).
Wed, Mar 6, 6:52 PM · Restricted Project
modocache created D59068: [coroutines][PR40979] Ignore unreachable uses across suspend points.
Wed, Mar 6, 6:49 PM · Restricted Project
modocache created D59064: [CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC).
Wed, Mar 6, 5:35 PM · Restricted Project

Mon, Mar 4

modocache created D58920: [Modules][PR39287] Consolidate multiple std's.
Mon, Mar 4, 12:41 PM · Restricted Project
modocache accepted D58751: Order File Instrumentation: add clang support for -forder-file-instrumentation.

Looks good, thanks for adding a driver option for this!

Mon, Mar 4, 10:06 AM · Restricted Project

Fri, Mar 1

modocache added a comment to D58216: Support attribute used in member funcs of class templates II.

Friendly ping! @aaron.ballman it looks like you accepted D56928, could you take a look at this as well?

Fri, Mar 1, 4:10 AM · Restricted Project

Jan 31 2019

modocache committed rL352831: [SemaCXX] Param diagnostic matches overload logic.
[SemaCXX] Param diagnostic matches overload logic
Jan 31 2019, 7:30 PM
modocache added a comment to D57032: [SemaCXX] Param diagnostic matches overload logic.

Thanks for the reviews!

Jan 31 2019, 7:30 PM · Restricted Project
modocache committed rC352831: [SemaCXX] Param diagnostic matches overload logic.
[SemaCXX] Param diagnostic matches overload logic
Jan 31 2019, 7:30 PM
modocache closed D57032: [SemaCXX] Param diagnostic matches overload logic.
Jan 31 2019, 7:30 PM · Restricted Project
Herald added a project to D57032: [SemaCXX] Param diagnostic matches overload logic: Restricted Project.

Friendly ping! Is there anything I can do to improve this patch? I think it's a clear improvement of the diagnostic, with a test case to boot!

Jan 31 2019, 6:42 PM · Restricted Project

Jan 30 2019

modocache updated the diff for D57032: [SemaCXX] Param diagnostic matches overload logic.

Thanks, @cpplearner! You're absolutely right. I got confused because I didn't realize that the method FunctionProtoType::getUnqualifiedType was being used from within Sema::FunctionParamTypesAreEqual, not QualType::getUnqualifiedType. I modified my patch to use ASTContext::hasSameUnqualifiedType instead.

Jan 30 2019, 6:35 AM · Restricted Project

Jan 21 2019

modocache created D57032: [SemaCXX] Param diagnostic matches overload logic.
Jan 21 2019, 12:30 PM · Restricted Project

Jan 10 2019

modocache added a comment to D56509: [AST] Remove ASTContext from getThisType (NFC).

Great, thanks for the review!

Jan 10 2019, 7:16 PM
modocache committed rCTE350916: Adapt to CXXMethodDecl::getThisType change (NFC).
Adapt to CXXMethodDecl::getThisType change (NFC)
Jan 10 2019, 6:16 PM
modocache committed rL350916: Adapt to CXXMethodDecl::getThisType change (NFC).
Adapt to CXXMethodDecl::getThisType change (NFC)
Jan 10 2019, 6:16 PM
modocache committed rL350914: [AST] Remove ASTContext from getThisType (NFC).
[AST] Remove ASTContext from getThisType (NFC)
Jan 10 2019, 5:58 PM
modocache committed rC350914: [AST] Remove ASTContext from getThisType (NFC).
[AST] Remove ASTContext from getThisType (NFC)
Jan 10 2019, 5:58 PM
modocache closed D56509: [AST] Remove ASTContext from getThisType (NFC).
Jan 10 2019, 5:58 PM

Jan 9 2019

modocache updated the diff for D56243: [coroutines] Experimenting with __builtin_coro_frame_max_size.

Remove obsoleted code I accidentally included.

Jan 9 2019, 12:31 PM
modocache updated the diff for D56243: [coroutines] Experimenting with __builtin_coro_frame_max_size.

Thanks for the offline review @GorNishanov! This revision allows constexpr usages of __builtin_coro_frame_max_size.

Jan 9 2019, 12:28 PM
modocache created D56509: [AST] Remove ASTContext from getThisType (NFC).
Jan 9 2019, 11:35 AM

Jan 6 2019

modocache added a comment to D56271: [SemaCXX] Fix ICE for unexpanded parameter pack.

Thank you for the review!

Jan 6 2019, 7:37 PM
modocache committed rC350501: [SemaCXX] Fix ICE for unexpanded parameter pack.
[SemaCXX] Fix ICE for unexpanded parameter pack
Jan 6 2019, 7:30 PM
modocache committed rL350501: [SemaCXX] Fix ICE for unexpanded parameter pack.
[SemaCXX] Fix ICE for unexpanded parameter pack
Jan 6 2019, 7:30 PM
modocache closed D56271: [SemaCXX] Fix ICE for unexpanded parameter pack.
Jan 6 2019, 7:30 PM

Jan 3 2019

modocache created D56271: [SemaCXX] Fix ICE for unexpanded parameter pack.
Jan 3 2019, 7:31 AM

Jan 2 2019

modocache created D56243: [coroutines] Experimenting with __builtin_coro_frame_max_size.
Jan 2 2019, 8:48 PM

Dec 21 2018

modocache requested changes to D55966: Ensure coro split pass only spills variables dominated by CoroBegin.

Excellent progress! Thanks for working on this.

Dec 21 2018, 2:33 PM

Dec 19 2018

modocache added a comment to D55216: [bugpoint][PR29027] Reduce function attributes.

Thanks for the reviews, @reames! As a follow-up to this, I also have https://reviews.llvm.org/D55601 out for review, if you're interested -- it improves the reduction logic added in this patch.

Dec 19 2018, 6:11 AM

Dec 18 2018

modocache committed rL349601: [bugpoint][PR29027] Reduce function attributes.
[bugpoint][PR29027] Reduce function attributes
Dec 18 2018, 7:45 PM
modocache closed D55216: [bugpoint][PR29027] Reduce function attributes.
Dec 18 2018, 7:45 PM

Dec 17 2018

modocache added a comment to D55216: [bugpoint][PR29027] Reduce function attributes.

Friendly ping! I believe I addressed all of the code review comments. @MatzeB, you created the bug report https://bugs.llvm.org/show_bug.cgi?id=29027, is this implementation what you had in mind?

Dec 17 2018, 5:33 AM

Dec 12 2018

modocache created D55601: [bugpoint] Add ability to reduce to zero elements.
Dec 12 2018, 7:25 AM · Restricted Project

Dec 11 2018

modocache accepted D55160: [coroutines] Improve suspend point simplification.

LGTM! As it happens I was reading this code the other day and wondering why it wasn't able to eliminate a suspend point I'd been looking at. I'll try it again and see if this new behavior is able to eliminate -- thanks!

Dec 11 2018, 7:54 AM

Dec 10 2018

modocache requested changes to D55160: [coroutines] Improve suspend point simplification.

Sorry for the wait! Mostly nits, but also I think the while condition might be inverted? It seems like, as is, it would never execute the body of the loop...?

Dec 10 2018, 6:43 PM

Dec 9 2018

modocache committed rL348734: [bugpoint] Find 'opt', etc., in bugpoint directory.
[bugpoint] Find 'opt', etc., in bugpoint directory
Dec 9 2018, 5:00 PM
modocache closed D54884: [bugpoint] Find 'opt', etc., in bugpoint directory.
Dec 9 2018, 5:00 PM
modocache committed rL348733: Re-commit "[IR] Add NODISCARD to attribute functions".
Re-commit "[IR] Add NODISCARD to attribute functions"
Dec 9 2018, 2:39 PM
modocache committed rL348732: [AMDGPU] Fix discarded result of addAttribute.
[AMDGPU] Fix discarded result of addAttribute
Dec 9 2018, 2:00 PM
modocache closed D55435: [AMDGPU] Fix discarded result of addAttribute.
Dec 9 2018, 2:00 PM
modocache added inline comments to D55216: [bugpoint][PR29027] Reduce function attributes.
Dec 9 2018, 10:21 AM
modocache updated the diff for D55216: [bugpoint][PR29027] Reduce function attributes.

Thanks for the review, @reames! I implemented each of your suggestions, but I had a small excuse for not using the variable name Suffix.

Dec 9 2018, 10:20 AM
modocache updated the diff for D55435: [AMDGPU] Fix discarded result of addAttribute.

I see, thanks @arsenm! I think this variable fits those criteria so I changed it back to using a dollar-sign prefix. Variable names notwithstanding, does the implementation change seem OK to everyone? It fixes what I believe is clearly a programming error. Landing this change will unblock me from LLVM_NODISCARD to these functions and so preventing another case of this same error.

Dec 9 2018, 9:03 AM
modocache updated the diff for D54884: [bugpoint] Find 'opt', etc., in bugpoint directory.

Search the bugpoint directory first, and only fall back to PATH if the program isn't there.

Dec 9 2018, 8:49 AM
modocache added a comment to D54884: [bugpoint] Find 'opt', etc., in bugpoint directory.

Thanks @MatzeB! I'll change this to search in the bugpoint directory first, and fall back to the PATH.

Dec 9 2018, 8:44 AM
modocache added inline comments to D55435: [AMDGPU] Fix discarded result of addAttribute.
Dec 9 2018, 8:15 AM
modocache updated the diff for D55435: [AMDGPU] Fix discarded result of addAttribute.

Thanks for the review, @nhaehnle! I changed the FileCheck variable NOUNWIND_READONLY to not use a dollar-sign prefix. I'm not sure why the other lines in this test do, but I left them alone for now. Any other suggestions for this, or is it good to go?

Dec 9 2018, 7:28 AM

Dec 7 2018

modocache created D55435: [AMDGPU] Fix discarded result of addAttribute.
Dec 7 2018, 7:10 AM

Dec 5 2018

modocache committed rL348375: Revert "[IR] Add NODISCARD to attribute functions".
Revert "[IR] Add NODISCARD to attribute functions"
Dec 5 2018, 7:59 AM
modocache added a comment to D55217: [IR] Add NODISCARD to attribute functions.

Oops, sorry, I didn't check hard enough. There's code for AMDGPU that runs up against this warning, causing some buildbots to fail: http://lab.llvm.org:8011/builders/lld-perf-testsuite/builds/9637/steps/build-bin%2Flld/logs/stdio

Dec 5 2018, 7:55 AM
modocache added a comment to D55217: [IR] Add NODISCARD to attribute functions.

Thanks! Yup, I confirmed no new warnings when building check-llvm and check-clang.

Dec 5 2018, 7:45 AM
modocache committed rL348372: [IR] Add NODISCARD to attribute functions.
[IR] Add NODISCARD to attribute functions
Dec 5 2018, 7:37 AM
modocache closed D55217: [IR] Add NODISCARD to attribute functions.
Dec 5 2018, 7:36 AM

Dec 3 2018

modocache created D55217: [IR] Add NODISCARD to attribute functions.
Dec 3 2018, 7:07 AM
modocache created D55216: [bugpoint][PR29027] Reduce function attributes.
Dec 3 2018, 6:58 AM

Nov 28 2018

modocache added reviewers for D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules: manmanren, bruno.

Friendly ping! Could someone recommend a reviewer for this? Or is there something wrong with the patch?

Nov 28 2018, 7:27 PM
modocache added a comment to D54884: [bugpoint] Find 'opt', etc., in bugpoint directory.

Friendly ping! I like this patch because it saves me the keystrokes of typing --opt-command every time I run bugpoint. Please give it a look and let me know if I can improve anything.

Nov 28 2018, 6:03 AM

Nov 25 2018

modocache created D54884: [bugpoint] Find 'opt', etc., in bugpoint directory.
Nov 25 2018, 8:51 PM

Nov 5 2018

modocache accepted D53212: inhereit LLVM_ENABLE_LIBXML2.

Sorry to have let this languish! LGTM.

Nov 5 2018, 9:38 AM

Nov 3 2018

modocache committed rL346074: [coroutines] Fix fallthrough warning on try/catch.
[coroutines] Fix fallthrough warning on try/catch
Nov 3 2018, 3:38 PM
modocache committed rC346074: [coroutines] Fix fallthrough warning on try/catch.
[coroutines] Fix fallthrough warning on try/catch
Nov 3 2018, 3:37 PM
modocache closed D54075: [coroutines] Fix fallthrough warning on try/catch.
Nov 3 2018, 3:37 PM
modocache added a comment to D54075: [coroutines] Fix fallthrough warning on try/catch.

Great, thanks!

Nov 3 2018, 3:37 PM
modocache created D54075: [coroutines] Fix fallthrough warning on try/catch.
Nov 3 2018, 12:02 PM

Oct 30 2018

modocache abandoned D53860: [SemaCXX] Don't check base's dtor is accessible.

Yes, thanks @rsmith! And sorry @ahatanak for the trouble of explaining your code here.

Oct 30 2018, 7:36 PM

Oct 29 2018

modocache added a comment to D53860: [SemaCXX] Don't check base's dtor is accessible.

Here's a compiler explorer link demonstrating that GCC 8.2 and Clang 7.0.0 compile the example code, but Clang trunk emits an error: https://godbolt.org/z/l3baI_

Oct 29 2018, 10:00 PM
modocache created D53860: [SemaCXX] Don't check base's dtor is accessible.
Oct 29 2018, 9:58 PM

Oct 15 2018

modocache added a comment to D44672: [CodeGen] Disable UBSan for coroutine functions.

Oh, I'm sorry I let this languish! I'll address your comments later this week, @vsk. Thanks so much for the review!

Oct 15 2018, 5:08 PM

Oct 7 2018

modocache committed rC343949: [coro]Pass rvalue reference for named local variable to return_value.
[coro]Pass rvalue reference for named local variable to return_value
Oct 7 2018, 8:14 PM
modocache committed rL343949: [coro]Pass rvalue reference for named local variable to return_value.
[coro]Pass rvalue reference for named local variable to return_value
Oct 7 2018, 8:10 PM