Page MenuHomePhabricator

modocache (Brian Gesiak)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 16 2014, 1:10 AM (274 w, 9 h)

Recent Activity

Thu, May 16

modocache created D62035: [AST] const-ify ObjC inherited class search.
Thu, May 16, 2:47 PM · Restricted Project

Wed, May 15

modocache updated the summary of D58920: [Modules][PR39287] Consolidate multiple std's.
Wed, May 15, 6:23 PM · Restricted Project
modocache updated the diff for D58920: [Modules][PR39287] Consolidate multiple std's.

Oops, sent the patch from the wrong repository.

Wed, May 15, 6:20 PM · Restricted Project
modocache updated the diff for D58920: [Modules][PR39287] Consolidate multiple std's.

Thanks for the help, @rsmith! Your suggestions were spot-on. (It took me a little while to figure out why, even using the LazyDeclPtr directly, I was still triggering deserialization. It turns out dump() causes deserialization too -- whoops!)

Wed, May 15, 6:17 PM · Restricted Project

Mon, May 13

modocache added a comment to D58920: [Modules][PR39287] Consolidate multiple std's.

Thanks @rsmith for the guidance here! I appreciate it very much. One snag I ran into after following your suggestion, though, is that when I modify ASTDeclReader::findExisting to return Sema's existing implicit std namespace, I run into an assertion later on, when the decl chain is being marked as incomplete. That is, the following patch (debug output included):

Mon, May 13, 10:47 AM · Restricted Project

Apr 2 2019

modocache committed rG1c44ed8b7611: [Transforms] Redundant getValueOperand (NFC) (authored by modocache).
[Transforms] Redundant getValueOperand (NFC)
Apr 2 2019, 8:00 AM
modocache committed rL357479: [Transforms] Redundant getValueOperand (NFC).
[Transforms] Redundant getValueOperand (NFC)
Apr 2 2019, 7:56 AM

Mar 26 2019

modocache committed rGb66754a29ed7: Revert "[coroutines] Add std::experimental::task<T> type" (authored by modocache).
Revert "[coroutines] Add std::experimental::task<T> type"
Mar 26 2019, 12:52 PM
modocache committed rCXX357023: Revert "[coroutines] Add std::experimental::task<T> type".
Revert "[coroutines] Add std::experimental::task<T> type"
Mar 26 2019, 12:49 PM
modocache committed rL357023: Revert "[coroutines] Add std::experimental::task<T> type".
Revert "[coroutines] Add std::experimental::task<T> type"
Mar 26 2019, 12:49 PM
modocache added a comment to rL357010: [coroutines] Add std::experimental::task<T> type.

Apologies, I forgot to include in the commit message:

Mar 26 2019, 10:52 AM
modocache closed D46140: [coroutines] Add std::experimental::task<T> type.

Committed in rL357010. Apologies, I forgot to include the differential revision in the commit message so this diff wasn't closed automatically as a result. I'll comment on rL357010 with the missing information.

Mar 26 2019, 10:50 AM
modocache committed rG57839425aa48: [coroutines] Add std::experimental::task<T> type (authored by modocache).
[coroutines] Add std::experimental::task<T> type
Mar 26 2019, 10:47 AM
modocache committed rL357010: [coroutines] Add std::experimental::task<T> type.
[coroutines] Add std::experimental::task<T> type
Mar 26 2019, 10:47 AM
modocache committed rCXX357010: [coroutines] Add std::experimental::task<T> type.
[coroutines] Add std::experimental::task<T> type
Mar 26 2019, 10:47 AM

Mar 25 2019

modocache abandoned D59755: gitignore: Ignore in-tree Swift builds.

Right, that makes sense @jordan_rose. I'll submit this to swift-llvm, then.

Mar 25 2019, 10:13 AM · Restricted Project
modocache updated the summary of D59765: [Lex] Warn about invisible Hangul whitespace.
Mar 25 2019, 6:42 AM · Restricted Project
modocache updated the diff for D59765: [Lex] Warn about invisible Hangul whitespace.

Remove unneeded change to test identifier 'xx'.

Mar 25 2019, 6:42 AM · Restricted Project
modocache created D59765: [Lex] Warn about invisible Hangul whitespace.
Mar 25 2019, 6:38 AM · Restricted Project

Mar 24 2019

modocache created D59755: gitignore: Ignore in-tree Swift builds.
Mar 24 2019, 6:34 PM · Restricted Project
modocache committed rGb15c35aff878: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block" (authored by modocache).
Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block"
Mar 24 2019, 5:53 PM
modocache committed rL356865: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block".
Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block"
Mar 24 2019, 5:52 PM
modocache committed rC356865: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block".
Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block"
Mar 24 2019, 5:52 PM
modocache closed D59752: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block".
Mar 24 2019, 5:51 PM · Restricted Project
modocache added a comment to D59752: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block".

Thank you for the review!

Mar 24 2019, 5:51 PM · Restricted Project
modocache added inline comments to D59752: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block".
Mar 24 2019, 4:06 PM · Restricted Project
modocache added reviewers for D59752: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block": bricci, riccibruno, jbulow.
Mar 24 2019, 2:23 PM · Restricted Project
modocache created D59752: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block".
Mar 24 2019, 2:22 PM · Restricted Project

Mar 22 2019

modocache committed rGe8b3d63dd5bb: Revert "[coroutines][PR40978] Emit error for co_yield within catch block" (authored by modocache).
Revert "[coroutines][PR40978] Emit error for co_yield within catch block"
Mar 22 2019, 9:09 AM
modocache committed rL356774: Revert "[coroutines][PR40978] Emit error for co_yield within catch block".
Revert "[coroutines][PR40978] Emit error for co_yield within catch block"
Mar 22 2019, 9:09 AM
modocache committed rC356774: Revert "[coroutines][PR40978] Emit error for co_yield within catch block".
Revert "[coroutines][PR40978] Emit error for co_yield within catch block"
Mar 22 2019, 9:09 AM
modocache added a comment to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

Reverted in rC356296. I'll rework this change along with a test confirming https://bugs.llvm.org/show_bug.cgi?id=41171 doesn't occur. Apologies!

Mar 22 2019, 9:08 AM · Restricted Project
modocache added a comment to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

Sorry for the late response, I'm looking now. Should I revert this for now?

Mar 22 2019, 9:02 AM · Restricted Project
modocache added a comment to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

I'm pushing a revert. Sorry for the trouble!

Mar 22 2019, 9:02 AM · Restricted Project

Mar 18 2019

modocache added a comment to D59189: [perf][DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces".

Friendly ping, @sylvestre.ledru! I'm also experiencing this build error. It looks like other diffs have been submitted to fix this, such as https://reviews.llvm.org/D59162, but it was abandoned in favor of this patch. It'd be great if you could commit this one.

Mar 18 2019, 11:46 AM · Restricted Project

Mar 15 2019

modocache committed rG9db9b1a17501: [coroutines][PR40978] Emit error for co_yield within catch block (authored by modocache).
[coroutines][PR40978] Emit error for co_yield within catch block
Mar 15 2019, 1:26 PM
modocache committed rL356296: [coroutines][PR40978] Emit error for co_yield within catch block.
[coroutines][PR40978] Emit error for co_yield within catch block
Mar 15 2019, 1:26 PM
modocache committed rC356296: [coroutines][PR40978] Emit error for co_yield within catch block.
[coroutines][PR40978] Emit error for co_yield within catch block
Mar 15 2019, 1:25 PM
modocache closed D59076: [coroutines][PR40978] Emit error for co_yield within catch block.
Mar 15 2019, 1:25 PM · Restricted Project
modocache added a comment to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

Great, thanks for the reviews, everyone!

Mar 15 2019, 1:25 PM · Restricted Project
modocache added a comment to D58920: [Modules][PR39287] Consolidate multiple std's.

I realize this isn't the correct solution, but would any would-be reviewers like to comment on the problem? Whether it's here or on the Bugzilla report https://bugs.llvm.org/show_bug.cgi?id=39287, as a newcomer to Clang modules I could use some help understanding whether this sort of behavior is expected, or if there are known workarounds. Any and all comments appreciated!

Mar 15 2019, 9:55 AM · Restricted Project

Mar 14 2019

modocache updated the diff for D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

OK, I've responded to all your review comments -- thank you! Please give this another look when you get a chance. I would like to emit note diagnostics pointing to the catch blocks, but I've left that as a FIXME for now.

Mar 14 2019, 3:12 PM · Restricted Project
modocache updated the diff for D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

Remove unused function parameter.

Mar 14 2019, 2:20 PM · Restricted Project
modocache updated the diff for D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

Thank you for the reviews! This revision fixes the nested try/catch behavior. I still need to modify this such that semantic analysis continues for the rest of the function body.

Mar 14 2019, 1:49 PM · Restricted Project

Mar 11 2019

modocache committed rGd7b68132d8f2: [coroutines][PR40979] Ignore unreachable uses across suspend points (authored by modocache).
[coroutines][PR40979] Ignore unreachable uses across suspend points
Mar 11 2019, 11:32 AM
modocache committed rL355852: [coroutines][PR40979] Ignore unreachable uses across suspend points.
[coroutines][PR40979] Ignore unreachable uses across suspend points
Mar 11 2019, 11:32 AM
modocache closed D59068: [coroutines][PR40979] Ignore unreachable uses across suspend points.
Mar 11 2019, 11:32 AM · Restricted Project
modocache updated the diff for D59068: [coroutines][PR40979] Ignore unreachable uses across suspend points.

Thanks @GorNishanov! I moved the call into splitCoroutine. I'll land this now.

Mar 11 2019, 11:17 AM · Restricted Project
modocache committed rG4349dc76fa08: [Utils] Extract EliminateUnreachableBlocks (NFC) (authored by modocache).
[Utils] Extract EliminateUnreachableBlocks (NFC)
Mar 11 2019, 10:54 AM
modocache committed rL355846: [Utils] Extract EliminateUnreachableBlocks (NFC).
[Utils] Extract EliminateUnreachableBlocks (NFC)
Mar 11 2019, 10:54 AM
modocache closed D59069: [Utils] Extract EliminateUnreachableBlocks (NFC).
Mar 11 2019, 10:53 AM · Restricted Project
modocache updated the diff for D59069: [Utils] Extract EliminateUnreachableBlocks (NFC).

Oops! Thanks for pointing that out @davide -- I had meant to pass them through to the DeleteDeadBlocks but forgot. Should be good now!

Mar 11 2019, 6:53 AM · Restricted Project

Mar 8 2019

modocache added a comment to D59069: [Utils] Extract EliminateUnreachableBlocks (NFC).

Friendly ping! I thought this might be easier to review if I split it up from https://reviews.llvm.org/D59068, which fixes a bug in coroutines and has already been accepted. This diff is an NFC but is necessary to land the bug fix.

Mar 8 2019, 9:27 AM · Restricted Project

Mar 7 2019

modocache committed rG4e467043fbb5: [CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC) (authored by modocache).
[CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC)
Mar 7 2019, 12:44 PM
modocache committed rL355634: [CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC).
[CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC)
Mar 7 2019, 12:44 PM
modocache closed D59064: [CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC).
Mar 7 2019, 12:44 PM · Restricted Project
modocache added a comment to D59064: [CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC).

Thanks for the review!

Mar 7 2019, 12:44 PM · Restricted Project
modocache added inline comments to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.
Mar 7 2019, 12:03 PM · Restricted Project
modocache updated the diff for D59076: [coroutines][PR40978] Emit error for co_yield within catch block.

Add test case for executing a lambda using co_yield within a catch block.

Mar 7 2019, 11:51 AM · Restricted Project
modocache added inline comments to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.
Mar 7 2019, 11:48 AM · Restricted Project

Mar 6 2019

modocache added inline comments to D59076: [coroutines][PR40978] Emit error for co_yield within catch block.
Mar 6 2019, 11:16 PM · Restricted Project
modocache created D59076: [coroutines][PR40978] Emit error for co_yield within catch block.
Mar 6 2019, 10:19 PM · Restricted Project
modocache updated the summary of D59068: [coroutines][PR40979] Ignore unreachable uses across suspend points.
Mar 6 2019, 6:52 PM · Restricted Project
modocache created D59069: [Utils] Extract EliminateUnreachableBlocks (NFC).
Mar 6 2019, 6:52 PM · Restricted Project
modocache created D59068: [coroutines][PR40979] Ignore unreachable uses across suspend points.
Mar 6 2019, 6:49 PM · Restricted Project
modocache created D59064: [CodeGen] Reuse BlockUtils for -unreachableblockelim pass (NFC).
Mar 6 2019, 5:35 PM · Restricted Project

Mar 4 2019

modocache created D58920: [Modules][PR39287] Consolidate multiple std's.
Mar 4 2019, 12:41 PM · Restricted Project
modocache accepted D58751: Order File Instrumentation: add clang support for -forder-file-instrumentation.

Looks good, thanks for adding a driver option for this!

Mar 4 2019, 10:06 AM · Restricted Project

Mar 1 2019

modocache added a comment to D58216: Support attribute used in member funcs of class templates II.

Friendly ping! @aaron.ballman it looks like you accepted D56928, could you take a look at this as well?

Mar 1 2019, 4:10 AM · Restricted Project

Jan 31 2019

modocache committed rL352831: [SemaCXX] Param diagnostic matches overload logic.
[SemaCXX] Param diagnostic matches overload logic
Jan 31 2019, 7:30 PM
modocache added a comment to D57032: [SemaCXX] Param diagnostic matches overload logic.

Thanks for the reviews!

Jan 31 2019, 7:30 PM · Restricted Project
modocache committed rC352831: [SemaCXX] Param diagnostic matches overload logic.
[SemaCXX] Param diagnostic matches overload logic
Jan 31 2019, 7:30 PM
modocache closed D57032: [SemaCXX] Param diagnostic matches overload logic.
Jan 31 2019, 7:30 PM · Restricted Project
Herald added a project to D57032: [SemaCXX] Param diagnostic matches overload logic: Restricted Project.

Friendly ping! Is there anything I can do to improve this patch? I think it's a clear improvement of the diagnostic, with a test case to boot!

Jan 31 2019, 6:42 PM · Restricted Project

Jan 30 2019

modocache updated the diff for D57032: [SemaCXX] Param diagnostic matches overload logic.

Thanks, @cpplearner! You're absolutely right. I got confused because I didn't realize that the method FunctionProtoType::getUnqualifiedType was being used from within Sema::FunctionParamTypesAreEqual, not QualType::getUnqualifiedType. I modified my patch to use ASTContext::hasSameUnqualifiedType instead.

Jan 30 2019, 6:35 AM · Restricted Project

Jan 21 2019

modocache created D57032: [SemaCXX] Param diagnostic matches overload logic.
Jan 21 2019, 12:30 PM · Restricted Project

Jan 10 2019

modocache added a comment to D56509: [AST] Remove ASTContext from getThisType (NFC).

Great, thanks for the review!

Jan 10 2019, 7:16 PM
modocache committed rCTE350916: Adapt to CXXMethodDecl::getThisType change (NFC).
Adapt to CXXMethodDecl::getThisType change (NFC)
Jan 10 2019, 6:16 PM
modocache committed rL350916: Adapt to CXXMethodDecl::getThisType change (NFC).
Adapt to CXXMethodDecl::getThisType change (NFC)
Jan 10 2019, 6:16 PM
modocache committed rL350914: [AST] Remove ASTContext from getThisType (NFC).
[AST] Remove ASTContext from getThisType (NFC)
Jan 10 2019, 5:58 PM
modocache committed rC350914: [AST] Remove ASTContext from getThisType (NFC).
[AST] Remove ASTContext from getThisType (NFC)
Jan 10 2019, 5:58 PM
modocache closed D56509: [AST] Remove ASTContext from getThisType (NFC).
Jan 10 2019, 5:58 PM

Jan 9 2019

modocache updated the diff for D56243: [coroutines] Experimenting with __builtin_coro_frame_max_size.

Remove obsoleted code I accidentally included.

Jan 9 2019, 12:31 PM
modocache updated the diff for D56243: [coroutines] Experimenting with __builtin_coro_frame_max_size.

Thanks for the offline review @GorNishanov! This revision allows constexpr usages of __builtin_coro_frame_max_size.

Jan 9 2019, 12:28 PM
modocache created D56509: [AST] Remove ASTContext from getThisType (NFC).
Jan 9 2019, 11:35 AM

Jan 6 2019

modocache added a comment to D56271: [SemaCXX] Fix ICE for unexpanded parameter pack.

Thank you for the review!

Jan 6 2019, 7:37 PM
modocache committed rC350501: [SemaCXX] Fix ICE for unexpanded parameter pack.
[SemaCXX] Fix ICE for unexpanded parameter pack
Jan 6 2019, 7:30 PM
modocache committed rL350501: [SemaCXX] Fix ICE for unexpanded parameter pack.
[SemaCXX] Fix ICE for unexpanded parameter pack
Jan 6 2019, 7:30 PM
modocache closed D56271: [SemaCXX] Fix ICE for unexpanded parameter pack.
Jan 6 2019, 7:30 PM

Jan 3 2019

modocache created D56271: [SemaCXX] Fix ICE for unexpanded parameter pack.
Jan 3 2019, 7:31 AM

Jan 2 2019

modocache created D56243: [coroutines] Experimenting with __builtin_coro_frame_max_size.
Jan 2 2019, 8:48 PM

Dec 21 2018

modocache requested changes to D55966: Ensure coro split pass only spills variables dominated by CoroBegin.

Excellent progress! Thanks for working on this.

Dec 21 2018, 2:33 PM

Dec 19 2018

modocache added a comment to D55216: [bugpoint][PR29027] Reduce function attributes.

Thanks for the reviews, @reames! As a follow-up to this, I also have https://reviews.llvm.org/D55601 out for review, if you're interested -- it improves the reduction logic added in this patch.

Dec 19 2018, 6:11 AM

Dec 18 2018

modocache committed rL349601: [bugpoint][PR29027] Reduce function attributes.
[bugpoint][PR29027] Reduce function attributes
Dec 18 2018, 7:45 PM
modocache closed D55216: [bugpoint][PR29027] Reduce function attributes.
Dec 18 2018, 7:45 PM

Dec 17 2018

modocache added a comment to D55216: [bugpoint][PR29027] Reduce function attributes.

Friendly ping! I believe I addressed all of the code review comments. @MatzeB, you created the bug report https://bugs.llvm.org/show_bug.cgi?id=29027, is this implementation what you had in mind?

Dec 17 2018, 5:33 AM

Dec 12 2018

modocache created D55601: [bugpoint] Add ability to reduce to zero elements.
Dec 12 2018, 7:25 AM · Restricted Project

Dec 11 2018

modocache accepted D55160: [coroutines] Improve suspend point simplification.

LGTM! As it happens I was reading this code the other day and wondering why it wasn't able to eliminate a suspend point I'd been looking at. I'll try it again and see if this new behavior is able to eliminate -- thanks!

Dec 11 2018, 7:54 AM

Dec 10 2018

modocache requested changes to D55160: [coroutines] Improve suspend point simplification.

Sorry for the wait! Mostly nits, but also I think the while condition might be inverted? It seems like, as is, it would never execute the body of the loop...?

Dec 10 2018, 6:43 PM

Dec 9 2018

modocache committed rL348734: [bugpoint] Find 'opt', etc., in bugpoint directory.
[bugpoint] Find 'opt', etc., in bugpoint directory
Dec 9 2018, 5:00 PM