modocache (Brian Gesiak)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 16 2014, 1:10 AM (247 w, 2 d)

Recent Activity

Mon, Nov 5

modocache accepted D53212: inhereit LLVM_ENABLE_LIBXML2.

Sorry to have let this languish! LGTM.

Mon, Nov 5, 9:38 AM

Sat, Nov 3

modocache committed rL346074: [coroutines] Fix fallthrough warning on try/catch.
[coroutines] Fix fallthrough warning on try/catch
Sat, Nov 3, 3:38 PM
modocache committed rC346074: [coroutines] Fix fallthrough warning on try/catch.
[coroutines] Fix fallthrough warning on try/catch
Sat, Nov 3, 3:37 PM
modocache closed D54075: [coroutines] Fix fallthrough warning on try/catch.
Sat, Nov 3, 3:37 PM
modocache added a comment to D54075: [coroutines] Fix fallthrough warning on try/catch.

Great, thanks!

Sat, Nov 3, 3:37 PM
modocache created D54075: [coroutines] Fix fallthrough warning on try/catch.
Sat, Nov 3, 12:02 PM

Tue, Oct 30

modocache abandoned D53860: [SemaCXX] Don't check base's dtor is accessible.

Yes, thanks @rsmith! And sorry @ahatanak for the trouble of explaining your code here.

Tue, Oct 30, 7:36 PM

Mon, Oct 29

modocache added a comment to D53860: [SemaCXX] Don't check base's dtor is accessible.

Here's a compiler explorer link demonstrating that GCC 8.2 and Clang 7.0.0 compile the example code, but Clang trunk emits an error: https://godbolt.org/z/l3baI_

Mon, Oct 29, 10:00 PM
modocache created D53860: [SemaCXX] Don't check base's dtor is accessible.
Mon, Oct 29, 9:58 PM

Mon, Oct 15

modocache added a comment to D44672: [CodeGen] Disable UBSan for coroutine functions.

Oh, I'm sorry I let this languish! I'll address your comments later this week, @vsk. Thanks so much for the review!

Mon, Oct 15, 5:08 PM

Oct 7 2018

modocache committed rC343949: [coro]Pass rvalue reference for named local variable to return_value.
[coro]Pass rvalue reference for named local variable to return_value
Oct 7 2018, 8:14 PM
modocache committed rL343949: [coro]Pass rvalue reference for named local variable to return_value.
[coro]Pass rvalue reference for named local variable to return_value
Oct 7 2018, 8:10 PM
modocache closed D51741: [coro]Pass rvalue reference for named local variable to return_value.
Oct 7 2018, 8:10 PM

Sep 26 2018

modocache accepted D51741: [coro]Pass rvalue reference for named local variable to return_value.

This is great, thanks! Sorry for letting it languish. I defer to @GorNishanov, but I don't see why this couldn't go in now and if there're any edge cases I'm missing we can address those in another patch. I pulled this down and played around with it, and everything seemed OK to me.

Sep 26 2018, 8:20 AM

Sep 3 2018

modocache added a comment to D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest".

Excellent, I think pushing this along with D50410 revealed the true error, as an MSAN buildbot tells use there's a use of an uninitialized value: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/23176/steps/check-clang%20msan/logs/stdio

Sep 3 2018, 11:18 AM
modocache committed rL341333: Revert r341329 due to MSAN error.
Revert r341329 due to MSAN error
Sep 3 2018, 11:14 AM
modocache committed rL341329: Re-push "[Option] Fix PR37006 prefix choice in findNearest".
Re-push "[Option] Fix PR37006 prefix choice in findNearest"
Sep 3 2018, 10:32 AM
modocache closed D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest".
Sep 3 2018, 10:32 AM
modocache committed rC341327: Removing -debug-info-macros from option suggestions test.
Removing -debug-info-macros from option suggestions test
Sep 3 2018, 9:56 AM
modocache committed rL341327: Removing -debug-info-macros from option suggestions test.
Removing -debug-info-macros from option suggestions test
Sep 3 2018, 9:56 AM
modocache closed D50410: Removing -debug-info-macros from option suggestions test.
Sep 3 2018, 9:56 AM
modocache accepted D51386: Add some context to fatal verifier errors.

Nice! This seems like a plain improvement in terms of debugging, thanks.

Sep 3 2018, 9:42 AM
modocache accepted D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest".

Thanks! I'll land D50410, then this, and monitor the buildbots to see what happens. If they fail again I may revert this once again. Thanks again for looking into this, sorry for the delay in landing it.

Sep 3 2018, 9:18 AM

Aug 28 2018

modocache added reviewers for D51333: Diagnose likely typos in include statements: aaron.ballman, erikjv.

This looks good to me, but maybe some people who've modified this part of the codebase before could review this as well? @aaron.ballman added a fix-it for angled/quoted strings in rL160406, and more recently @erikjv modified some of this code in rL285057. If anyone could suggest other reviewers that would be great as well!

Aug 28 2018, 9:47 AM

Aug 15 2018

modocache accepted D50410: Removing -debug-info-macros from option suggestions test.

I don't have access to the PS4 SDK, but this is the most plausible explanation I've seen for why I was experiencing issues on these platforms. Thanks for this!

Aug 15 2018, 1:35 PM

Jul 14 2018

modocache committed rC337103: Add caching when looking up coroutine_traits.
Add caching when looking up coroutine_traits
Jul 14 2018, 11:27 AM
modocache committed rL337103: Add caching when looking up coroutine_traits.
Add caching when looking up coroutine_traits
Jul 14 2018, 11:27 AM
modocache closed D48981: Add caching when looking up coroutine_traits.
Jul 14 2018, 11:26 AM
modocache accepted D48981: Add caching when looking up coroutine_traits.

Yup, LGTM! I'll land this now.

Jul 14 2018, 11:04 AM

Jul 10 2018

modocache committed rC336750: [SemaCXX] Remove comment from coroutines test, NFC.
[SemaCXX] Remove comment from coroutines test, NFC
Jul 10 2018, 6:06 PM
modocache committed rL336750: [SemaCXX] Remove comment from coroutines test, NFC.
[SemaCXX] Remove comment from coroutines test, NFC
Jul 10 2018, 6:05 PM
modocache committed rL336748: Remove qualtype qualifier in coroutine error to prevent assert in debug.
Remove qualtype qualifier in coroutine error to prevent assert in debug
Jul 10 2018, 5:51 PM
modocache committed rC336748: Remove qualtype qualifier in coroutine error to prevent assert in debug.
Remove qualtype qualifier in coroutine error to prevent assert in debug
Jul 10 2018, 5:51 PM
modocache closed D49099: Remove qualtype qualifier in coroutine error to prevent assert in debug.
Jul 10 2018, 5:50 PM
modocache added a comment to D49099: Remove qualtype qualifier in coroutine error to prevent assert in debug.

If you don't have commit access, let me know here if you'd like me to commit this on your behalf.

Jul 10 2018, 6:31 AM
modocache accepted D49099: Remove qualtype qualifier in coroutine error to prevent assert in debug.

Excellent, thanks!

Jul 10 2018, 6:18 AM

Jul 5 2018

modocache resigned from D48981: Add caching when looking up coroutine_traits.

This LGTM but I'll just wait for @GorNishanov to accept the patch, just in case I'm missing something. I'd be happy to commit this for you once Gor accepts! :)

Jul 5 2018, 11:07 AM

Jul 3 2018

modocache added inline comments to D48863: [Sema] Explain coroutine_traits template in diag.
Jul 3 2018, 4:13 PM
modocache updated the diff for D48863: [Sema] Explain coroutine_traits template in diag.

Oops, apologies, I included a line I shouldn't have in the previous diff.

Jul 3 2018, 12:29 PM

Jul 2 2018

modocache created D48863: [Sema] Explain coroutine_traits template in diag.
Jul 2 2018, 8:25 PM

Jun 26 2018

modocache committed rC335655: [AST] Fix typo in LazyOffsetPtr::get docs (NFC).
[AST] Fix typo in LazyOffsetPtr::get docs (NFC)
Jun 26 2018, 1:10 PM
modocache committed rL335655: [AST] Fix typo in LazyOffsetPtr::get docs (NFC).
[AST] Fix typo in LazyOffsetPtr::get docs (NFC)
Jun 26 2018, 1:10 PM

Jun 23 2018

modocache committed rL335422: [Coroutines] Less IR for noexcept await_resume.
[Coroutines] Less IR for noexcept await_resume
Jun 23 2018, 12:02 PM
modocache committed rC335422: [Coroutines] Less IR for noexcept await_resume.
[Coroutines] Less IR for noexcept await_resume
Jun 23 2018, 12:02 PM
modocache closed D47673: [Coroutines] Less IR for noexcept await_resume.
Jun 23 2018, 12:02 PM
modocache closed D47673: [Coroutines] Less IR for noexcept await_resume.
Jun 23 2018, 12:02 PM
modocache updated the diff for D47673: [Coroutines] Less IR for noexcept await_resume.

Great, thanks @GorNishanov! I moved the 'can throw' logic into a function called 'memberCallExpressionCanThrow', to convey that some dyn_cast'ing is going on.

Jun 23 2018, 11:39 AM
modocache committed rL335420: [Sema] isValidCoroutineContext FIXME and citations.
[Sema] isValidCoroutineContext FIXME and citations
Jun 23 2018, 11:05 AM
modocache committed rC335420: [Sema] isValidCoroutineContext FIXME and citations.
[Sema] isValidCoroutineContext FIXME and citations
Jun 23 2018, 11:05 AM
modocache closed D48519: [Sema] isValidCoroutineContext FIXME and citations.
Jun 23 2018, 11:05 AM
modocache updated the diff for D48519: [Sema] isValidCoroutineContext FIXME and citations.

Great, thanks for the review! I added a reference to N4499.

Jun 23 2018, 10:32 AM
modocache added inline comments to D48519: [Sema] isValidCoroutineContext FIXME and citations.
Jun 23 2018, 8:49 AM
modocache added a comment to D48519: [Sema] isValidCoroutineContext FIXME and citations.

Also @GorNishanov I'm curious about your two cents on whether comments like these are valuable. If you think they are I may add a few more with post-commit review.

Jun 23 2018, 8:47 AM
modocache created D48519: [Sema] isValidCoroutineContext FIXME and citations.
Jun 23 2018, 8:46 AM

Jun 13 2018

modocache committed rL334641: [Darwin] Do not error on '-lto_library' option.
[Darwin] Do not error on '-lto_library' option
Jun 13 2018, 12:05 PM
modocache committed rLLD334641: [Darwin] Do not error on '-lto_library' option.
[Darwin] Do not error on '-lto_library' option
Jun 13 2018, 12:04 PM
modocache closed D47994: [Darwin] Do not error on '-lto_library' option.
Jun 13 2018, 12:04 PM
modocache added a comment to D47994: [Darwin] Do not error on '-lto_library' option.

Great! Thanks for the review :)

Jun 13 2018, 12:04 PM
modocache added a comment to D47994: [Darwin] Do not error on '-lto_library' option.

Friendly ping! Is this alright by you, @smeenai and @pcc?

Jun 13 2018, 7:34 AM

Jun 12 2018

modocache added a comment to rL334507: Fix -DBUILD_SHARED_LIBS=1 build.

Great, thank you!

Jun 12 2018, 10:53 AM
modocache accepted D48073: [MachO] Add lldCommon to LINK_LIBS.

Thanks for catching this! LGTM.

Jun 12 2018, 4:42 AM

Jun 11 2018

modocache updated the diff for D47994: [Darwin] Do not error on '-lto_library' option.

Thanks for the reviews! I adopted @pcc's suggestion to ignore the option without printing a warning. (I also considered calling llvm::opt::Arg::claim, but it looks like no other arguments are claimed, and lld doesn't print warnings for unclaimed arguments anyway.) I updated the help text and the test as well.

Jun 11 2018, 8:23 PM
modocache committed rL334466: [Darwin] Use errorHandler from liblldCommon.
[Darwin] Use errorHandler from liblldCommon
Jun 11 2018, 7:38 PM
modocache committed rLLD334466: [Darwin] Use errorHandler from liblldCommon.
[Darwin] Use errorHandler from liblldCommon
Jun 11 2018, 7:38 PM
modocache closed D47998: [Darwin] Use errorHandler from liblldCommon.
Jun 11 2018, 7:38 PM
modocache updated the diff for D47998: [Darwin] Use errorHandler from liblldCommon.

Thanks for the reviews! I'm updating this so that it no longer includes the warning I added in D47994. I'll commit in in a second.

Jun 11 2018, 7:08 PM
modocache updated the diff for D47998: [Darwin] Use errorHandler from liblldCommon.

Oops! I fixed a typo in the error limit exceeded message.

Jun 11 2018, 8:13 AM

Jun 10 2018

modocache created D47998: [Darwin] Use errorHandler from liblldCommon.
Jun 10 2018, 7:05 PM
modocache created D47994: [Darwin] Do not error on '-lto_library' option.
Jun 10 2018, 11:34 AM

Jun 3 2018

modocache updated subscribers of D47673: [Coroutines] Less IR for noexcept await_resume.
Jun 3 2018, 8:44 AM

Jun 2 2018

modocache created D47673: [Coroutines] Less IR for noexcept await_resume.
Jun 2 2018, 12:18 AM

May 28 2018

modocache accepted D47454: [coroutines] Pass implicit object parameter to promise ctor (fix BUG37604).

Great! Thanks @GorNishanov!

May 28 2018, 11:09 AM

May 22 2018

modocache updated the diff for D46628: [ELF] Add --strip-debug-non-line option.

Thanks again for the reviews. I removed the extraneous else, and reverted the string switch back to what I had originally.

May 22 2018, 8:38 PM
modocache added a comment to D46628: [ELF] Add --strip-debug-non-line option.

Does gold really preserve .debug_info and .debug_abbrev? Generally .debug_info is by far the largest DWARF section and so the one you most likely want to remove.

May 22 2018, 8:09 PM
modocache added a comment to D46628: [ELF] Add --strip-debug-non-line option.

Sorry for letting this languish a bit. I took some time to experiment. Long story short I think llvm-dwarfdump and lldb aren't able to verify this option at the moment.

May 22 2018, 6:36 PM

May 21 2018

modocache committed rL332878: [DebugInfo] Fix typo "DWARG" in test comment (NFC).
[DebugInfo] Fix typo "DWARG" in test comment (NFC)
May 21 2018, 12:52 PM

May 19 2018

modocache committed rL332812: Re-revert "[Option] Fix PR37006 prefix choice in findNearest".
Re-revert "[Option] Fix PR37006 prefix choice in findNearest"
May 19 2018, 9:25 AM
modocache added a comment to rC332804: [Driver] Loosen test for LLVM findNearest.

Yes, unfortunately I haven’t been able to reproduce this locally, on any build environment I have access to. There’s a discussion about this in https://reviews.llvm.org/D46776, but I can’t figure out why the buildbots wouldn’t behave the same way. Passing ‘-triple x86_64-scei-ps4-ubuntu’ as suggested there doesn’t make a difference for me locally. And indeed the argument parsing occurs before the triple is taken into account anyway, so it makes sense to me that it wouldn’t make a difference.

May 19 2018, 5:57 AM
modocache committed rL332806: [Driver] Temporarily remove test for LLVM findNearest.
[Driver] Temporarily remove test for LLVM findNearest
May 19 2018, 5:47 AM
modocache committed rC332806: [Driver] Temporarily remove test for LLVM findNearest.
[Driver] Temporarily remove test for LLVM findNearest
May 19 2018, 5:47 AM
modocache committed rL332805: Un-revert "[Option] Fix PR37006 prefix choice in findNearest".
Un-revert "[Option] Fix PR37006 prefix choice in findNearest"
May 19 2018, 5:07 AM
modocache committed rC332804: [Driver] Loosen test for LLVM findNearest.
[Driver] Loosen test for LLVM findNearest
May 19 2018, 4:51 AM
modocache committed rL332804: [Driver] Loosen test for LLVM findNearest.
[Driver] Loosen test for LLVM findNearest
May 19 2018, 4:51 AM

May 15 2018

modocache added a comment to D46776: [Option] Fix PR37006 prefix choice in findNearest.

Hmm... but the >1 condition is such that an edit distance of greater than 1 results in no suggestion, whereas an edit distance of 1 or 0 results in a suggestion. In this case -- and apparently only on certain platforms' buildbots -- the edit distance between -debug-info-macros and -debug-info-macro is 1, and so it should display a suggestion.

May 15 2018, 2:29 PM

May 14 2018

modocache added a comment to D46776: [Option] Fix PR37006 prefix choice in findNearest.

I'm not yet sure why, but this change caused buildbot failures due to a test in Clang for the "did you mean" feature (example: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/29988). I couldn't figure out why the buildbots would fail whereas the Clang tests pass for me locally, and so reverted this change for the time being, in rL332304. I'll try to resubmit once I've figured out and fixed the issue.

May 14 2018, 3:43 PM
modocache committed rL332304: Revert "[Option] Fix PR37006 prefix choice in findNearest".
Revert "[Option] Fix PR37006 prefix choice in findNearest"
May 14 2018, 3:40 PM
modocache added a comment to D46776: [Option] Fix PR37006 prefix choice in findNearest.

Thanks for the reviews, and for pointing out the bug!

May 14 2018, 2:40 PM
modocache committed rL332299: [Option] Fix PR37006 prefix choice in findNearest.
[Option] Fix PR37006 prefix choice in findNearest
May 14 2018, 2:38 PM
modocache closed D46776: [Option] Fix PR37006 prefix choice in findNearest.
May 14 2018, 2:38 PM
modocache added inline comments to D46776: [Option] Fix PR37006 prefix choice in findNearest.
May 14 2018, 9:36 AM

May 11 2018

modocache created D46776: [Option] Fix PR37006 prefix choice in findNearest.
May 11 2018, 2:37 PM

May 10 2018

modocache added a comment to D43242: [Coroutines] PR34897: Fix incorrect elisions.

Hooray! Thanks again for the review, @GorNishanov.

May 10 2018, 8:26 PM
modocache committed rL332077: [Coroutines] PR34897: Fix incorrect elisions.
[Coroutines] PR34897: Fix incorrect elisions
May 10 2018, 8:16 PM
modocache closed D43242: [Coroutines] PR34897: Fix incorrect elisions.
May 10 2018, 8:16 PM
modocache committed rL332075: [Support] Add docs for 'openFileFor{Write,Read}'.
[Support] Add docs for 'openFileFor{Write,Read}'
May 10 2018, 6:51 PM
modocache closed D46499: [Support] Add docs for 'openFileFor{Write,Read}'.
May 10 2018, 6:51 PM
modocache updated the diff for D46499: [Support] Add docs for 'openFileFor{Write,Read}'.

I updated this diff to not only document how the ResultFD is set, but also make it a little more consistent across platforms. Previously Windows would only sometimes set it to -1 in the case of failure, now it always does.

May 10 2018, 2:17 PM
modocache added a comment to D46628: [ELF] Add --strip-debug-non-line option.

Please just bring back the first patch to line 1316 and submit. Thanks!

May 10 2018, 11:39 AM
modocache added a comment to D46628: [ELF] Add --strip-debug-non-line option.

Thanks for all the review!

May 10 2018, 10:21 AM

May 9 2018

modocache updated the diff for D46628: [ELF] Add --strip-debug-non-line option.

Thanks for the review! I adopted the changes you suggested. As for validating the debug info, what about using 'llvm-dwarfdump -verify'? In fact running that on the output of this new option resulted in errors, so I'll address those.

May 9 2018, 10:04 PM