Page MenuHomePhabricator

RaviNarayanaswamy (Ravi Narayanaswamy)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 11 2015, 7:57 AM (201 w, 4 d)

Recent Activity

Aug 14 2019

RaviNarayanaswamy added inline comments to D64375: [OpenMP][Docs] Provide implementation status details.
Aug 14 2019, 2:40 PM · Restricted Project, Restricted Project

Jun 14 2019

RaviNarayanaswamy added a comment to D63010: [OpenMP] Add task alloc function.

LGTM

Jun 14 2019, 12:16 PM · Restricted Project, Restricted Project, Unknown Object (Project)
RaviNarayanaswamy added a reviewer for D63010: [OpenMP] Add task alloc function: RaviNarayanaswamy.
Jun 14 2019, 12:02 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Nov 29 2018

RaviNarayanaswamy added a comment to D54342: Add omp_get_device_num() and update several other device API functions.

Can you enable LIBOMPTARGET_DEBUG and see if this is printed from libomptarget to confirm libomptarget is loaded and its api is used
DP("Call to omp_get_num_devices returning %zd\n", Devices_size);

Nov 29 2018, 2:39 PM · Unknown Object (Project)

Aug 30 2018

RaviNarayanaswamy accepted D51378: [OPENMP] Add support for nested 'declare target' directives.

Ok.
Thanks.

Aug 30 2018, 12:54 PM
RaviNarayanaswamy added a comment to D51378: [OPENMP] Add support for nested 'declare target' directives.

I did not see the code where check is done if Nestingdepth is 0 at end of compilation.

Aug 30 2018, 9:44 AM

Aug 29 2018

RaviNarayanaswamy added a comment to D51378: [OPENMP] Add support for nested 'declare target' directives.

We should just go with generating an error if the DeclareTargetNestingLevel is not 0 at the end of compilation unit.
Hard to detect if user accidentally forgot to have end declare in header file and had it in the include file or it was intentional.

Aug 29 2018, 1:04 PM

Aug 28 2018

RaviNarayanaswamy added a comment to D51378: [OPENMP] Add support for nested 'declare target' directives.

Is there a way to tell if the header files have matching omp declare target/omp end declare target.
The reason is if one of the header files is missing a matching omp end declare target all files which include it will end up having everything marked with declare target

Aug 28 2018, 2:31 PM

Aug 24 2018

RaviNarayanaswamy added inline comments to D51226: [OpenMP][libomptarget] rework of fatal error reporting.
Aug 24 2018, 12:03 PM
RaviNarayanaswamy added inline comments to D51226: [OpenMP][libomptarget] rework of fatal error reporting.
Aug 24 2018, 11:21 AM

Aug 23 2018

RaviNarayanaswamy added a comment to D51107: [LIBOMPTARGET] Add support for mapping of lambda captures..

If the objects which are copied are not compatible between host and target due to use of pointers which have different size in a structure then it is users responsibility.
I am more interested in where you allocate memory on device you get back an opaque object of size 64. The opaque object may be 64bit device pointer or a high 32bit pointer to device memory and low 32bit offset from that memory or it can be a pointer to a structure which has other information. The idea having libomptarget is to provide a thin layer between compiler and device specific plugin and we need to support different types of plugin.

Aug 23 2018, 1:20 PM
RaviNarayanaswamy added a comment to D51107: [LIBOMPTARGET] Add support for mapping of lambda captures..

Provide additional APIs in plugins if necessary to accomplish the arithmetic operations.
By doing arithmetic for target address in libomptarget you are assuming the pointer size is 64.

Aug 23 2018, 12:58 PM
RaviNarayanaswamy added inline comments to D51107: [LIBOMPTARGET] Add support for mapping of lambda captures..
Aug 23 2018, 9:47 AM

Aug 10 2018

RaviNarayanaswamy added a comment to D50522: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD env var.

Alex: If you feel strongly about your request, I will be happy to move the code into CheckDeviceAndCtors.
It is just a suggestion. Either way is fine.

Aug 10 2018, 3:46 PM

Aug 9 2018

RaviNarayanaswamy added inline comments to D50522: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD env var.
Aug 9 2018, 1:23 PM

Aug 2 2018

RaviNarayanaswamy added a comment to D50158: [OpenMP] Add placeholder functions for the depend and nowait depend clauses for target data directives..

It may be named libOMPtarget and is in openmp projects but we want to use the offloading library with other runtime libraries.

Aug 2 2018, 9:59 AM
RaviNarayanaswamy added a comment to D50158: [OpenMP] Add placeholder functions for the depend and nowait depend clauses for target data directives..

We should not be having calls to _-kmpc_omp_taskwait in libomptarget.
The wait should be done in the user code and then libomptarget routine should be called.

Aug 2 2018, 9:33 AM

Mar 16 2018

RaviNarayanaswamy added a comment to D44577: Read OMP_TARGET_OFFLOAD and provide API to access ICV.

DEFAULT implies MANDATORY or DISABLED. Don't need to communicate to libomp

Mar 16 2018, 2:26 PM

Mar 15 2018

RaviNarayanaswamy added a comment to D44522: [Libomptarget] Full implementation of the target-offload-icv.

Openmp has defined OMP_TARGET_OFFLOAD to control offloading, We should be using this

Mar 15 2018, 9:54 AM · Unknown Object (Project)

Mar 7 2018

RaviNarayanaswamy added inline comments to D44186: [OpenMP][libomptarget] New map interface: remove translation code and ensure proper alignment of struct members.
Mar 7 2018, 1:24 PM · Unknown Object (Project)

Aug 25 2016

RaviNarayanaswamy updated subscribers of D13909: clang-offload-bundler - offload files bundling/unbundling tool.
Aug 25 2016, 3:17 PM

Jan 6 2016

RaviNarayanaswamy added a comment to D14031: [OpenMP] Initial implementation of OpenMP offloading library - libomptarget..

OpenMP says : " If the corresponding list item is not present in the device data environment then no assignment occurs to or from the original list item."

Jan 6 2016, 8:16 AM