- User Since
- Nov 11 2015, 7:57 AM (257 w, 5 d)
Fri, Sep 25
Wed, Sep 23
Can you also remove the definition in the header file include/omptarget.h
Sep 9 2020
Jul 24 2020
Jul 23 2020
Jun 19 2020
How do you plan to support
#pragma omp target update to (arr[1:2][1:2][0:2], x, b[1:5][0:2])
Are you going to split this into 3 updates since your are using the arg fields.
Jan 29 2020
I don't recall saying needs changes.
Aug 14 2019
Jun 14 2019
Nov 29 2018
Can you enable LIBOMPTARGET_DEBUG and see if this is printed from libomptarget to confirm libomptarget is loaded and its api is used
DP("Call to omp_get_num_devices returning %zd\n", Devices_size);
Aug 30 2018
I did not see the code where check is done if Nestingdepth is 0 at end of compilation.
Aug 29 2018
We should just go with generating an error if the DeclareTargetNestingLevel is not 0 at the end of compilation unit.
Hard to detect if user accidentally forgot to have end declare in header file and had it in the include file or it was intentional.
Aug 28 2018
Is there a way to tell if the header files have matching omp declare target/omp end declare target.
The reason is if one of the header files is missing a matching omp end declare target all files which include it will end up having everything marked with declare target
Aug 24 2018
Aug 23 2018
If the objects which are copied are not compatible between host and target due to use of pointers which have different size in a structure then it is users responsibility.
I am more interested in where you allocate memory on device you get back an opaque object of size 64. The opaque object may be 64bit device pointer or a high 32bit pointer to device memory and low 32bit offset from that memory or it can be a pointer to a structure which has other information. The idea having libomptarget is to provide a thin layer between compiler and device specific plugin and we need to support different types of plugin.
Provide additional APIs in plugins if necessary to accomplish the arithmetic operations.
By doing arithmetic for target address in libomptarget you are assuming the pointer size is 64.
Aug 10 2018
Alex: If you feel strongly about your request, I will be happy to move the code into CheckDeviceAndCtors.
It is just a suggestion. Either way is fine.
Aug 9 2018
Aug 2 2018
It may be named libOMPtarget and is in openmp projects but we want to use the offloading library with other runtime libraries.
We should not be having calls to _-kmpc_omp_taskwait in libomptarget.
The wait should be done in the user code and then libomptarget routine should be called.
Mar 16 2018
DEFAULT implies MANDATORY or DISABLED. Don't need to communicate to libomp
Mar 15 2018
Openmp has defined OMP_TARGET_OFFLOAD to control offloading, We should be using this
Mar 7 2018
Jan 6 2016
OpenMP says : " If the corresponding list item is not present in the device data environment then no assignment occurs to or from the original list item."