Page MenuHomePhabricator

fghanim (Fady Ghanim)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 25 2019, 12:31 PM (13 w, 3 d)

Recent Activity

Yesterday

fghanim updated the diff for D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation.

Adding a new unittest for the this fix. Thanks to JDoerfert for Writing and providing me with this patch.

Sun, Jan 26, 11:37 AM · Restricted Project, Restricted Project

Thu, Jan 23

fghanim updated the diff for D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation.
  • Cleaning up some leftover code.
Thu, Jan 23, 1:15 PM · Restricted Project, Restricted Project
fghanim added a parent revision for D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation: D70258: [OpenMP][IR-Builder] Introduce the finalization stack.
Thu, Jan 23, 11:36 AM · Restricted Project, Restricted Project
fghanim added a child revision for D70258: [OpenMP][IR-Builder] Introduce the finalization stack: D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation.
Thu, Jan 23, 11:36 AM · Restricted Project, Restricted Project
fghanim created D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation.
Thu, Jan 23, 11:34 AM · Restricted Project, Restricted Project

Fri, Jan 17

fghanim added a comment to D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder..

No, I don't have commit privileges. I'd appreciate if you'd commit this for me. Thanks :)

Fri, Jan 17, 12:47 PM · Restricted Project, Restricted Project
fghanim updated the diff for D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder..

Addressing reviewer's comments regarding styling.

Fri, Jan 17, 12:38 PM · Restricted Project, Restricted Project
fghanim retitled D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder. from [OpenMP]{OMPIRBuilder] Add Directives (master and critical) to OMPBuilder. to [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder..
Fri, Jan 17, 6:20 AM · Restricted Project, Restricted Project

Thu, Jan 16

fghanim added a comment to D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder..

Thanks for reviewing this.

Thu, Jan 16, 1:08 PM · Restricted Project, Restricted Project
fghanim updated the diff for D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder..

Addressing reviewer's comments

  • fixed styling and naming according to llvm conventions
Thu, Jan 16, 1:07 PM · Restricted Project, Restricted Project

Wed, Jan 15

fghanim updated the diff for D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder..

Addressing reviewer comments

  • Added regression tests
  • styling
  • adding asserts and todo where needed.
Wed, Jan 15, 9:36 AM · Restricted Project, Restricted Project

Sun, Jan 12

fghanim added a comment to D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder..

I am working on a patch. In the mean time ;)

Sun, Jan 12, 2:43 PM · Restricted Project, Restricted Project
fghanim retitled D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder. from Summary: Add OpenMP Directives (master and critical) to OMPBuilder, and use them in clang. to [OpenMP]{OMPIRBuilder] Add Directives (master and critical) to OMPBuilder..
Sun, Jan 12, 2:18 PM · Restricted Project, Restricted Project

Sat, Jan 11

fghanim added a comment to D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder..

Commits need a message that explains the change.
Also the "Summary" should not be in the commit title.

Sat, Jan 11, 10:19 PM · Restricted Project, Restricted Project

Thu, Jan 9

fghanim updated the diff for D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder..
  • Adding array types to OMPKinds.def. Inlining runtime function calls generation. reformatting with clang format
Thu, Jan 9, 12:07 PM · Restricted Project, Restricted Project
fghanim added a comment to D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder..

So I modified the patch based on your comments. I removed all the code that I intended for llvm pass writers for now.
I will look at it again later, figure something to do with the whole switch-if-cascade thing, and will introduce it in a separate patch. I think that would be better than to include it here.

Thu, Jan 9, 12:07 PM · Restricted Project, Restricted Project

Tue, Jan 7

fghanim added a comment to D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder..

I don't think there is enough in this patch to split it into two or three patches. The main part is EmitOMPInlinedRegion which does all the heavy lifting. At this point, both create Master & Critical are almost wrappers collecting arguments for EmitOMPInlinedRegion. So I really do not want to split them into multiple patches unless I have to.

Tue, Jan 7, 2:48 PM · Restricted Project, Restricted Project

Mon, Jan 6

fghanim added a parent revision for D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.: D70258: [OpenMP][IR-Builder] Introduce the finalization stack.
Mon, Jan 6, 3:03 PM · Restricted Project, Restricted Project
fghanim added a child revision for D70258: [OpenMP][IR-Builder] Introduce the finalization stack: D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder..
Mon, Jan 6, 3:03 PM · Restricted Project, Restricted Project
fghanim created D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder..
Mon, Jan 6, 2:54 PM · Restricted Project, Restricted Project

Dec 12 2019

fghanim accepted D70290: [OpenMP] Use the OpenMPIRBuilder for "omp parallel".
Dec 12 2019, 6:07 AM · Restricted Project, Restricted Project

Nov 20 2019

fghanim accepted D70109: [OpenMP][IR-Builder] Introduce "pragma omp parallel" code generation.
Nov 20 2019, 11:43 AM · Restricted Project

Nov 18 2019

fghanim added a comment to D70109: [OpenMP][IR-Builder] Introduce "pragma omp parallel" code generation.

Generally acceptable, However wondering about future plans regarding:

  1. There are many aspects of the OMP parallel implementation that can be reused with other directives (i.e. 'If' clause, privatization clauses), any plans to outline?
  2. plans for implementing reduction clause?
Nov 18 2019, 11:44 AM · Restricted Project

Nov 4 2019

fghanim added inline comments to D69785: [OpenMP] Introduce the OpenMP-IR-Builder.
Nov 4 2019, 10:28 AM · Restricted Project, Restricted Project