Page MenuHomePhabricator

gtbercea (Gheorghe-Teodor Bercea)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 29 2016, 12:44 AM (138 w, 1 d)

Recent Activity

Fri, Aug 9

gtbercea committed rG0fd073b1bff8: [OpenMP] Add support for close map modifier in Clang (authored by gtbercea).
[OpenMP] Add support for close map modifier in Clang
Fri, Aug 9, 2:45 PM
gtbercea committed rG6c7b882e525d: [OpenMP][libomptarget] Add support for close map modifier (authored by gtbercea).
[OpenMP][libomptarget] Add support for close map modifier
Fri, Aug 9, 2:37 PM
gtbercea updated the diff for D65340: [OpenMP][libomptarget] Add support for close map modifier.
  • Simplify target region.
Fri, Aug 9, 2:20 PM · Restricted Project, Restricted Project
gtbercea added inline comments to D65340: [OpenMP][libomptarget] Add support for close map modifier.
Fri, Aug 9, 12:42 PM · Restricted Project, Restricted Project
gtbercea updated the diff for D65340: [OpenMP][libomptarget] Add support for close map modifier.
  • Rebase.
Fri, Aug 9, 12:39 PM · Restricted Project, Restricted Project
gtbercea updated the diff for D65340: [OpenMP][libomptarget] Add support for close map modifier.
  • Add back requires registration call.
Fri, Aug 9, 12:11 PM · Restricted Project, Restricted Project
gtbercea added inline comments to D65340: [OpenMP][libomptarget] Add support for close map modifier.
Fri, Aug 9, 11:39 AM · Restricted Project, Restricted Project
gtbercea added a comment to D65340: [OpenMP][libomptarget] Add support for close map modifier.

I disagree, the information about requires directives only needs to be present when initializing the device, not when loading a library. I've posted D66019 to solve this and fix the test I mentioned in D65001.

Fri, Aug 9, 11:35 AM · Restricted Project, Restricted Project
gtbercea accepted D66019: [libomptarget] Remove duplicate RTLRequiresFlags per device.
Fri, Aug 9, 11:35 AM · Restricted Project, Restricted Project
gtbercea added a comment to D66019: [libomptarget] Remove duplicate RTLRequiresFlags per device.

I see what you mean! I was working on a patch for adding a new method for manually setting the flag but this works too if we don't have to have a per device flag.

Fri, Aug 9, 11:35 AM · Restricted Project, Restricted Project
gtbercea added inline comments to D65340: [OpenMP][libomptarget] Add support for close map modifier.
Fri, Aug 9, 9:54 AM · Restricted Project, Restricted Project
gtbercea added a comment to D65340: [OpenMP][libomptarget] Add support for close map modifier.

@Hahnfeld
I would like to clarify something about tgt_register_requires call.

Fri, Aug 9, 9:50 AM · Restricted Project, Restricted Project
gtbercea added inline comments to D65340: [OpenMP][libomptarget] Add support for close map modifier.
Fri, Aug 9, 9:36 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65340: [OpenMP][libomptarget] Add support for close map modifier.
  • Remove requires manual call.
Fri, Aug 9, 9:36 AM · Restricted Project, Restricted Project
gtbercea added inline comments to D65340: [OpenMP][libomptarget] Add support for close map modifier.
Fri, Aug 9, 9:00 AM · Restricted Project, Restricted Project
gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Fri, Aug 9, 7:55 AM · Restricted Project, Restricted Project
gtbercea added inline comments to D65340: [OpenMP][libomptarget] Add support for close map modifier.
Fri, Aug 9, 7:39 AM · Restricted Project, Restricted Project
gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Fri, Aug 9, 7:24 AM · Restricted Project, Restricted Project

Thu, Aug 8

gtbercea added a comment to D65340: [OpenMP][libomptarget] Add support for close map modifier.

I don't have any comments about this patch other than the ones @Hahnfeld mentioned.

Thu, Aug 8, 12:22 PM · Restricted Project, Restricted Project
gtbercea added a comment to D65340: [OpenMP][libomptarget] Add support for close map modifier.

@Hahnfeld @grokos any further comments?

Thu, Aug 8, 7:30 AM · Restricted Project, Restricted Project

Wed, Aug 7

gtbercea added a comment to D65340: [OpenMP][libomptarget] Add support for close map modifier.

@grokos I have updated this patch as suggested and have added new tests. Please let me know if you any further comments.

Wed, Aug 7, 10:49 AM · Restricted Project, Restricted Project
gtbercea committed rGa1d20506e771: [OpenMP][libomptarget] Add support for unified memory for regular maps (authored by gtbercea).
[OpenMP][libomptarget] Add support for unified memory for regular maps
Wed, Aug 7, 10:30 AM

Tue, Aug 6

gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Tue, Aug 6, 2:14 PM · Restricted Project, Restricted Project
gtbercea updated the diff for D65340: [OpenMP][libomptarget] Add support for close map modifier.
  • Update.
Tue, Aug 6, 1:11 PM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Clean up conditions.
Tue, Aug 6, 1:03 PM · Restricted Project, Restricted Project
gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Tue, Aug 6, 12:43 PM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Move condition.
Tue, Aug 6, 12:43 PM · Restricted Project, Restricted Project
gtbercea added a comment to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.

@grokos any thoughts on the updated condition?

Tue, Aug 6, 11:40 AM · Restricted Project, Restricted Project
gtbercea added a comment to D65340: [OpenMP][libomptarget] Add support for close map modifier.

@Hahnfeld I have updated the tests, I added two new ones. Let me know if you have any further comments.

Tue, Aug 6, 11:40 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65340: [OpenMP][libomptarget] Add support for close map modifier.
  • Clean test.
Tue, Aug 6, 11:37 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65340: [OpenMP][libomptarget] Add support for close map modifier.
  • Clean-up.
Tue, Aug 6, 11:23 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65340: [OpenMP][libomptarget] Add support for close map modifier.
  • Add unsupported clang versions to test.
  • Add more tests.
Tue, Aug 6, 11:21 AM · Restricted Project, Restricted Project
gtbercea added a comment to D65340: [OpenMP][libomptarget] Add support for close map modifier.

The test will currently fail with older versions of Clang. It must at least be marked UNSUPPORTED for Clang versions older than what-will-be Clang 10.

Additionally, I'd still like to see a small test with manual calls to __tgt_target_data_begin / _end if possible. I'm thinking of the following:

int *a = // malloc
int *device;

__tgt_target_data_begin(...); // with close modifier for a
#pragma omp target data use_device_ptr(a)
{
  device = a;
}
__tgt_target_data_end(...); // correspondingly to the begin call above

// check...

Instead of the nested target data region, you could also use a simple target region in the outer data region, and have a check for use_device_ptr in another test.

Tue, Aug 6, 7:46 AM · Restricted Project, Restricted Project

Mon, Aug 5

gtbercea added a comment to D65340: [OpenMP][libomptarget] Add support for close map modifier.

@Hahnfeld I have addressed your comments, please let me know if you have further comments.

Mon, Aug 5, 11:56 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65340: [OpenMP][libomptarget] Add support for close map modifier.
  • Remove close flag from checks where it is not needed.
Mon, Aug 5, 11:49 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65340: [OpenMP][libomptarget] Add support for close map modifier.
  • Add back close modifier flag check.
Mon, Aug 5, 11:39 AM · Restricted Project, Restricted Project
gtbercea added inline comments to D65340: [OpenMP][libomptarget] Add support for close map modifier.
Mon, Aug 5, 11:29 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65340: [OpenMP][libomptarget] Add support for close map modifier.
  • Format test.
Mon, Aug 5, 11:25 AM · Restricted Project, Restricted Project
gtbercea added a comment to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.

@grokos I have updated the condition. I have also amended the comment to better explain the conditions.

Mon, Aug 5, 11:11 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Format tests.
Mon, Aug 5, 11:10 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Fix condition to exclude already mapped device data.
Mon, Aug 5, 8:14 AM · Restricted Project, Restricted Project
gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Mon, Aug 5, 7:44 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Fix condition again.
Mon, Aug 5, 7:42 AM · Restricted Project, Restricted Project

Fri, Aug 2

gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Fri, Aug 2, 11:59 AM · Restricted Project, Restricted Project
gtbercea added inline comments to D65340: [OpenMP][libomptarget] Add support for close map modifier.
Fri, Aug 2, 11:55 AM · Restricted Project, Restricted Project
gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Fri, Aug 2, 11:47 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Fix condition.
Fri, Aug 2, 11:34 AM · Restricted Project, Restricted Project

Thu, Aug 1

gtbercea committed rG625f59d19002: [OpenMP] Fix declare target link implementation (authored by gtbercea).
[OpenMP] Fix declare target link implementation
Thu, Aug 1, 2:18 PM
gtbercea updated the diff for D65340: [OpenMP][libomptarget] Add support for close map modifier.
  • Update.
Thu, Aug 1, 12:52 PM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Clean-up.
Thu, Aug 1, 12:50 PM · Restricted Project, Restricted Project
gtbercea updated the diff for D65340: [OpenMP][libomptarget] Add support for close map modifier.
  • Address comments.
Thu, Aug 1, 12:17 PM · Restricted Project, Restricted Project
gtbercea added inline comments to D65341: [OpenMP] Add support for close map modifier in Clang.
Thu, Aug 1, 11:05 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Add manual for registering the requires flag.
  • Address comments.
Thu, Aug 1, 10:59 AM · Restricted Project, Restricted Project
gtbercea added a comment to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.

There's still no call to __tgt_register_requires in the two tests, so I guess they won't pass with older versions of Clang.

Thu, Aug 1, 9:21 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65340: [OpenMP][libomptarget] Add support for close map modifier.
  • Add close modifier flag.
  • Move test to appropriate folder.
Thu, Aug 1, 8:52 AM · Restricted Project, Restricted Project
gtbercea added a comment to D65341: [OpenMP] Add support for close map modifier in Clang.

@Hahnfeld I have merged the tests from the previous patch as per Alexey's suggestion - with minor changes to make them pass. Let me know if this now addresses your previous comments.

Thu, Aug 1, 8:08 AM · Restricted Project, Restricted Project
gtbercea updated the summary of D65341: [OpenMP] Add support for close map modifier in Clang.
Thu, Aug 1, 8:07 AM · Restricted Project, Restricted Project
gtbercea updated the summary of D65341: [OpenMP] Add support for close map modifier in Clang.
Thu, Aug 1, 8:06 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65341: [OpenMP] Add support for close map modifier in Clang.
  • Improve test.
  • Add tests from previous patch.
Thu, Aug 1, 8:05 AM · Restricted Project, Restricted Project
gtbercea added a comment to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.

@Hahnfeld I hope I have answered all your concerns. Please let me know if you have any other comments.

Thu, Aug 1, 6:59 AM · Restricted Project, Restricted Project

Wed, Jul 31

gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Wed, Jul 31, 1:11 PM · Restricted Project, Restricted Project
gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Wed, Jul 31, 12:42 PM · Restricted Project, Restricted Project
gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Wed, Jul 31, 10:33 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Rename test.
  • Revert file move. Simplify condition.
  • Address comments.
Wed, Jul 31, 10:33 AM · Restricted Project, Restricted Project
gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Wed, Jul 31, 7:17 AM · Restricted Project, Restricted Project
gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Wed, Jul 31, 7:15 AM · Restricted Project, Restricted Project

Tue, Jul 30

gtbercea added a comment to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.

@Hahnfeld @grokos new version of the patch with addressed comments.

Tue, Jul 30, 2:10 PM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Move tests to new folder.
  • Fix tests.
  • Move requires test.
Tue, Jul 30, 2:08 PM · Restricted Project, Restricted Project
gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Tue, Jul 30, 1:35 PM · Restricted Project, Restricted Project
gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Tue, Jul 30, 1:32 PM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Address comments.
Tue, Jul 30, 1:32 PM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Remove use device ptr flag.
Tue, Jul 30, 1:15 PM · Restricted Project, Restricted Project
gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Tue, Jul 30, 9:00 AM · Restricted Project, Restricted Project

Mon, Jul 29

gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Mon, Jul 29, 12:07 PM · Restricted Project, Restricted Project
gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Mon, Jul 29, 11:52 AM · Restricted Project, Restricted Project
gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Mon, Jul 29, 11:45 AM · Restricted Project, Restricted Project
gtbercea added a comment to D65341: [OpenMP] Add support for close map modifier in Clang.

There's already D55892 with a better set of tests, including target enter data / target exit data.

Better to merge those two patches into one.

How would you like me to proceed? It looks like the other patch has been sitting there approved for many many months.

Yes, the patch has been waiting for the runtime implementation first and then commit.

Mon, Jul 29, 8:41 AM · Restricted Project, Restricted Project
gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Mon, Jul 29, 8:41 AM · Restricted Project, Restricted Project
gtbercea added a comment to D65341: [OpenMP] Add support for close map modifier in Clang.

There's already D55892 with a better set of tests, including target enter data / target exit data.

Better to merge those two patches into one.

Mon, Jul 29, 8:28 AM · Restricted Project, Restricted Project
gtbercea added a comment to D65340: [OpenMP][libomptarget] Add support for close map modifier.

I think this mostly looks good, but depends on D65001, right?

Mon, Jul 29, 8:11 AM · Restricted Project, Restricted Project
gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Mon, Jul 29, 8:03 AM · Restricted Project, Restricted Project

Fri, Jul 26

gtbercea updated the diff for D65341: [OpenMP] Add support for close map modifier in Clang.
  • Improve test.
Fri, Jul 26, 2:55 PM · Restricted Project, Restricted Project
gtbercea added inline comments to D65341: [OpenMP] Add support for close map modifier in Clang.
Fri, Jul 26, 12:36 PM · Restricted Project, Restricted Project
gtbercea added a reviewer for D65340: [OpenMP][libomptarget] Add support for close map modifier: AlexEichenberger.
Fri, Jul 26, 10:59 AM · Restricted Project, Restricted Project
gtbercea created D65341: [OpenMP] Add support for close map modifier in Clang.
Fri, Jul 26, 10:58 AM · Restricted Project, Restricted Project
gtbercea created D65340: [OpenMP][libomptarget] Add support for close map modifier.
Fri, Jul 26, 10:56 AM · Restricted Project, Restricted Project
gtbercea added a comment to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.

@Hahnfeld I added several tests. Because these tests require unified memory to be supported by the underlying system I have added them as a new type of test: check-libomptarget-nvptx-unified (in addition to the check-libomptarget-nvptx one). These tests should only be run on platforms which support unified memory.

Can we instead have the tests work with the host plugins? That would be much easier. (Sorry, don't have the time to look at the tests right now)

Fri, Jul 26, 10:25 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Add tests.
Fri, Jul 26, 10:25 AM · Restricted Project, Restricted Project

Thu, Jul 25

gtbercea added a comment to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.

@Hahnfeld I added several tests. Because these tests require unified memory to be supported by the underlying system I have added them as a new type of test: check-libomptarget-nvptx-unified (in addition to the check-libomptarget-nvptx one). These tests should only be run on platforms which support unified memory.

Thu, Jul 25, 6:18 AM · Restricted Project, Restricted Project

Jul 24 2019

gtbercea added a reviewer for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps: grokos.
Jul 24 2019, 10:52 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Improve test.
Jul 24 2019, 8:21 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Remove default device env var.
Jul 24 2019, 7:37 AM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Add tests.
Jul 24 2019, 7:26 AM · Restricted Project, Restricted Project

Jul 23 2019

gtbercea added a comment to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.

@Hahnfeld can you list the tests you would like to see please? And then I'll add them.

Jul 23 2019, 6:51 AM · Restricted Project, Restricted Project
gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Jul 23 2019, 6:49 AM · Restricted Project, Restricted Project

Jul 22 2019

gtbercea added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Jul 22 2019, 1:55 PM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Address comments.
Jul 22 2019, 1:55 PM · Restricted Project, Restricted Project

Jul 19 2019

gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Clean-up.
Jul 19 2019, 3:16 PM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Clean-up.
Jul 19 2019, 2:29 PM · Restricted Project, Restricted Project
gtbercea updated the diff for D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
  • Add TO FLAG.
  • Fix comment.
  • Fix condition.
  • Add TO FLAG.
  • Add support for unified memory for regular target regions.
  • Fix enum.
  • Add IsLast unified memory case.
  • Add early exit from RTL data submit, retrieve and delete functions. To be confirmed if fully correct.
  • Add prints.
  • Add fixes for unified memory and normal maps.
  • Add arg for tracking whether a host address is returned instead of a device one in target data begin.
  • Fix mapping of structs.
  • Fix rebase.
  • Fix code.
  • Remove the need to add a parameter to data delete function.
Jul 19 2019, 2:25 PM · Restricted Project, Restricted Project