- User Since
- Dec 29 2016, 12:44 AM (94 w, 5 d)
Fri, Oct 19
Thu, Oct 11
Simply call to common push function.
Ensure PushSize is multiple of 8 bytes.
Mon, Oct 1
Fri, Sep 28
Thu, Sep 27
Fix type of chunk size.
Wed, Sep 26
Due to most recent proposed changes to Clang in D52434, changes to the runtime are no longer required.
Only change default schedule for distribute directive.
Mon, Sep 24
Sep 21 2018
Sep 14 2018
Sep 11 2018
Considering your comment in the description about requiring latest Clang perhaps you should revisit this patch: D46842
Aug 30 2018
Aug 29 2018
Aug 27 2018
Add implicit cast.
Aug 24 2018
LG unless other reviewers have objections.
Aug 23 2018
Aug 16 2018
Aug 14 2018
Add __NO_MATH_INLINES macro for the NVPTX toolchain to prevent any host assembly from seeping onto the device.
Just to address any generality concerns:
Thanks @Hahnfeld for your suggestions.
Aug 10 2018
I don't want to use a fast `pow(a, 2)`, I don't want to call a library function for that at all.
The downside of this approach is that LLVM doesn't recognize these function calls and doesn't perform optimizations to fold libcalls. For example pow(a, 2) is transformed into a multiplication but __nv_pow(a, 2) is not.
Aug 8 2018
@Hahnfeld do you get the same error if you compile with clang++ instead of clang?
IIRC you started to work on this to fix the problem with inline assembly (see https://reviews.llvm.org/D47849#1125019). AFAICS this patch fixes declarations of math functions but you still cannot include math.h which most "correct" codes do.
Ok, so you are already talking about performance. I think we should fix correctness first, in particular the compiler shouldn't complain whenever <math.h> is included.
Aug 7 2018
Prevent math builtins from being used for nvptx toolchain.
- Address comments.
Aug 6 2018
Fix function call.
Aug 2 2018
No longer needed for trunk.
These calls are here because they require the interface of libomp library include these functions. A patch for Clang is in the works which calls these functions so they need to have some basic, correct implementation that works when used with libomp.
The implementation can/should be improved in the future. In our proprietary OpenMP library implementation we already do something more elaborate which is why we need the placeholders here.
Aug 1 2018
Jul 31 2018
Answers to comments.
Jul 30 2018
Jul 20 2018
Jul 13 2018
Jul 12 2018
Address comments and fix formatting.
Jul 11 2018
Reset StackP correctly.
Is this good to go?
Add test for spmd stack init function.