Page MenuHomePhabricator

gtbercea (Gheorghe-Teodor Bercea)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 29 2016, 12:44 AM (120 w, 1 d)

Recent Activity

Yesterday

gtbercea committed rGe94e0eb0c48f: [OpenMP][NFC] Fix requires target test. (authored by gtbercea).
[OpenMP][NFC] Fix requires target test.
Thu, Apr 18, 1:36 PM
gtbercea created D60886: [OpenMP][NFC] Fix requires target test..
Thu, Apr 18, 1:29 PM · Restricted Project
gtbercea committed rG411a62403f7e: [OpenMP] Add checks for requires and target directives. (authored by gtbercea).
[OpenMP] Add checks for requires and target directives.
Thu, Apr 18, 12:53 PM
gtbercea updated the diff for D60223: [OpenMP][libomptarget] Enable requires flags for target libraries. Support for target link variables when unified memory is enabled.

Update

Thu, Apr 18, 12:23 PM · Restricted Project
gtbercea added a child revision for D60223: [OpenMP][libomptarget] Enable requires flags for target libraries. Support for target link variables when unified memory is enabled: D60884: [OpenMP][libomptarget] Enable usage of unified memory for declare target link variables.
Thu, Apr 18, 12:08 PM · Restricted Project
gtbercea added a parent revision for D60884: [OpenMP][libomptarget] Enable usage of unified memory for declare target link variables: D60223: [OpenMP][libomptarget] Enable requires flags for target libraries. Support for target link variables when unified memory is enabled.
Thu, Apr 18, 12:08 PM · Restricted Project
gtbercea created D60884: [OpenMP][libomptarget] Enable usage of unified memory for declare target link variables.
Thu, Apr 18, 12:08 PM · Restricted Project
gtbercea created D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used.
Thu, Apr 18, 12:02 PM · Restricted Project
gtbercea updated the diff for D60875: [OpenMP] Add checks for requires and target directives..
  • Lower case.
Thu, Apr 18, 11:40 AM · Restricted Project
gtbercea updated the diff for D60568: [OpenMP] Add support for registering requires directives with the runtime.
  • Move error check in sema.
Thu, Apr 18, 10:18 AM · Restricted Project
gtbercea updated the diff for D60875: [OpenMP] Add checks for requires and target directives..
  • Fix.
Thu, Apr 18, 9:56 AM · Restricted Project
gtbercea updated the diff for D60875: [OpenMP] Add checks for requires and target directives..
  • Fix.
Thu, Apr 18, 9:51 AM · Restricted Project
gtbercea updated the diff for D60875: [OpenMP] Add checks for requires and target directives..
  • Fix test.
Thu, Apr 18, 9:47 AM · Restricted Project
gtbercea updated the diff for D60875: [OpenMP] Add checks for requires and target directives..
Fix test,
Thu, Apr 18, 9:35 AM · Restricted Project
gtbercea created D60875: [OpenMP] Add checks for requires and target directives..
Thu, Apr 18, 9:26 AM · Restricted Project
gtbercea updated the diff for D60568: [OpenMP] Add support for registering requires directives with the runtime.
  • Add const.
  • Address comments.
Thu, Apr 18, 7:53 AM · Restricted Project
gtbercea added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Thu, Apr 18, 7:32 AM · Restricted Project

Wed, Apr 17

gtbercea updated the diff for D60568: [OpenMP] Add support for registering requires directives with the runtime.
  • Update tests.
  • Move error check in sema.
Wed, Apr 17, 3:31 PM · Restricted Project
gtbercea added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Wed, Apr 17, 11:44 AM · Restricted Project
gtbercea updated the diff for D60568: [OpenMP] Add support for registering requires directives with the runtime.
  • Update error message.
Wed, Apr 17, 11:42 AM · Restricted Project
gtbercea updated the diff for D60568: [OpenMP] Add support for registering requires directives with the runtime.
  • Add support for declare target routines.
Wed, Apr 17, 11:33 AM · Restricted Project

Tue, Apr 16

gtbercea added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Tue, Apr 16, 12:37 PM · Restricted Project
gtbercea added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Tue, Apr 16, 11:48 AM · Restricted Project
gtbercea added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Tue, Apr 16, 10:21 AM · Restricted Project
gtbercea added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Tue, Apr 16, 10:18 AM · Restricted Project
gtbercea updated the diff for D60223: [OpenMP][libomptarget] Enable requires flags for target libraries. Support for target link variables when unified memory is enabled.
  • Update patch.
Tue, Apr 16, 9:07 AM · Restricted Project
gtbercea added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Tue, Apr 16, 9:01 AM · Restricted Project
gtbercea updated the diff for D60568: [OpenMP] Add support for registering requires directives with the runtime.
  • Fix checks for use of requires directive.
Tue, Apr 16, 8:51 AM · Restricted Project

Mon, Apr 15

gtbercea added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Mon, Apr 15, 9:12 AM · Restricted Project
gtbercea updated the diff for D60568: [OpenMP] Add support for registering requires directives with the runtime.
  • Remove const.
Mon, Apr 15, 8:58 AM · Restricted Project
gtbercea added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Mon, Apr 15, 8:44 AM · Restricted Project
gtbercea updated the diff for D60568: [OpenMP] Add support for registering requires directives with the runtime.
  • Add break.
Mon, Apr 15, 8:43 AM · Restricted Project
gtbercea added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Mon, Apr 15, 8:43 AM · Restricted Project
gtbercea updated the diff for D60568: [OpenMP] Add support for registering requires directives with the runtime.
  • Fix type.
Mon, Apr 15, 8:29 AM · Restricted Project
gtbercea updated the diff for D60568: [OpenMP] Add support for registering requires directives with the runtime.
  • Remove atomic flags.
Mon, Apr 15, 8:15 AM · Restricted Project
gtbercea updated the diff for D60568: [OpenMP] Add support for registering requires directives with the runtime.
  • Address comments.
Mon, Apr 15, 8:06 AM · Restricted Project

Thu, Apr 11

gtbercea updated the diff for D60568: [OpenMP] Add support for registering requires directives with the runtime.
  • Handle OpenMP simd case.
Thu, Apr 11, 4:10 PM · Restricted Project
gtbercea updated the diff for D60568: [OpenMP] Add support for registering requires directives with the runtime.
  • Split patch.
Thu, Apr 11, 2:24 PM · Restricted Project
gtbercea accepted D60578: [OPENMP][NVPTX]Fix dynamic scheduling in L2+ SPMD parallel regions..

LGTM

Thu, Apr 11, 2:15 PM · Restricted Project
gtbercea updated the diff for D60568: [OpenMP] Add support for registering requires directives with the runtime.
  • Fix enum.
Thu, Apr 11, 2:14 PM · Restricted Project
gtbercea added inline comments to D60568: [OpenMP] Add support for registering requires directives with the runtime.
Thu, Apr 11, 1:46 PM · Restricted Project
gtbercea updated the diff for D60568: [OpenMP] Add support for registering requires directives with the runtime.
  • Address comments.
Thu, Apr 11, 1:46 PM · Restricted Project
gtbercea updated the diff for D60568: [OpenMP] Add support for registering requires directives with the runtime.
  • Address comments.
Thu, Apr 11, 1:40 PM · Restricted Project
gtbercea created D60568: [OpenMP] Add support for registering requires directives with the runtime.
Thu, Apr 11, 8:48 AM · Restricted Project

Wed, Apr 10

gtbercea updated the diff for D60223: [OpenMP][libomptarget] Enable requires flags for target libraries. Support for target link variables when unified memory is enabled.
  • Fix checks and default flag.
Wed, Apr 10, 2:32 PM · Restricted Project

Mon, Apr 8

gtbercea retitled D60223: [OpenMP][libomptarget] Enable requires flags for target libraries. Support for target link variables when unified memory is enabled from [OpenMP][libomptarget] Add support for target link variables when unified memory is enabled to [OpenMP][libomptarget] Enable requires flags for target libraries. Support for target link variables when unified memory is enabled.
Mon, Apr 8, 12:18 PM · Restricted Project
gtbercea updated the diff for D60223: [OpenMP][libomptarget] Enable requires flags for target libraries. Support for target link variables when unified memory is enabled.
  • Update patch.
Mon, Apr 8, 12:14 PM · Restricted Project

Wed, Apr 3

gtbercea updated the diff for D60223: [OpenMP][libomptarget] Enable requires flags for target libraries. Support for target link variables when unified memory is enabled.
  • Fix size.
Wed, Apr 3, 12:20 PM · Restricted Project
gtbercea updated the diff for D60223: [OpenMP][libomptarget] Enable requires flags for target libraries. Support for target link variables when unified memory is enabled.
  • Fix comment.
Wed, Apr 3, 12:02 PM · Restricted Project
gtbercea updated the diff for D60223: [OpenMP][libomptarget] Enable requires flags for target libraries. Support for target link variables when unified memory is enabled.
  • Fix comment.
Wed, Apr 3, 12:01 PM · Restricted Project
gtbercea updated the diff for D60223: [OpenMP][libomptarget] Enable requires flags for target libraries. Support for target link variables when unified memory is enabled.

Remove line.

Wed, Apr 3, 12:01 PM · Restricted Project
gtbercea created D60223: [OpenMP][libomptarget] Enable requires flags for target libraries. Support for target link variables when unified memory is enabled.
Wed, Apr 3, 11:53 AM · Restricted Project

Fri, Mar 22

gtbercea added a comment to D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls.

Thank you both for the feedback.

Fri, Mar 22, 11:48 AM · Restricted Project

Mar 6 2019

gtbercea added a comment to D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries.

For now this patch doesn't make sense until the main linking patch lands but it's a case we need to keep in mind.

Mar 6 2019, 12:19 PM · Restricted Project
gtbercea added a child revision for D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain: D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries.
Mar 6 2019, 12:18 PM · Restricted Project
gtbercea added a parent revision for D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries: D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain.
Mar 6 2019, 12:18 PM · Restricted Project
gtbercea added inline comments to D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries.
Mar 6 2019, 10:47 AM · Restricted Project
gtbercea added inline comments to D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries.
Mar 6 2019, 10:24 AM · Restricted Project
gtbercea added inline comments to D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries.
Mar 6 2019, 10:18 AM · Restricted Project
gtbercea created D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries.
Mar 6 2019, 8:51 AM · Restricted Project

Feb 22 2019

gtbercea added a comment to D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain.

ping

Feb 22 2019, 1:42 PM · Restricted Project
gtbercea updated the diff for D47394: [OpenMP][Clang][NVPTX] Replace bundling with partial linking for the OpenMP NVPTX device offloading toolchain.
  • Update.
Feb 22 2019, 1:42 PM · Restricted Project

Feb 20 2019

gtbercea committed rG06e08f0b0ad7: [OpenMP][libomptarget] New reduction scheme for team reductions (authored by gtbercea).
[OpenMP][libomptarget] New reduction scheme for team reductions
Feb 20 2019, 6:56 AM

Feb 19 2019

gtbercea updated the summary of D58409: [OpenMP][libomptarget] New reduction scheme for team reductions.
Feb 19 2019, 2:56 PM · Restricted Project
gtbercea created D58409: [OpenMP][libomptarget] New reduction scheme for team reductions.
Feb 19 2019, 2:56 PM · Restricted Project

Jan 18 2019

gtbercea accepted D56733: [OPENMP] update release note for implemented OMP 5.0 features.

Thanks for the update!

Jan 18 2019, 10:48 AM · Restricted Project

Jan 17 2019

gtbercea added inline comments to D56733: [OPENMP] update release note for implemented OMP 5.0 features.
Jan 17 2019, 1:41 PM · Restricted Project
gtbercea added a comment to D56733: [OPENMP] update release note for implemented OMP 5.0 features.

Could we add the changes in D56790 to this diff?

Sure, I will do that.

Jan 17 2019, 1:10 PM · Restricted Project

Jan 16 2019

gtbercea added a comment to D56733: [OPENMP] update release note for implemented OMP 5.0 features.

Could we add the changes in D56790 to this diff?

Jan 16 2019, 12:09 PM · Restricted Project
gtbercea created D56790: [OpenMP] Update release notes with OpenMP related changes.
Jan 16 2019, 9:12 AM

Jan 9 2019

gtbercea added inline comments to D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter.
Jan 9 2019, 12:15 PM
gtbercea updated the diff for D55773: [OpenMP][libomptarget] Use shared memory variable for tracking parallel level.
  • Fix.
Jan 9 2019, 9:09 AM
gtbercea updated the diff for D55773: [OpenMP][libomptarget] Use shared memory variable for tracking parallel level.
  • Fix.
Jan 9 2019, 9:05 AM
gtbercea updated the diff for D55773: [OpenMP][libomptarget] Use shared memory variable for tracking parallel level.
  • Add slot initialization.
Jan 9 2019, 8:58 AM
gtbercea added inline comments to D55773: [OpenMP][libomptarget] Use shared memory variable for tracking parallel level.
Jan 9 2019, 6:46 AM

Jan 8 2019

gtbercea updated the diff for D55773: [OpenMP][libomptarget] Use shared memory variable for tracking parallel level.
  • Use new sync.
Jan 8 2019, 1:49 PM
gtbercea updated the diff for D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest..
Fix.
Jan 8 2019, 1:01 PM
gtbercea added a comment to D55773: [OpenMP][libomptarget] Use shared memory variable for tracking parallel level.

ping

Jan 8 2019, 12:27 PM
gtbercea updated the diff for D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest..

Remove redundant initalization.

Jan 8 2019, 11:54 AM
gtbercea updated the diff for D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest..

Fix update.

Jan 8 2019, 11:41 AM
gtbercea updated the diff for D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest..
Invert accumulation direction.
Jan 8 2019, 11:40 AM

Jan 7 2019

gtbercea created D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest..
Jan 7 2019, 2:09 PM

Dec 20 2018

gtbercea added inline comments to D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter.
Dec 20 2018, 7:43 AM
gtbercea updated the diff for D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter.
  • Address comments.
Dec 20 2018, 7:40 AM
gtbercea added inline comments to D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter.
Dec 20 2018, 7:25 AM
gtbercea updated the diff for D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter.
  • Address comments.
Dec 20 2018, 7:24 AM
gtbercea created D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter.
Dec 20 2018, 6:42 AM

Dec 17 2018

gtbercea created D55773: [OpenMP][libomptarget] Use shared memory variable for tracking parallel level.
Dec 17 2018, 8:44 AM
gtbercea created D55772: [OpenMP][libomptarget] Suppress C++ 11 related warnings when building libomptarget-nvptx bitcode library.
Dec 17 2018, 8:39 AM · Restricted Project

Dec 10 2018

gtbercea accepted D55514: [OPENMP][NVPTX]Revert __kmpc_shuffle_int64 to its original form..

LG

Dec 10 2018, 8:41 AM

Dec 7 2018

gtbercea accepted D55440: [OPENMP][NVPTX]Enable fast shuffles on 64bit values only if CUDA >= 9..

LG

Dec 7 2018, 2:10 PM
gtbercea accepted D55436: [OPENMP][NVPTX]Save registers for optimized builds with enabled logging..

LG

Dec 7 2018, 7:41 AM

Dec 6 2018

gtbercea accepted D55379: [OPENMP][NVPTX]Correct type casting for printf args + simplified shfl64 function..

LG

Dec 6 2018, 11:49 AM
gtbercea accepted D55370: [OPENMP][NVPTX]Fix __kmpc_flush to flush the memory per system, not per block..

LG

Dec 6 2018, 7:20 AM

Dec 3 2018

gtbercea created D55219: [OpenMP][libomptarget] Flush intermediate values during team reduction .
Dec 3 2018, 7:16 AM

Nov 30 2018

gtbercea accepted D55130: [OPENMP][NVPTX]Make runtime compatible with the original runtime..

LGTM

Nov 30 2018, 8:37 AM

Nov 29 2018

gtbercea added a comment to D54342: Add omp_get_device_num() and update several other device API functions.

After this patch, omp_get_num_devices() seems to wrongly return 0 even when devices are present.

Nov 29 2018, 2:22 PM · Restricted Project

Nov 27 2018

gtbercea updated the diff for D54970: [OpenMP] Add a new version of the SPMD deinit kernel function.
Add constant values to function calls.
Nov 27 2018, 1:47 PM
gtbercea updated the diff for D54970: [OpenMP] Add a new version of the SPMD deinit kernel function.
Delete old function.
Nov 27 2018, 1:19 PM
gtbercea updated the diff for D54969: [OpenMP][libomptarget] Add new version of SPMD deinit kernel function with argument.
Call new function in the old function.
Nov 27 2018, 1:15 PM