Page MenuHomePhabricator

jhuber6 (Joseph Huber)
User

Projects

User does not belong to any projects.

User Details

User Since
May 4 2020, 11:17 AM (29 w, 3 d)

Recent Activity

Thu, Nov 19

jhuber6 committed rGda8bec47ab8c: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging (authored by jhuber6).
[OpenMP] Add Location Fields to Libomptarget Runtime for Debugging
Thu, Nov 19, 9:03 AM
jhuber6 closed D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging.
Thu, Nov 19, 9:03 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Nov 18

jhuber6 updated the diff for D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging.

Rebasing

Wed, Nov 18, 1:45 PM · Restricted Project, Restricted Project, Restricted Project
jhuber6 committed rG5378c6a4bf94: [OpenMP] Add Support for Mapping Names in Libomptarget RTL (authored by jhuber6).
[OpenMP] Add Support for Mapping Names in Libomptarget RTL
Wed, Nov 18, 1:02 PM
jhuber6 committed rG97e55cfef5b8: [OpenMP] Add Passing in Original Declaration Names To Mapper API (authored by jhuber6).
[OpenMP] Add Passing in Original Declaration Names To Mapper API
Wed, Nov 18, 12:29 PM
jhuber6 updated the diff for D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API.

Fixing test that got changed.

Wed, Nov 18, 9:23 AM · Restricted Project, Restricted Project, Restricted Project
jhuber6 updated the diff for D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API.

Rebasing. Sorry I got it confused, @tianshilei1992 you said you had a crash using this patch, I haven't encountered any errors on my machine. Could you verify that this doesn't cause any issues for you?

Wed, Nov 18, 8:03 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Nov 16

jhuber6 accepted D91552: [OPENMP]Fix PR48076: mapping of data member pointer..

LGTM, fixed the problem on my machine and passes the unit tests.

Mon, Nov 16, 11:17 AM · Restricted Project

Fri, Nov 13

jhuber6 added a reviewer for D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API: ye-luo.
Fri, Nov 13, 12:39 PM · Restricted Project, Restricted Project, Restricted Project
jhuber6 updated the diff for D90172: [OpenMP] Add Support for Mapping Names in Libomptarget RTL.

Rebase.

Fri, Nov 13, 11:43 AM · Restricted Project
jhuber6 updated the diff for D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API.

Rebasing on master after D91370 fixed the tests. I could not reproduce your crash @ye-lou . This passed all the Clang checks and I didn't change anything in the code, could you check if this still doesn't work for you?

Fri, Nov 13, 10:18 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Nov 12

jhuber6 added a comment to D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front..

Could you try this patch:

diff --git a/clang/lib/CodeGen/CGOpenMPRuntime.cpp b/clang/lib/CodeGen/CGOpenMPRuntime.cpp
index ce8846140d4..854b7f3e830 100644
--- a/clang/lib/CodeGen/CGOpenMPRuntime.cpp
+++ b/clang/lib/CodeGen/CGOpenMPRuntime.cpp
@@ -9938,7 +9938,7 @@ void CGOpenMPRuntime::emitTargetCall(
           MappedVarSet.insert(CI->getCapturedVar());
         else
           MappedVarSet.insert(nullptr);
-        if (CurInfo.BasePointers.empty())
+        if (CurInfo.BasePointers.empty() && !PartialStruct.Base.isValid())
           MEHandler.generateDefaultMapInfo(*CI, **RI, *CV, CurInfo);
         // Generate correct mapping for variables captured by reference in
         // lambdas.
@@ -9947,7 +9947,7 @@ void CGOpenMPRuntime::emitTargetCall(
                                                   CurInfo, LambdaPointers);
       }
       // We expect to have at least an element of information for this capture.
-      assert(!CurInfo.BasePointers.empty() &&
+      assert((!CurInfo.BasePointers.empty() || PartialStruct.Base.isValid()) &&
              "Non-existing map pointer for capture!");
       assert(CurInfo.BasePointers.size() == CurInfo.Pointers.size() &&
              CurInfo.BasePointers.size() == CurInfo.Sizes.size() &&
Thu, Nov 12, 2:57 PM · Restricted Project
jhuber6 added a comment to D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front..

Could you try this patch:

diff --git a/clang/lib/CodeGen/CGOpenMPRuntime.cpp b/clang/lib/CodeGen/CGOpenMPRuntime.cpp
index ce8846140d4..854b7f3e830 100644
--- a/clang/lib/CodeGen/CGOpenMPRuntime.cpp
+++ b/clang/lib/CodeGen/CGOpenMPRuntime.cpp
@@ -9938,7 +9938,7 @@ void CGOpenMPRuntime::emitTargetCall(
           MappedVarSet.insert(CI->getCapturedVar());
         else
           MappedVarSet.insert(nullptr);
-        if (CurInfo.BasePointers.empty())
+        if (CurInfo.BasePointers.empty() && !PartialStruct.Base.isValid())
           MEHandler.generateDefaultMapInfo(*CI, **RI, *CV, CurInfo);
         // Generate correct mapping for variables captured by reference in
         // lambdas.
@@ -9947,7 +9947,7 @@ void CGOpenMPRuntime::emitTargetCall(
                                                   CurInfo, LambdaPointers);
       }
       // We expect to have at least an element of information for this capture.
-      assert(!CurInfo.BasePointers.empty() &&
+      assert((!CurInfo.BasePointers.empty() || PartialStruct.Base.isValid()) &&
              "Non-existing map pointer for capture!");
       assert(CurInfo.BasePointers.size() == CurInfo.Pointers.size() &&
              CurInfo.BasePointers.size() == CurInfo.Sizes.size() &&

It stopped the crashing but I'm not sure it's working as intended. The following program doesn't crash, but it doesn't change the value of s.p. Looking at the debug output it doesn't seem to be mapping the whole struct.

struct S {
  float f[50];
  double *p;
};
Thu, Nov 12, 2:55 PM · Restricted Project
jhuber6 added a comment to D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front..

From libomptarget. It must be different. Could you copy it here?

Thu, Nov 12, 12:57 PM · Restricted Project
jhuber6 added a comment to D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front..

LGTM then.

Any clue what the cause of the other problem is?

Could you try your test with the patch from D86119?

Still crashes after applying D86119.

Could you provide a debug log?

Thu, Nov 12, 12:51 PM · Restricted Project
jhuber6 added a comment to D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front..

LGTM then.

Any clue what the cause of the other problem is?

Could you try your test with the patch from D86119?

Thu, Nov 12, 12:45 PM · Restricted Project
jhuber6 accepted D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front..

LGTM then.

Thu, Nov 12, 11:58 AM · Restricted Project
jhuber6 added a comment to D91370: [OPENMP]Fix PR48076: Check map types array before accessing its front..

This stops it from crashing Clang, but I'm not sure if it's fixing the underlying problem. When I compile and run this program it crashes in libomptarget. If you get rid of the float f[50] in the struct it works as expected.

Thu, Nov 12, 11:48 AM · Restricted Project

Wed, Nov 11

jhuber6 committed rG292e898c16d1: [OpenMP] Begin Adding OpenMP Tool to Gather OpenMP Information (authored by jhuber6).
[OpenMP] Begin Adding OpenMP Tool to Gather OpenMP Information
Wed, Nov 11, 5:01 PM
jhuber6 closed D91085: [OpenMP] Begin Adding OpenMP Tool to Gather OpenMP Information.
Wed, Nov 11, 5:01 PM · Restricted Project
jhuber6 updated the diff for D91085: [OpenMP] Begin Adding OpenMP Tool to Gather OpenMP Information.

Fixing regex for C function names.

Wed, Nov 11, 4:56 PM · Restricted Project
jhuber6 updated the diff for D91085: [OpenMP] Begin Adding OpenMP Tool to Gather OpenMP Information.

Changing hard link to a symbolic link.

Wed, Nov 11, 1:40 PM · Restricted Project
jhuber6 updated the diff for D91085: [OpenMP] Begin Adding OpenMP Tool to Gather OpenMP Information.

Updating to remove some redundancy. The ++ variant is simply a link but it appears like that doesn't appear in the diff viewer.

Wed, Nov 11, 1:15 PM · Restricted Project

Mon, Nov 9

jhuber6 requested review of D91085: [OpenMP] Begin Adding OpenMP Tool to Gather OpenMP Information.
Mon, Nov 9, 8:08 AM · Restricted Project

Thu, Oct 29

jhuber6 accepted D90256: [OpenMP][Docs] Structure and content for the OpenMP documentation.

LGTM

Thu, Oct 29, 10:30 AM · Restricted Project

Wed, Oct 28

jhuber6 added a comment to D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API.

This patch caused segment fault in D90099 where the map variable info pointer is nullptr but it is deferenced.

Wed, Oct 28, 10:41 AM · Restricted Project, Restricted Project, Restricted Project

Oct 27 2020

jhuber6 updated the diff for D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging.

Updating after D90172 and D89802 landed. I don't see it failing the tests anymore but I'll look into it more. I should probably make a test for the source location stuff now that it will all be implemenated.

Oct 27 2020, 8:06 PM · Restricted Project, Restricted Project, Restricted Project
jhuber6 committed rGd981c7b7581e: [OpenMP] Add Support for Mapping Names in Libomptarget RTL (authored by jhuber6).
[OpenMP] Add Support for Mapping Names in Libomptarget RTL
Oct 27 2020, 1:59 PM
jhuber6 closed D90172: [OpenMP] Add Support for Mapping Names in Libomptarget RTL.
Oct 27 2020, 1:58 PM · Restricted Project
jhuber6 committed rGa87d7b3d448a: [OpenMP] Add Passing in Original Declaration Names To Mapper API (authored by jhuber6).
[OpenMP] Add Passing in Original Declaration Names To Mapper API
Oct 27 2020, 1:11 PM
jhuber6 closed D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API.
Oct 27 2020, 1:11 PM · Restricted Project, Restricted Project, Restricted Project
jhuber6 updated the diff for D90172: [OpenMP] Add Support for Mapping Names in Libomptarget RTL.

Changed name_t to map_var_info_t and renamed the Ident.h header.

Oct 27 2020, 10:20 AM · Restricted Project
jhuber6 updated the diff for D90172: [OpenMP] Add Support for Mapping Names in Libomptarget RTL.

Restructuring code to use type alias wrapper name_t to make it more obvious what the data is beyond a void *. Restructured Ident.h into a class with a constructor, this will have an extra constructor for the OpenMP Ident_t struct once D87946 is merged. Added a routine to print out the declaration site in the table dump using LIBOMPTARGET_INFO. For example, if I seg-fault in an OpenMP region using env LIBOMPTARGET_INFO=2 I will get this output for a sample program.

Oct 27 2020, 9:28 AM · Restricted Project

Oct 26 2020

jhuber6 added inline comments to D90172: [OpenMP] Add Support for Mapping Names in Libomptarget RTL.
Oct 26 2020, 4:34 PM · Restricted Project
jhuber6 updated the diff for D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API.

Changing to use the range iterators. There was a reason I did it like that initially but forgot to change it back.

Oct 26 2020, 4:31 PM · Restricted Project, Restricted Project, Restricted Project
jhuber6 requested review of D90172: [OpenMP] Add Support for Mapping Names in Libomptarget RTL.
Oct 26 2020, 10:40 AM · Restricted Project

Oct 22 2020

jhuber6 updated the diff for D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API.

Updating test

Oct 22 2020, 12:53 PM · Restricted Project, Restricted Project, Restricted Project

Oct 21 2020

jhuber6 committed rGcd4a4ae97a7c: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts (authored by jhuber6).
[OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts
Oct 21 2020, 2:02 PM
jhuber6 closed D89904: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts.
Oct 21 2020, 2:01 PM · Restricted Project
jhuber6 updated the diff for D89904: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts.

Changing to just check if the target triple is of four known 64-bit architectures.

Oct 21 2020, 11:43 AM · Restricted Project
jhuber6 requested review of D89904: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts.
Oct 21 2020, 11:40 AM · Restricted Project
jhuber6 added a comment to D89041: [libc++] Include <__config_site> from <__config>.

Yeah, I think that one might've been a compiler-rt failure that broke some other time since I haven't built from scratch in awhile. I'll let you know if my build finishes without compiler-rt.

Oct 21 2020, 11:23 AM · Restricted Project, Restricted Project
jhuber6 added a comment to D89041: [libc++] Include <__config_site> from <__config>.

When I try a fresh build using an install script,

In file included from /home2/3n4/llvm/trunk/llvm-project/compiler-rt/lib/fuzzer/FuzzerCrossOver.cpp:11:
/home2/3n4/llvm/trunk/llvm-project/compiler-rt/lib/fuzzer/FuzzerDefs.h:14:10: fatal error: cassert: No such file or directory
 #include <cassert>

How are you building? This does not appear to be one of the usual setups, cause the builds are green on my side.

Oct 21 2020, 10:52 AM · Restricted Project, Restricted Project
jhuber6 added a comment to D89041: [libc++] Include <__config_site> from <__config>.

Fails at make install.

CMake Error at projects/libcxx/include/cmake_install.cmake:753 (file):

file INSTALL cannot find
"/scratch/opt/llvm-clang/build_mirror_offload_nightly/projects/libcxx/__config_site":
No such file or directory.

This change is surprisingly tricky to land. Thanks for the heads up.

Should be fixed in

commit b5aa67446e01bd277727b05710a42e69ac41e74b
Author: Louis Dionne <ldionne@apple.com>
Date:   Wed Oct 21 12:53:24 2020 -0400

    [libc++] Fix the installation of libc++ headers since the __config_site change
Oct 21 2020, 10:37 AM · Restricted Project, Restricted Project
jhuber6 added a comment to D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts.

@daltenty Do you think this will fix the problem on AIX?

It's not just AIX that will have this problem I suspect. If you configure any cross-compiling build with a 64-bit host, targeting a 32-bit arch, your going to run into the problem. I think checking against a list of known 64-bit arches is good enough for the purposes here, but the check still needs to be against the target, not the host.

Also, the frontend diagnostic looks like it is off for the same reason:

else if (getArchPtrSize(T) != getArchPtrSize(TT))
  Diags.Report(diag::err_drv_incompatible_omp_arch)

T seems to be the target triple, not the host, but the diagnostic reads: pointer size is incompatible with host.

Oct 21 2020, 8:42 AM · Restricted Project
jhuber6 added a comment to D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts.

@daltenty Do you think this will fix the problem on AIX?

Oct 21 2020, 7:03 AM · Restricted Project
jhuber6 updated the diff for D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts.

Changing test to be similar to LLVM's method, checks the linker flags for 32-bit library and only if the target triple is one of the known 64-bit triples.

Oct 21 2020, 6:57 AM · Restricted Project

Oct 20 2020

jhuber6 added inline comments to D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts.
Oct 20 2020, 4:36 PM · Restricted Project
jhuber6 updated the diff for D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API.

Fixed failing tests and added a new Clang test.

Oct 20 2020, 1:19 PM · Restricted Project, Restricted Project, Restricted Project
jhuber6 added a comment to D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API.

Initial version. This fails a few tests and needs additional test cases for the additional functionality as well as support inside the runtime library.

Oct 20 2020, 8:53 AM · Restricted Project, Restricted Project, Restricted Project
jhuber6 requested review of D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API.
Oct 20 2020, 8:50 AM · Restricted Project, Restricted Project, Restricted Project

Oct 19 2020

jhuber6 committed rG24df30efda61: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts (authored by jhuber6).
[OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts
Oct 19 2020, 10:42 AM
jhuber6 closed D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts.
Oct 19 2020, 10:42 AM · Restricted Project
jhuber6 updated the diff for D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts.

Checking tests again.

Oct 19 2020, 9:26 AM · Restricted Project
jhuber6 requested review of D89696: [OpenMP] Fixing OpenMP/driver.c failing on 32-bit hosts.
Oct 19 2020, 6:24 AM · Restricted Project

Oct 12 2020

jhuber6 added a comment to D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging.

Current build, fails offloading/target_depend_nowait for an unknown reason after calling cuStreamSynchronize in __tgt_target_teams_mapper_nowait.

Is your tree up to date? We had a problem with this test, which was fixed by D84470.

Oct 12 2020, 1:29 PM · Restricted Project, Restricted Project, Restricted Project
jhuber6 updated the diff for D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging.

Current build, fails offloading/target_depend_nowait for an unknown reason after calling cuStreamSynchronize in __tgt_target_teams_mapper_nowait.

Oct 12 2020, 12:22 PM · Restricted Project, Restricted Project, Restricted Project

Oct 9 2020

jhuber6 updated the diff for D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging.

Fixing tests.

Oct 9 2020, 12:14 PM · Restricted Project, Restricted Project, Restricted Project

Oct 8 2020

jhuber6 committed rG3cc1f1fc1d97: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def (authored by jhuber6).
[OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def
Oct 8 2020, 11:01 AM
jhuber6 updated the diff for D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def.

Updating tests after landing D88594.

Oct 8 2020, 10:06 AM · Restricted Project, Restricted Project, Restricted Project
jhuber6 updated the diff for D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging.

Removing the _loc suffix. The Mapper API hasn't been officially released in Clang 11.x so we're still free to make changes. Currently working on augmenting the mapper API with variable declaration information so we can associate mapped pointers with their source names if the user specified debug locations.

Oct 8 2020, 10:00 AM · Restricted Project, Restricted Project, Restricted Project
jhuber6 reopened D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging.

Closed accidentally, had the wrong revision link in another patch.

Oct 8 2020, 9:13 AM · Restricted Project, Restricted Project, Restricted Project
jhuber6 closed D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default.

Screwed up and put the wrong revision in the commit message. Closed in rGd564409946a5a13cb6391fc0fec54dcbd6f6d249

Oct 8 2020, 9:12 AM · Restricted Project, Restricted Project
jhuber6 committed rGd564409946a5: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by… (authored by jhuber6).
[OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by…
Oct 8 2020, 9:10 AM
jhuber6 closed D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging.
Oct 8 2020, 9:10 AM · Restricted Project, Restricted Project, Restricted Project
jhuber6 committed rG6668e4cc685e: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload (authored by jhuber6).
[OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload
Oct 8 2020, 5:23 AM

Oct 7 2020

jhuber6 updated the diff for D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default.

Implementing Ye's code. I changed it to putput the architecture as a dependency and then set the value where we define the default architecture. I did a full build from scratch using this and got the sm_70 libraries for my machine without needing to specify it in my build script.

Oct 7 2020, 2:27 PM · Restricted Project, Restricted Project
jhuber6 updated the diff for D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload.

Okay, I'll push it after this finishes its build and see if buildbot sends me angry emails again.

Oct 7 2020, 1:24 PM · Restricted Project, Restricted Project, Restricted Project
jhuber6 updated the diff for D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload.

Changed method for comparing the architectures. Enum is local to the loop so it shouldn't pollute the namespace.

Oct 7 2020, 1:14 PM · Restricted Project, Restricted Project, Restricted Project
jhuber6 added inline comments to D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload.
Oct 7 2020, 11:58 AM · Restricted Project, Restricted Project, Restricted Project
jhuber6 added inline comments to D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload.
Oct 7 2020, 11:35 AM · Restricted Project, Restricted Project, Restricted Project
jhuber6 added inline comments to D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload.
Oct 7 2020, 11:27 AM · Restricted Project, Restricted Project, Restricted Project
jhuber6 updated the diff for D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload.

Removing the architecture detection from lit. Simply changing the tests to use specific architectures, in this case x86_64 and aarch64.

Oct 7 2020, 11:16 AM · Restricted Project, Restricted Project, Restricted Project

Oct 6 2020

jhuber6 added inline comments to D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default.
Oct 6 2020, 8:12 PM · Restricted Project, Restricted Project
jhuber6 updated the diff for D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default.

Removing redundant call to find_package.

Oct 6 2020, 6:59 PM · Restricted Project, Restricted Project
jhuber6 added a comment to D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default.

Probably not messing with enable_language(CUDA) at the moment, just add cuda_select_nvcc_arch_flags(CUDA_ARCH_FLAGS) to `openmp/libomptarget/cmake/Modules/LibomptargetGetDependencies.cmake?

Oct 6 2020, 3:59 PM · Restricted Project, Restricted Project
jhuber6 added a comment to D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default.

I just realized that this patch affects clang and libomptarget.
I cannot comment on clang. Regarding libomptarget, Could you explain why the detection is not put together with other cuda stuff in openmp/libomptarget/cmake/Modules/LibomptargetGetDependencies.cmake

Oct 6 2020, 3:49 PM · Restricted Project, Restricted Project
jhuber6 added a comment to D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default.

The link I posted indicated that independent feature is merged since 3.12. Better to avoid deprecated stuff when introducing new cmake lines even though some existing lines may still rely on deprecated cmake.

Oct 6 2020, 3:20 PM · Restricted Project, Restricted Project
jhuber6 added a comment to D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default.

FindCUDA has been deprecated.
Please explore the following feature without directly calling FindCUDA.
https://gitlab.kitware.com/cmake/cmake/-/merge_requests/1856

Oct 6 2020, 2:57 PM · Restricted Project, Restricted Project
jhuber6 requested review of D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default.
Oct 6 2020, 2:36 PM · Restricted Project, Restricted Project

Oct 5 2020

jhuber6 updated the diff for D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload.

Changing method of determining architecture.

Oct 5 2020, 9:49 AM · Restricted Project, Restricted Project, Restricted Project
jhuber6 added a reverting change for rGeaf73293cb6b: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload: rG1dce692de189: Revert "[OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target….
Oct 5 2020, 9:36 AM
jhuber6 committed rG1dce692de189: Revert "[OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target… (authored by jhuber6).
Revert "[OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target…
Oct 5 2020, 9:36 AM
jhuber6 added a reverting change for D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload: rG1dce692de189: Revert "[OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target….
Oct 5 2020, 9:36 AM · Restricted Project, Restricted Project, Restricted Project
jhuber6 committed rGeaf73293cb6b: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload (authored by jhuber6).
[OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload
Oct 5 2020, 8:03 AM
jhuber6 closed D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload.
Oct 5 2020, 8:03 AM · Restricted Project, Restricted Project, Restricted Project

Oct 4 2020

jhuber6 updated the diff for D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload.

Changed the lit substitution to be for fixing this problem specifically. It made the tests too unreadable and wasn't a good solution since it didn't detect 16 bit architectures anyway.

Oct 4 2020, 3:14 PM · Restricted Project, Restricted Project, Restricted Project

Oct 2 2020

jhuber6 reopened D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload.

Reopening for now.

Oct 2 2020, 7:14 PM · Restricted Project, Restricted Project, Restricted Project
jhuber6 updated the diff for D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload.

Adding an extra substitution in lit to solve the problem of automatically populating the test files with incompatible architectures.

Oct 2 2020, 7:13 PM · Restricted Project, Restricted Project, Restricted Project

Oct 1 2020

jhuber6 committed rG82453e759c77: [OpenMP] Add Missing Runtime Call for Globalization Remarks (authored by jhuber6).
[OpenMP] Add Missing Runtime Call for Globalization Remarks
Oct 1 2020, 6:21 PM
jhuber6 closed D88621: [OpenMP] Add Missing Runtime Call for Globalization Remarks.
Oct 1 2020, 6:21 PM · Restricted Project, Restricted Project

Sep 30 2020

jhuber6 requested review of D88621: [OpenMP] Add Missing Runtime Call for Globalization Remarks.
Sep 30 2020, 3:26 PM · Restricted Project, Restricted Project
jhuber6 added a reverting change for rG90eaedda9b8e: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def: rG1b60f63e4fd0: Revert "[OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds..
Sep 30 2020, 12:12 PM
jhuber6 committed rG1b60f63e4fd0: Revert "[OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds. (authored by jhuber6).
Revert "[OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.
Sep 30 2020, 12:12 PM
jhuber6 added a reverting change for D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def: rG1b60f63e4fd0: Revert "[OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds..
Sep 30 2020, 12:12 PM · Restricted Project, Restricted Project, Restricted Project
jhuber6 added a reverting change for rG9d2378b59150: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload: rGbdc85292fb0f: Revert "[OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target….
Sep 30 2020, 12:09 PM
jhuber6 committed rGbdc85292fb0f: Revert "[OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target… (authored by jhuber6).
Revert "[OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target…
Sep 30 2020, 12:08 PM
jhuber6 closed D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload.

Committed in rG9d2378b59150, forgot to update the commit message.

Sep 30 2020, 11:06 AM · Restricted Project, Restricted Project, Restricted Project
jhuber6 committed rG90eaedda9b8e: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def (authored by jhuber6).
[OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def
Sep 30 2020, 11:00 AM
jhuber6 closed D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def.
Sep 30 2020, 11:00 AM · Restricted Project, Restricted Project, Restricted Project