Page MenuHomePhabricator

sdmitriev (Sergey Dmitriev)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 7 2016, 2:42 PM (236 w, 5 d)

Recent Activity

May 20 2021

sdmitriev committed rG1fb5278882e4: [llvm-strip] Add support for '--' for delimiting options from input files (authored by sdmitriev).
[llvm-strip] Add support for '--' for delimiting options from input files
May 20 2021, 3:36 AM
sdmitriev closed D102825: [llvm-strip] Add support for '--' for delimiting options from input files.
May 20 2021, 3:36 AM · Restricted Project
sdmitriev updated the diff for D102825: [llvm-strip] Add support for '--' for delimiting options from input files.
May 20 2021, 2:18 AM · Restricted Project
sdmitriev updated the diff for D102825: [llvm-strip] Add support for '--' for delimiting options from input files.

Addressed review comments.

May 20 2021, 1:54 AM · Restricted Project
sdmitriev updated the diff for D102825: [llvm-strip] Add support for '--' for delimiting options from input files.

Addressed review comments.

May 20 2021, 1:28 AM · Restricted Project

May 19 2021

sdmitriev requested review of D102825: [llvm-strip] Add support for '--' for delimiting options from input files.
May 19 2021, 9:48 PM · Restricted Project
sdmitriev committed rGf8444a8e9422: [clang-offload-bundler] Delimit input/output file names by '--' for llvm-objcopy (authored by sdmitriev).
[clang-offload-bundler] Delimit input/output file names by '--' for llvm-objcopy
May 19 2021, 8:33 PM
sdmitriev closed D102752: [clang-offload-bundler] Delimit input/output file names by '--' for llvm-objcopy.
May 19 2021, 8:33 PM · Restricted Project
sdmitriev committed rG0b12963b747c: [llvm-objcopy] Update LIT test to resolve bot failure [NFC] (authored by sdmitriev).
[llvm-objcopy] Update LIT test to resolve bot failure [NFC]
May 19 2021, 8:21 PM
sdmitriev closed D102823: [llvm-objcopy] Update LIT test to resolve bot failure [NFC].
May 19 2021, 8:21 PM · Restricted Project
sdmitriev requested review of D102823: [llvm-objcopy] Update LIT test to resolve bot failure [NFC].
May 19 2021, 7:51 PM · Restricted Project
sdmitriev requested review of D102752: [clang-offload-bundler] Delimit input/output file names by '--' for llvm-objcopy.
May 19 2021, 2:13 AM · Restricted Project
sdmitriev committed rGf24f14029070: [llvm-objcopy] Add support for '--' for delimiting options from input/output… (authored by sdmitriev).
[llvm-objcopy] Add support for '--' for delimiting options from input/output…
May 19 2021, 2:02 AM
sdmitriev closed D102665: [llvm-objcopy] Add support for '--' for delimiting options from input/output files.
May 19 2021, 2:02 AM · Restricted Project
sdmitriev updated the diff for D102665: [llvm-objcopy] Add support for '--' for delimiting options from input/output files.

Applied code review suggestions.

May 19 2021, 1:06 AM · Restricted Project

May 18 2021

sdmitriev committed rG8998a8aa97f8: [clang-offload-bundler] Add sections and set section flags using one llvm… (authored by sdmitriev).
[clang-offload-bundler] Add sections and set section flags using one llvm…
May 18 2021, 9:02 AM
sdmitriev closed D102670: [clang-offload-bundler] Add sections and set section flags using one llvm-objcopy invocation.
May 18 2021, 9:02 AM · Restricted Project
sdmitriev updated the diff for D102665: [llvm-objcopy] Add support for '--' for delimiting options from input/output files.

Addressed review comments.

May 18 2021, 5:30 AM · Restricted Project
sdmitriev updated the diff for D102665: [llvm-objcopy] Add support for '--' for delimiting options from input/output files.

Addressed review comments.

May 18 2021, 3:46 AM · Restricted Project
sdmitriev added inline comments to D102665: [llvm-objcopy] Add support for '--' for delimiting options from input/output files.
May 18 2021, 3:04 AM · Restricted Project
sdmitriev updated the diff for D102665: [llvm-objcopy] Add support for '--' for delimiting options from input/output files.

I agree that it would be better to create a single LIT test for a file name beginning with dash, but it is not clear how to write it. I assume such test would require use of %T (directory of a %t), but according to the documentation it is deprecated now. So, I decided to follow the same strategy for testing this patch as was used in a similar llvm-rc change (D56743) - updating few arbitrary tests to use ‘--’ separator for the file names. If you have ideas how to write a test for a file name beginning with ‘-‘, please share.

May 18 2021, 3:03 AM · Restricted Project

May 17 2021

sdmitriev requested review of D102670: [clang-offload-bundler] Add sections and set section flags using one llvm-objcopy invocation.
May 17 2021, 11:43 PM · Restricted Project
sdmitriev updated the summary of D102665: [llvm-objcopy] Add support for '--' for delimiting options from input/output files.
May 17 2021, 11:14 PM · Restricted Project
sdmitriev requested review of D102665: [llvm-objcopy] Add support for '--' for delimiting options from input/output files.
May 17 2021, 10:07 PM · Restricted Project

Apr 12 2021

sdmitriev added inline comments to rG8359511c62b7: [CodeExtractor] Remove stale llvm.assume calls from extracted region.
Apr 12 2021, 9:55 PM
sdmitriev added a comment to D98740: [OpenMP] Change OMPIRBuilder to append function attributes.

With this change OMPIRBuilder may produce invalid IR if existing function attributes conflict with the new attributes it is trying to add. The problem can be reproduced on llvm/test/Transforms/OpenMP/gpu_state_machine_function_ptr_replacement.ll test where __kmpc_global_thread_num function is declared with the following attributes

Apr 12 2021, 7:56 PM · Restricted Project

Jan 25 2021

sdmitriev committed rG13cedcaf4538: [llvm-link] Fix crash when materializing appending global (authored by sdmitriev).
[llvm-link] Fix crash when materializing appending global
Jan 25 2021, 6:18 PM
sdmitriev closed D95329: [llvm-link] Fix crash when materializing appending global.
Jan 25 2021, 6:18 PM · Restricted Project
sdmitriev added inline comments to D95329: [llvm-link] Fix crash when materializing appending global.
Jan 25 2021, 5:26 PM · Restricted Project
sdmitriev updated the diff for D95329: [llvm-link] Fix crash when materializing appending global.

Addressed review comments.

Jan 25 2021, 5:24 PM · Restricted Project
sdmitriev added inline comments to D95329: [llvm-link] Fix crash when materializing appending global.
Jan 25 2021, 10:17 AM · Restricted Project

Jan 24 2021

sdmitriev requested review of D95329: [llvm-link] Fix crash when materializing appending global.
Jan 24 2021, 10:07 PM · Restricted Project

Jan 23 2021

sdmitriev committed rG267a57a64572: [llvm-link] Fix for an assertion when linking global with appending linkage (authored by sdmitriev).
[llvm-link] Fix for an assertion when linking global with appending linkage
Jan 23 2021, 12:31 AM
sdmitriev closed D95126: [llvm-link] Fix for an assertion when linking global with appending linkage.
Jan 23 2021, 12:31 AM · Restricted Project

Jan 22 2021

sdmitriev updated the diff for D95126: [llvm-link] Fix for an assertion when linking global with appending linkage.

Given the langref text I'm unsure what it means to link an append linkage variable to a non-append linkage one. I can see how extern is different but what would happen before & now if you remove the extern.

Jan 22 2021, 1:24 AM · Restricted Project

Jan 21 2021

sdmitriev requested review of D95126: [llvm-link] Fix for an assertion when linking global with appending linkage.
Jan 21 2021, 4:00 AM · Restricted Project

Jan 19 2021

sdmitriev committed rG233106269db6: [llvm-link] Improve link time for bitcode archives [NFC] (authored by sdmitriev).
[llvm-link] Improve link time for bitcode archives [NFC]
Jan 19 2021, 5:42 PM
sdmitriev closed D94643: [llvm-link] Improve link time for bitcode archives [NFC].
Jan 19 2021, 5:42 PM · Restricted Project
sdmitriev added a comment to D94643: [llvm-link] Improve link time for bitcode archives [NFC].

ping

Jan 19 2021, 7:50 AM · Restricted Project

Jan 14 2021

sdmitriev added a comment to D94643: [llvm-link] Improve link time for bitcode archives [NFC].
In D94643#2498870, @tra wrote:

LGTM.

Do you have any measurements showing actual impact on performance or memory consumption?

Jan 14 2021, 5:29 PM · Restricted Project
sdmitriev updated the diff for D94643: [llvm-link] Improve link time for bitcode archives [NFC].

Addressed review comment.

Jan 14 2021, 5:26 PM · Restricted Project

Jan 13 2021

sdmitriev requested review of D94643: [llvm-link] Improve link time for bitcode archives [NFC].
Jan 13 2021, 6:22 PM · Restricted Project

Jan 5 2021

sdmitriev committed rG761aca1e2e39: [llvm-link] fix linker behavior when linking archives with --only-needed option (authored by sdmitriev).
[llvm-link] fix linker behavior when linking archives with --only-needed option
Jan 5 2021, 10:09 AM
sdmitriev closed D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.
Jan 5 2021, 10:08 AM · Restricted Project

Jan 4 2021

sdmitriev added inline comments to D80816: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives..
Jan 4 2021, 12:54 AM · Restricted Project, Restricted Project

Dec 28 2020

sdmitriev added a comment to D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.

Looks good to me. Please wait for @tra to accept it.

Dec 28 2020, 8:39 AM · Restricted Project

Dec 22 2020

sdmitriev added a comment to D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.

Well, it looks like nobody is going to respond.

Dec 22 2020, 5:33 PM · Restricted Project

Dec 18 2020

sdmitriev added a reviewer for D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option: saiislam.
Dec 18 2020, 3:53 AM · Restricted Project
sdmitriev added inline comments to D80816: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives..
Dec 18 2020, 3:34 AM · Restricted Project, Restricted Project

Dec 14 2020

sdmitriev added a comment to D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.

ping

Dec 14 2020, 8:39 PM · Restricted Project

Dec 10 2020

sdmitriev updated the diff for D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.

Updated diff after committing NFC changes (D92918).

Dec 10 2020, 12:17 AM · Restricted Project

Dec 9 2020

sdmitriev committed rG025d4faadb68: [llvm-link][NFC] Minor cleanup (authored by sdmitriev).
[llvm-link][NFC] Minor cleanup
Dec 9 2020, 11:18 PM
sdmitriev closed D92918: [llvm-link][NFC] Minor cleanup.
Dec 9 2020, 11:18 PM · Restricted Project
sdmitriev added a comment to D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.

I wonder if we want to go even further and bring archive linking closer to how static linking works with normal object files?
Instead of linking all files in the archive together (that may have its own set of issues) and returning a single module, perhaps we should just load individual files, return them as a vector and link each of them in order with --only-needed.

Dec 9 2020, 10:46 PM · Restricted Project
sdmitriev added a comment to D92918: [llvm-link][NFC] Minor cleanup.

Well, when you use a class you have to know the interface it defines, so this is not about the implementation details, but about the interface provided by the class. llvm::Linker::linkModules(), as it is defined today, is a static member of the class, so it does not require an instance of llvm::Linker class to be called. Adding an additional parameter to loadArFile just in case does not buy as anything at all except unneeded redundancy. And, by the way, this function is called as a static member (i.e. Linker::linkModules()) everywhere in LLVM sources except llvm-link.cpp:

Dec 9 2020, 5:51 PM · Restricted Project

Dec 8 2020

sdmitriev added a comment to D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.

I have prepared a separate patch for NFC changes D92918. Will update this patch once D92918 is approved.

Dec 8 2020, 11:33 PM · Restricted Project
sdmitriev requested review of D92918: [llvm-link][NFC] Minor cleanup.
Dec 8 2020, 11:31 PM · Restricted Project
sdmitriev added a comment to D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.
In D92535#2440317, @tra wrote:

The patch description describes what the patch does, but does not tell us much about the problem is is supposed to fix.
Could you give us more details on why the patch is needed?

Dec 8 2020, 8:01 PM · Restricted Project

Dec 7 2020

sdmitriev added a reviewer for D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option: JDevlieghere.
Dec 7 2020, 6:55 PM · Restricted Project
sdmitriev added a reviewer for D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option: tra.
Dec 7 2020, 6:51 PM · Restricted Project
sdmitriev added a comment to D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.

Do you have any comments for this patch?

Dec 7 2020, 3:04 AM · Restricted Project

Dec 3 2020

sdmitriev updated the diff for D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.

I have realized that this patch is not NFC, and it corrects llvm-link behavior when archive is linked with other inputs as a library (with --only-needed option). I have updated description and added LIT test to the patch.

Dec 3 2020, 1:44 AM · Restricted Project

Dec 2 2020

sdmitriev requested review of D92535: [llvm-link] fix linker behavior when linking archives with --only-needed option.
Dec 2 2020, 8:02 PM · Restricted Project
sdmitriev committed rG715ba18d3e11: [llvm-link] use file magic when deciding if input should be loaded as archive (authored by sdmitriev).
[llvm-link] use file magic when deciding if input should be loaded as archive
Dec 2 2020, 5:34 PM
sdmitriev updated the diff for D92376: [llvm-link] use file magic when deciding if input should be loaded as archive.

Added BinaryFormat to the list of components that need to be linked.

Dec 2 2020, 5:15 PM · Restricted Project
sdmitriev added a reverting change for rG55f8c2fdfbc5: [llvm-link] use file magic when deciding if input should be loaded as archive: rG9c955b79fb2b: Revert "[llvm-link] use file magic when deciding if input should be loaded as….
Dec 2 2020, 4:54 PM
sdmitriev committed rG9c955b79fb2b: Revert "[llvm-link] use file magic when deciding if input should be loaded as… (authored by sdmitriev).
Revert "[llvm-link] use file magic when deciding if input should be loaded as…
Dec 2 2020, 4:54 PM
sdmitriev added a reverting change for D92376: [llvm-link] use file magic when deciding if input should be loaded as archive: rG9c955b79fb2b: Revert "[llvm-link] use file magic when deciding if input should be loaded as….
Dec 2 2020, 4:54 PM · Restricted Project
sdmitriev committed rG55f8c2fdfbc5: [llvm-link] use file magic when deciding if input should be loaded as archive (authored by sdmitriev).
[llvm-link] use file magic when deciding if input should be loaded as archive
Dec 2 2020, 4:44 PM
sdmitriev closed D92376: [llvm-link] use file magic when deciding if input should be loaded as archive.
Dec 2 2020, 4:44 PM · Restricted Project

Dec 1 2020

sdmitriev requested review of D92376: [llvm-link] use file magic when deciding if input should be loaded as archive.
Dec 1 2020, 2:45 AM · Restricted Project

Nov 24 2020

sdmitriev added inline comments to D80816: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives..
Nov 24 2020, 8:13 PM · Restricted Project, Restricted Project
sdmitriev committed rG1b0ca81a6c35: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC] (authored by sdmitriev).
[clang-offload-bundler] use std::forward_list for storing temp file names [NFC]
Nov 24 2020, 8:09 AM
sdmitriev closed D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC].
Nov 24 2020, 8:09 AM · Restricted Project
sdmitriev added inline comments to D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC].
Nov 24 2020, 7:35 AM · Restricted Project
sdmitriev added inline comments to D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC].
Nov 24 2020, 6:55 AM · Restricted Project
sdmitriev requested review of D92010: [clang-offload-bundler] use std::forward_list for storing temp file names [NFC].
Nov 24 2020, 1:08 AM · Restricted Project

Nov 12 2020

sdmitriev added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Nov 12 2020, 12:52 AM · Restricted Project, Restricted Project

Jul 27 2020

sdmitriev committed rGbec77ece1489: [CallGraph] Preserve call records vector when replacing call edge (authored by sdmitriev).
[CallGraph] Preserve call records vector when replacing call edge
Jul 27 2020, 6:17 AM
sdmitriev closed D84295: [CallGraph] Preserve call records vector when replacing call edge.
Jul 27 2020, 6:16 AM · Restricted Project
sdmitriev updated the diff for D84295: [CallGraph] Preserve call records vector when replacing call edge.
Jul 27 2020, 12:41 AM · Restricted Project
sdmitriev updated the diff for D84295: [CallGraph] Preserve call records vector when replacing call edge.

Added unit test for the CallGraphNode::replaceCallEdge() change. Without this change test finishes with an assertion on windows debug build.

Jul 27 2020, 12:21 AM · Restricted Project

Jul 22 2020

sdmitriev added a comment to D84295: [CallGraph] Preserve call records vector when replacing call edge.

Yes, exactly. If the number of callbacks is the same we can avoid invalidating iterators. I assume that should really cover most of the cases.

Jul 22 2020, 7:46 PM · Restricted Project
sdmitriev updated the diff for D84295: [CallGraph] Preserve call records vector when replacing call edge.
Jul 22 2020, 2:02 AM · Restricted Project
Herald added a project to D84295: [CallGraph] Preserve call records vector when replacing call edge: Restricted Project.
Jul 22 2020, 1:41 AM · Restricted Project

Jul 13 2020

sdmitriev accepted D83718: [CallGraph] Update callback call sites in RefreshCallGraph.

LGTM

Jul 13 2020, 4:42 PM · Restricted Project

Jul 1 2020

sdmitriev committed rGcb8faaacb52c: [CallGraph] Add support for callback call sites (authored by sdmitriev).
[CallGraph] Add support for callback call sites
Jul 1 2020, 2:05 PM
sdmitriev closed D82572: [CallGraph] Add support for callback call sites.
Jul 1 2020, 2:05 PM · Restricted Project

Jun 28 2020

sdmitriev updated the diff for D82572: [CallGraph] Add support for callback call sites.

Rebase after committing NFC patch (D82686).

Jun 28 2020, 8:52 PM · Restricted Project
sdmitriev committed rG1becd298b82e: [NFC] CallGraph related cleanup (authored by sdmitriev).
[NFC] CallGraph related cleanup
Jun 28 2020, 4:06 PM
sdmitriev closed D82686: [NFC] CallGraph related cleanup.
Jun 28 2020, 4:06 PM · Restricted Project

Jun 26 2020

sdmitriev added a comment to D82572: [CallGraph] Add support for callback call sites.

Sure, I have separated NFC changes to D82686.

Jun 26 2020, 2:41 PM · Restricted Project
sdmitriev created D82686: [NFC] CallGraph related cleanup.
Jun 26 2020, 2:41 PM · Restricted Project
sdmitriev added inline comments to D82572: [CallGraph] Add support for callback call sites.
Jun 26 2020, 9:17 AM · Restricted Project

Jun 25 2020

sdmitriev updated the diff for D82572: [CallGraph] Add support for callback call sites.
Jun 25 2020, 7:08 PM · Restricted Project
sdmitriev added inline comments to D82572: [CallGraph] Add support for callback call sites.
Jun 25 2020, 6:02 PM · Restricted Project
sdmitriev updated the diff for D82572: [CallGraph] Add support for callback call sites.

One more fix for pre-merge check issues.

Jun 25 2020, 2:44 PM · Restricted Project
sdmitriev updated the diff for D82572: [CallGraph] Add support for callback call sites.

Fixed 'clang-format' issue reported by pre-merge checks.

Jun 25 2020, 10:13 AM · Restricted Project
sdmitriev created D82572: [CallGraph] Add support for callback call sites.
Jun 25 2020, 9:07 AM · Restricted Project

May 12 2020

sdmitriev committed rG32f5ee830b0f: [Attributor] Fixup block addresses after rewriting function signature (authored by sdmitriev).
[Attributor] Fixup block addresses after rewriting function signature
May 12 2020, 2:00 PM