This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP 5.1] Parsing and Sema support for `scope` construct
ClosedPublic

Authored by mdfazlay on Aug 14 2023, 3:54 PM.

Details

Summary

#pragma omp scope [clause[ [,] clause] ... ]
structured-block

where clause is one of the following:

private(list)
reduction([reduction-modifier ,] reduction-identifier : list)
nowait

Reference:
(1) OpenMP 5.1 Specification - Section 2.9 (Page 106)

Diff Detail

Event Timeline

mdfazlay created this revision.Aug 14 2023, 3:54 PM
Herald added a project: Restricted Project. · View Herald Transcript
mdfazlay requested review of this revision.Aug 14 2023, 3:54 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript

Need to add the tests (and the checks, if required) for the nesting of the regions

Need to add the tests (and the checks, if required) for the nesting of the regions

I think I have the nesting of regions checks in scope_messages.cpp. Do you prefer to have those checks in nesting_of_regions.cpp file?

Need to add the tests (and the checks, if required) for the nesting of the regions

I think I have the nesting of regions checks in scope_messages.cpp. Do you prefer to have those checks in nesting_of_regions.cpp file?

Yes, extend this one

mdfazlay updated this revision to Diff 550521.Aug 15 2023, 4:21 PM

Updated nesting of regions checks.

Could you also add the nesting tests for outer scope directive? Currently it tests only for inner

mdfazlay updated this revision to Diff 552484.Aug 22 2023, 1:09 PM

Could you also add the nesting tests for outer scope directive? Currently it tests only for inner

Added. Please take a look.

ABataev accepted this revision.Aug 22 2023, 1:19 PM

LG. Please, update docs/OpenMPSupport.rst

This revision is now accepted and ready to land.Aug 22 2023, 1:19 PM
mdfazlay updated this revision to Diff 553311.Aug 24 2023, 5:18 PM

Updated docs/OpenMPSupport.rst

This revision was landed with ongoing or failed builds.Aug 24 2023, 6:14 PM
This revision was automatically updated to reflect the committed changes.