commit by rGf8d5b49c786f: Fix missing error for use of 128-bit integer inside SPIR64 device code.

Thanks @aaron.ballman to accept my change!!!
Hi @jdoerfert,
Thank you for your review.
it seems you still has request change for for this. I did address your earlier comment in SPIR.h and upload the change. Is there anything else I need to change?

In D92439#2429511, @jdoerfert wrote:

Still unsure if we should also error out for NVPTX but that is a different story. Looks OK from my side, assuming you address the earlier comment.

Fix problem with @jdoerfert pointed where using bool hasInt128Type() const override { return false; } instead.

LGTM

LGTM. Please changed format for td file.

This looks good to me. Could you also add a test to use this new DiagGroup (-Wno-slh-asm-goto)?

I don’t know what consequences is of using asm goto under SLH.

In D79743#2034945, @zbrid wrote:

In D79743#2034792, @jyu2 wrote:

Two questions:
1> What happen under SLH, will asm goto gets removed, or a runtime problem?
2> Should we emit error or warning in the Parser instead?

1. SLH crashes with an unhelpful error message.
2. I'd be happy to emit the warning in the Parser. Could you give me a pointer to where in the parser would be appropriate? I'm not super familiar with the clang codebase. Also why do you think the parser would be a better place? (Asking to learn since I'm new to this area)

Two questions:
1> What happen under SLH, will asm goto gets removed, or a runtime problem?
2> Should we emit error or warning in the Parser instead?

jyu2 committed rGb8fee677bf8e: Re-check in clang support gun asm goto after fixing tests. (authored by jyu2).

jyu2 committed rG954ec09aed4f: clang support gnu asm goto

committed rGc19f4f806972: Fix bug 37903:MS ABI: handle inline static data member and inline variable as… (authored by jyu2).

In D56571#1476266, @nickdesaulniers wrote:

@compudj email me the preprocessed output of basic_percpu_ops_test.c and I'll take a look. (Should be able to find my email via git log).

Hi Reid,
Thanks for your review and catch what I were missing for inline variable part(only inline static data member were fix in previous patch).
As you suggested, instead using GVA_DiscardableODR to put inline variable's initialization function or inline static member's initialization functions into to COMDAT group with global being initialized.

Looks good to me. We are basically de-mangled name for those E initialize global’s function and F destroy global's function.

In D60912#1472987, @rnk wrote:

In D60912#1472986, @jyu2 wrote:

inline static int aoo = foo(); // C++17 inline variable, thus also a definition

This is a static inline global variable, so it technically creates two different globals, so calling foo twice is intended behavior. I think we really want to look at the GVA linkage instead of trying to list all the reasons why something might have weak linkage. Take a look at shouldBeInCOMDAT in CodeGenModule.cpp, I think it has the logic we want.

In D60912#1472983, @rnk wrote:

Thanks, I think there's another case to handle, though.

Closed by commit rG0b28b8b09be7: Bug-40323: MS ABI adding template static member in the linker directive section… (authored by jyu2).

In D58160#1433458, @rnk wrote:

lgtm

Rebased

Rebase

Review comments addressed.

Review comment addressed

Cleanup CFG code, remove obj-lifetime code when build CFE for asm-goto.

I find some ambiguous error for asm-goto out of scope.
Instead call VerifyIndirectOrAsmJumps one time, call that function twice one for indirect-goto one for asm-goto.

Remove check for %lN
Fix missing successor of asm goto in CFG build.

small fix.

More change from review.

1>emit better error for use of output constraints.
2> Add assert for NumLabels and NumOutputs are both larger than 0.

More review comments addressed.

1> Add code for scope checking
2> Using CastInterator
3> CFG change to remove duplicate Block list

Change test for BE IR change.

Change error message.

I add additional test.

Add code to diagnostic error for use of the "l" modifier that does not point to a label in the label list.

Couple of change to respond Eli’s comments.

1> I add code for CFG.cpp and a test for that, as efriedman request.
2> changes are respond the comments I received

In D33537#827509, @baloghadamsoftware wrote:

Test changed. I made some bad throws reachable, but the frontend check still does detects them.

In D33537#801889, @baloghadamsoftware wrote:

In D33537#771274, @aaron.ballman wrote:

The check in D33333 is using a CFG, not just checking direct throws.

I tested the latest revision (the fronted patch already included) on my test file. Disregarding of the not so important parameters (EnabledFunctions and IgnoredExceptions) I do not get warnings for any indirect throws (indirect_implicit() and indirect_explicit()). So for me it does not seem to be using the CFG. Furthermore, I do not get warning for throw_and_catch_some() where 1.1 is a double thus catch(int &) should not catch it. The same happens in throw_catch_rethrow_the_rest(), where catch(int &) should not catch 1.1, but catch(...) should catch and rethrow it. This latter may be a bug.

Hi Richard,

Hi Aaron,
Thank you so much for your review. I just update change to address your comments.

Thank you so much Richard for your review. It is very good to know this select method for diagnostic.

Update test.

update patch