Thanks. @rnk

Thank you so much for the suggestion.

Before we do that, you should be able to delete the logic in CodeGenModule::getFunctionLinkage to handle inheriting constructor thunks. Your change should have the same effect. Can you do that, and check that it passes tests? If we do that, we're don't have to accumulate extra special case code, we've just moved the special case code earlier, up from codegen into the earlier linkage calculation.

Thanks @rnk. This is address his comment.

Our customer fond problem I submit bug: in https://github.com/llvm/llvm-project/issues/65045

Thanks all for the review! This is fix space problem.

LGTM.

Thanks @jdoerfert, @ABataev and @aaron.ballman for the code reviews. This is addressing comments.

Thanks Alexey for the review. This is address his comment.

Fix typo.

In D154180#4469417, @ABataev wrote:

LG with a nit

Thanks Alexey for the review!!

Thanks Alexey!!!

Thanks Alexey's review. This address Alexey's comments.

Checked in with rG085845a2acbe

Sorry, full diff.

Thanks.

Thanks Alexey's review. This is address his comments.

Thanks Alexey for the review.

Thanks Alex for the review. This is to address his comments.

In D148723#4376946, @serge-sans-paille wrote:

@jyu2 : could you test that patch in your setup ? Also I can't find the bug id associated with your original bug anymore...

In D151517#4374583, @ABataev wrote:

Could you split it into 3 separate patch

Thanks Alexey, sure I am separate the patch. This is first oen.

LGTM

In D150340#4343915, @efriedma wrote:

LGTM... but I don't think the IR we're generating is really correct overall; see https://github.com/llvm/llvm-project/issues/62723

On a side-note, other open issues related to -EHa/__try:

https://github.com/llvm/llvm-project/issues/62606
D124642

Address Eli's comment. Thanks for review!.

If it is okay with is_divece_ptr. I am okay with it.
Please add a lit test for this?

I think something like

Hi @serge-sans-paille, thanks for the fix. Could you please also try some test with dllimport/dllexport with inline function? Jennifer

This change seems cause assert:

Fix clang format problem

In D145093#4179927, @ronlieb wrote:

seems to fail amdgpu buildbot
https://lab.llvm.org/buildbot/#/builders/193/builds/27692

Okay, I add code to get **a to work. Thanks Alexey for the review.

Add additional test as Alexey asked.

Thanks Alexey for the code review. I removed loop by using last expression in the component for checking.

Yes, I understand. And did not ask for it. I just mean that a[0][:3] emits different mapping data - TARGET_PAPARM|TO|FROM, PTR_AND_OBJ|TO|FROM

Thanks Alexey for the review.

I mean we shall emit the same mapping for (*a)[:3] and for a[0][:3]

In D145093#4164528, @ABataev wrote:

What result produces map(a[0][:3]?