Page MenuHomePhabricator

jyu2 (Jennifer Yu)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 2 2016, 10:10 AM (221 w, 4 d)

Recent Activity

Dec 9 2020

jyu2 closed D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code..

commit by rGf8d5b49c786f: Fix missing error for use of 128-bit integer inside SPIR64 device code.

Dec 9 2020, 10:00 AM · Restricted Project

Dec 7 2020

jyu2 committed rGf8d5b49c786f: Fix missing error for use of 128-bit integer inside SPIR64 device code. (authored by jyu2).
Fix missing error for use of 128-bit integer inside SPIR64 device code.
Dec 7 2020, 10:53 AM

Dec 4 2020

jyu2 added a comment to D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code..

Thanks @aaron.ballman to accept my change!!!
Hi @jdoerfert,
Thank you for your review.
it seems you still has request change for for this. I did address your earlier comment in SPIR.h and upload the change. Is there anything else I need to change?

Dec 4 2020, 11:20 AM · Restricted Project

Dec 2 2020

jyu2 added a comment to D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code..

Still unsure if we should also error out for NVPTX but that is a different story. Looks OK from my side, assuming you address the earlier comment.

Dec 2 2020, 4:30 PM · Restricted Project
jyu2 added inline comments to D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code..
Dec 2 2020, 3:03 PM · Restricted Project
jyu2 updated the diff for D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code..

Fix problem with @jdoerfert pointed where using bool hasInt128Type() const override { return false; } instead.

Dec 2 2020, 2:54 PM · Restricted Project
jyu2 added inline comments to D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code..
Dec 2 2020, 12:55 PM · Restricted Project
jyu2 added inline comments to D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code..
Dec 2 2020, 9:45 AM · Restricted Project
jyu2 added inline comments to D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code..
Dec 2 2020, 8:54 AM · Restricted Project

Dec 1 2020

jyu2 requested review of D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code..
Dec 1 2020, 5:21 PM · Restricted Project

Oct 9 2020

jyu2 accepted D87279: [clang] Fix handling of physical registers in inline assembly operands..

LGTM

Oct 9 2020, 2:40 PM · Restricted Project

Oct 7 2020

jyu2 added inline comments to D87279: [clang] Fix handling of physical registers in inline assembly operands..
Oct 7 2020, 7:53 AM · Restricted Project

Jul 7 2020

jyu2 committed rG6cf0dac1ca3f: orrectly generate invert xor value for Binary Atomics of int size > 64 (authored by jyu2).
orrectly generate invert xor value for Binary Atomics of int size > 64
Jul 7 2020, 10:21 AM
jyu2 closed D82832: Correctly generate invert xor value for Binary Atomics of int size > 64.
Jul 7 2020, 10:21 AM · Restricted Project

Jun 30 2020

jyu2 removed a reviewer for D82832: Correctly generate invert xor value for Binary Atomics of int size > 64: cfe-commits.
Jun 30 2020, 7:00 AM · Restricted Project

Jun 29 2020

jyu2 created D82832: Correctly generate invert xor value for Binary Atomics of int size > 64.
Jun 29 2020, 6:34 PM · Restricted Project

May 19 2020

jyu2 accepted D79743: [clang][asm goto][slh] Warn if asm goto + SLH.

LGTM. Please changed format for td file.

May 19 2020, 5:39 PM · Restricted Project
jyu2 added a comment to D79743: [clang][asm goto][slh] Warn if asm goto + SLH.

This looks good to me. Could you also add a test to use this new DiagGroup (-Wno-slh-asm-goto)?

May 19 2020, 12:02 PM · Restricted Project

May 14 2020

jyu2 added a comment to D79743: [clang][asm goto][slh] Warn if asm goto + SLH.

I don’t know what consequences is of using asm goto under SLH.

May 14 2020, 10:50 AM · Restricted Project

May 13 2020

jyu2 added a comment to D79743: [clang][asm goto][slh] Warn if asm goto + SLH.

Two questions:
1> What happen under SLH, will asm goto gets removed, or a runtime problem?
2> Should we emit error or warning in the Parser instead?

  1. SLH crashes with an unhelpful error message.
  2. I'd be happy to emit the warning in the Parser. Could you give me a pointer to where in the parser would be appropriate? I'm not super familiar with the clang codebase. Also why do you think the parser would be a better place? (Asking to learn since I'm new to this area)
May 13 2020, 2:09 PM · Restricted Project
jyu2 added a comment to D79743: [clang][asm goto][slh] Warn if asm goto + SLH.

Two questions:
1> What happen under SLH, will asm goto gets removed, or a runtime problem?
2> Should we emit error or warning in the Parser instead?

May 13 2020, 11:58 AM · Restricted Project

Jun 3 2019

jyu2 closed D56571: [RFC prototype] Implementation of asm-goto support in clang.

jyu2 committed rGb8fee677bf8e: Re-check in clang support gun asm goto after fixing tests. (authored by jyu2).

Jun 3 2019, 9:01 AM
jyu2 committed rGb8fee677bf8e: Re-check in clang support gun asm goto after fixing tests. (authored by jyu2).
Re-check in clang support gun asm goto after fixing tests.
Jun 3 2019, 9:00 AM
jyu2 committed rL362410: Re-check in clang support gun asm goto after fixing tests..
Re-check in clang support gun asm goto after fixing tests.
Jun 3 2019, 8:59 AM

May 30 2019

jyu2 added a comment to D56571: [RFC prototype] Implementation of asm-goto support in clang.

jyu2 committed rG954ec09aed4f: clang support gnu asm goto

May 30 2019, 1:14 PM

May 29 2019

jyu2 committed rC362045: clang support gnu asm goto..
clang support gnu asm goto.
May 29 2019, 6:04 PM
jyu2 committed rG954ec09aed4f: clang support gnu asm goto. Syntax: asm [volatile] goto ( AssemblerTemplate… (authored by jyu2).
clang support gnu asm goto. Syntax: asm [volatile] goto ( AssemblerTemplate…
May 29 2019, 6:04 PM
jyu2 committed rL362045: clang support gnu asm goto..
clang support gnu asm goto.
May 29 2019, 6:03 PM

May 16 2019

xianjun awarded D56571: [RFC prototype] Implementation of asm-goto support in clang a Like token.
May 16 2019, 5:49 AM

Apr 25 2019

jyu2 closed D60912: MS ABI: handle inline static data member and inline variable as template static data member.

committed rGc19f4f806972: Fix bug 37903:MS ABI: handle inline static data member and inline variable as… (authored by jyu2).

Apr 25 2019, 10:50 AM · Restricted Project
jyu2 added inline comments to D60912: MS ABI: handle inline static data member and inline variable as template static data member.
Apr 25 2019, 10:47 AM · Restricted Project
jyu2 committed rGc19f4f806972: Fix bug 37903:MS ABI: handle inline static data member and inline variable as… (authored by jyu2).
Fix bug 37903:MS ABI: handle inline static data member and inline variable as…
Apr 25 2019, 10:44 AM
jyu2 committed rL359212: Fix bug 37903:MS ABI: handle inline static data member and inline variable as….
Fix bug 37903:MS ABI: handle inline static data member and inline variable as…
Apr 25 2019, 10:44 AM
jyu2 committed rC359212: Fix bug 37903:MS ABI: handle inline static data member and inline variable as….
Fix bug 37903:MS ABI: handle inline static data member and inline variable as…
Apr 25 2019, 10:44 AM

Apr 24 2019

jyu2 added a comment to D56571: [RFC prototype] Implementation of asm-goto support in clang.

@compudj email me the preprocessed output of basic_percpu_ops_test.c and I'll take a look. (Should be able to find my email via git log).

Apr 24 2019, 5:11 PM

Apr 23 2019

jyu2 updated the diff for D60912: MS ABI: handle inline static data member and inline variable as template static data member.

Hi Reid,
Thanks for your review and catch what I were missing for inline variable part(only inline static data member were fix in previous patch).
As you suggested, instead using GVA_DiscardableODR to put inline variable's initialization function or inline static member's initialization functions into to COMDAT group with global being initialized.

Apr 23 2019, 3:53 PM · Restricted Project

Apr 22 2019

jyu2 added a comment to D60930: [codeview] Fix symbol names for dynamic initializers and atexit stubs.

Looks good to me. We are basically de-mangled name for those E initialize global’s function and F destroy global's function.

Apr 22 2019, 11:15 AM · Restricted Project

Apr 19 2019

jyu2 added a comment to D60912: MS ABI: handle inline static data member and inline variable as template static data member.
In D60912#1472987, @rnk wrote:

inline static int aoo = foo(); // C++17 inline variable, thus also a definition

This is a static inline global variable, so it technically creates two different globals, so calling foo twice is intended behavior. I think we really want to look at the GVA linkage instead of trying to list all the reasons why something might have weak linkage. Take a look at shouldBeInCOMDAT in CodeGenModule.cpp, I think it has the logic we want.

Apr 19 2019, 1:54 PM · Restricted Project
jyu2 added a comment to D60912: MS ABI: handle inline static data member and inline variable as template static data member.
In D60912#1472983, @rnk wrote:

Thanks, I think there's another case to handle, though.

Apr 19 2019, 1:19 PM · Restricted Project
jyu2 created D60912: MS ABI: handle inline static data member and inline variable as template static data member.
Apr 19 2019, 12:00 PM · Restricted Project

Apr 3 2019

jyu2 closed D58160: MS ABI: adding template static member in the linker directive section to make sure init function can be called before main..

Closed by commit rG0b28b8b09be7: Bug-40323: MS ABI adding template static member in the linker directive section… (authored by jyu2).

Apr 3 2019, 10:49 AM · Restricted Project
jyu2 committed rG0b28b8b09be7: Bug-40323: MS ABI adding template static member in the linker directive section… (authored by jyu2).
Bug-40323: MS ABI adding template static member in the linker directive section…
Apr 3 2019, 10:21 AM
jyu2 committed rL357610: Bug-40323: MS ABI adding template static member in the linker directive section….
Bug-40323: MS ABI adding template static member in the linker directive section…
Apr 3 2019, 10:20 AM
jyu2 committed rC357610: Bug-40323: MS ABI adding template static member in the linker directive section….
Bug-40323: MS ABI adding template static member in the linker directive section…
Apr 3 2019, 10:20 AM

Mar 20 2019

jyu2 committed rG506d74c8e39a: Remove extra white spaces (authored by jyu2).
Remove extra white spaces
Mar 20 2019, 4:05 PM
jyu2 committed rC356628: Remove extra white spaces.
Remove extra white spaces
Mar 20 2019, 4:04 PM
jyu2 committed rL356628: Remove extra white spaces.
Remove extra white spaces
Mar 20 2019, 4:04 PM

Mar 18 2019

jyu2 added a comment to D58160: MS ABI: adding template static member in the linker directive section to make sure init function can be called before main..
In D58160#1433458, @rnk wrote:

lgtm

Mar 18 2019, 9:04 PM · Restricted Project
jyu2 retitled D58160: MS ABI: adding template static member in the linker directive section to make sure init function can be called before main. from Fix runtime problem from //bugs.llvm.org/show_bug.cgi?id=40323 to MS ABI: adding template static member in the linker directive section to make sure init function can be called before main..
Mar 18 2019, 10:04 AM · Restricted Project

Mar 4 2019

jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

Rebased

Mar 4 2019, 2:21 PM

Feb 22 2019

jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

Rebase

Feb 22 2019, 6:33 PM

Feb 15 2019

jyu2 added inline comments to D56571: [RFC prototype] Implementation of asm-goto support in clang.
Feb 15 2019, 7:27 PM
jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

Review comments addressed.

Feb 15 2019, 7:27 PM
jyu2 added inline comments to D56571: [RFC prototype] Implementation of asm-goto support in clang.
Feb 15 2019, 10:28 AM
jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

Review comment addressed

Feb 15 2019, 10:28 AM

Feb 12 2019

jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

Cleanup CFG code, remove obj-lifetime code when build CFE for asm-goto.

Feb 12 2019, 6:10 PM
jyu2 created D58160: MS ABI: adding template static member in the linker directive section to make sure init function can be called before main..
Feb 12 2019, 4:57 PM · Restricted Project

Feb 11 2019

jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

I find some ambiguous error for asm-goto out of scope.
Instead call VerifyIndirectOrAsmJumps one time, call that function twice one for indirect-goto one for asm-goto.

Feb 11 2019, 4:03 PM

Feb 8 2019

jyu2 added reviewers for D56571: [RFC prototype] Implementation of asm-goto support in clang: rsmith, efriedma, cfe-commits.
Feb 8 2019, 9:56 PM

Feb 7 2019

jyu2 added inline comments to D56571: [RFC prototype] Implementation of asm-goto support in clang.
Feb 7 2019, 9:42 PM
jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

Remove check for %lN
Fix missing successor of asm goto in CFG build.

Feb 7 2019, 9:42 PM
jyu2 added inline comments to D56571: [RFC prototype] Implementation of asm-goto support in clang.
Feb 7 2019, 9:25 AM

Feb 5 2019

jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

small fix.

Feb 5 2019, 9:43 PM
jyu2 added inline comments to D56571: [RFC prototype] Implementation of asm-goto support in clang.
Feb 5 2019, 7:46 PM
jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

More change from review.

Feb 5 2019, 7:43 PM
jyu2 added inline comments to D56571: [RFC prototype] Implementation of asm-goto support in clang.
Feb 5 2019, 11:35 AM
jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

1>emit better error for use of output constraints.
2> Add assert for NumLabels and NumOutputs are both larger than 0.

Feb 5 2019, 11:33 AM

Feb 4 2019

jyu2 added inline comments to D56571: [RFC prototype] Implementation of asm-goto support in clang.
Feb 4 2019, 6:02 PM
jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

More review comments addressed.

Feb 4 2019, 6:01 PM
jyu2 added inline comments to D56571: [RFC prototype] Implementation of asm-goto support in clang.
Feb 4 2019, 2:09 PM
jyu2 added inline comments to D56571: [RFC prototype] Implementation of asm-goto support in clang.
Feb 4 2019, 11:13 AM
jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

1> Add code for scope checking
2> Using CastInterator
3> CFG change to remove duplicate Block list

Feb 4 2019, 11:04 AM
jyu2 commandeered D56571: [RFC prototype] Implementation of asm-goto support in clang.
Feb 4 2019, 10:39 AM

Jan 30 2019

jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

Change test for BE IR change.

Jan 30 2019, 12:26 PM

Jan 15 2019

jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

Change error message.

Jan 15 2019, 9:57 PM
jyu2 added inline comments to D56571: [RFC prototype] Implementation of asm-goto support in clang.
Jan 15 2019, 1:16 PM
jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

I add additional test.

Jan 15 2019, 1:04 PM

Jan 14 2019

jyu2 added inline comments to D56571: [RFC prototype] Implementation of asm-goto support in clang.
Jan 14 2019, 7:31 PM
jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

Add code to diagnostic error for use of the "l" modifier that does not point to a label in the label list.

Jan 14 2019, 7:30 PM
jyu2 added inline comments to D56571: [RFC prototype] Implementation of asm-goto support in clang.
Jan 14 2019, 10:52 AM

Jan 11 2019

jyu2 added inline comments to D56571: [RFC prototype] Implementation of asm-goto support in clang.
Jan 11 2019, 6:07 PM
jyu2 added inline comments to D56571: [RFC prototype] Implementation of asm-goto support in clang.
Jan 11 2019, 5:44 PM
jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

Couple of change to respond Eli’s comments.

Jan 11 2019, 5:38 PM
jyu2 added inline comments to D56571: [RFC prototype] Implementation of asm-goto support in clang.
Jan 11 2019, 2:01 PM
jyu2 added inline comments to D56571: [RFC prototype] Implementation of asm-goto support in clang.
Jan 11 2019, 11:51 AM
jyu2 updated the diff for D56571: [RFC prototype] Implementation of asm-goto support in clang.

1> I add code for CFG.cpp and a test for that, as efriedman request.
2> changes are respond the comments I received

Jan 11 2019, 11:45 AM
jyu2 commandeered D56571: [RFC prototype] Implementation of asm-goto support in clang.
Jan 11 2019, 11:43 AM

Aug 1 2017

jyu2 added a comment to D33537: [clang-tidy] Exception Escape Checker.

Test changed. I made some bad throws reachable, but the frontend check still does detects them.

Aug 1 2017, 8:35 AM · Restricted Project

Jul 13 2017

jyu2 added a comment to D33537: [clang-tidy] Exception Escape Checker.

The check in D33333 is using a CFG, not just checking direct throws.

I tested the latest revision (the fronted patch already included) on my test file. Disregarding of the not so important parameters (EnabledFunctions and IgnoredExceptions) I do not get warnings for any indirect throws (indirect_implicit() and indirect_explicit()). So for me it does not seem to be using the CFG. Furthermore, I do not get warning for throw_and_catch_some() where 1.1 is a double thus catch(int &) should not catch it. The same happens in throw_catch_rethrow_the_rest(), where catch(int &) should not catch 1.1, but catch(...) should catch and rethrow it. This latter may be a bug.

Jul 13 2017, 8:53 AM · Restricted Project

Jun 30 2017

jyu2 added inline comments to D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333.
Jun 30 2017, 5:19 PM
jyu2 updated the diff for D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333.

Hi Richard,

Jun 30 2017, 5:19 PM
jyu2 added inline comments to D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333.
Jun 30 2017, 4:38 PM
jyu2 updated the diff for D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333.

Hi Aaron,
Thank you so much for your review. I just update change to address your comments.

Jun 30 2017, 4:37 PM

Jun 29 2017

jyu2 added inline comments to D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333.
Jun 29 2017, 4:18 PM
jyu2 updated the diff for D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333.

Thank you so much Richard for your review. It is very good to know this select method for diagnostic.

Jun 29 2017, 4:11 PM

Jun 27 2017

jyu2 updated the summary of D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333.
Jun 27 2017, 9:44 AM

Jun 26 2017

jyu2 created D34671: This is to address more command from Richard Smith for my change of https://reviews.llvm.org/D33333.
Jun 26 2017, 11:31 PM

Jun 21 2017

jyu2 updated the diff for D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier.

Update test.

Jun 21 2017, 9:14 PM

Jun 16 2017

jyu2 added inline comments to D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier.
Jun 16 2017, 2:27 PM
jyu2 updated the diff for D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier.

update patch

Jun 16 2017, 2:27 PM