User Details
- User Since
- Dec 2 2016, 10:10 AM (355 w, 5 d)
Mon, Aug 28
Thanks. @rnk
Aug 28 2023
Thank you so much for the suggestion.
Before we do that, you should be able to delete the logic in CodeGenModule::getFunctionLinkage to handle inheriting constructor thunks. Your change should have the same effect. Can you do that, and check that it passes tests? If we do that, we're don't have to accumulate extra special case code, we've just moved the special case code earlier, up from codegen into the earlier linkage calculation.
Thanks @rnk. This is address his comment.
Our customer fond problem I submit bug: in https://github.com/llvm/llvm-project/issues/65045
Aug 22 2023
Aug 21 2023
Aug 17 2023
Aug 10 2023
Thanks all for the review! This is fix space problem.
Aug 9 2023
Jul 14 2023
LGTM.
Jul 7 2023
Thanks @jdoerfert, @ABataev and @aaron.ballman for the code reviews. This is addressing comments.
Jul 6 2023
Thanks Alexey for the review. This is address his comment.
Jul 5 2023
Fix typo.
Jul 3 2023
Thanks Alexey for the review!!
Jun 30 2023
Thanks Alexey!!!
Thanks Alexey's review. This address Alexey's comments.
Jun 29 2023
Checked in with rG085845a2acbe
Sorry, full diff.
Jun 28 2023
Thanks.
Thanks Alexey's review. This is address his comments.
Thanks Alexey for the review.
Thanks Alex for the review. This is to address his comments.
Jun 22 2023
May 30 2023
May 26 2023
May 25 2023
Thanks Alexey, sure I am separate the patch. This is first oen.
LGTM
May 17 2023
May 16 2023
May 11 2023
Address Eli's comment. Thanks for review!.
May 10 2023
Apr 27 2023
If it is okay with is_divece_ptr. I am okay with it.
Please add a lit test for this?
Apr 20 2023
I think something like
Apr 19 2023
Hi @serge-sans-paille, thanks for the fix. Could you please also try some test with dllimport/dllexport with inline function? Jennifer
Apr 18 2023
This change seems cause assert:
Mar 14 2023
Mar 13 2023
Fix clang format problem
Mar 9 2023
Mar 8 2023
Okay, I add code to get **a to work. Thanks Alexey for the review.
Mar 7 2023
Mar 6 2023
Add additional test as Alexey asked.
Mar 3 2023
Thanks Alexey for the code review. I removed loop by using last expression in the component for checking.
Mar 2 2023
Yes, I understand. And did not ask for it. I just mean that a[0][:3] emits different mapping data - TARGET_PAPARM|TO|FROM, PTR_AND_OBJ|TO|FROM
Thanks Alexey for the review.
I mean we shall emit the same mapping for (*a)[:3] and for a[0][:3]