- User Since
- Dec 2 2016, 10:10 AM (145 w, 2 d)
Jun 3 2019
jyu2 committed rGb8fee677bf8e: Re-check in clang support gun asm goto after fixing tests. (authored by jyu2).
May 30 2019
jyu2 committed rG954ec09aed4f: clang support gnu asm goto
May 29 2019
May 16 2019
Apr 25 2019
committed rGc19f4f806972: Fix bug 37903:MS ABI: handle inline static data member and inline variable as… (authored by jyu2).
Apr 24 2019
Apr 23 2019
Thanks for your review and catch what I were missing for inline variable part(only inline static data member were fix in previous patch).
As you suggested, instead using GVA_DiscardableODR to put inline variable's initialization function or inline static member's initialization functions into to COMDAT group with global being initialized.
Apr 22 2019
Looks good to me. We are basically de-mangled name for those E initialize global’s function and F destroy global's function.
Apr 19 2019
Apr 3 2019
Closed by commit rG0b28b8b09be7: Bug-40323: MS ABI adding template static member in the linker directive section… (authored by jyu2).
Mar 20 2019
Mar 18 2019
Mar 4 2019
Feb 22 2019
Feb 15 2019
Review comments addressed.
Review comment addressed
Feb 12 2019
Cleanup CFG code, remove obj-lifetime code when build CFE for asm-goto.
Feb 11 2019
I find some ambiguous error for asm-goto out of scope.
Instead call VerifyIndirectOrAsmJumps one time, call that function twice one for indirect-goto one for asm-goto.
Feb 8 2019
Feb 7 2019
Remove check for %lN
Fix missing successor of asm goto in CFG build.
Feb 5 2019
More change from review.
1>emit better error for use of output constraints.
2> Add assert for NumLabels and NumOutputs are both larger than 0.
Feb 4 2019
More review comments addressed.
1> Add code for scope checking
2> Using CastInterator
3> CFG change to remove duplicate Block list
Jan 30 2019
Change test for BE IR change.
Jan 15 2019
Change error message.
I add additional test.
Jan 14 2019
Add code to diagnostic error for use of the "l" modifier that does not point to a label in the label list.
Jan 11 2019
Couple of change to respond Eli’s comments.
1> I add code for CFG.cpp and a test for that, as efriedman request.
2> changes are respond the comments I received
Aug 1 2017
Jul 13 2017
Jun 30 2017
Thank you so much for your review. I just update change to address your comments.
Jun 29 2017
Thank you so much Richard for your review. It is very good to know this select method for diagnostic.
Jun 27 2017
Jun 26 2017
Jun 21 2017
Jun 16 2017
Thanks Aaron!!! I just upload new patch to address your comments. I now understand your point on when I can use auto.
Jun 15 2017
Address Aaron's comments.
Jun 5 2017
Add more test include 1> throw/catch reference types. 2> try block. 3>unreachable code.
Jun 2 2017
Jun 1 2017
Update to address review comments.
May 30 2017
Okay this CFG version of this change. In this change I am basic using same algorithm with -Winfinite-recursion.
May 23 2017
I missed two place which Aaron point out.
1> using isNothrow function instead NR_Nothrow.
2> A format problem.
May 22 2017
This is new version should address all @Aaron's commands, but CFG part.
May 21 2017
May 18 2017
Thank you so much for your comments. I upload new patch to address your suggestion.
1> Emit warning for throw exception in all noexcept function. And special diagnostic note for destructor and delete operators.
2> Silence this warning when the throw inside try block.
Dec 6 2016
last one missing test part diff. Sorry for that