Page MenuHomePhabricator

jyu2 (Jennifer Yu)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 2 2016, 10:10 AM (297 w, 1 d)

Recent Activity

Yesterday

jyu2 committed rG2ca27206f973: [OpenMP] Fix segmentation fault when data field is used in is_device_pt (authored by jyu2).
[OpenMP] Fix segmentation fault when data field is used in is_device_pt
Fri, Aug 12, 5:20 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 closed D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt..
Fri, Aug 12, 5:20 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt..
Fri, Aug 12, 12:38 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt..

Fix test problem.

Fri, Aug 12, 12:38 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Aug 11

jyu2 updated the diff for D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt..

Thanks Alexey. This to fix test format.

Thu, Aug 11, 1:19 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt..
Thu, Aug 11, 12:05 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt..
Thu, Aug 11, 11:48 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt..

Thanks Alexey! Address the comment.

Thu, Aug 11, 11:48 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Aug 3

jyu2 committed rGa7bca18bc50c: Fix assert during the call to getCanonicalDecl. (authored by jyu2).
Fix assert during the call to getCanonicalDecl.
Wed, Aug 3, 9:20 AM · Restricted Project, Restricted Project
jyu2 closed D131024: Fix assert in the call to isOpenMPRebuildMemberExpr.
Wed, Aug 3, 9:20 AM · Restricted Project, Restricted Project

Tue, Aug 2

jyu2 edited reviewers for D131024: Fix assert in the call to isOpenMPRebuildMemberExpr, added: ABataev; removed: jdoerfert.
Tue, Aug 2, 2:38 PM · Restricted Project, Restricted Project
jyu2 requested review of D131024: Fix assert in the call to isOpenMPRebuildMemberExpr.
Tue, Aug 2, 2:36 PM · Restricted Project, Restricted Project
jyu2 added a comment to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..

I noticed that this patch is causing now an assertion failure for cases like :

class A{

void a() {
  #pragma omp parallel
  a(b);
}

};

The failed assertion is: "const clang::ValueDecl* getCanonicalDecl(const clang::ValueDecl*): Assertion `FD' failed."

while before it clang was correctly reporting error:
error: use of undeclared identifier 'b'

is it the same assertion you were trying to fix here?

No, the assert I am fixing is when default(firstprivate) is used inside member function.

Could you please investigate and fix it?

Tue, Aug 2, 8:31 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 added a comment to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..

I noticed that this patch is causing now an assertion failure for cases like :

class A{

void a() {
  #pragma omp parallel
  a(b);
}

};

The failed assertion is: "const clang::ValueDecl* getCanonicalDecl(const clang::ValueDecl*): Assertion `FD' failed."

while before it clang was correctly reporting error:
error: use of undeclared identifier 'b'

is it the same assertion you were trying to fix here?

Tue, Aug 2, 8:06 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jul 25

jyu2 added inline comments to D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc..
Mon, Jul 25, 12:23 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc..
Mon, Jul 25, 11:02 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc..
Mon, Jul 25, 10:45 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc..
Mon, Jul 25, 10:16 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc..
Mon, Jul 25, 9:44 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jul 22

jyu2 added a comment to D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc..

Why does it get truncated if the type must be integer? Probably, something incorrect in sema.

Fri, Jul 22, 10:29 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 added a comment to D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc..

Ping!

Fri, Jul 22, 7:04 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jul 15

jyu2 requested review of D129872: [clang][OpenMP] Fix runtime crash in the call to __kmp_alloc..
Fri, Jul 15, 9:08 AM · Restricted Project, Restricted Project, Restricted Project

Jul 12 2022

jyu2 added reviewers for D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt.: ABataev, mikerice.
Jul 12 2022, 5:52 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 requested review of D129608: [Clang][OpenMP] Fix segmentation fault when data field is used in is_device_pt..
Jul 12 2022, 5:49 PM · Restricted Project, Restricted Project, Restricted Project

Jul 1 2022

jyu2 committed rG927156a67445: Generate the capture for the field when the field is used in openmp (authored by jyu2).
Generate the capture for the field when the field is used in openmp
Jul 1 2022, 5:33 PM · Restricted Project, Restricted Project
jyu2 closed D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Jul 1 2022, 5:33 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..

Thank Alexey for the review. This is remove check for omp region just use hasDSA.

Jul 1 2022, 12:04 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Jul 1 2022, 12:02 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Jul 1 2022, 9:20 AM · Restricted Project, Restricted Project, Restricted Project

Jun 30 2022

jyu2 added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Jun 30 2022, 6:16 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..

Thanks Alexey for the review. This patch to address his comment.

Jun 30 2022, 6:14 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Jun 30 2022, 9:04 AM · Restricted Project, Restricted Project, Restricted Project

Jun 29 2022

jyu2 updated the diff for D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..

Thanks Alexey for the review.
This is to address Alexey's comments,

Jun 29 2022, 10:01 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..

Thanks Alexey for the review.
Add change in TreeTransform.h to rebuilt member expression.

Jun 29 2022, 9:11 AM · Restricted Project, Restricted Project, Restricted Project

Jun 24 2022

jyu2 added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Jun 24 2022, 3:33 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Jun 24 2022, 3:27 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Jun 24 2022, 10:11 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..

Remove change in TreeTransform.h. Will deal that in other patch. Thanks.

Jun 24 2022, 10:11 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Jun 24 2022, 8:53 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Jun 24 2022, 8:00 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..

Address Alexey's comments! Thanks.

Jun 24 2022, 7:57 AM · Restricted Project, Restricted Project, Restricted Project

Jun 23 2022

jyu2 added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Jun 23 2022, 5:16 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..

Thanks Alexey's review. Address Alexey's review.

Jun 23 2022, 5:16 PM · Restricted Project, Restricted Project, Restricted Project

Jun 22 2022

jyu2 added inline comments to D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Jun 22 2022, 4:01 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..

Thanks Alexey for the review. This is address Alexey's comments.

Jun 22 2022, 4:00 PM · Restricted Project, Restricted Project, Restricted Project

Jun 21 2022

jyu2 updated the diff for D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..

Thanks Alexey's comment. Address his comment. Instead save info into DSA, add new field in ImplicitDefaultFirstprivateFDs in SharingMapTy.

Jun 21 2022, 5:29 PM · Restricted Project, Restricted Project, Restricted Project

Jun 16 2022

jyu2 committed rGbb83f8e70bd1: [OpenMP] Initial parsing and sema for 'parallel masked' construct (authored by jyu2).
[OpenMP] Initial parsing and sema for 'parallel masked' construct
Jun 16 2022, 6:16 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 closed D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct .
Jun 16 2022, 6:16 PM · Restricted Project, Restricted Project, Restricted Project

Jun 14 2022

jyu2 requested review of D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function..
Jun 14 2022, 3:06 PM · Restricted Project, Restricted Project, Restricted Project

May 19 2022

jyu2 committed rG7aa9c3938198: [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause (authored by jyu2).
[Clang][[OpenMP5.1] Initial parser/sema for default(private) clause
May 19 2022, 12:47 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 closed D125912: [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause.
May 19 2022, 12:47 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D125912: [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause.

Thanks Alexey for the review. This is fix the nit.

May 19 2022, 9:28 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 18 2022

jyu2 requested review of D125912: [Clang][[OpenMP5.1] Initial parser/sema for default(private) clause.
May 18 2022, 11:01 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 8 2022

jyu2 committed rG187ccc66fa5d: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr (authored by jyu2).
[clang][OpenMP5.1] Initial parsing/sema for has_device_addr
Apr 8 2022, 9:32 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
jyu2 closed D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr.
Apr 8 2022, 9:32 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr.

Add test in cfg-openmp.cpp

Apr 8 2022, 6:00 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr.
Apr 8 2022, 2:39 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr.

Thanks Alexey, for the review! This patch addresses his comments.

Apr 8 2022, 2:35 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
jyu2 requested review of D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr.
Apr 8 2022, 9:33 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 31 2022

jyu2 requested review of D122852: [OPENMP] Fix assertion in clang::ASTContext::getTypeInfoImpl.
Mar 31 2022, 3:06 PM · Restricted Project, Restricted Project

Mar 24 2022

jyu2 added a comment to D122338: [OPENMP] Eliminate extra set of simd variant function attribute..

LG

Mar 24 2022, 1:47 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 committed rGa6cdac48ffaf: Eliminate extra set of simd variant function attribute. (authored by jyu2).
Eliminate extra set of simd variant function attribute.
Mar 24 2022, 1:46 PM · Restricted Project, Restricted Project
jyu2 closed D122338: [OPENMP] Eliminate extra set of simd variant function attribute..
Mar 24 2022, 1:46 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D122338: [OPENMP] Eliminate extra set of simd variant function attribute..

Address Alexey comment.

Mar 24 2022, 10:32 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D122338: [OPENMP] Eliminate extra set of simd variant function attribute..

Address Alexey's comment.

Mar 24 2022, 8:59 AM · Restricted Project, Restricted Project, Restricted Project

Mar 23 2022

jyu2 updated the diff for D122338: [OPENMP] Eliminate extra set of simd variant function attribute..
Mar 23 2022, 2:27 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 added a comment to D122338: [OPENMP] Eliminate extra set of simd variant function attribute..

If ParamPositions grows, it means that the item is not found. Is it correct behavior if the compiler inserts new item in the ParamPositions map?

Mar 23 2022, 2:22 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 requested review of D122338: [OPENMP] Eliminate extra set of simd variant function attribute..
Mar 23 2022, 12:00 PM · Restricted Project, Restricted Project, Restricted Project

Mar 22 2022

jyu2 accepted D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments.

This is okay with me.

Mar 22 2022, 8:21 PM · Restricted Project, Restricted Project

Mar 21 2022

jyu2 added inline comments to D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments.
Mar 21 2022, 7:48 AM · Restricted Project, Restricted Project

Mar 10 2022

jyu2 added inline comments to D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments.
Mar 10 2022, 3:31 PM · Restricted Project, Restricted Project

Mar 9 2022

jyu2 added inline comments to D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments.
Mar 9 2022, 8:17 AM · Restricted Project, Restricted Project

Jan 10 2022

jyu2 committed rG140a6b1e5c68: [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause (authored by jyu2).
[clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause
Jan 10 2022, 5:11 PM
jyu2 closed D116764: [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause.
Jan 10 2022, 5:11 PM · Restricted Project, Restricted Project, Restricted Project

Jan 7 2022

jyu2 updated the diff for D116764: [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause.

Fix format problem.

Jan 7 2022, 3:05 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 accepted D116059: [Clang][CFG] check children statements of asm goto.

Looks good to me. Thanks.

Jan 7 2022, 1:20 PM · Restricted Project

Jan 6 2022

jyu2 added a comment to D116764: [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause.

Thanks Alexey for the code review.

Jan 6 2022, 8:25 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D116764: [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause.

Address Alexey's comments.

Jan 6 2022, 8:24 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 requested review of D116764: [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause.
Jan 6 2022, 12:37 PM · Restricted Project, Restricted Project, Restricted Project

Oct 22 2021

jyu2 added a comment to D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive.

Good point. I did not find that. At this point, I don't know if we need this change. I checked gnu, gnu allow this.... :-(

Oct 22 2021, 1:26 PM · Restricted Project, Restricted Project
jyu2 updated the diff for D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive.

fix format problem.

Oct 22 2021, 11:05 AM · Restricted Project, Restricted Project
jyu2 added a comment to D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive.

In which standard version was that rule introduced, is this missing some checks for the OpenMP version?

Oct 22 2021, 9:26 AM · Restricted Project, Restricted Project
jyu2 added inline comments to D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive.
Oct 22 2021, 8:40 AM · Restricted Project, Restricted Project
jyu2 updated the diff for D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive.
Oct 22 2021, 8:39 AM · Restricted Project, Restricted Project
jyu2 added inline comments to D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive.
Oct 22 2021, 8:05 AM · Restricted Project, Restricted Project
jyu2 added a comment to D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive.

Hi Alexey, Thanks for review.

Oct 22 2021, 7:56 AM · Restricted Project, Restricted Project

Oct 21 2021

jyu2 requested review of D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive.
Oct 21 2021, 8:12 PM · Restricted Project, Restricted Project

Oct 6 2021

jyu2 committed rGa4743eba3c13: Fix assert of "Unable to find base lambda address" from (authored by jyu2).
Fix assert of "Unable to find base lambda address" from
Oct 6 2021, 2:39 PM
jyu2 closed D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures..
Oct 6 2021, 2:38 PM · Restricted Project, Restricted Project

Oct 5 2021

jyu2 updated the diff for D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures..

Adding check for map type in test. Thanks Alexey.

Oct 5 2021, 9:22 PM · Restricted Project, Restricted Project
jyu2 updated the diff for D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures..

Thanks Alexey! Fix missing Modifiers.

Oct 5 2021, 2:36 PM · Restricted Project, Restricted Project
jyu2 updated the diff for D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures..

Address Alexey's comments.

Oct 5 2021, 1:48 PM · Restricted Project, Restricted Project
jyu2 added inline comments to D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures..
Oct 5 2021, 11:55 AM · Restricted Project, Restricted Project
jyu2 updated the diff for D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures..

Thanks Alexey's review. This patch is address Alexe's comments by adding new field LambdasMap.

Oct 5 2021, 10:11 AM · Restricted Project, Restricted Project

Oct 4 2021

jyu2 requested review of D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures..
Oct 4 2021, 9:55 PM · Restricted Project, Restricted Project

Aug 19 2021

jyu2 added a comment to D108132: Add implicit map for a list item appears in a reduction clause..

Thank you so much for Alex's review!!!

Aug 19 2021, 1:04 PM · Restricted Project, Restricted Project
jyu2 committed rGc274b1986680: Add implicit map for a list item appears in a reduction clause. (authored by jyu2).
Add implicit map for a list item appears in a reduction clause.
Aug 19 2021, 1:04 PM
jyu2 closed D108132: Add implicit map for a list item appears in a reduction clause..
Aug 19 2021, 1:04 PM · Restricted Project, Restricted Project

Aug 17 2021

jyu2 updated the diff for D108132: Add implicit map for a list item appears in a reduction clause..

Address Alex's comment.

Aug 17 2021, 12:57 PM · Restricted Project, Restricted Project
jyu2 added inline comments to D108132: Add implicit map for a list item appears in a reduction clause..
Aug 17 2021, 12:15 PM · Restricted Project, Restricted Project