Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

jyu2 (Jennifer Yu)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 2 2016, 10:10 AM (355 w, 5 d)

Recent Activity

Mon, Aug 28

jyu2 added a comment to D158538: [MS-ABI] Remove comdat attribute for inheriting ctor..

Thanks. @rnk

Mon, Aug 28, 6:12 PM · Restricted Project, Restricted Project
jyu2 committed rG1d0bd8e51be2: [MSABI] Remove comdat attribute for inheriting ctor. (authored by jyu2).
[MSABI] Remove comdat attribute for inheriting ctor.
Mon, Aug 28, 3:28 PM · Restricted Project, Restricted Project
jyu2 closed D158538: [MS-ABI] Remove comdat attribute for inheriting ctor..
Mon, Aug 28, 3:28 PM · Restricted Project, Restricted Project

Aug 28 2023

jyu2 added a comment to D158538: [MS-ABI] Remove comdat attribute for inheriting ctor..

Thank you so much for the suggestion.

Before we do that, you should be able to delete the logic in CodeGenModule::getFunctionLinkage to handle inheriting constructor thunks. Your change should have the same effect. Can you do that, and check that it passes tests? If we do that, we're don't have to accumulate extra special case code, we've just moved the special case code earlier, up from codegen into the earlier linkage calculation.

Aug 28 2023, 1:00 PM · Restricted Project, Restricted Project
jyu2 updated the diff for D158538: [MS-ABI] Remove comdat attribute for inheriting ctor..

Thanks @rnk. This is address his comment.

Aug 28 2023, 1:00 PM · Restricted Project, Restricted Project
jyu2 added a comment to D158538: [MS-ABI] Remove comdat attribute for inheriting ctor..

Our customer fond problem I submit bug: in https://github.com/llvm/llvm-project/issues/65045

Aug 28 2023, 9:12 AM · Restricted Project, Restricted Project

Aug 22 2023

jyu2 requested review of D158538: [MS-ABI] Remove comdat attribute for inheriting ctor..
Aug 22 2023, 12:07 PM · Restricted Project, Restricted Project

Aug 21 2023

jyu2 committed rGff08c8e57e39: [SEH] Fix wrong argument passes to the call of OutlinedFinally. (authored by jyu2).
[SEH] Fix wrong argument passes to the call of OutlinedFinally.
Aug 21 2023, 5:12 PM · Restricted Project, Restricted Project
jyu2 closed D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally..
Aug 21 2023, 5:12 PM · Restricted Project, Restricted Project
jyu2 added inline comments to D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally..
Aug 21 2023, 4:02 PM · Restricted Project, Restricted Project
jyu2 updated the diff for D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally..
Aug 21 2023, 4:01 PM · Restricted Project, Restricted Project
jyu2 updated the summary of D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally..
Aug 21 2023, 6:20 AM · Restricted Project, Restricted Project

Aug 17 2023

jyu2 requested review of D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally..
Aug 17 2023, 4:45 PM · Restricted Project, Restricted Project

Aug 10 2023

jyu2 committed rG33e3b2c46084: Fix assertion when -fasy-exception is used. (authored by jyu2).
Fix assertion when -fasy-exception is used.
Aug 10 2023, 9:59 PM · Restricted Project, Restricted Project
jyu2 closed D157566: [SEH] fix assertion when -fasy-exceptions is used..
Aug 10 2023, 9:59 PM · Restricted Project, Restricted Project
jyu2 updated the diff for D157566: [SEH] fix assertion when -fasy-exceptions is used..

Thanks all for the review! This is fix space problem.

Aug 10 2023, 2:39 PM · Restricted Project, Restricted Project

Aug 9 2023

jyu2 requested review of D157566: [SEH] fix assertion when -fasy-exceptions is used..
Aug 9 2023, 5:57 PM · Restricted Project, Restricted Project

Jul 14 2023

jyu2 added inline comments to D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes.
Jul 14 2023, 4:09 PM · Restricted Project, Restricted Project
jyu2 accepted D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes.

LGTM.

Jul 14 2023, 4:06 PM · Restricted Project, Restricted Project

Jul 7 2023

jyu2 committed rG852fe30b687e: [OPENMP52] Deprecation of 'depend' clause in ordered directive. (authored by jyu2).
[OPENMP52] Deprecation of 'depend' clause in ordered directive.
Jul 7 2023, 1:20 PM · Restricted Project, Restricted Project
jyu2 closed D154672: [OPENMP52] Deprecation of 'depend' clause in ordered directive..
Jul 7 2023, 1:20 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D154672: [OPENMP52] Deprecation of 'depend' clause in ordered directive..
Jul 7 2023, 8:53 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D154672: [OPENMP52] Deprecation of 'depend' clause in ordered directive..

Thanks @jdoerfert, @ABataev and @aaron.ballman for the code reviews. This is addressing comments.

Jul 7 2023, 8:53 AM · Restricted Project, Restricted Project, Restricted Project

Jul 6 2023

jyu2 requested review of D154672: [OPENMP52] Deprecation of 'depend' clause in ordered directive..
Jul 6 2023, 6:35 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 committed rGf70967fdc473: [OPENMP52] Support Support omp_cur_iteration modifier for doacross (authored by jyu2).
[OPENMP52] Support Support omp_cur_iteration modifier for doacross
Jul 6 2023, 11:54 AM · Restricted Project, Restricted Project
jyu2 closed D154556: [OPENMP52] Support Support omp_cur_iteration modifier for doacross clause..
Jul 6 2023, 11:53 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D154556: [OPENMP52] Support Support omp_cur_iteration modifier for doacross clause..
Jul 6 2023, 8:47 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D154556: [OPENMP52] Support Support omp_cur_iteration modifier for doacross clause..

Thanks Alexey for the review. This is address his comment.

Jul 6 2023, 8:47 AM · Restricted Project, Restricted Project, Restricted Project

Jul 5 2023

jyu2 updated the diff for D154556: [OPENMP52] Support Support omp_cur_iteration modifier for doacross clause..

Fix typo.

Jul 5 2023, 5:32 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 requested review of D154556: [OPENMP52] Support Support omp_cur_iteration modifier for doacross clause..
Jul 5 2023, 5:29 PM · Restricted Project, Restricted Project, Restricted Project

Jul 3 2023

jyu2 committed rG35041a435def: [OPENMP52] Codegen support for doacross clause. (authored by jyu2).
[OPENMP52] Codegen support for doacross clause.
Jul 3 2023, 3:36 PM · Restricted Project, Restricted Project
jyu2 closed D154180: [OPENMP52] Codegen support for doacross clause..
Jul 3 2023, 3:35 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 added a comment to D154180: [OPENMP52] Codegen support for doacross clause..

LG with a nit

Jul 3 2023, 2:01 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D154180: [OPENMP52] Codegen support for doacross clause..
Jul 3 2023, 10:30 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D154180: [OPENMP52] Codegen support for doacross clause..

Thanks Alexey for the review!!

Jul 3 2023, 10:30 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D154180: [OPENMP52] Codegen support for doacross clause..
Jul 3 2023, 9:29 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D154180: [OPENMP52] Codegen support for doacross clause..
Jul 3 2023, 9:29 AM · Restricted Project, Restricted Project, Restricted Project

Jun 30 2023

jyu2 added inline comments to D154180: [OPENMP52] Codegen support for doacross clause..
Jun 30 2023, 2:48 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D154180: [OPENMP52] Codegen support for doacross clause..

Thanks Alexey!!!

Jun 30 2023, 2:48 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D154180: [OPENMP52] Codegen support for doacross clause..
Jun 30 2023, 1:36 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D154180: [OPENMP52] Codegen support for doacross clause..

Thanks Alexey's review. This address Alexey's comments.

Jun 30 2023, 1:36 PM · Restricted Project, Restricted Project, Restricted Project

Jun 29 2023

jyu2 updated the summary of D154180: [OPENMP52] Codegen support for doacross clause..
Jun 29 2023, 9:02 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 requested review of D154180: [OPENMP52] Codegen support for doacross clause..
Jun 29 2023, 9:01 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 closed D153556: [OPENMP52] Initial support for doacross clause..

Checked in with rG085845a2acbe

Jun 29 2023, 12:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
jyu2 committed rG085845a2acbe: [OMP5.2] Initial support for doacross clause. (authored by jyu2).
[OMP5.2] Initial support for doacross clause.
Jun 29 2023, 12:08 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D153556: [OPENMP52] Initial support for doacross clause..

Sorry, full diff.

Jun 29 2023, 7:42 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 28 2023

jyu2 added a comment to D153556: [OPENMP52] Initial support for doacross clause..

Thanks.

Jun 28 2023, 7:57 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D153556: [OPENMP52] Initial support for doacross clause..

Thanks Alexey's review. This is address his comments.

Jun 28 2023, 7:55 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
jyu2 added a comment to D153556: [OPENMP52] Initial support for doacross clause..

Thanks Alexey for the review.

Jun 28 2023, 2:01 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D153556: [OPENMP52] Initial support for doacross clause..

Thanks Alex for the review. This is to address his comments.

Jun 28 2023, 1:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 22 2023

jyu2 requested review of D153556: [OPENMP52] Initial support for doacross clause..
Jun 22 2023, 8:00 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 30 2023

jyu2 committed rGaaa33b6a98de: Fix assert "DeclRefExpr for Decl not entered in LocalDeclMap?" (authored by jyu2).
Fix assert "DeclRefExpr for Decl not entered in LocalDeclMap?"
May 30 2023, 4:48 PM · Restricted Project, Restricted Project
jyu2 closed D151743: [OMP] Fix compiler assert "DeclRefExpr for Decl not entered in LocalDeclMap?".
May 30 2023, 4:47 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 requested review of D151743: [OMP] Fix compiler assert "DeclRefExpr for Decl not entered in LocalDeclMap?".
May 30 2023, 11:58 AM · Restricted Project, Restricted Project, Restricted Project

May 26 2023

jyu2 committed rG3108c1b81173: skip test run on amdgcn-amd-amdhsa (authored by jyu2).
skip test run on amdgcn-amd-amdhsa
May 26 2023, 4:28 PM · Restricted Project, Restricted Project
jyu2 committed rGa419ec4f256d: Fix runtime crash inside __kmpc_init_allocator (authored by jyu2).
Fix runtime crash inside __kmpc_init_allocator
May 26 2023, 4:06 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 closed D151576: Fix runtime crash inside __kmpc_init_allocator.
May 26 2023, 4:06 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 added a comment to D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage.

@jyu2 : could you test that patch in your setup ? Also I can't find the bug id associated with your original bug anymore...

May 26 2023, 1:37 PM · Restricted Project, Restricted Project
jyu2 requested review of D151576: Fix runtime crash inside __kmpc_init_allocator.
May 26 2023, 11:24 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 committed rGacb1b4fbb793: Fix wrong error message when compiling C souce code: (authored by jyu2).
Fix wrong error message when compiling C souce code:
May 26 2023, 10:27 AM · Restricted Project, Restricted Project
jyu2 closed D151517: Fix wrong error message when compiling C souce code.
May 26 2023, 10:27 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 added a comment to D151517: Fix wrong error message when compiling C souce code.

Could you split it into 3 separate patch

May 26 2023, 7:37 AM · Restricted Project, Restricted Project, Restricted Project

May 25 2023

jyu2 updated the diff for D151517: Fix wrong error message when compiling C souce code.

Thanks Alexey, sure I am separate the patch. This is first oen.

May 25 2023, 6:05 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 requested review of D151517: Fix wrong error message when compiling C souce code.
May 25 2023, 4:33 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 accepted D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device.

LGTM

May 25 2023, 8:14 AM · Restricted Project, Restricted Project

May 17 2023

jyu2 committed rG691927c904ed: Fix assertion when try is used inside catch(...) block (authored by jyu2).
Fix assertion when try is used inside catch(...) block
May 17 2023, 2:56 PM · Restricted Project, Restricted Project
jyu2 closed D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa.
May 17 2023, 2:56 PM · Restricted Project, Restricted Project

May 16 2023

jyu2 added a comment to D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa.

LGTM... but I don't think the IR we're generating is really correct overall; see https://github.com/llvm/llvm-project/issues/62723

On a side-note, other open issues related to -EHa/__try:

https://github.com/llvm/llvm-project/issues/62606
D124642

May 16 2023, 10:14 AM · Restricted Project, Restricted Project

May 11 2023

jyu2 updated the diff for D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa.

Address Eli's comment. Thanks for review!.

May 11 2023, 3:23 PM · Restricted Project, Restricted Project
jyu2 added inline comments to D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa.
May 11 2023, 1:53 PM · Restricted Project, Restricted Project

May 10 2023

jyu2 requested review of D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa.
May 10 2023, 7:56 PM · Restricted Project, Restricted Project

Apr 27 2023

jyu2 added a comment to D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device.

If it is okay with is_divece_ptr. I am okay with it.
Please add a lit test for this?

Apr 27 2023, 8:31 AM · Restricted Project, Restricted Project

Apr 20 2023

jyu2 added a comment to D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage.

I think something like

Apr 20 2023, 8:46 AM · Restricted Project, Restricted Project

Apr 19 2023

jyu2 added a comment to D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage.

Hi @serge-sans-paille, thanks for the fix. Could you please also try some test with dllimport/dllexport with inline function? Jennifer

Apr 19 2023, 9:58 AM · Restricted Project, Restricted Project

Apr 18 2023

jyu2 added a comment to D147307: [clang] Do not require GNUInlineAttr for inline builtins.

This change seems cause assert:

Apr 18 2023, 9:16 PM · Restricted Project, Restricted Project

Mar 14 2023

jyu2 committed rG3d9880ebbcb7: [OpenMP]Skip generating this[:1] map info for non-member variable. (authored by jyu2).
[OpenMP]Skip generating this[:1] map info for non-member variable.
Mar 14 2023, 9:19 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 closed D146000: [OpenMP]Skip generating this[:1] map info for non-member variable..
Mar 14 2023, 9:19 AM · Restricted Project, Restricted Project, Restricted Project

Mar 13 2023

jyu2 updated the diff for D146000: [OpenMP]Skip generating this[:1] map info for non-member variable..

Fix clang format problem

Mar 13 2023, 6:31 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 requested review of D146000: [OpenMP]Skip generating this[:1] map info for non-member variable..
Mar 13 2023, 4:28 PM · Restricted Project, Restricted Project, Restricted Project

Mar 9 2023

jyu2 added a comment to D145093: [OpenMP] Add map info for dereference pointer..
Mar 9 2023, 11:33 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 added a reverting change for rG8cf85a0cadb0: Revert "Add map info for dereference pointer.": rG8da99b44b6a5: Revert "Revert "Add map info for dereference pointer."".
Mar 9 2023, 11:33 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 committed rG8da99b44b6a5: Revert "Revert "Add map info for dereference pointer."" (authored by jyu2).
Revert "Revert "Add map info for dereference pointer.""
Mar 9 2023, 11:33 AM · Restricted Project, Restricted Project, Restricted Project

Mar 8 2023

jyu2 committed rG0f2f37842582: Add map info for dereference pointer. (authored by jyu2).
Add map info for dereference pointer.
Mar 8 2023, 5:59 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 closed D145093: [OpenMP] Add map info for dereference pointer..
Mar 8 2023, 5:59 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D145093: [OpenMP] Add map info for dereference pointer..

Okay, I add code to get **a to work. Thanks Alexey for the review.

Mar 8 2023, 10:13 AM · Restricted Project, Restricted Project, Restricted Project

Mar 7 2023

jyu2 added inline comments to D145093: [OpenMP] Add map info for dereference pointer..
Mar 7 2023, 7:51 AM · Restricted Project, Restricted Project, Restricted Project

Mar 6 2023

jyu2 added inline comments to D145093: [OpenMP] Add map info for dereference pointer..
Mar 6 2023, 3:52 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D145093: [OpenMP] Add map info for dereference pointer..

Add additional test as Alexey asked.

Mar 6 2023, 3:52 PM · Restricted Project, Restricted Project, Restricted Project

Mar 3 2023

jyu2 added inline comments to D145093: [OpenMP] Add map info for dereference pointer..
Mar 3 2023, 2:57 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D145093: [OpenMP] Add map info for dereference pointer..
Mar 3 2023, 9:11 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D145093: [OpenMP] Add map info for dereference pointer..

Thanks Alexey for the code review. I removed loop by using last expression in the component for checking.

Mar 3 2023, 9:10 AM · Restricted Project, Restricted Project, Restricted Project

Mar 2 2023

jyu2 added inline comments to D145093: [OpenMP] Add map info for dereference pointer..
Mar 2 2023, 12:30 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D145093: [OpenMP] Add map info for dereference pointer..
Mar 2 2023, 11:33 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 added a comment to D145093: [OpenMP] Add map info for dereference pointer..

Yes, I understand. And did not ask for it. I just mean that a[0][:3] emits different mapping data - TARGET_PAPARM|TO|FROM, PTR_AND_OBJ|TO|FROM

Mar 2 2023, 10:47 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 updated the diff for D145093: [OpenMP] Add map info for dereference pointer..

Thanks Alexey for the review.

Mar 2 2023, 10:47 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 added a comment to D145093: [OpenMP] Add map info for dereference pointer..

I mean we shall emit the same mapping for (*a)[:3] and for a[0][:3]

Mar 2 2023, 8:57 AM · Restricted Project, Restricted Project, Restricted Project
jyu2 added a comment to D145093: [OpenMP] Add map info for dereference pointer..

What result produces map(a[0][:3]?

Mar 2 2023, 8:37 AM · Restricted Project, Restricted Project, Restricted Project

Mar 1 2023

jyu2 updated the summary of D145093: [OpenMP] Add map info for dereference pointer..
Mar 1 2023, 6:05 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 added inline comments to D145093: [OpenMP] Add map info for dereference pointer..
Mar 1 2023, 4:24 PM · Restricted Project, Restricted Project, Restricted Project
jyu2 requested review of D145093: [OpenMP] Add map info for dereference pointer..
Mar 1 2023, 11:20 AM · Restricted Project, Restricted Project, Restricted Project