The patch handles fixed type strict-fp by new RISCVISD::STRICT_ prefixed
isd nodes.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td | ||
|---|---|---|
| 829 | The type of any_fadd is PatFrag and the type of first argument of VPatBinaryFPSDNode_VV_VF. I am not sure what types contains PatFrag and SDNode. | |
| llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td | ||
|---|---|---|
| 829 | I think the common base class is SDPatternOperator. | |
| llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td | ||
|---|---|---|
| 829 | Done. Thank your advise. | |
| llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td | ||
|---|---|---|
| 835 | This line still looks identical to the line before it. | |
| llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td | ||
|---|---|---|
| 835 | Sorry, I mis-filled the done status. | |
| llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td | ||
|---|---|---|
| 835 | The reason I didn't deal with widen operations now is we need to deal with (any_fadd (any_fpextend)) and the test cases change may be too large to read. Is my concern over-thinking? Actually I don't know how large should a patch be ? | |
| llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td | ||
|---|---|---|
| 835 | We can skip widening instructions for now. | |
| llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td | ||
|---|---|---|
| 835 | Thank you. I will support it within subsequent corresponding patches. | |
| llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td | ||
|---|---|---|
| 835 | Can you delete the second copy of defm : VPatWidenBinaryFPSDNode_VV_VF_WV_WF<fadd, "PseudoVFWADD">; that was added so I can approve this patch? | |
clang-format suggested style edits found: