Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Looks good to me except a nit and a question to the FIXME. I would prefer another person to also review the patch and approve it though.
llvm/lib/Target/RISCV/RISCVISelLowering.cpp | ||
---|---|---|
458 | This should trigger clang-foramt. | |
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vmax-vp.ll | ||
10 | Nit: %b to %vb | |
365 | Just to make sure, do you mean that LMUL should be m4 here? |
llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vmax-vp.ll | ||
---|---|---|
365 | I copied this from the vadd test. The VL is 128 so the upper half VL is zero as you can see in the vsetvli. But we don't strip any of the unneed code. |
llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp | ||
---|---|---|
174 | I think that uses sext for scalar i32 on RISC-V by calling isSExtCheaperThanZExt |
This should link to umin <int_umin>