This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][VP] Add RVV codegen for vp.trunc.
ClosedPublic

Authored by jacquesguan on Apr 12 2022, 2:36 AM.

Diff Detail

Event Timeline

jacquesguan created this revision.Apr 12 2022, 2:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2022, 2:36 AM
jacquesguan requested review of this revision.Apr 12 2022, 2:36 AM
frasercrmck added inline comments.Apr 12 2022, 4:33 AM
llvm/lib/Target/RISCV/RISCVISelLowering.cpp
3171–3172

Can trim the unnecessary {} now too

llvm/test/CodeGen/RISCV/rvv/fixed-vector-trunc-vp-mask.ll
3

-verify-machineinstrs wouldn't hurt

craig.topper added inline comments.Apr 12 2022, 8:59 AM
llvm/lib/Target/RISCV/RISCVISelLowering.cpp
4355

Am I crazy or are these splats missing their VL operand?

Address comment.

jacquesguan added inline comments.Apr 12 2022, 8:02 PM
llvm/lib/Target/RISCV/RISCVISelLowering.cpp
3171–3172

Done.

4355

I add the VL operand, I think it work without VL because those splat will finally match to vi instructions.

This revision is now accepted and ready to land.Apr 14 2022, 8:40 AM
This revision was landed with ongoing or failed builds.Apr 14 2022, 7:30 PM
This revision was automatically updated to reflect the committed changes.