This is an archive of the discontinued LLVM Phabricator instance.

[clang][OpenMP5.1] Initial parsing/sema for has_device_addr
ClosedPublic

Authored by jyu2 on Apr 8 2022, 9:33 AM.

Details

Summary

Added basic parsing/sema/ support for the 'has_device_addr' clause

Diff Detail

Event Timeline

jyu2 created this revision.Apr 8 2022, 9:33 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
jyu2 requested review of this revision.Apr 8 2022, 9:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2022, 9:33 AM

I think it worth it to add the analysis test for the clause

clang/lib/AST/OpenMPClause.cpp
1465

auto *

clang/lib/Serialization/ASTReader.cpp
12848

Use I instead of i everywhere in this function

llvm/include/llvm/Frontend/OpenMP/OMP.td
564

VersionedClause<OMPC_HasDeviceAddr, 51>,

661

VersionedClause<OMPC_HasDeviceAddr, 51>,

694

VersionedClause<OMPC_HasDeviceAddr, 51>,

711

VersionedClause<OMPC_HasDeviceAddr, 51>,

1145

VersionedClause<OMPC_HasDeviceAddr, 51>,

1176

VersionedClause<OMPC_HasDeviceAddr, 51>, and in other places

jyu2 updated this revision to Diff 421637.Apr 8 2022, 2:35 PM

Thanks Alexey, for the review! This patch addresses his comments.

jyu2 updated this revision to Diff 421639.Apr 8 2022, 2:39 PM

Add a test to Analysis/cfg-openmp.cpp

jyu2 updated this revision to Diff 421657.Apr 8 2022, 6:00 PM

Add test in cfg-openmp.cpp

This revision is now accepted and ready to land.Apr 8 2022, 6:57 PM
This revision was landed with ongoing or failed builds.Apr 8 2022, 9:32 PM
This revision was automatically updated to reflect the committed changes.