According to RISC-V Unprivileged ISA 15.6.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
From an initial look, I think this is almost ready to land - thank you.
One suggestion would be to review the various Subtarget.hasStdExtZfhmin() || Subtarget.hasStdExtZfh(). I'd first thought adding a new helper to RISCVSubtarget to be called instead, but actually it looks like a number of these could be replaced by just hasStdExtZfhmin due to Zfhmin implying Zfh.
llvm/lib/Target/RISCV/RISCVInstrInfoZfh.td | ||
---|---|---|
187 | Unintended change? |
llvm/lib/Target/RISCV/RISCVISelLowering.cpp | ||
---|---|---|
1157–1158 | This could equivalently just be if (VT == MVT::f16 && !Subtarget.hasStdExtZfhmin()), right? | |
1182 | This could just be !Subtarget.hasStdExtZfhmin()? | |
1194 | This could just be Subtarget.hasStdExtZfhmin()? | |
1401 | This could just be !Subtarget.hasStdExtZfhmin()? |
LGTM, modulo one tiny nit on a comment. Thanks!
llvm/lib/Target/RISCV/RISCVInstrInfoZfh.td | ||
---|---|---|
253 | HasStdExtZfh=>HasStdExtZfhmin |
This could equivalently just be if (VT == MVT::f16 && !Subtarget.hasStdExtZfhmin()), right?