Page MenuHomePhabricator

[IRBuilder] Add type argument to CreateMaskedLoad/Gather
ClosedPublic

Authored by nikic on Jul 3 2021, 6:17 AM.

Details

Reviewers
aartbik
ftynse
post.kadirselcuk
aeubanks
Group Reviewers
Restricted Project
Summary

Same as other CreateLoad-style functions, these need a type argument to support opaque pointers.

Given the minimal use of these APIs, I'm not going through the deprecation dance here.

Diff Detail

Event Timeline

nikic created this revision.Jul 3 2021, 6:17 AM
nikic requested review of this revision.Jul 3 2021, 6:17 AM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptJul 3 2021, 6:17 AM
nikic added inline comments.Jul 3 2021, 6:22 AM
mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
1519

Would be great if someone familiar with MLIR could look into removing the getPointerElementType() calls in this file.

This revision is now accepted and ready to land.Jul 3 2021, 7:41 AM
aeubanks accepted this revision.Jul 3 2021, 11:32 AM
This revision was landed with ongoing or failed builds.Jul 4 2021, 3:19 AM
This revision was automatically updated to reflect the committed changes.

Might use some testing? (guess there was previously missing testing, or this API change would've broken those tests)