Page MenuHomePhabricator

cota (Emilio Cota)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2017, 8:12 AM (248 w, 1 d)

Recent Activity

Mar 25 2022

cota committed rG0e1e3ccc989a: [bazel] add missing targets since 3be7c28917 (authored by cota).
[bazel] add missing targets since 3be7c28917
Mar 25 2022, 12:42 PM · Restricted Project

Mar 10 2022

cota committed rGb24de9f68452: [mlir] ExecutionEngine: default enableObjectCache to false (authored by cota).
[mlir] ExecutionEngine: default enableObjectCache to false
Mar 10 2022, 8:25 AM · Restricted Project
cota closed D121291: [mlir] ExecutionEngine: default enableObjectCache to false.
Mar 10 2022, 8:25 AM · Restricted Project, Restricted Project

Mar 9 2022

cota added a comment to D121291: [mlir] ExecutionEngine: default enableObjectCache to false.

Context: https://reviews.llvm.org/D120380

Mar 9 2022, 7:17 AM · Restricted Project, Restricted Project
cota requested review of D121291: [mlir] ExecutionEngine: default enableObjectCache to false.
Mar 9 2022, 7:15 AM · Restricted Project, Restricted Project

Feb 23 2022

cota committed rG011f653265e1: [mlir] Add sectionMemoryMapper to ExecutionEngineOptions (authored by cota).
[mlir] Add sectionMemoryMapper to ExecutionEngineOptions
Feb 23 2022, 11:57 AM
cota closed D120415: [mlir] Add sectionMemoryMapper to ExecutionEngineOptions.
Feb 23 2022, 11:57 AM · Restricted Project
cota updated the diff for D120415: [mlir] Add sectionMemoryMapper to ExecutionEngineOptions.

Capture options.sectionMemoryMapper by value instead of by reference

Feb 23 2022, 11:13 AM · Restricted Project
cota added a reviewer for D120415: [mlir] Add sectionMemoryMapper to ExecutionEngineOptions: ezhulenev.
Feb 23 2022, 10:35 AM · Restricted Project
cota added a reviewer for D120415: [mlir] Add sectionMemoryMapper to ExecutionEngineOptions: ftynse.
Feb 23 2022, 8:13 AM · Restricted Project
cota accepted D120075: [mlir] Async: update condition for dispatching block-aligned compute function.
Feb 23 2022, 8:10 AM · Restricted Project
cota requested review of D120415: [mlir] Add sectionMemoryMapper to ExecutionEngineOptions.
Feb 23 2022, 7:55 AM · Restricted Project
cota committed rGa7db3c611b1e: [mlir][NFC] Use options struct in ExecutionEngine::create (authored by cota).
[mlir][NFC] Use options struct in ExecutionEngine::create
Feb 23 2022, 7:33 AM
cota closed D120380: [mlir][NFC] Use options struct in ExecutionEngine::create.
Feb 23 2022, 7:33 AM · Restricted Project
cota added inline comments to D120380: [mlir][NFC] Use options struct in ExecutionEngine::create.
Feb 23 2022, 6:50 AM · Restricted Project

Feb 22 2022

cota added inline comments to D120380: [mlir][NFC] Use options struct in ExecutionEngine::create.
Feb 22 2022, 7:53 PM · Restricted Project
cota requested review of D120380: [mlir][NFC] Use options struct in ExecutionEngine::create.
Feb 22 2022, 7:35 PM · Restricted Project

Feb 17 2022

cota added inline comments to D119976: [mlir] Async: add alwaysinline/noinline attributes to parallel-for functions.
Feb 17 2022, 9:32 AM · Restricted Project

Feb 16 2022

cota accepted D119959: [mlir] Async: create async.group inside the scf.if branch.
Feb 16 2022, 2:44 PM · Restricted Project

Jan 13 2022

cota accepted D117162: [DebugInfo][InstrRef] Short-circuit unnecessary preferred location map construction.
Jan 13 2022, 2:58 AM · Restricted Project

Dec 6 2021

cota accepted D115152: [mlir] Improve async parallel for tests + fix typos.
Dec 6 2021, 11:37 AM · Restricted Project
cota added inline comments to D115152: [mlir] Improve async parallel for tests + fix typos.
Dec 6 2021, 7:49 AM · Restricted Project

Oct 28 2021

cota accepted D112764: [mlir] MathApproximations: scalars shape must be 0-rank.
Oct 28 2021, 6:22 PM · Restricted Project
cota added a comment to D112736: [mlir] MathApproximations: unroll virtual vectors into hardware vectors for ISA specific operation.
  1. I would just like Math dialect transforms to not depend on target-specific dialects. So concretely just RsqrtOpApproximation pattern would move to x86vector/Transform/, since it is the target specific one.
  2. I agree, removing Polynomial would be good.
Oct 28 2021, 3:54 PM · Restricted Project
cota abandoned D112729: [mlir] fix shape check in Rsqrt approximation.
Oct 28 2021, 12:51 PM · Restricted Project
cota added a comment to D112729: [mlir] fix shape check in Rsqrt approximation.

Included this fix in: https://reviews.llvm.org/D112736

Oct 28 2021, 12:51 PM · Restricted Project
cota accepted D112736: [mlir] MathApproximations: unroll virtual vectors into hardware vectors for ISA specific operation.

Thanks for this! Just some nits below, feel free to ignore.

Oct 28 2021, 12:20 PM · Restricted Project
cota requested review of D112729: [mlir] fix shape check in Rsqrt approximation.
Oct 28 2021, 8:53 AM · Restricted Project

Oct 22 2021

cota updated the diff for D112192: [mlir] Add polynomial approximation for vectorized math::Rsqrt.
  • Re-indented test/Dialect/Math/polynomial-approximation-avx2.mlir as suggested by pifon2a.
Oct 22 2021, 4:01 PM · Restricted Project

Oct 21 2021

cota added inline comments to D112192: [mlir] Add polynomial approximation for vectorized math::Rsqrt.
Oct 21 2021, 7:50 PM · Restricted Project
cota updated the diff for D112192: [mlir] Add polynomial approximation for vectorized math::Rsqrt.
  • Remove stray comments from a previous iteration
  • Rename flag from avx2 to enableAvx2/enable-avx2
  • Document the enableAvx2 bool in the Options struct
  • Use FileCheck --check-prefix; remove the now-redundant _avx2.mlir file
  • Fix coding style issues
Oct 21 2021, 7:49 PM · Restricted Project

Oct 20 2021

cota added reviewers for D112192: [mlir] Add polynomial approximation for vectorized math::Rsqrt: ftynse, ezhulenev.
Oct 20 2021, 4:20 PM · Restricted Project
cota updated the diff for D112192: [mlir] Add polynomial approximation for vectorized math::Rsqrt.

Add missing newline's at EOFs

Oct 20 2021, 4:19 PM · Restricted Project
cota requested review of D112192: [mlir] Add polynomial approximation for vectorized math::Rsqrt.
Oct 20 2021, 4:15 PM · Restricted Project

Oct 18 2021

cota accepted D112011: [mlir] Update approximation range for Tanh operation.
Oct 18 2021, 9:27 AM · Restricted Project

Oct 8 2021

cota abandoned D111455: X86Vector: remove rsqrt Integration test.
Oct 8 2021, 1:24 PM · Restricted Project
cota added a comment to D111455: X86Vector: remove rsqrt Integration test.

After discussing with Mehdi and Aart, I'm withdrawing this change in favor of https://reviews.llvm.org/D111461

Oct 8 2021, 1:24 PM · Restricted Project
cota updated the summary of D111461: X86Vector: relax checks in rsqrt's integration test.
Oct 8 2021, 1:18 PM · Restricted Project
cota updated the summary of D111461: X86Vector: relax checks in rsqrt's integration test.
Oct 8 2021, 1:17 PM · Restricted Project
cota requested review of D111461: X86Vector: relax checks in rsqrt's integration test.
Oct 8 2021, 1:14 PM · Restricted Project
cota requested review of D111455: X86Vector: remove rsqrt Integration test.
Oct 8 2021, 12:00 PM · Restricted Project

Oct 7 2021

cota accepted D111373: Fix test-rsqrt.mlir to accept AMD's approximation of rsqrt as well.
Oct 7 2021, 7:10 PM · Restricted Project

Oct 4 2021

chikitaisaac123 awarded rG0edc4bc84aa2: [mlir] Add polynomial approximation for math::ExpM1 a Pirate Logo token.
Oct 4 2021, 10:49 AM

Aug 11 2021

cota requested review of D107908: [mlir] BUILD.bazel: remove LLVMDialect from MathTransforms.
Aug 11 2021, 9:02 AM · Restricted Project
cota accepted D107896: [mlir] Make polynomial approximation emit std instead of LLVM ops.
Aug 11 2021, 7:17 AM · Restricted Project
cota accepted D107891: [mlir] Add std.bitcast -> llvm.bitcast conversion.
Aug 11 2021, 7:15 AM · Restricted Project
cota accepted D107889: [mlir] Tighten LLVM_AnyNonAggregate ODS type constraint.
Aug 11 2021, 7:13 AM · Restricted Project

Jun 29 2021

cota accepted D104977: [perf] Fix a data race in the PerfJITEventListener.
Jun 29 2021, 8:29 AM · Restricted Project

May 7 2021

cota added a comment to D102081: [mlir][docs] remove stale statement about index type in vectors.

Thanks Tobias for the quick reply. Can you please commit this change? I don't yet have commit access to the repo.

May 7 2021, 11:14 AM · Restricted Project
cota requested review of D102081: [mlir][docs] remove stale statement about index type in vectors.
May 7 2021, 9:38 AM · Restricted Project

May 5 2021

cota updated the diff for D101940: [mlir] Check generated IR of math_polynomial_approx.mlir.

Rebase onto HEAD

May 5 2021, 4:08 PM · Restricted Project
cota updated the diff for D101940: [mlir] Check generated IR of math_polynomial_approx.mlir.

Fix file header + trailing newline

May 5 2021, 1:22 PM · Restricted Project
cota added inline comments to D101852: [mlir] Add polynomial approximation for math::ExpM1.
May 5 2021, 1:17 PM · Restricted Project
cota requested review of D101940: [mlir] Check generated IR of math_polynomial_approx.mlir.
May 5 2021, 1:16 PM · Restricted Project

May 4 2021

cota updated the summary of D101852: [mlir] Add polynomial approximation for math::ExpM1.
May 4 2021, 1:18 PM · Restricted Project
cota requested review of D101852: [mlir] Add polynomial approximation for math::ExpM1.
May 4 2021, 1:17 PM · Restricted Project

May 3 2021

cota added a comment to D96776: [mlir] Add lowering from math.expm1 to LLVM..

Ping.
I just added log1p's approximation (https://reviews.llvm.org/D101765). I'd like this patch to go in so that I can also add expm1's approximation.

May 3 2021, 3:15 PM · Restricted Project
cota updated the diff for D101765: [mlir] Add polynomial approximation for math::Log1p.

mention inf in the comment

May 3 2021, 1:17 PM · Restricted Project
cota retitled D101765: [mlir] Add polynomial approximation for math::Log1p from BEGIN_PUBLIC [mlir] Add polynomial approximation for math::Log1p to [mlir] Add polynomial approximation for math::Log1p.
May 3 2021, 9:52 AM · Restricted Project
cota requested review of D101765: [mlir] Add polynomial approximation for math::Log1p.
May 3 2021, 9:51 AM · Restricted Project

Apr 13 2021

cota added a comment to D100344: [mlir] Use MCJIT to fix integration tests.

The ORC bug is closed, can you update all these tests back to use ORC?

Apr 13 2021, 1:15 PM · Restricted Project
cota requested review of D100407: [mlir] Use default lli JIT in Integration tests.
Apr 13 2021, 12:43 PM · Restricted Project

Apr 12 2021

cota added inline comments to D99818: [mlir] X86Vector: Add AVX Rsqrt.
Apr 12 2021, 6:51 PM · Restricted Project
cota updated the diff for D99818: [mlir] X86Vector: Add AVX Rsqrt.
Apr 12 2021, 6:51 PM · Restricted Project
cota added a comment to D100344: [mlir] Use MCJIT to fix integration tests.

Ideally the bug should be referred as TODO in all these tests, and also these tests should be mentioned in the bug so that when closing the bug we update the tests back.

Apr 12 2021, 6:01 PM · Restricted Project
cota updated the diff for D100344: [mlir] Use MCJIT to fix integration tests.

Add TODO comments that refer to the reported bug.

Apr 12 2021, 5:56 PM · Restricted Project
cota retitled D100344: [mlir] Use MCJIT to fix integration tests from [mlir] X86Vector: use MCJIT to fix integration tests to [mlir] Use MCJIT to fix integration tests.
Apr 12 2021, 3:11 PM · Restricted Project
cota added a comment to D100344: [mlir] Use MCJIT to fix integration tests.

aren't the AMX test affected by this as well then?

Apr 12 2021, 3:09 PM · Restricted Project
cota updated the diff for D100344: [mlir] Use MCJIT to fix integration tests.

Fix AMX tests as well

Apr 12 2021, 3:09 PM · Restricted Project
cota updated the diff for D99818: [mlir] X86Vector: Add AVX Rsqrt.

fix newline

Apr 12 2021, 2:39 PM · Restricted Project
cota retitled D99818: [mlir] X86Vector: Add AVX Rsqrt from [mlir] Add rsqrt to AVX512 dialect to [mlir] X86Vector: Add AVX Rsqrt .
Apr 12 2021, 2:33 PM · Restricted Project
cota updated the diff for D99818: [mlir] X86Vector: Add AVX Rsqrt.

Rebase on X86Vector

Apr 12 2021, 2:32 PM · Restricted Project
cota requested review of D100344: [mlir] Use MCJIT to fix integration tests.
Apr 12 2021, 2:24 PM · Restricted Project
cota added a comment to D100119: [mlir] Rename AVX512 dialect to X86Vector.

So far I only have immediate plans of adding avx.rsqrt to the dialect. I'd expect AVX, AVX512 and SSE ops to be added to this dialect in the future.

Apr 12 2021, 8:53 AM · Restricted Project, Restricted Project

Apr 9 2021

cota added inline comments to D100119: [mlir] Rename AVX512 dialect to X86Vector.
Apr 9 2021, 12:11 PM · Restricted Project, Restricted Project
cota updated the diff for D100119: [mlir] Rename AVX512 dialect to X86Vector.

Fix overly long comments

Apr 9 2021, 7:22 AM · Restricted Project, Restricted Project
cota added a comment to D100119: [mlir] Rename AVX512 dialect to X86Vector.

There isn't a commit summary at all. It'd be good to explain the rationale for the renaming.

Apr 9 2021, 7:01 AM · Restricted Project, Restricted Project
cota updated the summary of D100119: [mlir] Rename AVX512 dialect to X86Vector.
Apr 9 2021, 7:00 AM · Restricted Project, Restricted Project

Apr 8 2021

cota updated the diff for D100119: [mlir] Rename AVX512 dialect to X86Vector.

The previous push used a different diffbase than the original push,
which messed up the diff. Push a diff with the original diffbase now.

Apr 8 2021, 7:56 PM · Restricted Project, Restricted Project
cota retitled D100119: [mlir] Rename AVX512 dialect to X86Vector from [mlir] Add X86Vector dialect to supersede the AVX512 dialect to [mlir] Rename AVX512 dialect to X86Vector.
Apr 8 2021, 7:43 PM · Restricted Project, Restricted Project
cota updated the diff for D100119: [mlir] Rename AVX512 dialect to X86Vector.
  • [mlir] Rename AVX512 dialect to X86Vector
Apr 8 2021, 7:42 PM · Restricted Project, Restricted Project
cota added inline comments to D99818: [mlir] X86Vector: Add AVX Rsqrt.
Apr 8 2021, 8:55 AM · Restricted Project
cota added a comment to D100119: [mlir] Rename AVX512 dialect to X86Vector.

Context: https://reviews.llvm.org/D99818

Apr 8 2021, 8:52 AM · Restricted Project, Restricted Project
cota requested review of D100119: [mlir] Rename AVX512 dialect to X86Vector.
Apr 8 2021, 8:52 AM · Restricted Project, Restricted Project

Apr 6 2021

cota added inline comments to D99818: [mlir] X86Vector: Add AVX Rsqrt.
Apr 6 2021, 2:11 PM · Restricted Project
cota added inline comments to D99818: [mlir] X86Vector: Add AVX Rsqrt.
Apr 6 2021, 12:10 PM · Restricted Project
cota updated the diff for D99818: [mlir] X86Vector: Add AVX Rsqrt.

Address some reviewer comments

Apr 6 2021, 12:10 PM · Restricted Project

Apr 2 2021

cota updated subscribers of D99818: [mlir] X86Vector: Add AVX Rsqrt.
Apr 2 2021, 2:55 PM · Restricted Project
cota requested review of D99818: [mlir] X86Vector: Add AVX Rsqrt.
Apr 2 2021, 2:54 PM · Restricted Project

Mar 16 2021

cota accepted D98662: [mlir] Add lowering from math::Log1p to LLVM.
Mar 16 2021, 7:17 AM · Restricted Project

Mar 10 2021

cota updated cota.
Mar 10 2021, 10:19 AM
cota updated the diff for D98282: [mlir] Add polynomial approximation for math::Log2.
  • Fix typo in comment.
Mar 10 2021, 10:11 AM · Restricted Project
cota added inline comments to D98282: [mlir] Add polynomial approximation for math::Log2.
Mar 10 2021, 10:09 AM · Restricted Project
cota updated the diff for D98282: [mlir] Add polynomial approximation for math::Log2.
  • Test fixes as suggested by mehdi_amini.
  • Log base class as suggested by ezhulenev.
Mar 10 2021, 10:09 AM · Restricted Project

Mar 9 2021

cota added inline comments to D98282: [mlir] Add polynomial approximation for math::Log2.
Mar 9 2021, 2:08 PM · Restricted Project
cota updated the diff for D98282: [mlir] Add polynomial approximation for math::Log2.

s/LOG_OP/Op/

Mar 9 2021, 2:06 PM · Restricted Project
cota updated the summary of D98282: [mlir] Add polynomial approximation for math::Log2.
Mar 9 2021, 12:25 PM · Restricted Project
cota updated the diff for D98282: [mlir] Add polynomial approximation for math::Log2.

Update D98282: [mlir] Add polynomial approximation for math::Log2

Mar 9 2021, 12:24 PM · Restricted Project
cota requested review of D98282: [mlir] Add polynomial approximation for math::Log2.
Mar 9 2021, 12:18 PM · Restricted Project

Mar 9 2020

cota added a comment to D75820: tsan_interface.h: make constants static.

I have no commit access -- please merge it, thanks!

Mar 9 2020, 10:13 AM · Restricted Project, Restricted Project