Page MenuHomePhabricator

cota (Emilio Cota)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2017, 8:12 AM (293 w, 1 d)

Recent Activity

Tue, Mar 14

cota accepted D146072: [mlir][vector] Add bazel dependency to TestVector.
Tue, Mar 14, 11:31 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Mar 9

cota committed rG350d7e33ff09: [mlir][vector] remove unnecessary VectorTransformOps include (authored by cota).
[mlir][vector] remove unnecessary VectorTransformOps include
Thu, Mar 9, 3:24 PM · Restricted Project, Restricted Project
cota closed D145731: [mlir][vector] remove unnecessary VectorTransformOps include.
Thu, Mar 9, 3:24 PM · Restricted Project, Restricted Project
cota requested review of D145731: [mlir][vector] remove unnecessary VectorTransformOps include.
Thu, Mar 9, 2:09 PM · Restricted Project, Restricted Project

Mar 2 2023

cota accepted D145176: [mlir][sparse] convenience util to test for "sparse" op.

Thanks

Mar 2 2023, 12:14 PM · Restricted Project, Restricted Project

Dec 7 2022

cota committed rG72d76a240345: [mlir][bufferize] lower allocation alignment from 128 to 64 bytes (authored by cota).
[mlir][bufferize] lower allocation alignment from 128 to 64 bytes
Dec 7 2022, 8:16 AM · Restricted Project, Restricted Project
cota closed D139434: [mlir][bufferize] lower allocation alignment from 128 to 64 bytes.
Dec 7 2022, 8:16 AM · Restricted Project, Restricted Project

Dec 6 2022

cota updated the summary of D139434: [mlir][bufferize] lower allocation alignment from 128 to 64 bytes.
Dec 6 2022, 7:55 AM · Restricted Project, Restricted Project
cota requested review of D139434: [mlir][bufferize] lower allocation alignment from 128 to 64 bytes.
Dec 6 2022, 7:43 AM · Restricted Project, Restricted Project

Dec 5 2022

cota accepted D139383: [mlir][sparse] slience compiler warning on windows..
Dec 5 2022, 5:23 PM · Restricted Project, Restricted Project

Nov 7 2022

cota committed rG463da45892e2: [bazel][mlir] NVGPUToNVVM fixes for 708185f03ff (authored by cota).
[bazel][mlir] NVGPUToNVVM fixes for 708185f03ff
Nov 7 2022, 11:23 AM · Restricted Project

Nov 3 2022

cota committed rG7e133eb49b35: [mlir][bufferize] Add filterFn option to BufferResultsToOutParams (authored by cota).
[mlir][bufferize] Add filterFn option to BufferResultsToOutParams
Nov 3 2022, 10:09 AM · Restricted Project, Restricted Project
cota closed D137264: [mlir][bufferize] Add filterFn option to BufferResultsToOutParams.
Nov 3 2022, 10:09 AM · Restricted Project, Restricted Project
cota added a comment to D137264: [mlir][bufferize] Add filterFn option to BufferResultsToOutParams.

Resolve nits.

Nov 3 2022, 7:50 AM · Restricted Project, Restricted Project
cota updated the diff for D137264: [mlir][bufferize] Add filterFn option to BufferResultsToOutParams.

if (foo)

bar;
Nov 3 2022, 7:49 AM · Restricted Project, Restricted Project

Nov 2 2022

cota added a comment to D137264: [mlir][bufferize] Add filterFn option to BufferResultsToOutParams.

I also removed the tests as suggested by @springerm.

Nov 2 2022, 2:28 PM · Restricted Project, Restricted Project
cota retitled D137264: [mlir][bufferize] Add filterFn option to BufferResultsToOutParams from [mlir][bufferize] Add restrictToMarkedFunctions option to BufferResultsToOutParams to [mlir][bufferize] Add filterFn option to BufferResultsToOutParams.
Nov 2 2022, 2:26 PM · Restricted Project, Restricted Project
cota updated the diff for D137264: [mlir][bufferize] Add filterFn option to BufferResultsToOutParams.

Remove the marker; add filterFn lambda.

Nov 2 2022, 2:25 PM · Restricted Project, Restricted Project
cota added a comment to D137264: [mlir][bufferize] Add filterFn option to BufferResultsToOutParams.

+1 for the lambda.
Is it OK to keep the markers for testing only though? Otherwise I don't know how I'd test this.
Thanks!

Nov 2 2022, 10:02 AM · Restricted Project, Restricted Project
cota requested review of D137264: [mlir][bufferize] Add filterFn option to BufferResultsToOutParams.
Nov 2 2022, 9:05 AM · Restricted Project, Restricted Project

Oct 27 2022

cota committed rG764c7128c016: [mlir][spirv] fix Bazel build of Passes.h (authored by cota).
[mlir][spirv] fix Bazel build of Passes.h
Oct 27 2022, 6:51 PM · Restricted Project, Restricted Project
cota closed D136909: [mlir][spirv] fix Bazel build of Passes.h.
Oct 27 2022, 6:50 PM · Restricted Project, Restricted Project
cota requested review of D136909: [mlir][spirv] fix Bazel build of Passes.h.
Oct 27 2022, 6:43 PM · Restricted Project, Restricted Project
cota added a comment to D136519: bazel fix for TranslateLib.

We should later also fix the Utilities typo in the file name.

Oct 27 2022, 2:17 PM · Restricted Project, Restricted Project
cota committed rG17dbd80ff72c: [mlir] Fix typo s/utilties/utilities/ (including in file name) (authored by cota).
[mlir] Fix typo s/utilties/utilities/ (including in file name)
Oct 27 2022, 2:15 PM · Restricted Project, Restricted Project
cota closed D136887: [mlir] Fix typo s/utilties/utilities/ (including in file name).
Oct 27 2022, 2:15 PM · Restricted Project, Restricted Project
cota added a reviewer for D136887: [mlir] Fix typo s/utilties/utilities/ (including in file name): rriddle.
Oct 27 2022, 2:11 PM · Restricted Project, Restricted Project
cota requested review of D136887: [mlir] Fix typo s/utilties/utilities/ (including in file name).
Oct 27 2022, 2:10 PM · Restricted Project, Restricted Project
cota added a comment to D136875: [mlir] Rename `outs` to `inits` for linalg ops..

Can you please provide a rationale for the rename in the commit message? Or a link to a previous discussion on this topic. Thanks!

Oct 27 2022, 1:14 PM · Restricted Project, Restricted Project

Oct 26 2022

cota committed rG9fc345c5c743: [bazel][mlir][arith] build fixes for arith fastmath flags (authored by cota).
[bazel][mlir][arith] build fixes for arith fastmath flags
Oct 26 2022, 2:47 PM · Restricted Project

Oct 24 2022

cota accepted D136561: [mlir][Translation] Make commandline option registration optional.
Oct 24 2022, 10:48 AM · Restricted Project, Restricted Project
cota requested changes to D136561: [mlir][Translation] Make commandline option registration optional.
Oct 24 2022, 9:30 AM · Restricted Project, Restricted Project
cota added inline comments to D136561: [mlir][Translation] Make commandline option registration optional.
Oct 24 2022, 9:07 AM · Restricted Project, Restricted Project
cota accepted D136561: [mlir][Translation] Make commandline option registration optional.
Oct 24 2022, 9:05 AM · Restricted Project, Restricted Project

Oct 21 2022

cota added a comment to D136519: bazel fix for TranslateLib.

We should later also fix the Utilities typo in the file name.

Oct 21 2022, 8:07 PM · Restricted Project, Restricted Project
cota accepted D136519: bazel fix for TranslateLib.
Oct 21 2022, 8:05 PM · Restricted Project, Restricted Project

Oct 4 2022

cota accepted D135184: [mlir][sparse] fixed typo in fix of bazel fix.
Oct 4 2022, 11:14 AM · Restricted Project, Restricted Project
cota accepted D135183: [mlir][sparse] fix bazel breakage.
Oct 4 2022, 10:58 AM · Restricted Project, Restricted Project

Sep 28 2022

cota added a comment to D134762: [mlir][arith] Change dialect name from Arithmetic to Arith.

Based on internal feedback, I want to split this patch into a few more gradual changes:

  1. (This revision) Rename the dialect and paths, but add an alias for the old dialect name
  2. Remove the alias
  3. Rename passes/conversions (landed a few days later so that folks have time to catch up)

Does this work for other folks?

Sep 28 2022, 10:03 AM · Restricted Project, Restricted Project

Sep 27 2022

cota committed rG4db3a649ea79: [MLIR] Expose `getAsValues` in `StaticValueUtils.h` (NFC) [reland] (authored by chelini).
[MLIR] Expose `getAsValues` in `StaticValueUtils.h` (NFC) [reland]
Sep 27 2022, 8:20 AM · Restricted Project, Restricted Project
cota closed D134451: [MLIR] Expose `getAsValues` in `StaticValueUtils.h` (NFC).
Sep 27 2022, 8:20 AM · Restricted Project, Restricted Project
cota added a comment to D134451: [MLIR] Expose `getAsValues` in `StaticValueUtils.h` (NFC).

@rengolin: AFAIK we do not want dependency cycles in the build system (Cmake or otherwise). I wrongly thought I was reporting one such case.

Sep 27 2022, 7:29 AM · Restricted Project, Restricted Project
cota accepted D134451: [MLIR] Expose `getAsValues` in `StaticValueUtils.h` (NFC).

@akuegel is right, my apologies. I wrongly assumed that in Cmake, ArithDialect depends on DialectUtils, just like it (unnecessarily) does in Bazel. I confirm that removing that superfluous dependence fixes the cycle in Bazel.

Sep 27 2022, 7:26 AM · Restricted Project, Restricted Project

Sep 26 2022

cota added a comment to D134451: [MLIR] Expose `getAsValues` in `StaticValueUtils.h` (NFC).

This change introduces a circular build dependence: DialectUtils <- ArithmeticUtils <- ArithDialect <- DialectUtils.

Sep 26 2022, 12:32 PM · Restricted Project, Restricted Project

Sep 20 2022

cota accepted D134301: [MLIR] Update bazel build files after 242d558658cd5a480b02883e2982d7246342e0d0.
Sep 20 2022, 12:19 PM · Restricted Project, Restricted Project

Sep 9 2022

cota committed rGd8094d32ed32: [mlir] NFC: ConvertAsyncToLLVM: sort deps alphabetically (authored by cota).
[mlir] NFC: ConvertAsyncToLLVM: sort deps alphabetically
Sep 9 2022, 12:00 PM · Restricted Project, Restricted Project

Sep 8 2022

cota committed rGe413eb6cf877: [mlir] ConvertAsyncToLLVM: add missing dependence on async dialect (authored by cota).
[mlir] ConvertAsyncToLLVM: add missing dependence on async dialect
Sep 8 2022, 1:18 PM · Restricted Project, Restricted Project
cota closed D133516: [mlir] ConvertAsyncToLLVM: add missing dependence on async dialect.
Sep 8 2022, 1:18 PM · Restricted Project, Restricted Project
cota updated the diff for D133516: [mlir] ConvertAsyncToLLVM: add missing dependence on async dialect.

Rebase on current HEAD to hopefully avoid unrelated BUILD failures.

Sep 8 2022, 12:40 PM · Restricted Project, Restricted Project
cota requested review of D133516: [mlir] ConvertAsyncToLLVM: add missing dependence on async dialect.
Sep 8 2022, 12:16 PM · Restricted Project, Restricted Project

Aug 12 2022

cota accepted D131798: [MLIR] Add utility function to create values for all dimensions of a tensor value.
Aug 12 2022, 11:38 AM · Restricted Project, Restricted Project

Mar 25 2022

cota committed rG0e1e3ccc989a: [bazel] add missing targets since 3be7c28917 (authored by cota).
[bazel] add missing targets since 3be7c28917
Mar 25 2022, 12:42 PM · Restricted Project

Mar 10 2022

cota committed rGb24de9f68452: [mlir] ExecutionEngine: default enableObjectCache to false (authored by cota).
[mlir] ExecutionEngine: default enableObjectCache to false
Mar 10 2022, 8:25 AM · Restricted Project
cota closed D121291: [mlir] ExecutionEngine: default enableObjectCache to false.
Mar 10 2022, 8:25 AM · Restricted Project, Restricted Project

Mar 9 2022

cota added a comment to D121291: [mlir] ExecutionEngine: default enableObjectCache to false.

Context: https://reviews.llvm.org/D120380

Mar 9 2022, 7:17 AM · Restricted Project, Restricted Project
cota requested review of D121291: [mlir] ExecutionEngine: default enableObjectCache to false.
Mar 9 2022, 7:15 AM · Restricted Project, Restricted Project

Feb 23 2022

cota committed rG011f653265e1: [mlir] Add sectionMemoryMapper to ExecutionEngineOptions (authored by cota).
[mlir] Add sectionMemoryMapper to ExecutionEngineOptions
Feb 23 2022, 11:57 AM
cota closed D120415: [mlir] Add sectionMemoryMapper to ExecutionEngineOptions.
Feb 23 2022, 11:57 AM · Restricted Project
cota updated the diff for D120415: [mlir] Add sectionMemoryMapper to ExecutionEngineOptions.

Capture options.sectionMemoryMapper by value instead of by reference

Feb 23 2022, 11:13 AM · Restricted Project
cota added a reviewer for D120415: [mlir] Add sectionMemoryMapper to ExecutionEngineOptions: ezhulenev.
Feb 23 2022, 10:35 AM · Restricted Project
cota added a reviewer for D120415: [mlir] Add sectionMemoryMapper to ExecutionEngineOptions: ftynse.
Feb 23 2022, 8:13 AM · Restricted Project
cota accepted D120075: [mlir] Async: update condition for dispatching block-aligned compute function.
Feb 23 2022, 8:10 AM · Restricted Project
cota requested review of D120415: [mlir] Add sectionMemoryMapper to ExecutionEngineOptions.
Feb 23 2022, 7:55 AM · Restricted Project
cota committed rGa7db3c611b1e: [mlir][NFC] Use options struct in ExecutionEngine::create (authored by cota).
[mlir][NFC] Use options struct in ExecutionEngine::create
Feb 23 2022, 7:33 AM
cota closed D120380: [mlir][NFC] Use options struct in ExecutionEngine::create.
Feb 23 2022, 7:33 AM · Restricted Project
cota added inline comments to D120380: [mlir][NFC] Use options struct in ExecutionEngine::create.
Feb 23 2022, 6:50 AM · Restricted Project

Feb 22 2022

cota added inline comments to D120380: [mlir][NFC] Use options struct in ExecutionEngine::create.
Feb 22 2022, 7:53 PM · Restricted Project
cota requested review of D120380: [mlir][NFC] Use options struct in ExecutionEngine::create.
Feb 22 2022, 7:35 PM · Restricted Project

Feb 17 2022

cota added inline comments to D119976: [mlir] Async: add alwaysinline/noinline attributes to parallel-for functions.
Feb 17 2022, 9:32 AM · Restricted Project

Feb 16 2022

cota accepted D119959: [mlir] Async: create async.group inside the scf.if branch.
Feb 16 2022, 2:44 PM · Restricted Project

Jan 13 2022

cota accepted D117162: [DebugInfo][InstrRef] Short-circuit unnecessary preferred location map construction.
Jan 13 2022, 2:58 AM · Restricted Project

Dec 6 2021

cota accepted D115152: [mlir] Improve async parallel for tests + fix typos.
Dec 6 2021, 11:37 AM · Restricted Project
cota added inline comments to D115152: [mlir] Improve async parallel for tests + fix typos.
Dec 6 2021, 7:49 AM · Restricted Project

Oct 28 2021

cota accepted D112764: [mlir] MathApproximations: scalars shape must be 0-rank.
Oct 28 2021, 6:22 PM · Restricted Project
cota added a comment to D112736: [mlir] MathApproximations: unroll virtual vectors into hardware vectors for ISA specific operation.
  1. I would just like Math dialect transforms to not depend on target-specific dialects. So concretely just RsqrtOpApproximation pattern would move to x86vector/Transform/, since it is the target specific one.
  2. I agree, removing Polynomial would be good.
Oct 28 2021, 3:54 PM · Restricted Project
cota abandoned D112729: [mlir] fix shape check in Rsqrt approximation.
Oct 28 2021, 12:51 PM · Restricted Project
cota added a comment to D112729: [mlir] fix shape check in Rsqrt approximation.

Included this fix in: https://reviews.llvm.org/D112736

Oct 28 2021, 12:51 PM · Restricted Project
cota accepted D112736: [mlir] MathApproximations: unroll virtual vectors into hardware vectors for ISA specific operation.

Thanks for this! Just some nits below, feel free to ignore.

Oct 28 2021, 12:20 PM · Restricted Project
cota requested review of D112729: [mlir] fix shape check in Rsqrt approximation.
Oct 28 2021, 8:53 AM · Restricted Project

Oct 22 2021

cota updated the diff for D112192: [mlir] Add polynomial approximation for vectorized math::Rsqrt.
  • Re-indented test/Dialect/Math/polynomial-approximation-avx2.mlir as suggested by pifon2a.
Oct 22 2021, 4:01 PM · Restricted Project

Oct 21 2021

cota added inline comments to D112192: [mlir] Add polynomial approximation for vectorized math::Rsqrt.
Oct 21 2021, 7:50 PM · Restricted Project
cota updated the diff for D112192: [mlir] Add polynomial approximation for vectorized math::Rsqrt.
  • Remove stray comments from a previous iteration
  • Rename flag from avx2 to enableAvx2/enable-avx2
  • Document the enableAvx2 bool in the Options struct
  • Use FileCheck --check-prefix; remove the now-redundant _avx2.mlir file
  • Fix coding style issues
Oct 21 2021, 7:49 PM · Restricted Project

Oct 20 2021

cota added reviewers for D112192: [mlir] Add polynomial approximation for vectorized math::Rsqrt: ftynse, ezhulenev.
Oct 20 2021, 4:20 PM · Restricted Project
cota updated the diff for D112192: [mlir] Add polynomial approximation for vectorized math::Rsqrt.

Add missing newline's at EOFs

Oct 20 2021, 4:19 PM · Restricted Project
cota requested review of D112192: [mlir] Add polynomial approximation for vectorized math::Rsqrt.
Oct 20 2021, 4:15 PM · Restricted Project

Oct 18 2021

cota accepted D112011: [mlir] Update approximation range for Tanh operation.
Oct 18 2021, 9:27 AM · Restricted Project

Oct 8 2021

cota abandoned D111455: X86Vector: remove rsqrt Integration test.
Oct 8 2021, 1:24 PM · Restricted Project
cota added a comment to D111455: X86Vector: remove rsqrt Integration test.

After discussing with Mehdi and Aart, I'm withdrawing this change in favor of https://reviews.llvm.org/D111461

Oct 8 2021, 1:24 PM · Restricted Project
cota updated the summary of D111461: X86Vector: relax checks in rsqrt's integration test.
Oct 8 2021, 1:18 PM · Restricted Project
cota updated the summary of D111461: X86Vector: relax checks in rsqrt's integration test.
Oct 8 2021, 1:17 PM · Restricted Project
cota requested review of D111461: X86Vector: relax checks in rsqrt's integration test.
Oct 8 2021, 1:14 PM · Restricted Project
cota requested review of D111455: X86Vector: remove rsqrt Integration test.
Oct 8 2021, 12:00 PM · Restricted Project

Oct 7 2021

cota accepted D111373: Fix test-rsqrt.mlir to accept AMD's approximation of rsqrt as well.
Oct 7 2021, 7:10 PM · Restricted Project

Oct 4 2021

chikitaisaac123 awarded rG0edc4bc84aa2: [mlir] Add polynomial approximation for math::ExpM1 a Pirate Logo token.
Oct 4 2021, 10:49 AM

Aug 11 2021

cota requested review of D107908: [mlir] BUILD.bazel: remove LLVMDialect from MathTransforms.
Aug 11 2021, 9:02 AM · Restricted Project
cota accepted D107896: [mlir] Make polynomial approximation emit std instead of LLVM ops.
Aug 11 2021, 7:17 AM · Restricted Project
cota accepted D107891: [mlir] Add std.bitcast -> llvm.bitcast conversion.
Aug 11 2021, 7:15 AM · Restricted Project
cota accepted D107889: [mlir] Tighten LLVM_AnyNonAggregate ODS type constraint.
Aug 11 2021, 7:13 AM · Restricted Project

Jun 29 2021

cota accepted D104977: [perf] Fix a data race in the PerfJITEventListener.
Jun 29 2021, 8:29 AM · Restricted Project

May 7 2021

cota added a comment to D102081: [mlir][docs] remove stale statement about index type in vectors.

Thanks Tobias for the quick reply. Can you please commit this change? I don't yet have commit access to the repo.

May 7 2021, 11:14 AM · Restricted Project