User Details
- User Since
- Aug 18 2017, 8:12 AM (293 w, 1 d)
Tue, Mar 14
Thu, Mar 9
Mar 2 2023
Thanks
Dec 7 2022
Dec 6 2022
Dec 5 2022
Nov 7 2022
Nov 3 2022
Resolve nits.
if (foo)
bar;
Nov 2 2022
I also removed the tests as suggested by @springerm.
Remove the marker; add filterFn lambda.
+1 for the lambda.
Is it OK to keep the markers for testing only though? Otherwise I don't know how I'd test this.
Thanks!
Oct 27 2022
Can you please provide a rationale for the rename in the commit message? Or a link to a previous discussion on this topic. Thanks!
Oct 26 2022
Oct 24 2022
Oct 21 2022
We should later also fix the Utilities typo in the file name.
Oct 4 2022
Sep 28 2022
Sep 27 2022
@rengolin: AFAIK we do not want dependency cycles in the build system (Cmake or otherwise). I wrongly thought I was reporting one such case.
@akuegel is right, my apologies. I wrongly assumed that in Cmake, ArithDialect depends on DialectUtils, just like it (unnecessarily) does in Bazel. I confirm that removing that superfluous dependence fixes the cycle in Bazel.
Sep 26 2022
This change introduces a circular build dependence: DialectUtils <- ArithmeticUtils <- ArithDialect <- DialectUtils.
Sep 20 2022
Sep 9 2022
Sep 8 2022
Rebase on current HEAD to hopefully avoid unrelated BUILD failures.
Aug 12 2022
Mar 25 2022
Mar 10 2022
Mar 9 2022
Context: https://reviews.llvm.org/D120380
Feb 23 2022
Capture options.sectionMemoryMapper by value instead of by reference
Feb 22 2022
Feb 17 2022
Feb 16 2022
Jan 13 2022
Dec 6 2021
Oct 28 2021
Thanks for this! Just some nits below, feel free to ignore.
Oct 22 2021
- Re-indented test/Dialect/Math/polynomial-approximation-avx2.mlir as suggested by pifon2a.
Oct 21 2021
- Remove stray comments from a previous iteration
- Rename flag from avx2 to enableAvx2/enable-avx2
- Document the enableAvx2 bool in the Options struct
- Use FileCheck --check-prefix; remove the now-redundant _avx2.mlir file
- Fix coding style issues
Oct 20 2021
Add missing newline's at EOFs
Oct 18 2021
Oct 8 2021
After discussing with Mehdi and Aart, I'm withdrawing this change in favor of https://reviews.llvm.org/D111461
Oct 7 2021
Oct 4 2021
Aug 11 2021
Jun 29 2021
May 7 2021
Thanks Tobias for the quick reply. Can you please commit this change? I don't yet have commit access to the repo.