Page MenuHomePhabricator

[RISCV] "V" Extention coming with "F" "D" "Zfh" Extentions
AbandonedPublic

Authored by luke957 on Mar 29 2021, 2:38 AM.

Details

Summary

If a target has StdExtF, it also has StdExtF, StdExtD and StdExtZfh?
When running command "./build/bin/opt -loop-vectorize -dce -instcombine -mtriple riscv64-linux-gnu -mattr=+experimental-v -debug-only=loop-vectorize -S llvm/test/Transforms/LoopVectorize/RISCV/basic-vec.ll", an "UNREACHABLE executed" error was received.
Missing "+f" in "-mattr" is the reason of "UNREACHABLE executed" error.

Diff Detail

Unit TestsFailed

TimeTest
25,210 msx64 debian > LLVM.Bindings/Go::go.test
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/llvm-go go=/usr/bin/go test llvm.org/llvm/bindings/go/llvm

Event Timeline

luke957 created this revision.Mar 29 2021, 2:38 AM
luke957 requested review of this revision.Mar 29 2021, 2:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2021, 2:38 AM
Jim added inline comments.Mar 29 2021, 3:28 AM
llvm/lib/Target/RISCV/RISCVISelLowering.cpp
139

It is incorrect. Only Zfh imply F enabled and D imply F enabled.

luke957 retitled this revision from [RISCV] "V" Extention coming with "F" "D" "Zfh" to [RISCV] "V" Extention coming with "F" "D" "Zfh" Extentions.Mar 29 2021, 3:44 AM
luke957 edited the summary of this revision. (Show Details)
luke957 added a reviewer: craig.topper.

There is no such implication in the V specification. See https://github.com/riscv/riscv-v-spec/issues/608.

There is no such implication in the V specification. See https://github.com/riscv/riscv-v-spec/issues/608.

Get it. Thanks.

luke957 added inline comments.Mar 30 2021, 3:36 AM
llvm/lib/Target/RISCV/RISCVISelLowering.cpp
139

Yeah, I should find another way to solve the crash problem.

luke957 abandoned this revision.Tue, Apr 13, 7:59 PM