This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Support bitcasts of fixed-length mask vectors
ClosedPublic

Authored by frasercrmck on Mar 17 2021, 6:03 AM.

Details

Summary

Without this patch, bitcasts of fixed-length mask vectors would go
through the stack.

Diff Detail

Event Timeline

frasercrmck created this revision.Mar 17 2021, 6:03 AM
frasercrmck requested review of this revision.Mar 17 2021, 6:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 17 2021, 6:03 AM
craig.topper accepted this revision.Mar 17 2021, 10:33 AM

LGTM

Is this based on real IR you saw? Such a cast would be pretty terrible on X86 so I hope it doesn't come up often.

This revision is now accepted and ready to land.Mar 17 2021, 10:33 AM

LGTM

Is this based on real IR you saw? Such a cast would be pretty terrible on X86 so I hope it doesn't come up often.

Cheers. Nah, luckily it came up while optimizing mask build_vectors.

This revision was landed with ongoing or failed builds.Mar 18 2021, 1:59 AM
This revision was automatically updated to reflect the committed changes.