This is an archive of the discontinued LLVM Phabricator instance.

Differential D73865

[CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition
AbandonedPublic

Authored by MaskRay on Feb 3 2020, 12:12 AM.

Details

Reviewers
peter.smith
rnk
serge-sans-paille
sfertile
jfb
jdoerfert
Commits
rG789a46f2d742: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition
Summary

Clang -fpic defaults to -fno-semantic-interposition (GCC -fpic defaults
to -fsemantic-interposition).
Users need to specify -fsemantic-interposition to get semantic
interposition behavior.

Semantic interposition is currently a best-effort feature. There may
still be some cases where it is not handled well.

Diff Detail

Unit TestsFailed

TimeTest
50 msClang.CXX/modules-ts::Unknown Unit Message ("")
50 msClang.CXX/modules-ts/basic/basic_link::Unknown Unit Message ("")
350 msClang.CodeGen::Unknown Unit Message ("")
80 msClang.CodeGen::Unknown Unit Message ("")
90 msClang.CodeGen::Unknown Unit Message ("")
View Full Test Results (121 Failed)

Event Timeline

MaskRay created this revision.Feb 3 2020, 12:12 AM
Herald added a reviewer: jfb. · View Herald TranscriptFeb 3 2020, 12:12 AM
Herald added a reviewer: jdoerfert. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: cfe-commits, luismarques, apazos and 30 others. · View Herald Transcript
merge_guards_bot added a subscriber: merge_guards_bot.Feb 3 2020, 12:30 AM

Unit tests: fail. 62284 tests passed, 121 failed and 839 were skipped.

failed: Clang.CXX/modules-ts/basic/basic_link/p3.cppm
failed: Clang.CXX/modules-ts/codegen-basics.cppm
failed: Clang.CodeGen/arm-aapcs-vfp.c
failed: Clang.CodeGen/attr-cpuspecific.c
failed: Clang.CodeGen/attr-target-mv-func-ptrs.c
failed: Clang.CodeGen/attr-target-mv-va-args.c
failed: Clang.CodeGenCUDA/address-spaces.cu
failed: Clang.CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu
failed: Clang.CodeGenCUDA/amdgpu-kernel-attrs.cu
failed: Clang.CodeGenCUDA/amdgpu-visibility.cu
failed: Clang.CodeGenCUDA/convergent.cu
failed: Clang.CodeGenCUDA/cuda-builtin-vars.cu
failed: Clang.CodeGenCUDA/device-stub.cu
failed: Clang.CodeGenCUDA/device-var-init.cu
failed: Clang.CodeGenCUDA/device-vtable.cu
failed: Clang.CodeGenCUDA/function-overload.cu
failed: Clang.CodeGenCUDA/kernel-amdgcn.cu
failed: Clang.CodeGenCUDA/kernel-args.cu
failed: Clang.CodeGenCUDA/library-builtin.cu
failed: Clang.CodeGenCUDA/link-device-bitcode.cu
failed: Clang.CodeGenCUDA/nothrow.cu
failed: Clang.CodeGenCUDA/propagate-metadata.cu
failed: Clang.CodeGenCUDA/ptx-kernels.cu
failed: Clang.CodeGenCUDA/types.cu
failed: Clang.CodeGenCUDA/usual-deallocators.cu
failed: Clang.CodeGenCXX/attr-exclude_from_explicit_instantiation.dont_assume_extern_instantiation.cpp
failed: Clang.CodeGenCXX/attr-target-mv-diff-ns.cpp
failed: Clang.CodeGenCXX/attr-target-mv-member-funcs.cpp
failed: Clang.CodeGenCXX/attr-target-mv-out-of-line-defs.cpp
failed: Clang.CodeGenCXX/attr-target-mv-overloads.cpp
failed: Clang.CodeGenCXX/attr.cpp
failed: Clang.CodeGenCXX/builtin-source-location.cpp
failed: Clang.CodeGenCXX/conditional-temporaries.cpp
failed: Clang.CodeGenCXX/const-init-cxx2a.cpp
failed: Clang.CodeGenCXX/ctor-dtor-alias.cpp
failed: Clang.CodeGenCXX/cxx0x-initializer-stdinitializerlist-pr12086.cpp
failed: Clang.CodeGenCXX/cxx0x-initializer-stdinitializerlist-startend.cpp
failed: Clang.CodeGenCXX/cxx0x-initializer-stdinitializerlist.cpp
failed: Clang.CodeGenCXX/cxx11-extern-constexpr.cpp
failed: Clang.CodeGenCXX/cxx11-initializer-aggregate.cpp
failed: Clang.CodeGenCXX/cxx11-thread-local-reference.cpp
failed: Clang.CodeGenCXX/cxx11-thread-local-visibility.cpp
failed: Clang.CodeGenCXX/cxx1y-variable-template-linkage.cpp
failed: Clang.CodeGenCXX/cxx1z-inline-variables.cpp
failed: Clang.CodeGenCXX/explicit-instantiation.cpp
failed: Clang.CodeGenCXX/inheriting-constructor.cpp
failed: Clang.CodeGenCXX/member-function-pointers.cpp
failed: Clang.CodeGenCXX/microsoft-uuidof.cpp
failed: Clang.CodeGenCXX/no-odr-use.cpp
failed: Clang.CodeGenCXX/pragma-visibility.cpp
failed: Clang.CodeGenCXX/regcall.cpp
failed: Clang.CodeGenCXX/static-data-member.cpp
failed: Clang.CodeGenCXX/static-init.cpp
failed: Clang.CodeGenCXX/static-member-variable-explicit-specialization.cpp
failed: Clang.CodeGenCXX/visibility-inlines-hidden-staticvar.cpp
failed: Clang.CodeGenCXX/vtable-linkage.cpp
failed: Clang.CodeGenCXX/x86_64-arguments.cpp
failed: Clang.CodeGenCoroutines/coro-await-resume-eh.cpp
failed: Clang.CodeGenCoroutines/coro-await.cpp
failed: Clang.CodeGenCoroutines/coro-cleanup.cpp
failed: Clang.CodeGenCoroutines/coro-gro-nrvo.cpp
failed: Clang.CodeGenCoroutines/coro-params.cpp
failed: Clang.CodeGenCoroutines/coro-ret-void.cpp
failed: Clang.CodeGenObjC/assign.m
failed: Clang.CodeGenObjC/constant-strings.m
failed: Clang.CodeGenObjC/gnu-exceptions.m
failed: Clang.CodeGenObjC/gnustep2-proto.m
failed: Clang.CodeGenObjC/objfw.m
failed: Clang.CodeGenObjC/property.m
failed: Clang.CodeGenObjC/stret_lookup.m
failed: Clang.CodeGenObjCXX/designated-initializers.mm
failed: Clang.CodeGenObjCXX/objfw-exceptions.mm
failed: Clang.CodeGenOpenCL/addr-space-struct-arg.cl
failed: Clang.CodeGenOpenCL/address-spaces-conversions.cl
failed: Clang.CodeGenOpenCL/amdgcn-automatic-variable.cl
failed: Clang.CodeGenOpenCL/amdgcn-large-globals.cl
failed: Clang.CodeGenOpenCL/amdgpu-abi-struct-coerce.cl
failed: Clang.CodeGenOpenCL/amdgpu-attrs.cl
failed: Clang.CodeGenOpenCL/amdgpu-call-kernel.cl
failed: Clang.CodeGenOpenCL/amdgpu-calling-conv.cl
failed: Clang.CodeGenOpenCL/amdgpu-enqueue-kernel.cl
failed: Clang.CodeGenOpenCL/amdgpu-nullptr.cl
failed: Clang.CodeGenOpenCL/as_type.cl
failed: Clang.CodeGenOpenCL/bool_cast.cl
failed: Clang.CodeGenOpenCL/cl20-device-side-enqueue.cl
failed: Clang.CodeGenOpenCL/constant-addr-space-globals.cl
failed: Clang.CodeGenOpenCL/convergent.cl
failed: Clang.CodeGenOpenCL/extension-begin.cl
failed: Clang.CodeGenOpenCL/kernel-arg-info.cl
failed: Clang.CodeGenOpenCL/kernels-have-spir-cc-by-default.cl
failed: Clang.CodeGenOpenCL/partial_initializer.cl
failed: Clang.CodeGenOpenCL/pipe_types.cl
failed: Clang.CodeGenOpenCL/ptx-calls.cl
failed: Clang.CodeGenOpenCL/ptx-kernels.cl
failed: Clang.CodeGenOpenCL/sampler.cl
failed: Clang.CodeGenOpenCL/shifts.cl
failed: Clang.CodeGenOpenCL/spir-calling-conv.cl
failed: Clang.CodeGenOpenCL/vectorLoadStore.cl
failed: Clang.CodeGenOpenCL/visibility.cl
failed: Clang.CodeGenOpenCL/vla.cl
failed: Clang.CodeGenOpenCLCXX/address-space-deduction.cl
failed: Clang.CodeGenOpenCLCXX/addrspace-derived-base.cl
failed: Clang.CodeGenOpenCLCXX/addrspace-operators.cl
failed: Clang.CodeGenOpenCLCXX/addrspace-references.cl
failed: Clang.CodeGenOpenCLCXX/addrspace-with-class.cl
failed: Clang.CodeGenOpenCLCXX/constexpr.cl
failed: Clang.Modules/codegen-flags.test
failed: Clang.Modules/codegen-opt.test
failed: Clang.Modules/codegen.test
failed: Clang.Modules/initializers.cpp
failed: Clang.Modules/templates-2.mm
failed: Clang.Modules/templates.mm
failed: Clang.OpenMP/allocate_codegen.cpp
failed: Clang.OpenMP/declare_variant_mixed_codegen.c
failed: Clang.OpenMP/parallel_codegen.cpp
failed: Clang.OpenMP/parallel_master_codegen.cpp
failed: Clang.OpenMP/simd_metadata.c
failed: Clang.OpenMP/threadprivate_codegen.cpp
failed: Clang.PCH/codegen.cpp
failed: Clang.Parser/pragma-visibility2.c
failed: Clang.Profile/cxx-abc-deleting-dtor.cpp

clang-tidy: pass.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

Herald added subscribers: • wuzish, dexonsmith. · View Herald TranscriptFeb 3 2020, 12:30 AM
Harbormaster failed remote builds in B45552: Diff 241977!Feb 3 2020, 12:35 AM
peter.smith added a comment.Feb 3 2020, 4:12 AM

If I've understood correctly this would make LLVM more aggressive for PIC relocation models, but perhaps more honest in an inter procedural optimisation context? The code changes look fine to me, I'm wondering if we've discussed this widely enough with the community to work out how to proceed here. For example do we have plan to test -fno-semantic-interposition well enough for it to be relied on. The consensus may already exist, and I don't know enough about it though.

clang/lib/CodeGen/CodeGenModule.cpp
845

I think that this comment needs updating to explain the effect of SemanticInterposition, and maybe the clang default.

clang/test/CodeGen/aapcs-align.cpp
21

I initially thought a triple of arm-none-none-eabi (bare-metal for embedded systems) would have a relocation model of static and hence should have already been dso_local. Thinking about it in more detail the clang-driver will usually pass the relocation model to cc1 so by default the driver is assuming PIC. May be worth pointing that out in your description.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2020, 10:02 AM
Closed by commit rG789a46f2d742: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition (authored by MaskRay). · Explain Why
This revision was automatically updated to reflect the committed changes.
MaskRay reopened this revision.EditedFeb 3 2020, 10:12 AM

Accidentally committed. Sorry..

serge-sans-paille added inline comments.Feb 10 2020, 11:40 AM
clang/lib/CodeGen/CodeGenModule.cpp
871

in clang/lib/Driver/ToolChains/Clang.cpp we have

if (Args.hasFlag(options::OPT_fsemantic_interposition,
                 options::OPT_fno_semantic_interposition, false) &&
    RelocationModel != llvm::Reloc::Static && !IsPIE)
  CmdArgs.push_back("-fsemantic-interposition");

reading that diff makes me wonder if that's the right place to put that test?

Herald added a subscriber: miyuki. · View Herald TranscriptFeb 10 2020, 11:40 AM
rnk added a comment.Feb 10 2020, 1:46 PM

What is the motivation for adding a best effort -fsemantic-interposition? Was there anything wrong with our previously unstated project policy of ignoring this complexity and surviving without this mode? Less modes -> less conditional soup...

clang/lib/CodeGen/CodeGenModule.cpp
852

We now come here for shared objects in most cases: most definitions are assumed to be dso_local and most declarations are assumed to be in another DSO. Please update the comment.

MaskRay mentioned this in D72197: [MC][ELF] Emit a relocation if target is defined in the same section and is non-local.Feb 11 2020, 9:51 AM
MaskRay planned changes to this revision.EditedFeb 15 2020, 4:00 PM

What is the motivation for adding a best effort -fsemantic-interposition?

I don't need it, and I hope we can avoid this configuration, but I guess @serge-sans-paille may need it.

The semantic interposition status is complex. We have probably 3 cases:

  • Current status: -fno-semantic-interposition, but dso_local is not inferred
  • What I want to do: -fno-semantic-interposition, and dso_local is inferred
  • -fsemantic-interposition: best effort. (I hope we can avoid it.)

I am thinking whether we may need fine-grained -fno-semantic-interposition-{data,function}. I've noticed one problem with an internal target _multiarray_umath.so npy_ma_str_array_finalize. I need to make more investigation, but there is a chance that we can default to -fno-semantic-interposition-function but not -fno-semantic-interposition-data.

There is an issue that should be fixed in LTO. dso_local needs to be removed for a split LTO unit. Inferring dso_local when -fPIC -fno-semantic-interposition can cause problem to -fsanitize=cfi -fsanitize-cfi-cross-dso -fsplit-lto-unit. For my own note, absl/base:sysinfo_test can cause error: relocation R_X86_64_PC32 cannot be used against symbol vtable for BaseArena; recompile with -fPIC.

At least, before the LTO issue is fixed, we cannot assume dso_local for -fno-semantic-position (even if specified explicitly).

MaskRay mentioned this in D74751: [ThinLTO] Drop dso_local if a GlobalVariable satisfies isDeclarationForLinker().Feb 21 2020, 3:32 PM
MaskRay mentioned this in rGd2ef8c1f2ca3: [ThinLTO] Drop dso_local if a GlobalVariable satisfies isDeclarationForLinker().Apr 7 2020, 3:50 PM
MaskRay abandoned this revision.Aug 10 2020, 2:55 PM

Landed with a change that only changes the explicit -fno-semantic-interposition behavior, so there was very little test change.

Herald added subscribers: aaron.ballman, sstefan1. · View Herald TranscriptAug 10 2020, 2:55 PM

Large Diff

This large diff affects 459 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
clang/
lib/
CodeGen/
4 lines
test/
CXX/
expr/
4 lines
CodeGen/
4 lines
6 lines
6 lines
100 lines
2 lines
14 lines
10 lines
20 lines
48 lines
4 lines
160 lines
88 lines
24 lines
48 lines
42 lines
48 lines
48 lines
540 lines
48 lines
84 lines
144 lines
28 lines
56 lines
62 lines
96 lines
2 lines
50 lines
8 lines
14 lines
30 lines
4 lines
2 lines
2 lines
12 lines
12 lines
arc/
44 lines
4 lines
2 lines
6 lines
76 lines
24 lines
2 lines
30 lines
16 lines
8 lines
8 lines
32 lines
2 lines
36 lines
36 lines
30 lines
6 lines
26 lines
2 lines
2 lines
4 lines
10 lines
2 lines
52 lines
4 lines
4 lines
8 lines
32 lines
30 lines
avr/
attributes/
2 lines
2 lines
16 lines
6 lines
10 lines
2 lines
4 lines
12 lines
4 lines
12 lines
8 lines
2 lines
36 lines
30 lines
58 lines
2 lines
10 lines
2 lines
2 lines
4 lines
2 lines
14 lines
2 lines
4 lines
4 lines
4 lines
4 lines
4 lines
2 lines
2 lines
2 lines
2 lines
4 lines
2 lines
32 lines
2 lines
16 lines
4 lines
2 lines
2 lines
4 lines
10 lines
2 lines
4 lines
44 lines
4 lines
16 lines
2 lines
16 lines
6 lines
6 lines
10 lines
2 lines
16 lines
2 lines
4 lines
2 lines
30 lines
8 lines
6 lines
12 lines
8 lines
4 lines
16 lines
14 lines
58 lines
22 lines
18 lines
2 lines
6 lines
14 lines
2 lines
2 lines
6 lines
4 lines
14 lines
6 lines
66 lines
16 lines
2 lines
12 lines
4 lines
8 lines
4 lines
18 lines
2 lines
16 lines
8 lines
6 lines
6 lines
4 lines
8 lines
10 lines
6 lines
8 lines
4 lines
22 lines
2 lines
2 lines
54 lines
40 lines
4 lines
16 lines
6 lines
2 lines
26 lines
32 lines
32 lines
2 lines
4 lines
8 lines
2 lines
12 lines
6 lines
44 lines
4 lines
2 lines
14 lines
90 lines
24 lines
8 lines
4 lines
2 lines
2 lines
4 lines
2 lines
60 lines
2 lines
10 lines
8 lines
8 lines
76 lines
106 lines
14 lines
96 lines
4 lines
4 lines
68 lines
96 lines
92 lines
6 lines
2 lines
6 lines
6 lines
2 lines
30 lines
2 lines
2 lines
4 lines
30 lines
20 lines
180 lines
106 lines
2 lines
36 lines
10 lines
24 lines
10 lines
4 lines
2 lines
4 lines
4 lines
2 lines
6 lines
12 lines
2 lines
18 lines
18 lines
8 lines
12 lines
20 lines
4 lines
16 lines
32 lines
2 lines
4 lines
26 lines
92 lines
14 lines
54 lines
6 lines
4 lines
6 lines
8 lines
4 lines
4 lines
2 lines
4 lines
4 lines
2 lines
4 lines
6 lines
68 lines
CodeGenCXX/
2 lines
2 lines
2 lines
6 lines
14 lines
12 lines
8 lines
2 lines
8 lines
12 lines
6 lines
10 lines
2 lines
2 lines
12 lines
4 lines
4 lines
88 lines
2 lines
4 lines
18 lines
48 lines
6 lines
12 lines
4 lines
24 lines
4 lines
12 lines
36 lines
6 lines
8 lines
2 lines
2 lines
14 lines
2 lines
62 lines
6 lines
2 lines
2 lines
12 lines
8 lines
8 lines
36 lines
10 lines
8 lines
6 lines
2 lines
12 lines
2 lines
6 lines
8 lines
8 lines
14 lines
2 lines
20 lines
10 lines
32 lines
4 lines
8 lines
4 lines
34 lines
8 lines
2 lines
6 lines
6 lines
36 lines
2 lines
36 lines
30 lines
2 lines
4 lines
2 lines
28 lines
6 lines
2 lines
44 lines
2 lines
28 lines
10 lines
4 lines
8 lines
2 lines
4 lines
2 lines
28 lines
12 lines
36 lines
10 lines
24 lines
12 lines
2 lines
4 lines
24 lines
18 lines
28 lines
2 lines
8 lines
22 lines
26 lines
2 lines
36 lines
12 lines
2 lines
2 lines
6 lines
2 lines
22 lines
10 lines
6 lines
14 lines
6 lines
2 lines
24 lines
2 lines
12 lines
2 lines
4 lines
12 lines
2 lines
2 lines
8 lines
4 lines
2 lines
30 lines
4 lines
4 lines
6 lines
44 lines
2 lines
10 lines
38 lines
8 lines
2 lines
2 lines
4 lines
8 lines
8 lines
16 lines
14 lines
CodeGenCoroutines/
2 lines
4 lines
4 lines
2 lines
2 lines
4 lines
4 lines
Modules/
2 lines
16 lines
2 lines
OpenMP/
10 lines
2 lines
2 lines
6 lines
2 lines
2 lines
4 lines
4 lines
2 lines
4 lines
12 lines
2 lines
2 lines
34 lines
8 lines
2 lines
8 lines
36 lines
2 lines
2 lines
2 lines
2 lines
36 lines
36 lines
36 lines
36 lines
36 lines
36 lines
12 lines
12 lines
2 lines
36 lines
12 lines
2 lines
12 lines
36 lines
12 lines
12 lines
12 lines
12 lines
12 lines
12 lines
12 lines
12 lines
12 lines
12 lines
2 lines
16 lines
PCH/
2 lines
SemaCXX/
2 lines
2 lines

Diff 241977

clang/lib/CodeGen/CodeGenModule.cpp

Show First 20 Lines • Show All 836 Lines • ▼ Show 20 Linesstatic bool shouldAssumeDSOLocal(const CodeGenModule &CGM,
// FIXME: even thread local variables? // FIXME: even thread local variables?
if (TT.isOSBinFormatCOFF() || (TT.isOSWindows() && TT.isOSBinFormatMachO())) if (TT.isOSBinFormatCOFF() || (TT.isOSWindows() && TT.isOSBinFormatMachO()))
return true; return true;
// Only handle COFF and ELF for now. // Only handle COFF and ELF for now.
if (!TT.isOSBinFormatELF()) if (!TT.isOSBinFormatELF())
return false; return false;
// If this is not an executable, don't assume anything is local. // If this is not an executable, don't assume anything is local.
peter.smithUnsubmitted
Not Done
ReplyInline Actions

I think that this comment needs updating to explain the effect of SemanticInterposition, and maybe the clang default.

peter.smith: I think that this comment needs updating to explain the effect of SemanticInterposition, and…
const auto &CGOpts = CGM.getCodeGenOpts(); const auto &CGOpts = CGM.getCodeGenOpts();
llvm::Reloc::Model RM = CGOpts.RelocationModel; llvm::Reloc::Model RM = CGOpts.RelocationModel;
const auto &LOpts = CGM.getLangOpts(); const auto &LOpts = CGM.getLangOpts();
if (RM != llvm::Reloc::Static && !LOpts.PIE) if (RM != llvm::Reloc::Static && LOpts.SemanticInterposition)
return false; return false;
// A definition cannot be preempted from an executable. // A definition cannot be preempted from an executable.
rnkUnsubmitted
Not Done
ReplyInline Actions

We now come here for shared objects in most cases: most definitions are assumed to be dso_local and most declarations are assumed to be in another DSO. Please update the comment.

rnk: We now come here for shared objects in most cases: most definitions are assumed to be dso_local…
if (!GV->isDeclarationForLinker()) if (!GV->isDeclarationForLinker())
return true; return true;
// Most PIC code sequences that assume that a symbol is local cannot produce a // Most PIC code sequences that assume that a symbol is local cannot produce a
// 0 if it turns out the symbol is undefined. While this is ABI and relocation // 0 if it turns out the symbol is undefined. While this is ABI and relocation
// depended, it seems worth it to handle it here. // depended, it seems worth it to handle it here.
if (RM == llvm::Reloc::PIC_ && GV->hasExternalWeakLinkage()) if (RM == llvm::Reloc::PIC_ && GV->hasExternalWeakLinkage())
return false; return false;
// PPC has no copy relocations and cannot use a plt entry as a symbol address. // PPC has no copy relocations and cannot use a plt entry as a symbol address.
llvm::Triple::ArchType Arch = TT.getArch(); llvm::Triple::ArchType Arch = TT.getArch();
if (Arch == llvm::Triple::ppc || Arch == llvm::Triple::ppc64 || if (Arch == llvm::Triple::ppc || Arch == llvm::Triple::ppc64 ||
Arch == llvm::Triple::ppc64le) Arch == llvm::Triple::ppc64le)
return false; return false;
// If we can use copy relocations we can assume it is local. // If we can use copy relocations we can assume it is local.
if (auto *Var = dyn_cast<llvm::GlobalVariable>(GV)) if (auto *Var = dyn_cast<llvm::GlobalVariable>(GV))
if (!Var->isThreadLocal() && if (!Var->isThreadLocal() &&
(RM == llvm::Reloc::Static || CGOpts.PIECopyRelocations)) (RM == llvm::Reloc::Static || (LOpts.PIE && CGOpts.PIECopyRelocations)))
serge-sans-pailleUnsubmitted
Not Done
ReplyInline Actions

in clang/lib/Driver/ToolChains/Clang.cpp we have

if (Args.hasFlag(options::OPT_fsemantic_interposition,
                 options::OPT_fno_semantic_interposition, false) &&
    RelocationModel != llvm::Reloc::Static && !IsPIE)
  CmdArgs.push_back("-fsemantic-interposition");

reading that diff makes me wonder if that's the right place to put that test?

serge-sans-paille: in `clang/lib/Driver/ToolChains/Clang.cpp` we have ``` if (Args.hasFlag(options…
return true; return true;
// If we can use a plt entry as the symbol address we can assume it // If we can use a plt entry as the symbol address we can assume it
// is local. // is local.
// FIXME: This should work for PIE, but the gold linker doesn't support it. // FIXME: This should work for PIE, but the gold linker doesn't support it.
if (isa<llvm::Function>(GV) && !CGOpts.NoPLT && RM == llvm::Reloc::Static) if (isa<llvm::Function>(GV) && !CGOpts.NoPLT && RM == llvm::Reloc::Static)
return true; return true;
▲ Show 20 Lines • Show All 5,057 Lines • Show Last 20 Lines

clang/test/CXX/expr/p10-0x.cpp

clang/test/CodeGen/2006-05-19-SingleEltReturn.c

clang/test/CodeGen/2008-07-30-implicit-initialization.c

clang/test/CodeGen/2008-07-31-promotion-of-compound-pointer-arithmetic.c

clang/test/CodeGen/3dnow-builtins.c

clang/test/CodeGen/_Bool-conversion.c

clang/test/CodeGen/aapcs-align.cpp

Show All 12 Lines
void f0(int, S); void f0(int, S);
void f0m(int, int, int, int, int, S); void f0m(int, int, int, int, int, S);
void g0() { void g0() {
S s = {6, 7}; S s = {6, 7};
f0(1, s); f0(1, s);
f0m(1, 2, 3, 4, 5, s); f0m(1, 2, 3, 4, 5, s);
} }
// CHECK: define void @g0 // CHECK: define dso_local void @g0
peter.smithUnsubmitted
Not Done
ReplyInline Actions

I initially thought a triple of arm-none-none-eabi (bare-metal for embedded systems) would have a relocation model of static and hence should have already been dso_local. Thinking about it in more detail the clang-driver will usually pass the relocation model to cc1 so by default the driver is assuming PIC. May be worth pointing that out in your description.

peter.smith: I initially thought a triple of arm-none-none-eabi (bare-metal for embedded systems) would have…
// CHECK: call void @f0(i32 1, [2 x i32] [i32 6, i32 7] // CHECK: call void @f0(i32 1, [2 x i32] [i32 6, i32 7]
// CHECK: call void @f0m(i32 1, i32 2, i32 3, i32 4, i32 5, [2 x i32] [i32 6, i32 7] // CHECK: call void @f0m(i32 1, i32 2, i32 3, i32 4, i32 5, [2 x i32] [i32 6, i32 7]
// CHECK: declare void @f0(i32, [2 x i32]) // CHECK: declare void @f0(i32, [2 x i32])
// CHECK: declare void @f0m(i32, i32, i32, i32, i32, [2 x i32]) // CHECK: declare void @f0m(i32, i32, i32, i32, i32, [2 x i32])
// Aligned struct, passed according to its natural alignment. // Aligned struct, passed according to its natural alignment.
struct __attribute__((aligned(8))) S8 { struct __attribute__((aligned(8))) S8 {
int x, y; int x, y;
} s8; } s8;
void f1(int, S8); void f1(int, S8);
void f1m(int, int, int, int, int, S8); void f1m(int, int, int, int, int, S8);
void g1() { void g1() {
S8 s = {6, 7}; S8 s = {6, 7};
f1(1, s); f1(1, s);
f1m(1, 2, 3, 4, 5, s); f1m(1, 2, 3, 4, 5, s);
} }
// CHECK: define void @g1 // CHECK: define dso_local void @g1
// CHECK: call void @f1(i32 1, [2 x i32] [i32 6, i32 7] // CHECK: call void @f1(i32 1, [2 x i32] [i32 6, i32 7]
// CHECK: call void @f1m(i32 1, i32 2, i32 3, i32 4, i32 5, [2 x i32] [i32 6, i32 7] // CHECK: call void @f1m(i32 1, i32 2, i32 3, i32 4, i32 5, [2 x i32] [i32 6, i32 7]
// CHECK: declare void @f1(i32, [2 x i32]) // CHECK: declare void @f1(i32, [2 x i32])
// CHECK: declare void @f1m(i32, i32, i32, i32, i32, [2 x i32]) // CHECK: declare void @f1m(i32, i32, i32, i32, i32, [2 x i32])
// Aligned struct, passed according to its natural alignment. // Aligned struct, passed according to its natural alignment.
struct alignas(16) S16 { struct alignas(16) S16 {
int x, y; int x, y;
}; };
extern "C" void f2(int, S16); extern "C" void f2(int, S16);
extern "C" void f2m(int, int, int, int, int, S16); extern "C" void f2m(int, int, int, int, int, S16);
void g2() { void g2() {
S16 s = {6, 7}; S16 s = {6, 7};
f2(1, s); f2(1, s);
f2m(1, 2, 3, 4, 5, s); f2m(1, 2, 3, 4, 5, s);
} }
// CHECK: define void @g2 // CHECK: define dso_local void @g2
// CHECK: call void @f2(i32 1, [4 x i32] [i32 6, i32 7 // CHECK: call void @f2(i32 1, [4 x i32] [i32 6, i32 7
// CHECK: call void @f2m(i32 1, i32 2, i32 3, i32 4, i32 5, [4 x i32] [i32 6, i32 7 // CHECK: call void @f2m(i32 1, i32 2, i32 3, i32 4, i32 5, [4 x i32] [i32 6, i32 7
// CHECK: declare void @f2(i32, [4 x i32]) // CHECK: declare void @f2(i32, [4 x i32])
// CHECK: declare void @f2m(i32, i32, i32, i32, i32, [4 x i32]) // CHECK: declare void @f2m(i32, i32, i32, i32, i32, [4 x i32])
// Increased natural alignment. // Increased natural alignment.
struct SF8 { struct SF8 {
int x __attribute__((aligned(8))); int x __attribute__((aligned(8)));
int y; int y;
}; };
void f3(int, SF8); void f3(int, SF8);
void f3m(int, int, int, int, int, SF8); void f3m(int, int, int, int, int, SF8);
void g3() { void g3() {
SF8 s = {6, 7}; SF8 s = {6, 7};
f3(1, s); f3(1, s);
f3m(1, 2, 3, 4, 5, s); f3m(1, 2, 3, 4, 5, s);
} }
// CHECK: define void @g3 // CHECK: define dso_local void @g3
// CHECK: call void @f3(i32 1, [1 x i64] [i64 30064771078] // CHECK: call void @f3(i32 1, [1 x i64] [i64 30064771078]
// CHECK: call void @f3m(i32 1, i32 2, i32 3, i32 4, i32 5, [1 x i64] [i64 30064771078] // CHECK: call void @f3m(i32 1, i32 2, i32 3, i32 4, i32 5, [1 x i64] [i64 30064771078]
// CHECK: declare void @f3(i32, [1 x i64]) // CHECK: declare void @f3(i32, [1 x i64])
// CHECK: declare void @f3m(i32, i32, i32, i32, i32, [1 x i64]) // CHECK: declare void @f3m(i32, i32, i32, i32, i32, [1 x i64])
// Increased natural alignment, capped to 8 though. // Increased natural alignment, capped to 8 though.
struct SF16 { struct SF16 {
int x; int x;
int y alignas(16); int y alignas(16);
int z, a, b, c, d, e, f, g, h, i, j, k; int z, a, b, c, d, e, f, g, h, i, j, k;
}; };
void f4(int, SF16); void f4(int, SF16);
void f4m(int, int, int, int, int, SF16); void f4m(int, int, int, int, int, SF16);
void g4() { void g4() {
SF16 s = {6, 7}; SF16 s = {6, 7};
f4(1, s); f4(1, s);
f4m(1, 2, 3, 4, 5, s); f4m(1, 2, 3, 4, 5, s);
} }
// CHECK: define void @g4 // CHECK: define dso_local void @g4
// CHECK: call void @f4(i32 1, %struct.SF16* nonnull byval(%struct.SF16) align 8 // CHECK: call void @f4(i32 1, %struct.SF16* nonnull byval(%struct.SF16) align 8
// CHECK: call void @f4m(i32 1, i32 2, i32 3, i32 4, i32 5, %struct.SF16* nonnull byval(%struct.SF16) align 8 // CHECK: call void @f4m(i32 1, i32 2, i32 3, i32 4, i32 5, %struct.SF16* nonnull byval(%struct.SF16) align 8
// CHECK: declare void @f4(i32, %struct.SF16* byval(%struct.SF16) align 8) // CHECK: declare void @f4(i32, %struct.SF16* byval(%struct.SF16) align 8)
// CHECK: declare void @f4m(i32, i32, i32, i32, i32, %struct.SF16* byval(%struct.SF16) align 8) // CHECK: declare void @f4m(i32, i32, i32, i32, i32, %struct.SF16* byval(%struct.SF16) align 8)
// Packed structure. // Packed structure.
struct __attribute__((packed)) P { struct __attribute__((packed)) P {
int x; int x;
long long u; long long u;
}; };
void f5(int, P); void f5(int, P);
void f5m(int, int, int, int, int, P); void f5m(int, int, int, int, int, P);
void g5() { void g5() {
P s = {6, 7}; P s = {6, 7};
f5(1, s); f5(1, s);
f5m(1, 2, 3, 4, 5, s); f5m(1, 2, 3, 4, 5, s);
} }
// CHECK: define void @g5 // CHECK: define dso_local void @g5
// CHECK: call void @f5(i32 1, [3 x i32] [i32 6, i32 7, i32 0]) // CHECK: call void @f5(i32 1, [3 x i32] [i32 6, i32 7, i32 0])
// CHECK: call void @f5m(i32 1, i32 2, i32 3, i32 4, i32 5, [3 x i32] [i32 6, i32 7, i32 0]) // CHECK: call void @f5m(i32 1, i32 2, i32 3, i32 4, i32 5, [3 x i32] [i32 6, i32 7, i32 0])
// CHECK: declare void @f5(i32, [3 x i32]) // CHECK: declare void @f5(i32, [3 x i32])
// CHECK: declare void @f5m(i32, i32, i32, i32, i32, [3 x i32]) // CHECK: declare void @f5m(i32, i32, i32, i32, i32, [3 x i32])
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-
Lint: Pre-merge checks: clang-format: please reformat the code ``` - ```
// Packed and aligned, alignement causes padding at the end. // Packed and aligned, alignement causes padding at the end.
struct __attribute__((packed, aligned(8))) P8 { struct __attribute__((packed, aligned(8))) P8 {
int x; int x;
long long u; long long u;
}; };
void f6(int, P8); void f6(int, P8);
void f6m(int, int, int, int, int, P8); void f6m(int, int, int, int, int, P8);
void g6() { void g6() {
P8 s = {6, 7}; P8 s = {6, 7};
f6(1, s); f6(1, s);
f6m(1, 2, 3, 4, 5, s); f6m(1, 2, 3, 4, 5, s);
} }
// CHECK: define void @g6 // CHECK: define dso_local void @g6
// CHECK: call void @f6(i32 1, [4 x i32] [i32 6, i32 7, i32 0, i32 0]) // CHECK: call void @f6(i32 1, [4 x i32] [i32 6, i32 7, i32 0, i32 0])
// CHECK: call void @f6m(i32 1, i32 2, i32 3, i32 4, i32 5, [4 x i32] [i32 6, i32 7, i32 0, i32 0]) // CHECK: call void @f6m(i32 1, i32 2, i32 3, i32 4, i32 5, [4 x i32] [i32 6, i32 7, i32 0, i32 0])
// CHECK: declare void @f6(i32, [4 x i32]) // CHECK: declare void @f6(i32, [4 x i32])
// CHECK: declare void @f6m(i32, i32, i32, i32, i32, [4 x i32]) // CHECK: declare void @f6m(i32, i32, i32, i32, i32, [4 x i32])
} }

clang/test/CodeGen/aapcs64-align.cpp

clang/test/CodeGen/aarch64-args.cpp

clang/test/CodeGen/aarch64-branch-protection-attr.c

clang/test/CodeGen/aarch64-byval-temp.c

clang/test/CodeGen/aarch64-neon-3v.c

clang/test/CodeGen/aarch64-neon-across.c

clang/test/CodeGen/aarch64-neon-dot-product.c

clang/test/CodeGen/aarch64-neon-extract.c

clang/test/CodeGen/aarch64-neon-fcvt-intrinsics.c

clang/test/CodeGen/aarch64-neon-fma.c

clang/test/CodeGen/aarch64-neon-fp16fml.c

clang/test/CodeGen/aarch64-neon-ldst-one.c

clang/test/CodeGen/aarch64-neon-scalar-copy.c

clang/test/CodeGen/aarch64-neon-scalar-x-indexed-elem.c

clang/test/CodeGen/aarch64-neon-tbl.c

clang/test/CodeGen/aarch64-neon-vcombine.c

clang/test/CodeGen/aarch64-neon-vget-hilo.c

clang/test/CodeGen/aarch64-poly128.c

clang/test/CodeGen/aarch64-poly64.c

clang/test/CodeGen/aarch64-tme.cpp

clang/test/CodeGen/aarch64-varargs.c

clang/test/CodeGen/aarch64-vpcs.c

clang/test/CodeGen/address-space.c

clang/test/CodeGen/alias.c

clang/test/CodeGen/align-systemz.c

clang/test/CodeGen/align_value.cpp

clang/test/CodeGen/alignment.c

clang/test/CodeGen/alloc-align-attr.c

clang/test/CodeGen/altivec.c

clang/test/CodeGen/arc/arguments.c

clang/test/CodeGen/arc/struct-align.c

clang/test/CodeGen/arm-aapcs-vfp.c

clang/test/CodeGen/arm-cc.c

clang/test/CodeGen/arm-float-helpers.c

clang/test/CodeGen/arm-fp16-arguments.c

clang/test/CodeGen/arm-homogenous.c

clang/test/CodeGen/arm-neon-directed-rounding.c

clang/test/CodeGen/arm-neon-dot-product.c

clang/test/CodeGen/arm-neon-fma.c

clang/test/CodeGen/arm-neon-numeric-maxmin.c

clang/test/CodeGen/arm-neon-vcvtX.c

clang/test/CodeGen/arm-pcs.c

clang/test/CodeGen/arm-varargs.c

clang/test/CodeGen/arm-vfp16-arguments.c

clang/test/CodeGen/arm-vfp16-arguments2.cpp

clang/test/CodeGen/arm64-aapcs-arguments.c

clang/test/CodeGen/arm64-mte.c

clang/test/CodeGen/arm_function_epilog.cpp

clang/test/CodeGen/asm-label.c

clang/test/CodeGen/assign.c

clang/test/CodeGen/atomics-inlining.c

clang/test/CodeGen/attr-msp430.c

clang/test/CodeGen/attr-target-mv.c

clang/test/CodeGen/attr-weakref.c

clang/test/CodeGen/attr-weakref2.c

clang/test/CodeGen/attr-x86-interrupt.c

clang/test/CodeGen/attributes.c

clang/test/CodeGen/avr-builtins.c

clang/test/CodeGen/avr/attributes/interrupt.c

clang/test/CodeGen/avr/attributes/signal.c

clang/test/CodeGen/bitfield-2.c

clang/test/CodeGen/blocks.c

clang/test/CodeGen/bool-convert.c

clang/test/CodeGen/bool-init.c

clang/test/CodeGen/bool_test.c

clang/test/CodeGen/builtin-align.c

clang/test/CodeGen/builtin-constant-p.c

clang/test/CodeGen/builtin-expect.c

clang/test/CodeGen/builtin-ms-noop.cpp

clang/test/CodeGen/builtin-unpredictable.c

clang/test/CodeGen/builtins-arm.c

clang/test/CodeGen/builtins-ppc-altivec.c

clang/test/CodeGen/builtins-ppc-crypto.c

clang/test/CodeGen/builtins-ppc-htm.c

clang/test/CodeGen/builtins-ppc-p7.c

clang/test/CodeGen/builtins-ppc-p8vector.c

clang/test/CodeGen/builtins-ppc-quadword.c

clang/test/CodeGen/builtins-ppc-vsx.c

clang/test/CodeGen/builtins-ppc.c

clang/test/CodeGen/c11atomics.c

clang/test/CodeGen/catch-alignment-assumption-attribute-align_value-on-lvalue.cpp

clang/test/CodeGen/catch-alignment-assumption-attribute-align_value-on-paramvar.cpp

clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp

clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function.cpp

clang/test/CodeGen/catch-alignment-assumption-attribute-assume_aligned-on-function-two-params.cpp

clang/test/CodeGen/catch-alignment-assumption-attribute-assume_aligned-on-function.cpp

clang/test/CodeGen/catch-alignment-assumption-builtin_assume_aligned-three-params-variable.cpp

clang/test/CodeGen/catch-alignment-assumption-builtin_assume_aligned-three-params.cpp

clang/test/CodeGen/catch-alignment-assumption-builtin_assume_aligned-two-params.cpp

clang/test/CodeGen/catch-alignment-assumption-openmp.cpp

clang/test/CodeGen/catch-nullptr-and-nonzero-offset-in-offsetof-idiom.c

clang/test/CodeGen/catch-nullptr-and-nonzero-offset-when-nullptr-is-defined.c

clang/test/CodeGen/catch-nullptr-and-nonzero-offset.c

clang/test/CodeGen/catch-pointer-overflow-volatile.c

clang/test/CodeGen/catch-pointer-overflow.c

clang/test/CodeGen/cfi-icall-canonical-jump-tables.c

clang/test/CodeGen/cfi-icall-cross-dso2.c

clang/test/CodeGen/cfi-icall-generalize.c

clang/test/CodeGen/cfstring-elf-cfbuild-x86_64.c

clang/test/CodeGen/clang-sections-attribute.c

clang/test/CodeGen/cleanup-destslot-simple.c

clang/test/CodeGen/const-arithmetic.c

clang/test/CodeGen/const-init.c

clang/test/CodeGen/decl-in-prototype.c

clang/test/CodeGen/default-address-space.c

clang/test/CodeGen/default-function-attr.c

clang/test/CodeGen/designated-initializers.c

clang/test/CodeGen/dllexport-1.c

clang/test/CodeGen/dso-local-executable.c

clang/test/CodeGen/enable_if.c

clang/test/CodeGen/exceptions.c

clang/test/CodeGen/exprs.c

clang/test/CodeGen/flatten.c

clang/test/CodeGen/flexible-array-init.c

clang/test/CodeGen/fp16-ops.c

clang/test/CodeGen/function-attributes.c

clang/test/CodeGen/functions.c

clang/test/CodeGen/global-decls.c

clang/test/CodeGen/global-init.c

clang/test/CodeGen/iamcu-abi.c

clang/test/CodeGen/ifunc.c

clang/test/CodeGen/init-memset.c

clang/test/CodeGen/init.c

clang/test/CodeGen/inline.c

clang/test/CodeGen/lanai-arguments.c

clang/test/CodeGen/le32-arguments.c

clang/test/CodeGen/le32-libcall-pow.c

clang/test/CodeGen/le32-vaarg.c

clang/test/CodeGen/libcalls.c

clang/test/CodeGen/lifetime-debuginfo-1.c

clang/test/CodeGen/lifetime-debuginfo-2.c

clang/test/CodeGen/link-bitcode-file.c

clang/test/CodeGen/long-call-attr.c

clang/test/CodeGen/long_double_fp128.cpp

clang/test/CodeGen/malign-double-x86-nacl.c

clang/test/CodeGen/malign-double.cpp

clang/test/CodeGen/mangle-windows.c

clang/test/CodeGen/mbackchain.c

clang/test/CodeGen/mcu-struct-return.c

clang/test/CodeGen/micromips-attr.c

clang/test/CodeGen/microsoft-call-conv.c

clang/test/CodeGen/mips-byval-arg.c

clang/test/CodeGen/mips-interrupt-attr.c

clang/test/CodeGen/mips-transparent-union.c

clang/test/CodeGen/mips-varargs.c

clang/test/CodeGen/mips-vector-arg.c

clang/test/CodeGen/mips-vector-return.c

clang/test/CodeGen/mips-zero-sized-struct.c

clang/test/CodeGen/mips16-attr.c

clang/test/CodeGen/mips64-class-return.cpp

clang/test/CodeGen/mips64-padding-arg.c

clang/test/CodeGen/mrtd.c

clang/test/CodeGen/ms_abi.c

clang/test/CodeGen/ms_abi_aarch64.c

clang/test/CodeGen/no-builtin.cpp

clang/test/CodeGen/noduplicate-cxx11-test.cpp

clang/test/CodeGen/nvptx-abi.c

clang/test/CodeGen/packed-arrays.c

clang/test/CodeGen/packed-structure.c

clang/test/CodeGen/partial-reinitialization1.c

clang/test/CodeGen/patchable-function-entry.c

clang/test/CodeGen/powerpc_types.c

clang/test/CodeGen/ppc-signbit.c

clang/test/CodeGen/ppc64-align-struct.c

clang/test/CodeGen/ppc64-complex-parms.c

clang/test/CodeGen/ppc64-complex-return.c

clang/test/CodeGen/ppc64-dwarf.c

clang/test/CodeGen/ppc64-elf-abi.c

clang/test/CodeGen/ppc64-extend.c

clang/test/CodeGen/ppc64-inline-asm.c

clang/test/CodeGen/ppc64-long-double.cpp

clang/test/CodeGen/ppc64-qpx-vector.c

clang/test/CodeGen/ppc64-soft-float.c

clang/test/CodeGen/ppc64-struct-onefloat.c

clang/test/CodeGen/ppc64-struct-onevect.c

clang/test/CodeGen/ppc64-vector.c

clang/test/CodeGen/ppc64le-aggregates.c

clang/test/CodeGen/ppc64le-f128Aggregates.c

clang/test/CodeGen/pr25786.c

clang/test/CodeGen/pr34021.c

clang/test/CodeGen/pr9614.c

clang/test/CodeGen/pragma-weak.c

clang/test/CodeGen/prefetchw-builtins.c

clang/test/CodeGen/redefine_extname.c

clang/test/CodeGen/regcall.c

clang/test/CodeGen/regparm.c

clang/test/CodeGen/riscv-inline-asm.c

clang/test/CodeGen/riscv32-ilp32-abi.c

clang/test/CodeGen/riscv32-ilp32-ilp32f-abi.c

clang/test/CodeGen/riscv32-ilp32-ilp32f-ilp32d-abi.c

clang/test/CodeGen/riscv32-ilp32d-abi.c

clang/test/CodeGen/riscv32-ilp32f-abi.c

clang/test/CodeGen/riscv32-ilp32f-ilp32d-abi.c

clang/test/CodeGen/riscv64-lp64-abi.c

clang/test/CodeGen/riscv64-lp64-lp64f-abi.c

clang/test/CodeGen/riscv64-lp64-lp64f-lp64d-abi.c

clang/test/CodeGen/riscv64-lp64d-abi.c

clang/test/CodeGen/riscv64-lp64f-lp64d-abi.c

clang/test/CodeGen/sanitize-address-field-padding.cpp

clang/test/CodeGen/sparc-arguments.c

clang/test/CodeGen/sparc-vaarg.c

clang/test/CodeGen/sparcv8-abi.c

clang/test/CodeGen/sparcv8-inline-asm.c

clang/test/CodeGen/sparcv9-abi.c

clang/test/CodeGen/sparcv9-dwarf.c

clang/test/CodeGen/spir-half-type.cpp

clang/test/CodeGen/stackrealign-main.c

clang/test/CodeGen/stdcall-fastcall.c

clang/test/CodeGen/switch.c

clang/test/CodeGen/systemz-abi-vector.c

clang/test/CodeGen/systemz-abi.c

clang/test/CodeGen/systemz-abi.cpp

clang/test/CodeGen/systemz-inline-asm.c

clang/test/CodeGen/thread-specifier.c

clang/test/CodeGen/tls-model.c

clang/test/CodeGen/transparent-union-redecl.c

clang/test/CodeGen/transparent-union.c

clang/test/CodeGen/ubsan-asan-noreturn.c

clang/test/CodeGen/ubsan-function.cpp

clang/test/CodeGen/unaligned-decl.c

clang/test/CodeGen/union-tbaa1.c

clang/test/CodeGen/unsigned-overflow-minimal.c

clang/test/CodeGen/unwind-attr.c

clang/test/CodeGen/variadic-null-win64.c

clang/test/CodeGen/visibility.c

clang/test/CodeGen/vla.c

clang/test/CodeGen/volatile-complex.c

clang/test/CodeGen/x86-inline-asm-min-vector-width.c

clang/test/CodeGen/x86-long-double.cpp

clang/test/CodeGen/x86-soft-float.c

clang/test/CodeGen/x86-vec-i128.c

clang/test/CodeGen/x86_32-arguments-iamcu.c

clang/test/CodeGen/x86_32-arguments-linux.c

clang/test/CodeGen/x86_32-arguments-nommx.c

clang/test/CodeGen/x86_64-arguments-nacl.c

clang/test/CodeGen/x86_64-arguments.c

clang/test/CodeGen/x86_64-floatvectors.c

clang/test/CodeGen/x86_64-longdouble.c

clang/test/CodeGen/xcore-abi.c

clang/test/CodeGen/xcore-abi.cpp

clang/test/CodeGen/xray-always-instrument.cpp

clang/test/CodeGen/xray-attr-list.cpp

clang/test/CodeGen/xray-attributes-noxray-supported.cpp

clang/test/CodeGen/xray-attributes-supported.cpp

clang/test/CodeGen/xray-ignore-loops.cpp

clang/test/CodeGen/xray-imbue-arg1.cpp

clang/test/CodeGen/xray-instruction-threshold.cpp

clang/test/CodeGen/xray-instrumentation-bundles.cpp

clang/test/CodeGen/xray-log-args.cpp

clang/test/CodeGen/xray-never-instrument.cpp

clang/test/CodeGen/zvector.c

clang/test/CodeGenCXX/2009-05-04-PureConstNounwind.cpp

clang/test/CodeGenCXX/2011-12-19-init-list-ctor.cpp

clang/test/CodeGenCXX/aarch64-arguments.cpp

clang/test/CodeGenCXX/alloca-align.cpp

clang/test/CodeGenCXX/amdgcn-automatic-variable.cpp

clang/test/CodeGenCXX/amdgcn-func-arg.cpp

clang/test/CodeGenCXX/amdgcn-string-literal.cpp

clang/test/CodeGenCXX/amdgcn_declspec_get.cpp

clang/test/CodeGenCXX/arm64-darwinpcs.cpp

clang/test/CodeGenCXX/attr-callback.cpp

clang/test/CodeGenCXX/attr-cpuspecific.cpp

clang/test/CodeGenCXX/attr-exclude_from_explicit_instantiation.dont_assume_extern_instantiation.cpp

clang/test/CodeGenCXX/attr-target-mv-func-ptrs.cpp

clang/test/CodeGenCXX/attr-used-member-function-implicit-instantiation.cpp

clang/test/CodeGenCXX/attr-x86-interrupt.cpp

clang/test/CodeGenCXX/attr.cpp

clang/test/CodeGenCXX/auto-variable-template.cpp

clang/test/CodeGenCXX/bitfield.cpp

clang/test/CodeGenCXX/bool-bitfield.cpp

clang/test/CodeGenCXX/builtin-calling-conv.cpp

clang/test/CodeGenCXX/builtin-is-constant-evaluated.cpp

clang/test/CodeGenCXX/builtin-launder.cpp

clang/test/CodeGenCXX/builtin-operator-new-delete.cpp

clang/test/CodeGenCXX/builtin_LINE.cpp

clang/test/CodeGenCXX/catch-nullptr-and-nonzero-offset-in-offsetof-idiom.cpp

clang/test/CodeGenCXX/catch-undef-behavior.cpp

clang/test/CodeGenCXX/char8_t.cpp

clang/test/CodeGenCXX/clang-sections-tentative.c

clang/test/CodeGenCXX/clang-sections.cpp

clang/test/CodeGenCXX/compound-literals.cpp

clang/test/CodeGenCXX/conditional-gnu-ext.cpp

clang/test/CodeGenCXX/conditional-temporaries.cpp

clang/test/CodeGenCXX/const-init-cxx11.cpp

clang/test/CodeGenCXX/const-init-cxx2a.cpp

clang/test/CodeGenCXX/constructor-alias.cpp

clang/test/CodeGenCXX/constructor-destructor-return-this.cpp

clang/test/CodeGenCXX/copy-constructor-elim-2.cpp

clang/test/CodeGenCXX/ctor-dtor-alias.cpp

clang/test/CodeGenCXX/cxx0x-delegating-ctors.cpp

clang/test/CodeGenCXX/cxx0x-initializer-array.cpp

clang/test/CodeGenCXX/cxx0x-initializer-constructors.cpp

clang/test/CodeGenCXX/cxx0x-initializer-stdinitializerlist-startend.cpp

clang/test/CodeGenCXX/cxx0x-initializer-stdinitializerlist.cpp

clang/test/CodeGenCXX/cxx11-extern-constexpr.cpp

clang/test/CodeGenCXX/cxx11-initializer-aggregate.cpp

clang/test/CodeGenCXX/cxx11-thread-local-reference.cpp

clang/test/CodeGenCXX/cxx11-thread-local-visibility.cpp

clang/test/CodeGenCXX/cxx11-thread-local.cpp

clang/test/CodeGenCXX/cxx1y-deduced-return-type.cpp

clang/test/CodeGenCXX/cxx1y-init-captures-eh.cpp

clang/test/CodeGenCXX/cxx1y-init-captures.cpp

clang/test/CodeGenCXX/cxx1y-initializer-aggregate.cpp

clang/test/CodeGenCXX/cxx1y-sized-deallocation.cpp

clang/test/CodeGenCXX/cxx1y-variable-template.cpp

clang/test/CodeGenCXX/cxx1z-decomposition.cpp

clang/test/CodeGenCXX/cxx1z-initializer-aggregate.cpp

clang/test/CodeGenCXX/cxx1z-inline-variables.cpp

clang/test/CodeGenCXX/cxx2a-destroying-delete.cpp

clang/test/CodeGenCXX/cxx2a-thread-local-constinit.cpp

clang/test/CodeGenCXX/debug-info.cpp

clang/test/CodeGenCXX/default_calling_conv.cpp

clang/test/CodeGenCXX/delete-two-arg.cpp

clang/test/CodeGenCXX/derived-cast.cpp

clang/test/CodeGenCXX/designated-init.cpp

clang/test/CodeGenCXX/devirtualize-dtor-final.cpp

clang/test/CodeGenCXX/devirtualize-virtual-function-calls-final.cpp

clang/test/CodeGenCXX/devirtualize-virtual-function-calls.cpp

clang/test/CodeGenCXX/exceptions.cpp

clang/test/CodeGenCXX/explicit-instantiation.cpp

clang/test/CodeGenCXX/extern-section-attribute.cpp

clang/test/CodeGenCXX/fastcall.cpp

clang/test/CodeGenCXX/flatten.cpp

clang/test/CodeGenCXX/float128-declarations.cpp

clang/test/CodeGenCXX/fp16-mangle.cpp

clang/test/CodeGenCXX/global-dtor-no-atexit.cpp

clang/test/CodeGenCXX/homogeneous-aggregates.cpp

clang/test/CodeGenCXX/implicit-record-visibility.cpp

clang/test/CodeGenCXX/inheriting-constructor.cpp

clang/test/CodeGenCXX/init-invariant.cpp

clang/test/CodeGenCXX/initializer-list-ctor-order.cpp

clang/test/CodeGenCXX/invariant.group-for-vptrs.cpp

clang/test/CodeGenCXX/key-function-vtable.cpp

clang/test/CodeGenCXX/linetable-virtual-variadic.cpp

clang/test/CodeGenCXX/mangle-win64-ccs.cpp

clang/test/CodeGenCXX/member-function-pointers.cpp

clang/test/CodeGenCXX/microsoft-abi-default-cc.cpp

clang/test/CodeGenCXX/microsoft-abi-sret-and-byval.cpp

clang/test/CodeGenCXX/microsoft-uuidof-mangling.cpp

clang/test/CodeGenCXX/microsoft-uuidof.cpp

clang/test/CodeGenCXX/mips-size_t-ptrdiff_t.cpp

clang/test/CodeGenCXX/new-alias.cpp

clang/test/CodeGenCXX/new-array-init-exceptions.cpp

clang/test/CodeGenCXX/new-array-init.cpp

clang/test/CodeGenCXX/new-overflow.cpp

clang/test/CodeGenCXX/new.cpp

clang/test/CodeGenCXX/no-elide-constructors.cpp

clang/test/CodeGenCXX/no-odr-use.cpp

clang/test/CodeGenCXX/no-unique-address.cpp

clang/test/CodeGenCXX/nrvo.cpp

clang/test/CodeGenCXX/powerpc-byval.cpp

clang/test/CodeGenCXX/pr12251.cpp

clang/test/CodeGenCXX/pr13396.cpp

clang/test/CodeGenCXX/pr31054.cpp

clang/test/CodeGenCXX/pr9130.cpp

clang/test/CodeGenCXX/pragma-visibility.cpp

clang/test/CodeGenCXX/redefine_extname.cpp

clang/test/CodeGenCXX/regcall.cpp

clang/test/CodeGenCXX/rtti-qualfn.cpp

clang/test/CodeGenCXX/stack-reuse-exceptions.cpp

clang/test/CodeGenCXX/stack-reuse.cpp

clang/test/CodeGenCXX/static-data-member.cpp

clang/test/CodeGenCXX/static-init-4.cpp

clang/test/CodeGenCXX/static-init.cpp

clang/test/CodeGenCXX/static-initializer-branch-weights.cpp

clang/test/CodeGenCXX/static-local-in-local-class.cpp

clang/test/CodeGenCXX/static-member-variable-explicit-specialization.cpp

clang/test/CodeGenCXX/std-byte.cpp

clang/test/CodeGenCXX/template-anonymous-types.cpp

clang/test/CodeGenCXX/thiscall-struct-return.cpp

clang/test/CodeGenCXX/throw-expression-cleanup.cpp

clang/test/CodeGenCXX/throw-expressions.cpp

clang/test/CodeGenCXX/thunk-linkonce-odr.cpp

clang/test/CodeGenCXX/thunk-returning-memptr.cpp

clang/test/CodeGenCXX/thunks.cpp

clang/test/CodeGenCXX/type-metadata.cpp

clang/test/CodeGenCXX/ubsan-function-noexcept.cpp

clang/test/CodeGenCXX/ubsan-vtable-checks.cpp

clang/test/CodeGenCXX/uncopyable-args.cpp

clang/test/CodeGenCXX/virt-dtor-key.cpp

clang/test/CodeGenCXX/virtual-function-elimination.cpp

clang/test/CodeGenCXX/visibility-inlines-hidden-staticvar.cpp

clang/test/CodeGenCXX/visibility-inlines-hidden.cpp

clang/test/CodeGenCXX/vla-consruct.cpp

clang/test/CodeGenCXX/vla.cpp

clang/test/CodeGenCXX/vtable-key-function-arm.cpp

clang/test/CodeGenCXX/vtable-linkage.cpp

clang/test/CodeGenCXX/x86_64-arguments-avx.cpp

clang/test/CodeGenCXX/x86_64-arguments-nacl-x32.cpp

clang/test/CodeGenCXX/x86_64-arguments.cpp

clang/test/CodeGenCoroutines/coro-await-resume-eh.cpp

clang/test/CodeGenCoroutines/coro-cleanup.cpp

clang/test/CodeGenCoroutines/coro-gro-nrvo.cpp

clang/test/CodeGenCoroutines/coro-gro.cpp

clang/test/CodeGenCoroutines/coro-lambda.cpp

clang/test/CodeGenCoroutines/coro-params.cpp

clang/test/CodeGenCoroutines/coro-ret-void.cpp

clang/test/Modules/codegen-extern-template.cpp

clang/test/Modules/initializers.cpp

clang/test/Modules/var-templates.cpp

clang/test/OpenMP/allocate_codegen.cpp

clang/test/OpenMP/constexpr_codegen.cpp

clang/test/OpenMP/declare_variant_mixed_codegen.c

clang/test/OpenMP/for_codegen.cpp

clang/test/OpenMP/for_private_codegen.cpp

clang/test/OpenMP/nvptx_declare_target_var_ctor_dtor_codegen.cpp

clang/test/OpenMP/nvptx_target_requires_unified_shared_memory.cpp

clang/test/OpenMP/openmp_offload_registration.cpp

clang/test/OpenMP/parallel_codegen.cpp

clang/test/OpenMP/parallel_firstprivate_codegen.cpp

clang/test/OpenMP/parallel_master_codegen.cpp

clang/test/OpenMP/parallel_private_codegen.cpp

clang/test/OpenMP/sections_private_codegen.cpp

clang/test/OpenMP/simd_metadata.c

clang/test/OpenMP/single_codegen.cpp

clang/test/OpenMP/single_private_codegen.cpp

clang/test/OpenMP/target_codegen_global_capture.cpp

clang/test/OpenMP/target_codegen_registration.cpp

clang/test/OpenMP/target_data_use_device_ptr_codegen.cpp

clang/test/OpenMP/target_defaultmap_codegen.cpp

clang/test/OpenMP/target_is_device_ptr_codegen.cpp

clang/test/OpenMP/target_map_codegen.cpp

clang/test/OpenMP/target_parallel_codegen_registration.cpp

clang/test/OpenMP/target_parallel_for_codegen_registration.cpp

clang/test/OpenMP/target_parallel_for_simd_codegen_registration.cpp

clang/test/OpenMP/target_simd_codegen_registration.cpp

clang/test/OpenMP/target_teams_codegen_registration.cpp

clang/test/OpenMP/target_teams_distribute_codegen_registration.cpp

clang/test/OpenMP/target_teams_distribute_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_codegen_registration.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_parallel_for_simd_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_private_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_codegen_registration.cpp

clang/test/OpenMP/target_teams_distribute_simd_firstprivate_codegen.cpp

clang/test/OpenMP/target_teams_distribute_simd_private_codegen.cpp

clang/test/OpenMP/teams_distribute_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_private_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_parallel_for_simd_private_codegen.cpp

clang/test/OpenMP/teams_distribute_private_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_firstprivate_codegen.cpp

clang/test/OpenMP/teams_distribute_simd_private_codegen.cpp

clang/test/OpenMP/teams_private_codegen.cpp

clang/test/OpenMP/threadprivate_codegen.cpp

clang/test/PCH/chain-pending-instantiations.cpp

clang/test/SemaCXX/attr-on-explicit-template-instantiation.cpp

clang/test/SemaCXX/cxx03-aligned-allocation-unscoped-enum.cpp