- User Since
- Oct 24 2016, 8:15 AM (242 w, 3 d)
Tue, Jun 15
Mon, Jun 14
Fri, Jun 11
Thu, Jun 10
Thanks for the updates Xing, LGTM.
Wed, Jun 9
Tue, Jun 8
One comment but otherwise LGTM.
Mon, Jun 7
Thanks for working on this. I'm excited to finally replace all the precompiled objects we used for testing the XCOFF tools implementation. I've only got one initial comment since I'm not real familiar with this part fo the code yet, but will spend some more time going over this tomorrow.
Thanks for working on this. My first suggestion is we need to break up this patch to make it smaller and easier to review. The natural place to partition it is the llvm-readobj functionality. I don't think the YAML tools support generating 64-bit XCOFF objects yet, but we can add a precompiled object file as test input.
Wed, Jun 2
Tue, Jun 1
Tue, May 25
May 17 2021
May 15 2021
May 10 2021
Thanks Xing, LGTM.
May 6 2021
Thanks for the updates Victor, LGTM.
May 3 2021
Apr 30 2021
Great work Sidharth, a couple minor nits but otherwise the patch LGTM.
Apr 29 2021
Apr 28 2021
Awesome work Sidarth, patch looks really good. I've got one initial comment.
One minor nit but otherwise LGTM.
Apr 27 2021
Apr 26 2021
Thanks for the quick updates. Patch is getting really close I think.
Thanks for splitting this out Xing. I suggest showing the syntax differences between gas and AIX assembly we intend to work around with these macros in the commit message. LGTM.
Apr 22 2021
Apr 20 2021
Patch looks pretty good. IIUC we were not printing the '@gd' specifier before because it is assumed by default by the system assembler. Now that we are adding object file support we can no longer rely of the system assembler to assume the specifier based on the storage mapping class ,and need to add the new variant kinds so we create the correct relocations, which has the side effect of also changing the asm we emit. I know I am being pedantic, but I think we should land that part of the change and the update to the asm test in an initial patch even though the object writing is the motivation for adding it.
Mar 24 2021
Mar 8 2021
discussed with sean offline, the we do not call the emitGlobalDtorWithCXAAtExit() in AIX. so we do not have the problem for the "__dso_handle"
I initially had concerns with the places clang introduces non-default visibility in codegen. The few cases I was worried we would hit were related to static init , but that was before @Xiangling_L static init related work. After those changes I have no other concerns. I would wait a day or two to ensure that there are no more comments related to the round-trip-args behaviour but otherwise LGTM.
Mar 6 2021
Mar 5 2021
Thanks for the updates Lei. LGTM.
One minor comment but otherwise LGTM.
- clang-formated lambda
- changed check-prefixes to check-prefix
- added whitespace between 32-bit and 64-bit check lines
- Changed check for further custom RegLcos to include that the ValNo of the next RegLoc is the same as the original ValNo.
Patch looks good Lei, the one thing we are missing though is a lit test that checks for the expected toc entries.
Mar 4 2021
Mar 3 2021
Fix formating on assert.
- Add asserts that the ValNo of custom RegLocs match the ValNo of the custom MemLoc.
- Assert that we are targeting 32-bit codegen when we have 4 custom RegLocs.
- Add comments to the tests to make it easier to determine what is being tested.
Mar 2 2021
- Converted loop to explicit handling of custom RegLocs
- Added const on member function.
Mar 1 2021
Feb 28 2021
Fixed a number of formatting and spelling mistakes.
Feb 25 2021
Feb 18 2021
Feb 17 2021
Could there be a simpler approach where we always emit a .got section on PPC64: In addReservedSymbols if we fail to resolve .TOC. then we create it?
Feb 16 2021
Feb 12 2021
LGTM. Please wait until David has given it the OK too though.
Feb 11 2021
Thanks for the update. LGTM.
I'll need a bit more time to finish going through ppc-shrink-wrapping.ll but the patch is looking really good. Thanks for the updates.
Feb 10 2021
Addressed review comments.