Page MenuHomePhabricator

sfertile (Sean Fertile)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2016, 8:15 AM (291 w, 5 d)

Recent Activity

Mar 30 2022

sfertile accepted D122450: [ELF] Default to --no-fortran-common.

LGTM.

Mar 30 2022, 7:31 AM · Restricted Project, Restricted Project

Mar 8 2022

sfertile added a comment to D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function.

Thanks for the updates Zarko. I think we are almost there.

Mar 8 2022, 7:27 AM · Restricted Project, Restricted Project, Restricted Project

Mar 2 2022

Herald added a project to D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function: Restricted Project.
Mar 2 2022, 10:52 AM · Restricted Project, Restricted Project, Restricted Project

Feb 17 2022

sfertile added a comment to D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function.

Hey Zarko. I really like how we only issue the warning when the struct is used, however I think this is still overly broad because of where the incompatibility lies between xlc and clang. I believe the layout of the structures will be the same for both compilers, and globals of this type will have the same alignment restrictions. A function like void baz(int *); will be compatible between the 2 compilers since the argument is just a pointer. The difference occurs when passing the structure by value on the stack, where xlc doesn't align the struct to the expected alignment, and clang/llvm does. Since the incompatibility is in the calling convention only when the struct is passed byval, that should be the only time we emit the diagnostic.

Feb 17 2022, 7:15 AM · Restricted Project, Restricted Project, Restricted Project

Feb 15 2022

sfertile accepted D119787: [ELF][PPC64] Fix assertion failure for branches to hidden undefined weak for -no-pie.

LGTM.

Feb 15 2022, 12:51 PM · Restricted Project, Restricted Project

Feb 7 2022

sfertile added a reviewer for D101470: [XCOFF][AIX] Peephole optimization in 32-bit TocData transformation: stefanp.
Feb 7 2022, 10:08 AM · Restricted Project

Feb 1 2022

sfertile requested review of D118718: [PowerPC][AIX] Peephole optimization for 64-bit TocData transformation.
Feb 1 2022, 11:13 AM · Restricted Project, Restricted Project
sfertile retitled D101470: [XCOFF][AIX] Peephole optimization in 32-bit TocData transformation from [XCOFF][AIX] Peephole optimization in TocData transformation to [XCOFF][AIX] Peephole optimization in 32-bit TocData transformation.
Feb 1 2022, 8:55 AM · Restricted Project

Jan 28 2022

sfertile accepted D118477: [NFC][AIX]Disable new pcm tests on AIX.

Thanks Steven. LGTM.

Jan 28 2022, 8:55 AM · Restricted Project
sfertile added a comment to D118474: [NFC][AIX][clang] un-XFAIL gcc profile flag compat test.

Thanks David.

Jan 28 2022, 8:54 AM · Restricted Project

Jan 27 2022

sfertile accepted D116607: [AIX][PowerPC][PGO] Generate .ref for some PGO sections .

LGTM Wael. Sorry for taking so long to get to it.

Jan 27 2022, 6:43 PM · Restricted Project
sfertile updated the diff for D101470: [XCOFF][AIX] Peephole optimization in 32-bit TocData transformation.

rebase patch and update the testing.

Jan 27 2022, 12:02 PM · Restricted Project
sfertile committed rGdad2b6e797df: [PowerPC][AIX] Support toc-data attribute for read-only globals. (authored by yoalione).
[PowerPC][AIX] Support toc-data attribute for read-only globals.
Jan 27 2022, 7:49 AM
sfertile closed D116181: [PowerPC][AIX] Support toc-data attribute for read-only globals.
Jan 27 2022, 7:49 AM · Restricted Project

Jan 25 2022

sfertile committed rGa2505bd063e7: [PowerPC][AIX] Override markFunctionEnd() (authored by sfertile).
[PowerPC][AIX] Override markFunctionEnd()
Jan 25 2022, 7:09 AM
sfertile closed D117040: [PowerPC][AIX] Override markFunctionEnd().
Jan 25 2022, 7:09 AM · Restricted Project, Restricted Project

Jan 24 2022

sfertile added a comment to D112086: [libc++][AIX] Do not assert chmod return value is non-zero..

Here is an example of a build that's failing: https://buildkite.com/llvm-project/libcxx-ci/builds/8104#3fcf3f17-bdfe-476b-85f7-314c82a378ff. D117512 is completely unrelated to filesystem, so I can't imagine it's an actual issue with D117512.

Jan 24 2022, 10:22 AM · Restricted Project
sfertile committed rGd193f7be7898: [libc++][AIX] Do not assert chmod return value is non-zero. (authored by sfertile).
[libc++][AIX] Do not assert chmod return value is non-zero.
Jan 24 2022, 7:31 AM
sfertile closed D112086: [libc++][AIX] Do not assert chmod return value is non-zero..
Jan 24 2022, 7:31 AM · Restricted Project

Jan 21 2022

sfertile updated the diff for D112086: [libc++][AIX] Do not assert chmod return value is non-zero..

Rebase to trigger ci before committing, since I let this sit so long.

Jan 21 2022, 11:38 AM · Restricted Project

Jan 20 2022

sfertile updated the diff for D117040: [PowerPC][AIX] Override markFunctionEnd().

Fixed formatting.

Jan 20 2022, 10:41 AM · Restricted Project, Restricted Project

Jan 17 2022

sfertile committed rG10d3bf951841: [PowerPC][AIX] Fallback to DAG-ISEL if global has toc-data attribute. (authored by sfertile).
[PowerPC][AIX] Fallback to DAG-ISEL if global has toc-data attribute.
Jan 17 2022, 1:24 PM
sfertile closed D115373: [PowerPC][AIX] Fallback to DAG-ISEL if a global has toc-data attribute..
Jan 17 2022, 1:24 PM · Restricted Project

Jan 11 2022

sfertile requested review of D117040: [PowerPC][AIX] Override markFunctionEnd().
Jan 11 2022, 10:07 AM · Restricted Project, Restricted Project

Dec 22 2021

sfertile accepted D116181: [PowerPC][AIX] Support toc-data attribute for read-only globals.

LGTM.

Dec 22 2021, 11:47 AM · Restricted Project

Dec 20 2021

sfertile updated the diff for D115373: [PowerPC][AIX] Fallback to DAG-ISEL if a global has toc-data attribute..
  • Fix if condition that broke the Debian buildbot.
  • Remove 'Required: asserts' from the test as I've updated to use a pass that is run regardless of whether asserts are enabled or not.
  • Remove some unintended formatting changes from the lit test.
Dec 20 2021, 10:02 AM · Restricted Project

Dec 8 2021

sfertile edited reviewers for D115373: [PowerPC][AIX] Fallback to DAG-ISEL if a global has toc-data attribute., added: yoalione; removed: yousufhali.
Dec 8 2021, 12:07 PM · Restricted Project
sfertile requested review of D115373: [PowerPC][AIX] Fallback to DAG-ISEL if a global has toc-data attribute..
Dec 8 2021, 12:04 PM · Restricted Project

Dec 1 2021

sfertile committed rG415e821a5089: [PowerPC][AIX] Add toc-data support for 64-bit AIX small code model. (authored by yoalione).
[PowerPC][AIX] Add toc-data support for 64-bit AIX small code model.
Dec 1 2021, 7:58 AM
sfertile closed D114654: [PowerPC][AIX] Add toc-data support for 64-bit AIX.
Dec 1 2021, 7:58 AM · Restricted Project

Nov 29 2021

sfertile accepted D114654: [PowerPC][AIX] Add toc-data support for 64-bit AIX.

LGTM!

Nov 29 2021, 12:49 PM · Restricted Project
sfertile added inline comments to D114654: [PowerPC][AIX] Add toc-data support for 64-bit AIX.
Nov 29 2021, 8:29 AM · Restricted Project

Nov 26 2021

sfertile added a comment to D114654: [PowerPC][AIX] Add toc-data support for 64-bit AIX.

Nice work Yousuf. Can you start by adding the context for the patch (for example if you used git diff or git show then adding -U9999 will give you 9999 lines of surrounding context in the diff), and running clang format on the patch?

Nov 26 2021, 12:28 PM · Restricted Project

Nov 10 2021

sfertile committed rGe068c84762ac: [libc++][AIX] Alignment of bool on AIX is 1 (authored by sfertile).
[libc++][AIX] Alignment of bool on AIX is 1
Nov 10 2021, 10:03 AM
sfertile closed D112087: [libc++][AIX] Alignment of bool on AIX is 1.
Nov 10 2021, 10:03 AM · Restricted Project
sfertile updated the diff for D112087: [libc++][AIX] Alignment of bool on AIX is 1.

Rebased to trigger CI.

Nov 10 2021, 7:30 AM · Restricted Project

Oct 26 2021

sfertile added a comment to D111889: [AIX] Support of Big archive (read).

For the 2 binary files being added, I think we should append xcoff- in the names.

Oct 26 2021, 1:37 PM · Restricted Project

Oct 21 2021

sfertile updated the diff for D112086: [libc++][AIX] Do not assert chmod return value is non-zero..

Rebase on https://reviews.llvm.org/D111359 and remove XFAIL from now passing tests.

Oct 21 2021, 7:01 AM · Restricted Project
sfertile abandoned D102632: [libcxx/cxxabi/unwind][AIX] Add an AIX target and config for testing..
Oct 21 2021, 6:53 AM · Restricted Project

Oct 19 2021

sfertile requested review of D112087: [libc++][AIX] Alignment of bool on AIX is 1.
Oct 19 2021, 11:06 AM · Restricted Project
sfertile requested review of D112086: [libc++][AIX] Do not assert chmod return value is non-zero..
Oct 19 2021, 11:04 AM · Restricted Project

Sep 29 2021

sfertile added inline comments to D82549: [AIX][XCOFF] parsing xcoff object file auxiliary header.
Sep 29 2021, 10:12 AM · Restricted Project
sfertile committed rG9b10e2b1cf01: [PowerPC][AIX] Warn when using pragma align(packed) on AIX. (authored by sfertile).
[PowerPC][AIX] Warn when using pragma align(packed) on AIX.
Sep 29 2021, 8:55 AM
sfertile closed D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX..
Sep 29 2021, 8:55 AM · Restricted Project, Restricted Project

Sep 24 2021

sfertile added a comment to D109090: [FreeBSD] avoid marking __stack_chk_guard symbol as dso_local on FreeBSD.

@adalava the symbol __stack_chk_guard resides in libc.so on FreeBSD (i.e. a different DSO from the compiled program).

Sep 24 2021, 7:15 AM · Restricted Project

Sep 16 2021

sfertile accepted D105659: [PowerPC][AIX] Support ByVals with greater alignment then pointer size.

LGTM, but since as you mentioned I originally wrote this I would fell better if @cebowleratibm reviewed and approved before committing as well.

Sep 16 2021, 7:34 AM · Restricted Project

Sep 15 2021

sfertile accepted D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX.

LGTM.

Sep 15 2021, 1:07 PM · Restricted Project, Restricted Project

Sep 14 2021

sfertile added a comment to D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX.

I suggest we separate the clang change and testing into a standalone patch, and the llvm backend tests into a standalone patch which we can commit separately.

Sep 14 2021, 11:12 AM · Restricted Project, Restricted Project

Aug 19 2021

sfertile added inline comments to D104646: [AIX][XCOFF] 64-bit relocation reading support.
Aug 19 2021, 11:19 AM · Restricted Project
sfertile added a comment to D104639: [AIX][XCOFF] Add support for 64-bit file header and section header writing.

I tried to make changes you told me to see if I could make it in time. Because tomorow is my last day at work, I don't have enough time to redo all the patchs especially the tests.

Aug 19 2021, 10:40 AM · Restricted Project

Aug 18 2021

sfertile added a comment to D104639: [AIX][XCOFF] Add support for 64-bit file header and section header writing.

As a non-XCOFF developer, this mostly looks fine to me, but needs a test case.

Aug 18 2021, 1:02 PM · Restricted Project
sfertile committed rG7151a8aada21: [PowerPC][AIX] llvm-readobj: Convert some errors to warnings. (authored by MaryamBen).
[PowerPC][AIX] llvm-readobj: Convert some errors to warnings.
Aug 18 2021, 8:05 AM
sfertile closed D106783: [AIX][XCOFF][llvm-readobj] Replace unwrapOrError with reportUniqueWarning.
Aug 18 2021, 8:05 AM · Restricted Project

Aug 17 2021

sfertile accepted D106783: [AIX][XCOFF][llvm-readobj] Replace unwrapOrError with reportUniqueWarning.

Hi Maryam.

Aug 17 2021, 8:00 AM · Restricted Project

Aug 7 2021

sfertile updated the diff for D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX..

Add a couple more struct layouts to the testing to show cases diagnostic is not issued.

Aug 7 2021, 5:51 PM · Restricted Project, Restricted Project

Aug 6 2021

sfertile added a reverting change for rG5181be344adb: [PowerPC][AIX] Limit attribute aligned to 4096.: rGdddd524bb884: Revert "[PowerPC][AIX] Limit attribute aligned to 4096.".
Aug 6 2021, 10:56 AM
sfertile committed rGdddd524bb884: Revert "[PowerPC][AIX] Limit attribute aligned to 4096." (authored by sfertile).
Revert "[PowerPC][AIX] Limit attribute aligned to 4096."
Aug 6 2021, 10:56 AM
sfertile added a reverting change for D107497: [PowerPC][AIX] Limit attribute aligned to 4096.: rGdddd524bb884: Revert "[PowerPC][AIX] Limit attribute aligned to 4096.".
Aug 6 2021, 10:56 AM · Restricted Project, Restricted Project
sfertile added inline comments to D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX..
Aug 6 2021, 9:07 AM · Restricted Project, Restricted Project
sfertile updated the diff for D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX..

Fixed diagnostic to only emit when there is a bitfield member.

Aug 6 2021, 9:06 AM · Restricted Project, Restricted Project
sfertile added a comment to D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX..

Moved the diagnostic emission to Sema::ActOnTagFinishDefinition as suggested.

Aug 6 2021, 6:50 AM · Restricted Project, Restricted Project
sfertile updated the diff for D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX..

Moved the diagnostic emission to Sema::ActOnTagFinishDefinition as suggested.

Aug 6 2021, 6:43 AM · Restricted Project, Restricted Project

Aug 5 2021

sfertile committed rG23651c5ae02a: [PowerPC][AIX] Create multiple constant sections. (authored by sfertile).
[PowerPC][AIX] Create multiple constant sections.
Aug 5 2021, 6:21 PM
sfertile closed D103103: [PowerPC][XCOFF] Create 8 and 16 byte aligned constant csects..
Aug 5 2021, 6:20 PM · Restricted Project, Restricted Project
sfertile accepted D107598: [AIX] "aligned" attribute should not decrease type alignment returned by __alignof__.

LGTM, other then 1 small test update.

Aug 5 2021, 3:01 PM · Restricted Project
sfertile added a comment to D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX..

Good point Chris. The only difference in layout is related to bitfield members, so I have moved the warning to VerifyBitField as suggested.

Aug 5 2021, 12:12 PM · Restricted Project, Restricted Project
sfertile updated the diff for D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX..

Only emit diagnostic on bitfield members, which is the only difference in align(packed) behaviour XL and clang/xlclang.

Aug 5 2021, 12:10 PM · Restricted Project, Restricted Project
sfertile committed rGf888e442bcc5: [PowerPC][AIX] attribute aligned cannot decrease align of a vector var. (authored by sfertile).
[PowerPC][AIX] attribute aligned cannot decrease align of a vector var.
Aug 5 2021, 8:17 AM
sfertile closed D107522: [PowerPC][AIX] attribute aligned cannot decrease align of a vector var..
Aug 5 2021, 8:16 AM · Restricted Project
sfertile committed rG5181be344adb: [PowerPC][AIX] Limit attribute aligned to 4096. (authored by sfertile).
[PowerPC][AIX] Limit attribute aligned to 4096.
Aug 5 2021, 6:52 AM
sfertile closed D107497: [PowerPC][AIX] Limit attribute aligned to 4096..
Aug 5 2021, 6:51 AM · Restricted Project, Restricted Project
sfertile added inline comments to D107522: [PowerPC][AIX] attribute aligned cannot decrease align of a vector var..
Aug 5 2021, 6:17 AM · Restricted Project
sfertile updated the diff for D107522: [PowerPC][AIX] attribute aligned cannot decrease align of a vector var..
  • Fixed spelling mistake
  • Check that VD is non-nulll earlier.
  • added warning that the requested alignment is too small.
  • renamed test
Aug 5 2021, 6:16 AM · Restricted Project

Aug 4 2021

sfertile requested review of D107522: [PowerPC][AIX] attribute aligned cannot decrease align of a vector var..
Aug 4 2021, 7:18 PM · Restricted Project
sfertile added a comment to D107394: [AIX] "aligned" attribute does not decrease alignment.

Thanks Steven, LGTM.

Aug 4 2021, 7:13 PM · Restricted Project
sfertile updated the diff for D107497: [PowerPC][AIX] Limit attribute aligned to 4096..

Fix formatting.

Aug 4 2021, 3:12 PM · Restricted Project, Restricted Project
sfertile requested review of D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX..
Aug 4 2021, 3:10 PM · Restricted Project, Restricted Project
sfertile requested review of D107497: [PowerPC][AIX] Limit attribute aligned to 4096..
Aug 4 2021, 12:53 PM · Restricted Project, Restricted Project
sfertile added inline comments to D107394: [AIX] "aligned" attribute does not decrease alignment.
Aug 4 2021, 10:07 AM · Restricted Project
sfertile committed rGb8f612e780e5: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment. (authored by sfertile).
[PowerPC][AIX] Packed zero-width bitfields do not affect alignment.
Aug 4 2021, 8:05 AM
sfertile closed D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment..
Aug 4 2021, 8:04 AM · Restricted Project
sfertile added inline comments to D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment..
Aug 4 2021, 7:25 AM · Restricted Project
sfertile updated the diff for D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment..

Don't update the unpacked field align based on IsPacked.

Aug 4 2021, 7:25 AM · Restricted Project

Jul 30 2021

sfertile updated the diff for D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment..

Fixed spelling and added a 'long long' zero width bitfield to the testing.

Jul 30 2021, 10:44 AM · Restricted Project
sfertile added inline comments to D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment..
Jul 30 2021, 7:06 AM · Restricted Project

Jul 29 2021

sfertile added a reviewer for D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.: ZarkoCA.
Jul 29 2021, 12:08 PM · Restricted Project
sfertile updated the diff for D103103: [PowerPC][XCOFF] Create 8 and 16 byte aligned constant csects..

Spelling and formatting fixes, and added coverage for the XCOFF object writing.

Jul 29 2021, 11:27 AM · Restricted Project, Restricted Project

Jul 28 2021

sfertile updated the diff for D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment..

clang-formatted

Jul 28 2021, 6:53 AM · Restricted Project

Jul 27 2021

sfertile requested review of D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment..
Jul 27 2021, 11:25 AM · Restricted Project

Jul 14 2021

sfertile accepted D105945: [ELF] --fortran-common: prefer STB_WEAK to COMMON.

LGTM, thanks for finding and fixing this MaskRay.

Jul 14 2021, 6:45 AM · Restricted Project

Jul 8 2021

sfertile requested review of D105635: [PowerPC][AIX] Fix Zero-width bit fields wrt MaxFieldAlign..
Jul 8 2021, 8:05 AM · Restricted Project, Restricted Project

Jun 30 2021

sfertile added a comment to D102632: [libcxx/cxxabi/unwind][AIX] Add an AIX target and config for testing..

LGTM on AIX perspective.
FYI, we will need two reviewers from libc++ review group or the maintainer of libc++ project to approve before we could land.

Jun 30 2021, 11:55 AM · Restricted Project

Jun 15 2021

sfertile commandeered D101470: [XCOFF][AIX] Peephole optimization in 32-bit TocData transformation.
Jun 15 2021, 4:00 PM · Restricted Project
sfertile added a reviewer for D103103: [PowerPC][XCOFF] Create 8 and 16 byte aligned constant csects.: cebowleratibm.
Jun 15 2021, 3:58 PM · Restricted Project, Restricted Project
sfertile added inline comments to D100132: [libunwind][AIX] implementation of the unwinder for AIX.
Jun 15 2021, 10:55 AM · Restricted Project, Restricted Project, Restricted Project
sfertile added a comment to D103103: [PowerPC][XCOFF] Create 8 and 16 byte aligned constant csects..

ping.

Jun 15 2021, 7:49 AM · Restricted Project, Restricted Project
sfertile added inline comments to D100132: [libunwind][AIX] implementation of the unwinder for AIX.
Jun 15 2021, 7:49 AM · Restricted Project, Restricted Project, Restricted Project

Jun 14 2021

sfertile added inline comments to D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..
Jun 14 2021, 6:08 PM · Restricted Project
sfertile added a comment to D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.

Hello,
For you information, we have had trouble with arcanist configuration, and my account is used to push to review. Patch has been written by @MaryamBen, as confirmed by commit author.
Comments in push message are also made @MaryamBen.
Regards.

Jun 14 2021, 10:27 AM · Restricted Project
sfertile added inline comments to D100132: [libunwind][AIX] implementation of the unwinder for AIX.
Jun 14 2021, 8:52 AM · Restricted Project, Restricted Project, Restricted Project