Page MenuHomePhabricator

sfertile (Sean Fertile)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2016, 8:15 AM (168 w, 4 d)

Recent Activity

Thu, Jan 9

sfertile added a reviewer for D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time: xingxue.
Thu, Jan 9, 1:04 PM · Restricted Project, Restricted Project, Restricted Project
sfertile added inline comments to D72067: [PowerPC] Delete PPCSubtarget::isDarwin and isDarwinABI.
Thu, Jan 9, 11:38 AM · Restricted Project
sfertile committed rG1a1dbea24df5: [PowerPC] The VK_PLT symbolref modifier is only used on 32-bit ELF. [NFC] (authored by sfertile).
[PowerPC] The VK_PLT symbolref modifier is only used on 32-bit ELF. [NFC]
Thu, Jan 9, 11:11 AM
sfertile added a comment to D72183: [ELF][PPC64] Add --lax-call-lacks-nop.

Thanks for doing this. I think this approach in much safer at the cost of some friction on the systems where the option is needed. My one suggestion would be to separate the tail call case b foo from the normal call case. It will cause a runtime failure if the callers caller resides outside the dso and would be much more likely then a failure like glibc encountered. I believe gcc/gfortran got that case correct so it shouldn't impact usability on the older OS releases, but I'm not 100% sure of that.

Thu, Jan 9, 9:56 AM · Restricted Project
sfertile added a comment to D72197: [MC][ELF] Emit a relocation if target is defined in the same section and is non-local.

I think the change is correct, and desirable for the reasons you mentioned previously: we get consistent semantics whether function sections are used or not, and consistent behavior whether we use the integrated assembler or not. There is a chance this patch affects some users negatively despite being correct. Ideally we would commit to at least supporting part of the semantic-interposition option (so the user can opt in to disabling IPO when the callee is runtime replaceable) in the same release we land this fix. If I had the bandwidth to do this I would offer but I don't :(. Because of that user impact I don't feel confident enough to approve the patch myself, but I have no strong objection against it landing.

Thu, Jan 9, 7:34 AM · Restricted Project

Wed, Jan 8

sfertile added a comment to D72363: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC.

LGTM: I really didn't like setting PIC as the default just to work around some codegen bugs. I believe there are PowerPC codegen tests that will fail with this change though (or perhaps there is a PowerPC leak sanitizer build bot which begins to fail? @stefanp probably knows what exposed the BE issue previously).

Wed, Jan 8, 7:12 AM · Restricted Project

Mon, Jan 6

sfertile updated subscribers of D72197: [MC][ELF] Emit a relocation if target is defined in the same section and is non-local.

I wonder if is this really a bug or intentional. Clang and LLVM seem to ignore the possibility of symbol interposition (see: -fno-semantic-interposition). What is the LLVM policy for this?

Mon, Jan 6, 8:15 AM · Restricted Project

Fri, Jan 3

sfertile added a comment to D71639: [ELF][PPC64] Improve "call lacks nop" diagnostic and make it compatible with GCC<5.5 and GCC<6.4.

I agree that the runtime symbol preemption makes the failure unlikely. I disagree its not a bug though: it doesn't matter that FORTRAN and C++ have the 'one-definition-rule' because the generated code isn't ABI compliant. A compiler producing a valid C++/Fortran program that isn't ABI compliant is definitely a bug. The case I am much more concerned about is code like this:

Fri, Jan 3, 12:51 PM · Restricted Project

Thu, Jan 2

sfertile added inline comments to D72067: [PowerPC] Delete PPCSubtarget::isDarwin and isDarwinABI.
Thu, Jan 2, 5:38 PM · Restricted Project
sfertile added a comment to D71639: [ELF][PPC64] Improve "call lacks nop" diagnostic and make it compatible with GCC<5.5 and GCC<6.4.

I can definitely see it from the opposite side: We want LLD to be usable on these systems that shipped with this bug in libstdc++ and gcc/gfortran. And adding a link option can be hard to do in some build setups so its not as simple as I make it sound. What worries me though is that one of the compilers could subtly break and with the linker[s] being sloppy with the error then we don't find out until long after the toolchain has shipped.

Thu, Jan 2, 5:19 PM · Restricted Project
sfertile committed rG479e9406c2ed: [PowerPC][AIX] Enable sret arguments. (authored by sfertile).
[PowerPC][AIX] Enable sret arguments.
Thu, Jan 2, 4:50 PM
sfertile closed D71504: [PowerPC] Enable sret arguments..
Thu, Jan 2, 4:50 PM · Restricted Project
sfertile added a comment to D71639: [ELF][PPC64] Improve "call lacks nop" diagnostic and make it compatible with GCC<5.5 and GCC<6.4.

Relaxing the check will allow those old miss-compiled objects to link, but we are loosing some utility here as well: we are turning a valid link time failure into a potential runtime failure. Even worse a runtime failure that depends on the environment at load time so the failure is not consistent. Could we guard the error relaxation with a specific option so that 1) It must be opted into specifically and 2) We can eventually phase the option out once the OS that used gcc 5.* and 6.* go out of service?

Thu, Jan 2, 11:34 AM · Restricted Project
sfertile added a comment to D72067: [PowerPC] Delete PPCSubtarget::isDarwin and isDarwinABI.

I think we should be safe removing the Darwin code in this patch, but Chris will know better.

Thu, Jan 2, 10:26 AM · Restricted Project
sfertile added a comment to D71509: [ELF][PPC64] Implement IPLT code sequence for non-preemptible IFUNC.

LGTM.

Thu, Jan 2, 8:51 AM · Restricted Project

Fri, Dec 20

sfertile updated the diff for D71504: [PowerPC] Enable sret arguments..

Uploaded wrong diff last time.

Fri, Dec 20, 5:21 PM · Restricted Project
sfertile added a comment to D71504: [PowerPC] Enable sret arguments..

I don't know what happens in the case where the front-end doesn't handle some cases correctly but the back-end does. Is there a danger in enabling this in the back-end knowing we don't get correct IR for complex types for AIX? Is there an error in the front-end for those before we get to this step?

There's no error from the front-end. In terms of continuous delivery, this leads to silently bad code that could lead to incorrect output or crashes at runtime.

Fri, Dec 20, 12:11 PM · Restricted Project
sfertile updated the diff for D71504: [PowerPC] Enable sret arguments..

Rebased and added '-verify-machineinstrs` to the run commands.

Fri, Dec 20, 12:01 PM · Restricted Project
sfertile accepted D71649: [PPC32] Emit R_PPC_PLTREL24 for calls to dso_local ifunc.

🤡🤡🤡(Any chance this is reviewed before I watch star wars? (I felt that if I did not say, due to vacation schedules, this might took a lot longer..))

Fri, Dec 20, 10:51 AM · Restricted Project

Dec 18 2019

sfertile added inline comments to D70570: [PowerPC] Only use PLT annotations if using PIC relocation model.
Dec 18 2019, 8:23 AM · Restricted Project
sfertile added a comment to D70570: [PowerPC] Only use PLT annotations if using PIC relocation model.

Update diff. It would help if I actually compiled when rebasing...

@sfertile I figured the available-externally.ll test would suffice for this.
Do you think a separate test is needed, or a comment is warranted on this
test for it?

Dec 18 2019, 8:18 AM · Restricted Project
sfertile added a comment to D71649: [PPC32] Emit R_PPC_PLTREL24 for calls to dso_local ifunc.

In terms of making a dso_local ifunc work this behavior seems logical to me: I'm skeptical though because I'm not sure we typically know when we are calling an ifunc.
From the gcc docs on ifunc attribute

Dec 18 2019, 7:44 AM · Restricted Project
sfertile accepted D70570: [PowerPC] Only use PLT annotations if using PIC relocation model.

LGTM also. I have one minor question: Is it worthwhile to add a small lit test explicitly for this? ie.

  1. we don't emit the '@PLT' annotation on a call when linking with static-relocation model.
  2. emit the annotation with PIC relocation model.
Dec 18 2019, 6:05 AM · Restricted Project

Dec 17 2019

sfertile added a comment to D70570: [PowerPC] Only use PLT annotations if using PIC relocation model.
  • It is an error to not use a PLTREL relocation for a call that needs to be indirected through the PLT. The linker will complain to recompile with -fPIC.

Means you can't link static execs against shared objects anymore. Is this the intent? Or am I missing something obvious?

My phrasing wasn't quite right, I guess.
The linker will create the PLT stubs by nature of it being an external shared object, or something to that effect. What I really meant was that it's an error to need a PLT and not have it (linker will warn or error if you try to create a .so and use anything other than PLTREL relocations).

Dec 17 2019, 12:01 PM · Restricted Project
sfertile added a comment to D71509: [ELF][PPC64] Implement IPLT code sequence for non-preemptible IFUNC.

I'm not super knowledgeable on IFuncs so I really appreciate the detailed descriptions you've provided. I'll start brushing up on ifuncs so I can review this. I have one early observation though: If its valid to tail call a non-preemptible ifunc (and since its non-preemptible I'm assuming it is tail-callable) , then saving of the toc pointer in the stub is not safe.

Dec 17 2019, 10:26 AM · Restricted Project
sfertile added inline comments to D71504: [PowerPC] Enable sret arguments..
Dec 17 2019, 10:15 AM · Restricted Project

Dec 16 2019

sfertile added a comment to D71504: [PowerPC] Enable sret arguments..

So it doesn't look like we need to add any special handling for struct returns on AIX? I had a quick look and none of the other PPC targets seem to have anything.

By the time we get the IR in this form from the front-end, we shouldn't need special handling here. We know the front-end does not represent complex types in an ideal way for AIX here.

Dec 16 2019, 9:57 AM · Restricted Project
sfertile added inline comments to D71013: [AIX] Allow vararg calls when all arguments reside in registers..
Dec 16 2019, 7:38 AM · Restricted Project

Dec 13 2019

sfertile created D71504: [PowerPC] Enable sret arguments..
Dec 13 2019, 7:04 PM · Restricted Project
sfertile committed rG93faa237da8d: [PowerPC] Add Support for indirect calls on AIX. (authored by sfertile).
[PowerPC] Add Support for indirect calls on AIX.
Dec 13 2019, 5:08 PM

Dec 11 2019

sfertile added inline comments to D70724: [PowerPC] Add Support for indirect calls on AIX..
Dec 11 2019, 7:22 AM · Restricted Project
sfertile updated the diff for D70724: [PowerPC] Add Support for indirect calls on AIX..

Rebased, combined the ASM32 and OBJ32 checks that were the same into 1 ASMOBJ32 check label, moved comment on tabelgen InstrFormat member to the bh bits field.

Dec 11 2019, 7:17 AM · Restricted Project

Dec 10 2019

sfertile added a comment to D70570: [PowerPC] Only use PLT annotations if using PIC relocation model.

@MaskRay , @jhibbits Thank you for providing the correct ABI doc, and for the answers. I'll start going through it.

Dec 10 2019, 12:57 PM · Restricted Project
sfertile added a reviewer for D70570: [PowerPC] Only use PLT annotations if using PIC relocation model: sfertile.
Dec 10 2019, 10:18 AM · Restricted Project
sfertile added a comment to D70570: [PowerPC] Only use PLT annotations if using PIC relocation model.

This doesn't seem quite sufficient for FreeBSD kernel modules. It's emitting R_PPC_REL24 instead of R_PPC_ADDR16_HA/R_PPC_ADDR16_LO pairs for stuff like memset and memcpy,
which are unusable because we're running modules in KVA and the kernel text in the 32 bit DMAP. Still need to figure out why these are being emitted this way when using freestanding.

Dec 10 2019, 10:18 AM · Restricted Project
sfertile added a comment to D70570: [PowerPC] Only use PLT annotations if using PIC relocation model.

Hi Justin,

Dec 10 2019, 9:32 AM · Restricted Project
sfertile added inline comments to D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove.
Dec 10 2019, 7:56 AM · Restricted Project
sfertile added inline comments to D71013: [AIX] Allow vararg calls when all arguments reside in registers..
Dec 10 2019, 7:46 AM · Restricted Project

Dec 9 2019

sfertile updated the diff for D70724: [PowerPC] Add Support for indirect calls on AIX..
  • Fixed formatting in several places.
  • Fixed the added Instruction format and Ins of the new pseudo op. I had implemented as if the load were a DS form instruction instead of a D form instruction.
  • Collapsed the asm and obj lit testing checks together for the instructions where we don't care about the encoding (and the checks end up being the same between asm and binary output)
Dec 9 2019, 1:40 PM · Restricted Project
sfertile added a comment to rG94603ec11b55: [Parser] Don't crash on MS assembly if target desc/asm parser isn't linked in..

I believe this commit breaks a number of the build bots. eg: Arm , PowerPC

Dec 9 2019, 10:05 AM
sfertile committed rGc78726fae0ed: [PowerPC] Refactor FinishCall. [NFC] (authored by sfertile).
[PowerPC] Refactor FinishCall. [NFC]
Dec 9 2019, 9:47 AM
sfertile closed D70126: [PowerPC] Refactor FinishCall [NFC].
Dec 9 2019, 9:47 AM · Restricted Project

Dec 6 2019

sfertile added a comment to D70724: [PowerPC] Add Support for indirect calls on AIX..

Just noting here that the test does not actually enforce that r2 is saved before being written to. Similarly for the other tests.

Dec 6 2019, 3:21 PM · Restricted Project
sfertile updated the diff for D70724: [PowerPC] Add Support for indirect calls on AIX..
  • Removed all instruction encodings from the test, other then those that are expanded from the newly added pseudo instruction.
  • parameterized the scratch register used in the 64-bit asm.
Dec 6 2019, 2:34 PM · Restricted Project
sfertile added a comment to D71013: [AIX] Allow vararg calls when all arguments reside in registers..

clang-format the changes please.

Dec 6 2019, 6:29 AM · Restricted Project

Dec 5 2019

sfertile accepted D70937: [ELF][PPC64] Support long branch thunks with addends.

I have a couple minor questions, but it LGTM.

Dec 5 2019, 8:11 AM · Restricted Project

Dec 4 2019

sfertile added a comment to D70937: [ELF][PPC64] Support long branch thunks with addends.

Sorry for the wait, I was on vacation. I'm going over the related pr, D70637 and this patch right now.

Dec 4 2019, 10:28 AM · Restricted Project
sfertile updated the diff for D70724: [PowerPC] Add Support for indirect calls on AIX..

Addressed comments and added back missing tests.

Dec 4 2019, 6:53 AM · Restricted Project

Dec 3 2019

sfertile updated the diff for D70724: [PowerPC] Add Support for indirect calls on AIX..

Rebased.

Dec 3 2019, 4:10 PM · Restricted Project
sfertile added inline comments to D70126: [PowerPC] Refactor FinishCall [NFC].
Dec 3 2019, 3:51 PM · Restricted Project
sfertile updated the diff for D70126: [PowerPC] Refactor FinishCall [NFC].

Rebased to pick up recent changes to PPCISelLowering.cpp

Dec 3 2019, 3:51 PM · Restricted Project

Nov 29 2019

sfertile committed rG26ab827c24c8: [PowerPC][AIX] Add support for lowering int/float/double formal arguments. (authored by sfertile).
[PowerPC][AIX] Add support for lowering int/float/double formal arguments.
Nov 29 2019, 10:06 AM
sfertile closed D69578: [AIX] Add support for lowering int, float and double formal arguments..
Nov 29 2019, 10:06 AM · Restricted Project

Nov 27 2019

sfertile updated the diff for D70724: [PowerPC] Add Support for indirect calls on AIX..
  • Change targeted cpu in the test from pwr7 to pwr4.
  • Add testing of object file generation.
  • Change CHECK-NEXT directive to CHECK-DAG directive for instructions that can be scheduled differently.
  • Use a file check variable instead of hard-coded register for scratch register used to move the callee address into the count register.
Nov 27 2019, 5:56 PM · Restricted Project
sfertile updated the diff for D70126: [PowerPC] Refactor FinishCall [NFC].
  • Accidentally dropped the useful part of the previous suggested comment when rewording. Added it back.
  • Added a local variable set to the MVT for a gpr, and replaced several conditional operator uses with it.
  • Reworded another comment that made it sound like plt stubs save multiple things to the stack.
Nov 27 2019, 5:03 PM · Restricted Project
sfertile added a comment to D70126: [PowerPC] Refactor FinishCall [NFC].

Since this is a NFC patch, does it make sense to add NFC on patch title?

Nov 27 2019, 5:03 PM · Restricted Project
sfertile updated the summary of D70126: [PowerPC] Refactor FinishCall [NFC].
Nov 27 2019, 1:24 PM · Restricted Project
sfertile retitled D70126: [PowerPC] Refactor FinishCall [NFC] from [PowerPC] Refactor FinishCall to [PowerPC] Refactor FinishCall [NFC].
Nov 27 2019, 1:23 PM · Restricted Project
sfertile updated the diff for D70126: [PowerPC] Refactor FinishCall [NFC].
  • clang-formatted the patch.
  • Add back dropped comment (but reworded and expanded)
  • Added a local to replace several calls to Subtarget.isPPC64()
Nov 27 2019, 1:23 PM · Restricted Project
sfertile added inline comments to D70126: [PowerPC] Refactor FinishCall [NFC].
Nov 27 2019, 10:36 AM · Restricted Project

Nov 26 2019

sfertile updated the summary of D70724: [PowerPC] Add Support for indirect calls on AIX..
Nov 26 2019, 9:35 AM · Restricted Project
sfertile updated the summary of D70724: [PowerPC] Add Support for indirect calls on AIX..
Nov 26 2019, 9:35 AM · Restricted Project
sfertile created D70724: [PowerPC] Add Support for indirect calls on AIX..
Nov 26 2019, 9:35 AM · Restricted Project
sfertile updated the summary of D70724: [PowerPC] Add Support for indirect calls on AIX..
Nov 26 2019, 9:35 AM · Restricted Project
sfertile accepted D69578: [AIX] Add support for lowering int, float and double formal arguments..

Only a couple minor comments. Otherwise LGTM.

Nov 26 2019, 7:39 AM · Restricted Project

Nov 21 2019

sfertile added a comment to D70126: [PowerPC] Refactor FinishCall [NFC].

Ping.

Nov 21 2019, 9:35 AM · Restricted Project

Nov 19 2019

sfertile added a comment to D69578: [AIX] Add support for lowering int, float and double formal arguments..

Patch is very close. I've added a few inline comments on the test.

Nov 19 2019, 8:43 AM · Restricted Project

Nov 18 2019

sfertile accepted D70243: Lowering CPI/JTI/BA to assembly.

Other then the few nits I mentioned LGTM.

Nov 18 2019, 3:52 PM · Restricted Project
sfertile added inline comments to D69578: [AIX] Add support for lowering int, float and double formal arguments..
Nov 18 2019, 12:39 PM · Restricted Project
sfertile added inline comments to D70271: [AIX][XCOFF] Write Function descriptors and TOC base to data section.
Nov 18 2019, 12:21 PM · Restricted Project
sfertile added inline comments to D70243: Lowering CPI/JTI/BA to assembly.
Nov 18 2019, 10:31 AM · Restricted Project
sfertile added a comment to D70126: [PowerPC] Refactor FinishCall [NFC].

The new logic is much clearer, though it's hard to discern that the semantics remain correct because so much logic was redistributed. If a series of smaller commits were possible it would be easier to review.

Nov 18 2019, 9:11 AM · Restricted Project
sfertile updated the diff for D70126: [PowerPC] Refactor FinishCall [NFC].
  • Various spelling and punctuation fixes.
  • made 'buildCallOperands' static
  • Added a comment in the 'useFunctionDescriptors' querry.
  • renamed 'buildIndirectCall' and 'buildDescriptorIndirectCall' by changing 'build' to 'prepare' --> The helpers build the DAGs, setting up the call, but don't insert the call instruction itself so 'prepare' is a better description then 'build'.
Nov 18 2019, 9:11 AM · Restricted Project
sfertile accepted D70255: implement printing out raw section data of xcoff objectfile for llvm-objdump.

LGTM. A minor suggestion: we could use a test where one of the virtual sections, say .bss is larger then the object file. Similar to X86/elf-disassemble-bss.test.

Nov 18 2019, 7:33 AM · Restricted Project

Nov 14 2019

sfertile added inline comments to D69578: [AIX] Add support for lowering int, float and double formal arguments..
Nov 14 2019, 11:39 AM · Restricted Project
sfertile added inline comments to D70243: Lowering CPI/JTI/BA to assembly.
Nov 14 2019, 9:48 AM · Restricted Project

Nov 12 2019

sfertile updated the summary of D70126: [PowerPC] Refactor FinishCall [NFC].
Nov 12 2019, 7:41 AM · Restricted Project
sfertile created D70126: [PowerPC] Refactor FinishCall [NFC].
Nov 12 2019, 7:41 AM · Restricted Project

Nov 11 2019

sfertile committed rGe5e2e0a66b03: [PowerPC][XCOFF] Add support for zero initialized global values. (authored by sfertile).
[PowerPC][XCOFF] Add support for zero initialized global values.
Nov 11 2019, 4:00 PM
sfertile closed D69528: [PowerPC][XCOFF] Add assembly support for zero initalized global values..
Nov 11 2019, 4:00 PM · Restricted Project
sfertile added a comment to D69578: [AIX] Add support for lowering int, float and double formal arguments..

A couple high level comments on the tests.

Nov 11 2019, 9:36 AM · Restricted Project

Nov 8 2019

sfertile added a comment to D69578: [AIX] Add support for lowering int, float and double formal arguments..

Patch is getting pretty close, I am just going over the tests more thoroughly now. One observation for the gpr test: We have a lot of cases passing i8, but none passing i16.

Nov 8 2019, 12:16 PM · Restricted Project

Oct 30 2019

sfertile added inline comments to D69578: [AIX] Add support for lowering int, float and double formal arguments..
Oct 30 2019, 10:52 AM · Restricted Project

Oct 29 2019

sfertile added a comment to D67125: [PowerPC][AIX] Adds support for writing the data section in object files.

I don't think that initialized global data should be coming out as label symbols (everything appears to be contained in a ".data" csect). As I understand it only static data should be glob'd into one big csect, as per the XCOFF spec "An initialized definition for a global data scalar or structure ... is contained in its own csect". So each of these globals should have their own csect, which is the behavior exhibited by XLC.

I've observed that GCC on AIX is currently exhibiting this initalized-globals-in-one-csect behavior, but as we might expect, it interferes with the linkers ability to garbage collect unneeded global data.

I believe this is also an issue in the assembly path in D66154

As per out of band discussion, we will revisit this behavior under an option flag in a future revision and adopt the GCC behavior for now.

Oct 29 2019, 10:17 AM · Restricted Project
sfertile added inline comments to D67125: [PowerPC][AIX] Adds support for writing the data section in object files.
Oct 29 2019, 7:58 AM · Restricted Project
sfertile added a child revision for D67125: [PowerPC][AIX] Adds support for writing the data section in object files: D69528: [PowerPC][XCOFF] Add assembly support for zero initalized global values..
Oct 29 2019, 7:33 AM · Restricted Project
sfertile added a parent revision for D69528: [PowerPC][XCOFF] Add assembly support for zero initalized global values.: D67125: [PowerPC][AIX] Adds support for writing the data section in object files.
Oct 29 2019, 7:33 AM · Restricted Project
sfertile updated the diff for D69528: [PowerPC][XCOFF] Add assembly support for zero initalized global values..

Rebased to pick up test changes from D67125

Oct 29 2019, 7:30 AM · Restricted Project

Oct 28 2019

sfertile added a comment to D69528: [PowerPC][XCOFF] Add assembly support for zero initalized global values..

This patch is going to have conflict with D67125. Depending on which patch is going to go land first, the test case is likely need to get modified.

I would propose to let D67125 be the parent and add object file generation test in this patch.

Oct 28 2019, 7:26 PM · Restricted Project
sfertile created D69528: [PowerPC][XCOFF] Add assembly support for zero initalized global values..
Oct 28 2019, 1:20 PM · Restricted Project
sfertile accepted D69264: [AIX] Lowering CPI/JTI/BA to MIR.

LGTM.

Oct 28 2019, 12:23 PM · Restricted Project
sfertile committed rG582e3c09d487: [AIX] Refactor AIX Call Lowering to use CCState. NFCI. (authored by sfertile).
[AIX] Refactor AIX Call Lowering to use CCState. NFCI.
Oct 28 2019, 9:45 AM
sfertile closed D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI..
Oct 28 2019, 9:45 AM · Restricted Project

Oct 22 2019

sfertile added inline comments to D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI..
Oct 22 2019, 8:46 AM · Restricted Project

Oct 21 2019

sfertile added inline comments to D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI..
Oct 21 2019, 7:02 AM · Restricted Project

Oct 18 2019

sfertile added inline comments to D69112: [NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup.
Oct 18 2019, 10:30 AM · Restricted Project

Oct 11 2019

sfertile accepted D68815: [AIX] Use .space instead of .zero in assembly.

LGTM.

Oct 11 2019, 6:12 AM · Restricted Project

Oct 9 2019

sfertile committed rL374203: Request commit access for sfertile.
Request commit access for sfertile
Oct 9 2019, 12:35 PM

Oct 8 2019

sfertile added inline comments to D68341: [AIX] TOC pseudo expansion for 64bit large + 64bit small + 32bit large modes.
Oct 8 2019, 9:33 AM · Restricted Project
sfertile added inline comments to D67008: [llvm-readobj][XCOFF]implement parsing relocation information for 32-bit xcoff objectfile.
Oct 8 2019, 8:16 AM · Restricted Project