Page MenuHomePhabricator

sfertile (Sean Fertile)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2016, 8:15 AM (125 w, 6 h)

Recent Activity

Fri, Mar 8

sfertile added inline comments to D59048: Add AIX Target Info.
Fri, Mar 8, 8:01 AM · Restricted Project
sfertile accepted D58930: Add XCOFF triple object format type for AIX.

LGTM.

Fri, Mar 8, 7:46 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 6

sfertile added inline comments to D58930: Add XCOFF triple object format type for AIX.
Wed, Mar 6, 10:04 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 4

sfertile added a comment to D55501: [PPC64][PPC] add tests for R_PPC64_REL14 R_PPC_REL14.

Overall patch LGTM. Thanks for adding this. I have one small question about the llvm-readobj test though. IIUC the python file is used to generate the output files for test/tools/llvm-readobj/reloc-types.test. Do we need to run the python script to get the updated relocs.obj.elf-ppc64 file and update the checks for the added relocations in reloc-types.test?

Mon, Mar 4, 7:41 PM · Restricted Project

Thu, Feb 21

sfertile added inline comments to D58250: [AIX][CMake] Changes for building on AIX with XL and GCC.
Thu, Feb 21, 8:42 AM · Restricted Project

Feb 15 2019

sfertile added inline comments to D58250: [AIX][CMake] Changes for building on AIX with XL and GCC.
Feb 15 2019, 8:58 AM · Restricted Project

Feb 12 2019

sfertile committed rG9850a4827510: Fix undefined behaviour in PPCInstPrinter::printBranchOperand. (authored by sfertile).
Fix undefined behaviour in PPCInstPrinter::printBranchOperand.
Feb 12 2019, 12:03 PM
sfertile committed rL353874: Fix undefined behaviour in PPCInstPrinter::printBranchOperand..
Fix undefined behaviour in PPCInstPrinter::printBranchOperand.
Feb 12 2019, 12:02 PM
sfertile committed rG0205828be4f1: [PPC64] Update tests to reflect change in printing of call operand. [NFC] (authored by sfertile).
[PPC64] Update tests to reflect change in printing of call operand. [NFC]
Feb 12 2019, 9:50 AM
sfertile committed rGc06945202726: [PowerPC] Fix printing of negative offsets in call instruction dissasembly. (authored by sfertile).
[PowerPC] Fix printing of negative offsets in call instruction dissasembly.
Feb 12 2019, 9:49 AM
sfertile committed rL353866: [PPC64] Update tests to reflect change in printing of call operand. [NFC].
[PPC64] Update tests to reflect change in printing of call operand. [NFC]
Feb 12 2019, 9:48 AM
sfertile committed rLLD353866: [PPC64] Update tests to reflect change in printing of call operand. [NFC].
[PPC64] Update tests to reflect change in printing of call operand. [NFC]
Feb 12 2019, 9:48 AM
sfertile committed rL353865: [PowerPC] Fix printing of negative offsets in call instruction dissasembly..
[PowerPC] Fix printing of negative offsets in call instruction dissasembly.
Feb 12 2019, 9:48 AM
sfertile committed rLLD353849: [PPC64] Sort .toc sections accessed with small code model relocs..
[PPC64] Sort .toc sections accessed with small code model relocs.
Feb 12 2019, 7:37 AM
sfertile committed rGd694160e665e: [PPC64] Sort .toc sections accessed with small code model relocs. (authored by sfertile).
[PPC64] Sort .toc sections accessed with small code model relocs.
Feb 12 2019, 7:36 AM
sfertile committed rL353849: [PPC64] Sort .toc sections accessed with small code model relocs..
[PPC64] Sort .toc sections accessed with small code model relocs.
Feb 12 2019, 7:36 AM
sfertile closed D57245: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got part 2.
Feb 12 2019, 7:35 AM · Restricted Project

Feb 6 2019

sfertile added inline comments to D57245: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got part 2.
Feb 6 2019, 12:02 PM · Restricted Project

Feb 5 2019

Herald added a project to D57331: [PowerPC] Fix printing of negative offsets in call instruction dissasembly.: Restricted Project.

ping

Feb 5 2019, 8:50 AM · Restricted Project
sfertile added inline comments to D57673: [PPC64] Set the number of relocations processed for R_PPC64_TLS[GL]D to 2.
Feb 5 2019, 8:49 AM · Restricted Project

Feb 4 2019

sfertile accepted D57673: [PPC64] Set the number of relocations processed for R_PPC64_TLS[GL]D to 2.

LGTM other then 1 minor comment.

Feb 4 2019, 9:23 AM · Restricted Project
sfertile added a comment to D57673: [PPC64] Set the number of relocations processed for R_PPC64_TLS[GL]D to 2.

If this is allowed. Is there any restriction on the TLS code sequence? e.g. Is it allowed to omit R_PPC64_GOT_TLSGD16_HA?

Feb 4 2019, 8:41 AM · Restricted Project

Jan 31 2019

sfertile added inline comments to D54720: [PPC64] toc-indirect to toc-relative relaxation..
Jan 31 2019, 1:31 PM
sfertile added inline comments to D54720: [PPC64] toc-indirect to toc-relative relaxation..
Jan 31 2019, 9:46 AM
sfertile updated the diff for D54720: [PPC64] toc-indirect to toc-relative relaxation..

Addressed several review comments, and fixed bug where I was erroneously relaxing preepmtible symbols.

Jan 31 2019, 9:05 AM

Jan 30 2019

sfertile added inline comments to D57245: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got part 2.
Jan 30 2019, 10:50 AM · Restricted Project
sfertile updated the diff for D57245: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got part 2.

Updated /moved a few comments.

Jan 30 2019, 10:42 AM · Restricted Project

Jan 28 2019

sfertile retitled D57331: [PowerPC] Fix printing of negative offsets in call instruction dissasembly. from [PowerPC} Fix printing of negative offsets in call instruction dissasembly. to [PowerPC] Fix printing of negative offsets in call instruction dissasembly..
Jan 28 2019, 8:18 AM · Restricted Project
sfertile created D57331: [PowerPC] Fix printing of negative offsets in call instruction dissasembly..
Jan 28 2019, 8:18 AM · Restricted Project

Jan 25 2019

sfertile created D57245: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got part 2.
Jan 25 2019, 9:21 AM · Restricted Project

Jan 24 2019

sfertile added a comment to D54720: [PPC64] toc-indirect to toc-relative relaxation..

ping

Jan 24 2019, 7:20 PM
sfertile updated the diff for D54720: [PPC64] toc-indirect to toc-relative relaxation..

rebased

Jan 24 2019, 7:19 PM
sfertile committed rL352071: [PPC64] Reland r351978 'Sort .toc sections accessed with small code model ...'.
[PPC64] Reland r351978 'Sort .toc sections accessed with small code model ...'
Jan 24 2019, 10:17 AM
sfertile committed rLLD352071: [PPC64] Reland r351978 'Sort .toc sections accessed with small code model ...'.
[PPC64] Reland r351978 'Sort .toc sections accessed with small code model ...'
Jan 24 2019, 10:17 AM

Jan 23 2019

sfertile committed rLLD351985: Revert "[PPC64] Sort .toc sections accessed with small code model ...".
Revert "[PPC64] Sort .toc sections accessed with small code model ..."
Jan 23 2019, 1:46 PM
sfertile committed rL351985: Revert "[PPC64] Sort .toc sections accessed with small code model ...".
Revert "[PPC64] Sort .toc sections accessed with small code model ..."
Jan 23 2019, 1:46 PM
sfertile committed rLLD351978: [PPC64] Sort .toc sections accessed with small code model relocs close to .got..
[PPC64] Sort .toc sections accessed with small code model relocs close to .got.
Jan 23 2019, 1:04 PM
sfertile committed rL351978: [PPC64] Sort .toc sections accessed with small code model relocs close to .got..
[PPC64] Sort .toc sections accessed with small code model relocs close to .got.
Jan 23 2019, 1:04 PM
sfertile closed D56920: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got.
Jan 23 2019, 1:04 PM

Jan 22 2019

sfertile updated the diff for D56920: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got.

Addressed second round of review comments.

Jan 22 2019, 8:29 AM

Jan 21 2019

sfertile added inline comments to D56920: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got.
Jan 21 2019, 9:31 PM
sfertile updated the diff for D56920: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got.

Addressed review comments and cut down the test.

Jan 21 2019, 9:03 PM

Jan 18 2019

sfertile created D56920: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got.
Jan 18 2019, 9:56 AM

Jan 17 2019

sfertile updated the diff for D54720: [PPC64] toc-indirect to toc-relative relaxation..

Fixed look up to handle .toc sections that don't have a relocation for every entry and added a comprehensive test to verify we perform the correct optimization on all access types in this case.

Jan 17 2019, 10:13 AM

Jan 10 2019

sfertile committed rL350828: Modify InputSectionBase::getLocation to add section and offset to every loc..
Modify InputSectionBase::getLocation to add section and offset to every loc.
Jan 10 2019, 7:13 AM
sfertile committed rLLD350828: Modify InputSectionBase::getLocation to add section and offset to every loc..
Modify InputSectionBase::getLocation to add section and offset to every loc.
Jan 10 2019, 7:13 AM
sfertile closed D56453: Modify InputSectionBase::getLocation to add section and offset to every location string..
Jan 10 2019, 7:12 AM
sfertile committed rLLD350827: [PPC64] Fix RelType in checkInt and checkAlignment diagnsotics..
[PPC64] Fix RelType in checkInt and checkAlignment diagnsotics.
Jan 10 2019, 7:12 AM
sfertile committed rL350827: [PPC64] Fix RelType in checkInt and checkAlignment diagnsotics..
[PPC64] Fix RelType in checkInt and checkAlignment diagnsotics.
Jan 10 2019, 7:12 AM
sfertile closed D56448: [PPC64] Fix RelType in checkInt and checkAlignment diagnsotics..
Jan 10 2019, 7:12 AM

Jan 8 2019

sfertile added inline comments to D56453: Modify InputSectionBase::getLocation to add section and offset to every location string..
Jan 8 2019, 8:12 PM
sfertile created D56453: Modify InputSectionBase::getLocation to add section and offset to every location string..
Jan 8 2019, 1:30 PM
sfertile added inline comments to D56448: [PPC64] Fix RelType in checkInt and checkAlignment diagnsotics..
Jan 8 2019, 11:41 AM
sfertile created D56448: [PPC64] Fix RelType in checkInt and checkAlignment diagnsotics..
Jan 8 2019, 11:01 AM

Jan 7 2019

sfertile added inline comments to D54720: [PPC64] toc-indirect to toc-relative relaxation..
Jan 7 2019, 7:12 AM

Jan 3 2019

sfertile added inline comments to D54720: [PPC64] toc-indirect to toc-relative relaxation..
Jan 3 2019, 12:14 PM

Dec 31 2018

sfertile updated the diff for D54720: [PPC64] toc-indirect to toc-relative relaxation..

Forgot to update formatting in one of the tests.

Dec 31 2018, 9:26 AM
sfertile updated the diff for D54720: [PPC64] toc-indirect to toc-relative relaxation..

Addressed review comments

Dec 31 2018, 9:19 AM

Dec 27 2018

sfertile updated the diff for D54720: [PPC64] toc-indirect to toc-relative relaxation..

Moved the toc relaxation logic into the PPC64 target.

Dec 27 2018, 1:19 PM

Dec 24 2018

sfertile added a comment to D55498: [PPC64] Support R_PPC64_GOT16 Relocations.

This was already implemented in rL349511 and rL349772.
Thanks @sfertile and sorry for the noise.
I don't know if there are any notes here that are useful. --got-optimize ?

Dec 24 2018, 7:33 AM

Dec 20 2018

sfertile committed rLLD349772: [PPC64] Add toc-optimizations for got based relocations..
[PPC64] Add toc-optimizations for got based relocations.
Dec 20 2018, 9:05 AM
sfertile committed rL349772: [PPC64] Add toc-optimizations for got based relocations..
[PPC64] Add toc-optimizations for got based relocations.
Dec 20 2018, 9:04 AM
sfertile closed D54907: [PPC64] Support toc-optimization for '@got' relocations.
Dec 20 2018, 9:03 AM

Dec 18 2018

sfertile closed D54859: [PPC64] Support got relocations.

Committed: https://reviews.llvm.org/rLLD349511

Dec 18 2018, 9:46 AM
sfertile committed rL349511: [PPC64] Support got-based relocations..
[PPC64] Support got-based relocations.
Dec 18 2018, 9:38 AM
sfertile committed rLLD349511: [PPC64] Support got-based relocations..
[PPC64] Support got-based relocations.
Dec 18 2018, 9:38 AM
sfertile added a comment to D54859: [PPC64] Support got relocations.

Reminder for committing :)

Dec 18 2018, 7:18 AM
sfertile added inline comments to D53384: [PowerPC] Make no-PIC default to match GCC - CLANG.
Dec 18 2018, 7:17 AM

Dec 5 2018

sfertile added a comment to D54720: [PPC64] toc-indirect to toc-relative relaxation..

Related to @grimar comment, I am also playing around with doing some of the checking early and mapping toc based relocations that are not-relaxable to got based relocations during scanRelocs. Ideally I'd like to be able to add a separate step for PPC64 once all relocations have been scanned that will iterate over the .toc sections to handle large-code model where any symbols that can't be safely relaxed get added to the .got and all remaining toc based relocations get relaxed. This should hopefully allow me to get rid of the .toc sections in the final binaries, but I'm not familiar enough with large-code model, or gcc and xlc codegen to know if this is feasible yet.

Dec 5 2018, 8:45 AM

Dec 4 2018

sfertile added inline comments to D54720: [PPC64] toc-indirect to toc-relative relaxation..
Dec 4 2018, 7:17 AM
sfertile updated the diff for D54720: [PPC64] toc-indirect to toc-relative relaxation..

Addressed further review comments.

Dec 4 2018, 7:13 AM

Dec 3 2018

sfertile accepted D54868: [PPC][PPC64] PPC_REL14 and PPC64_REL14 relocations.

Other then my one comment it LGTM.

Dec 3 2018, 7:00 AM · lld

Nov 30 2018

sfertile accepted D54925: [NFC] [PowerPC] add an routine in PPCTargetLowering to determine if a global is accessed as got-indirect or not..

LGTM!

Nov 30 2018, 6:40 AM

Nov 29 2018

sfertile added inline comments to D54925: [NFC] [PowerPC] add an routine in PPCTargetLowering to determine if a global is accessed as got-indirect or not..
Nov 29 2018, 10:28 AM

Nov 26 2018

sfertile created D54907: [PPC64] Support toc-optimization for '@got' relocations.
Nov 26 2018, 10:08 AM
sfertile added inline comments to D54859: [PPC64] Support got relocations.
Nov 26 2018, 9:02 AM

Nov 23 2018

sfertile created D54859: [PPC64] Support got relocations.
Nov 23 2018, 6:14 AM

Nov 22 2018

sfertile added inline comments to D54720: [PPC64] toc-indirect to toc-relative relaxation..
Nov 22 2018, 10:46 AM
sfertile updated the diff for D54720: [PPC64] toc-indirect to toc-relative relaxation..

Addressed initial review comments.

Nov 22 2018, 10:44 AM

Nov 19 2018

sfertile updated the diff for D54720: [PPC64] toc-indirect to toc-relative relaxation..

Added full context

Nov 19 2018, 1:23 PM
sfertile added a comment to D54720: [PPC64] toc-indirect to toc-relative relaxation..

Zaara pointed out I am missing the full context, I'll re post the patch with the context fixed shortly.

Nov 19 2018, 1:05 PM
sfertile created D54720: [PPC64] toc-indirect to toc-relative relaxation..
Nov 19 2018, 12:54 PM

Nov 16 2018

sfertile accepted D53384: [PowerPC] Make no-PIC default to match GCC - CLANG.

LGTM

Nov 16 2018, 10:23 AM

Nov 14 2018

sfertile committed rLLD346877: [PPC64] Long branch thunks..
[PPC64] Long branch thunks.
Nov 14 2018, 9:59 AM
sfertile committed rLLD346876: [NFC] Change address __tls_getaddr is defined at so it does not need a thunk..
[NFC] Change address __tls_getaddr is defined at so it does not need a thunk.
Nov 14 2018, 9:59 AM
sfertile committed rL346877: [PPC64] Long branch thunks..
[PPC64] Long branch thunks.
Nov 14 2018, 9:59 AM
sfertile closed D53408: [PPC64] Long branch thunks. .
Nov 14 2018, 9:59 AM · lld
sfertile committed rL346876: [NFC] Change address __tls_getaddr is defined at so it does not need a thunk..
[NFC] Change address __tls_getaddr is defined at so it does not need a thunk.
Nov 14 2018, 9:59 AM

Nov 13 2018

sfertile accepted D53383: [PowerPC] Make no-PIC default to match GCC - LLVM .

I definitely agree we need to fix the PIC by default behavior, PIC implies we need to produce code suitable for a shared object and that has a number of unneeded limitations. I tried to figure out what we are doing differently between pie and static relocation models but don't see much difference.
For the most part we happen to do the same thing, for example the default isOffsetFoldingLegal depends on position-dependence but the PPCTargetLowering overrides it to always return false, we always produce relative jump-tables for ppc64 regardless of the relocation mode, we always use TOC-pointer relative addressing for module local symbols regardles of relocation model . The one difference I did find is TargetLoweringObjectFile::getKindForGlobal although that line looks wrong to me. Static binaries can still link against shared objects. Globals/functions defined in those will not have their addresses resolved at link time, unless maybe this is only a problem on ppc since we don't use copy relocs? (I believe the original PIC by default change was motivated by this but without a clear example I'm not sure why ...). I don't like using the fact there is (or was) bad codegen for the static relocation model as reasoning for picking pie as the default, that bad codegen comes back if the user adds -fno-pie as an option.

Nov 13 2018, 1:10 PM

Nov 8 2018

sfertile updated the diff for D53408: [PPC64] Long branch thunks. .

Added separate index for use in the branch_lt section and added comment on how we will end up with an empty branch_lt section due removing empty synthetic sections before thunk allocation.

Nov 8 2018, 9:14 AM · lld

Nov 7 2018

sfertile accepted D54200: [PPC64] Use INT32_MIN instead of std::numeric_limits<int32_t>::min().

LGTM

Nov 7 2018, 11:22 AM

Oct 30 2018

sfertile added inline comments to D53601: [GCOV] Add a test for function defined on one line (follow-up of https://reviews.llvm.org/D53600).
Oct 30 2018, 1:20 PM
sfertile committed rL345604: [PPC64] Handle powerpc64 in OUTPUT_FORMAT..
[PPC64] Handle powerpc64 in OUTPUT_FORMAT.
Oct 30 2018, 7:41 AM
sfertile committed rLLD345604: [PPC64] Handle powerpc64 in OUTPUT_FORMAT..
[PPC64] Handle powerpc64 in OUTPUT_FORMAT.
Oct 30 2018, 7:40 AM
sfertile closed D53652: [PPC64] Handle powerpc64 in OUTPUT_FORMAT.
Oct 30 2018, 7:40 AM
sfertile added a comment to D53652: [PPC64] Handle powerpc64 in OUTPUT_FORMAT.

Hi... can you commit

Oct 30 2018, 7:18 AM

Oct 29 2018

sfertile accepted D53821: [ELF][PPC64]Workaround bogus Visual Studio build warning.

Thanks for cleaning this up. LGTM.

Oct 29 2018, 9:56 AM

Oct 25 2018

sfertile added inline comments to D53384: [PowerPC] Make no-PIC default to match GCC - CLANG.
Oct 25 2018, 6:55 AM

Oct 24 2018

sfertile added inline comments to D53408: [PPC64] Long branch thunks. .
Oct 24 2018, 1:19 PM · lld
sfertile added inline comments to D53408: [PPC64] Long branch thunks. .
Oct 24 2018, 12:42 PM · lld