sfertile (Sean Fertile)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2016, 8:15 AM (103 w, 6 d)

Recent Activity

Thu, Oct 18

sfertile abandoned D49795: [PPC64] Position-independent long-branch thunks..

Abandoned in favour of https://reviews.llvm.org/D53408

Thu, Oct 18, 12:30 PM
sfertile abandoned D50097: [PPC64] Position-dependent long-branch thunks..

Abandoned in favor of [[ https://reviews.llvm.org/D53408 | [PPC64] Long branch thunks. ]]

Thu, Oct 18, 12:29 PM
sfertile created D53408: [PPC64] Long branch thunks. .
Thu, Oct 18, 12:27 PM · lld
sfertile committed rLLD344747: [PPC64] Fix offset checks on rel24 call relocations..
[PPC64] Fix offset checks on rel24 call relocations.
Thu, Oct 18, 8:46 AM
sfertile committed rL344747: [PPC64] Fix offset checks on rel24 call relocations..
[PPC64] Fix offset checks on rel24 call relocations.
Thu, Oct 18, 8:45 AM
sfertile closed D53401: [PPC64] Fix offset checks on rel24 call relocations..
Thu, Oct 18, 8:45 AM · lld
sfertile created D53401: [PPC64] Fix offset checks on rel24 call relocations..
Thu, Oct 18, 7:57 AM · lld

Tue, Oct 16

sfertile committed rLLD344622: Reland "[PPC64] Add split - stack support.".
Reland "[PPC64] Add split - stack support."
Tue, Oct 16, 10:16 AM
sfertile committed rL344622: Reland "[PPC64] Add split - stack support.".
Reland "[PPC64] Add split - stack support."
Tue, Oct 16, 10:15 AM

Mon, Oct 15

sfertile committed rLLD344551: Revert "[PPC64] Add split - stack support.".
Revert "[PPC64] Add split - stack support."
Mon, Oct 15, 1:23 PM
sfertile committed rL344551: Revert "[PPC64] Add split - stack support.".
Revert "[PPC64] Add split - stack support."
Mon, Oct 15, 1:23 PM
sfertile committed rLLD344544: [PPC64] Add split - stack support..
[PPC64] Add split - stack support.
Mon, Oct 15, 12:08 PM
sfertile committed rL344544: [PPC64] Add split - stack support..
[PPC64] Add split - stack support.
Mon, Oct 15, 12:08 PM
sfertile closed D52099: [PPC64] Add split-stack support..
Mon, Oct 15, 12:07 PM
sfertile added a comment to rL344150: [CodeGenCXX] Treat 'this' as noalias in constructors.

Reverted in https://reviews.llvm.org/rL344526 until we can figure this out.

Mon, Oct 15, 8:57 AM
sfertile committed rC344526: Revert "[CodeGenCXX] Treat 'this' as noalias in constructors".
Revert "[CodeGenCXX] Treat 'this' as noalias in constructors"
Mon, Oct 15, 8:46 AM
sfertile committed rL344526: Revert "[CodeGenCXX] Treat 'this' as noalias in constructors".
Revert "[CodeGenCXX] Treat 'this' as noalias in constructors"
Mon, Oct 15, 8:45 AM

Thu, Oct 11

sfertile added a comment to rL344234: clang-cl: Add /showFilenames option (PR31957).

I've reverted this for now.

Thu, Oct 11, 11:54 AM
sfertile committed rL344276: Revert "clang-cl: Add /showFilenames option (PR31957)".
Revert "clang-cl: Add /showFilenames option (PR31957)"
Thu, Oct 11, 11:42 AM
sfertile committed rC344276: Revert "clang-cl: Add /showFilenames option (PR31957)".
Revert "clang-cl: Add /showFilenames option (PR31957)"
Thu, Oct 11, 11:42 AM
sfertile added a comment to rL344234: clang-cl: Add /showFilenames option (PR31957).

This test is failing on the powerpc bots as well as hexagon and s390x:
http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/20815
http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/20534

Thu, Oct 11, 10:18 AM

Thu, Oct 4

sfertile added a comment to D49795: [PPC64] Position-independent long-branch thunks..

This patch seems a bit too intrusive to me, but I'm not sure if it is unavoidable (and thus this is a straightforward implementation) or there's another way to implement it.

Thu, Oct 4, 12:45 PM
sfertile added inline comments to D52099: [PPC64] Add split-stack support..
Thu, Oct 4, 9:24 AM
sfertile updated the diff for D52099: [PPC64] Add split-stack support..

Removed extra space in comment, and incorrect assert.

Thu, Oct 4, 9:18 AM

Wed, Oct 3

sfertile committed rL343729: [PPC64] Test documenting toc-restore after interposable recursive call. [NFC].
[PPC64] Test documenting toc-restore after interposable recursive call. [NFC]
Wed, Oct 3, 3:02 PM
sfertile committed rL343728: [PPC64] Add test documenting toc-restore when linking with -Bsymbolic. [NFC].
[PPC64] Add test documenting toc-restore when linking with -Bsymbolic. [NFC]
Wed, Oct 3, 3:02 PM
sfertile committed rLLD343729: [PPC64] Test documenting toc-restore after interposable recursive call. [NFC].
[PPC64] Test documenting toc-restore after interposable recursive call. [NFC]
Wed, Oct 3, 3:02 PM
sfertile closed D52564: [PPC64] Add test for toc-restore on recursive call..
Wed, Oct 3, 3:02 PM · lld
sfertile committed rLLD343728: [PPC64] Add test documenting toc-restore when linking with -Bsymbolic. [NFC].
[PPC64] Add test documenting toc-restore when linking with -Bsymbolic. [NFC]
Wed, Oct 3, 3:02 PM
sfertile closed D52523: [PPC64] Add test documenting toc-restore behaviour with -Bsymbolic option. [NFC].
Wed, Oct 3, 3:02 PM
sfertile added inline comments to D49795: [PPC64] Position-independent long-branch thunks..
Wed, Oct 3, 12:23 PM

Fri, Sep 28

sfertile added inline comments to D52564: [PPC64] Add test for toc-restore on recursive call..
Fri, Sep 28, 10:10 AM · lld

Wed, Sep 26

sfertile added inline comments to D52564: [PPC64] Add test for toc-restore on recursive call..
Wed, Sep 26, 1:47 PM · lld
sfertile created D52564: [PPC64] Add test for toc-restore on recursive call..
Wed, Sep 26, 11:10 AM · lld

Tue, Sep 25

sfertile created D52523: [PPC64] Add test documenting toc-restore behaviour with -Bsymbolic option. [NFC].
Tue, Sep 25, 3:46 PM

Sep 19 2018

sfertile committed rL342604: [PPC64] Handle ppc64le triple in getBitcodeMachineKind..
[PPC64] Handle ppc64le triple in getBitcodeMachineKind.
Sep 19 2018, 5:28 PM
sfertile committed rL342603: [PPC64] Helper for offset from a function's global entry to local entry. [NFC].
[PPC64] Helper for offset from a function's global entry to local entry. [NFC]
Sep 19 2018, 5:28 PM
sfertile committed rLLD342604: [PPC64] Handle ppc64le triple in getBitcodeMachineKind..
[PPC64] Handle ppc64le triple in getBitcodeMachineKind.
Sep 19 2018, 5:28 PM
sfertile committed rLLD342603: [PPC64] Helper for offset from a function's global entry to local entry. [NFC].
[PPC64] Helper for offset from a function's global entry to local entry. [NFC]
Sep 19 2018, 5:28 PM
sfertile closed D52265: [PPC64] handle ppc64le triple in getBitcodeMachineKind.
Sep 19 2018, 5:28 PM
sfertile closed D52231: [PPC64] Add helper for calculating the offset from a functions global entry to its local entry. [NFC].
Sep 19 2018, 5:28 PM
sfertile committed rLLD342602: [PPC64] Optimize redundant instructions in global access sequences..
[PPC64] Optimize redundant instructions in global access sequences.
Sep 19 2018, 5:28 PM
sfertile committed rL342602: [PPC64] Optimize redundant instructions in global access sequences..
[PPC64] Optimize redundant instructions in global access sequences.
Sep 19 2018, 5:28 PM
sfertile closed D49237: [PPC64] Optimize redundant instructions using R_PPC64_TOC16_HA in nop.
Sep 19 2018, 5:28 PM
sfertile created D52265: [PPC64] handle ppc64le triple in getBitcodeMachineKind.
Sep 19 2018, 6:44 AM

Sep 18 2018

sfertile updated the summary of D52099: [PPC64] Add split-stack support..
Sep 18 2018, 7:13 PM
sfertile updated the diff for D52099: [PPC64] Add split-stack support..
  • Added an explanation of the expected prologue instructions and how the linker is supposed to modify them.
  • Add check for overflow on the adjusted stack size
  • Add check that the register operands are the expected ones.
  • Changed global-entry to local-entry offset calculation to use new helper function.
Sep 18 2018, 7:09 PM
sfertile created D52231: [PPC64] Add helper for calculating the offset from a functions global entry to its local entry. [NFC].
Sep 18 2018, 7:02 AM
sfertile added inline comments to D52099: [PPC64] Add split-stack support..
Sep 18 2018, 7:02 AM
sfertile retitled D52231: [PPC64] Add helper for calculating the offset from a functions global entry to its local entry. [NFC] from [PPC64] Add helper for calculating the offset from a functions global entry to its local entry. to [PPC64] Add helper for calculating the offset from a functions global entry to its local entry. [NFC].
Sep 18 2018, 7:02 AM

Sep 17 2018

sfertile added inline comments to D49237: [PPC64] Optimize redundant instructions using R_PPC64_TOC16_HA in nop.
Sep 17 2018, 2:27 PM
sfertile updated the diff for D49237: [PPC64] Optimize redundant instructions using R_PPC64_TOC16_HA in nop.

Moved checking of OPT_toc_optimise until after the machine has been decided and made it default to on only for PowerPC64.

Sep 17 2018, 2:24 PM
sfertile added inline comments to D52055: [PPC64] Support relaxing R_PPC64_TLSGD16 in TlsGdtoLe relaxation.
Sep 17 2018, 2:05 PM
sfertile committed rLLD342411: [PPC64] Support relaxing R_PPC64_TLSGD16 in TlsGdtoLe relaxation..
[PPC64] Support relaxing R_PPC64_TLSGD16 in TlsGdtoLe relaxation.
Sep 17 2018, 1:28 PM
sfertile committed rL342411: [PPC64] Support relaxing R_PPC64_TLSGD16 in TlsGdtoLe relaxation..
[PPC64] Support relaxing R_PPC64_TLSGD16 in TlsGdtoLe relaxation.
Sep 17 2018, 1:28 PM
sfertile committed rL342410: [PPC64] Helpers for read/write an instr while relocating a half16 type. [NFC].
[PPC64] Helpers for read/write an instr while relocating a half16 type. [NFC]
Sep 17 2018, 1:28 PM
sfertile closed D52055: [PPC64] Support relaxing R_PPC64_TLSGD16 in TlsGdtoLe relaxation.
Sep 17 2018, 1:28 PM
sfertile committed rLLD342410: [PPC64] Helpers for read/write an instr while relocating a half16 type. [NFC].
[PPC64] Helpers for read/write an instr while relocating a half16 type. [NFC]
Sep 17 2018, 1:28 PM
sfertile closed D52115: [PPC64] Add helpers for read/writing an instruction while relocating a half16 type. [NFC].
Sep 17 2018, 1:28 PM
sfertile added a comment to D52124: [ELF][test] Use llvm-readelf's short option -r instead of -relocations and remove ignored --wide.

Thanks for doing this. I didn't realize we got the wide behavior by default with llvm-readelf.

Sep 17 2018, 12:09 PM

Sep 14 2018

sfertile updated the diff for D49237: [PPC64] Optimize redundant instructions using R_PPC64_TOC16_HA in nop.

Addressed initial comments.

Sep 14 2018, 12:25 PM
sfertile created D52115: [PPC64] Add helpers for read/writing an instruction while relocating a half16 type. [NFC].
Sep 14 2018, 12:02 PM
sfertile added inline comments to D52099: [PPC64] Add split-stack support..
Sep 14 2018, 11:31 AM
sfertile created D52099: [PPC64] Add split-stack support..
Sep 14 2018, 8:27 AM

Sep 13 2018

sfertile created D52055: [PPC64] Support relaxing R_PPC64_TLSGD16 in TlsGdtoLe relaxation.
Sep 13 2018, 1:04 PM

Sep 5 2018

sfertile added a comment to D46204: [PPC64] V2 abi: Emit plt call stubs to the text section rather then the plt section. .

Thanks for digging up that comment, its nice to know.

Sep 5 2018, 11:21 AM

Sep 4 2018

sfertile added a comment to D46204: [PPC64] V2 abi: Emit plt call stubs to the text section rather then the plt section. .

A bit more info here since the fact the call to _ZNKSt6locale2id5_M_idEv is a recursive call makes the situation a bit more muddy. I tested this with an older gcc version (5.4.0) and a newer version (7.3.1 from advanced toolchain 11). The newer compiler will emit a nop after a recursive call if the function is interposable, while the older compiler skips the nop. The linkers from the older toolchain (gold and bfd from binutils 2.26) both use plt stubs for the recursive call, and will rewrite the following nop to a toc-restore if the nop is there. I think lld behavior to emit a fatal error when trying to link _ZNKSt6locale2id5_M_idEv into a shared object is the correct one.

Sep 4 2018, 1:19 PM

Aug 31 2018

sfertile added inline comments to D46204: [PPC64] V2 abi: Emit plt call stubs to the text section rather then the plt section. .
Aug 31 2018, 9:01 AM
sfertile added inline comments to D46204: [PPC64] V2 abi: Emit plt call stubs to the text section rather then the plt section. .
Aug 31 2018, 8:42 AM

Aug 30 2018

sfertile added inline comments to D46204: [PPC64] V2 abi: Emit plt call stubs to the text section rather then the plt section. .
Aug 30 2018, 10:05 AM

Aug 28 2018

sfertile committed rLLD340832: [PPC64] Fix DQ-form instruction handling and emit error for misalignment..
[PPC64] Fix DQ-form instruction handling and emit error for misalignment.
Aug 28 2018, 8:17 AM
sfertile committed rL340832: [PPC64] Fix DQ-form instruction handling and emit error for misalignment..
[PPC64] Fix DQ-form instruction handling and emit error for misalignment.
Aug 28 2018, 8:17 AM

Aug 27 2018

sfertile added inline comments to D51122: [PowerPC][MC] Support expressions in getMemRIX16Encoding.
Aug 27 2018, 10:45 AM
sfertile committed rL340761: [PowerPC][MC] Support expressions in getMemRIX16Encoding..
[PowerPC][MC] Support expressions in getMemRIX16Encoding.
Aug 27 2018, 10:38 AM
sfertile closed D51122: [PowerPC][MC] Support expressions in getMemRIX16Encoding.
Aug 27 2018, 10:38 AM
sfertile accepted D50965: [PowerPC] Fix label address calculation for ppc64.

LGTM with a few minor comments about the test.

Aug 27 2018, 8:23 AM

Aug 24 2018

sfertile updated the diff for D49237: [PPC64] Optimize redundant instructions using R_PPC64_TOC16_HA in nop.
  • Error when optimizing an updated form load or store.
  • Add an option that can disable the toc optimization.
  • Expand the testing.
Aug 24 2018, 11:18 AM

Aug 23 2018

sfertile committed rLLD340568: Revert "[PPC64] Fix DQ-form instruction handling and emit error for misalign...".
Revert "[PPC64] Fix DQ-form instruction handling and emit error for misalign..."
Aug 23 2018, 12:11 PM
sfertile committed rL340568: Revert "[PPC64] Fix DQ-form instruction handling and emit error for misalign...".
Revert "[PPC64] Fix DQ-form instruction handling and emit error for misalign..."
Aug 23 2018, 12:11 PM
sfertile committed rL340564: [PPC64] Fix DQ-form instruction handling and emit error for misalignment..
[PPC64] Fix DQ-form instruction handling and emit error for misalignment.
Aug 23 2018, 11:36 AM
sfertile committed rLLD340564: [PPC64] Fix DQ-form instruction handling and emit error for misalignment..
[PPC64] Fix DQ-form instruction handling and emit error for misalignment.
Aug 23 2018, 11:36 AM
sfertile closed D51124: [PPC64] Fix DQ-form instruction handeling and emit error for misalignment on a *_DS relocations.
Aug 23 2018, 11:35 AM

Aug 22 2018

sfertile created D51124: [PPC64] Fix DQ-form instruction handeling and emit error for misalignment on a *_DS relocations.
Aug 22 2018, 1:16 PM
sfertile created D51122: [PowerPC][MC] Support expressions in getMemRIX16Encoding.
Aug 22 2018, 1:05 PM

Aug 20 2018

sfertile added a comment to D49795: [PPC64] Position-independent long-branch thunks..

ping

Aug 20 2018, 11:32 AM
sfertile added a comment to D50097: [PPC64] Position-dependent long-branch thunks..

ping

Aug 20 2018, 11:32 AM
sfertile commandeered D49237: [PPC64] Optimize redundant instructions using R_PPC64_TOC16_HA in nop.

I've picked this up from @syzaara. I'll post a revised patch shortly.

Aug 20 2018, 11:31 AM

Jul 31 2018

sfertile updated subscribers of D40425: Extending CFGPrinter and CallPrinter with Heat Colors.

Except for the bug detected by the sanitizer, which seems to be related to the old pass manager, this patch is ready to be committed.

Jul 31 2018, 1:17 PM
sfertile added a comment to D49237: [PPC64] Optimize redundant instructions using R_PPC64_TOC16_HA in nop.

Overall I think the patch looks good, but we should expand the ppc64-toc-addis-nop.s test to cover all the different sequences this will affect (like loading bytes/half-word/word signed and unsigned etc).

Jul 31 2018, 12:59 PM
sfertile created D50097: [PPC64] Position-dependent long-branch thunks..
Jul 31 2018, 12:06 PM

Jul 25 2018

sfertile retitled D49795: [PPC64] Position-independent long-branch thunks. from [PPC64] Position-indepenent long-branch thunks. to [PPC64] Position-independent long-branch thunks..
Jul 25 2018, 8:03 AM
sfertile created D49795: [PPC64] Position-independent long-branch thunks..
Jul 25 2018, 6:10 AM

Jul 23 2018

sfertile added inline comments to D48091: [PPC64] Add TLS initial exec to local exec relaxation.
Jul 23 2018, 10:49 AM

Jul 17 2018

sfertile added inline comments to D49424: [PowerPC] Handle __builtin_xxpermdi the same way as GCC does.
Jul 17 2018, 6:23 PM

Jul 11 2018

sfertile added a comment to rL336000: Revert "Extend CFGPrinter and CallPrinter with Heat Colors".

Tested the above change out on my laptop and if it fixes the leak failure. I'm going to see if I can reproduce the problem in another pass and open a bugzilla if I can reproduce it.

Jul 11 2018, 5:47 AM

Jul 10 2018

sfertile added a comment to rL336000: Revert "Extend CFGPrinter and CallPrinter with Heat Colors".

@rcorcs i t looks like simply changing the order of the addRequired to put BPI before BFI fixes the reported leak:

diff --git a/lib/Analysis/CFGPrinter.cpp b/lib/Analysis/CFGPrinter.cpp
index 10be4e4..396f352 100644
--- a/lib/Analysis/CFGPrinter.cpp
+++ b/lib/Analysis/CFGPrinter.cpp
@@ -228,8 +228,8 @@ namespace {
Jul 10 2018, 8:46 AM
sfertile added a comment to rL336000: Revert "Extend CFGPrinter and CallPrinter with Heat Colors".

I've been looking into the sanitizer build-bot failure and the address sanitizer detects a leak in the old-pass manager. One of my team members encountered this same problem before, where a seemingly unrelated change caused the address sanitize to detect a leak in the old pass manger. I am hoping to get a chance to look at it closer tonight to see if there is a real problem or not.

Jul 10 2018, 6:51 AM
sfertile added a comment to rL336000: Revert "Extend CFGPrinter and CallPrinter with Heat Colors".

Hi,

I've fixed the graph printing in Polly.

Should I create a separate patch for Polly?

Thanks.

Jul 10 2018, 6:44 AM

Jul 9 2018

sfertile added a comment to D49039: [BitcodeReader] Infer the correct runtime preemption for GlobalValue.

Thanks for doing this!

Jul 9 2018, 7:37 AM

Jun 29 2018

sfertile added a comment to D40425: Extending CFGPrinter and CallPrinter with Heat Colors.

Unfortunately I had to revert this (https://reviews.llvm.org/rL336000) since there were several build-bot breaks.

Jun 29 2018, 12:29 PM