sfertile (Sean Fertile)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2016, 8:15 AM (95 w, 23 h)

Recent Activity

Yesterday

sfertile added a comment to D49795: [PPC64] Position-independent long-branch thunks..

ping

Mon, Aug 20, 11:32 AM
sfertile added a comment to D50097: [PPC64] Position-dependent long-branch thunks..

ping

Mon, Aug 20, 11:32 AM
sfertile commandeered D49237: [PPC64] Optimize redundant instructions using R_PPC64_TOC16_HA in nop.

I've picked this up from @syzaara. I'll post a revised patch shortly.

Mon, Aug 20, 11:31 AM

Tue, Jul 31

sfertile updated subscribers of D40425: Extending CFGPrinter and CallPrinter with Heat Colors.

Except for the bug detected by the sanitizer, which seems to be related to the old pass manager, this patch is ready to be committed.

Tue, Jul 31, 1:17 PM
sfertile added a comment to D49237: [PPC64] Optimize redundant instructions using R_PPC64_TOC16_HA in nop.

Overall I think the patch looks good, but we should expand the ppc64-toc-addis-nop.s test to cover all the different sequences this will affect (like loading bytes/half-word/word signed and unsigned etc).

Tue, Jul 31, 12:59 PM
sfertile created D50097: [PPC64] Position-dependent long-branch thunks..
Tue, Jul 31, 12:06 PM

Wed, Jul 25

sfertile retitled D49795: [PPC64] Position-independent long-branch thunks. from [PPC64] Position-indepenent long-branch thunks. to [PPC64] Position-independent long-branch thunks..
Wed, Jul 25, 8:03 AM
sfertile created D49795: [PPC64] Position-independent long-branch thunks..
Wed, Jul 25, 6:10 AM

Mon, Jul 23

sfertile added inline comments to D48091: [PPC64] Add TLS initial exec to local exec relaxation.
Mon, Jul 23, 10:49 AM

Jul 17 2018

sfertile added inline comments to D49424: [PowerPC] Handle __builtin_xxpermdi the same way as GCC does.
Jul 17 2018, 6:23 PM

Jul 11 2018

sfertile added a comment to rL336000: Revert "Extend CFGPrinter and CallPrinter with Heat Colors".

Tested the above change out on my laptop and if it fixes the leak failure. I'm going to see if I can reproduce the problem in another pass and open a bugzilla if I can reproduce it.

Jul 11 2018, 5:47 AM

Jul 10 2018

sfertile added a comment to rL336000: Revert "Extend CFGPrinter and CallPrinter with Heat Colors".

@rcorcs i t looks like simply changing the order of the addRequired to put BPI before BFI fixes the reported leak:

diff --git a/lib/Analysis/CFGPrinter.cpp b/lib/Analysis/CFGPrinter.cpp
index 10be4e4..396f352 100644
--- a/lib/Analysis/CFGPrinter.cpp
+++ b/lib/Analysis/CFGPrinter.cpp
@@ -228,8 +228,8 @@ namespace {
Jul 10 2018, 8:46 AM
sfertile added a comment to rL336000: Revert "Extend CFGPrinter and CallPrinter with Heat Colors".

I've been looking into the sanitizer build-bot failure and the address sanitizer detects a leak in the old-pass manager. One of my team members encountered this same problem before, where a seemingly unrelated change caused the address sanitize to detect a leak in the old pass manger. I am hoping to get a chance to look at it closer tonight to see if there is a real problem or not.

Jul 10 2018, 6:51 AM
sfertile added a comment to rL336000: Revert "Extend CFGPrinter and CallPrinter with Heat Colors".

Hi,

I've fixed the graph printing in Polly.

Should I create a separate patch for Polly?

Thanks.

Jul 10 2018, 6:44 AM

Jul 9 2018

sfertile added a comment to D49039: [BitcodeReader] Infer the correct runtime preemption for GlobalValue.

Thanks for doing this!

Jul 9 2018, 7:37 AM

Jun 29 2018

sfertile added a comment to D40425: Extending CFGPrinter and CallPrinter with Heat Colors.

Unfortunately I had to revert this (https://reviews.llvm.org/rL336000) since there were several build-bot breaks.

Jun 29 2018, 12:29 PM
sfertile committed rL336000: Revert "Extend CFGPrinter and CallPrinter with Heat Colors".
Revert "Extend CFGPrinter and CallPrinter with Heat Colors"
Jun 29 2018, 10:53 AM
sfertile committed rL335996: Extend CFGPrinter and CallPrinter with Heat Colors.
Extend CFGPrinter and CallPrinter with Heat Colors
Jun 29 2018, 10:19 AM
sfertile closed D40425: Extending CFGPrinter and CallPrinter with Heat Colors.
Jun 29 2018, 10:18 AM
sfertile added a comment to D40425: Extending CFGPrinter and CallPrinter with Heat Colors.

I've just noticed that last time I uploaded the wrong diff.

This is the actual diff that fixes all conflicts with the latest LLVM version.

Jun 29 2018, 9:26 AM

Jun 28 2018

sfertile added inline comments to rL327871: [ELF] Add basic support for PPC LE.
Jun 28 2018, 7:20 PM

Jun 27 2018

sfertile added inline comments to D48293: [PPC64] Add TLS local dynamic to local exec relaxation.
Jun 27 2018, 9:10 AM
sfertile added inline comments to D48091: [PPC64] Add TLS initial exec to local exec relaxation.
Jun 27 2018, 8:55 AM

Jun 26 2018

sfertile committed rL335651: [PPC64] Thread-local storage general-dynamic to initial-exec relaxation..
[PPC64] Thread-local storage general-dynamic to initial-exec relaxation.
Jun 26 2018, 12:43 PM
sfertile committed rLLD335651: [PPC64] Thread-local storage general-dynamic to initial-exec relaxation..
[PPC64] Thread-local storage general-dynamic to initial-exec relaxation.
Jun 26 2018, 12:43 PM
sfertile closed D48090: [PPC64] global dynamic to initial exec relaxation.
Jun 26 2018, 12:42 PM

Jun 25 2018

sfertile updated the diff for D48090: [PPC64] global dynamic to initial exec relaxation.
  • clang formatted patch
  • Switched the relax RelExpr to one that calculates a got-offset.
  • used relocateOne to make it clearer what we were relaxing to.
  • updated register mask to use hex instead of decimal.
Jun 25 2018, 12:32 PM

Jun 15 2018

sfertile committed rL334855: [PPC64] Support "symbol@high" and "symbol@higha" symbol modifers..
[PPC64] Support "symbol@high" and "symbol@higha" symbol modifers.
Jun 15 2018, 12:52 PM
sfertile committed rL334856: [PowerPC] Add support for high and higha symbol modifiers on tls modifers..
[PowerPC] Add support for high and higha symbol modifiers on tls modifers.
Jun 15 2018, 12:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Jun 15 2018, 12:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Jun 15 2018, 12:52 PM

Jun 13 2018

sfertile added inline comments to D48090: [PPC64] global dynamic to initial exec relaxation.
Jun 13 2018, 4:18 PM
sfertile updated the diff for D48090: [PPC64] global dynamic to initial exec relaxation.

Updated formatting, removed the 2 new RelExprs since they aren't needed, expanded comments on the relaxation specifics.

Jun 13 2018, 12:37 PM
sfertile added inline comments to D48112: Simplify PPC64::calcEFlags()..
Jun 13 2018, 12:04 PM
sfertile added inline comments to D48112: Simplify PPC64::calcEFlags()..
Jun 13 2018, 11:06 AM
sfertile accepted D48112: Simplify PPC64::calcEFlags()..

Other then the 1 comment this LGTM.

Jun 13 2018, 9:46 AM
sfertile added a comment to D48090: [PPC64] global dynamic to initial exec relaxation.

Can you give me a pointer to the spec describing these relaxations?

Jun 13 2018, 9:05 AM

Jun 12 2018

sfertile accepted D48093: Use shorter names for #lo, #hi, #ha, etc. NFC..

LGTM

Jun 12 2018, 5:44 PM
sfertile created D48090: [PPC64] global dynamic to initial exec relaxation.
Jun 12 2018, 12:55 PM
sfertile closed D47596: [PPC64] Support R_PPC64_DTPREL* relcoations.

committed in https://reviews.llvm.org/rLLD334465

Jun 12 2018, 9:54 AM
sfertile added a comment to D48082: [PPC64] Add TLS global dynamic to local exec relaxation.
Jun 12 2018, 9:30 AM

Jun 11 2018

sfertile committed rLLD334465: [PPC64] Support R_PPC64_DTPREL relocations..
[PPC64] Support R_PPC64_DTPREL relocations.
Jun 11 2018, 6:51 PM
sfertile committed rL334465: [PPC64] Support R_PPC64_DTPREL relocations..
[PPC64] Support R_PPC64_DTPREL relocations.
Jun 11 2018, 6:51 PM
sfertile added a comment to D47966: [ELF][PPC64] Add R_PPC64_DTPREL16* relocations for local-dynamic TLS model.

we have already have a patch that adds support for nearly all the DTPREL relocations here: https://reviews.llvm.org/D47596. Its been sitting for a while with-out a review though, rather then submit a new patch that adds support for only a few of the local-dynamic relocations I would appreciate a review on that so we can commit support for all at once.

Jun 11 2018, 7:25 AM
sfertile added a reviewer for D47596: [PPC64] Support R_PPC64_DTPREL* relcoations: MaskRay.
Jun 11 2018, 7:25 AM

Jun 8 2018

sfertile added a comment to D47596: [PPC64] Support R_PPC64_DTPREL* relcoations.

ping

Jun 8 2018, 10:34 AM

Jun 7 2018

sfertile updated the diff for D47754: [PowerPC] Add support for high and high-adjusted symbol modifiers on thread-local storage modifers..

Updated tests to produce the missing dtprel/tprel relocation types.

Jun 7 2018, 12:28 PM

Jun 4 2018

sfertile created D47754: [PowerPC] Add support for high and high-adjusted symbol modifiers on thread-local storage modifers..
Jun 4 2018, 6:52 PM
sfertile added a reviewer for D47729: [PowerPC] Add support for high and high-adjusted symbol modifiers.: grosbach.
Jun 4 2018, 11:30 AM
sfertile created D47729: [PowerPC] Add support for high and high-adjusted symbol modifiers..
Jun 4 2018, 10:21 AM

Jun 1 2018

sfertile added inline comments to D47598: [PPC64] Add support for local-exec TLS model.
Jun 1 2018, 10:35 AM

May 31 2018

sfertile added a comment to D47598: [PPC64] Add support for local-exec TLS model.

This LGTM, but I think someone with more lld experience should Ok it as well.

May 31 2018, 12:18 PM
sfertile committed rLLD333681: [PPC64] Support R_PPC64_GOT_TLSLD16 relocations..
[PPC64] Support R_PPC64_GOT_TLSLD16 relocations.
May 31 2018, 11:48 AM
sfertile committed rL333681: [PPC64] Support R_PPC64_GOT_TLSLD16 relocations..
[PPC64] Support R_PPC64_GOT_TLSLD16 relocations.
May 31 2018, 11:48 AM
sfertile closed D47538: [PPC64] Support R_PPC64_GOT_TLSLD16* relocations.
May 31 2018, 11:48 AM
sfertile closed D47538: [PPC64] Support R_PPC64_GOT_TLSLD16* relocations.
May 31 2018, 11:48 AM
sfertile committed rL333674: Rename R_TLSGD/R_TLSLD to add _GOT_FROM_END. NFC..
Rename R_TLSGD/R_TLSLD to add _GOT_FROM_END. NFC.
May 31 2018, 11:11 AM
sfertile committed rLLD333674: Rename R_TLSGD/R_TLSLD to add _GOT_FROM_END. NFC..
Rename R_TLSGD/R_TLSLD to add _GOT_FROM_END. NFC.
May 31 2018, 11:11 AM
sfertile closed D47379: [lld] Rename R_TLSGD/R_TLSLD to R_TLSGD_FROM_END/R_TLSLD_FROM_END [NFC].
May 31 2018, 11:11 AM
sfertile created D47596: [PPC64] Support R_PPC64_DTPREL* relcoations.
May 31 2018, 10:13 AM

May 30 2018

sfertile created D47538: [PPC64] Support R_PPC64_GOT_TLSLD16* relocations.
May 30 2018, 8:34 AM

May 29 2018

sfertile committed rLLD333420: [PPC64] Support General-Dynamic tls..
[PPC64] Support General-Dynamic tls.
May 29 2018, 7:45 AM
sfertile committed rL333420: [PPC64] Support General-Dynamic tls..
[PPC64] Support General-Dynamic tls.
May 29 2018, 7:38 AM
sfertile closed D47325: [PPC64] Support the General-Dynamic tls relocations.
May 29 2018, 7:38 AM

May 28 2018

sfertile updated the diff for D47325: [PPC64] Support the General-Dynamic tls relocations.

Fixed extra space.

May 28 2018, 12:35 PM
sfertile added a comment to D47379: [lld] Rename R_TLSGD/R_TLSLD to R_TLSGD_FROM_END/R_TLSLD_FROM_END [NFC].

New naming is confusing IMO. We had R_GOTONLY_PC_FROM_END, R_GOT_FROM_END and R_GOTREL_FROM_END.
Since names contains "GOT" it is clear that "FROM_END" says about the end of GOT.

But R_TLSGD_FROM_END is different made me think about the end of TLS first of all.

May 28 2018, 9:10 AM

May 25 2018

sfertile retitled D47379: [lld] Rename R_TLSGD/R_TLSLD to R_TLSGD_FROM_END/R_TLSLD_FROM_END [NFC] from [lld] Rename R_TLSGD/R_TLSLD to R_TLSGD_FROM_END/R_TLSLD_FROM_END to [lld] Rename R_TLSGD/R_TLSLD to R_TLSGD_FROM_END/R_TLSLD_FROM_END [NFC].
May 25 2018, 10:50 AM
sfertile created D47379: [lld] Rename R_TLSGD/R_TLSLD to R_TLSGD_FROM_END/R_TLSLD_FROM_END [NFC].
May 25 2018, 10:49 AM
sfertile closed D46876: [PPC64] Add R_PPC64_IRELATIVE relocation.

commited in https://reviews.llvm.org/rL333200

May 25 2018, 10:06 AM
sfertile added a comment to D47325: [PPC64] Support the General-Dynamic tls relocations.

Generally looking good, it needs a bit more time to understand the test though.

May 25 2018, 7:50 AM

May 24 2018

sfertile added inline comments to D47325: [PPC64] Support the General-Dynamic tls relocations.
May 24 2018, 11:47 AM
sfertile updated the diff for D47325: [PPC64] Support the General-Dynamic tls relocations.

Renamed the test and fixed several places where I used global-dynamic instead of`general-dynamic`.
Added run steps to the test to run on BE as well as LE.

May 24 2018, 10:53 AM
sfertile committed rLLD333209: Fix regex in lld ppc64-ifunc test..
Fix regex in lld ppc64-ifunc test.
May 24 2018, 10:11 AM
sfertile committed rL333209: Fix regex in lld ppc64-ifunc test..
Fix regex in lld ppc64-ifunc test.
May 24 2018, 10:11 AM
sfertile committed rLLD333203: [PPC64] Set the IRelative relocation type..
[PPC64] Set the IRelative relocation type.
May 24 2018, 9:36 AM
sfertile committed rL333203: [PPC64] Set the IRelative relocation type..
[PPC64] Set the IRelative relocation type.
May 24 2018, 9:36 AM
sfertile closed D46877: [PPC64] Set the IRelative relocation type..
May 24 2018, 9:36 AM
sfertile committed rL333200: Add R_PPC64_IRELATIVE to PPC64 relocations..
Add R_PPC64_IRELATIVE to PPC64 relocations.
May 24 2018, 9:06 AM
sfertile created D47325: [PPC64] Support the General-Dynamic tls relocations.
May 24 2018, 6:59 AM

May 15 2018

sfertile updated the summary of D46876: [PPC64] Add R_PPC64_IRELATIVE relocation.
May 15 2018, 6:27 AM
sfertile created D46877: [PPC64] Set the IRelative relocation type..
May 15 2018, 6:27 AM
sfertile created D46876: [PPC64] Add R_PPC64_IRELATIVE relocation.
May 15 2018, 6:22 AM

May 11 2018

sfertile added a comment to D46761: [NFC] [Power] Fix instruction format for xsrqpi.

Minor nit: the instructions that use this class are either Z23Form_7 ( xsrqpxp) or Z23Form_8 (xsrqpi, xsrqpix). The structure is correct but I think we should stick with the naming that matches the instruction descriptions in the ISA.

May 11 2018, 1:29 PM
sfertile accepted D46766: [ELF][PPC64] Fix getRelExpr for R_PPC64_REL64.

LGTM.

May 11 2018, 12:38 PM
sfertile committed rLLD332127: [PPC64] isRelExpr should return true for the PPC Call Exprs..
[PPC64] isRelExpr should return true for the PPC Call Exprs.
May 11 2018, 12:35 PM
sfertile committed rL332127: [PPC64] isRelExpr should return true for the PPC Call Exprs..
[PPC64] isRelExpr should return true for the PPC Call Exprs.
May 11 2018, 12:35 PM
sfertile closed D46654: [PPC64] isRelExpr should return true for the PPC Call Exprs.
May 11 2018, 12:35 PM

May 9 2018

sfertile created D46654: [PPC64] isRelExpr should return true for the PPC Call Exprs.
May 9 2018, 11:35 AM

May 8 2018

sfertile committed rLLD331840: [PPC64] Add lazy symbol resolution stubs..
[PPC64] Add lazy symbol resolution stubs.
May 8 2018, 7:11 PM
sfertile committed rL331840: [PPC64] Add lazy symbol resolution stubs..
[PPC64] Add lazy symbol resolution stubs.
May 8 2018, 7:11 PM
sfertile closed D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..
May 8 2018, 7:11 PM
sfertile added inline comments to D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..
May 8 2018, 11:40 AM
sfertile added inline comments to D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..
May 8 2018, 11:12 AM
sfertile updated the diff for D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..

Addressed review comments.

May 8 2018, 11:02 AM

May 7 2018

sfertile added inline comments to D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..
May 7 2018, 7:04 PM
sfertile updated the diff for D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..

Updated based on review comments.

May 7 2018, 6:58 PM

May 6 2018

sfertile added inline comments to D46204: [PPC64] V2 abi: Emit plt call stubs to the text section rather then the plt section. .
May 6 2018, 12:20 PM
sfertile committed rLLD331607: [PPC64] Emit plt call stubs to the text section rather then the plt section..
[PPC64] Emit plt call stubs to the text section rather then the plt section.
May 6 2018, 12:20 PM
sfertile committed rL331607: [PPC64] Emit plt call stubs to the text section rather then the plt section..
[PPC64] Emit plt call stubs to the text section rather then the plt section.
May 6 2018, 12:17 PM
sfertile closed D46204: [PPC64] V2 abi: Emit plt call stubs to the text section rather then the plt section. .
May 6 2018, 12:17 PM