- User Since
- Oct 24 2016, 8:15 AM (151 w, 3 d)
Thu, Sep 12
Wed, Sep 11
Mon, Sep 9
Sat, Sep 7
Fri, Sep 6
Wed, Sep 4
Tue, Sep 3
Used numeric substitution block for symbol table indexes.
Thu, Aug 29
Tue, Aug 27
Mon, Aug 26
Fri, Aug 23
Can we please either commit this, or revert r369414 otherwise? Several of the sanitizer buildbots have been red since Tuesday due to r369414.
Thu, Aug 22
Wed, Aug 21
This broke several of the bots (eg). It seems any of the __has_cpp_attribute checks that have a namespace qualified attributes will need to be guarded by a if defined(__cplusplus) if we are including the header in a C file.
We were stretching the definition of an NFC patch by creating but not using the TOC-base on AIX. I've striped this down to the NFC part and will post a separate patch for the TOC base change that includes a test change to reflect the TOC-base being created.
Aug 20 2019
Related to the 32-bit vs 64-bit naming and assertions: I can appreciate being defensive about this, but I think trying to disable being able to create the various types and having an assertion (or error) in every function is overkill. Too much defensiveness is just clutter. I've added an earlier fatal_error in executePostlayoutBinding which blocks the ObjectWriter from doing anything interesting. When we are ready to proceed with 64-bit support we can remove that error and either rename the types (and guard all the appropriate functions), or modify the types for both 64-bit and 32-bit support, whichever is appropriate for the way we intend to add 64-bit support.
- Addressed latest round of review comments.
- Replaced 'CSect' in code with 'Csect' and changed errors/comments to use 'CSECT'.
- Added a second fatal error related to emiting 64-bit objects, in executePostBindingLayout.
Aug 19 2019
Addressed most review comments other then those related to 32-bit vs 64-bit.
Aug 16 2019
Changed MCSymbolXCOFF StorageClass member to be an optional<StorageClass> and added asserts checking for redefineing the storage class and accessing an unset storage class.
Minor comment changes.
Aug 14 2019
Rebased and addressed numerous review comments.
Aug 13 2019
LGTM. (After either responding to or addressing Jason comment)
Aug 12 2019
Rebased to reflect changes made in https://reviews.llvm.org/rL368584
Aug 9 2019
Aug 8 2019
Aug 7 2019
Aug 6 2019
Aug 1 2019
Jul 30 2019
Jul 29 2019
Jul 26 2019
A minor comment, but otherwise LGTM.
Jul 24 2019
We will need to add handling of Text SectionKind in TargetLoweringObjectFileXCOFF::getExplicitSectionGlobal in this because it blocks assembly generation for the test.
A couple minor comments, I think we are almost there.
I'll have to dig into the AIX ABI docs before I can review this more thoroughly but it looks good. I suggest we split out renaming of the hardcoded '8' to --> getCRSaveOffset() as a separate NFC patch and that we can land immediately.
Jul 23 2019
Jul 22 2019
Committed in https://reviews.llvm.org/rG942537d9fa50