sfertile (Sean Fertile)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2016, 8:15 AM (86 w, 2 d)

Recent Activity

Fri, Jun 15

sfertile committed rL334855: [PPC64] Support "symbol@high" and "symbol@higha" symbol modifers..
[PPC64] Support "symbol@high" and "symbol@higha" symbol modifers.
Fri, Jun 15, 12:52 PM
sfertile committed rL334856: [PowerPC] Add support for high and higha symbol modifiers on tls modifers..
[PowerPC] Add support for high and higha symbol modifiers on tls modifers.
Fri, Jun 15, 12:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Fri, Jun 15, 12:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Fri, Jun 15, 12:52 PM

Wed, Jun 13

sfertile added inline comments to D48090: [PPC64] global dynamic to initial exec relaxation.
Wed, Jun 13, 4:18 PM
sfertile updated the diff for D48090: [PPC64] global dynamic to initial exec relaxation.

Updated formatting, removed the 2 new RelExprs since they aren't needed, expanded comments on the relaxation specifics.

Wed, Jun 13, 12:37 PM
sfertile added inline comments to D48112: Simplify PPC64::calcEFlags()..
Wed, Jun 13, 12:04 PM
sfertile added inline comments to D48112: Simplify PPC64::calcEFlags()..
Wed, Jun 13, 11:06 AM
sfertile accepted D48112: Simplify PPC64::calcEFlags()..

Other then the 1 comment this LGTM.

Wed, Jun 13, 9:46 AM
sfertile added a comment to D48090: [PPC64] global dynamic to initial exec relaxation.

Can you give me a pointer to the spec describing these relaxations?

Wed, Jun 13, 9:05 AM

Tue, Jun 12

sfertile accepted D48093: Use shorter names for #lo, #hi, #ha, etc. NFC..

LGTM

Tue, Jun 12, 5:44 PM
sfertile created D48090: [PPC64] global dynamic to initial exec relaxation.
Tue, Jun 12, 12:55 PM
sfertile closed D47596: [PPC64] Support R_PPC64_DTPREL* relcoations.

committed in https://reviews.llvm.org/rLLD334465

Tue, Jun 12, 9:54 AM
sfertile added a comment to D48082: [PPC64] Add TLS global dynamic to local exec relaxation.
Tue, Jun 12, 9:30 AM

Mon, Jun 11

sfertile committed rLLD334465: [PPC64] Support R_PPC64_DTPREL relocations..
[PPC64] Support R_PPC64_DTPREL relocations.
Mon, Jun 11, 6:51 PM
sfertile committed rL334465: [PPC64] Support R_PPC64_DTPREL relocations..
[PPC64] Support R_PPC64_DTPREL relocations.
Mon, Jun 11, 6:51 PM
sfertile added a comment to D47966: [ELF][PPC64] Add R_PPC64_DTPREL16* relocations for local-dynamic TLS model.

we have already have a patch that adds support for nearly all the DTPREL relocations here: https://reviews.llvm.org/D47596. Its been sitting for a while with-out a review though, rather then submit a new patch that adds support for only a few of the local-dynamic relocations I would appreciate a review on that so we can commit support for all at once.

Mon, Jun 11, 7:25 AM
sfertile added a reviewer for D47596: [PPC64] Support R_PPC64_DTPREL* relcoations: MaskRay.
Mon, Jun 11, 7:25 AM

Fri, Jun 8

sfertile added a comment to D47596: [PPC64] Support R_PPC64_DTPREL* relcoations.

ping

Fri, Jun 8, 10:34 AM

Thu, Jun 7

sfertile updated the diff for D47754: [PowerPC] Add support for high and high-adjusted symbol modifiers on thread-local storage modifers..

Updated tests to produce the missing dtprel/tprel relocation types.

Thu, Jun 7, 12:28 PM

Mon, Jun 4

sfertile created D47754: [PowerPC] Add support for high and high-adjusted symbol modifiers on thread-local storage modifers..
Mon, Jun 4, 6:52 PM
sfertile added a reviewer for D47729: [PowerPC] Add support for high and high-adjusted symbol modifiers.: grosbach.
Mon, Jun 4, 11:30 AM
sfertile created D47729: [PowerPC] Add support for high and high-adjusted symbol modifiers..
Mon, Jun 4, 10:21 AM

Fri, Jun 1

sfertile added inline comments to D47598: [PPC64] Add support for local-exec TLS model.
Fri, Jun 1, 10:35 AM

Thu, May 31

sfertile added a comment to D47598: [PPC64] Add support for local-exec TLS model.

This LGTM, but I think someone with more lld experience should Ok it as well.

Thu, May 31, 12:18 PM
sfertile committed rLLD333681: [PPC64] Support R_PPC64_GOT_TLSLD16 relocations..
[PPC64] Support R_PPC64_GOT_TLSLD16 relocations.
Thu, May 31, 11:48 AM
sfertile committed rL333681: [PPC64] Support R_PPC64_GOT_TLSLD16 relocations..
[PPC64] Support R_PPC64_GOT_TLSLD16 relocations.
Thu, May 31, 11:48 AM
sfertile closed D47538: [PPC64] Support R_PPC64_GOT_TLSLD16* relocations.
Thu, May 31, 11:48 AM
sfertile closed D47538: [PPC64] Support R_PPC64_GOT_TLSLD16* relocations.
Thu, May 31, 11:48 AM
sfertile committed rL333674: Rename R_TLSGD/R_TLSLD to add _GOT_FROM_END. NFC..
Rename R_TLSGD/R_TLSLD to add _GOT_FROM_END. NFC.
Thu, May 31, 11:11 AM
sfertile committed rLLD333674: Rename R_TLSGD/R_TLSLD to add _GOT_FROM_END. NFC..
Rename R_TLSGD/R_TLSLD to add _GOT_FROM_END. NFC.
Thu, May 31, 11:11 AM
sfertile closed D47379: [lld] Rename R_TLSGD/R_TLSLD to R_TLSGD_FROM_END/R_TLSLD_FROM_END [NFC].
Thu, May 31, 11:11 AM
sfertile created D47596: [PPC64] Support R_PPC64_DTPREL* relcoations.
Thu, May 31, 10:13 AM

Wed, May 30

sfertile created D47538: [PPC64] Support R_PPC64_GOT_TLSLD16* relocations.
Wed, May 30, 8:34 AM

Tue, May 29

sfertile committed rLLD333420: [PPC64] Support General-Dynamic tls..
[PPC64] Support General-Dynamic tls.
Tue, May 29, 7:45 AM
sfertile committed rL333420: [PPC64] Support General-Dynamic tls..
[PPC64] Support General-Dynamic tls.
Tue, May 29, 7:38 AM
sfertile closed D47325: [PPC64] Support the General-Dynamic tls relocations.
Tue, May 29, 7:38 AM

Mon, May 28

sfertile updated the diff for D47325: [PPC64] Support the General-Dynamic tls relocations.

Fixed extra space.

Mon, May 28, 12:35 PM
sfertile added a comment to D47379: [lld] Rename R_TLSGD/R_TLSLD to R_TLSGD_FROM_END/R_TLSLD_FROM_END [NFC].

New naming is confusing IMO. We had R_GOTONLY_PC_FROM_END, R_GOT_FROM_END and R_GOTREL_FROM_END.
Since names contains "GOT" it is clear that "FROM_END" says about the end of GOT.

But R_TLSGD_FROM_END is different made me think about the end of TLS first of all.

Mon, May 28, 9:10 AM

Fri, May 25

sfertile retitled D47379: [lld] Rename R_TLSGD/R_TLSLD to R_TLSGD_FROM_END/R_TLSLD_FROM_END [NFC] from [lld] Rename R_TLSGD/R_TLSLD to R_TLSGD_FROM_END/R_TLSLD_FROM_END to [lld] Rename R_TLSGD/R_TLSLD to R_TLSGD_FROM_END/R_TLSLD_FROM_END [NFC].
Fri, May 25, 10:50 AM
sfertile created D47379: [lld] Rename R_TLSGD/R_TLSLD to R_TLSGD_FROM_END/R_TLSLD_FROM_END [NFC].
Fri, May 25, 10:49 AM
sfertile closed D46876: [PPC64] Add R_PPC64_IRELATIVE relocation.

commited in https://reviews.llvm.org/rL333200

Fri, May 25, 10:06 AM
sfertile added a comment to D47325: [PPC64] Support the General-Dynamic tls relocations.

Generally looking good, it needs a bit more time to understand the test though.

Fri, May 25, 7:50 AM

Thu, May 24

sfertile added inline comments to D47325: [PPC64] Support the General-Dynamic tls relocations.
Thu, May 24, 11:47 AM
sfertile updated the diff for D47325: [PPC64] Support the General-Dynamic tls relocations.

Renamed the test and fixed several places where I used global-dynamic instead of`general-dynamic`.

Thu, May 24, 10:53 AM
sfertile committed rLLD333209: Fix regex in lld ppc64-ifunc test..
Fix regex in lld ppc64-ifunc test.
Thu, May 24, 10:11 AM
sfertile committed rL333209: Fix regex in lld ppc64-ifunc test..
Fix regex in lld ppc64-ifunc test.
Thu, May 24, 10:11 AM
sfertile committed rLLD333203: [PPC64] Set the IRelative relocation type..
[PPC64] Set the IRelative relocation type.
Thu, May 24, 9:36 AM
sfertile committed rL333203: [PPC64] Set the IRelative relocation type..
[PPC64] Set the IRelative relocation type.
Thu, May 24, 9:36 AM
sfertile closed D46877: [PPC64] Set the IRelative relocation type..
Thu, May 24, 9:36 AM
sfertile committed rL333200: Add R_PPC64_IRELATIVE to PPC64 relocations..
Add R_PPC64_IRELATIVE to PPC64 relocations.
Thu, May 24, 9:06 AM
sfertile created D47325: [PPC64] Support the General-Dynamic tls relocations.
Thu, May 24, 6:59 AM

May 15 2018

sfertile updated the summary of D46876: [PPC64] Add R_PPC64_IRELATIVE relocation.
May 15 2018, 6:27 AM
sfertile created D46877: [PPC64] Set the IRelative relocation type..
May 15 2018, 6:27 AM
sfertile created D46876: [PPC64] Add R_PPC64_IRELATIVE relocation.
May 15 2018, 6:22 AM

May 11 2018

sfertile added a comment to D46761: [NFC] [Power] Fix instruction format for xsrqpi.

Minor nit: the instructions that use this class are either Z23Form_7 ( xsrqpxp) or Z23Form_8 (xsrqpi, xsrqpix). The structure is correct but I think we should stick with the naming that matches the instruction descriptions in the ISA.

May 11 2018, 1:29 PM
sfertile accepted D46766: [ELF][PPC64] Fix getRelExpr for R_PPC64_REL64.

LGTM.

May 11 2018, 12:38 PM
sfertile committed rLLD332127: [PPC64] isRelExpr should return true for the PPC Call Exprs..
[PPC64] isRelExpr should return true for the PPC Call Exprs.
May 11 2018, 12:35 PM
sfertile committed rL332127: [PPC64] isRelExpr should return true for the PPC Call Exprs..
[PPC64] isRelExpr should return true for the PPC Call Exprs.
May 11 2018, 12:35 PM
sfertile closed D46654: [PPC64] isRelExpr should return true for the PPC Call Exprs.
May 11 2018, 12:35 PM

May 9 2018

sfertile created D46654: [PPC64] isRelExpr should return true for the PPC Call Exprs.
May 9 2018, 11:35 AM

May 8 2018

sfertile committed rLLD331840: [PPC64] Add lazy symbol resolution stubs..
[PPC64] Add lazy symbol resolution stubs.
May 8 2018, 7:11 PM
sfertile committed rL331840: [PPC64] Add lazy symbol resolution stubs..
[PPC64] Add lazy symbol resolution stubs.
May 8 2018, 7:11 PM
sfertile closed D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..
May 8 2018, 7:11 PM
sfertile added inline comments to D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..
May 8 2018, 11:40 AM
sfertile added inline comments to D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..
May 8 2018, 11:12 AM
sfertile updated the diff for D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..

Addressed review comments.

May 8 2018, 11:02 AM

May 7 2018

sfertile added inline comments to D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..
May 7 2018, 7:04 PM
sfertile updated the diff for D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..

Updated based on review comments.

May 7 2018, 6:58 PM

May 6 2018

sfertile added inline comments to D46204: [PPC64] V2 abi: Emit plt call stubs to the text section rather then the plt section. .
May 6 2018, 12:20 PM
sfertile committed rLLD331607: [PPC64] Emit plt call stubs to the text section rather then the plt section..
[PPC64] Emit plt call stubs to the text section rather then the plt section.
May 6 2018, 12:20 PM
sfertile committed rL331607: [PPC64] Emit plt call stubs to the text section rather then the plt section..
[PPC64] Emit plt call stubs to the text section rather then the plt section.
May 6 2018, 12:17 PM
sfertile closed D46204: [PPC64] V2 abi: Emit plt call stubs to the text section rather then the plt section. .
May 6 2018, 12:17 PM

May 4 2018

sfertile added inline comments to D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..
May 4 2018, 1:55 PM
sfertile added a comment to D46204: [PPC64] V2 abi: Emit plt call stubs to the text section rather then the plt section. .

Hi Rui, thanks for the review. I think I've addressed all your comments.

May 4 2018, 12:21 PM
sfertile updated the diff for D46204: [PPC64] V2 abi: Emit plt call stubs to the text section rather then the plt section. .

Rebased to pick up Zaaras patch that removed V1 abi support and addressed review comments.

May 4 2018, 12:21 PM
sfertile abandoned D46076: [PPC64] Replace several endianess checks with abi checks..

This LGTM FWIW. (Acking to have it pop back up in people's queues).

May 4 2018, 8:05 AM

May 2 2018

sfertile added a comment to D45833: [PPC64] Add .toc section after .got section.

I wonder if you really need to merge .toc into .got. If I understand your description correctly, it doesn't matter whether they are merged or not as long as they are close enough. So I'm wondering if you can just manipulate the section output order so that .toc and .got are output next to each other.

May 2 2018, 11:18 AM

May 1 2018

sfertile updated the summary of D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..
May 1 2018, 7:30 PM
sfertile updated the diff for D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..

Moved the lazy resolver stubs to the .plt section, and renamed the ,plt and .got.plt sections.

May 1 2018, 7:28 PM
sfertile updated the diff for D46204: [PPC64] V2 abi: Emit plt call stubs to the text section rather then the plt section. .

Rebased to top of trunk.

May 1 2018, 11:23 AM

Apr 27 2018

sfertile created D46204: [PPC64] V2 abi: Emit plt call stubs to the text section rather then the plt section. .
Apr 27 2018, 12:11 PM
sfertile added a comment to D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..

I've moved the lazy resolver stubs to .plt section as suggested and will hopefully post the updated patch shortly. Everything seems to be working as expected. I had to re implement the plt call-stubs as thunks before I could do that move, but that was something that was going to have to be done eventually anyways.

Apr 27 2018, 11:20 AM

Apr 25 2018

sfertile created D46076: [PPC64] Replace several endianess checks with abi checks..
Apr 25 2018, 12:17 PM

Apr 23 2018

sfertile added a comment to D45892: [PPC64] Fix toc restore nops offset for V2 ABI.

It would be nice to have a test similar to ppc64-error-toc-restore.s that makes sure we emit the error for a missing nop on a tail call as well.

Apr 23 2018, 7:24 AM

Apr 20 2018

sfertile committed rL330473: [PartialInlining] Fix Crash from holding a reference to a destructed ORE..
[PartialInlining] Fix Crash from holding a reference to a destructed ORE.
Apr 20 2018, 1:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Apr 20 2018, 12:59 PM

Apr 18 2018

sfertile added a comment to D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..

This is a plt by another name, no?

Do you know why it is defined to have another name?

I'm not sure what you mean by 'plt' here. In this abi the .plt section is just the array of addresses of external functions that the dynamic linker fills out at runtime. The .glink section holds the lazy resolution stubs which will setup the environment for the dynamic linker to do so. Then there are also stubs for calling the external functions by loading their address out of the .plt. Am I right to assume by 'plt' you mean a combination of lazy resolver and the call stub?

The question is why there is such a difference of terminology. At least of x86_64/x86/aarch64 the the array of addresses is the .got.plt section and the .plt section is what has the stubs. Just like .glink it has a special first entry. That is:

pp64 v2 | others
.glink | .plt
.plt | .got.plt

Apr 18 2018, 6:59 AM

Apr 16 2018

sfertile added a comment to D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..

This is a plt by another name, no?

Do you know why it is defined to have another name?

Apr 16 2018, 12:49 PM
sfertile added a comment to D43219: [PartialInlining] Fix Crash from holding a reference to a destructed ORE.

ping

Apr 16 2018, 8:04 AM

Apr 13 2018

sfertile created D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution..
Apr 13 2018, 4:04 PM
sfertile committed rL330038: Add PPC64_GLINK dynamic tag..
Add PPC64_GLINK dynamic tag.
Apr 13 2018, 9:46 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Apr 13 2018, 9:46 AM

Apr 12 2018

sfertile added inline comments to D45574: Add PPC64_GLINK dynamic tag.
Apr 12 2018, 2:17 PM
sfertile created D45574: Add PPC64_GLINK dynamic tag.
Apr 12 2018, 8:57 AM

Apr 9 2018

sfertile added a comment to D43219: [PartialInlining] Fix Crash from holding a reference to a destructed ORE.

ping

Apr 9 2018, 11:58 AM

Apr 2 2018

sfertile committed rLLD329006: [PPC64] Minor changes for Plt relocations..
[PPC64] Minor changes for Plt relocations.
Apr 2 2018, 12:50 PM
sfertile committed rL329006: [PPC64] Minor changes for Plt relocations..
[PPC64] Minor changes for Plt relocations.
Apr 2 2018, 12:50 PM
sfertile closed D44951: [PPC64LE] Minor changes for Plt relocations..
Apr 2 2018, 12:50 PM · lld
sfertile committed rLLD329004: [PPC64] Write plt stubs for ElfV2 abi.
[PPC64] Write plt stubs for ElfV2 abi
Apr 2 2018, 12:20 PM