Page MenuHomePhabricator

sfertile (Sean Fertile)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2016, 8:15 AM (142 w, 6 d)

Recent Activity

Tue, Jul 16

sfertile added inline comments to D64814: [NFC][PowerPC]Change ADDIStocHA to ADDIStocHA8 to follow 64-bit naming convention.
Tue, Jul 16, 2:12 PM · Restricted Project
sfertile updated subscribers of D64814: [NFC][PowerPC]Change ADDIStocHA to ADDIStocHA8 to follow 64-bit naming convention.
Tue, Jul 16, 2:03 PM · Restricted Project
sfertile added inline comments to D63547: [AIX]Global Address Lowering.
Tue, Jul 16, 2:03 PM · Restricted Project

Fri, Jul 12

sfertile added inline comments to D63547: [AIX]Global Address Lowering.
Fri, Jul 12, 12:07 PM · Restricted Project
sfertile created D64652: [AIX] Add a TargetLoweringObjectFile for XCOFF and add support for common variables..
Fri, Jul 12, 11:23 AM · Restricted Project

Tue, Jul 9

sfertile added inline comments to D63547: [AIX]Global Address Lowering.
Tue, Jul 9, 5:31 PM · Restricted Project
sfertile added a comment to D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..

np.

Tue, Jul 9, 3:16 PM · Restricted Project
sfertile updated subscribers of D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..

Maybe someone can enlighten me as to why the build bots aren't tripping up on this one, but our group is running into this when we pull this commit from the upstream:

In MCStreamer.h, the declaration of the pure virtual EmitSymbolAttribute is:

virtual bool EmitSymbolAttribute(MCSymbol *Symbol,
                                 MCSymbolAttr AttrKind,
                                 StringRef AttrVal = StringRef()) = 0;

In this revision, in MCXCOFFStreamer.h, the declaration is:

bool EmitSymbolAttribute(MCSymbol *Symbol, MCSymbolAttr Attribute) override;

This is ill-formed, because the 'override' declaration hides the pure virtual member function. Apparently the clang-fast build bots are ok with this, but I'm not sure how. A similar code segment (Compiler Explorer) fails on every clang compiler I've tried.

Tue, Jul 9, 3:03 PM · Restricted Project
sfertile accepted D63738: [AIX]Enable lowering of MCSymbol MachineOperand.

LGTM.

Tue, Jul 9, 12:36 PM · Restricted Project
sfertile committed rGf09d54ed2a75: Boilerplate for producing XCOFF object files from the PowerPC backend. (authored by sfertile).
Boilerplate for producing XCOFF object files from the PowerPC backend.
Tue, Jul 9, 12:22 PM
sfertile committed rL365541: Boilerplate for producing XCOFF object files from the PowerPC backend..
Boilerplate for producing XCOFF object files from the PowerPC backend.
Tue, Jul 9, 12:21 PM
sfertile closed D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..
Tue, Jul 9, 12:21 PM · Restricted Project
sfertile committed rG210314ae8c59: Try to appease the Windows build bots. (authored by sfertile).
Try to appease the Windows build bots.
Tue, Jul 9, 11:46 AM
sfertile committed rL365535: Try to appease the Windows build bots..
Try to appease the Windows build bots.
Tue, Jul 9, 11:44 AM
sfertile committed rG837ae69f8b9d: [Object][XCOFF] Add support for 64-bit file header and section header dumping. (authored by sfertile).
[Object][XCOFF] Add support for 64-bit file header and section header dumping.
Tue, Jul 9, 11:11 AM
sfertile added a comment to D64197: [HardwareLoops] NFC - move hardware loop checking code to isHardwareLoopProfitable().
Tue, Jul 9, 11:11 AM · Restricted Project
sfertile committed rL365524: [Object][XCOFF] Add support for 64-bit file header and section header dumping..
[Object][XCOFF] Add support for 64-bit file header and section header dumping.
Tue, Jul 9, 11:09 AM
sfertile closed D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping..
Tue, Jul 9, 11:09 AM · Restricted Project
sfertile added a comment to D64197: [HardwareLoops] NFC - move hardware loop checking code to isHardwareLoopProfitable().

I tried adding a dependency on TransformUtils to Analysis/LLVMBuild.txt but that generated:

CMake Error at CMakeLists.txt:711 (message):
  Unexpected failure executing llvm-build: llvm-build: fatal error: found
  cycle to u'Analysis' after following: u'AArch64CodeGen' (required library)
  -> u'Analysis' (required library) -> u'TransformUtils' (required library)
  -> Analysis

Does this mean that this change violates the dependency graph? Assuming you can repro, with -DBUILD_SHARED_LIBS=ON then perhaps we can revert this while a solution is found?

Tue, Jul 9, 10:42 AM · Restricted Project
sfertile added inline comments to D63547: [AIX]Global Address Lowering.
Tue, Jul 9, 9:59 AM · Restricted Project
sfertile added inline comments to D63547: [AIX]Global Address Lowering.
Tue, Jul 9, 8:11 AM · Restricted Project
sfertile added inline comments to D63547: [AIX]Global Address Lowering.
Tue, Jul 9, 7:59 AM · Restricted Project

Mon, Jul 8

sfertile added inline comments to D63547: [AIX]Global Address Lowering.
Mon, Jul 8, 11:00 AM · Restricted Project

Fri, Jul 5

sfertile updated the diff for D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..
  • Various comment tweaks and spelling fixes.
  • Some indentation fixes and formatting changes.
  • Removed unreachable return statement.
  • Fixed error messages related to unsupported assembler pseudo ops.
  • Added some comments to test clarifying why we are checking for .text csect, and that the binary and text outputs don't represent the same XCOFF content.
Fri, Jul 5, 12:21 PM · Restricted Project
sfertile accepted D64222: [sanitizers] Use covering ObjectFormatType switches.

LGTM.

Fri, Jul 5, 8:15 AM · Restricted Project, Restricted Project
sfertile added inline comments to D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping..
Fri, Jul 5, 7:34 AM · Restricted Project
sfertile updated the diff for D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping..
  • Perform address arithmetic on const char* before casting to a uintptr_t.
Fri, Jul 5, 7:30 AM · Restricted Project

Thu, Jul 4

sfertile added inline comments to D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping..
Thu, Jul 4, 1:53 PM · Restricted Project
sfertile updated the diff for D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping..
  • Lots of tweaks to comments and whitespace.
    • Added assertion to 'getPointerToSymbolTable`
    • Changed name of local variable in getSymbolSectionName to be more descriptive.
    • Use checkOffset and getObject'in parseStringTable.
    • Changed unreachables to report_fatal_error in 'printSectionHeaders`.
    • Added TODO where overflow checking eventually needs to be done.
    • Added comment about DWARF subsection types, & limited section flag printing to the section type flags.
Thu, Jul 4, 1:48 PM · Restricted Project
sfertile accepted D63767: [NFC] Make some ObjectFormatType switches covering.

LGTM.

Thu, Jul 4, 7:57 AM · Restricted Project, Restricted Project

Fri, Jun 28

sfertile updated the diff for D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping..

Converted the way parsing the binary is done to not need an error_code out argument in the constructor. Creates a bare bones object file, then attempts to parse the expected structures out of the memory buffer. Trying to match the style ELF used.

Fri, Jun 28, 2:08 PM · Restricted Project
sfertile added inline comments to D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping..
Fri, Jun 28, 8:25 AM · Restricted Project
sfertile updated the diff for D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping..

Address further comments:

  • Simplified the address checking in 'checkSectionAddress'
  • Removed unneeded asserts. As Digger pointed out, an symbol related function that casts a DataRefImpl.p to a symbol table entry already asserts in toSymbolEntry.
Fri, Jun 28, 8:16 AM · Restricted Project
sfertile updated the diff for D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping..

Addressed first round of review comments.

  • Fix getSectionFlags return value to be signed.
  • Print the section flags as its symbolic value.
Fri, Jun 28, 5:58 AM · Restricted Project
sfertile added inline comments to D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping..
Fri, Jun 28, 5:50 AM · Restricted Project

Thu, Jun 27

sfertile added inline comments to D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..
Thu, Jun 27, 1:46 PM · Restricted Project
sfertile updated the diff for D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..
Address review comments round 2.
Thu, Jun 27, 1:29 PM · Restricted Project

Wed, Jun 26

sfertile created D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping..
Wed, Jun 26, 2:04 PM · Restricted Project
sfertile added inline comments to D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..
Wed, Jun 26, 11:26 AM · Restricted Project
sfertile updated the diff for D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..

Addressed review comments:

  • Fixed up several comments
  • removed overridden functions that only called based class implementation.
  • fixed up logic for creating an MCAsmInfo and Streamers so that Linux/ELF remains the default.
  • Removed code for registering an XCOFFStreamer creation callback as no classes extend the XCOFF streamer.
  • reviewed usage of assert/llvm_unreachable. Converted most to report_fatal_error
  • Always use a timestamp of '0' for reproducible. Fatal error if incremental linking is enabled.
Wed, Jun 26, 11:13 AM · Restricted Project

Jun 18 2019

sfertile added a comment to D63383: [ELF][ARM][AARCH64][MIPS][PPC] Simplify the logic to create R_*_RELATIVE for absolute relocation types in writable sections.

PowerPC64 changes LGTM.

Jun 18 2019, 8:49 AM · Restricted Project

Jun 12 2019

sfertile added a comment to D63182: [ELF][PPC64] Don't report "relocation refers to a discarded section" for .toc.

Thank You @MaskRay.

Jun 12 2019, 5:09 AM · Restricted Project

Jun 11 2019

sfertile updated subscribers of D63043: [ELF][PPC] Simplify {read,write}FromHalf16.

@kamaub ^

Jun 11 2019, 8:58 AM · Restricted Project
sfertile added a comment to D63043: [ELF][PPC] Simplify {read,write}FromHalf16.

@sfertile Sorry but I can't find commit 729111cf1824159bb4dd331cab8a829eab30313f or f49f58527a6d8147524d8d6f2eb1feb70f856292 in either llvm/llvm-project (git monorepo) or llvm-mirror/lld (git multirepo). Do you have the revision numbers, e.g. r362867 (or rL362867 rLLD362867; the latters give a clickable link on Phabricator)

Jun 11 2019, 8:34 AM · Restricted Project
sfertile added a comment to D63043: [ELF][PPC] Simplify {read,write}FromHalf16.

Let me revert this change.

Sean, feel free to revert a change if it broke buildbots like this. You don't have to go through a pre-commit code review for a revert change that fixes buildbots.

Jun 11 2019, 6:13 AM · Restricted Project

Jun 10 2019

sfertile updated subscribers of D63043: [ELF][PPC] Simplify {read,write}FromHalf16.

@MaskRay You broke the PowerpC64 build bot, and have been asked by both the buildbot maintainer (@anil9) and me to fix it. As of this morning the bot is still failing dues to the same problem (http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/4263/steps/build-stage2-unified-tree/logs/stdio) Can you please address that before committing PPC64 changes like this. I don't understand why you would consider committing more PowerPC64 changes when the bot is in this state, rather then fixing it first.

Jun 10 2019, 9:08 AM · Restricted Project

Jun 7 2019

sfertile added a comment to D61583: [ELF] Create Undefined for local STT_SECTION symbol if the section is discarded.

@MaskRay Are you planning on pulling this? The buildbot is still red and there have been numerous Power related changes going in with no buildbot coverage.

Jun 7 2019, 8:21 AM · Restricted Project

Jun 6 2019

sfertile added a comment to D61583: [ELF] Create Undefined for local STT_SECTION symbol if the section is discarded.

@sfertile I'm confused with the recent revert and revert of revert.. The problem this change caused should have been fixed by D62840. Did you find other problems? (The warn() can be deleted if you suspect there is somethin

Jun 6 2019, 7:26 PM · Restricted Project
sfertile committed rG6a573e3ec3ea: Revert "Revert "[ELF] Suppress "STT_SECTION symbol should be defined" on . (authored by sfertile).
Revert "Revert "[ELF] Suppress "STT_SECTION symbol should be defined" on .
Jun 6 2019, 1:15 PM
sfertile committed rG6ba76dd77952: Revert "Revert "Reland D61583 [ELF] Error on relocations to STT_SECTION symbols… (authored by sfertile).
Revert "Revert "Reland D61583 [ELF] Error on relocations to STT_SECTION symbols…
Jun 6 2019, 1:15 PM
sfertile committed rL362743: Revert "Revert "Reland D61583 [ELF] Error on relocations to STT_SECTION symbols….
Revert "Revert "Reland D61583 [ELF] Error on relocations to STT_SECTION symbols…
Jun 6 2019, 1:13 PM
sfertile committed rL362744: Revert "Revert "[ELF] Suppress "STT_SECTION symbol should be defined" on ..
Revert "Revert "[ELF] Suppress "STT_SECTION symbol should be defined" on .
Jun 6 2019, 1:13 PM
sfertile committed rGa0a63b2f9053: Revert "[ELF] Suppress "STT_SECTION symbol should be defined" on .eh_frame, . (authored by sfertile).
Revert "[ELF] Suppress "STT_SECTION symbol should be defined" on .eh_frame, .
Jun 6 2019, 12:34 PM
sfertile committed rGf1d9b3180e61: Revert "Reland D61583 [ELF] Error on relocations to STT_SECTION symbols if the… (authored by sfertile).
Revert "Reland D61583 [ELF] Error on relocations to STT_SECTION symbols if the…
Jun 6 2019, 12:34 PM
sfertile added a reverting change for rGdcba4828a9ea: [ELF] Suppress "STT_SECTION symbol should be defined" on .eh_frame, .debug*, .: rGa0a63b2f9053: Revert "[ELF] Suppress "STT_SECTION symbol should be defined" on .eh_frame, ..
Jun 6 2019, 12:34 PM
sfertile added a reverting change for rG5d3b3188f722: Reland D61583 [ELF] Error on relocations to STT_SECTION symbols if the sections…: rGf1d9b3180e61: Revert "Reland D61583 [ELF] Error on relocations to STT_SECTION symbols if the….
Jun 6 2019, 12:34 PM
sfertile committed rL362739: Revert "Reland D61583 [ELF] Error on relocations to STT_SECTION symbols if the….
Revert "Reland D61583 [ELF] Error on relocations to STT_SECTION symbols if the…
Jun 6 2019, 12:34 PM
sfertile committed rL362738: Revert "[ELF] Suppress "STT_SECTION symbol should be defined" on .eh_frame, ..
Revert "[ELF] Suppress "STT_SECTION symbol should be defined" on .eh_frame, .
Jun 6 2019, 12:33 PM
sfertile accepted D62532: [AIX] Implement function descriptor on SDAG.

LGTM.

Jun 6 2019, 9:41 AM · Restricted Project

Jun 4 2019

sfertile added inline comments to D62532: [AIX] Implement function descriptor on SDAG.
Jun 4 2019, 10:58 AM · Restricted Project
sfertile added a reviewer for D62532: [AIX] Implement function descriptor on SDAG: syzaara.
Jun 4 2019, 9:41 AM · Restricted Project

May 29 2019

sfertile added inline comments to D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..
May 29 2019, 5:50 AM · Restricted Project

May 24 2019

sfertile accepted D61948: Implement call lowering without parameters on AIX.

LGTM.

May 24 2019, 9:44 AM · Restricted Project

May 21 2019

sfertile added inline comments to D61948: Implement call lowering without parameters on AIX.
May 21 2019, 6:06 PM · Restricted Project

May 17 2019

sfertile added inline comments to D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..
May 17 2019, 9:55 AM · Restricted Project
sfertile added a comment to D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..

ping.

May 17 2019, 9:23 AM · Restricted Project

May 16 2019

sfertile added inline comments to D61532: implement of the parsing symbol table for xcoffobjfile and output as yaml format.
May 16 2019, 8:52 PM · Restricted Project

May 15 2019

sfertile added a reviewer for D61948: Implement call lowering without parameters on AIX: hfinkel.
May 15 2019, 8:15 AM · Restricted Project

May 14 2019

sfertile added inline comments to D61532: implement of the parsing symbol table for xcoffobjfile and output as yaml format.
May 14 2019, 12:00 PM · Restricted Project
sfertile accepted D61900: [tests][go]Add -stdlib=libc++ to build GO test if LLVM is built with libc++.

LGTM.

May 14 2019, 10:30 AM · Restricted Project

May 13 2019

sfertile added a comment to D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..

ping

May 13 2019, 7:47 PM · Restricted Project

May 10 2019

sfertile accepted D61718: [llvm-objdump] Print st_other.

LGTM.

May 10 2019, 6:50 AM · Restricted Project

May 9 2019

sfertile accepted D61720: [PPC64] Define getThunkSectionSpacing() based on the range of R_PPC64_REL24.

The "simplest" number 0x2000000 works no worse than other numbers so I'll just use it.

May 9 2019, 8:24 AM · Restricted Project

May 8 2019

sfertile created D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..
May 8 2019, 1:01 PM · Restricted Project
sfertile added inline comments to D61532: implement of the parsing symbol table for xcoffobjfile and output as yaml format.
May 8 2019, 10:52 AM · Restricted Project
sfertile added a comment to D61647: llvm-objdump: when ELF st_other field is set, print its value before symbol name.

MaskRay, looks like many tests under lld/tests are using llvm-objdump, a grep for llvm-objdump on this folder returned >1000 entries.

May 8 2019, 10:18 AM · Restricted Project
sfertile added a comment to D61610: [PPC64] implement Thunk Section Spacing.
If PPC is anything like Arm, I would be very surprised to see a lot of inter-section conditional branches,
May 8 2019, 8:11 AM · Restricted Project

May 7 2019

sfertile added a comment to D61647: llvm-objdump: when ELF st_other field is set, print its value before symbol name.

Adding MaskRay as a reviewer for their familiarity with the llvm tools.

May 7 2019, 1:44 PM · Restricted Project
sfertile added a reviewer for D61647: llvm-objdump: when ELF st_other field is set, print its value before symbol name: MaskRay.
May 7 2019, 1:22 PM · Restricted Project
sfertile added a comment to D61610: [PPC64] implement Thunk Section Spacing.

Thanks for posting this @adalava.

May 7 2019, 7:02 AM · Restricted Project

May 3 2019

sfertile added inline comments to D61532: implement of the parsing symbol table for xcoffobjfile and output as yaml format.
May 3 2019, 2:53 PM · Restricted Project
sfertile accepted D61530: Add AIX Version Macros.

LGTM

May 3 2019, 1:07 PM · Restricted Project
sfertile committed rGfd75ee9154d2: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj. (authored by sfertile).
[Object][XCOFF] Add an XCOFF dumper for llvm-readobj.
May 3 2019, 5:56 AM
sfertile committed rL359878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj..
[Object][XCOFF] Add an XCOFF dumper for llvm-readobj.
May 3 2019, 5:55 AM
sfertile closed D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj.
May 3 2019, 5:55 AM · Restricted Project

May 2 2019

sfertile abandoned D54720: [PPC64] toc-indirect to toc-relative relaxation..

Abandoning in favour of D60958.

May 2 2019, 9:12 AM · Restricted Project
sfertile added a comment to D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj.
May 2 2019, 8:22 AM · Restricted Project
sfertile updated the diff for D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj.

Removed extra blank lines and added binaries into the diff.

May 2 2019, 8:13 AM · Restricted Project

Apr 30 2019

sfertile updated the diff for D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj.

Fixed return types to match the type of field being accessed.

Apr 30 2019, 11:08 AM · Restricted Project
sfertile accepted D60958: [PPC64] toc-indirect to toc-relative relaxation.

LGTM.

Apr 30 2019, 8:04 AM · Restricted Project

Apr 25 2019

sfertile added a comment to D60958: [PPC64] toc-indirect to toc-relative relaxation.

Patch looks really good. I think you managed to explain the toc-indirection without getting to verbose which is something I've struggled with. I have a couple minor suggestions and I need to go over the test a bit more indepth but overall this looks good to me.

Apr 25 2019, 5:01 PM · Restricted Project
sfertile committed rGa93a33cb87ec: [Object][XCOFF] Add intial support for section header table. (authored by sfertile).
[Object][XCOFF] Add intial support for section header table.
Apr 25 2019, 2:38 PM
sfertile committed rL359244: [Object][XCOFF] Add intial support for section header table..
[Object][XCOFF] Add intial support for section header table.
Apr 25 2019, 2:38 PM
sfertile closed D60784: [Object][XCOFF] Add intial support for parsing/dumping section header table..
Apr 25 2019, 2:38 PM · Restricted Project

Apr 24 2019

sfertile committed rG526633deea86: Add period at end of comment. (authored by sfertile).
Add period at end of comment.
Apr 24 2019, 2:51 PM
sfertile committed rL359144: Add period at end of comment..
Add period at end of comment.
Apr 24 2019, 2:50 PM

Apr 23 2019

sfertile added a comment to D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj.

The format of the binaries included in the patch don't seem correct, they create empty files. As a result the corresponding test are failing.

Apr 23 2019, 10:04 AM · Restricted Project
sfertile added a comment to D60958: [PPC64] toc-indirect to toc-relative relaxation.

Hi MaskRay.

Apr 23 2019, 9:29 AM · Restricted Project

Apr 22 2019

sfertile updated the summary of D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj.
Apr 22 2019, 1:11 PM · Restricted Project
sfertile added a comment to D54720: [PPC64] toc-indirect to toc-relative relaxation..

@sfertile Didn't catch you these days on IRC...

I've created D60958 for my idea.

Apr 22 2019, 10:23 AM · Restricted Project