Page MenuHomePhabricator

sfertile (Sean Fertile)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2016, 8:15 AM (221 w, 4 d)

Recent Activity

Mon, Jan 18

sfertile committed rGead71a23edde: [PowerPC][AIX]Do not emit xxspltd mnemonic on AIX. (authored by sfertile).
[PowerPC][AIX]Do not emit xxspltd mnemonic on AIX.
Mon, Jan 18, 6:27 AM
sfertile closed D94419: [PowerPC][AIX]Do not emit xxspltd mnemonic on AIX..
Mon, Jan 18, 6:26 AM · Restricted Project, Restricted Project

Fri, Jan 15

sfertile updated the diff for D94419: [PowerPC][AIX]Do not emit xxspltd mnemonic on AIX..

Rebased on trunk.

Fri, Jan 15, 8:45 AM · Restricted Project, Restricted Project

Thu, Jan 14

sfertile accepted D94458: [PowerPC] Only use some extend mne if assembler is modern enough.

Thanks Jinsong, LGTM.

Thu, Jan 14, 12:13 PM · Restricted Project
sfertile added inline comments to D94458: [PowerPC] Only use some extend mne if assembler is modern enough.
Thu, Jan 14, 8:47 AM · Restricted Project
sfertile added inline comments to D94458: [PowerPC] Only use some extend mne if assembler is modern enough.
Thu, Jan 14, 6:34 AM · Restricted Project

Wed, Jan 13

sfertile added a comment to D94458: [PowerPC] Only use some extend mne if assembler is modern enough.

Thanks Jinsong, left a couple really minor comments. Will rebase the xxspltd fix on this patch now.

Wed, Jan 13, 8:37 AM · Restricted Project

Tue, Jan 12

sfertile added a comment to D94458: [PowerPC] Only use some extend mne if assembler is modern enough.
clang -target powerpc64le-unknown-linux-gnu  -c -o a.o  modern-as.s
 error: instruction use requires an option to be enabled
            mfudscr 2

IIUC this patch is breaking compatibility with gas due to the AIX assembler not supporting the mnemonic. Similarly for my xxspltd patch, we wouldn't be able to encode the mnemonic without passing extra options on Linux. Thats why I took the approach I did in D94419. I am happy to change direction, but in my opinion we should only be disabling the mnemonics on AIX.

Tue, Jan 12, 10:15 AM · Restricted Project
sfertile added a comment to D94419: [PowerPC][AIX]Do not emit xxspltd mnemonic on AIX..

I have added a Predicates in https://reviews.llvm.org/D94458 for a similar mne, maybe you can rebase this to use that.

Tue, Jan 12, 7:42 AM · Restricted Project, Restricted Project
sfertile accepted D94449: [PowerPC][NFCI] PassSubtarget to ASMWriter.

Thanks Jinsong, LGTM.

Tue, Jan 12, 7:40 AM · Restricted Project

Mon, Jan 11

sfertile requested review of D94419: [PowerPC][AIX]Do not emit xxspltd mnemonic on AIX..
Mon, Jan 11, 8:12 AM · Restricted Project, Restricted Project

Dec 7 2020

sfertile committed rG8f91f38148e8: [LLD] Search archives for symbol defs to override COMMON symbols. (authored by sfertile).
[LLD] Search archives for symbol defs to override COMMON symbols.
Dec 7 2020, 7:10 AM
sfertile closed D86142: [LLD] Search archives for non-tentative defintions..
Dec 7 2020, 7:10 AM · Restricted Project, Restricted Project

Dec 2 2020

sfertile added a comment to D86142: [LLD] Search archives for non-tentative defintions..

If there is no objections, I'll go ahead and commit later this week.

Dec 2 2020, 8:24 AM · Restricted Project, Restricted Project
sfertile updated the diff for D86142: [LLD] Search archives for non-tentative defintions..

Fixed one too many hyphens in man page change.

Dec 2 2020, 8:23 AM · Restricted Project, Restricted Project
sfertile updated the diff for D86142: [LLD] Search archives for non-tentative defintions..
  • Removed leading space in option description
  • Updated the manpage doc.
Dec 2 2020, 8:12 AM · Restricted Project, Restricted Project
sfertile added a comment to D92445: [PowerPC] Enable OpenMP for powerpcle target. [5/5].

On FreeBSD, the main use of this will be on the new powerpc64le arch, where we need to build a 32-bit LE bootloader for use with pseries. (it is easier to retarget LLVM than make a cross-endian bootloader, as it would involve rewriting filesystem code etc.)

Excuse my ignorance, but what are there technical limitations preventing writing n 64-bit LE boot loader and avoid having a 32-bit LE target all-together?

Dec 2 2020, 7:46 AM · Restricted Project, Restricted Project, Restricted Project
sfertile added inline comments to D92324: [PowerPC] Fix altivec feature on pwr cpus pre pwr6..
Dec 2 2020, 6:46 AM · Restricted Project, Restricted Project

Dec 1 2020

sfertile updated the diff for D92324: [PowerPC] Fix altivec feature on pwr cpus pre pwr6..
  • Added -mattr=+altivec to vector pop count test to keep pwr5 testing
  • Added a test to show enabling altivec through function attribute.
Dec 1 2020, 10:26 AM · Restricted Project, Restricted Project

Nov 30 2020

sfertile added a comment to D92324: [PowerPC] Fix altivec feature on pwr cpus pre pwr6..

The altivec feature was an optional part of the 2.03 (pwr4) and 2.04 (pwr5) ISAs, and it was not implemented by any IBM CPUs until Power6.

The Power Processing Element in various IBM CPUs (including the Cell Broadband Engine) incorporate VMX. With this change, which of the CPU options should a user targeting a PPE use?

Nov 30 2020, 12:49 PM · Restricted Project, Restricted Project
sfertile added inline comments to D91611: [PowerPC][LLD] Detecting and fixing missing TLS relocation on __tls_get_addr.
Nov 30 2020, 8:23 AM · Restricted Project
sfertile requested review of D92324: [PowerPC] Fix altivec feature on pwr cpus pre pwr6..
Nov 30 2020, 7:20 AM · Restricted Project, Restricted Project

Nov 26 2020

sfertile added a comment to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

Sorry Zarko, I must have deleted my comment before posting last night I've added it back now.

Nov 26 2020, 6:12 AM · Restricted Project

Nov 25 2020

sfertile accepted D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

1 comment, but otherwise LGTM.

Nov 25 2020, 4:52 PM · Restricted Project

Nov 24 2020

sfertile committed rG4f5355ee7362: [PowerPC] Don't reuse an illegal typed load for int_to_fp conversion. (authored by sfertile).
[PowerPC] Don't reuse an illegal typed load for int_to_fp conversion.
Nov 24 2020, 12:48 PM
sfertile closed D91265: [PowerPC] Don't reuse the address of an illegal typed load for int_to_fp..
Nov 24 2020, 12:48 PM · Restricted Project, Restricted Project

Nov 23 2020

sfertile accepted D91272: [AIX] Support init priority.

LGTM.

Nov 23 2020, 10:17 AM · Restricted Project
sfertile added a comment to D91272: [AIX] Support init priority.

A couple of really minor comments, but otherwise LGTM.

Nov 23 2020, 8:20 AM · Restricted Project

Nov 20 2020

sfertile accepted D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.

LGTM.

Nov 20 2020, 6:55 AM · Restricted Project, Restricted Project

Nov 19 2020

sfertile added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Nov 19 2020, 10:18 AM · Restricted Project, Restricted Project
sfertile added inline comments to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.
Nov 19 2020, 10:03 AM · Restricted Project
sfertile added inline comments to D91611: [PowerPC][LLD] Detecting and fixing missing TLS relocation on __tls_get_addr.
Nov 19 2020, 8:36 AM · Restricted Project
sfertile added inline comments to D91272: [AIX] Support init priority.
Nov 19 2020, 7:54 AM · Restricted Project

Nov 18 2020

sfertile added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Nov 18 2020, 12:13 PM · Restricted Project, Restricted Project
sfertile accepted D90892: [AIX][FE] Support constructor/destructor attribute.

Thanks for the updates. LGTM.

Nov 18 2020, 8:54 AM · Restricted Project

Nov 17 2020

sfertile requested review of D91629: [PowerPC] Handle FP physical register in inline asm constraint..
Nov 17 2020, 7:06 AM · Restricted Project, Restricted Project

Nov 13 2020

sfertile added inline comments to D90892: [AIX][FE] Support constructor/destructor attribute.
Nov 13 2020, 7:56 AM · Restricted Project

Nov 12 2020

sfertile updated the diff for D86142: [LLD] Search archives for non-tentative defintions..
  • Add testing for warn-backrefs interaction.
  • Spelling fixes
  • Fix comments to use ## instead of # in lit test.
Nov 12 2020, 8:02 AM · Restricted Project, Restricted Project

Nov 11 2020

sfertile requested review of D91265: [PowerPC] Don't reuse the address of an illegal typed load for int_to_fp..
Nov 11 2020, 7:46 AM · Restricted Project, Restricted Project

Nov 9 2020

sfertile updated the diff for D86142: [LLD] Search archives for non-tentative defintions..
  • Added a detailed comment trying to capture some of the linked discussion and distill why we want the more complicated lookup behaviour (at least by default).
  • Added an option -fortran-common to toggle the new behaviour on/off.
Nov 9 2020, 10:34 AM · Restricted Project, Restricted Project

Nov 5 2020

sfertile added a comment to D86142: [LLD] Search archives for non-tentative defintions..

I think that if this behaviour is to be put under an option, it is on by default. This will permit users to use both GNU ld and lld with the same command line.

Nov 5 2020, 10:22 AM · Restricted Project, Restricted Project
sfertile updated the diff for D86142: [LLD] Search archives for non-tentative defintions..
  • Add comments about why we have the special lookup behaviour for common in archives..
  • Use NonCommon as opposed to UnCommon
  • switch second if to be an else if instead.
Nov 5 2020, 10:18 AM · Restricted Project, Restricted Project

Oct 28 2020

sfertile updated the diff for D86142: [LLD] Search archives for non-tentative defintions..
  • Added comment in the test describing why the behaviour change is needed.
  • Converted a dyn_cast to a cast.
  • Fixed paramater name to use lowercase.
  • Fixed .size directives in the test to refer to the correct object.
Oct 28 2020, 9:31 AM · Restricted Project, Restricted Project

Oct 27 2020

sfertile added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Oct 27 2020, 9:51 AM · Restricted Project, Restricted Project
sfertile added inline comments to D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.
Oct 27 2020, 8:49 AM · Restricted Project

Oct 26 2020

sfertile added inline comments to D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.
Oct 26 2020, 2:03 PM · Restricted Project
sfertile added a comment to D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.

Sorry, missed a comment.

Oct 26 2020, 2:01 PM · Restricted Project
sfertile added inline comments to D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.
Oct 26 2020, 1:57 PM · Restricted Project

Oct 22 2020

sfertile accepted D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.
Oct 22 2020, 1:49 PM · Restricted Project

Oct 16 2020

sfertile added inline comments to D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.
Oct 16 2020, 12:22 PM · Restricted Project

Oct 13 2020

sfertile added inline comments to D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.
Oct 13 2020, 1:56 PM · Restricted Project
sfertile added inline comments to D87504: [PowerPC][LLD] Support for PC Relative TLS for Local Dynamic.
Oct 13 2020, 8:58 AM · Restricted Project
sfertile added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Oct 13 2020, 7:13 AM · Restricted Project, Restricted Project

Oct 9 2020

sfertile added inline comments to D87029: [AIX] Implement AIX special bitfield related alignment rules.
Oct 9 2020, 8:04 AM · Restricted Project

Oct 8 2020

sfertile added a comment to D89044: [FE][AIX] Emit error for oversized long long bitfield under 32bit mode.

Thanks for splitting this out XiangLing.

Oct 8 2020, 1:05 PM
sfertile added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Oct 8 2020, 11:05 AM · Restricted Project, Restricted Project
sfertile closed D75059: [PowerPC] Remove support for VRSAVE save/restore/update..

Commited in https://reviews.llvm.org/rGdfb717da1f794c235b81a985a57dc238c82318e6

Oct 8 2020, 6:22 AM · Restricted Project, Restricted Project

Oct 6 2020

sfertile added inline comments to D87029: [AIX] Implement AIX special bitfield related alignment rules.
Oct 6 2020, 2:07 PM · Restricted Project

Oct 5 2020

sfertile added inline comments to D87029: [AIX] Implement AIX special bitfield related alignment rules.
Oct 5 2020, 12:43 PM · Restricted Project
sfertile added inline comments to D87029: [AIX] Implement AIX special bitfield related alignment rules.
Oct 5 2020, 11:45 AM · Restricted Project
sfertile added inline comments to D87029: [AIX] Implement AIX special bitfield related alignment rules.
Oct 5 2020, 8:01 AM · Restricted Project

Oct 1 2020

sfertile added a reviewer for D87029: [AIX] Implement AIX special bitfield related alignment rules: sfertile.
Oct 1 2020, 11:39 AM · Restricted Project
sfertile added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Oct 1 2020, 11:05 AM · Restricted Project, Restricted Project
sfertile added a comment to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.

More test coverage for this patch:

Oct 1 2020, 10:55 AM · Restricted Project, Restricted Project
sfertile updated subscribers of D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Oct 1 2020, 10:37 AM · Restricted Project, Restricted Project
sfertile accepted D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.

LGTM also.

Oct 1 2020, 6:53 AM · Restricted Project

Sep 30 2020

sfertile added inline comments to D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.
Sep 30 2020, 1:14 PM · Restricted Project
sfertile committed rGdfb717da1f79: [PowerPC] Remove support for VRSAVE save/restore/update. (authored by sfertile).
[PowerPC] Remove support for VRSAVE save/restore/update.
Sep 30 2020, 7:06 AM

Sep 29 2020

sfertile retitled D75059: [PowerPC] Remove support for VRSAVE save/restore/update. from [PowerPC][NFC] Remove support for VRSAVE save/restore/update. to [PowerPC] Remove support for VRSAVE save/restore/update..
Sep 29 2020, 1:26 PM · Restricted Project, Restricted Project
sfertile updated the diff for D75059: [PowerPC] Remove support for VRSAVE save/restore/update..

Rebased.

Sep 29 2020, 12:42 PM · Restricted Project, Restricted Project
sfertile added a comment to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

We are in a poor position since this depends on D75059 which I never commit-ed since as I realized it was not really NFC because we were wrongly inserting VR_SAVE code for AIX. This had the effect of emitting a fatal error if we used vector arguments, return values and I believe if we selected any vector instructions. I never went back and updated it because there was always something higher priority to work on. I have a non-NFC update I haven't posted which relies on the calling convention lowering to emit an error when passing vector arguments, and I add an error when returning vector arguments. I will post that shortly.

Sep 29 2020, 10:09 AM · Restricted Project

Sep 28 2020

sfertile added inline comments to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.
Sep 28 2020, 7:25 AM · Restricted Project

Sep 25 2020

sfertile added inline comments to D86142: [LLD] Search archives for non-tentative defintions..
Sep 25 2020, 12:40 PM · Restricted Project, Restricted Project
sfertile updated the diff for D86142: [LLD] Search archives for non-tentative defintions..
  • Add static on helper functions.
  • Use ## for comments in lit test.
  • Remove redundant parens
  • Ignore locals when looking for overriding symbol def.
Sep 25 2020, 12:24 PM · Restricted Project, Restricted Project

Sep 24 2020

sfertile added inline comments to D87318: [LLD][PowerPC] Add support for R_PPC64_GOT_TLSGD_PCREL34 used in TLS General Dynamic.
Sep 24 2020, 10:07 AM · Restricted Project
sfertile accepted D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits.

2 minor comments but otherwise LGTM.

Sep 24 2020, 6:39 AM · Restricted Project

Sep 23 2020

sfertile added a comment to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.

Does PPCMIPeephole::combineSEXTAndSHL have a similar problem that needs to be addressed?

I thought so, but it looks like that function is only called when PPCMIPeephole::simplifyCode sees an RLDICR Opcode which is a 64Bit only instruction. So it looks like we avoid this problem there.

Sep 23 2020, 2:02 PM · Restricted Project
sfertile updated the diff for D86142: [LLD] Search archives for non-tentative defintions..

Address review comments, switched test to use split-file instead of other inputs and macros, and simplified the test as much as possible.

Sep 23 2020, 12:02 PM · Restricted Project, Restricted Project

Sep 21 2020

sfertile added inline comments to D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk.
Sep 21 2020, 11:21 AM · Restricted Project
sfertile added a comment to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.

Does PPCMIPeephole::combineSEXTAndSHL have a similar problem that needs to be addressed?

Sep 21 2020, 10:53 AM · Restricted Project
sfertile added inline comments to D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk.
Sep 21 2020, 10:30 AM · Restricted Project
sfertile added inline comments to D87916: [PowerPC][LLD] Extend R2 save stub to support offsets of more than 26 bits.
Sep 21 2020, 8:46 AM · Restricted Project
sfertile added inline comments to D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk.
Sep 21 2020, 8:03 AM · Restricted Project

Sep 15 2020

sfertile updated the diff for D86142: [LLD] Search archives for non-tentative defintions..

Extended the patch so that lazy object files are handled the same as archives, and bitcode files are handled same as native objects, both in archives and as lazy object files.

Sep 15 2020, 7:31 AM · Restricted Project, Restricted Project

Sep 1 2020

sfertile accepted D86777: [PowerPC] Fix missing TLS symbol type..

One minor nit, but otherwise LGTM.

Sep 1 2020, 5:06 PM · Restricted Project
sfertile committed rGfecc27db1110: [PowerPC][AIX] Update save/restore offset for frame and base pointers. (authored by sfertile).
[PowerPC][AIX] Update save/restore offset for frame and base pointers.
Sep 1 2020, 11:14 AM
sfertile closed D85850: [PowerPC][AIX] Fix frame-pointer and base-pointer save/restore offset..
Sep 1 2020, 11:14 AM · Restricted Project, Restricted Project

Aug 31 2020

sfertile added a reviewer for D75059: [PowerPC] Remove support for VRSAVE save/restore/update.: ZarkoCA.
Aug 31 2020, 10:26 AM · Restricted Project, Restricted Project
sfertile updated the diff for D75059: [PowerPC] Remove support for VRSAVE save/restore/update..

Previous patch was not really NFC, since we were inserting VRSAVE pseudos on AIX, then emiting a fatal error in frame lowering. This was because we missed changing the condition gating the vrsave insertion to include the AIX abi.

Aug 31 2020, 10:26 AM · Restricted Project, Restricted Project
sfertile committed rG84875f694102: [PowerPC][AIX] Add test for returning a vector type. [NFC] (authored by sfertile).
[PowerPC][AIX] Add test for returning a vector type. [NFC]
Aug 31 2020, 8:26 AM

Aug 28 2020

sfertile accepted D86706: [LLD][PowerPC] Add a pc-rel based long branch thunk.

One minor nit, but otherwise LGTM. If Nemanja would still like the comment he suggested make sure to address that before committing.

Aug 28 2020, 7:05 AM · Restricted Project

Aug 27 2020

sfertile added inline comments to D86706: [LLD][PowerPC] Add a pc-rel based long branch thunk.
Aug 27 2020, 2:15 PM · Restricted Project
sfertile added inline comments to D86706: [LLD][PowerPC] Add a pc-rel based long branch thunk.
Aug 27 2020, 7:18 AM · Restricted Project

Aug 24 2020

sfertile added a comment to D86142: [LLD] Search archives for non-tentative defintions..

I've spent some time reading through the linked thread. Thanks. There is a lot to reply to so I hope I don't miss anything.

Aug 24 2020, 12:43 PM · Restricted Project, Restricted Project
sfertile added inline comments to D85850: [PowerPC][AIX] Fix frame-pointer and base-pointer save/restore offset..
Aug 24 2020, 10:14 AM · Restricted Project, Restricted Project
sfertile updated the diff for D85850: [PowerPC][AIX] Fix frame-pointer and base-pointer save/restore offset..
  • Removed now unused local variable.
  • Removed -framepointer=all option in lit test.
  • Fixed formatting of runsteps in new lit test.
Aug 24 2020, 10:12 AM · Restricted Project, Restricted Project

Aug 18 2020

sfertile added a comment to D85994: [LLD][PowerPC] Add check in LLD to produce an error for missing TLSGD/TLSLD.

I am unable to use the assembly files. The problem is that __tls_get_addr is a special name for the PPC backend and we cannot generate an object file from incorrect assembly. For example:

$ cat GeneralDynamic.s
	.text
GeneralDynamic:                         # @GeneralDynamic
	addis 3, 2, x@got@tlsgd@ha
	addi 3, 3, x@got@tlsgd@l
	bl __tls_get_addr()
	blr

Produces:

$ llvm-mc GeneralDynamic.s --filetype=obj -o /dev/null
GeneralDynamic.s:5:20: error: unknown token in expression
        bl __tls_get_addr()
                          ^
GeneralDynamic.s:5:20: error: invalid TLS call expression
        bl __tls_get_addr()
                          ^
Aug 18 2020, 8:38 AM · Restricted Project
sfertile requested review of D86142: [LLD] Search archives for non-tentative defintions..
Aug 18 2020, 7:21 AM · Restricted Project, Restricted Project

Aug 16 2020

sfertile accepted D85973: [PowerPC] Fix thunk alignment issue when using pc-rel instruction .

LGTM.

Aug 16 2020, 6:01 PM · Restricted Project

Aug 13 2020

sfertile added a comment to D84360: [LLD][PowerPC] Implement GOT to PC-Rel relaxation.

But that's what check_LD_STD_W_PADDI does. Do you mean that I should add checks for the actual values?

Aug 13 2020, 9:32 AM · Restricted Project, Restricted Project