Page MenuHomePhabricator

sfertile (Sean Fertile)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2016, 8:15 AM (133 w, 6 d)

Recent Activity

Fri, May 17

sfertile added inline comments to D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..
Fri, May 17, 9:55 AM · Restricted Project
sfertile added a comment to D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..

ping.

Fri, May 17, 9:23 AM · Restricted Project

Thu, May 16

sfertile added inline comments to D61532: implement of the parsing symbol table for xcoffobjfile and output as yaml format.
Thu, May 16, 8:52 PM · Restricted Project

Wed, May 15

sfertile added a reviewer for D61948: Implement call lowering without parameters on AIX: hfinkel.
Wed, May 15, 8:15 AM · Restricted Project

Tue, May 14

sfertile added inline comments to D61532: implement of the parsing symbol table for xcoffobjfile and output as yaml format.
Tue, May 14, 12:00 PM · Restricted Project
sfertile accepted D61900: [tests][go]Add -stdlib=libc++ to build GO test if LLVM is built with libc++.

LGTM.

Tue, May 14, 10:30 AM · Restricted Project

Mon, May 13

sfertile added a comment to D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..

ping

Mon, May 13, 7:47 PM · Restricted Project

Fri, May 10

sfertile accepted D61718: [llvm-objdump] Print st_other.

LGTM.

Fri, May 10, 6:50 AM · Restricted Project

Thu, May 9

sfertile accepted D61720: [PPC64] Define getThunkSectionSpacing() based on the range of R_PPC64_REL24.

The "simplest" number 0x2000000 works no worse than other numbers so I'll just use it.

Thu, May 9, 8:24 AM · Restricted Project

Wed, May 8

sfertile created D61694: Boilerplate for producing XCOFF object files from the PowerPC backend..
Wed, May 8, 1:01 PM · Restricted Project
sfertile added inline comments to D61532: implement of the parsing symbol table for xcoffobjfile and output as yaml format.
Wed, May 8, 10:52 AM · Restricted Project
sfertile added a comment to D61647: llvm-objdump: when ELF st_other field is set, print its value before symbol name.

MaskRay, looks like many tests under lld/tests are using llvm-objdump, a grep for llvm-objdump on this folder returned >1000 entries.

Wed, May 8, 10:18 AM · Restricted Project
sfertile added a comment to D61610: [PPC64] implement Thunk Section Spacing.
If PPC is anything like Arm, I would be very surprised to see a lot of inter-section conditional branches,
Wed, May 8, 8:11 AM · Restricted Project

Tue, May 7

sfertile added a comment to D61647: llvm-objdump: when ELF st_other field is set, print its value before symbol name.

Adding MaskRay as a reviewer for their familiarity with the llvm tools.

Tue, May 7, 1:44 PM · Restricted Project
sfertile added a reviewer for D61647: llvm-objdump: when ELF st_other field is set, print its value before symbol name: MaskRay.
Tue, May 7, 1:22 PM · Restricted Project
sfertile added a comment to D61610: [PPC64] implement Thunk Section Spacing.

Thanks for posting this @adalava.

Tue, May 7, 7:02 AM · Restricted Project

Fri, May 3

sfertile added inline comments to D61532: implement of the parsing symbol table for xcoffobjfile and output as yaml format.
Fri, May 3, 2:53 PM · Restricted Project
sfertile accepted D61530: Add AIX Version Macros.

LGTM

Fri, May 3, 1:07 PM · Restricted Project
sfertile committed rGfd75ee9154d2: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj. (authored by sfertile).
[Object][XCOFF] Add an XCOFF dumper for llvm-readobj.
Fri, May 3, 5:56 AM
sfertile committed rL359878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj..
[Object][XCOFF] Add an XCOFF dumper for llvm-readobj.
Fri, May 3, 5:55 AM
sfertile closed D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj.
Fri, May 3, 5:55 AM · Restricted Project

Thu, May 2

sfertile abandoned D54720: [PPC64] toc-indirect to toc-relative relaxation..

Abandoning in favour of D60958.

Thu, May 2, 9:12 AM · Restricted Project
sfertile added a comment to D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj.
Thu, May 2, 8:22 AM · Restricted Project
sfertile updated the diff for D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj.

Removed extra blank lines and added binaries into the diff.

Thu, May 2, 8:13 AM · Restricted Project

Tue, Apr 30

sfertile updated the diff for D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj.

Fixed return types to match the type of field being accessed.

Tue, Apr 30, 11:08 AM · Restricted Project
sfertile accepted D60958: [PPC64] toc-indirect to toc-relative relaxation.

LGTM.

Tue, Apr 30, 8:04 AM · Restricted Project

Thu, Apr 25

sfertile added a comment to D60958: [PPC64] toc-indirect to toc-relative relaxation.

Patch looks really good. I think you managed to explain the toc-indirection without getting to verbose which is something I've struggled with. I have a couple minor suggestions and I need to go over the test a bit more indepth but overall this looks good to me.

Thu, Apr 25, 5:01 PM · Restricted Project
sfertile committed rGa93a33cb87ec: [Object][XCOFF] Add intial support for section header table. (authored by sfertile).
[Object][XCOFF] Add intial support for section header table.
Thu, Apr 25, 2:38 PM
sfertile committed rL359244: [Object][XCOFF] Add intial support for section header table..
[Object][XCOFF] Add intial support for section header table.
Thu, Apr 25, 2:38 PM
sfertile closed D60784: [Object][XCOFF] Add intial support for parsing/dumping section header table..
Thu, Apr 25, 2:38 PM · Restricted Project

Wed, Apr 24

sfertile committed rG526633deea86: Add period at end of comment. (authored by sfertile).
Add period at end of comment.
Wed, Apr 24, 2:51 PM
sfertile committed rL359144: Add period at end of comment..
Add period at end of comment.
Wed, Apr 24, 2:50 PM

Tue, Apr 23

sfertile added a comment to D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj.

The format of the binaries included in the patch don't seem correct, they create empty files. As a result the corresponding test are failing.

Tue, Apr 23, 10:04 AM · Restricted Project
sfertile added a comment to D60958: [PPC64] toc-indirect to toc-relative relaxation.

Hi MaskRay.

Tue, Apr 23, 9:29 AM · Restricted Project

Mon, Apr 22

sfertile updated the summary of D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj.
Mon, Apr 22, 1:11 PM · Restricted Project
sfertile added a comment to D54720: [PPC64] toc-indirect to toc-relative relaxation..

@sfertile Didn't catch you these days on IRC...

I've created D60958 for my idea.

Mon, Apr 22, 10:23 AM · Restricted Project

Apr 18 2019

sfertile added inline comments to D60784: [Object][XCOFF] Add intial support for parsing/dumping section header table..
Apr 18 2019, 1:16 PM · Restricted Project
sfertile created D60885: [Object][XCOFF] Remove extra includes from XCOFF related files. [NFC].
Apr 18 2019, 1:15 PM · Restricted Project
sfertile added inline comments to D60784: [Object][XCOFF] Add intial support for parsing/dumping section header table..
Apr 18 2019, 12:46 PM · Restricted Project
sfertile added inline comments to D60784: [Object][XCOFF] Add intial support for parsing/dumping section header table..
Apr 18 2019, 12:17 PM · Restricted Project
sfertile created D60878: [Object][XCOFF] Add an XCOFF dumper for llvm-readobj.
Apr 18 2019, 10:17 AM · Restricted Project
sfertile accepted D60143: [compiler-rt][tests] Propagate COMPILER_RT_UNITTEST_LINK_FLAGS.

LGTM

Apr 18 2019, 10:12 AM · Restricted Project, Restricted Project
sfertile updated the diff for D60784: [Object][XCOFF] Add intial support for parsing/dumping section header table..
  1. Addressed @hubert.reinterpretcast comments
  2. Added the compiler and source used to generate the object file used in the test.
  3. Added test coverage of long section names (ie names of length 8 that are not null terminated)
  4. removed the checkSize function as there were no longer any users.
Apr 18 2019, 8:17 AM · Restricted Project

Apr 16 2019

sfertile added a reviewer for D60784: [Object][XCOFF] Add intial support for parsing/dumping section header table.: jasonliu.
Apr 16 2019, 10:41 AM · Restricted Project
sfertile created D60784: [Object][XCOFF] Add intial support for parsing/dumping section header table..
Apr 16 2019, 10:32 AM · Restricted Project
sfertile closed D60216: [PowerPC] Add support for encoding slbfee (SLB Find Entry ESID) instruction. .
Apr 16 2019, 10:21 AM · Restricted Project
sfertile closed D57331: [PowerPC] Fix printing of negative offsets in call instruction dissasembly..
Apr 16 2019, 7:53 AM · Restricted Project

Apr 15 2019

sfertile committed rG8d856488a897: Add slbfee instruction. (authored by sfertile).
Add slbfee instruction.
Apr 15 2019, 10:11 AM
sfertile committed rL358425: Add slbfee instruction..
Add slbfee instruction.
Apr 15 2019, 10:11 AM

Apr 3 2019

sfertile created D60216: [PowerPC] Add support for encoding slbfee (SLB Find Entry ESID) instruction. .
Apr 3 2019, 10:13 AM · Restricted Project

Mar 29 2019

sfertile accepted D59419: [XCOFF] Add functionality for parsing AIX XCOFF object files header . .

Other the a few minor nit picks, this LGTM.

Mar 29 2019, 6:46 AM · Restricted Project

Mar 28 2019

sfertile added inline comments to D54720: [PPC64] toc-indirect to toc-relative relaxation..
Mar 28 2019, 9:05 AM · Restricted Project

Mar 27 2019

sfertile added inline comments to D54720: [PPC64] toc-indirect to toc-relative relaxation..
Mar 27 2019, 8:42 AM · Restricted Project

Mar 20 2019

sfertile added a comment to D58951: [compiler-rt][tests] Improve handling with non-default toolchains.

Patch LGTM, but I think someone more familiar with compiler-rt cmake needs to be the one to accept it.

Mar 20 2019, 9:32 AM · Restricted Project, Restricted Project

Mar 19 2019

sfertile added a comment to D59419: [XCOFF] Add functionality for parsing AIX XCOFF object files header . .
In D59419#1435075, @rnk wrote:

My main question would be, how is this going to fit into MC and the rest of LLVM? We support 4(?) object file formats there now (ELF, COFF (pretty much assumes Windows), wasm, and MachO), and MC is not designed to be very extensible. Will Triple::isOSBinFormatCOFF return true for XCOFF, or will it be distinct?

Mar 19 2019, 11:12 AM · Restricted Project

Mar 18 2019

sfertile added a comment to D59419: [XCOFF] Add functionality for parsing AIX XCOFF object files header . .

I've added a few reviewers who have committed to the other file formats recently since none of us have a lot of experience with this part of llvm.

Mar 18 2019, 6:43 PM · Restricted Project
sfertile added reviewers for D59419: [XCOFF] Add functionality for parsing AIX XCOFF object files header . : mstorsjo, zturner.
Mar 18 2019, 6:34 PM · Restricted Project

Mar 8 2019

sfertile added inline comments to D59048: Add AIX Target Info.
Mar 8 2019, 8:01 AM · Restricted Project
sfertile accepted D58930: Add XCOFF triple object format type for AIX.

LGTM.

Mar 8 2019, 7:46 AM · Restricted Project, Restricted Project, Restricted Project

Mar 6 2019

sfertile added inline comments to D58930: Add XCOFF triple object format type for AIX.
Mar 6 2019, 10:04 AM · Restricted Project, Restricted Project, Restricted Project

Mar 4 2019

sfertile added a comment to D55501: [PPC64][PPC] add tests for R_PPC64_REL14 R_PPC_REL14.

Overall patch LGTM. Thanks for adding this. I have one small question about the llvm-readobj test though. IIUC the python file is used to generate the output files for test/tools/llvm-readobj/reloc-types.test. Do we need to run the python script to get the updated relocs.obj.elf-ppc64 file and update the checks for the added relocations in reloc-types.test?

Mar 4 2019, 7:41 PM · Restricted Project

Feb 21 2019

sfertile added inline comments to D58250: [AIX][CMake] Changes for building on AIX with XL and GCC.
Feb 21 2019, 8:42 AM · Restricted Project

Feb 15 2019

sfertile added inline comments to D58250: [AIX][CMake] Changes for building on AIX with XL and GCC.
Feb 15 2019, 8:58 AM · Restricted Project

Feb 12 2019

sfertile committed rG9850a4827510: Fix undefined behaviour in PPCInstPrinter::printBranchOperand. (authored by sfertile).
Fix undefined behaviour in PPCInstPrinter::printBranchOperand.
Feb 12 2019, 12:03 PM
sfertile committed rL353874: Fix undefined behaviour in PPCInstPrinter::printBranchOperand..
Fix undefined behaviour in PPCInstPrinter::printBranchOperand.
Feb 12 2019, 12:02 PM
sfertile committed rG0205828be4f1: [PPC64] Update tests to reflect change in printing of call operand. [NFC] (authored by sfertile).
[PPC64] Update tests to reflect change in printing of call operand. [NFC]
Feb 12 2019, 9:50 AM
sfertile committed rGc06945202726: [PowerPC] Fix printing of negative offsets in call instruction dissasembly. (authored by sfertile).
[PowerPC] Fix printing of negative offsets in call instruction dissasembly.
Feb 12 2019, 9:49 AM
sfertile committed rL353866: [PPC64] Update tests to reflect change in printing of call operand. [NFC].
[PPC64] Update tests to reflect change in printing of call operand. [NFC]
Feb 12 2019, 9:48 AM
sfertile committed rLLD353866: [PPC64] Update tests to reflect change in printing of call operand. [NFC].
[PPC64] Update tests to reflect change in printing of call operand. [NFC]
Feb 12 2019, 9:48 AM
sfertile committed rL353865: [PowerPC] Fix printing of negative offsets in call instruction dissasembly..
[PowerPC] Fix printing of negative offsets in call instruction dissasembly.
Feb 12 2019, 9:48 AM
sfertile committed rLLD353849: [PPC64] Sort .toc sections accessed with small code model relocs..
[PPC64] Sort .toc sections accessed with small code model relocs.
Feb 12 2019, 7:37 AM
sfertile committed rGd694160e665e: [PPC64] Sort .toc sections accessed with small code model relocs. (authored by sfertile).
[PPC64] Sort .toc sections accessed with small code model relocs.
Feb 12 2019, 7:36 AM
sfertile committed rL353849: [PPC64] Sort .toc sections accessed with small code model relocs..
[PPC64] Sort .toc sections accessed with small code model relocs.
Feb 12 2019, 7:36 AM
sfertile closed D57245: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got part 2.
Feb 12 2019, 7:35 AM · Restricted Project

Feb 6 2019

sfertile added inline comments to D57245: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got part 2.
Feb 6 2019, 12:02 PM · Restricted Project

Feb 5 2019

Herald added a project to D57331: [PowerPC] Fix printing of negative offsets in call instruction dissasembly.: Restricted Project.

ping

Feb 5 2019, 8:50 AM · Restricted Project
sfertile added inline comments to D57673: [PPC64] Set the number of relocations processed for R_PPC64_TLS[GL]D to 2.
Feb 5 2019, 8:49 AM · Restricted Project

Feb 4 2019

sfertile accepted D57673: [PPC64] Set the number of relocations processed for R_PPC64_TLS[GL]D to 2.

LGTM other then 1 minor comment.

Feb 4 2019, 9:23 AM · Restricted Project
sfertile added a comment to D57673: [PPC64] Set the number of relocations processed for R_PPC64_TLS[GL]D to 2.

If this is allowed. Is there any restriction on the TLS code sequence? e.g. Is it allowed to omit R_PPC64_GOT_TLSGD16_HA?

Feb 4 2019, 8:41 AM · Restricted Project

Jan 31 2019

sfertile added inline comments to D54720: [PPC64] toc-indirect to toc-relative relaxation..
Jan 31 2019, 1:31 PM · Restricted Project
sfertile added inline comments to D54720: [PPC64] toc-indirect to toc-relative relaxation..
Jan 31 2019, 9:46 AM · Restricted Project
sfertile updated the diff for D54720: [PPC64] toc-indirect to toc-relative relaxation..

Addressed several review comments, and fixed bug where I was erroneously relaxing preepmtible symbols.

Jan 31 2019, 9:05 AM · Restricted Project

Jan 30 2019

sfertile added inline comments to D57245: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got part 2.
Jan 30 2019, 10:50 AM · Restricted Project
sfertile updated the diff for D57245: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got part 2.

Updated /moved a few comments.

Jan 30 2019, 10:42 AM · Restricted Project

Jan 28 2019

sfertile retitled D57331: [PowerPC] Fix printing of negative offsets in call instruction dissasembly. from [PowerPC} Fix printing of negative offsets in call instruction dissasembly. to [PowerPC] Fix printing of negative offsets in call instruction dissasembly..
Jan 28 2019, 8:18 AM · Restricted Project
sfertile created D57331: [PowerPC] Fix printing of negative offsets in call instruction dissasembly..
Jan 28 2019, 8:18 AM · Restricted Project

Jan 25 2019

sfertile created D57245: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got part 2.
Jan 25 2019, 9:21 AM · Restricted Project

Jan 24 2019

sfertile added a comment to D54720: [PPC64] toc-indirect to toc-relative relaxation..

ping

Jan 24 2019, 7:20 PM · Restricted Project
sfertile updated the diff for D54720: [PPC64] toc-indirect to toc-relative relaxation..

rebased

Jan 24 2019, 7:19 PM · Restricted Project
sfertile committed rL352071: [PPC64] Reland r351978 'Sort .toc sections accessed with small code model ...'.
[PPC64] Reland r351978 'Sort .toc sections accessed with small code model ...'
Jan 24 2019, 10:17 AM
sfertile committed rLLD352071: [PPC64] Reland r351978 'Sort .toc sections accessed with small code model ...'.
[PPC64] Reland r351978 'Sort .toc sections accessed with small code model ...'
Jan 24 2019, 10:17 AM

Jan 23 2019

sfertile committed rLLD351985: Revert "[PPC64] Sort .toc sections accessed with small code model ...".
Revert "[PPC64] Sort .toc sections accessed with small code model ..."
Jan 23 2019, 1:46 PM
sfertile committed rL351985: Revert "[PPC64] Sort .toc sections accessed with small code model ...".
Revert "[PPC64] Sort .toc sections accessed with small code model ..."
Jan 23 2019, 1:46 PM
sfertile committed rLLD351978: [PPC64] Sort .toc sections accessed with small code model relocs close to .got..
[PPC64] Sort .toc sections accessed with small code model relocs close to .got.
Jan 23 2019, 1:04 PM
sfertile committed rL351978: [PPC64] Sort .toc sections accessed with small code model relocs close to .got..
[PPC64] Sort .toc sections accessed with small code model relocs close to .got.
Jan 23 2019, 1:04 PM
sfertile closed D56920: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got.
Jan 23 2019, 1:04 PM

Jan 22 2019

sfertile updated the diff for D56920: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got.

Addressed second round of review comments.

Jan 22 2019, 8:29 AM

Jan 21 2019

sfertile added inline comments to D56920: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got.
Jan 21 2019, 9:31 PM
sfertile updated the diff for D56920: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got.

Addressed review comments and cut down the test.

Jan 21 2019, 9:03 PM

Jan 18 2019

sfertile created D56920: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got.
Jan 18 2019, 9:56 AM