Page MenuHomePhabricator

sfertile (Sean Fertile)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 24 2016, 8:15 AM (242 w, 3 d)

Recent Activity

Tue, Jun 15

sfertile commandeered D101470: [XCOFF][AIX] Peephole optimization in TocData transformation.
Tue, Jun 15, 4:00 PM · Restricted Project
sfertile added a reviewer for D103103: [PowerPC][XCOFF] Create 8 and 16 byte aligned constant csects.: cebowleratibm.
Tue, Jun 15, 3:58 PM · Restricted Project, Restricted Project
sfertile added inline comments to D100132: [libunwind][AIX] implementation of the unwinder for AIX.
Tue, Jun 15, 10:55 AM · Restricted Project, Restricted Project
sfertile added a comment to D103103: [PowerPC][XCOFF] Create 8 and 16 byte aligned constant csects..

ping.

Tue, Jun 15, 7:49 AM · Restricted Project, Restricted Project
sfertile added inline comments to D100132: [libunwind][AIX] implementation of the unwinder for AIX.
Tue, Jun 15, 7:49 AM · Restricted Project, Restricted Project

Mon, Jun 14

sfertile added inline comments to D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..
Mon, Jun 14, 6:08 PM · Restricted Project
sfertile added a comment to D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.

Hello,
For you information, we have had trouble with arcanist configuration, and my account is used to push to review. Patch has been written by @MaryamBen, as confirmed by commit author.
Comments in push message are also made @MaryamBen.
Regards.

Mon, Jun 14, 10:27 AM · Restricted Project
sfertile added inline comments to D100132: [libunwind][AIX] implementation of the unwinder for AIX.
Mon, Jun 14, 8:52 AM · Restricted Project, Restricted Project

Fri, Jun 11

sfertile added inline comments to D100132: [libunwind][AIX] implementation of the unwinder for AIX.
Fri, Jun 11, 8:16 AM · Restricted Project, Restricted Project

Thu, Jun 10

sfertile accepted D101298: [libc++abi][AIX] Enable calculating addresses with DW_EH_PE_datarel.

Thanks for the updates Xing, LGTM.

Thu, Jun 10, 11:24 AM · Restricted Project, Restricted Project

Wed, Jun 9

sfertile added inline comments to D103651: [AIX][XCOFF] generate eh_info when vector registers are saved according to the traceback table..
Wed, Jun 9, 2:08 PM · Restricted Project
sfertile added inline comments to D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.
Wed, Jun 9, 11:07 AM · Restricted Project
sfertile added inline comments to D101298: [libc++abi][AIX] Enable calculating addresses with DW_EH_PE_datarel.
Wed, Jun 9, 8:00 AM · Restricted Project, Restricted Project

Tue, Jun 8

sfertile accepted D103901: [NFC][XCOFF] Replace structs FileHeader32/SectionHeader32 with constants..

One comment but otherwise LGTM.

Tue, Jun 8, 9:21 AM · Restricted Project
sfertile added inline comments to D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.
Tue, Jun 8, 7:06 AM · Restricted Project

Mon, Jun 7

sfertile added a comment to D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..

Thanks for working on this. I'm excited to finally replace all the precompiled objects we used for testing the XCOFF tools implementation. I've only got one initial comment since I'm not real familiar with this part fo the code yet, but will spend some more time going over this tomorrow.

Mon, Jun 7, 8:41 PM · Restricted Project
sfertile added a comment to D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.

I don't think the YAML tools support generating 64-bit XCOFF objects yet, but we can add a precompiled object file as test input.

https://reviews.llvm.org/D100375 is ready for review, so I would suggest we use yam2obj base on that .
It would be great if we can help review and test D100375.

Mon, Jun 7, 7:37 PM · Restricted Project
sfertile added a comment to D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.

Thanks for working on this. My first suggestion is we need to break up this patch to make it smaller and easier to review. The natural place to partition it is the llvm-readobj functionality. I don't think the YAML tools support generating 64-bit XCOFF objects yet, but we can add a precompiled object file as test input.

Mon, Jun 7, 10:34 AM · Restricted Project

Wed, Jun 2

sfertile committed rG81f7607f7c7d: [PowerPC][AIX} FIx AIX bootstrap build. (authored by sfertile).
[PowerPC][AIX} FIx AIX bootstrap build.
Wed, Jun 2, 6:32 AM
sfertile closed D103474: [PowerPC][AIX] Fix static_assert while bootstrapping..
Wed, Jun 2, 6:32 AM · Restricted Project, Restricted Project

Tue, Jun 1

sfertile requested review of D103474: [PowerPC][AIX] Fix static_assert while bootstrapping..
Tue, Jun 1, 10:57 AM · Restricted Project, Restricted Project

Tue, May 25

sfertile added a comment to D102632: [libcxx/cxxabi/unwind][AIX] Add an AIX target and config for testing..

Ping.

Tue, May 25, 1:15 PM · Restricted Project
sfertile requested review of D103103: [PowerPC][XCOFF] Create 8 and 16 byte aligned constant csects..
Tue, May 25, 10:48 AM · Restricted Project, Restricted Project

May 17 2021

sfertile requested review of D102632: [libcxx/cxxabi/unwind][AIX] Add an AIX target and config for testing..
May 17 2021, 8:26 AM · Restricted Project

May 15 2021

sfertile accepted D87029: [AIX] Implement AIX special bitfield related alignment rules.

LGTM.

May 15 2021, 10:41 AM · Restricted Project

May 10 2021

sfertile accepted D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings.

Thanks Xing, LGTM.

May 10 2021, 6:31 AM · Restricted Project, Restricted Project

May 6 2021

sfertile accepted D100214: [AIX][TLS] Add support for TLSGD relocations to XCOFF objects.

Thanks for the updates Victor, LGTM.

May 6 2021, 6:33 AM · Restricted Project

May 3 2021

sfertile added inline comments to D100214: [AIX][TLS] Add support for TLSGD relocations to XCOFF objects.
May 3 2021, 10:28 AM · Restricted Project
sfertile added a comment to D101298: [libc++abi][AIX] Enable calculating addresses with DW_EH_PE_datarel.

This version is clean of format changes made by clang-format.

May 3 2021, 8:45 AM · Restricted Project, Restricted Project
sfertile added inline comments to D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings.
May 3 2021, 8:45 AM · Restricted Project, Restricted Project

Apr 30 2021

sfertile accepted D101178: [XCOFF][AIX] Add Global Variables Directly to TOC for 32 bit AIX.

Great work Sidharth, a couple minor nits but otherwise the patch LGTM.

Apr 30 2021, 6:13 AM · Restricted Project

Apr 29 2021

sfertile added a comment to D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings.

I keep feeling that the AIX implementation probably needs its own file. Making Itanium/ARM/SEH share some functions actually make generic code improvement harder.

Apr 29 2021, 10:40 AM · Restricted Project, Restricted Project

Apr 28 2021

sfertile added inline comments to D101178: [XCOFF][AIX] Add Global Variables Directly to TOC for 32 bit AIX.
Apr 28 2021, 6:13 PM · Restricted Project
sfertile added a comment to D101470: [XCOFF][AIX] Peephole optimization in TocData transformation.

Awesome work Sidarth, patch looks really good. I've got one initial comment.

Apr 28 2021, 5:57 PM · Restricted Project
sfertile added inline comments to D101178: [XCOFF][AIX] Add Global Variables Directly to TOC for 32 bit AIX.
Apr 28 2021, 12:23 PM · Restricted Project
sfertile accepted D100956: [AIX][TLS] Add ASM portion changes to support TLSGD relocations to XCOFF objects .

One minor nit but otherwise LGTM.

Apr 28 2021, 8:17 AM · Restricted Project

Apr 27 2021

sfertile added inline comments to D101178: [XCOFF][AIX] Add Global Variables Directly to TOC for 32 bit AIX.
Apr 27 2021, 5:50 AM · Restricted Project

Apr 26 2021

sfertile added a comment to D101178: [XCOFF][AIX] Add Global Variables Directly to TOC for 32 bit AIX.

Thanks for the quick updates. Patch is getting really close I think.

Apr 26 2021, 6:49 PM · Restricted Project
sfertile added inline comments to D101298: [libc++abi][AIX] Enable calculating addresses with DW_EH_PE_datarel.
Apr 26 2021, 6:10 PM · Restricted Project, Restricted Project
sfertile added inline comments to D101178: [XCOFF][AIX] Add Global Variables Directly to TOC for 32 bit AIX.
Apr 26 2021, 10:17 AM · Restricted Project
sfertile added inline comments to D101178: [XCOFF][AIX] Add Global Variables Directly to TOC for 32 bit AIX.
Apr 26 2021, 9:55 AM · Restricted Project
sfertile accepted D101179: [libunwind] NFC: Use macros to accommodate differences in representation of PowerPC assemblers.

Thanks for splitting this out Xing. I suggest showing the syntax differences between gas and AIX assembly we intend to work around with these macros in the commit message. LGTM.

Apr 26 2021, 8:29 AM · Restricted Project, Restricted Project

Apr 22 2021

sfertile added inline comments to D100132: [libunwind][AIX] implementation of the unwinder for AIX.
Apr 22 2021, 1:30 PM · Restricted Project, Restricted Project
sfertile added inline comments to D100956: [AIX][TLS] Add ASM portion changes to support TLSGD relocations to XCOFF objects .
Apr 22 2021, 12:17 PM · Restricted Project
sfertile added inline comments to D100956: [AIX][TLS] Add ASM portion changes to support TLSGD relocations to XCOFF objects .
Apr 22 2021, 10:41 AM · Restricted Project

Apr 20 2021

sfertile added a comment to D100214: [AIX][TLS] Add support for TLSGD relocations to XCOFF objects.

Patch looks pretty good. IIUC we were not printing the '@gd' specifier before because it is assumed by default by the system assembler. Now that we are adding object file support we can no longer rely of the system assembler to assume the specifier based on the storage mapping class ,and need to add the new variant kinds so we create the correct relocations, which has the side effect of also changing the asm we emit. I know I am being pedantic, but I think we should land that part of the change and the update to the asm test in an initial patch even though the object writing is the motivation for adding it.

Apr 20 2021, 8:53 AM · Restricted Project

Mar 24 2021

sfertile added a comment to D91426: [PowerPC] Fix issue where binary uses a .got but is missing a .TOC..

Could there be a simpler approach where we always emit a .got section on PPC64: In addReservedSymbols if we fail to resolve .TOC. then we create it?

We could do that and it would certainly solve the problem. The issue I have with that is that we will now have a .got for everything we link including things that we used to link in the past that did not require it. It seems odd to say that since the design of the linker won't allow us to do this easily we will generate this section whether we need it or not.

Mar 24 2021, 12:30 PM · Restricted Project

Mar 8 2021

sfertile accepted D98078: [AIX][TLS] Generate 64-bit general-dynamic access code sequence.

LGTM.

Mar 8 2021, 12:42 PM · Restricted Project
sfertile accepted D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.

discussed with sean offline, the we do not call the emitGlobalDtorWithCXAAtExit() in AIX. so we do not have the problem for the "__dso_handle"

I initially had concerns with the places clang introduces non-default visibility in codegen. The few cases I was worried we would hit were related to static init , but that was before @Xiangling_L static init related work. After those changes I have no other concerns. I would wait a day or two to ensure that there are no more comments related to the round-trip-args behaviour but otherwise LGTM.

Mar 8 2021, 9:47 AM · Restricted Project

Mar 6 2021

sfertile committed rGf0904a62085a: [PowePC][AIX] Handle variadic vector call operands. (authored by sfertile).
[PowePC][AIX] Handle variadic vector call operands.
Mar 6 2021, 10:51 AM
sfertile closed D97956: [PowePC][AIX] Handle variadic vector call operands..
Mar 6 2021, 10:51 AM · Restricted Project, Restricted Project

Mar 5 2021

sfertile added inline comments to D97909: [AIX] Allow safe for 32bit P8 VSX pattern matching.
Mar 5 2021, 12:24 PM · Restricted Project
sfertile accepted D97948: [AIX][TLS] Generate 32-bit general-dynamic access code sequence.

Thanks for the updates Lei. LGTM.

Mar 5 2021, 11:02 AM · Restricted Project
sfertile accepted D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.

One minor comment but otherwise LGTM.

Mar 5 2021, 9:09 AM · Restricted Project, Restricted Project
sfertile updated the diff for D97956: [PowePC][AIX] Handle variadic vector call operands..
  • clang-formated lambda
  • changed check-prefixes to check-prefix
  • added whitespace between 32-bit and 64-bit check lines
  • Changed check for further custom RegLcos to include that the ValNo of the next RegLoc is the same as the original ValNo.
Mar 5 2021, 8:55 AM · Restricted Project, Restricted Project
sfertile added inline comments to D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Mar 5 2021, 7:07 AM · Restricted Project, Restricted Project
sfertile added a comment to D97948: [AIX][TLS] Generate 32-bit general-dynamic access code sequence.

Patch looks good Lei, the one thing we are missing though is a lit test that checks for the expected toc entries.

Mar 5 2021, 5:58 AM · Restricted Project

Mar 4 2021

sfertile added inline comments to D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Mar 4 2021, 2:58 PM · Restricted Project, Restricted Project
sfertile retitled D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX from [AIX] Enable the default AltiVec ABI on AIX to [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Mar 4 2021, 12:26 PM · Restricted Project, Restricted Project
sfertile accepted D97418: [PowerPC] Disable more extended mne on AIX.

LGTM.

Mar 4 2021, 12:24 PM · Restricted Project
sfertile requested review of D97956: [PowePC][AIX] Handle variadic vector call operands..
Mar 4 2021, 8:22 AM · Restricted Project, Restricted Project
sfertile committed rGaaeffbe00736: [PowerPC][AIX] Handle variadic vector formal arguments. (authored by sfertile).
[PowerPC][AIX] Handle variadic vector formal arguments.
Mar 4 2021, 7:58 AM
sfertile closed D97485: [PowerPC][AIX] Handle variadic vector formal arguments..
Mar 4 2021, 7:58 AM · Restricted Project, Restricted Project
sfertile retitled D97485: [PowerPC][AIX] Handle variadic vector formal arguments. from PowerPC][AIX] Handle variadic vector formal arguments. to [PowerPC][AIX] Handle variadic vector formal arguments..
Mar 4 2021, 6:34 AM · Restricted Project, Restricted Project

Mar 3 2021

sfertile updated the diff for D97485: [PowerPC][AIX] Handle variadic vector formal arguments..

Fix formating on assert.

Mar 3 2021, 3:52 PM · Restricted Project, Restricted Project
sfertile added inline comments to D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Mar 3 2021, 8:20 AM · Restricted Project, Restricted Project
sfertile added inline comments to D97485: [PowerPC][AIX] Handle variadic vector formal arguments..
Mar 3 2021, 7:42 AM · Restricted Project, Restricted Project
sfertile updated the diff for D97485: [PowerPC][AIX] Handle variadic vector formal arguments..
  • Add asserts that the ValNo of custom RegLocs match the ValNo of the custom MemLoc.
  • Assert that we are targeting 32-bit codegen when we have 4 custom RegLocs.
  • Add comments to the tests to make it easier to determine what is being tested.
Mar 3 2021, 7:32 AM · Restricted Project, Restricted Project

Mar 2 2021

sfertile added inline comments to D97485: [PowerPC][AIX] Handle variadic vector formal arguments..
Mar 2 2021, 8:33 AM · Restricted Project, Restricted Project
sfertile updated the diff for D97485: [PowerPC][AIX] Handle variadic vector formal arguments..
  • Converted loop to explicit handling of custom RegLocs
  • Added const on member function.
Mar 2 2021, 8:31 AM · Restricted Project, Restricted Project
sfertile added inline comments to D97485: [PowerPC][AIX] Handle variadic vector formal arguments..
Mar 2 2021, 7:12 AM · Restricted Project, Restricted Project

Mar 1 2021

sfertile added inline comments to D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Mar 1 2021, 10:43 AM · Restricted Project, Restricted Project
sfertile committed rG3f40dbbbc71d: [PowerPC][AIX] Enable passing vectors in variadic functions. (authored by sfertile).
[PowerPC][AIX] Enable passing vectors in variadic functions.
Mar 1 2021, 10:09 AM
sfertile closed D97474: [PowerPC][AIX] Enable passing vectors in variadic functions (front-end)..
Mar 1 2021, 10:09 AM · Restricted Project, Restricted Project

Feb 28 2021

sfertile updated the diff for D97485: [PowerPC][AIX] Handle variadic vector formal arguments..

Fixed a number of formatting and spelling mistakes.

Feb 28 2021, 7:52 AM · Restricted Project, Restricted Project

Feb 25 2021

sfertile requested review of D97485: [PowerPC][AIX] Handle variadic vector formal arguments..
Feb 25 2021, 9:32 AM · Restricted Project, Restricted Project
sfertile requested review of D97474: [PowerPC][AIX] Enable passing vectors in variadic functions (front-end)..
Feb 25 2021, 7:33 AM · Restricted Project, Restricted Project

Feb 18 2021

sfertile committed rGbb260b1ca7d5: [PowerPC][AIX] Add support for vector arg passing on the stack. (authored by sfertile).
[PowerPC][AIX] Add support for vector arg passing on the stack.
Feb 18 2021, 10:35 AM
sfertile closed D96415: [PowerPC][AIX] Support passing vector arguments on the stack..
Feb 18 2021, 10:34 AM · Restricted Project, Restricted Project

Feb 17 2021

sfertile added inline comments to D96351: [PowerPC][AIX] Enable the default AltiVec ABI on AIX.
Feb 17 2021, 9:48 AM · Restricted Project, Restricted Project
sfertile added a comment to D91426: [PowerPC] Fix issue where binary uses a .got but is missing a .TOC..

Could there be a simpler approach where we always emit a .got section on PPC64: In addReservedSymbols if we fail to resolve .TOC. then we create it?

Feb 17 2021, 7:29 AM · Restricted Project
sfertile committed rG4e127bce2d11: [PowerPC] Handle FP physical register in inline asm constraint. (authored by sfertile).
[PowerPC] Handle FP physical register in inline asm constraint.
Feb 17 2021, 6:29 AM
sfertile closed D91629: [PowerPC] Handle FP physical register in inline asm constraint..
Feb 17 2021, 6:29 AM · Restricted Project, Restricted Project
sfertile accepted D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..

LGTM.

Feb 17 2021, 6:21 AM · Restricted Project
sfertile retitled D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX. from [ShrinkWrap] Enable Shrinkwrapping on 32 and 64 bit AIX, and 64 bit ELF to [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Feb 17 2021, 6:17 AM · Restricted Project

Feb 16 2021

sfertile added inline comments to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Feb 16 2021, 7:44 AM · Restricted Project

Feb 12 2021

sfertile accepted D96184: [AIX][TLS] Generate TLS variables in assembly files.

LGTM. Please wait until David has given it the OK too though.

Feb 12 2021, 10:39 AM · Restricted Project, Restricted Project
sfertile added inline comments to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Feb 12 2021, 10:23 AM · Restricted Project
sfertile added inline comments to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Feb 12 2021, 9:49 AM · Restricted Project
sfertile added inline comments to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Feb 12 2021, 8:37 AM · Restricted Project

Feb 11 2021

sfertile accepted D96346: [NFC][PPC] Refactor TOC representation to allow several entries for the same symbol.

Thanks for the update. LGTM.

Feb 11 2021, 12:58 PM · Restricted Project, Restricted Project
sfertile added a comment to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..

I'll need a bit more time to finish going through ppc-shrink-wrapping.ll but the patch is looking really good. Thanks for the updates.

Feb 11 2021, 9:24 AM · Restricted Project
sfertile added inline comments to D96346: [NFC][PPC] Refactor TOC representation to allow several entries for the same symbol.
Feb 11 2021, 6:38 AM · Restricted Project, Restricted Project

Feb 10 2021

sfertile added inline comments to D96415: [PowerPC][AIX] Support passing vector arguments on the stack..
Feb 10 2021, 12:54 PM · Restricted Project, Restricted Project
sfertile updated the diff for D96415: [PowerPC][AIX] Support passing vector arguments on the stack..

Addressed review comments.

Feb 10 2021, 12:54 PM · Restricted Project, Restricted Project
sfertile added inline comments to D96346: [NFC][PPC] Refactor TOC representation to allow several entries for the same symbol.
Feb 10 2021, 11:43 AM · Restricted Project, Restricted Project
sfertile added a comment to D91629: [PowerPC] Handle FP physical register in inline asm constraint..

ping.

Feb 10 2021, 10:04 AM · Restricted Project, Restricted Project
sfertile added inline comments to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Feb 10 2021, 9:58 AM · Restricted Project
sfertile added inline comments to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Feb 10 2021, 8:20 AM · Restricted Project
sfertile added inline comments to D95094: [PowerPC][AIX] Enable Shrinkwrapping on 32 and 64 bit AIX..
Feb 10 2021, 7:29 AM · Restricted Project