peter.smith (Peter Smith)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 11 2016, 8:56 AM (54 w, 22 h)

Recent Activity

Today

peter.smith added a comment to D32233: [LLD][ELF] User linkerscript InputSectionDescription for .ARM.exidx dependency order.

I've created D32485 for an alternative implementation that just makes the link order sections orphans. I think that this ends up being a bit simpler overall.

Tue, Apr 25, 6:46 AM
peter.smith created D32485: [LLD][ELF] Make SHF_LINK_ORDER sections orphans.
Tue, Apr 25, 6:44 AM
peter.smith added a comment to D32223: [LLD][ELF] Add InputSectionDescriptions for Orphan Sections.

The main difficulty in creating and adding the Orphan OutputSectionCommand in addOrphanSections() is that we don't have a good idea of where in the order of OutputSectionCommands to insert them. The placeOrphanSections() is intentionally run immediately after sortSections() has been called so that it can insert the OutputSectionCommands in the right place. There is a comment in Writer.c in sortSections() that says:

// The way we define an order then is:
// *  First put script sections at the start and sort the script and
//    non-script sections independently.
// *  Move each non-script section to its preferred position. We try
//    to put each section in the last position where it it can share
//    a PT_LOAD.

It may be possible to create the Orphan OutputSectionCommands early and have the comparison routine work out the ordering, although there is a comment in the same block as the one above that claims that coming up with a strict weak ordering to get the desired result is not easy.

Tue, Apr 25, 4:09 AM
peter.smith added a comment to D32233: [LLD][ELF] User linkerscript InputSectionDescription for .ARM.exidx dependency order.

I can think of some options, although each has their own trade-off. Apologies for the length of the answer.

Tue, Apr 25, 3:29 AM

Fri, Apr 21

peter.smith added a comment to D32355: [ELF] - Remove dead TLS relocations relative code for MIPS and ARM.

I don't have any objections to it being removed. It can be reintroduced if we need it later.

Fri, Apr 21, 8:51 AM
peter.smith added a comment to D32072: [AArch64] ILP32 Backend Relocation Support.

I've spotted what I think is one mistake, R_AARCH64_P32_TLSDESC_ADR_PREL19 should be R_AARCH64_P32_TLSDESC_ADR_PREL21. I've put some suggestions for some missing test cases as well. Other than that I can't spot any obvious problems.

Fri, Apr 21, 3:24 AM

Wed, Apr 19

peter.smith created D32233: [LLD][ELF] User linkerscript InputSectionDescription for .ARM.exidx dependency order.
Wed, Apr 19, 9:43 AM
peter.smith created D32223: [LLD][ELF] Add InputSectionDescriptions for Orphan Sections.
Wed, Apr 19, 6:46 AM
peter.smith added a comment to D31888: [LLD][ELF] Always use Script::assignAddresses().

Now committed r300687.

Wed, Apr 19, 6:01 AM
peter.smith accepted D32053: Define __tls_get_addr as a hidden symbol even for ARM or MIPS..

I agree that the code is now redundant and can be removed. It used to be the case that addIgnored() would define the symbol even when there was an existing definition and cause a duplicate error. It looks like this was later fixed in -r287125 Don't error if __tls_get_addr is defined.

Wed, Apr 19, 3:13 AM

Thu, Apr 13

peter.smith abandoned D32030: [LLD][ELF] Work in progress of using InputSectionDescriptions for createThunks().

Marking as abandoned as this patch is for communication only.

Thu, Apr 13, 10:11 AM
peter.smith created D32030: [LLD][ELF] Work in progress of using InputSectionDescriptions for createThunks().
Thu, Apr 13, 10:10 AM
peter.smith added a comment to D31888: [LLD][ELF] Always use Script::assignAddresses().

Thanks for the review. I'll hold off on committing this till I get back from the UK Easter public holidays just in case this causes problems outside of the tests and I'm not around to fix them.

Thu, Apr 13, 5:26 AM

Tue, Apr 11

peter.smith created D31932: [LLD][ELF] Mark ARM Exceptions that refer to folded code as not live.
Tue, Apr 11, 5:51 AM
peter.smith added inline comments to D31751: [LLD][ELF] Tidy up handleARMTlsRelocation [NFC].
Tue, Apr 11, 3:12 AM
peter.smith updated the diff for D31888: [LLD][ELF] Always use Script::assignAddresses().

Updated diff to address review comments.
Apologies for leaving PHDRS in, I had originally attempted to merge fixSectionAlignments() into FabricateSectionAlignments(), but decided against it.

Tue, Apr 11, 2:12 AM

Mon, Apr 10

peter.smith created D31888: [LLD][ELF] Always use Script::assignAddresses().
Mon, Apr 10, 8:13 AM

Fri, Apr 7

peter.smith updated the diff for D31751: [LLD][ELF] Tidy up handleARMTlsRelocation [NFC].

Yes, we can use Config->Shared instead, thanks for pointing that out. I've updated to use Config->Shared and have put back the use of TlsOffsetRel in the Got, it could be possible to add another field to make it use a more regular relocation code, but I'm not sure that is a net win in readability. I'm happy to make the change if it is important to others though.

Fri, Apr 7, 3:02 AM
peter.smith added a comment to D31749: [LLD][ELF] Fix ARM TLS global dynamic TlsOffsetRel for non-preemtible symbols.

I've used the regular relocation code for this change.

Fri, Apr 7, 2:50 AM

Thu, Apr 6

peter.smith abandoned D31672: [LLD][ELF] Fix ARM TLS global dynamic TlsOffsetRel for non-preemptible symbols.

I've split this into 3 reviews:
D31748 Split handleNoRelaxTlsRelocation into ARM and Mips specific impls
D31749 Fix ARM TLS global dynamic TlsOffsetRel for non-preemtible symbols
D31751 Tidy up handleARMTlsRelocation [NFC]
To separate out the refactoring from the fix.

Thu, Apr 6, 3:40 AM
peter.smith created D31751: [LLD][ELF] Tidy up handleARMTlsRelocation [NFC].
Thu, Apr 6, 3:32 AM
peter.smith created D31749: [LLD][ELF] Fix ARM TLS global dynamic TlsOffsetRel for non-preemtible symbols.
Thu, Apr 6, 3:29 AM
peter.smith created D31748: [LLD][ELF] Split handleNoRelaxTlsRelocation into ARM and Mips specific impls [NFC].
Thu, Apr 6, 3:25 AM

Wed, Apr 5

peter.smith updated the diff for D31672: [LLD][ELF] Fix ARM TLS global dynamic TlsOffsetRel for non-preemptible symbols.

I think at least some of the difficulty in understanding the code here is that there are too many somewhat arbitrary ARM and Mips specific bits of code here. I've updated the diff to split handleNoRelaxTlsRelocation() into an ARM and Mips specific function, this allows us to take out some of the special cases.

Wed, Apr 5, 9:27 AM
peter.smith updated the diff for D31663: [LLD][ELF] Account for range thunk that has drifted out of range.

Rebased to take account of changes in D31654

Wed, Apr 5, 6:23 AM
peter.smith updated the diff for D31662: [LLD][ELF] Introduce range extension thunks for ARM.

Rebased to account for changes in D31654

Wed, Apr 5, 6:19 AM
peter.smith updated the diff for D31661: [LLD][ELF] Pre-create ThunkSections at Target specific intervals.

Rebased to account for changes in D31654

Wed, Apr 5, 6:15 AM
peter.smith updated the diff for D31660: [LLD][ELF] Allow multiple thunks to be added for a symbol..

Rebase to account for changes made in D31654

Wed, Apr 5, 5:47 AM
peter.smith updated the diff for D31658: [LLD][ELF] Introduce Thunk reuse compatibility.

Rebased to account for changes in D31654

Wed, Apr 5, 5:41 AM
peter.smith updated the diff for D31657: [LLD][ELF] Make createThunks() iterate until no more thunks added.

Rebased patch after earlier changes made to D31654

Wed, Apr 5, 4:22 AM
peter.smith updated the diff for D31656: [LLD][ELF] Fix Thunks with placement restrictions and linker scripts.

Rebasing patch on top of recent linkerscript refactoring.

Wed, Apr 5, 4:17 AM
peter.smith accepted D31682: Fix PLT and GOTPLT entries for x86 PIC..

That looks good to me. I agree that it is the better solution to not assume anything about the relative locations of .got and .got.plt

Wed, Apr 5, 2:05 AM

Tue, Apr 4

peter.smith created D31672: [LLD][ELF] Fix ARM TLS global dynamic TlsOffsetRel for non-preemptible symbols.
Tue, Apr 4, 9:49 AM
peter.smith created D31666: [LLD][ELF] Add test cases for range extension thunks using linker scripts.
Tue, Apr 4, 4:49 AM
peter.smith created D31665: [LLD][ELF] Add test cases for range extension thunks (no linkerscripts).
Tue, Apr 4, 4:47 AM
peter.smith created D31664: [LLD][ELF] Prefer placing ThunkSections before non ThunkSections.
Tue, Apr 4, 4:40 AM
peter.smith created D31663: [LLD][ELF] Account for range thunk that has drifted out of range.
Tue, Apr 4, 4:34 AM
peter.smith created D31662: [LLD][ELF] Introduce range extension thunks for ARM.
Tue, Apr 4, 4:31 AM
peter.smith created D31661: [LLD][ELF] Pre-create ThunkSections at Target specific intervals.
Tue, Apr 4, 4:16 AM
peter.smith created D31660: [LLD][ELF] Allow multiple thunks to be added for a symbol..
Tue, Apr 4, 4:08 AM
peter.smith created D31659: [LLD][ELF] Be more precise about Thumb state bit in ARM thunks.
Tue, Apr 4, 4:06 AM
peter.smith created D31658: [LLD][ELF] Introduce Thunk reuse compatibility.
Tue, Apr 4, 4:03 AM
peter.smith created D31657: [LLD][ELF] Make createThunks() iterate until no more thunks added.
Tue, Apr 4, 4:00 AM
peter.smith abandoned D30641: [LLD][ELF] Fix ordering of Mips LA25 Thunks when Linker Script used.

Abandoning this revision in favour of D31656, which is more general and can handle range extension thunks.

Tue, Apr 4, 3:55 AM
peter.smith updated the summary of D31656: [LLD][ELF] Fix Thunks with placement restrictions and linker scripts.
Tue, Apr 4, 3:54 AM
peter.smith created D31656: [LLD][ELF] Fix Thunks with placement restrictions and linker scripts.
Tue, Apr 4, 3:48 AM
peter.smith created D31654: [LLD][ELF] Make createThunks a class [NFC].
Tue, Apr 4, 3:03 AM

Mon, Apr 3

peter.smith created D31605: [LLD][ELF][ARM] Rename ARM Thunks in anticipation of Range Thunks.
Mon, Apr 3, 9:14 AM

Fri, Mar 31

peter.smith added a comment to D31500: [ARM]Add a NOP instruction to make LLVM generate a mapping symbol.

Ok now merged as r299212

Fri, Mar 31, 6:21 AM
peter.smith added a comment to D31500: [ARM]Add a NOP instruction to make LLVM generate a mapping symbol.

I can do, although there isn't any special permissions to commit to lld, if you can commit to llvm then you can commit to lld. Let me know if you'd prefer to do it yourself? Otherwise I'll do it in an hour.

Fri, Mar 31, 5:30 AM
peter.smith accepted D31500: [ARM]Add a NOP instruction to make LLVM generate a mapping symbol.

My understanding is that this test failed when a change went in to llvm-mc to not emit the mapping symbol $d.0 when the section contains only data. The test here is checking for the $d.0. Adding the nop forces the creation of a $a.0 which then forces the creation of the $d.0, this will make the test more robust against llvm-mc changes.

Fri, Mar 31, 1:51 AM

Wed, Mar 29

peter.smith added a comment to D30724: Dont emit Mapping symbols for sections that contain only data..

I think the lld test in question is expecting a $d.0 mapping symbol because up to now this is what llvm-objdump has been outputting. It is not strictly necessary for the test which is checking the behaviour of the R_ARM_TARGET1 relocation in response to the --target1-rel flag. It just so happens that .text has been used for the test for what looks like convenience. Strictly speaking we would never see a R_ARM_TARGET1 relocation in an executable section (Should only be present in SHT_INIT_ARRAY or SHT_FINI_ARRAY) sections so I don't see any problem with fixing the lld test to match the new llvm-objdump output.

Wed, Mar 29, 6:36 AM

Mar 24 2017

peter.smith added a comment to D31274: Remove an optimization to set the TLS module index to 1..

I haven't got a good answer for why !isPreemptible() is there. My best guess is that it started as isPreemptible(), there was originally no !Config->Pic, when the !Config->Pic got added this made the !isPreemptible() redundant in that case. The isPreemptible() is important in the Target->TlsOffsetRel case as even for a shared library the linker will know the offset of the Symbol in the TLS block if the symbol isn't preemptible.

Mar 24 2017, 4:20 AM

Mar 23 2017

peter.smith added a comment to D31274: Remove an optimization to set the TLS module index to 1..

Hello, thanks for giving me the chance to review.

Mar 23 2017, 5:05 AM

Mar 7 2017

peter.smith added a comment to D29983: [LLD][ELF] Calculate sizes of SHF_ALLOC Synthetic Sections early.

Apologies, I'm a bit confused about the status of this patch after the last comment/status change, I'll assume this is still waiting for further comments for now.

Mar 7 2017, 2:02 AM

Mar 6 2017

peter.smith created D30641: [LLD][ELF] Fix ordering of Mips LA25 Thunks when Linker Script used.
Mar 6 2017, 3:56 AM
peter.smith created D30637: [LLD][ELF] Fix problem with LA25 Thunks when OutputSection of caller and callee differ.
Mar 6 2017, 3:26 AM

Mar 2 2017

peter.smith updated the diff for D29983: [LLD][ELF] Calculate sizes of SHF_ALLOC Synthetic Sections early.

Rebased and updated the patch.

Mar 2 2017, 10:51 AM

Feb 22 2017

peter.smith added a comment to D29983: [LLD][ELF] Calculate sizes of SHF_ALLOC Synthetic Sections early.

Thanks for the comments, I'll pick this back up when I get back to the office next week. It is helpful to know what the intentions are with respect to naming.

Feb 22 2017, 6:02 AM

Feb 20 2017

peter.smith updated the diff for D29983: [LLD][ELF] Calculate sizes of SHF_ALLOC Synthetic Sections early.

Thank you very much for the comments, I've updated the diff to incorporate the suggestions.

Feb 20 2017, 8:29 AM

Feb 17 2017

peter.smith updated the diff for D29983: [LLD][ELF] Calculate sizes of SHF_ALLOC Synthetic Sections early.

Updated diff to:

  • Rebased on top of D30085 (not reviewed yet) which allows us to add local symbols after globals
  • Moved the addition of symbols to the GNU Hash Table to a separate member function that can be called immediately after the dynamic symbols have been added.
  • Change finalizeAllocSize() to updateAllocSize(). The intention is that this will be called each time thunks are added, and immediately prior to thunks being added, to prevent the MipsGot missing an additional page.
  • Hopefully addressed any review comments that still apply
Feb 17 2017, 8:10 AM
peter.smith created D30085: [LLD][ELF] Alloc local symbols to be added to the SymTab after global symbols.
Feb 17 2017, 3:14 AM

Feb 16 2017

peter.smith added a comment to D29983: [LLD][ELF] Calculate sizes of SHF_ALLOC Synthetic Sections early.

Thank you both for the comments. I'm thinking that it may be better to rework this a little bit and resubmit as the MipsGot::PageIndex calculation breaks my assertion that adding range extension thunks can't affect the size of the SyntheticSections. The size of the MipsGot is proportional to the size of the OutputSections size (modulo 64k), while the amount of Thunks added is likely to be smaller than 64k adding a Thunk could potentially extend over a page boundary.

Feb 16 2017, 3:22 AM

Feb 15 2017

peter.smith created D29983: [LLD][ELF] Calculate sizes of SHF_ALLOC Synthetic Sections early.
Feb 15 2017, 3:33 AM

Feb 8 2017

peter.smith updated the diff for D29664: [LLD][ELF] Refactor PltSection and IPltSection common code into a base class NFC.

Updated the diff with an attempt to use a single class for both the Plt and IPlt. I've used HeaderSize to distinguish between them as that removes a few conditional statements.

Feb 8 2017, 6:54 AM
peter.smith updated the diff for D29637: [LLD][ELF] Use synthetic section to hold copy relocations.

Thank you very much for the comments. I've updated the diff to make the requested changes.

Feb 8 2017, 4:02 AM

Feb 7 2017

peter.smith created D29664: [LLD][ELF] Refactor PltSection and IPltSection common code into a base class NFC.
Feb 7 2017, 10:24 AM
peter.smith created D29637: [LLD][ELF] Use synthetic section to hold copy relocations.
Feb 7 2017, 6:16 AM

Feb 1 2017

peter.smith added a comment to D29192: [AArch64] Fix incorrect relocation encodings for ILP32.

Thanks for the update, I don't have any more comments.

Feb 1 2017, 9:44 AM
peter.smith added inline comments to D29192: [AArch64] Fix incorrect relocation encodings for ILP32.
Feb 1 2017, 2:59 AM

Jan 31 2017

peter.smith created D29327: [LLD][ELF] Use Synthetic Sections for Thunks (try 2).
Jan 31 2017, 6:43 AM

Jan 27 2017

peter.smith added a comment to D29192: [AArch64] Fix incorrect relocation encodings for ILP32.

I've checked that the relocation name is correct. I'm a bit suspicious of allowing the fixup_aarch64_ldst_imm12_scale8 in LP32, with a 32-bit sized GOT I think that this is likely to be a programming mistake that we should probably error on. I'm not hugely familiar with lp32 programming so there may be a case for it that I'm missing?

Jan 27 2017, 6:37 AM
peter.smith added a comment to D29129: [LLD][ELF] Use Synthetic Sections for Thunks.

Thanks for the suggestions. Now committed r293283. I'll now go about thinking about how best to add range extension thunks.

Jan 27 2017, 5:26 AM

Jan 26 2017

peter.smith added a comment to D28571: RuntimeDyldELF/AArch64: Implement basic support for PIC relocations.

I think that those changes address my previous comments, thanks for the update. I've found a couple of what look like typos in the comments. I'm not familiar with rtdyld's organizational and coding conventions so probably best that let an owner take it from here.

Jan 26 2017, 9:42 AM
peter.smith updated the diff for D29129: [LLD][ELF] Use Synthetic Sections for Thunks.

Thanks very much for the comments.

Jan 26 2017, 5:13 AM

Jan 25 2017

peter.smith retitled D29129: [LLD][ELF] Use Synthetic Sections for Thunks from [LLD][ELF] Use Thunks for Synthetic Sections to [LLD][ELF] Use Synthetic Sections for Thunks.
Jan 25 2017, 8:22 AM
peter.smith created D29129: [LLD][ELF] Use Synthetic Sections for Thunks.
Jan 25 2017, 8:21 AM

Jan 24 2017

peter.smith updated the diff for D28956: [LLD][ELF] Add support for local symbols in Synthetic Sections.

Updated patch to remove Saver.save for mapping symbol entries.

Jan 24 2017, 2:21 AM
peter.smith added a comment to D28956: [LLD][ELF] Add support for local symbols in Synthetic Sections.

That is possible although in many cases the disassembler can derive that information without an additional symbol. For example there is some functionality in GNU objdump to display the symbol name of the PLT from some hard-coded choice of PLT size made when building objdump. For example, from hello world compiled and linked with ld.bfd:

Jan 24 2017, 2:03 AM

Jan 23 2017

peter.smith updated the diff for D28956: [LLD][ELF] Add support for local symbols in Synthetic Sections.

Thanks for the comments. I've updated the diff.

Jan 23 2017, 10:26 AM
peter.smith updated the diff for D28950: [LLD][ELF] Correct sh_info for static symbol table.

Thank you for the comments. Updated to use std::stable_partition and rebased on top of D29021.

Jan 23 2017, 8:28 AM
peter.smith updated the diff for D28956: [LLD][ELF] Add support for local symbols in Synthetic Sections.

Removed all code in SymbolTable and rebased the patch on top of D29021.

Jan 23 2017, 7:37 AM

Jan 20 2017

peter.smith added a comment to D28863: RuntimeDyldELF: Implement LDST8_ABS_LO12_NC and LDST16_ABS_LO12_NC relocs.

That looks correct to me according to ELF for the 64-bit ARM architecture definitions of R_AARCH_64_LDST8_ABS_LO12_NC and R_AARCH_64_LDST16_ABS_LO12_NC. Will be worth waiting to see if there are any other comments.

Jan 20 2017, 9:43 AM
peter.smith added a comment to D28956: [LLD][ELF] Add support for local symbols in Synthetic Sections.

I've not added any uses of adding a local symbol to a synthetic section. I've checked that it works by adding mapping symbols to ARM PLT entries, this is quite a large diff due to test updates so I've not included it in the review. I've attached the patch for reference

Jan 20 2017, 8:53 AM
peter.smith created D28956: [LLD][ELF] Add support for local symbols in Synthetic Sections.
Jan 20 2017, 8:46 AM
peter.smith created D28950: [LLD][ELF] Correct sh_info for static symbol table.
Jan 20 2017, 6:08 AM

Jan 18 2017

peter.smith added a comment to D28571: RuntimeDyldELF/AArch64: Implement basic support for PIC relocations.

Hello Evgeny,

Jan 18 2017, 3:33 AM

Jan 17 2017

peter.smith created D28811: [LLD][ARM][Mips] Move createThunks() after scanRelocs().
Jan 17 2017, 9:18 AM

Jan 4 2017

peter.smith added a comment to D27629: Fix unwind info relocation with large code model on AArch64.

I think the code changes and test look fine, but I think you should get this approved by one of the approvers of https://reviews.llvm.org/D6079, which is where the x86_64 large code model change was made along with the justification for it.

Jan 4 2017, 4:22 AM
peter.smith closed D27709: [LLD][ARM] Add support for thunks to undefined non-weak symbols.

Thanks for the review, committed revision 290951

Jan 4 2017, 2:14 AM

Jan 3 2017

peter.smith updated the diff for D27709: [LLD][ARM] Add support for thunks to undefined non-weak symbols.

Rebased patch to account for last couple of weeks changes, no functional changes. Happy New Year!

Jan 3 2017, 3:43 AM

Dec 15 2016

peter.smith updated the diff for D27709: [LLD][ARM] Add support for thunks to undefined non-weak symbols.

Thanks for the update. I've added the comments.

Dec 15 2016, 3:34 AM

Dec 14 2016

peter.smith added a comment to D27709: [LLD][ARM] Add support for thunks to undefined non-weak symbols.

I think it depends on what the precise meaning of Shared and Undefined. At the moment I think the distinction is:
Shared:

  • The symbol is defined in a known shared object.
  • The symbol details such as type, binding and version are known.
  • The shared object has been added as a dependency to the output.
  • The shared object defining the symbol can be found from the SymbolBody.

Undefined:

  • We have a reference to a symbol but no definition.
  • When linking a shared library we assume that the dynamic loader will find a suitable definition from the executable/shared library or error.
  • In all other cases (besides relocatable -r) an undefined non-weak symbol is an error.
  • There is no input file associated with the symbol.
Dec 14 2016, 3:45 AM

Dec 13 2016

peter.smith added a comment to D27718: [LLD][ARM] Accept first SHT_ARM_ATTRIBUTES section.

Thanks for the review. My first idea was to put a flag in Config, but that didn't seem right either. If we were wanting to merge the build attributes sections we'd probably want to do so via a SyntheticSection so I thought it would be easier to start that way.

Dec 13 2016, 10:45 AM
peter.smith retitled D27718: [LLD][ARM] Accept first SHT_ARM_ATTRIBUTES section from to [LLD][ARM] Accept first SHT_ARM_ATTRIBUTES section.
Dec 13 2016, 10:14 AM
peter.smith added a comment to D27629: Fix unwind info relocation with large code model on AArch64.

The relocation calculation looks right, but I'm not convinced about the ulittle64_t with the information I have right now. I suggest that if D27609 is approved this should follow.

Dec 13 2016, 3:45 AM
peter.smith retitled D27709: [LLD][ARM] Add support for thunks to undefined non-weak symbols from to [LLD][ARM] Add support for thunks to undefined non-weak symbols.
Dec 13 2016, 3:18 AM

Dec 12 2016

peter.smith retitled D27678: [LLD][ARM] Add R_ARM_RELATIVE to relocations that can be applied to GotSection from to [LLD][ARM] Add R_ARM_RELATIVE to relocations that can be applied to GotSection.
Dec 12 2016, 9:26 AM

Dec 9 2016

peter.smith added a comment to D27581: [ELF][I386] .got.plt entries for i386 should use the VA of the ifunc resolver function.

I've altered the commit message to say glibc ld.so. Hope that's ok. R289198

Dec 9 2016, 3:59 AM

Dec 8 2016

peter.smith retitled D27581: [ELF][I386] .got.plt entries for i386 should use the VA of the ifunc resolver function from to [ELF][I386] .got.plt entries for i386 should use the VA of the ifunc resolver function.
Dec 8 2016, 10:32 AM