Page MenuHomePhabricator

miyuki (Mikhail Maltsev)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 6 2017, 10:05 AM (243 w, 1 d)

Recent Activity

Wed, Jun 29

miyuki added a comment to D128499: [Clang] Fix: Restore warning inadvertently removed by D126061..

Thanks for fixing the issue.

Wed, Jun 29, 7:02 AM · Restricted Project, Restricted Project

Thu, Jun 23

miyuki added a comment to D126061: [clang] Reject non-declaration C++11 attributes on declarations.

Hi Martin,

Thu, Jun 23, 8:10 AM · Restricted Project, Restricted Project

Apr 25 2022

miyuki added inline comments to D123851: [libc++] Change vector<bool>::const_iterator::reference to bool in ABIv2.
Apr 25 2022, 7:50 AM · Restricted Project, Restricted Project
miyuki added inline comments to D123851: [libc++] Change vector<bool>::const_iterator::reference to bool in ABIv2.
Apr 25 2022, 7:42 AM · Restricted Project, Restricted Project
miyuki added inline comments to D123851: [libc++] Change vector<bool>::const_iterator::reference to bool in ABIv2.
Apr 25 2022, 5:09 AM · Restricted Project, Restricted Project

Apr 13 2022

miyuki added inline comments to D123511: [libc++abi] Fix fallback allocator alignment issue.
Apr 13 2022, 6:16 AM · Restricted Project, Restricted Project
miyuki added a comment to D123511: [libc++abi] Fix fallback allocator alignment issue.

Just to confirm my understanding, basically this only triggers when malloc(...) returns nullptr, i.e. when memory is exhausted, right?

Apr 13 2022, 6:11 AM · Restricted Project, Restricted Project

Apr 11 2022

miyuki updated the summary of D123511: [libc++abi] Fix fallback allocator alignment issue.
Apr 11 2022, 6:59 AM · Restricted Project, Restricted Project
miyuki requested review of D123511: [libc++abi] Fix fallback allocator alignment issue.
Apr 11 2022, 6:57 AM · Restricted Project, Restricted Project

Feb 10 2022

miyuki added a comment to D115906: [libc++] Add a bunch of missing inline and _LIBCPP_HIDE_FROM_ABI in __threading_support.

Ping, since as per my previous comment, I'm pretty sure this change will have broken _LIBCPP_BUILDING_THREAD_LIBRARY_EXTERNAL.

Feb 10 2022, 4:03 AM · Restricted Project

Feb 9 2022

miyuki added a comment to D114786: [libc++] Remove the ability to use the std::nullptr_t emulation in C++03 mode.

OK, thanks.

Feb 9 2022, 7:46 AM · Restricted Project, Restricted Project
miyuki added a comment to D114786: [libc++] Remove the ability to use the std::nullptr_t emulation in C++03 mode.

Is it expected that ::nullptr_t gets defined in headers other than <cstddef>
(e.g. <cmath>)? And also is it expected that ::nullptr_t gets defined even in C++03 mode?

Feb 9 2022, 3:53 AM · Restricted Project, Restricted Project

Jan 26 2022

miyuki added a comment to D117585: [libcxx] Support waiting on monotonic clock with ext. threading.

@ldionne, could you please have a look at this patch?

Jan 26 2022, 4:49 AM · Restricted Project

Jan 20 2022

miyuki updated the diff for D117585: [libcxx] Support waiting on monotonic clock with ext. threading.

Renamed steady -> monotonic.

Jan 20 2022, 8:00 AM · Restricted Project
miyuki added a reviewer for D117585: [libcxx] Support waiting on monotonic clock with ext. threading: Quuxplusone.
Jan 20 2022, 5:38 AM · Restricted Project

Jan 19 2022

miyuki added a comment to D116944: [libc++] Split a few utilities out of __threading_support.

@ldionne, the reason for using __libcpp_timespec_t is the _LIBCPP_HAS_THREAD_API_EXTERNAL configuration. In that case __libcpp_timespec_t is defined in the __external_threading header.

Jan 19 2022, 2:30 AM · Restricted Project

Jan 18 2022

miyuki updated the diff for D117585: [libcxx] Support waiting on monotonic clock with ext. threading.
Jan 18 2022, 10:48 AM · Restricted Project
miyuki updated the diff for D117585: [libcxx] Support waiting on monotonic clock with ext. threading.

Added missing "_LIBCPP_HIDE_FROM_ABI inline"

Jan 18 2022, 10:39 AM · Restricted Project
miyuki requested review of D117585: [libcxx] Support waiting on monotonic clock with ext. threading.
Jan 18 2022, 10:35 AM · Restricted Project

Jan 13 2022

miyuki added a comment to D116213: [ARM] fix bug causing shrinkwrapping not always being off using PAC.

OK, in this case, it makes sense to be conservative and disable shrink-wrapping for all functions that use PAC. LGTM.

Jan 13 2022, 2:28 AM · Restricted Project

Jan 7 2022

miyuki accepted D116213: [ARM] fix bug causing shrinkwrapping not always being off using PAC.

LGTM, but please update the commit message. The part saying

Jan 7 2022, 8:23 AM · Restricted Project

Dec 23 2021

miyuki added inline comments to D116213: [ARM] fix bug causing shrinkwrapping not always being off using PAC.
Dec 23 2021, 5:37 AM · Restricted Project

Nov 26 2021

miyuki committed rGd8f3cdfed03f: [libcxx] Implement three-way comparison for std::reverse_iterator (authored by miyuki).
[libcxx] Implement three-way comparison for std::reverse_iterator
Nov 26 2021, 2:13 AM
miyuki closed D113695: [libcxx] Implement three-way comparison for std::reverse_iterator.
Nov 26 2021, 2:12 AM · Restricted Project

Nov 25 2021

miyuki updated the diff for D113695: [libcxx] Implement three-way comparison for std::reverse_iterator.

Added missing #include-s

Nov 25 2021, 10:56 AM · Restricted Project
miyuki added a comment to D113695: [libcxx] Implement three-way comparison for std::reverse_iterator.

The CI failure looks unrelated.

Nov 25 2021, 9:05 AM · Restricted Project
miyuki accepted D112431: [ARM][clang] Define feature test macro for the PACBTI-M extension.
Nov 25 2021, 7:56 AM · Restricted Project
miyuki updated the diff for D113695: [libcxx] Implement three-way comparison for std::reverse_iterator.

Addressed comments.

Nov 25 2021, 7:53 AM · Restricted Project
miyuki updated the diff for D113695: [libcxx] Implement three-way comparison for std::reverse_iterator.

Added missing constexpr

Nov 25 2021, 5:39 AM · Restricted Project

Nov 22 2021

miyuki added a comment to D113695: [libcxx] Implement three-way comparison for std::reverse_iterator.

Guess I failed to nerdsnipe you into adding the constraints to the other six relational operators, huh?

I'll submit a separate patch

Nov 22 2021, 5:02 AM · Restricted Project
miyuki added inline comments to D113695: [libcxx] Implement three-way comparison for std::reverse_iterator.
Nov 22 2021, 5:02 AM · Restricted Project
miyuki updated the diff for D113695: [libcxx] Implement three-way comparison for std::reverse_iterator.

Updated the test.

Nov 22 2021, 5:00 AM · Restricted Project

Nov 15 2021

miyuki updated the diff for D113695: [libcxx] Implement three-way comparison for std::reverse_iterator.

Added std::partial_ordering test

Nov 15 2021, 7:32 AM · Restricted Project
miyuki committed rG6938270fa68d: [libcxx] Fix enable_if condition of std::reverse_iterator::operator= (authored by miyuki).
[libcxx] Fix enable_if condition of std::reverse_iterator::operator=
Nov 15 2021, 5:10 AM
miyuki closed D113417: [libcxx] Fix enable_if condition of std::reverse_iterator::operator=.
Nov 15 2021, 5:09 AM · Restricted Project
miyuki updated the diff for D113417: [libcxx] Fix enable_if condition of std::reverse_iterator::operator=.

Rebased and addressed Arthur's comment.

Nov 15 2021, 3:25 AM · Restricted Project

Nov 12 2021

miyuki added a comment to D113417: [libcxx] Fix enable_if condition of std::reverse_iterator::operator=.

The AIX failures seem to be unrelated.

Nov 12 2021, 6:20 AM · Restricted Project
miyuki added inline comments to D113417: [libcxx] Fix enable_if condition of std::reverse_iterator::operator=.
Nov 12 2021, 3:50 AM · Restricted Project
miyuki updated the diff for D113417: [libcxx] Fix enable_if condition of std::reverse_iterator::operator=.

Updated tests

Nov 12 2021, 3:40 AM · Restricted Project
miyuki added inline comments to D113695: [libcxx] Implement three-way comparison for std::reverse_iterator.
Nov 12 2021, 3:08 AM · Restricted Project

Nov 11 2021

miyuki added inline comments to D113417: [libcxx] Fix enable_if condition of std::reverse_iterator::operator=.
Nov 11 2021, 10:39 AM · Restricted Project
miyuki requested review of D113695: [libcxx] Implement three-way comparison for std::reverse_iterator.
Nov 11 2021, 10:35 AM · Restricted Project
miyuki updated the diff for D113417: [libcxx] Fix enable_if condition of std::reverse_iterator::operator=.
  1. Updated std::reverse_iterator tests
  2. Added a test for std::move_iterator
Nov 11 2021, 10:33 AM · Restricted Project

Nov 8 2021

miyuki requested review of D113417: [libcxx] Fix enable_if condition of std::reverse_iterator::operator=.
Nov 8 2021, 9:55 AM · Restricted Project

Nov 4 2021

miyuki added inline comments to D112431: [ARM][clang] Define feature test macro for the PACBTI-M extension.
Nov 4 2021, 7:17 AM · Restricted Project

Oct 21 2021

miyuki committed rG05a2d1766864: [libcxx] Throw correct exception from std::vector::reserve (authored by miyuki).
[libcxx] Throw correct exception from std::vector::reserve
Oct 21 2021, 2:41 AM
miyuki closed D112068: [libcxx] Throw correct exception from std::vector::reserve.
Oct 21 2021, 2:41 AM · Restricted Project
miyuki committed rG49be23a1eb57: [libcxx] Support allocators with explicit c-tors in vector<bool> (authored by miyuki).
[libcxx] Support allocators with explicit c-tors in vector<bool>
Oct 21 2021, 2:39 AM
miyuki closed D112150: [libcxx] Support allocators with explicit c-tors in vector<bool>.
Oct 21 2021, 2:39 AM · Restricted Project

Oct 20 2021

miyuki updated the diff for D112068: [libcxx] Throw correct exception from std::vector::reserve.
  1. Addressed reviewers' comments.
  2. Added a prerequisite patch.
Oct 20 2021, 9:31 AM · Restricted Project
miyuki requested review of D112150: [libcxx] Support allocators with explicit c-tors in vector<bool>.
Oct 20 2021, 9:21 AM · Restricted Project

Oct 19 2021

miyuki requested review of D112068: [libcxx] Throw correct exception from std::vector::reserve.
Oct 19 2021, 5:35 AM · Restricted Project

Oct 18 2021

miyuki committed rGbe10b1f1cc5f: [libcxx] Make allocator<T>:allocate throw bad_array_new_length (authored by miyuki).
[libcxx] Make allocator<T>:allocate throw bad_array_new_length
Oct 18 2021, 11:14 AM
miyuki closed D110846: [libcxx] Make allocator<T>:allocate throw bad_array_new_length.
Oct 18 2021, 11:13 AM · Restricted Project
miyuki updated the diff for D110846: [libcxx] Make allocator<T>:allocate throw bad_array_new_length.

Rebased

Oct 18 2021, 11:12 AM · Restricted Project
miyuki updated the diff for D110846: [libcxx] Make allocator<T>:allocate throw bad_array_new_length.
  1. Rebased
  2. Fixed grammar in ReleaseNotes
Oct 18 2021, 8:33 AM · Restricted Project

Oct 7 2021

miyuki updated the diff for D110846: [libcxx] Make allocator<T>:allocate throw bad_array_new_length.

Updated Linux ABI list

Oct 7 2021, 4:41 AM · Restricted Project
miyuki updated the diff for D110846: [libcxx] Make allocator<T>:allocate throw bad_array_new_length.

Rebased

Oct 7 2021, 3:23 AM · Restricted Project

Oct 5 2021

miyuki updated the diff for D110846: [libcxx] Make allocator<T>:allocate throw bad_array_new_length.

Addressed Louis' comments.

Oct 5 2021, 3:21 AM · Restricted Project

Oct 4 2021

miyuki added inline comments to D110846: [libcxx] Make allocator<T>:allocate throw bad_array_new_length.
Oct 4 2021, 4:14 AM · Restricted Project
miyuki updated the summary of D110846: [libcxx] Make allocator<T>:allocate throw bad_array_new_length.
Oct 4 2021, 3:30 AM · Restricted Project
miyuki updated the diff for D110846: [libcxx] Make allocator<T>:allocate throw bad_array_new_length.

Addressed Arthur's comments.

Oct 4 2021, 3:30 AM · Restricted Project
miyuki added inline comments to D110846: [libcxx] Make allocator<T>:allocate throw bad_array_new_length.
Oct 4 2021, 3:20 AM · Restricted Project

Sep 30 2021

miyuki requested review of D110846: [libcxx] Make allocator<T>:allocate throw bad_array_new_length.
Sep 30 2021, 9:09 AM · Restricted Project

Jul 28 2021

miyuki added a comment to D104328: [libc++] Always build libc++ and libc++abi with -fPIC.

Furthermore, there is apparently basically no downside to building the libraries with position independent code, since modern toolchains are sufficiently clever.

FWIW it's not necessarily so much about modern toolchains, as it is about modern architectures. AFAIK position independent code is measurably less efficient on e.g. i386, while the overhead on e.g. x86_64 and arm64 is much much smaller (possibly also on 32 bit arm). Therefore I think the other patch (D104327) makes more sense out of these two, as the choice of PIC is more of a choice for how one configures and distributes it, than an intrinsic property of the project itself.

Jul 28 2021, 5:52 AM · Restricted Project, Restricted Project, Restricted Project

Jul 19 2021

miyuki added a comment to D102727: Use precise growth rather than amortized growth in std::string::resize/__resize_default_init..

[...] which would make me caution on the side of DTRT instead of does the minimum memory thing. The latter is more a faang thing. I would imagine that a 'stable' user might be surprised with sudden regressions without maybe being too concerned with (temporary) allocations being +/- 20%.

Jul 19 2021, 4:59 AM · Restricted Project

Jul 14 2021

miyuki added inline comments to D105493: [clang] Change set type used for SourceLocation..
Jul 14 2021, 9:33 AM · Restricted Project

Jul 8 2021

miyuki accepted D105490: Remove unused parameter from parseMSInlineAsm..

This change is not part of my original D97204 patch (in D97204, I replaced void *AsmLoc with uint64_t AsmLoc), so I think I am eligible to review the change.

Jul 8 2021, 5:49 AM · Restricted Project, Restricted Project

Jun 18 2021

miyuki accepted D104442: [libclang] Fix error handler in translateSourceLocation..

This change is pretty obvious. LGTM.

Jun 18 2021, 4:20 AM · Restricted Project

Jun 14 2021

miyuki added a comment to D103140: [libcxx] Fix exception raised during downstream bare-metal libunwind tests.

Ping^2

Jun 14 2021, 9:41 AM · Restricted Project, Restricted Project

Jun 7 2021

miyuki accepted D103140: [libcxx] Fix exception raised during downstream bare-metal libunwind tests.

This looks sensible, given that libcxxabi/test/libcxxabi/test/config.py does the same thing:

74         triple = self.get_lit_conf('target_triple', None)
75         if triple is not None:
Jun 7 2021, 5:42 AM · Restricted Project, Restricted Project

Apr 28 2021

miyuki added a comment to D96523: [libc++] Rewrite the tuple constructors to be strictly Standards conforming.

Hi. It looks like this change broke the following code:

Apr 28 2021, 6:36 AM · Restricted Project

Apr 14 2021

miyuki added a reviewer for D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally: psmith.
Apr 14 2021, 4:54 AM · Restricted Project

Apr 7 2021

miyuki added inline comments to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.
Apr 7 2021, 8:22 AM · Restricted Project
miyuki added inline comments to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.
Apr 7 2021, 8:09 AM · Restricted Project

Mar 22 2021

miyuki added inline comments to D99091: [locale][num_get] Improve Stage 2 of string to float conversion.
Mar 22 2021, 10:33 AM · Restricted Project

Feb 25 2021

miyuki added a comment to D97204: [RFC] Clang 64-bit source locations.

Thanks for doing this!

The 8-9% memory hit is better than I'd feared, but still seems uncomfortably large. I've left comments on a couple of places where I think we could substantially reduce this.

Thanks, I'll try that.

Feb 25 2021, 4:29 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 23 2021

miyuki updated the diff for D97204: [RFC] Clang 64-bit source locations.

Fixed python bindings and formatting.

Feb 23 2021, 6:21 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
miyuki added a comment to D97204: [RFC] Clang 64-bit source locations.

Hi @miyuki,

A major thing worth noting is that 64-bit source locations will
require an ABI breakage in libclang. This patch changes the bit width
in libclang unconditionally, rather than making it configurable.

Is it possible to make the libclang change configurable as well? A libclang ABI breakage would be problematic for us at Apple. We support dynamically loading and using multiple libclang dylibs from different toolchains, which can be different clang versions.

Feb 23 2021, 6:15 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 22 2021

miyuki requested review of D97204: [RFC] Clang 64-bit source locations.
Feb 22 2021, 9:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 27 2021

miyuki committed rG30d9ca1bd9de: [clang][AST] Encapsulate DeclarationNameLoc, NFCI (authored by miyuki).
[clang][AST] Encapsulate DeclarationNameLoc, NFCI
Jan 27 2021, 3:22 AM
miyuki closed D94596: [clang][AST] Encapsulate DeclarationNameLoc, NFCI.
Jan 27 2021, 3:21 AM · Restricted Project

Jan 22 2021

miyuki committed rGa0e30914f8c8: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI (authored by miyuki).
[clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI
Jan 22 2021, 5:02 AM
miyuki closed D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI.
Jan 22 2021, 5:02 AM · Restricted Project

Jan 20 2021

miyuki added a comment to D94596: [clang][AST] Encapsulate DeclarationNameLoc, NFCI.

ping

Jan 20 2021, 1:43 AM · Restricted Project

Jan 19 2021

miyuki updated the diff for D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI.

Added static_asserts that check that SourceRange and SourceLocation are trivially destructible.

Jan 19 2021, 10:52 AM · Restricted Project
miyuki added a comment to D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI.

I will wait until the end of this week to see if anyone has objections.

Jan 19 2021, 3:20 AM · Restricted Project

Jan 14 2021

miyuki committed rG176f5e95e1af: [clang-tidy] Use DenseSet<SourceLocation> in UpgradeDurationConversionsCheck… (authored by miyuki).
[clang-tidy] Use DenseSet<SourceLocation> in UpgradeDurationConversionsCheck…
Jan 14 2021, 5:50 AM
miyuki closed D94601: [clang-tidy] Use DenseSet<SourceLocation> in UpgradeDurationConversionsCheck, NFCI.
Jan 14 2021, 5:50 AM · Restricted Project, Restricted Project
miyuki added a comment to D94237: [clang] Use SourceLocations in unions [NFCI].

This revision was landed with ongoing or failed builds.

Jan 14 2021, 2:59 AM · Restricted Project
miyuki committed rG17f8c458de63: [clang] Use SourceLocations in unions [NFCI] (authored by miyuki).
[clang] Use SourceLocations in unions [NFCI]
Jan 14 2021, 2:57 AM
miyuki closed D94237: [clang] Use SourceLocations in unions [NFCI].
Jan 14 2021, 2:57 AM · Restricted Project

Jan 13 2021

miyuki updated the diff for D94237: [clang] Use SourceLocations in unions [NFCI].

Refactored SLocEntry in a similar way.

Jan 13 2021, 8:38 AM · Restricted Project
miyuki requested review of D94601: [clang-tidy] Use DenseSet<SourceLocation> in UpgradeDurationConversionsCheck, NFCI.
Jan 13 2021, 7:20 AM · Restricted Project, Restricted Project
miyuki requested review of D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI.
Jan 13 2021, 7:03 AM · Restricted Project
miyuki abandoned D69903: [Basic] Introduce PODSourceLocation, NFCI.

Abandoning in favor of D94237 and D94596.

Jan 13 2021, 6:09 AM · Restricted Project
miyuki requested review of D94596: [clang][AST] Encapsulate DeclarationNameLoc, NFCI.
Jan 13 2021, 6:04 AM · Restricted Project
miyuki added a reviewer for D94237: [clang] Use SourceLocations in unions [NFCI]: faisalv.
Jan 13 2021, 4:48 AM · Restricted Project
miyuki added a comment to D94237: [clang] Use SourceLocations in unions [NFCI].

Do you need to run the destructor before placement new in these situations?

Jan 13 2021, 2:46 AM · Restricted Project

Jan 12 2021

miyuki committed rGc1e08f0073e3: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI] (authored by miyuki).
[clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]
Jan 12 2021, 2:23 AM