User Details
- User Since
- Nov 6 2017, 10:05 AM (280 w, 3 d)
Today
Hi. This change causes failures in one of our configurations, compiled with _LIBCPP_HAS_NO_THREADS. Compilation of mutex.cpp fails with the following error:
Mon, Mar 20
Ping
Feb 21 2023
Fixed indentation.
Feb 1 2023
Nov 29 2022
The CI failures look related to this change: https://buildkite.com/llvm-project/premerge-checks/builds/123301#0184aa94-1b82-44a9-9c25-4074e026d266
Sep 6 2022
Could you please add tests for signext/zeroext i1 return type?
Jul 29 2022
The patch LGTM, but since this is libc++abi, we need approval from the code owners.
Jul 28 2022
Abandoning in favor of D129842.
Jun 29 2022
Thanks for fixing the issue.
Jun 23 2022
Hi Martin,
Apr 25 2022
Apr 13 2022
Apr 11 2022
Feb 10 2022
Feb 9 2022
OK, thanks.
Is it expected that ::nullptr_t gets defined in headers other than <cstddef>
(e.g. <cmath>)? And also is it expected that ::nullptr_t gets defined even in C++03 mode?
Jan 26 2022
@ldionne, could you please have a look at this patch?
Jan 20 2022
Renamed steady -> monotonic.
Jan 19 2022
@ldionne, the reason for using __libcpp_timespec_t is the _LIBCPP_HAS_THREAD_API_EXTERNAL configuration. In that case __libcpp_timespec_t is defined in the __external_threading header.
Jan 18 2022
Added missing "_LIBCPP_HIDE_FROM_ABI inline"
Jan 13 2022
OK, in this case, it makes sense to be conservative and disable shrink-wrapping for all functions that use PAC. LGTM.
Jan 7 2022
LGTM, but please update the commit message. The part saying
Dec 23 2021
Nov 26 2021
Nov 25 2021
Added missing #include-s
The CI failure looks unrelated.
Addressed comments.
Added missing constexpr
Nov 22 2021
Guess I failed to nerdsnipe you into adding the constraints to the other six relational operators, huh?
I'll submit a separate patch
Updated the test.
Nov 15 2021
Added std::partial_ordering test
Rebased and addressed Arthur's comment.
Nov 12 2021
The AIX failures seem to be unrelated.
Updated tests
Nov 11 2021
- Updated std::reverse_iterator tests
- Added a test for std::move_iterator
Nov 8 2021
Nov 4 2021
Oct 21 2021
Oct 20 2021
- Addressed reviewers' comments.
- Added a prerequisite patch.
Oct 19 2021
Oct 18 2021
Rebased
- Rebased
- Fixed grammar in ReleaseNotes
Oct 7 2021
Updated Linux ABI list
Rebased
Oct 5 2021
Addressed Louis' comments.
Oct 4 2021
Addressed Arthur's comments.
Sep 30 2021
Jul 28 2021
Jul 19 2021
Jul 14 2021
Jul 8 2021
Jun 18 2021
This change is pretty obvious. LGTM.
Jun 14 2021
Ping^2
Jun 7 2021
This looks sensible, given that libcxxabi/test/libcxxabi/test/config.py does the same thing:
74 triple = self.get_lit_conf('target_triple', None) 75 if triple is not None:
Apr 28 2021
Hi. It looks like this change broke the following code:
Apr 14 2021
Apr 7 2021
Mar 22 2021
Feb 25 2021
Thanks, I'll try that.
Feb 23 2021
Fixed python bindings and formatting.
Feb 22 2021
Jan 27 2021
Jan 22 2021
Jan 20 2021
ping
Jan 19 2021
Added static_asserts that check that SourceRange and SourceLocation are trivially destructible.
I will wait until the end of this week to see if anyone has objections.