This includes integer arithmetic of various kinds (add/sub/multiply,
saturating and not), and the VMOVs that load an immediate into all
lanes of a vector.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Updated to current trunk, and renamed instruction ids in line with new
consistent MVE_ prefix.
llvm/lib/Target/ARM/ARMInstrMVE.td | ||
---|---|---|
1571 | Bit 28 could be a parameter of MVE_VQxDMULH, and this could be a multiclass to avoid repetition of the types below. (Common pattern in this file). | |
llvm/lib/Target/ARM/Disassembler/ARMDisassembler.cpp | ||
3449 | What does this mean? | |
llvm/test/MC/ARM/mve-integer.s | ||
9 | We should also test that invalid immediates are rejected. | |
llvm/test/MC/Disassembler/ARM/mve-integer.txt | ||
6 | Should these instructions have CHECK-NOMVE lines? | |
33 | These ERROR check lines aren't used by and RUN lines. |
llvm/lib/Target/ARM/Disassembler/ARMDisassembler.cpp | ||
---|---|---|
3449 | Looks as if it was left in from some preliminary work in which the author wasn't sure what further range of instructions that decoder function would end up applying to. I'll take it out. |
Addressed all review comments. In particular, completely removed the mve.fp test run from the mve-integer.s test file, because it was only there due to copy and paste error (I split all these tests out of one far-too-big input file with a single set of run commands).
Added the integer VMINA / VMAXA instructions to this patch, which were
mistakenly included in D62677 despite not being derived from the
latter patch's shared base class.
Bit 28 could be a parameter of MVE_VQxDMULH, and this could be a multiclass to avoid repetition of the types below. (Common pattern in this file).