Page MenuHomePhabricator

ostannard (Oliver Stannard (Linaro))
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 11 2019, 6:15 AM (114 w, 9 h)

Recent Activity

May 13 2021

ostannard accepted D102415: [llvm-mc][AArch64] HINT instruction disassembled as BTI.

LGTM

May 13 2021, 9:51 AM · Restricted Project
ostannard added a reverting change for rG3bf1acab5b45: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions: rG92260d7a1864: Revert "[CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions".
May 13 2021, 6:31 AM
ostannard committed rG92260d7a1864: Revert "[CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions" (authored by ostannard).
Revert "[CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions"
May 13 2021, 6:31 AM
ostannard added a reverting change for D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions: rG92260d7a1864: Revert "[CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions".
May 13 2021, 6:31 AM · Restricted Project, Restricted Project
ostannard added a comment to D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions.

There is also a test failure on the aarch64 2-stage bot (https://lab.llvm.org/buildbot/#/builders/7/builds/2720) which I've bisected to this change, so I'll revert it for now.

May 13 2021, 6:30 AM · Restricted Project, Restricted Project

Mar 30 2021

ostannard added a comment to D76115: Add debug support for set types.

One of the tests was failing on the ARM/AArch64 bots because they don't build the X86 backend, I've moved that test to the X86-specific directory (rG6b3fb4714365).

Mar 30 2021, 5:03 AM · debug-info, Restricted Project
ostannard committed rG6b3fb4714365: Move test to X86 directory (authored by ostannard).
Move test to X86 directory
Mar 30 2021, 5:02 AM

Mar 29 2021

ostannard added a comment to D98146: OpaquePtr: Turn inalloca into a type attribute.

I've reverted this (07e46367bae) because it was causing Bindings/Go/go.test to fail on the buoldbots. Example failure at http://lab.llvm.org:8011/#/builders/107/builds/6075.

Mar 29 2021, 3:35 AM · Restricted Project
ostannard added a reverting change for rGfc9df309917e: Reapply "OpaquePtr: Turn inalloca into a type attribute": rG07e46367baec: Revert "Reapply "OpaquePtr: Turn inalloca into a type attribute"".
Mar 29 2021, 3:33 AM
ostannard committed rG07e46367baec: Revert "Reapply "OpaquePtr: Turn inalloca into a type attribute"" (authored by ostannard).
Revert "Reapply "OpaquePtr: Turn inalloca into a type attribute""
Mar 29 2021, 3:33 AM

Mar 11 2021

ostannard added a comment to D95835: [dfsan] Support origin tracking.

Many of the tests added here are failing on the AArch64 buildbots (e.g. http://lab.llvm.org:8011/#/builders/7/builds/1974). Is this expected to work on AArch64, or should these tests be disabled for those bots?

Mar 11 2021, 2:51 AM · Restricted Project, Restricted Project
ostannard added a comment to D98009: [AArch64][compiler-rt] Add Pointer Authentication support for VFORK..

This patch was causing failures on the AArch64 buildbots, because the compilers they use (clang 10.0 and gcc 9.3.0) don't accept these instructions when targeting armv8.0-a. I've committed https://reviews.llvm.org/rG0070c9ee2d2ce8 to use the hint mnemonic instead for these, which is supported by all aarch64 assemblers.

Mar 11 2021, 1:21 AM · Restricted Project
ostannard committed rG0070c9ee2d2c: [AArch64][compiler-rt] Fix PAC instructions for older compilers (authored by ostannard).
[AArch64][compiler-rt] Fix PAC instructions for older compilers
Mar 11 2021, 1:21 AM

Mar 10 2021

ostannard accepted D98253: [clang][ARM] Refactor ComputeLLVMTriple code for ARM.

LGTM

Mar 10 2021, 6:23 AM · Restricted Project

Mar 9 2021

ostannard updated the diff for D96005: [AArch64] Stack probing for dynamic allocas in SelectionDAG.
  • Rebase
  • Also probe space allocated for outgoing call arguments when needed
Mar 9 2021, 10:34 AM · Restricted Project
ostannard planned changes to D96005: [AArch64] Stack probing for dynamic allocas in SelectionDAG.

While writing the comment in D98258, I noticed that we also move the stack pointer down for calls when a reserved call frame can't be used, which isn't probed by this patch.

Mar 9 2021, 9:11 AM · Restricted Project
ostannard requested review of D96004: [AArch64] Stack probing for function prologues.
Mar 9 2021, 9:01 AM · Restricted Project
ostannard planned changes to D96004: [AArch64] Stack probing for function prologues.
Mar 9 2021, 9:00 AM · Restricted Project
ostannard committed rG8d632ca43655: [ARM] Add comment explaining stack frame layout (authored by ostannard).
[ARM] Add comment explaining stack frame layout
Mar 9 2021, 7:21 AM
ostannard closed D98258: [ARM] Add comment explaining stack frame layout.
Mar 9 2021, 7:20 AM · Restricted Project
ostannard requested review of D98258: [ARM] Add comment explaining stack frame layout.
Mar 9 2021, 6:47 AM · Restricted Project
ostannard updated the diff for D96004: [AArch64] Stack probing for function prologues.
  • Rebase
  • Check for unsupported stack probing methods
Mar 9 2021, 6:31 AM · Restricted Project

Mar 8 2021

ostannard added a comment to D96004: [AArch64] Stack probing for function prologues.

Ping

Mar 8 2021, 8:22 AM · Restricted Project

Mar 4 2021

ostannard committed rGaac056c528cf: [objdump][ARM] Use correct offset when printing ARM/Thumb branch targets (authored by ostannard).
[objdump][ARM] Use correct offset when printing ARM/Thumb branch targets
Mar 4 2021, 3:17 AM
ostannard closed D97766: [objdump][ARM] Use correct offset when printing ARM/Thumb branch targets.
Mar 4 2021, 3:17 AM · Restricted Project
ostannard updated the diff for D97766: [objdump][ARM] Use correct offset when printing ARM/Thumb branch targets.
  • Use TSFlags to check for thumb instructions, and walk operands to find the immediate, to avoid needing to keep the switch statement up to date
  • Don't include instruction encodings in test
Mar 4 2021, 1:54 AM · Restricted Project
ostannard added inline comments to D97766: [objdump][ARM] Use correct offset when printing ARM/Thumb branch targets.
Mar 4 2021, 1:53 AM · Restricted Project

Mar 2 2021

ostannard updated the diff for D97766: [objdump][ARM] Use correct offset when printing ARM/Thumb branch targets.
  • Test with both ARM and Thumb triples
  • Fix failing lld test, where this bug was causing the wrong symbols to be displayed
Mar 2 2021, 8:17 AM · Restricted Project
ostannard added a comment to D96004: [AArch64] Stack probing for function prologues.

Ping

Mar 2 2021, 6:16 AM · Restricted Project
ostannard requested review of D97766: [objdump][ARM] Use correct offset when printing ARM/Thumb branch targets.
Mar 2 2021, 5:58 AM · Restricted Project

Feb 18 2021

ostannard added a comment to D96004: [AArch64] Stack probing for function prologues.

Ping.

Feb 18 2021, 2:37 AM · Restricted Project

Feb 11 2021

ostannard added a comment to D96489: [zorg] Fix test-suite regression on arm bots.

I think it would be better to disable (or change the CFLAGS for, is possible) the one test (is this the same one discussed in D96490?), than to change the config of the whole test suite.

Feb 11 2021, 6:39 AM · Restricted Project
ostannard accepted D96337: [sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu.

LGTM

Feb 11 2021, 6:31 AM · Restricted Project
ostannard added a comment to D96490: [zorg] Disable test-suite for arm global-isel bots.

There are lists of tests to skip for each architecture in SingleSource/Regression/C/gcc-c-torture/execute/CMakeLists.txt, that looks like the right place to do this. I'm not sure if it's possible to know if global-isel is enabled in that file, but since it's just one test I think disabling it for all Arm and AArch64 bots is ok.

Feb 11 2021, 6:29 AM · Restricted Project
ostannard requested changes to D96490: [zorg] Disable test-suite for arm global-isel bots.

The test-suite is the only thing this bot does to test global-isel, so I don't think there's any point in running the bot with this change. I think our options here are:

  • Disable just the tests which are failing (looks like it's just test-suite::GCC-C-execute-eeprof-1.test?)
  • Convert this to a 2-stage bot with the second stage built using global-isel, so that we are still doing some useful testing
  • Disable this bot completely until https://bugs.llvm.org/show_bug.cgi?id=49143 is fixed.
Feb 11 2021, 5:46 AM · Restricted Project
ostannard accepted D95471: [ARM] VINS f16 pattern.

LGTM

Feb 11 2021, 2:34 AM · Restricted Project
ostannard added a comment to D96004: [AArch64] Stack probing for function prologues.

Ping.

Feb 11 2021, 2:21 AM · Restricted Project
ostannard added a comment to D96337: [sanitizer] Fix suffix-log-path_test.c on arm-linux-gnu.

Could this also affect regular users of the sanitizers, or is it specific to the way we are running the tests? If it could affect users, then could we fix this in the clang driver, so that unwind tables are turned on by default whenever the sanitizers need them?

Feb 11 2021, 2:20 AM · Restricted Project

Feb 8 2021

ostannard updated the diff for D96006: [AArch64] Stack probing for dynamic allocas in GlobalISel.
  • Assert if types aren't what we expect, instead of emitting an un-probed SP move.
  • Share code with LegalizerHelper
  • Add MIR tests for the legalizer
Feb 8 2021, 2:49 AM · Restricted Project
ostannard added inline comments to D96006: [AArch64] Stack probing for dynamic allocas in GlobalISel.
Feb 8 2021, 2:47 AM · Restricted Project

Feb 5 2021

ostannard accepted D96146: Don't run testsuite on Linaro quick bots..

LGTM

Feb 5 2021, 10:44 AM
ostannard updated the diff for D96007: [AArch64] Enable stack clash protection for AArch64 linux in clang.
Feb 5 2021, 2:38 AM · Restricted Project
ostannard updated the diff for D96006: [AArch64] Stack probing for dynamic allocas in GlobalISel.
Feb 5 2021, 2:37 AM · Restricted Project
ostannard updated the diff for D96005: [AArch64] Stack probing for dynamic allocas in SelectionDAG.
Feb 5 2021, 2:37 AM · Restricted Project
ostannard updated the diff for D96004: [AArch64] Stack probing for function prologues.
Feb 5 2021, 2:37 AM · Restricted Project

Feb 4 2021

ostannard requested review of D96007: [AArch64] Enable stack clash protection for AArch64 linux in clang.
Feb 4 2021, 2:31 AM · Restricted Project
ostannard requested review of D96006: [AArch64] Stack probing for dynamic allocas in GlobalISel.
Feb 4 2021, 2:30 AM · Restricted Project
ostannard requested review of D96005: [AArch64] Stack probing for dynamic allocas in SelectionDAG.
Feb 4 2021, 2:28 AM · Restricted Project
ostannard requested review of D96004: [AArch64] Stack probing for function prologues.
Feb 4 2021, 2:27 AM · Restricted Project

Jan 29 2021

ostannard committed rZORG2d096eb6dc44: Explicitly use python3 for lit sandbox (authored by ostannard).
Explicitly use python3 for lit sandbox
Jan 29 2021, 2:11 AM
ostannard closed D95604: Explicitly use python3 for lit sandbox.
Jan 29 2021, 2:11 AM

Jan 28 2021

ostannard requested review of D95604: Explicitly use python3 for lit sandbox.
Jan 28 2021, 2:46 AM

Jan 15 2021

ostannard closed D94167: [ARM][GISel] Treat calls as variadic even if only fixed arguments provided.

Committed as rG3676ef1053.

Jan 15 2021, 1:37 AM · Restricted Project
ostannard committed rG3676ef105389: [ARM][GISel] Treat calls as variadic even if only fixed arguments provided (authored by ostannard).
[ARM][GISel] Treat calls as variadic even if only fixed arguments provided
Jan 15 2021, 1:37 AM

Jan 14 2021

ostannard added reviewers for D94167: [ARM][GISel] Treat calls as variadic even if only fixed arguments provided: yroux, DavidSpickett.

Ping.

Jan 14 2021, 8:27 AM · Restricted Project

Jan 7 2021

ostannard added a comment to rG9b228f107d43: [llvm] Use BasicBlock::phis() (NFC).

This is causing compiler crashes during the second stage of the 2-stage buildbots (e.g. http://lab.llvm.org:8011/#/builders/7/builds/1140), so I've reverted it in rG76f6b125cef1.

Jan 7 2021, 1:46 AM
ostannard added a reverting change for rG9b228f107d43: [llvm] Use BasicBlock::phis() (NFC): rG76f6b125cef1: Revert "[llvm] Use BasicBlock::phis() (NFC)".
Jan 7 2021, 1:45 AM
ostannard committed rG76f6b125cef1: Revert "[llvm] Use BasicBlock::phis() (NFC)" (authored by ostannard).
Revert "[llvm] Use BasicBlock::phis() (NFC)"
Jan 7 2021, 1:45 AM

Jan 6 2021

ostannard requested review of D94167: [ARM][GISel] Treat calls as variadic even if only fixed arguments provided.
Jan 6 2021, 4:18 AM · Restricted Project
ostannard added a reverting change for rGb7718b617557: Reland D93848 "[sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX…: rG4839378ca05f: Revert "[sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature….
Jan 6 2021, 2:33 AM
ostannard committed rG4839378ca05f: Revert "[sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature… (authored by ostannard).
Revert "[sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature…
Jan 6 2021, 2:33 AM
ostannard added a reverting change for D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl: rG4839378ca05f: Revert "[sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature….
Jan 6 2021, 2:33 AM · Restricted Project, Restricted Project
ostannard added a comment to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.

This is causing a build failure on the 32-bit ARM bots:

Jan 6 2021, 2:33 AM · Restricted Project, Restricted Project
ostannard closed D94085: [simd_ops] Build tests with -fpic.

Committed as 224328460d75e1fa16a23901b3aa494b89e0a842.

Jan 6 2021, 1:46 AM · Restricted Project

Jan 5 2021

ostannard requested review of D94085: [simd_ops] Build tests with -fpic.
Jan 5 2021, 6:22 AM · Restricted Project

Dec 18 2020

ostannard accepted D93221: [ARM] Add clang command line support for -mharden-sls=.

Ok, LGTM

Dec 18 2020, 9:40 AM · Restricted Project
ostannard accepted D92469: [ARM] harden-sls-blr: avoid r12 and lr in indirect calls.

LGTM

Dec 18 2020, 6:20 AM · Restricted Project
ostannard accepted D92468: [ARM] Harden indirect calls against SLS.

LGTM

Dec 18 2020, 6:19 AM · Restricted Project
ostannard accepted D92395: [ARM] Implement harden-sls-retbr for ARM mode.

LGTM

Dec 18 2020, 6:18 AM · Restricted Project
ostannard accepted D92574: [AArch64] Add support for ls64 to the .arch_extension asm directive.

LGTM

Dec 18 2020, 6:17 AM · Restricted Project
ostannard accepted D93538: [AArch64] Updating .arch_extension negative tests.

LGTM

Dec 18 2020, 6:16 AM · Restricted Project
ostannard added inline comments to D92574: [AArch64] Add support for ls64 to the .arch_extension asm directive.
Dec 18 2020, 1:42 AM · Restricted Project
ostannard accepted D92391: [AArch64] Add support for the SPE-EEF feature.

LGTM

Dec 18 2020, 1:36 AM · Restricted Project
ostannard accepted D92389: [AArch64] Add support for the Branch Record Buffer extension.

LGTM

Dec 18 2020, 1:35 AM · Restricted Project

Dec 17 2020

ostannard accepted D93231: [ARM] Adding v8.7-A command-line support for the ARM target.

LGTM

Dec 17 2020, 2:43 AM · Restricted Project, Restricted Project
ostannard accepted D91772: [ARM][AArch64] Adding basic support for the v8.7-A architecture.

LGTM

Dec 17 2020, 2:41 AM · Restricted Project
ostannard added a comment to D93221: [ARM] Add clang command line support for -mharden-sls=.

Why is this restricted to v7-A or later? The DSB and ISB instructions have existed since v6T2 and v6M.

Dec 17 2020, 2:40 AM · Restricted Project
ostannard added inline comments to D92469: [ARM] harden-sls-blr: avoid r12 and lr in indirect calls.
Dec 17 2020, 2:27 AM · Restricted Project
ostannard added inline comments to D92468: [ARM] Harden indirect calls against SLS.
Dec 17 2020, 2:12 AM · Restricted Project
ostannard accepted D92396: [ARM] Implement harden-sls-retbr for Thumb mode.

LGTM

Dec 17 2020, 1:47 AM · Restricted Project
ostannard added inline comments to D92395: [ARM] Implement harden-sls-retbr for ARM mode.
Dec 17 2020, 1:41 AM · Restricted Project

Dec 8 2020

ostannard added a comment to D91772: [ARM][AArch64] Adding basic support for the v8.7-A architecture.

The code changes look good, but this is missing tests for the new TLBI operands..

Dec 8 2020, 3:38 AM · Restricted Project
ostannard accepted D92388: [NFC][AArch64] Capturing multiple feature requirements in AsmParser messages.

LGTM

Dec 8 2020, 3:28 AM · Restricted Project

Dec 7 2020

ostannard committed rG7d04e70627aa: [Lit] Fix flaky test on heavily loaded bots (authored by ostannard).
[Lit] Fix flaky test on heavily loaded bots
Dec 7 2020, 1:06 AM
ostannard closed D92563: [Lit] Fix flaky test on heavily loaded bots.
Dec 7 2020, 1:06 AM · Restricted Project

Dec 3 2020

ostannard requested review of D92563: [Lit] Fix flaky test on heavily loaded bots.
Dec 3 2020, 3:01 AM · Restricted Project

Nov 19 2020

ostannard added inline comments to D91773: [AArch64] Add SubtargetFeatures for v8.7-A options.
Nov 19 2020, 5:28 AM · Restricted Project
ostannard accepted D91775: [AArch64] Adding the v8.7-A LD64B/ST64B Accelerator extension.

LGTM with one minor comment.

Nov 19 2020, 5:27 AM · Restricted Project
ostannard accepted D91774: [AArch64] Add a GPR64x8 register class.

LGTM

Nov 19 2020, 5:23 AM · Restricted Project
ostannard added a comment to D91772: [ARM][AArch64] Adding basic support for the v8.7-A architecture.

The pre-commit test failures look relevant, so should be investigated.

Nov 19 2020, 3:30 AM · Restricted Project
ostannard accepted D91776: [ARM][AAarch64] Initial command-line support for v8.7-A.

LGTM

Nov 19 2020, 3:11 AM · Restricted Project, Restricted Project
ostannard added inline comments to D91773: [AArch64] Add SubtargetFeatures for v8.7-A options.
Nov 19 2020, 3:05 AM · Restricted Project
ostannard accepted D91771: [NFC][AArch64] Move AArch64 MSR/MRS into a new decoder namespace.

LGTM

Nov 19 2020, 2:50 AM · Restricted Project
ostannard accepted D91733: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available.

LGTM

Nov 19 2020, 1:48 AM · Restricted Project
ostannard accepted D91732: [compiler-rt] [builtins] Support conversion between fp16 and fp128.

Also, __fp16 is a storage format and promoted to 'float' for argument passing

Nov 19 2020, 1:43 AM · Restricted Project
ostannard accepted D91731: [AArch64] Lower fptrunc/fpext from/to FP128t to/from FP16.

LGTM

Nov 19 2020, 1:23 AM · Restricted Project

Nov 18 2020

ostannard added a comment to D90175: [AArch64] Support conversion between fp16 and fp128.

They are enabled iff the compiler supports _Float16.

Nov 18 2020, 1:47 AM · Restricted Project, Restricted Project

Nov 6 2020

ostannard accepted D90918: [Arm][MC] Remove unused prefixes in .arch_extension fp tests.

LGTM

Nov 6 2020, 6:28 AM · Restricted Project
ostannard accepted D90913: [AArch64][MC] Remove unused prefix in v8.4-a trace test.

LGTM

Nov 6 2020, 1:54 AM · Restricted Project

Oct 27 2020

ostannard added a comment to D90153: [AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register..

I'm not aware of any official policy about this, but I don't think it's worth going through a multi-release deprecation process for something which is called out in the architecture manual as not valid.

Oct 27 2020, 7:47 AM · Restricted Project