Page MenuHomePhabricator

[ARM] Add fixup types for BF and LOL.
AbandonedPublic

Authored by simon_tatham on Apr 15 2019, 5:58 AM.

Details

Summary

The BF ones translate into new ELF relocations, whereas the LOL ones
are handled entirely internally.

Event Timeline

simon_tatham created this revision.Apr 15 2019, 5:58 AM

I think it would be better to fold this patch in with whatever smallest unit makes it testable. Probably by splitting up the different fixups to go in with the instruction that uses them.

ostannard added inline comments.
llvm/include/llvm/BinaryFormat/ELFRelocs/ARM.def
139
llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
269

This should also check for negative offsets.

304

Should this be "< 0"?

simon_tatham abandoned this revision.May 30 2019, 8:37 AM

I think it would be better to fold this patch in with whatever smallest unit makes it testable. Probably by splitting up the different fixups to go in with the instruction that uses them.

Fair enough. It's now folded into the new D62667.