Page MenuHomePhabricator

SjoerdMeijer (Sjoerd Meijer)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 26 2016, 2:17 AM (176 w, 6 d)

Recent Activity

Today

SjoerdMeijer added a comment to D63418: [ARM] Rename Thumb2ITBlockPass.cpp to Thumb2CondExecution.cpp.

I might be changing my opinion on this patch and won't commit this yet. I will see first how much I actually can reuse from the IT block infrastructure. It would be a bit pointless if I rename this now, and decide later to move the VPT pass in a separate file.

Mon, Jun 17, 7:14 AM · Restricted Project
SjoerdMeijer added inline comments to D63419: [ARM] Thumb2CondExecution. NFC.
Mon, Jun 17, 7:14 AM · Restricted Project
SjoerdMeijer added a comment to D63418: [ARM] Rename Thumb2ITBlockPass.cpp to Thumb2CondExecution.cpp.

Ha ha, cheers!

Mon, Jun 17, 6:35 AM · Restricted Project
SjoerdMeijer added a child revision for D63418: [ARM] Rename Thumb2ITBlockPass.cpp to Thumb2CondExecution.cpp: D63419: [ARM] Thumb2CondExecution. NFC.
Mon, Jun 17, 5:22 AM · Restricted Project
SjoerdMeijer created D63419: [ARM] Thumb2CondExecution. NFC.
Mon, Jun 17, 5:22 AM · Restricted Project
SjoerdMeijer created D63418: [ARM] Rename Thumb2ITBlockPass.cpp to Thumb2CondExecution.cpp.
Mon, Jun 17, 5:20 AM · Restricted Project

Fri, Jun 14

SjoerdMeijer accepted D63265: [ARM] Extract some code from ARMConstantIslandPass.

Looks like a useful refactoring to me.

Fri, Jun 14, 8:52 AM · Restricted Project
SjoerdMeijer committed rG3058a62b9081: [ARM] MVE VPT Block Pass (authored by SjoerdMeijer).
[ARM] MVE VPT Block Pass
Fri, Jun 14, 4:45 AM
SjoerdMeijer committed rL363370: [ARM] MVE VPT Block Pass.
[ARM] MVE VPT Block Pass
Fri, Jun 14, 4:44 AM
SjoerdMeijer closed D63247: [ARM] MVE VPT Block Pass.
Fri, Jun 14, 4:44 AM · Restricted Project
SjoerdMeijer updated the diff for D63247: [ARM] MVE VPT Block Pass.

Thanks for your suggestion and explanation Simon. I have shamelessly almost literally copied and added it as a comment as I think that's very useful.

Fri, Jun 14, 2:00 AM · Restricted Project
SjoerdMeijer updated the diff for D63247: [ARM] MVE VPT Block Pass.
  • registered the pass,
  • so that I could create and add a MIR test,
  • and wrote a range based for-loop.
Fri, Jun 14, 1:19 AM · Restricted Project
SjoerdMeijer added a comment to D63247: [ARM] MVE VPT Block Pass.

D62669 includes a few VPT predicable MVE instructions to test the assembly side of this, is that enough to add some MIR tests for this?

Fri, Jun 14, 1:04 AM · Restricted Project

Thu, Jun 13

SjoerdMeijer added a reviewer for D63247: [ARM] MVE VPT Block Pass: ostannard.
Thu, Jun 13, 5:26 AM · Restricted Project
SjoerdMeijer added a comment to D63247: [ARM] MVE VPT Block Pass.

Obviously a test is missing here. I will have a look what is easier: extract a few tablegen instructions descriptions from later patches so that we can create/add a test here, or we can wait for the later patches to be in.
Also, the pass will run, but won't trigger because there are no instructions yet that have getVPTInstrPredicate.

Thu, Jun 13, 3:20 AM · Restricted Project
SjoerdMeijer updated the summary of D63247: [ARM] MVE VPT Block Pass.
Thu, Jun 13, 3:13 AM · Restricted Project
SjoerdMeijer created D63247: [ARM] MVE VPT Block Pass.
Thu, Jun 13, 3:13 AM · Restricted Project
SjoerdMeijer added a child revision for D62669: [ARM] Set up infrastructure for MVE vector instructions.: D63247: [ARM] MVE VPT Block Pass.
Thu, Jun 13, 3:13 AM · Restricted Project
SjoerdMeijer accepted D63212: [ARM] Scan for existing loop intrinsics.

Looks very reasonable to me.

Thu, Jun 13, 12:27 AM · Restricted Project

Wed, Jun 12

SjoerdMeijer added inline comments to D63212: [ARM] Scan for existing loop intrinsics.
Wed, Jun 12, 9:16 AM · Restricted Project
SjoerdMeijer added a comment to D63212: [ARM] Scan for existing loop intrinsics.

I can't see what's being changed in ARMTargetTransformInfo.cpp. Can you upload the patch with more context?

Wed, Jun 12, 9:00 AM · Restricted Project
SjoerdMeijer committed rGde73404b8c43: [AArch64] Merge globals when optimising for size (authored by SjoerdMeijer).
[AArch64] Merge globals when optimising for size
Wed, Jun 12, 1:27 AM
SjoerdMeijer committed rL363130: [AArch64] Merge globals when optimising for size.
[AArch64] Merge globals when optimising for size
Wed, Jun 12, 1:25 AM
SjoerdMeijer closed D61947: [AArch64] Merge globals when optimising for size.
Wed, Jun 12, 1:25 AM · Restricted Project

Tue, Jun 11

SjoerdMeijer updated the diff for D61947: [AArch64] Merge globals when optimising for size.
Tue, Jun 11, 9:24 AM · Restricted Project
SjoerdMeijer updated the diff for D61947: [AArch64] Merge globals when optimising for size.

I have enabled this only when we optimise for code-size. The performance results show that there's potential, but as pointed out there is this SPEC regression. But at the moment, we are interested in this patch for code size reasons, and it shows good improvements. I've left a FIXME that it would be worth investigating the regression so that it could be enabled for performance too in a follow up patch.

Tue, Jun 11, 9:11 AM · Restricted Project
SjoerdMeijer commandeered D61947: [AArch64] Merge globals when optimising for size.
Tue, Jun 11, 9:05 AM · Restricted Project

Mon, Jun 10

SjoerdMeijer added inline comments to D62667: [ARM] Add the non-MVE instructions in Arm v8.1-M..
Mon, Jun 10, 7:53 AM · Restricted Project

Fri, Jun 7

SjoerdMeijer committed rG4ea248eb56cc: [ARM] Add ACLE feature macros for MVE (authored by SjoerdMeijer).
[ARM] Add ACLE feature macros for MVE
Fri, Jun 7, 8:22 AM
SjoerdMeijer committed rL362806: [ARM] Add ACLE feature macros for MVE.
[ARM] Add ACLE feature macros for MVE
Fri, Jun 7, 8:22 AM
SjoerdMeijer closed D60710: [ARM] Add ACLE feature macros for MVE..
Fri, Jun 7, 8:21 AM · Restricted Project, Restricted Project
SjoerdMeijer added a comment to D60710: [ARM] Add ACLE feature macros for MVE..

Thanks for reviewing!

Fri, Jun 7, 8:15 AM · Restricted Project, Restricted Project
SjoerdMeijer updated the diff for D60710: [ARM] Add ACLE feature macros for MVE..

Yep, sorry, missed that one.

Fri, Jun 7, 7:16 AM · Restricted Project, Restricted Project
SjoerdMeijer added a comment to D62998: [ARM] Fix bugs introduced by the fp64/d32 rework..

Cheers, LGTM too.

Fri, Jun 7, 3:32 AM · Restricted Project, Restricted Project
SjoerdMeijer updated the diff for D60710: [ARM] Add ACLE feature macros for MVE..

Set FullFP16 for +mve.fp

Fri, Jun 7, 3:09 AM · Restricted Project, Restricted Project
SjoerdMeijer added inline comments to D60710: [ARM] Add ACLE feature macros for MVE..
Fri, Jun 7, 3:00 AM · Restricted Project, Restricted Project
SjoerdMeijer added inline comments to D62998: [ARM] Fix bugs introduced by the fp64/d32 rework..
Fri, Jun 7, 2:03 AM · Restricted Project, Restricted Project
SjoerdMeijer added a reviewer for D60710: [ARM] Add ACLE feature macros for MVE.: ostannard.
Fri, Jun 7, 1:29 AM · Restricted Project, Restricted Project
SjoerdMeijer updated the diff for D60710: [ARM] Add ACLE feature macros for MVE..

Added tests

Fri, Jun 7, 1:29 AM · Restricted Project, Restricted Project
SjoerdMeijer commandeered D60710: [ARM] Add ACLE feature macros for MVE..
Fri, Jun 7, 1:26 AM · Restricted Project, Restricted Project

Thu, Jun 6

SjoerdMeijer added inline comments to D62604: [CodeGen] Generic Hardware Loop Support.
Thu, Jun 6, 3:48 AM
SjoerdMeijer accepted D62942: [PATCH 2/2] [AArch64][AsmParser] error on unexpected SVE predicate type suffix.

Looks like a good fix to me.

Thu, Jun 6, 1:47 AM · Restricted Project
SjoerdMeijer accepted D62941: [PATCH 1/2] [AArch64][AsmParser] Provide better diagnostics for SVE predicates.

Looks like a good improvement to me.

Thu, Jun 6, 1:39 AM · Restricted Project

Wed, Jun 5

SjoerdMeijer committed rGf95e6c065342: [ARM] Allow "-march=foo+fp" to vary with foo (authored by SjoerdMeijer).
[ARM] Allow "-march=foo+fp" to vary with foo
Wed, Jun 5, 6:12 AM
SjoerdMeijer committed rGa1bb4fb79d86: [ARM] Allow "-march=foo+fp" to vary with foo (authored by SjoerdMeijer).
[ARM] Allow "-march=foo+fp" to vary with foo
Wed, Jun 5, 6:12 AM
SjoerdMeijer committed rL362601: [ARM] Allow "-march=foo+fp" to vary with foo.
[ARM] Allow "-march=foo+fp" to vary with foo
Wed, Jun 5, 6:09 AM
SjoerdMeijer committed rL362600: [ARM] Allow "-march=foo+fp" to vary with foo.
[ARM] Allow "-march=foo+fp" to vary with foo
Wed, Jun 5, 6:09 AM
SjoerdMeijer closed D60697: [ARM] Allow "-march=foo+fp" to vary with foo..
Wed, Jun 5, 6:09 AM · Restricted Project, Restricted Project
SjoerdMeijer accepted D62861: [AArch64] Handle ISD::LROUND and ISD::LLROUND for float16.

Thanks for following up, this one LGTM too.

Wed, Jun 5, 1:43 AM · Restricted Project
SjoerdMeijer accepted D62863: [AArch64] Handle ISD::LRINT and ISD::LLRINT for float16.

Thanks for following up. This looks good to me.

Wed, Jun 5, 1:41 AM · Restricted Project

Tue, Jun 4

SjoerdMeijer updated the diff for D60697: [ARM] Allow "-march=foo+fp" to vary with foo..

Hi Oliver, thanks for your comments!

Tue, Jun 4, 7:27 AM · Restricted Project, Restricted Project

Mon, Jun 3

SjoerdMeijer added a comment to D62604: [CodeGen] Generic Hardware Loop Support.

Went through this for the first time, just some initial nits inline, will continue looking a bit.

Mon, Jun 3, 3:02 AM
SjoerdMeijer added inline comments to D62604: [CodeGen] Generic Hardware Loop Support.
Mon, Jun 3, 2:13 AM
SjoerdMeijer added inline comments to D62682: [ARM] Extra MVE-related testing..
Mon, Jun 3, 2:09 AM · Restricted Project
SjoerdMeijer added inline comments to D62668: [ARM] First MVE instructions: scalar shifts..
Mon, Jun 3, 1:41 AM · Restricted Project

Fri, May 31

SjoerdMeijer updated the diff for D60697: [ARM] Allow "-march=foo+fp" to vary with foo..

This time with tests.

Fri, May 31, 7:43 AM · Restricted Project, Restricted Project
SjoerdMeijer added a comment to D60697: [ARM] Allow "-march=foo+fp" to vary with foo..

Ah yes, the school boy error! ;-) Actually, there was a test, but in a different patch; I will move it to here.

Fri, May 31, 6:48 AM · Restricted Project, Restricted Project
SjoerdMeijer committed rG3cac8d258acb: Follow up and fix for rL362064 (authored by SjoerdMeijer).
Follow up and fix for rL362064
Fri, May 31, 1:41 AM
SjoerdMeijer updated the diff for D60697: [ARM] Allow "-march=foo+fp" to vary with foo..

This addresses @t.p.northover comment.

Fri, May 31, 1:40 AM · Restricted Project, Restricted Project
SjoerdMeijer committed rL362211: Follow up and fix for rL362064.
Follow up and fix for rL362064
Fri, May 31, 1:40 AM
SjoerdMeijer added a comment to D60696: [TableGen] New default operand "undef_tied_input"..

I've committed rL362211 to fix this bug. This change is used and tested by D62669.

Fri, May 31, 1:40 AM · Restricted Project
SjoerdMeijer commandeered D60697: [ARM] Allow "-march=foo+fp" to vary with foo..
Fri, May 31, 1:11 AM · Restricted Project, Restricted Project

Thu, May 30

SjoerdMeijer committed rGd74c2131c31b: Follow up of r362096 (authored by SjoerdMeijer).
Follow up of r362096
Thu, May 30, 11:10 AM
SjoerdMeijer committed rL362100: Follow up of r362096.
Follow up of r362096
Thu, May 30, 11:10 AM
SjoerdMeijer committed rC362100: Follow up of r362096.
Follow up of r362096
Thu, May 30, 11:10 AM
SjoerdMeijer committed rGeb072b5a6a2c: [ARM] Change the MC names for VMAXNM/VMINNM (authored by SjoerdMeijer).
[ARM] Change the MC names for VMAXNM/VMINNM
Thu, May 30, 7:33 AM
SjoerdMeijer committed rL362097: [ARM] Change the MC names for VMAXNM/VMINNM.
[ARM] Change the MC names for VMAXNM/VMINNM
Thu, May 30, 7:31 AM
SjoerdMeijer closed D60700: [ARM] Change the MC names for VMAXNM/VMINNM..
Thu, May 30, 7:31 AM · Restricted Project
SjoerdMeijer committed rG24f12711ae27: [ARM] Add CLI support for Armv8.1-M and MVE (authored by SjoerdMeijer).
[ARM] Add CLI support for Armv8.1-M and MVE
Thu, May 30, 7:20 AM
SjoerdMeijer committed rC362096: [ARM] Add CLI support for Armv8.1-M and MVE.
[ARM] Add CLI support for Armv8.1-M and MVE
Thu, May 30, 7:20 AM
SjoerdMeijer committed rL362096: [ARM] Add CLI support for Armv8.1-M and MVE.
[ARM] Add CLI support for Armv8.1-M and MVE
Thu, May 30, 7:20 AM
SjoerdMeijer closed D60699: [ARM] add CLI support for 8.1-M and MVE..
Thu, May 30, 7:20 AM · Restricted Project, Restricted Project
SjoerdMeijer committed rG930dee2c0b8a: [ARM] add target arch definitions for 8.1-M and MVE (authored by SjoerdMeijer).
[ARM] add target arch definitions for 8.1-M and MVE
Thu, May 30, 5:55 AM
SjoerdMeijer committed rL362090: [ARM] add target arch definitions for 8.1-M and MVE.
[ARM] add target arch definitions for 8.1-M and MVE
Thu, May 30, 5:54 AM
SjoerdMeijer closed D60698: [ARM] add target arch definitions for 8.1-M and MVE..
Thu, May 30, 5:54 AM · Restricted Project
SjoerdMeijer committed rG7eb95d672dbf: [ARM] Introduce separate features for FP registers (authored by SjoerdMeijer).
[ARM] Introduce separate features for FP registers
Thu, May 30, 5:37 AM
SjoerdMeijer committed rL362088: [ARM] Introduce separate features for FP registers.
[ARM] Introduce separate features for FP registers
Thu, May 30, 5:37 AM
SjoerdMeijer closed D60694: [ARM] Introduce separate features for FP registers..
Thu, May 30, 5:37 AM · Restricted Project
SjoerdMeijer added a comment to D60694: [ARM] Introduce separate features for FP registers..

Many thanks! I will remove those tests before committing!

Thu, May 30, 3:11 AM · Restricted Project
SjoerdMeijer updated the diff for D60694: [ARM] Introduce separate features for FP registers..

I've removed the instruction in the tests that are not yet supported; this will be added to another/later patch.

Thu, May 30, 2:38 AM · Restricted Project
SjoerdMeijer commandeered D60694: [ARM] Introduce separate features for FP registers..
Thu, May 30, 2:38 AM · Restricted Project
SjoerdMeijer committed rG5857bf5d1e5a: [ARM] Add an MVE execution domain (authored by SjoerdMeijer).
[ARM] Add an MVE execution domain
Thu, May 30, 1:07 AM
SjoerdMeijer committed rL362068: [ARM] Add an MVE execution domain.
[ARM] Add an MVE execution domain
Thu, May 30, 1:04 AM
SjoerdMeijer closed D60703: [ARM] Add an MVE execution domain..
Thu, May 30, 1:04 AM · Restricted Project
SjoerdMeijer added a comment to D60696: [TableGen] New default operand "undef_tied_input"..

But I haven't done that in this commit, because there was no need to - no Tablegen backend seems to autogenerate default fields in an MCInst.

So what's the test plan here?

Thu, May 30, 12:48 AM · Restricted Project
SjoerdMeijer committed rGbb4839d4157b: [TableGen] AsmMatcher: allow repeated input operands (authored by SjoerdMeijer).
[TableGen] AsmMatcher: allow repeated input operands
Thu, May 30, 12:36 AM
SjoerdMeijer committed rL362066: [TableGen] AsmMatcher: allow repeated input operands.
[TableGen] AsmMatcher: allow repeated input operands
Thu, May 30, 12:35 AM
SjoerdMeijer closed D60695: [TableGen] AsmMatcher: allow repeated input operands..
Thu, May 30, 12:35 AM · Restricted Project
SjoerdMeijer committed rGde234847e9db: [TableGen] New default operand "undef_tied_input" (authored by SjoerdMeijer).
[TableGen] New default operand "undef_tied_input"
Thu, May 30, 12:29 AM
SjoerdMeijer committed rL362064: [TableGen] New default operand "undef_tied_input".
[TableGen] New default operand "undef_tied_input"
Thu, May 30, 12:28 AM
SjoerdMeijer closed D60696: [TableGen] New default operand "undef_tied_input"..
Thu, May 30, 12:28 AM · Restricted Project

Wed, May 29

SjoerdMeijer updated the diff for D60698: [ARM] add target arch definitions for 8.1-M and MVE..

More targetparser and buildattribute tests!

Wed, May 29, 8:56 AM · Restricted Project
SjoerdMeijer updated the diff for D60698: [ARM] add target arch definitions for 8.1-M and MVE..

I am helping Simon a bit with upstreaming.

Wed, May 29, 8:23 AM · Restricted Project
SjoerdMeijer commandeered D60698: [ARM] add target arch definitions for 8.1-M and MVE..
Wed, May 29, 8:19 AM · Restricted Project
SjoerdMeijer committed rG24c56296258b: [ARM] Split predicates out into their own .td file (authored by SjoerdMeijer).
[ARM] Split predicates out into their own .td file
Wed, May 29, 6:41 AM
SjoerdMeijer committed rL361958: [ARM] Split predicates out into their own .td file.
[ARM] Split predicates out into their own .td file
Wed, May 29, 6:40 AM
SjoerdMeijer closed D60693: [ARM] Split predicates out into their own .td file..
Wed, May 29, 6:40 AM · Restricted Project
SjoerdMeijer accepted D62526: [AArch64][SVE2] Asm: support FCVTX/FLOGB instructions.

LGTM

Wed, May 29, 1:55 AM · Restricted Project
SjoerdMeijer accepted D62530: [AArch64][SVE2] Asm: support SVE2 vector splice (constructive).

LGTM

Wed, May 29, 1:55 AM · Restricted Project
SjoerdMeijer accepted D62528: [AArch64][SVE2] Asm: support SVE2 load instructions.

LGTM

Wed, May 29, 1:55 AM · Restricted Project