Thanks, looks good to me.

LGTM

Looks okay to me.

Looks like a straightforward fix to me.

Looks like a straightforward fix to me.

LGTM

Looks okay to me

Nit picking the subject/description:

Thanks for reviewing.

These changes look reasonable to me.

Looks like a straight forward fix to me now.

fixed typo

LGTM

Addressed comments.

Ah, sorry, I now see HasConsistentIterationCounts has been suggested in that other ticket. Oh well, as I said, I was bike shedding names (but still think 'invariant' is better :-)) Anyway, please ignore if you disagree.

Addressed comments.

Thanks for the reviews!

Also added HasFullFP16 check to LowerVectorFP_TO_INT.

Added tests for visitSelect.

Thanks, LGTM.

This work is continued in D50228.

Thanks, looks reasonable to me.

Looks like a straight forward fix, but how about the v4f16 variant?

Committed as rL338830

Hi Eli, thanks for the feedback.

Thanks!

This should be straightforward merge/cherry-pick, and nice to have on the release branch. So I would say yes.

LGTM. Thanks for fixing this.

Looks reasonable to me.

LGTM, thanks!

Okay, maybe "heavyweight" was not the right word to describe it, but I meant setting up all the machinery here: creating the lookup tables, doing the lookup. Whether an instruction can be combined, is a property of an instruction, so it looks a natural fit to encode this little bit of extra semantic information in the TSFlags of an instructions. It looks like TSFlags was invented to give instructions these kind of (niche) target properties, and it looks like this is what other backends are doing too. Yes, they are used for all instructions, but it's just 1 bit in a 64bit integer, and we are not using a lot of them yet, so don't risk exceeding the maximum of 64.