- User Since
- Mar 27 2015, 6:20 AM (138 w, 3 d)
Thanks for this.
Thanks for this. Is it possible to put a test? If not, perhaps you can share the output generated for a purposely failing case here (by adding an
Thu, Nov 16
Fri, Nov 10
Thu, Nov 9
Wed, Nov 8
This patch is now dependent on https://reviews.llvm.org/D39808
Tue, Nov 7
As Oli mentioned, I did not find reference to PSR in ARM-ARM when preparing these tables. Leaving it to Renato to decide whether it should still be added.
If you do end up adding, and the encoding is same as XPSR, you could use the Mask bits 1,0,1 to differentiate against existing XPSR encoding entry (otherwise Searchable Table will complain about uniqueness).
Mon, Nov 6
Thanks Diana for the review.
It seems the thumb instruction selection will take more work and needs probably split up into smaller ones (as discussed with Diana). So they will come later.
Fri, Nov 3
Added thumb tests to all three. Also renamed the files to make it clear the test run both arm and thumb
Yes I too was thinking of adding just the run line, but I don't know when we move to instruction-selection would/could we do the same.
And if not, the separation upfront might be a good idea. Please advise. I am ok either way.
Thu, Nov 2
Would it make sense to add a test, so that any future changes doesn't undo this behaviour?
Full context is missing (seems you forgot diff .... -U9999)
Mon, Oct 30
Thanks for the work. However, in its current form the implementation is bit hard to follow. Would it be possible to, describe -
- Your overall approach in the implementation
2.. Describe above the function what it is trying to do (e.g. checkedGetIncrement - which b.t.w looks non-intuitive name).
Sun, Oct 29
Thanks Diana for the feedback. I added the missing tests and they now all pass.
Thu, Oct 26
Tue, Oct 24
Oct 20 2017
Oct 19 2017
As Florian mentioned, it would be good having a test. No need to make a new test, just add a new run line to existing misched test
Oct 16 2017
Oct 15 2017
Oct 13 2017
Context is missing. You may want to generate diff using -U999
Oct 11 2017
Would it be possible to preprocess the *.td with a compacting script that make use of regular expression feature of instregex e.g. (instregex "MMX_*") instead listing everything.
Oct 10 2017
Oct 9 2017
Oct 8 2017
Oct 6 2017
Oct 5 2017
Oct 4 2017
Oct 3 2017
Oct 2 2017
Oct 1 2017
Sep 30 2017
Sep 27 2017
Sep 25 2017
Sep 22 2017
Sep 21 2017
Sep 20 2017
Sep 18 2017
looks ok to me. Thanks for extending these tests.
Will let, however, assigned reviewers, comment/accept further.
Sep 15 2017
Sep 13 2017
Sep 12 2017
Sep 7 2017
Sep 5 2017
Sep 4 2017
I am afraid it seems you forgot to do a diff -U9999, as the full context is not visible.
Sep 1 2017
You mention "For now point is fixed in the middle [32 bits].[32 bits], which makes calculations simple and fast.". Perhaps this should be commented in the code as well.
Aug 30 2017
Aug 29 2017
I am not an expert in this so may be a wrong question - once a new contributor is identified by this script, it is added as subscriber to 'what' ?
As a broad brush, more features to phabricator seems a good idea as it is so commonly now used.