Page MenuHomePhabricator

simon_tatham (Simon Tatham)
Compiler Engineer (Arm)

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2017, 1:23 AM (298 w, 1 d)

Recent Activity

Fri, Mar 24

simon_tatham accepted D146731: [extract_symbols.py] Export unique symbols.
Fri, Mar 24, 7:44 AM · Restricted Project, Restricted Project

Mon, Mar 13

simon_tatham committed rG5fba4c4d08bd: [AArch64] Don't #define __ARM_FP when there's no FPU. (authored by simon_tatham).
[AArch64] Don't #define __ARM_FP when there's no FPU.
Mon, Mar 13, 9:43 AM · Restricted Project, Restricted Project
simon_tatham closed D145781: [AArch64] Don't #define __ARM_FP when there's no FPU..
Mon, Mar 13, 9:43 AM · Restricted Project, Restricted Project

Fri, Mar 10

simon_tatham requested review of D145781: [AArch64] Don't #define __ARM_FP when there's no FPU..
Fri, Mar 10, 3:42 AM · Restricted Project, Restricted Project

Thu, Mar 9

simon_tatham added inline comments to D145567: [Driver] Rename multilib flags to tags.
Thu, Mar 9, 2:59 AM · Restricted Project, Restricted Project
simon_tatham added a comment to D145567: [Driver] Rename multilib flags to tags.

But it was useful to have it separate at least for review purposes, since it made it much easier when Michael asked me to proofread the change from 'flags' to 'tags'!

Thu, Mar 9, 2:51 AM · Restricted Project, Restricted Project

Feb 21 2023

simon_tatham accepted D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON.
Feb 21 2023, 1:14 AM · Restricted Project, Restricted Project

Feb 20 2023

simon_tatham committed rGa8cd35c3b7d5: [LowerTypeTests] Support generating Armv6-M jump tables. (reland) (authored by simon_tatham).
[LowerTypeTests] Support generating Armv6-M jump tables. (reland)
Feb 20 2023, 2:47 AM · Restricted Project, Restricted Project

Feb 16 2023

simon_tatham added a reverting change for D143576: [LowerTypeTests] Support generating Armv6-M jump tables.: rGbbef38352fba: Revert "[LowerTypeTests] Support generating Armv6-M jump tables.".
Feb 16 2023, 9:11 AM · Restricted Project, Restricted Project
simon_tatham added a reverting change for rGf6ddf7781471: [LowerTypeTests] Support generating Armv6-M jump tables.: rGbbef38352fba: Revert "[LowerTypeTests] Support generating Armv6-M jump tables.".
Feb 16 2023, 9:11 AM · Restricted Project, Restricted Project
simon_tatham committed rGbbef38352fba: Revert "[LowerTypeTests] Support generating Armv6-M jump tables." (authored by simon_tatham).
Revert "[LowerTypeTests] Support generating Armv6-M jump tables."
Feb 16 2023, 9:11 AM · Restricted Project, Restricted Project
simon_tatham committed rGf6ddf7781471: [LowerTypeTests] Support generating Armv6-M jump tables. (authored by simon_tatham).
[LowerTypeTests] Support generating Armv6-M jump tables.
Feb 16 2023, 7:35 AM · Restricted Project, Restricted Project
simon_tatham closed D143576: [LowerTypeTests] Support generating Armv6-M jump tables..
Feb 16 2023, 7:34 AM · Restricted Project, Restricted Project
simon_tatham added a comment to D143576: [LowerTypeTests] Support generating Armv6-M jump tables..

Ping? @lenary agreed that this is the least bad option to fix the codegen fault, and a week ago I fixed the only problem I knew of with the patch.

Feb 16 2023, 7:09 AM · Restricted Project, Restricted Project

Feb 15 2023

simon_tatham added a comment to D144079: [AArch64InstPrinter][llvm-objdump] Print ADR PC-relative label as a target address hexadecimal form.

I think that most ideally, if you don't know the true address of the instruction being disassembled, the best way to disassemble ADR is to indicate explicitly that the address you're going to end up with depends on that unknown, and not make it look as if it's a constant.

Feb 15 2023, 3:20 AM · Restricted Project, Restricted Project
simon_tatham accepted D144079: [AArch64InstPrinter][llvm-objdump] Print ADR PC-relative label as a target address hexadecimal form.

A much needed improvement – thanks!

Feb 15 2023, 1:42 AM · Restricted Project, Restricted Project

Feb 9 2023

simon_tatham updated the diff for D143576: [LowerTypeTests] Support generating Armv6-M jump tables..

Revised the patch to make the right decision on Armv6 and before, where Arm and Thumb-1 jump tables are both available, and we always want to pick Arm because it's smaller and faster. This also exposed a bug in which `getJumpTableEntrySize was ignoring the fact that selectJumpTableArmEncoding` might have swapped to the other one of Arm and Thumb (and until now it didn't matter because the table entries were always the same size for both).

Feb 9 2023, 9:49 AM · Restricted Project, Restricted Project
simon_tatham added a comment to D143576: [LowerTypeTests] Support generating Armv6-M jump tables..

Nevermind, this doesn't actually help what you're doing; the Thumbv6m thunks are a different size.

Feb 9 2023, 2:54 AM · Restricted Project, Restricted Project

Feb 8 2023

simon_tatham added a comment to D143576: [LowerTypeTests] Support generating Armv6-M jump tables..

I see what you mean, but in that case, how do we deal with the fact that there are multiple TargetTransformInfos involved? If there was just one for the whole module then that would make sense, but there's one per function. In the current version of the patch I'm iterating over all of them asking about b.w support, and making a single decision about the jump table format based on the results of all those queries.

Feb 8 2023, 7:49 AM · Restricted Project, Restricted Project
simon_tatham added a comment to D143576: [LowerTypeTests] Support generating Armv6-M jump tables..

I don't see how. TargetTransformInfo isn't a base class with target-specific descendants. It wraps an Impl class which you can't get out of it, and even if you could, there's no LLVM-style dyn_cast setup to allow detecting its concrete type.

Feb 8 2023, 6:27 AM · Restricted Project, Restricted Project
simon_tatham requested review of D143576: [LowerTypeTests] Support generating Armv6-M jump tables..
Feb 8 2023, 5:46 AM · Restricted Project, Restricted Project

Feb 6 2023

simon_tatham accepted D142989: [extract_symbols.py] Better handling of templates.

LGTM, with a small commenting nit.

Feb 6 2023, 6:42 AM · Restricted Project, Restricted Project

Feb 1 2023

simon_tatham committed rG60ea6f35a270: [ARM] Allow selecting hard-float ABI in integer-only MVE. (authored by simon_tatham).
[ARM] Allow selecting hard-float ABI in integer-only MVE.
Feb 1 2023, 1:05 AM · Restricted Project, Restricted Project, Restricted Project
simon_tatham closed D142703: [ARM] Allow selecting hard-float ABI in integer-only MVE..
Feb 1 2023, 1:05 AM · Restricted Project, Restricted Project, Restricted Project

Jan 27 2023

simon_tatham updated the diff for D142703: [ARM] Allow selecting hard-float ABI in integer-only MVE..

Added draft release notes, and an extra comment in the modified test file.

Jan 27 2023, 5:55 AM · Restricted Project, Restricted Project, Restricted Project
simon_tatham retitled D142703: [ARM] Allow selecting hard-float ABI in integer-only MVE. from [ARM] Allow selecting the hard float ABI in integer-only MVE. r=MaskRay,dmgreen,efriedma,john.brawn,lenary,ostannard to [ARM] Allow selecting the hard float ABI in integer-only MVE..
Jan 27 2023, 3:46 AM · Restricted Project, Restricted Project, Restricted Project
simon_tatham requested review of D142703: [ARM] Allow selecting hard-float ABI in integer-only MVE..
Jan 27 2023, 3:46 AM · Restricted Project, Restricted Project, Restricted Project

Jan 20 2023

simon_tatham added inline comments to D142217: [MC] Store target Insts table in reverse order. NFC..
Jan 20 2023, 9:09 AM · Restricted Project, Restricted Project
simon_tatham added inline comments to D142217: [MC] Store target Insts table in reverse order. NFC..
Jan 20 2023, 8:40 AM · Restricted Project, Restricted Project

Jan 17 2023

simon_tatham added a comment to D140959: RFC: Multilib prototype.

"Make difficult things possible": perhaps it might be useful to make sure it's at least possible to express a complex boolean function of the basic predicates, even if it's cumbersome? (So that, for example, you could make an attribute conditional on "this cc1 option but not that one".) I assume YAML would let you write something like an expression AST in hierarchical form, with predicates like regex: at the leaves, and internal nodes for AND, OR and NOT.

Jan 17 2023, 8:55 AM · Restricted Project, Restricted Project

Jan 12 2023

simon_tatham accepted D141511: [ARM] Use MCInstrInfo::get in ARMDisassembler instead of reinventing it.
Jan 12 2023, 5:36 AM · Restricted Project, Restricted Project

Dec 6 2022

simon_tatham accepted D139407: [llvm-objdump][AArch64] Fix ADRP target label calculation.
Dec 6 2022, 4:48 AM · Restricted Project, Restricted Project

Dec 5 2022

simon_tatham accepted D139131: [llvm-objdump] Avoid using mapping symbols as branch target labels.

Yes, I agree too – definitely a good change.

Dec 5 2022, 1:20 AM · Restricted Project, Restricted Project

Nov 29 2022

simon_tatham committed rGe45cbf9923e9: [ARM,MVE] Update MVE_VMLA_qr for architecture change. (authored by simon_tatham).
[ARM,MVE] Update MVE_VMLA_qr for architecture change.
Nov 29 2022, 12:47 AM · Restricted Project, Restricted Project
simon_tatham closed D138827: [ARM,MVE] Update MVE_VMLA_qr for architecture change..
Nov 29 2022, 12:47 AM · Restricted Project, Restricted Project

Nov 28 2022

simon_tatham requested review of D138827: [ARM,MVE] Update MVE_VMLA_qr for architecture change..
Nov 28 2022, 8:39 AM · Restricted Project, Restricted Project

Nov 17 2022

simon_tatham updated the diff for D132541: [llvm-objcopy] Introduce 'ihex-flat' output format..

Sorry to have been so long getting back to this! It was relegated to my back burner for a while, but I've now found time to address the review comments so far.

Nov 17 2022, 5:32 AM · Restricted Project, Restricted Project

Nov 15 2022

simon_tatham accepted D121929: [AArch64] Mark all instructions that read/write FPCR as doing so.
Nov 15 2022, 3:48 AM · Restricted Project, Restricted Project

Nov 3 2022

simon_tatham accepted D137256: [AArch64] Alter arm_fp16.h to be target-based, not preprocessor based..

But otherwise this is a very easy-to-check change compared to the previous ones on the same lines :-) LGTM.

Nov 3 2022, 7:44 AM · Restricted Project, Restricted Project
simon_tatham added a comment to D137256: [AArch64] Alter arm_fp16.h to be target-based, not preprocessor based..

Nit: your summary line and commit message don't match :-) One of them says "changed from target to preprocessor" and the other vice versa.

Nov 3 2022, 7:28 AM · Restricted Project, Restricted Project

Oct 24 2022

simon_tatham accepted D135615: [AArch64][ARM] Alter v8.1a neon intrinsics to be target-based, not preprocessor based.

Ah, yes, now I see it. Thanks for clarifying.

Oct 24 2022, 5:39 AM · Restricted Project, Restricted Project, Restricted Project
simon_tatham added inline comments to D135615: [AArch64][ARM] Alter v8.1a neon intrinsics to be target-based, not preprocessor based.
Oct 24 2022, 3:00 AM · Restricted Project, Restricted Project, Restricted Project

Oct 18 2022

simon_tatham added a comment to rG6db71b8f1418: [ConstraintElim] Use helper to allow overflow for coefficients of GEPs.

Hmm, yes, sorry about that. Using -print-after-all, it looks as if the useful parts of the loop body are vanishing during InstCombine, and indeed the ConstraintElim pass isn't running at all.

Oct 18 2022, 7:48 AM · Restricted Project, Restricted Project
simon_tatham added a comment to rG6db71b8f1418: [ConstraintElim] Use helper to allow overflow for coefficients of GEPs.

Hello. I think this recent change is the one that's caused clang to begin optimizing C code of the following type into the empty function:

extern const size_t start[], end[];
for (const size_t *p = start; p != end; ++p) { /* do stuff */ }
Oct 18 2022, 7:32 AM · Restricted Project, Restricted Project

Oct 13 2022

simon_tatham committed rG526ce9c9299a: Propagate tied operands when copying a MachineInstr. (authored by simon_tatham).
Propagate tied operands when copying a MachineInstr.
Oct 13 2022, 1:41 AM · Restricted Project, Restricted Project
simon_tatham closed D135434: Propagate tied operands when copying a MachineInstr..
Oct 13 2022, 1:40 AM · Restricted Project, Restricted Project

Oct 12 2022

simon_tatham accepted D135430: [llvm-objdump] Support nonzero section addresses in addSymbolizer.

No, I think this was exactly the mistake on my part that it looks like. Good catch, and thanks for fixing it!

Oct 12 2022, 1:22 AM · Restricted Project, Restricted Project
simon_tatham added inline comments to D130357: [MC,llvm-objdump,ARM] Target-dependent disassembly resync policy..
Oct 12 2022, 1:21 AM · Restricted Project, Restricted Project

Oct 11 2022

simon_tatham updated the diff for D135434: Propagate tied operands when copying a MachineInstr..

Going by the new test llvm/test/CodeGen/Thumb2/pipeliner-inlineasm, the two pieces of code don't conflict if both are present. But the code in the pipeliner also doesn't seem to be necessary any more. So I've revised this patch to remove it, and do all tie propagation centrally in MachineInstr's copy constructor.

Oct 11 2022, 5:33 AM · Restricted Project, Restricted Project
simon_tatham committed rG0648e42e5281: [NFC] Pre-commit tests for D135434. (authored by simon_tatham).
[NFC] Pre-commit tests for D135434.
Oct 11 2022, 5:31 AM · Restricted Project, Restricted Project

Oct 10 2022

simon_tatham added a comment to D135434: Propagate tied operands when copying a MachineInstr..

This sounds OK to me, and is probably how I would fix this. But it will effect more than just the MachinePipeliner, anything that goes through CloneMachineInstr. Looking at where that is uses, that seems like most the uses should be OK. I'm don't think many backends will use these implicit tied uses, and copying them sounds more correct during a clone.

Oct 10 2022, 3:46 AM · Restricted Project, Restricted Project

Oct 7 2022

simon_tatham requested review of D135434: Propagate tied operands when copying a MachineInstr..
Oct 7 2022, 2:54 AM · Restricted Project, Restricted Project

Aug 24 2022

simon_tatham committed rG79f99bf6220e: [bolt] Fix a test affected by D131589. (authored by simon_tatham).
[bolt] Fix a test affected by D131589.
Aug 24 2022, 7:52 AM · Restricted Project
simon_tatham committed rG8e29f3f1c35a: [llvm-objdump] Handle multiple syms at same addr in disassembly. (authored by simon_tatham).
[llvm-objdump] Handle multiple syms at same addr in disassembly.
Aug 24 2022, 7:08 AM · Restricted Project, Restricted Project
simon_tatham closed D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly..
Aug 24 2022, 7:08 AM · Restricted Project, Restricted Project
simon_tatham added a comment to D132541: [llvm-objcopy] Introduce 'ihex-flat' output format..

Absolutely, I agree. Off the top of my head, the most obvious continuing use case for x86-16 is first-stage bootloaders that the PC BIOS runs in real mode. I've no idea what tools people typically use for those these days, but I wouldn't have a hard time at all believing that it might turn out to be a hodgepodge of bits and pieces from all over the place.

Aug 24 2022, 5:39 AM · Restricted Project, Restricted Project
simon_tatham added a comment to D132541: [llvm-objcopy] Introduce 'ihex-flat' output format..

Supplementary discussion:

Aug 24 2022, 2:46 AM · Restricted Project, Restricted Project
simon_tatham requested review of D132541: [llvm-objcopy] Introduce 'ihex-flat' output format..
Aug 24 2022, 2:45 AM · Restricted Project, Restricted Project

Aug 22 2022

simon_tatham added inline comments to D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly..
Aug 22 2022, 2:40 AM · Restricted Project, Restricted Project
simon_tatham updated the diff for D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly..

Adjusted check prefixes, and translated all yaml2obj inputs into llvm-mc inputs (which in all cases fails with the old llvm-objdump, i.e. still produces an object file that successfully tests the changed behaviour).

Aug 22 2022, 2:40 AM · Restricted Project, Restricted Project

Aug 19 2022

simon_tatham added a comment to D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly..

(Ah, that's where the one last unticked Done box was hiding.)

Aug 19 2022, 7:26 AM · Restricted Project, Restricted Project
simon_tatham committed rGa771a91dcbe6: [libcxxabi] Fix alignment of pointers returned by fallback_malloc (authored by simon_tatham).
[libcxxabi] Fix alignment of pointers returned by fallback_malloc
Aug 19 2022, 7:09 AM · Restricted Project
simon_tatham closed D129842: [libcxxabi] Fix alignment of pointers returned by fallback_malloc.
Aug 19 2022, 7:08 AM · Restricted Project, Restricted Project
simon_tatham updated the diff for D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly..

I think I've now addressed all your review comments, including adding a demonstration of alphabetical order vs demangling.

Aug 19 2022, 7:07 AM · Restricted Project, Restricted Project
simon_tatham added inline comments to D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly..
Aug 19 2022, 7:07 AM · Restricted Project, Restricted Project
simon_tatham updated the diff for D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly..

Moved the check for data symbols to before we choose symbols to display, so that the same check can control which symbol is printed and how the data after it is disassembled.

Aug 19 2022, 2:35 AM · Restricted Project, Restricted Project
simon_tatham added a comment to D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly..

I think one bit of testing you still need is showing whether the demangled or raw name is used for the priority ordering of symbol names.

Aug 19 2022, 2:35 AM · Restricted Project, Restricted Project

Aug 17 2022

simon_tatham added a comment to D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly..

I've left most of your comments un-replied-to so far, because I need to think harder about the choice of symbols to display, as mentioned in one of my inline comments below.

Aug 17 2022, 3:51 AM · Restricted Project, Restricted Project

Aug 16 2022

simon_tatham updated the diff for D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly..

Added another test to check that the new data vs code priorities work.

Aug 16 2022, 7:54 AM · Restricted Project, Restricted Project

Aug 15 2022

simon_tatham updated the diff for D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly..

Updated handling of STT_OBJECT symbols as discussed. Also added a comment about the confusing double loop setting up the demangled symbol names, since the next person might also wonder why it's not being done in one step.

Aug 15 2022, 3:03 AM · Restricted Project, Restricted Project
simon_tatham added inline comments to D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly..
Aug 15 2022, 3:03 AM · Restricted Project, Restricted Project

Aug 12 2022

simon_tatham added inline comments to D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly..
Aug 12 2022, 3:00 AM · Restricted Project, Restricted Project
simon_tatham updated subscribers of D129842: [libcxxabi] Fix alignment of pointers returned by fallback_malloc.

Ping again. If I'm reading the libc++ group members page right, this patch needs to be looked at by at least one of: @EricWF @erik.pilkington @ldionne @mclow.lists @phosek @compnerd @urnathan . Is there somewhere else I should be asking, to bring it to the attention of the right people?

Aug 12 2022, 1:44 AM · Restricted Project, Restricted Project

Aug 11 2022

simon_tatham updated the diff for D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly..

Addressed all review comments (I think) other than the question of STT_OBJECT priority versus other kinds of symbol.

Aug 11 2022, 6:20 AM · Restricted Project, Restricted Project
simon_tatham added a comment to D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly..

I'm not the code owner of these disassembly tools

Aug 11 2022, 6:19 AM · Restricted Project, Restricted Project

Aug 10 2022

simon_tatham requested review of D131589: [llvm-objdump] Handle multiple syms at same addr in disassembly..
Aug 10 2022, 9:28 AM · Restricted Project, Restricted Project
simon_tatham added a comment to D131555: [Clang] Propagate const context info when emitting compound literal.

The clang code change looks reasonable to me, but I'm not the most expert in that area.

Aug 10 2022, 3:32 AM · Restricted Project, Restricted Project

Aug 8 2022

simon_tatham added inline comments to D130981: [yaml2obj] Add a `-E` flag to preprocess only..
Aug 8 2022, 5:48 AM · Restricted Project, Restricted Project
simon_tatham added a comment to D130902: [llvm-objdump,ARM] Fix big-endian AArch32 disassembly..

Oh, oops, caught out again :-( I really must stop assuming that a Phab comment saying "LGTM" actually marks the patch as accepted. Sorry about that. Will revert if you need me to.

Aug 8 2022, 2:52 AM · Restricted Project, Restricted Project
simon_tatham committed rG72017e9b16b7: [llvm-objdump,ARM] Fix big-endian AArch32 disassembly. (authored by simon_tatham).
[llvm-objdump,ARM] Fix big-endian AArch32 disassembly.
Aug 8 2022, 2:50 AM · Restricted Project, Restricted Project
simon_tatham closed D130902: [llvm-objdump,ARM] Fix big-endian AArch32 disassembly..
Aug 8 2022, 2:50 AM · Restricted Project, Restricted Project

Aug 5 2022

simon_tatham added a comment to D130902: [llvm-objdump,ARM] Fix big-endian AArch32 disassembly..

I didn't know about that previous patch at all, but off the top of my head, yes, I don't think it should be necessary at least for ELF files, because the combination of ELF header endianness and EF_ARM_BE8 flag is enough to autodetect the right code endianness in all cases.

Aug 5 2022, 9:03 AM · Restricted Project, Restricted Project
simon_tatham added a comment to D129842: [libcxxabi] Fix alignment of pointers returned by fallback_malloc.

Ping. Can someone in the libc++abi blocking reviewer group take a look at this patch, please?

Aug 5 2022, 2:31 AM · Restricted Project, Restricted Project

Aug 4 2022

simon_tatham added a comment to D130981: [yaml2obj] Add a `-E` flag to preprocess only..

Oh yes, sorry about that. Switching a little too fast between projects with completely different code review practices :-(

Aug 4 2022, 9:05 AM · Restricted Project, Restricted Project

Aug 3 2022

simon_tatham accepted D131064: [AArch64] Alter arm_sve.h to be target-based, not preprocessor based..

I love it! I'm generally frustrated by any software that says "what even is this, I've never heard of it" when it could so easily change it to "I have heard of this but it's not allowed in this particular context because reason". If nothing else, it means you get different error messages for "misspelled an intrinsic" and "used one from SVE version n+1".

Aug 3 2022, 6:28 AM · Restricted Project, Restricted Project
simon_tatham accepted D130973: [AArch64] Always allow the __bf16 type.

Ah, yes, I misread what the test changes were about – I didn't notice that you'd only just introduced the scalar error context, and thought you were enabling all those operations in at least one situation, rather than changing the form of the check that they were unconditionally disabled.

Aug 3 2022, 3:02 AM · Restricted Project, Restricted Project

Aug 2 2022

simon_tatham added a comment to D130973: [AArch64] Always allow the __bf16 type.

What actually happens if you try this? Normally I'd expect that if a thing is forbidden in the front end it's because otherwise it would lead to a codegen crash or something similar. But this patch is only removing the restriction, and not adding any support. Is that part already done, and bf16 operations will get automatically converted into some libcall that already exists, in the absence of any better approach?

Aug 2 2022, 7:00 AM · Restricted Project, Restricted Project
simon_tatham committed rG07e6eb6e75b8: [yaml2obj] Add a `-E` flag to preprocess only. (authored by simon_tatham).
[yaml2obj] Add a `-E` flag to preprocess only.
Aug 2 2022, 5:58 AM · Restricted Project, Restricted Project
simon_tatham closed D130981: [yaml2obj] Add a `-E` flag to preprocess only..
Aug 2 2022, 5:58 AM · Restricted Project, Restricted Project
simon_tatham added inline comments to D130981: [yaml2obj] Add a `-E` flag to preprocess only..
Aug 2 2022, 5:50 AM · Restricted Project, Restricted Project
simon_tatham added a comment to D130981: [yaml2obj] Add a `-E` flag to preprocess only..

I wrote this patch in order to use it myself. Naturally the problem I was trying to debug turned out to be embarrassingly trivial – I hadn't made a subtle mistake in the macro syntax, I'd put my -D options on completely the wrong command line. But now I've written the patch anyway it seems a pity to waste it :-)

Aug 2 2022, 4:08 AM · Restricted Project, Restricted Project
simon_tatham updated the diff for D130902: [llvm-objdump,ARM] Fix big-endian AArch32 disassembly..

Addressed all review comments, I think.

Aug 2 2022, 4:07 AM · Restricted Project, Restricted Project
simon_tatham requested review of D130981: [yaml2obj] Add a `-E` flag to preprocess only..
Aug 2 2022, 4:05 AM · Restricted Project, Restricted Project

Aug 1 2022

simon_tatham added inline comments to D130902: [llvm-objdump,ARM] Fix big-endian AArch32 disassembly..
Aug 1 2022, 7:57 AM · Restricted Project, Restricted Project
simon_tatham updated the diff for D130902: [llvm-objdump,ARM] Fix big-endian AArch32 disassembly..

Updated with arc lint style fixes.

Aug 1 2022, 7:34 AM · Restricted Project, Restricted Project
simon_tatham requested review of D130902: [llvm-objdump,ARM] Fix big-endian AArch32 disassembly..
Aug 1 2022, 7:31 AM · Restricted Project, Restricted Project

Jul 29 2022

simon_tatham updated the diff for D129842: [libcxxabi] Fix alignment of pointers returned by fallback_malloc.

Corrected that comment.

Jul 29 2022, 2:05 AM · Restricted Project, Restricted Project

Jul 26 2022

simon_tatham committed rG0db13e10c564: [bolt,AArch64] Fix one more test failure from D130358. (authored by simon_tatham).
[bolt,AArch64] Fix one more test failure from D130358.
Jul 26 2022, 8:41 AM · Restricted Project
simon_tatham committed rG5c396be5750e: [llvm-objdump,ARM] Fix further test failures. (authored by simon_tatham).
[llvm-objdump,ARM] Fix further test failures.
Jul 26 2022, 3:35 AM · Restricted Project, Restricted Project
simon_tatham committed rGae16b2ed9871: [llvm-objdump,ARM] Fix a lot more tests. (authored by simon_tatham).
[llvm-objdump,ARM] Fix a lot more tests.
Jul 26 2022, 2:22 AM · Restricted Project, Restricted Project