Page MenuHomePhabricator

simon_tatham (Simon Tatham)
Compiler Engineer (Arm)

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2017, 1:23 AM (141 w, 6 d)

Recent Activity

Fri, Mar 27

simon_tatham accepted D76927: [ARM,CDE] Improve CDE intrinsics testing.
Fri, Mar 27, 8:45 AM · Restricted Project
simon_tatham accepted D76910: [ARM] Make remaining MVE instruction predictable.
Fri, Mar 27, 5:24 AM
simon_tatham added a comment to D76910: [ARM] Make remaining MVE instruction predictable.

Are we talking about CONSTRAINED_UNPREDICTABLE here?

Fri, Mar 27, 4:17 AM
simon_tatham added a comment to D76910: [ARM] Make remaining MVE instruction predictable.

Do you understand why all those test outputs have changed as a side effect of this?

Fri, Mar 27, 3:10 AM

Thu, Mar 26

simon_tatham committed rG6a946993d519: Do export symbols when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is on. (authored by simon_tatham).
Do export symbols when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is on.
Thu, Mar 26, 2:08 AM
simon_tatham closed D76760: Do export symbols when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is on..
Thu, Mar 26, 2:08 AM · Restricted Project

Wed, Mar 25

simon_tatham accepted D76610: [ARM,CDE] Implement predicated Q-register CDE intrinsics.
Wed, Mar 25, 8:04 AM · Restricted Project
simon_tatham committed rG8f1651ccead1: [ARM,MVE] Add missing tests for vqdmlash intrinsics. (authored by simon_tatham).
[ARM,MVE] Add missing tests for vqdmlash intrinsics.
Wed, Mar 25, 3:13 AM
simon_tatham closed D76714: [ARM,MVE] Add missing tests for vqdmlash intrinsics..
Wed, Mar 25, 3:13 AM · Restricted Project
simon_tatham created D76760: Do export symbols when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is on..
Wed, Mar 25, 3:13 AM · Restricted Project

Tue, Mar 24

simon_tatham created D76714: [ARM,MVE] Add missing tests for vqdmlash intrinsics..
Tue, Mar 24, 10:12 AM · Restricted Project
simon_tatham committed rGf282b6ab23a0: [ReleaseNotes,ARM] MVE intrinsics are all implemented! (authored by simon_tatham).
[ReleaseNotes,ARM] MVE intrinsics are all implemented!
Tue, Mar 24, 4:48 AM
simon_tatham closed D76513: [ReleaseNotes,ARM] MVE intrinsics are all implemented!.
Tue, Mar 24, 4:48 AM · Restricted Project, Restricted Project
simon_tatham updated the diff for D76513: [ReleaseNotes,ARM] MVE intrinsics are all implemented!.

Added an entry to the Clang release notes as well.

Tue, Mar 24, 3:12 AM · Restricted Project, Restricted Project

Mon, Mar 23

simon_tatham accepted D76511: [ARM] Don't split trunc stores that can be better handled as VMOVN.
Mon, Mar 23, 2:43 AM · Restricted Project
simon_tatham accepted D76139: [Target][ARM] Change VPTMaskValues to the correct encoding.

LGTM, with only one tiny remaining nitpick.

Mon, Mar 23, 2:43 AM · Restricted Project

Fri, Mar 20

simon_tatham created D76513: [ReleaseNotes,ARM] MVE intrinsics are all implemented!.
Fri, Mar 20, 10:17 AM · Restricted Project, Restricted Project
simon_tatham committed rG45a9945b9ea9: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family. (authored by simon_tatham).
[ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family.
Fri, Mar 20, 9:11 AM
simon_tatham committed rG1adfa4c99169: [ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family. (authored by simon_tatham).
[ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family.
Fri, Mar 20, 9:11 AM
simon_tatham closed D76491: [ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family..
Fri, Mar 20, 9:11 AM · Restricted Project
simon_tatham closed D76490: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family..
Fri, Mar 20, 9:11 AM · Restricted Project
simon_tatham updated the diff for D76490: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family..

Update tests to fix CI failure (oops). Also added opt -sroa to make the incidental half/float argument marshalling a bit less verbose.

Fri, Mar 20, 7:32 AM · Restricted Project
simon_tatham created D76490: [ARM,MVE] Add ACLE intrinsics for the vminv/vmaxv family..
Fri, Mar 20, 5:23 AM · Restricted Project
simon_tatham created D76491: [ARM,MVE] Add ACLE intrinsics for the vaddv/vaddlv family..
Fri, Mar 20, 5:23 AM · Restricted Project

Wed, Mar 18

simon_tatham committed rGe13d153c1b59: [ARM,MVE] Add intrinsics for the VQDMLAD family. (authored by simon_tatham).
[ARM,MVE] Add intrinsics for the VQDMLAD family.
Wed, Mar 18, 10:21 AM
simon_tatham closed D76359: [ARM,MVE] Add intrinsics for the VQDMLAD family..
Wed, Mar 18, 10:20 AM · Restricted Project
simon_tatham added inline comments to D76139: [Target][ARM] Change VPTMaskValues to the correct encoding.
Wed, Mar 18, 9:47 AM · Restricted Project
simon_tatham created D76359: [ARM,MVE] Add intrinsics for the VQDMLAD family..
Wed, Mar 18, 6:31 AM · Restricted Project
simon_tatham committed rG28c5d97beec7: [ARM,MVE] Add intrinsics and isel for MVE integer VMLA. (authored by simon_tatham).
[ARM,MVE] Add intrinsics and isel for MVE integer VMLA.
Wed, Mar 18, 4:19 AM
simon_tatham committed rG928776de9233: [ARM,MVE] Add intrinsics for the VQDMLAH family. (authored by simon_tatham).
[ARM,MVE] Add intrinsics for the VQDMLAH family.
Wed, Mar 18, 4:19 AM
simon_tatham closed D76123: [ARM,MVE] Add intrinsics for the VQDMLAH family..
Wed, Mar 18, 4:19 AM · Restricted Project
simon_tatham closed D76122: [ARM,MVE] Add intrinsics and isel for MVE integer VMLA..
Wed, Mar 18, 4:19 AM · Restricted Project
simon_tatham added inline comments to D76139: [Target][ARM] Change VPTMaskValues to the correct encoding.
Wed, Mar 18, 3:46 AM · Restricted Project

Tue, Mar 17

simon_tatham added inline comments to D76139: [Target][ARM] Change VPTMaskValues to the correct encoding.
Tue, Mar 17, 8:31 AM · Restricted Project

Mon, Mar 16

simon_tatham added inline comments to D76122: [ARM,MVE] Add intrinsics and isel for MVE integer VMLA..
Mon, Mar 16, 10:20 AM · Restricted Project

Fri, Mar 13

simon_tatham updated the diff for D76122: [ARM,MVE] Add intrinsics and isel for MVE integer VMLA..

Fix clang-format warnings.

Fri, Mar 13, 4:24 AM · Restricted Project
simon_tatham created D76122: [ARM,MVE] Add intrinsics and isel for MVE integer VMLA..
Fri, Mar 13, 2:58 AM · Restricted Project
simon_tatham created D76123: [ARM,MVE] Add intrinsics for the VQDMLAH family..
Fri, Mar 13, 2:58 AM · Restricted Project

Thu, Mar 12

simon_tatham committed rG3f8e714e2f9f: [ARM,MVE] Add intrinsics and isel for MVE fused multiply-add. (authored by simon_tatham).
[ARM,MVE] Add intrinsics and isel for MVE fused multiply-add.
Thu, Mar 12, 4:30 AM
simon_tatham committed rGd608fee8399a: [ARM,MVE] Fix user-namespace violation in arm_mve.h. (authored by simon_tatham).
[ARM,MVE] Fix user-namespace violation in arm_mve.h.
Thu, Mar 12, 4:30 AM
simon_tatham closed D75997: [ARM,MVE] Fix user-namespace violation in arm_mve.h..
Thu, Mar 12, 4:30 AM · Restricted Project
simon_tatham closed D75998: [ARM,MVE] Add intrinsics and isel for MVE fused multiply-add..
Thu, Mar 12, 4:30 AM · Restricted Project, Restricted Project

Wed, Mar 11

simon_tatham updated the diff for D75998: [ARM,MVE] Add intrinsics and isel for MVE fused multiply-add..

Update test results following a last-minute correctness fix. (I updated one of the two test files but not the other.)

Wed, Mar 11, 9:04 AM · Restricted Project, Restricted Project
simon_tatham created D75997: [ARM,MVE] Fix user-namespace violation in arm_mve.h..
Wed, Mar 11, 9:04 AM · Restricted Project
simon_tatham added a comment to D75990: [ARM] MVE VFMA (reg) and VFMAS patterns.

... but I hadn't quite uploaded it yet. Now I have: D75998.

Wed, Mar 11, 9:04 AM · Restricted Project
simon_tatham created D75998: [ARM,MVE] Add intrinsics and isel for MVE fused multiply-add..
Wed, Mar 11, 9:04 AM · Restricted Project, Restricted Project

Tue, Mar 10

simon_tatham accepted D75850: [ARM,CDE] Generalize MVE intrinsics infrastructure to support CDE.

LGTM with a couple of tiny spelling nitpicks.

Tue, Mar 10, 5:48 AM · Restricted Project, Restricted Project

Mon, Mar 9

simon_tatham updated subscribers of D75850: [ARM,CDE] Generalize MVE intrinsics infrastructure to support CDE.

Renames the 'clang_arm_mve_alias' attribute into 'clang_arm_builtin_alias' (it will be used with CDE intrinsics as well as MVE intrinsics)

Mon, Mar 9, 9:41 AM · Restricted Project, Restricted Project
simon_tatham accepted D75843: [ARM,CDE] Implement CDE feature test macros.
Mon, Mar 9, 9:08 AM · Restricted Project
simon_tatham added inline comments to D75843: [ARM,CDE] Implement CDE feature test macros.
Mon, Mar 9, 8:35 AM · Restricted Project
simon_tatham requested changes to D75843: [ARM,CDE] Implement CDE feature test macros.
Mon, Mar 9, 6:57 AM · Restricted Project

Thu, Mar 5

simon_tatham added inline comments to D75470: [SVE] Auto-generate builtins and header for svld1..
Thu, Mar 5, 8:13 AM · Restricted Project

Wed, Mar 4

simon_tatham committed rG810127f6ab5d: [ARM,MVE] Add the `vsbciq` intrinsics. (authored by simon_tatham).
[ARM,MVE] Add the `vsbciq` intrinsics.
Wed, Mar 4, 1:13 AM
simon_tatham committed rG068b2f313c7d: [ARM,MVE] Add the `vshlcq` intrinsics. (authored by simon_tatham).
[ARM,MVE] Add the `vshlcq` intrinsics.
Wed, Mar 4, 1:13 AM
simon_tatham closed D75444: [ARM,MVE] Add the `vsbciq` intrinsics..
Wed, Mar 4, 1:13 AM · Restricted Project, Restricted Project
simon_tatham closed D75445: [ARM,MVE] Add the `vshlcq` intrinsics..
Wed, Mar 4, 1:13 AM · Restricted Project, Restricted Project

Mon, Mar 2

simon_tatham updated the diff for D75445: [ARM,MVE] Add the `vshlcq` intrinsics..

clang-formatted the new C test file.

Mon, Mar 2, 7:24 AM · Restricted Project, Restricted Project
simon_tatham updated the diff for D75444: [ARM,MVE] Add the `vsbciq` intrinsics..

clang-formatted the code added to the C test source.

Mon, Mar 2, 7:24 AM · Restricted Project, Restricted Project
simon_tatham created D75444: [ARM,MVE] Add the `vsbciq` intrinsics..
Mon, Mar 2, 3:53 AM · Restricted Project, Restricted Project
simon_tatham created D75445: [ARM,MVE] Add the `vshlcq` intrinsics..
Mon, Mar 2, 3:53 AM · Restricted Project, Restricted Project
simon_tatham committed rG1a8cbfa514ff: [ARM,MVE] Add ACLE intrinsics for VCVT[ANPM] family. (authored by simon_tatham).
[ARM,MVE] Add ACLE intrinsics for VCVT[ANPM] family.
Mon, Mar 2, 2:35 AM
simon_tatham closed D75255: [ARM,MVE] Add ACLE intrinsics for VCVT[ANPM] family..
Mon, Mar 2, 2:35 AM · Restricted Project, Restricted Project
simon_tatham committed rGb08d2ddd69b4: [ARM,MVE] Add ACLE intrinsics for VCVT.F32.F16 family. (authored by simon_tatham).
[ARM,MVE] Add ACLE intrinsics for VCVT.F32.F16 family.
Mon, Mar 2, 2:35 AM
simon_tatham closed D75254: [ARM,MVE] Add ACLE intrinsics for VCVT.F32.F16 family..
Mon, Mar 2, 2:35 AM · Restricted Project, Restricted Project
simon_tatham committed rG69441e53c9f4: [ARM,MVE] Correct MC operands in VCVT.F32.F16. (NFC) (authored by simon_tatham).
[ARM,MVE] Correct MC operands in VCVT.F32.F16. (NFC)
Mon, Mar 2, 2:35 AM
simon_tatham closed D75253: [ARM,MVE] Correct MC operands in VCVT.F32.F16. (NFC).
Mon, Mar 2, 2:34 AM · Restricted Project
simon_tatham committed rGa41ecf0eb051: [ARM,MVE] Add ACLE intrinsics for VQMOV[U]N family. (authored by simon_tatham).
[ARM,MVE] Add ACLE intrinsics for VQMOV[U]N family.
Mon, Mar 2, 2:34 AM
simon_tatham closed D75252: [ARM,MVE] Add ACLE intrinsics for VQMOV[U]N family..
Mon, Mar 2, 2:34 AM · Restricted Project, Restricted Project

Feb 27 2020

simon_tatham committed rG8c26f42fe90e: [clang,ARM,MVE] Remove redundant #includes in test file. (authored by simon_tatham).
[clang,ARM,MVE] Remove redundant #includes in test file.
Feb 27 2020, 9:47 AM
simon_tatham added a child revision for D75253: [ARM,MVE] Correct MC operands in VCVT.F32.F16. (NFC): D75254: [ARM,MVE] Add ACLE intrinsics for VCVT.F32.F16 family..
Feb 27 2020, 6:59 AM · Restricted Project
simon_tatham added a parent revision for D75254: [ARM,MVE] Add ACLE intrinsics for VCVT.F32.F16 family.: D75253: [ARM,MVE] Correct MC operands in VCVT.F32.F16. (NFC).
Feb 27 2020, 6:59 AM · Restricted Project, Restricted Project
simon_tatham created D75255: [ARM,MVE] Add ACLE intrinsics for VCVT[ANPM] family..
Feb 27 2020, 6:58 AM · Restricted Project, Restricted Project
simon_tatham created D75254: [ARM,MVE] Add ACLE intrinsics for VCVT.F32.F16 family..
Feb 27 2020, 6:57 AM · Restricted Project, Restricted Project
simon_tatham created D75253: [ARM,MVE] Correct MC operands in VCVT.F32.F16. (NFC).
Feb 27 2020, 6:57 AM · Restricted Project
simon_tatham created D75252: [ARM,MVE] Add ACLE intrinsics for VQMOV[U]N family..
Feb 27 2020, 6:56 AM · Restricted Project, Restricted Project

Feb 26 2020

simon_tatham committed rG9eb3cc10b2c6: [ARM,MVE] Add predicated intrinsics for many unary functions. (authored by simon_tatham).
[ARM,MVE] Add predicated intrinsics for many unary functions.
Feb 26 2020, 7:15 AM
simon_tatham closed D75165: [ARM,MVE] Add predicated intrinsics for many unary functions..
Feb 26 2020, 7:14 AM · Restricted Project, Restricted Project
simon_tatham accepted D75115: [ARM] MVE VMLAS.
Feb 26 2020, 6:33 AM · Restricted Project
simon_tatham created D75165: [ARM,MVE] Add predicated intrinsics for many unary functions..
Feb 26 2020, 4:25 AM · Restricted Project, Restricted Project

Feb 24 2020

simon_tatham accepted D75038: [ARM,MVE] Remove 64-bit variants of vbrsrq* intrinsics.

... and we weren't testing the accidental 64-bit builtins (or else we'd have spotted the problem!), so no tests need to be changed. LGTM.

Feb 24 2020, 3:59 AM · Restricted Project

Feb 19 2020

simon_tatham accepted D74803: TableGen: Fix logic for default operands.

I get incorrect type inference failures in D74832 without this patch since it ends up trying to merge the type of a non-default operand in with a default

Feb 19 2020, 8:42 AM · Restricted Project
simon_tatham added a comment to D74803: TableGen: Fix logic for default operands.

I might as well admit my ignorance up front: despite having been the last person to touch this code, I don't really understand what the distinction is between a CodeGenInstruction and a DAGInstruction here, apart from the fact that one of them has an operand list that includes the outputs as well as the inputs.

Feb 19 2020, 7:55 AM · Restricted Project

Feb 18 2020

simon_tatham accepted D74721: [ARM,MVE] Add vbrsrq intrinsics family.
Feb 18 2020, 9:02 AM · Restricted Project, Restricted Project
simon_tatham committed rGc32af4447f79: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family. (authored by simon_tatham).
[ARM,MVE] Add the vmovnbq,vmovntq intrinsic family.
Feb 18 2020, 1:38 AM
simon_tatham committed rG5e97940cd279: [ARM,MVE] Add the vmovlbq,vmovltq intrinsic family. (authored by simon_tatham).
[ARM,MVE] Add the vmovlbq,vmovltq intrinsic family.
Feb 18 2020, 1:38 AM
simon_tatham committed rG9dcc1667abfc: [ARM] Allow `ARMVectorRegCast` to match bitconverts too. (NFC) (authored by simon_tatham).
[ARM] Allow `ARMVectorRegCast` to match bitconverts too. (NFC)
Feb 18 2020, 1:37 AM
simon_tatham closed D74337: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family..
Feb 18 2020, 1:37 AM · Restricted Project, Restricted Project
simon_tatham closed D74336: [ARM,MVE] Add the vmovlbq,vmovltq intrinsic family..
Feb 18 2020, 1:37 AM · Restricted Project, Restricted Project
simon_tatham committed rGb6236e94799e: [ARM,MVE] Add the vrev16q, vrev32q, vrev64q family. (authored by simon_tatham).
[ARM,MVE] Add the vrev16q, vrev32q, vrev64q family.
Feb 18 2020, 1:37 AM
simon_tatham committed rG68b49f7ef49e: [ARM,MVE] Add intrinsics vclzq and vclsq. (authored by simon_tatham).
[ARM,MVE] Add intrinsics vclzq and vclsq.
Feb 18 2020, 1:37 AM
simon_tatham closed D74716: [ARM] Allow `ARMVectorRegCast` to match bitconverts too. (NFC).
Feb 18 2020, 1:37 AM · Restricted Project
simon_tatham committed rGc8b3196e5430: [ARM,MVE] Add intrinsics for FP rounding operations. (authored by simon_tatham).
[ARM,MVE] Add intrinsics for FP rounding operations.
Feb 18 2020, 1:37 AM
simon_tatham closed D74335: [ARM,MVE] Add intrinsics vclzq and vclsq..
Feb 18 2020, 1:37 AM · Restricted Project, Restricted Project
simon_tatham closed D74334: [ARM,MVE] Add the vrev16q, vrev32q, vrev64q family..
Feb 18 2020, 1:37 AM · Restricted Project
simon_tatham committed rGdf3ed6c0fe31: [ARM,MVE] Add intrinsics for int <-> float conversion. (authored by simon_tatham).
[ARM,MVE] Add intrinsics for int <-> float conversion.
Feb 18 2020, 1:37 AM
simon_tatham committed rG90dc78bc6278: [ARM,MVE] Add intrinsics for abs, neg and not operations. (authored by simon_tatham).
[ARM,MVE] Add intrinsics for abs, neg and not operations.
Feb 18 2020, 1:37 AM
simon_tatham closed D74333: [ARM,MVE] Add intrinsics for FP rounding operations..
Feb 18 2020, 1:37 AM · Restricted Project, Restricted Project
simon_tatham closed D74332: [ARM,MVE] Add intrinsics for int <-> float conversion..
Feb 18 2020, 1:37 AM · Restricted Project
simon_tatham closed D74331: [ARM,MVE] Add intrinsics for abs, neg and not operations..
Feb 18 2020, 1:37 AM · Restricted Project

Feb 17 2020

simon_tatham updated the diff for D74337: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family..

Test on the clang side in both endiannesses.

Feb 17 2020, 8:37 AM · Restricted Project, Restricted Project