Page MenuHomePhabricator

simon_tatham (Simon Tatham)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2017, 1:23 AM (93 w, 16 h)

Recent Activity

Wed, Apr 17

simon_tatham added inline comments to D60694: [ARM] Introduce separate features for FP registers..
Wed, Apr 17, 9:01 AM · Restricted Project

Tue, Apr 16

simon_tatham added a comment to D60708: [ARM] Code-generation infrastructure for MVE..

This infrastructure should be enough to let you use the vector types in C as a means of getting them to and from __asm__ blocks that do the real work. I suppose that means I should include some tests that exercise exactly that, using asm operations in IR.

Tue, Apr 16, 8:45 AM · Restricted Project
simon_tatham added a comment to D60704: [ARM] Disallow SP and PC in VMOVRH and VMOVHR..

It's tested for v8.1-M, by llvm/test/MC/ARM/thumbv8.1m.s which is added by D60706. I could add an extra test or two to this patch for other affected architectures, if you think it's necessary.

Tue, Apr 16, 3:17 AM · Restricted Project
simon_tatham added a comment to D60697: [ARM] Allow "-march=foo+fp" to vary with foo..

The aim of this change is that it will apply to the v8.1-M (mainline) architecture introduced in D60698, in which +fp won't be the default: -march=armv8.1m.main by itself gives you the base 8.1-M architecture without any FP, -march=armv8.1m.main+fp gives you the optional single-precision FP extension on top of that, and +fp.dp gives you double precision as well.

Tue, Apr 16, 2:56 AM · Restricted Project, Restricted Project
simon_tatham added inline comments to D60701: [ARM] add new LLVM addressing modes for v8.1-M and MVE..
Tue, Apr 16, 1:59 AM · Restricted Project

Mon, Apr 15

simon_tatham added a comment to D60700: [ARM] Change the MC names for VMAXNM/VMINNM..

It's true that during internal development we implemented this rename before the later change that adds some UnsupportedFeatures to the same schedule model which should rule out the MVE VMAXNM/VMINNM instructions in any case.

Mon, Apr 15, 8:45 AM · Restricted Project
simon_tatham added a comment to D60709: [ARM] Support inline assembler constraints for MVE..

Yes, it is.

Mon, Apr 15, 7:33 AM · Restricted Project, Restricted Project
simon_tatham added a parent revision for D60710: [ARM] Add ACLE feature macros for MVE.: D60709: [ARM] Support inline assembler constraints for MVE..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a child revision for D60709: [ARM] Support inline assembler constraints for MVE.: D60710: [ARM] Add ACLE feature macros for MVE..
Mon, Apr 15, 6:18 AM · Restricted Project, Restricted Project
simon_tatham added a child revision for D60708: [ARM] Code-generation infrastructure for MVE.: D60709: [ARM] Support inline assembler constraints for MVE..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a parent revision for D60709: [ARM] Support inline assembler constraints for MVE.: D60708: [ARM] Code-generation infrastructure for MVE..
Mon, Apr 15, 6:18 AM · Restricted Project, Restricted Project
simon_tatham added a parent revision for D60707: [ARM] Adjust calling conventions for MVE vectors.: D60706: [ARM] implement 8.1-M instructions at the MC level..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a parent revision for D60708: [ARM] Code-generation infrastructure for MVE.: D60707: [ARM] Adjust calling conventions for MVE vectors..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a child revision for D60706: [ARM] implement 8.1-M instructions at the MC level.: D60707: [ARM] Adjust calling conventions for MVE vectors..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a child revision for D60707: [ARM] Adjust calling conventions for MVE vectors.: D60708: [ARM] Code-generation infrastructure for MVE..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a parent revision for D60706: [ARM] implement 8.1-M instructions at the MC level.: D60705: [ARM] Turn some undefined encoding bits into mandatory 1s..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a child revision for D60705: [ARM] Turn some undefined encoding bits into mandatory 1s.: D60706: [ARM] implement 8.1-M instructions at the MC level..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham removed a parent revision for D60702: [ARM] Add fixup types for BF and LOL.: D60700: [ARM] Change the MC names for VMAXNM/VMINNM..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a child revision for D60702: [ARM] Add fixup types for BF and LOL.: D60703: [ARM] Add an MVE execution domain..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a parent revision for D60704: [ARM] Disallow SP and PC in VMOVRH and VMOVHR.: D60703: [ARM] Add an MVE execution domain..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a parent revision for D60705: [ARM] Turn some undefined encoding bits into mandatory 1s.: D60704: [ARM] Disallow SP and PC in VMOVRH and VMOVHR..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a parent revision for D60702: [ARM] Add fixup types for BF and LOL.: D60701: [ARM] add new LLVM addressing modes for v8.1-M and MVE..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a child revision for D60701: [ARM] add new LLVM addressing modes for v8.1-M and MVE.: D60702: [ARM] Add fixup types for BF and LOL..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a parent revision for D60703: [ARM] Add an MVE execution domain.: D60702: [ARM] Add fixup types for BF and LOL..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a child revision for D60704: [ARM] Disallow SP and PC in VMOVRH and VMOVHR.: D60705: [ARM] Turn some undefined encoding bits into mandatory 1s..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a child revision for D60703: [ARM] Add an MVE execution domain.: D60704: [ARM] Disallow SP and PC in VMOVRH and VMOVHR..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham removed a child revision for D60700: [ARM] Change the MC names for VMAXNM/VMINNM.: D60702: [ARM] Add fixup types for BF and LOL..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a child revision for D60700: [ARM] Change the MC names for VMAXNM/VMINNM.: D60702: [ARM] Add fixup types for BF and LOL..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a parent revision for D60702: [ARM] Add fixup types for BF and LOL.: D60700: [ARM] Change the MC names for VMAXNM/VMINNM..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a child revision for D60700: [ARM] Change the MC names for VMAXNM/VMINNM.: D60701: [ARM] add new LLVM addressing modes for v8.1-M and MVE..
Mon, Apr 15, 6:18 AM · Restricted Project
simon_tatham added a child revision for D60698: [ARM] add target arch definitions for 8.1-M and MVE.: D60699: [ARM] add CLI support for 8.1-M and MVE..
Mon, Apr 15, 6:17 AM · Restricted Project
simon_tatham added a parent revision for D60701: [ARM] add new LLVM addressing modes for v8.1-M and MVE.: D60700: [ARM] Change the MC names for VMAXNM/VMINNM..
Mon, Apr 15, 6:17 AM · Restricted Project
simon_tatham added a parent revision for D60700: [ARM] Change the MC names for VMAXNM/VMINNM.: D60699: [ARM] add CLI support for 8.1-M and MVE..
Mon, Apr 15, 6:17 AM · Restricted Project
simon_tatham added a child revision for D60699: [ARM] add CLI support for 8.1-M and MVE.: D60700: [ARM] Change the MC names for VMAXNM/VMINNM..
Mon, Apr 15, 6:17 AM · Restricted Project
simon_tatham added a parent revision for D60699: [ARM] add CLI support for 8.1-M and MVE.: D60698: [ARM] add target arch definitions for 8.1-M and MVE..
Mon, Apr 15, 6:17 AM · Restricted Project
simon_tatham added a child revision for D60697: [ARM] Allow "-march=foo+fp" to vary with foo.: D60698: [ARM] add target arch definitions for 8.1-M and MVE..
Mon, Apr 15, 6:10 AM · Restricted Project, Restricted Project
simon_tatham added a parent revision for D60698: [ARM] add target arch definitions for 8.1-M and MVE.: D60697: [ARM] Allow "-march=foo+fp" to vary with foo..
Mon, Apr 15, 6:10 AM · Restricted Project
simon_tatham added a child revision for D60696: [TableGen] New default operand "undef_tied_input".: D60697: [ARM] Allow "-march=foo+fp" to vary with foo..
Mon, Apr 15, 6:10 AM · Restricted Project
simon_tatham added a parent revision for D60696: [TableGen] New default operand "undef_tied_input".: D60695: [TableGen] AsmMatcher: allow repeated input operands..
Mon, Apr 15, 6:10 AM · Restricted Project
simon_tatham added a parent revision for D60697: [ARM] Allow "-march=foo+fp" to vary with foo.: D60696: [TableGen] New default operand "undef_tied_input"..
Mon, Apr 15, 6:10 AM · Restricted Project, Restricted Project
simon_tatham added a child revision for D60695: [TableGen] AsmMatcher: allow repeated input operands.: D60696: [TableGen] New default operand "undef_tied_input"..
Mon, Apr 15, 6:10 AM · Restricted Project
simon_tatham added a child revision for D60694: [ARM] Introduce separate features for FP registers.: D60695: [TableGen] AsmMatcher: allow repeated input operands..
Mon, Apr 15, 6:10 AM · Restricted Project
simon_tatham added a parent revision for D60695: [TableGen] AsmMatcher: allow repeated input operands.: D60694: [ARM] Introduce separate features for FP registers..
Mon, Apr 15, 6:10 AM · Restricted Project
simon_tatham added a child revision for D60693: [ARM] Split predicates out into their own .td file.: D60694: [ARM] Introduce separate features for FP registers..
Mon, Apr 15, 6:09 AM · Restricted Project
simon_tatham added a parent revision for D60694: [ARM] Introduce separate features for FP registers.: D60693: [ARM] Split predicates out into their own .td file..
Mon, Apr 15, 6:09 AM · Restricted Project
simon_tatham added a parent revision for D60693: [ARM] Split predicates out into their own .td file.: D60692: [ARM] Explicit lowering of half <-> double conversions..
Mon, Apr 15, 6:09 AM · Restricted Project
simon_tatham added a child revision for D60691: [ARM] Replace fp-only-sp and d16 with fp64 and d32.: D60692: [ARM] Explicit lowering of half <-> double conversions..
Mon, Apr 15, 6:09 AM · Restricted Project, Restricted Project
simon_tatham added a child revision for D60692: [ARM] Explicit lowering of half <-> double conversions.: D60693: [ARM] Split predicates out into their own .td file..
Mon, Apr 15, 6:09 AM · Restricted Project
simon_tatham added a parent revision for D60692: [ARM] Explicit lowering of half <-> double conversions.: D60691: [ARM] Replace fp-only-sp and d16 with fp64 and d32..
Mon, Apr 15, 6:09 AM · Restricted Project
simon_tatham created D60710: [ARM] Add ACLE feature macros for MVE..
Mon, Apr 15, 6:01 AM · Restricted Project
simon_tatham created D60709: [ARM] Support inline assembler constraints for MVE..
Mon, Apr 15, 6:01 AM · Restricted Project, Restricted Project
simon_tatham created D60708: [ARM] Code-generation infrastructure for MVE..
Mon, Apr 15, 6:00 AM · Restricted Project
simon_tatham created D60707: [ARM] Adjust calling conventions for MVE vectors..
Mon, Apr 15, 6:00 AM · Restricted Project
simon_tatham created D60706: [ARM] implement 8.1-M instructions at the MC level..
Mon, Apr 15, 6:00 AM · Restricted Project
simon_tatham created D60705: [ARM] Turn some undefined encoding bits into mandatory 1s..
Mon, Apr 15, 5:59 AM · Restricted Project
simon_tatham created D60704: [ARM] Disallow SP and PC in VMOVRH and VMOVHR..
Mon, Apr 15, 5:59 AM · Restricted Project
simon_tatham created D60703: [ARM] Add an MVE execution domain..
Mon, Apr 15, 5:59 AM · Restricted Project
simon_tatham created D60702: [ARM] Add fixup types for BF and LOL..
Mon, Apr 15, 5:59 AM · Restricted Project
simon_tatham created D60701: [ARM] add new LLVM addressing modes for v8.1-M and MVE..
Mon, Apr 15, 5:58 AM · Restricted Project
simon_tatham created D60700: [ARM] Change the MC names for VMAXNM/VMINNM..
Mon, Apr 15, 5:58 AM · Restricted Project
simon_tatham created D60699: [ARM] add CLI support for 8.1-M and MVE..
Mon, Apr 15, 5:58 AM · Restricted Project
simon_tatham created D60698: [ARM] add target arch definitions for 8.1-M and MVE..
Mon, Apr 15, 5:57 AM · Restricted Project
simon_tatham created D60697: [ARM] Allow "-march=foo+fp" to vary with foo..
Mon, Apr 15, 5:57 AM · Restricted Project, Restricted Project
simon_tatham created D60696: [TableGen] New default operand "undef_tied_input"..
Mon, Apr 15, 5:57 AM · Restricted Project
simon_tatham created D60695: [TableGen] AsmMatcher: allow repeated input operands..
Mon, Apr 15, 5:57 AM · Restricted Project
simon_tatham created D60694: [ARM] Introduce separate features for FP registers..
Mon, Apr 15, 5:57 AM · Restricted Project
simon_tatham created D60693: [ARM] Split predicates out into their own .td file..
Mon, Apr 15, 5:57 AM · Restricted Project
simon_tatham created D60691: [ARM] Replace fp-only-sp and d16 with fp64 and d32..
Mon, Apr 15, 5:57 AM · Restricted Project, Restricted Project
simon_tatham created D60692: [ARM] Explicit lowering of half <-> double conversions..
Mon, Apr 15, 5:57 AM · Restricted Project
simon_tatham committed rG301ed1cb49ab: [TableGen] Include schedule model name in diagnostic. (authored by simon_tatham).
[TableGen] Include schedule model name in diagnostic.
Mon, Apr 15, 3:06 AM
simon_tatham closed D60559: [TableGen] Include schedule model name in diagnostic..
Mon, Apr 15, 3:06 AM · Restricted Project

Fri, Apr 12

simon_tatham updated the diff for D60559: [TableGen] Include schedule model name in diagnostic..

Adjusted message wording as suggested.

Fri, Apr 12, 3:10 AM · Restricted Project

Thu, Apr 11

simon_tatham created D60559: [TableGen] Include schedule model name in diagnostic..
Thu, Apr 11, 3:32 AM · Restricted Project

Mar 12 2019

simon_tatham committed rGcdb7c31f0ada: [TableGen] Allow 2^63-1 and 2^63-2 as int literals. (authored by simon_tatham).
[TableGen] Allow 2^63-1 and 2^63-2 as int literals.
Mar 12 2019, 2:29 AM

Mar 11 2019

simon_tatham updated the diff for D59016: [TableGen] Allow 2^63-1 and 2^63-2 as int literals..

Simpler version that just replaces DenseMap with std::map.

Mar 11 2019, 2:55 AM · Restricted Project
simon_tatham added a comment to D59016: [TableGen] Allow 2^63-1 and 2^63-2 as int literals..

I'm happy to do that if you prefer – I left the DenseMap in place on the Chesterton's Fence principle. (I didn't know why it was originally chosen over std::map, so hesitated to unilaterally reverse the decision.)

Mar 11 2019, 2:23 AM · Restricted Project

Mar 6 2019

simon_tatham created D59016: [TableGen] Allow 2^63-1 and 2^63-2 as int literals..
Mar 6 2019, 2:31 AM · Restricted Project

Feb 25 2019

simon_tatham committed rGb70fc0c5fdbb: [ARM] Make fullfp16 instructions not conditionalisable. (authored by simon_tatham).
[ARM] Make fullfp16 instructions not conditionalisable.
Feb 25 2019, 2:40 AM

Feb 22 2019

simon_tatham updated the diff for D57823: [ARM] Make fullfp16 instructions not conditionalisable..

I'm not as familiar with the NEON FP16 instructions, but in a quick
look I didn't see a corresponding issue with predicating them – e.g.
the vector vadd.f32 and vadd.f16 are just as predicable as each
other, unlike the scalar ones.

Feb 22 2019, 9:10 AM · Restricted Project

Feb 21 2019

simon_tatham added a comment to D57823: [ARM] Make fullfp16 instructions not conditionalisable..

Could I ping this, please? I've added the assembler check @efriedma asked about; is there anything else I need to change?

Feb 21 2019, 5:57 AM · Restricted Project

Feb 8 2019

simon_tatham updated the diff for D57823: [ARM] Make fullfp16 instructions not conditionalisable..

Added an error check in ARMAsmParser and a test that exercises it.

Feb 8 2019, 8:06 AM · Restricted Project

Feb 7 2019

simon_tatham added a comment to D57823: [ARM] Make fullfp16 instructions not conditionalisable..

Good question. Testing it with llvm-mc, what seems to happen (with this patch applied) is that if I write one of these instructions after an explicit it instruction then I get "error: instructions in IT block must be predicable", but if there's no preceding IT then it's accepted without complaint.

Feb 7 2019, 2:33 AM · Restricted Project

Feb 6 2019

simon_tatham created D57823: [ARM] Make fullfp16 instructions not conditionalisable..
Feb 6 2019, 8:47 AM · Restricted Project

Jan 17 2019

simon_tatham added inline comments to D55758: [TableGen] : Extend !if semantics through new language feature !ifs.
Jan 17 2019, 9:31 AM

Jan 8 2019

simon_tatham added inline comments to D55758: [TableGen] : Extend !if semantics through new language feature !ifs.
Jan 8 2019, 4:28 AM

Jan 7 2019

simon_tatham added inline comments to D55758: [TableGen] : Extend !if semantics through new language feature !ifs.
Jan 7 2019, 1:27 AM

Dec 14 2018

simon_tatham added a comment to D53816: [TableGen:AsmWriter] Cope with consecutive tied operands..

Could I give this a gentle ping, please?

Dec 14 2018, 3:20 AM

Nov 28 2018

simon_tatham added a comment to D53815: [TableGen] Better error checking for TIED_TO constraints..

I've just come back to this patch after being distracted for several weeks (sorry about that). I intend to actually commit it shortly, and this time I'll try not to forget :-)

Nov 28 2018, 1:55 AM

Nov 1 2018

simon_tatham updated the diff for D53815: [TableGen] Better error checking for TIED_TO constraints..

Name is rewritten between creation of LHSOp and RHSOp, so you
can't just make both of them into StringRefs because LHSOp would be
invalidated by the change to Name.

Nov 1 2018, 4:33 AM

Oct 31 2018

simon_tatham added inline comments to D53931: TableGen: Fix ASAN error.
Oct 31 2018, 10:20 AM
simon_tatham updated the diff for D53815: [TableGen] Better error checking for TIED_TO constraints..

OK, here's a second draft which names the variables more sensibly. Perhaps slight overkill, in that I've used LHSOp and RHSOp for the variables ordered as they are in the source constraints string, and then DestOp and SrcOp once they're reordered to (what should be) a def and a use.

Oct 31 2018, 8:20 AM
simon_tatham added inline comments to D53815: [TableGen] Better error checking for TIED_TO constraints..
Oct 31 2018, 4:54 AM

Oct 30 2018

simon_tatham added a comment to D53816: [TableGen:AsmWriter] Cope with consecutive tied operands..

Can you add some tests for the affected instructions?

Oct 30 2018, 4:34 AM

Oct 29 2018

simon_tatham created D53816: [TableGen:AsmWriter] Cope with consecutive tied operands..
Oct 29 2018, 7:12 AM
simon_tatham created D53815: [TableGen] Better error checking for TIED_TO constraints..
Oct 29 2018, 7:09 AM

Aug 15 2018

simon_tatham created D50771: [clang-tblgen] Add -print-records and -dump-json modes..
Aug 15 2018, 5:28 AM

Jul 13 2018

simon_tatham accepted D49258: [json, test] Fix the json.td test - the path to python could contain spaces.

LGTM. (But I learned something new when I dug into lit to find out why you could get away with using single quotes – I would have expected that only double quotes would work on Windows!)

Jul 13 2018, 1:16 AM

Jul 12 2018

simon_tatham added a comment to D46054: [TableGen] Add a general-purpose JSON backend..

Oops, sorry about that :-(

Jul 12 2018, 9:43 AM

Jul 11 2018

simon_tatham added a comment to D46054: [TableGen] Add a general-purpose JSON backend..

Actually, on second thoughts, I'm going to assume it was overcautious to ask for a re-approval, since this version of the patch introduces no new controversy and in fact removes the only previous tweak in the Tablegen core (in that I'm not trying to change the semantics of anonymous any more). So I'll commit this as is, based on the previous review approval.

Jul 11 2018, 1:44 AM

Jul 10 2018

simon_tatham updated the diff for D46054: [TableGen] Add a general-purpose JSON backend..

Nearly forgot to mention the new option in the tblgen man page!

Jul 10 2018, 12:59 AM