Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

[pmatos]

Summary

Adds overload of ransformToPotentiallyEvaluated for TypeSourceInfo to properly deal with VLAs in nested calls of sizeof and typeof. Fixes #31042.

[pmatos]

@efriedma Here's the new patch, thanks for your help getting here.

[ahatanak]

Can you add a test case?

[efriedma]

Missing regression test in test/SemaCXX/.

[pmatos]

Apologies for the delay over the holiday season, I will look into this later on after office hours.

[pmatos]

Has this been fixed upstream already?

[pmatos]

Ah no, my mistake. I had the patch applied when I ran the test.

[pmatos]

Here's an updated patch including the test. Hope this is now ok for submission. Please accept my apologies with regards to the delay in submitting this.

[efriedma]

lib/Sema/SemaExpr.cpp

4027

Is the isUnevaluatedContext() check here necessary?

test/SemaCXX/pr31042.cpp

2

-emit-obj ?

4

Is this declaration necessary somehow?

[pmatos]

Thanks for the comments.

[pmatos]

lib/Sema/SemaExpr.cpp

4027

Not really. Reran tests to ensure removing it doesn't break anything.

test/SemaCXX/pr31042.cpp

2

Not needed. Left over from copying another test.

4

Same. Not needed. Left over from copying another test.

[pmatos]

@efriedma I have uploaded a new patch taking your comments into consideration and rebased on most recent clang sources.

[pmatos]

Added missing testcase to previous patch.

[efriedma]

test/SemaCXX/pr31042.cpp

2

Oh, this testcase doesn't actually crash on trunk without at least -emit-llvm because semantic analysis doesn't actually verify the used bit. :( Better to include that, I think.

[efriedma]

test/SemaCXX/pr31042.cpp

1

You need to use "-o -" or something like that to avoid generating a file pr31042.ll. Also, a comment explaining why this test is using -emit-llvm would be nice.