- User Since
- Aug 12 2019, 6:38 AM (216 w, 5 h)
Sep 21 2021
Sep 20 2021
Just a little thing I saw while reading code -- if no response in a couple weeks I will just abandon the rev
Aug 24 2021
@Anastasia is this good to go for you or does this need closer attention?
Thanks again John & Thomas for your thoughts.
Aug 23 2021
Closing PR as it turns out that I don't need the Address() change for my work; no need to churn here.
Rebase to no longer require Address default constructor.
Thanks for feedback! Following up on general question in D108464.
Aug 20 2021
Sooooo... besides the refactor, this is getting closer to where I'm going in https://lists.llvm.org/pipermail/cfe-dev/2021-July/068559.html, though still NFC. I think you can see where I would replace getASTAllocaAddressSpace with getAllocaAddressSpace(QualType Ty), and possibly (depending on the source language) avoid casting the resulting alloca to LangAS::Default. WDYT, is this sort of thing OK?
I tested by building with all targets enabled and there was no change in test results, running clang, llvm, and lld tests.
Just a drive-by cleanup while poking other address-space-related things.
Aug 19 2021
Hi John, I am new to clang, having mostly worked on the WebAssembly target in llvm proper. I have a stack of patches related to address space treatment in codegen -- most of them NFC refactors to later allow the WebAssembly target to alloca in different address spaces. See https://lists.llvm.org/pipermail/cfe-dev/2021-July/068559.html for broader context. Would it be OK if I sent them your way? Cheers, Andy.
Hi Richard, I am new to clang, having mostly worked on the WebAssembly target in llvm proper -- I have a stack of patches, of which a couple later ones touch Sema/. See https://lists.llvm.org/pipermail/cfe-dev/2021-July/068559.html for broader context. However I had a couple small NFC cleanups I found when reading code, like this one; would it be OK if I sent them your way? Cheers, Andy.
Jul 28 2021
Neat :) LGTM as well of course.
Jul 19 2021
Jul 16 2021
Tighten up tests
Thanks all for the feedback! I think the updated patch addresses the feedback; PTAL :)
Use STT_NOTYPE for synthesized symbols
Add wasm symbols for any function without a symbol
Rebase; will fix spurious presubmit errors
Jul 7 2021
Jun 1 2021
May 31 2021
Quick r? to @tlively -- OK with having the new util function in WebAssemblyFrameLowering? It didn't work to have it in the utils library because the function needs the vtable of WebAssemblyFunctionInfo.
Fix shared-library build by moving util function to WebAssemblyFrameLowering.
Yarrrgh, broke the shared library build. Fix incoming...
May 28 2021
Fix build for RISC-V and AMDGPU.
Adapt test to insert compiler barrier.
May 26 2021
Gentle ping here to @tlively :)
May 21 2021
May 20 2021
Remove AMDGPU test that alloca in wrong addrspace fails to verify
May 19 2021
Tweak alloca langref language
May 18 2021
Fix drop-debug-info-nonzero-alloca test
Go back to first version of patch, removing verifier restriction on alloca address spaces
May 17 2021
May 11 2021
Rename "managed" address space to "wasm var".
Update in response to parent commit changes
Rename "managed" address space to "wasm vars"
Fix spurious whitespace
Address feedback from tlively
May 10 2021
May 6 2021
Rename "object" to "managed", and address feedback
Rename "object" to "managed", and add test for stack id
yarr, shiver me timbers, fix me typos
Rename "object" address space to "managed"; address feedback.