ahatanak (Akira Hatanaka)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 4 2013, 1:37 PM (254 w, 1 d)

Recent Activity

Thu, Oct 11

ahatanak added a comment to D53154: [CodeGen] Handle extern references to OBJC_CLASS_$_*.

LGTM

Thu, Oct 11, 11:24 PM

Mon, Oct 1

ahatanak committed rC343556: [CodeGen] Before entering the loop that copies a non-trivial array field.
[CodeGen] Before entering the loop that copies a non-trivial array field
Mon, Oct 1, 6:02 PM
ahatanak committed rL343556: [CodeGen] Before entering the loop that copies a non-trivial array field.
[CodeGen] Before entering the loop that copies a non-trivial array field
Mon, Oct 1, 6:02 PM
ahatanak committed rL343542: Distinguish `__block` variables that are captured by escaping blocks.
Distinguish `__block` variables that are captured by escaping blocks
Mon, Oct 1, 2:54 PM
ahatanak committed rC343542: Distinguish `__block` variables that are captured by escaping blocks.
Distinguish `__block` variables that are captured by escaping blocks
Mon, Oct 1, 2:54 PM
ahatanak committed rL343531: Revert r343518..
Revert r343518.
Mon, Oct 1, 1:31 PM
ahatanak committed rC343531: Revert r343518..
Revert r343518.
Mon, Oct 1, 1:31 PM
ahatanak committed rL343518: Distinguish `__block` variables that are captured by escaping blocks.
Distinguish `__block` variables that are captured by escaping blocks
Mon, Oct 1, 11:52 AM
ahatanak committed rC343518: Distinguish `__block` variables that are captured by escaping blocks.
Distinguish `__block` variables that are captured by escaping blocks
Mon, Oct 1, 11:52 AM

Sep 8 2018

ahatanak committed rL341757: Revert r341754..
Revert r341754.
Sep 8 2018, 10:24 PM
ahatanak committed rC341757: Revert r341754..
Revert r341754.
Sep 8 2018, 10:24 PM
ahatanak committed rC341754: Distinguish `__block` variables that are captured by escaping blocks.
Distinguish `__block` variables that are captured by escaping blocks
Sep 8 2018, 1:06 PM
ahatanak committed rL341754: Distinguish `__block` variables that are captured by escaping blocks.
Distinguish `__block` variables that are captured by escaping blocks
Sep 8 2018, 1:06 PM
ahatanak closed D51564: Distinguish `__block` variables that are captured by escaping blocks from those that aren't.
Sep 8 2018, 1:06 PM

Sep 6 2018

ahatanak committed rL341629: [Sema] Check that the destructor for each element of class type is.
[Sema] Check that the destructor for each element of class type is
Sep 6 2018, 7:39 PM
ahatanak committed rC341629: [Sema] Check that the destructor for each element of class type is.
[Sema] Check that the destructor for each element of class type is
Sep 6 2018, 7:39 PM
ahatanak closed D45898: [SemaCXX] Mark destructor as referenced .
Sep 6 2018, 7:39 PM

Sep 5 2018

ahatanak added inline comments to D51564: Distinguish `__block` variables that are captured by escaping blocks from those that aren't.
Sep 5 2018, 10:32 AM
ahatanak updated the diff for D51564: Distinguish `__block` variables that are captured by escaping blocks from those that aren't.

Address review comments. Fix bugs in the handling of __block variables that have reference types.

Sep 5 2018, 10:32 AM

Sep 4 2018

ahatanak added inline comments to D45898: [SemaCXX] Mark destructor as referenced .
Sep 4 2018, 11:07 AM
ahatanak updated the diff for D45898: [SemaCXX] Mark destructor as referenced .

Point the diagnostic at either the relevant init list element or at the close brace.

Sep 4 2018, 11:07 AM

Aug 31 2018

ahatanak created D51564: Distinguish `__block` variables that are captured by escaping blocks from those that aren't.
Aug 31 2018, 6:11 PM
ahatanak updated the diff for D45898: [SemaCXX] Mark destructor as referenced .

Move the call that checks the element's destructor into InitListChecker::CheckStructUnionTypes.

Aug 31 2018, 5:36 PM
ahatanak added a comment to D50783: [CodeGen] Merge identical block descriptor global variables.

The GNUstep documentation I found replaces '@' with '\1'. Would that fix the problem?

Aug 31 2018, 11:36 AM

Aug 30 2018

ahatanak added a comment to D45898: [SemaCXX] Mark destructor as referenced .

ping

Aug 30 2018, 6:45 PM

Aug 28 2018

ahatanak committed rC340854: Define variables in test case rather than using values from functions.
Define variables in test case rather than using values from functions
Aug 28 2018, 11:19 AM
ahatanak committed rL340854: Define variables in test case rather than using values from functions.
Define variables in test case rather than using values from functions
Aug 28 2018, 11:19 AM

Aug 23 2018

ahatanak added a comment to D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called.
In D47757#1211276, @tra wrote:

I've confirmed that the patch does not break anything in our CUDA code, so it's good to go as far as CUDA is concerned.

Aug 23 2018, 4:05 PM

Aug 22 2018

ahatanak committed rC340408: [CodeGen] Look at the type of a block capture field rather than the type.
[CodeGen] Look at the type of a block capture field rather than the type
Aug 22 2018, 6:42 AM
ahatanak committed rL340408: [CodeGen] Look at the type of a block capture field rather than the type.
[CodeGen] Look at the type of a block capture field rather than the type
Aug 22 2018, 6:42 AM
ahatanak closed D51025: [CodeGen] Fix handling of variables captured by a block that is nested inside a lambda.
Aug 22 2018, 6:42 AM

Aug 21 2018

ahatanak accepted D51043: [clang][NFC] Fix typo in the name of a note.

Thanks. Yes, it's a typo.

Aug 21 2018, 8:52 AM

Aug 20 2018

ahatanak created D51025: [CodeGen] Fix handling of variables captured by a block that is nested inside a lambda.
Aug 20 2018, 11:53 PM

Aug 17 2018

ahatanak added a comment to D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called.

The code you showed does compile with or without -fcuda-is-device after applying my patch.

Aug 17 2018, 2:08 PM
ahatanak added a comment to D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called.
In D47757#1204561, @tra wrote:

It's a regression. There's a decent chance it breaks someone and this patch, if committed by itself, will end up being rolled back.

Aug 17 2018, 12:57 PM
ahatanak added a comment to D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called.

@tra and @rsmith: Can we move forward and fix the incorrect cuda diagnostics in a separate patch?

Aug 17 2018, 11:46 AM
ahatanak committed rC340041: [CodeGen] Merge identical block descriptor global variables..
[CodeGen] Merge identical block descriptor global variables.
Aug 17 2018, 8:47 AM
ahatanak committed rL340041: [CodeGen] Merge identical block descriptor global variables..
[CodeGen] Merge identical block descriptor global variables.
Aug 17 2018, 8:47 AM
ahatanak closed D50783: [CodeGen] Merge identical block descriptor global variables.
Aug 17 2018, 8:47 AM
ahatanak closed D50783: [CodeGen] Merge identical block descriptor global variables.
Aug 17 2018, 8:47 AM

Aug 16 2018

ahatanak updated the diff for D50783: [CodeGen] Merge identical block descriptor global variables.

Mark the block descriptor global variable as unnamed_addr.

Aug 16 2018, 7:36 PM
ahatanak added inline comments to D50783: [CodeGen] Merge identical block descriptor global variables.
Aug 16 2018, 4:24 PM
ahatanak updated the diff for D50783: [CodeGen] Merge identical block descriptor global variables.

Try harder to shorten the names of block descriptor global variables.

Aug 16 2018, 3:57 PM

Aug 15 2018

ahatanak added a comment to D50783: [CodeGen] Merge identical block descriptor global variables.

A few points I forgot to mention:

Aug 15 2018, 9:38 AM
ahatanak created D50783: [CodeGen] Merge identical block descriptor global variables.
Aug 15 2018, 8:23 AM

Aug 13 2018

ahatanak committed rL339633: [CodeGen] Before returning a copy/dispose helper function, bitcast it to.
[CodeGen] Before returning a copy/dispose helper function, bitcast it to
Aug 13 2018, 5:16 PM
ahatanak committed rC339633: [CodeGen] Before returning a copy/dispose helper function, bitcast it to.
[CodeGen] Before returning a copy/dispose helper function, bitcast it to
Aug 13 2018, 5:16 PM
ahatanak committed rL339632: Fix check strings in test/CodeGenObjC/arc-blocks.m in preperation for.
Fix check strings in test/CodeGenObjC/arc-blocks.m in preperation for
Aug 13 2018, 5:16 PM
ahatanak committed rC339632: Fix check strings in test/CodeGenObjC/arc-blocks.m in preperation for.
Fix check strings in test/CodeGenObjC/arc-blocks.m in preperation for
Aug 13 2018, 5:16 PM
ahatanak committed rL339613: Convert if/else to a switch. NFC..
Convert if/else to a switch. NFC.
Aug 13 2018, 2:00 PM
ahatanak committed rC339613: Convert if/else to a switch. NFC..
Convert if/else to a switch. NFC.
Aug 13 2018, 2:00 PM

Aug 10 2018

ahatanak committed rC339452: Make changes to the check strings so that the test I modified in r339438.
Make changes to the check strings so that the test I modified in r339438
Aug 10 2018, 10:08 AM
ahatanak committed rL339452: Make changes to the check strings so that the test I modified in r339438.
Make changes to the check strings so that the test I modified in r339438
Aug 10 2018, 10:07 AM
ahatanak committed rL339438: [CodeGen] Merge equivalent block copy/helper functions..
[CodeGen] Merge equivalent block copy/helper functions.
Aug 10 2018, 8:10 AM
ahatanak committed rC339438: [CodeGen] Merge equivalent block copy/helper functions..
[CodeGen] Merge equivalent block copy/helper functions.
Aug 10 2018, 8:10 AM
ahatanak closed D50152: [CodeGen] Merge equivalent block copy/helper functions.
Aug 10 2018, 8:10 AM

Aug 9 2018

ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Replace the two flags, EHOnly and DisposeCannotThrow, passed to pushCaptureCleanup with a single flag ForCopyHelper.

Aug 9 2018, 9:00 PM
ahatanak updated the diff for D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called.

Call MarkFunctionReferenced to mark the function __builtin_operator_new or __builtin_operator_delete will call as referenced.

Aug 9 2018, 7:02 PM
ahatanak added inline comments to D50152: [CodeGen] Merge equivalent block copy/helper functions.
Aug 9 2018, 5:52 PM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Define functions inline in the header file.

Aug 9 2018, 5:51 PM
ahatanak added a comment to D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called.

ping

Aug 9 2018, 10:02 AM
ahatanak added inline comments to D50152: [CodeGen] Merge equivalent block copy/helper functions.
Aug 9 2018, 7:50 AM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Address review comments.

Aug 9 2018, 7:49 AM

Aug 8 2018

ahatanak added inline comments to D50152: [CodeGen] Merge equivalent block copy/helper functions.
Aug 8 2018, 7:49 PM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Address review comments.

Aug 8 2018, 7:49 PM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Modify getBlockVarCopyInits and setBlockVarCopyInits to get and set both the copy expression and the boolean flag that indicates whether the expression can throw or not.

Aug 8 2018, 2:40 PM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Change the value type of BlockVarCopyInits to PointerIntPair<Expr *, 1, bool>. The boolean flag indicates whether the copy expression can throw. Serialize/deserialize the copy expression and the boolean flag and add a regression test to test/PCH.

Aug 8 2018, 11:33 AM

Aug 7 2018

ahatanak added a comment to D50152: [CodeGen] Merge equivalent block copy/helper functions.

Since BlockVarCopyInits is a map with key VarDecl *, I think we want to add a flag to VarDecl (NonParmVarDeclBits) that indicates whether the copy expression can throw or not. Or is there a reason to store the bit in BlockDecl::Capture instead?

Aug 7 2018, 7:46 PM
ahatanak added a comment to D50152: [CodeGen] Merge equivalent block copy/helper functions.

I thought it was okay to skip the work done by ResolveExceptionSpec in IRGen as long as the exception specifications that are needed have already been resolved in Sema. But calling Sema::canThrow in Sema::CheckCompleteVariableDeclaration and storing the result in BlockDecl::Capture is clearly the better solution since it doesn't introduce the complexity introduced in the updated patch.

Aug 7 2018, 11:49 AM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Remove a stale comment and add an assertion to check the destructor's exception specification has been resolved.

Aug 7 2018, 11:03 AM
ahatanak added inline comments to D50152: [CodeGen] Merge equivalent block copy/helper functions.
Aug 7 2018, 10:53 AM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Address review comments.

Aug 7 2018, 10:53 AM

Aug 6 2018

ahatanak added inline comments to D50152: [CodeGen] Merge equivalent block copy/helper functions.
Aug 6 2018, 2:06 PM
ahatanak added inline comments to D50152: [CodeGen] Merge equivalent block copy/helper functions.
Aug 6 2018, 1:56 PM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Address review comments.

Aug 6 2018, 1:55 PM
ahatanak added inline comments to D50152: [CodeGen] Merge equivalent block copy/helper functions.
Aug 6 2018, 12:20 AM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Address review comments.

Aug 6 2018, 12:19 AM

Aug 2 2018

ahatanak added inline comments to D50152: [CodeGen] Merge equivalent block copy/helper functions.
Aug 2 2018, 7:41 PM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Address review comments.

Aug 2 2018, 7:41 PM
ahatanak added a comment to D50205: [libc++] Add availability markup for aligned new/delete.

I just wanted to make sure that this doesn't have the same problem as https://reviews.llvm.org/D34556. Is that correct?

Aug 2 2018, 4:03 PM
ahatanak added inline comments to D50152: [CodeGen] Merge equivalent block copy/helper functions.
Aug 2 2018, 9:11 AM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Address review comments.

Aug 2 2018, 9:11 AM

Aug 1 2018

ahatanak committed rL338664: Pass triple to RUN line to fix failing bots..
Pass triple to RUN line to fix failing bots.
Aug 1 2018, 6:52 PM
ahatanak committed rC338664: Pass triple to RUN line to fix failing bots..
Pass triple to RUN line to fix failing bots.
Aug 1 2018, 6:52 PM
ahatanak committed rC338656: Serialize DoesNotEscape..
Serialize DoesNotEscape.
Aug 1 2018, 4:52 PM
ahatanak committed rL338656: Serialize DoesNotEscape..
Serialize DoesNotEscape.
Aug 1 2018, 4:52 PM
ahatanak added inline comments to D50152: [CodeGen] Merge equivalent block copy/helper functions.
Aug 1 2018, 2:29 PM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Use llvm::sort.

Aug 1 2018, 2:29 PM
ahatanak added inline comments to D50152: [CodeGen] Merge equivalent block copy/helper functions.
Aug 1 2018, 12:18 PM
ahatanak created D50152: [CodeGen] Merge equivalent block copy/helper functions.
Aug 1 2018, 12:10 PM

Jul 27 2018

ahatanak committed rL338189: [Sema][ObjC] Warn when a method declared in a protocol takes a.
[Sema][ObjC] Warn when a method declared in a protocol takes a
Jul 27 2018, 9:06 PM
ahatanak committed rC338189: [Sema][ObjC] Warn when a method declared in a protocol takes a.
[Sema][ObjC] Warn when a method declared in a protocol takes a
Jul 27 2018, 9:06 PM
ahatanak closed D49119: [Sema][ObjC] Issue a warning when a method declared in a protocol is non-escaping but the corresponding method in the implementation is escaping..
Jul 27 2018, 9:06 PM · Restricted Project
ahatanak updated the diff for D49119: [Sema][ObjC] Issue a warning when a method declared in a protocol is non-escaping but the corresponding method in the implementation is escaping..
  • Produce a note that tells users where the class extension conforming to the protocol containing the non-escaping method is declared.
  • Add a class method that has the same name as the instance method and check that no spurious warnings are issued.
Jul 27 2018, 5:21 PM · Restricted Project
ahatanak added a comment to D49119: [Sema][ObjC] Issue a warning when a method declared in a protocol is non-escaping but the corresponding method in the implementation is escaping..

Thanks, I'll update the patch and commit it today.

Jul 27 2018, 3:47 PM · Restricted Project

Jul 26 2018

ahatanak committed rC338048: [Sema][ObjC] Do not propagate the nullability specifier on the receiver.
[Sema][ObjC] Do not propagate the nullability specifier on the receiver
Jul 26 2018, 10:51 AM
ahatanak committed rL338048: [Sema][ObjC] Do not propagate the nullability specifier on the receiver.
[Sema][ObjC] Do not propagate the nullability specifier on the receiver
Jul 26 2018, 10:51 AM
ahatanak committed rL338041: [CodeGen][ObjC] Make block copy/dispose helper functions exception-safe..
[CodeGen][ObjC] Make block copy/dispose helper functions exception-safe.
Jul 26 2018, 9:51 AM
ahatanak committed rC338041: [CodeGen][ObjC] Make block copy/dispose helper functions exception-safe..
[CodeGen][ObjC] Make block copy/dispose helper functions exception-safe.
Jul 26 2018, 9:51 AM
ahatanak closed D49718: [CodeGen][ObjC] Make block copy/dispose helper function exception-safe..
Jul 26 2018, 9:51 AM