Page MenuHomePhabricator

ahatanak (Akira Hatanaka)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 4 2013, 1:37 PM (442 w, 2 d)

Recent Activity

Today

ahatanak added inline comments to D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization.
Fri, May 27, 12:30 PM · Restricted Project, Restricted Project
ahatanak added inline comments to D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization.
Fri, May 27, 12:14 PM · Restricted Project, Restricted Project

Yesterday

ahatanak updated the diff for D125936: [Sema] Relax an assertion in BuildStmtExpr.

Add a codegen test that checks destructors for temporaries inside asm statements are called.

Thu, May 26, 3:08 PM · Restricted Project, Restricted Project

Wed, May 25

ahatanak added a comment to D125936: [Sema] Relax an assertion in BuildStmtExpr.

I think the assertion is assuming StmtExpr is created only for GNU statement expressions, but it's created for asm statements too (see https://github.com/llvm/llvm-project/commit/3050d9bdb84e322e122219d54aedfe2d8ef7c51c).

Wed, May 25, 1:57 PM · Restricted Project, Restricted Project
ahatanak added a comment to D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor.

Does debug info need information on deduction guides? I think it's safe to skip deduction guides as they are used only for template argument deduction.

Wed, May 25, 11:44 AM · Restricted Project, Restricted Project
ahatanak added inline comments to D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization.
Wed, May 25, 11:20 AM · Restricted Project, Restricted Project

Fri, May 20

ahatanak added a comment to D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization.

The assertion assert(FromType->isIntegralOrUnscopedEnumerationType()) in StandardConversionSequence::getNarrowingKind fails when the invalid initialization is performed.

Fri, May 20, 12:33 PM · Restricted Project, Restricted Project
ahatanak requested review of D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization.
Fri, May 20, 12:27 PM · Restricted Project, Restricted Project

Wed, May 18

ahatanak added inline comments to D123649: Allow flexible array initialization in C++..
Wed, May 18, 4:53 PM · Restricted Project, Restricted Project
ahatanak requested review of D125936: [Sema] Relax an assertion in BuildStmtExpr.
Wed, May 18, 4:33 PM · Restricted Project, Restricted Project

Tue, May 17

ahatanak added a comment to D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor.

Without this fix, CXXNameMangler::mangleUnresolvedName crashes when it tries to mangle the name of a CXXDeductionGuideDecl.

Tue, May 17, 3:10 PM · Restricted Project, Restricted Project
ahatanak requested review of D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor.
Tue, May 17, 3:03 PM · Restricted Project, Restricted Project
ahatanak added inline comments to D123649: Allow flexible array initialization in C++..
Tue, May 17, 11:36 AM · Restricted Project, Restricted Project

Thu, May 12

ahatanak added a comment to D125349: [Sema] Fix crash for C11 atomic in gnu++ mode.

Is it not possible to handle this similarly to volatile unsigned? If I replace _Atomic unsigned with volatile unsigned, I see LookupOverloadedBinOp succeed without having to strip volatile because addAssignmentArithmeticOverloads adds candidates with volatile types.

Thu, May 12, 10:51 AM · Restricted Project
ahatanak accepted D125254: [clang] Allow all string types for all attribute(format) styles.

LGTM with one minor comment.

Thu, May 12, 10:17 AM · Restricted Project, Restricted Project

Mon, May 2

ahatanak updated subscribers of D124680: [WinEHPrepare] Fix accidental truncation of EH funclets with GNUstep ObjC runtime.
Mon, May 2, 9:44 AM · Restricted Project, Restricted Project

Apr 22 2022

ahatanak committed rG3b578ae9088c: [Driver] Call hasFlag instead of hasArg (authored by ahatanak).
[Driver] Call hasFlag instead of hasArg
Apr 22 2022, 8:15 PM · Restricted Project, Restricted Project
ahatanak closed D124312: [Driver] Call hasFlag instead of hasArg.
Apr 22 2022, 8:15 PM · Restricted Project, Restricted Project
ahatanak requested review of D124312: [Driver] Call hasFlag instead of hasArg.
Apr 22 2022, 4:59 PM · Restricted Project, Restricted Project

Apr 20 2022

ahatanak added a comment to D122251: [lit] Use sharding for GoogleTest format.

It looks like this commit is causing https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive/22234/testReport/junit/ThreadSanitizer-Unit/rtl___TsanRtlTest-x86_64-Test_ThreadSanitizer/RaceWithDeadThread/ to fail. Can you take a look?

Apr 20 2022, 1:04 PM · Restricted Project, Restricted Project

Apr 16 2022

ahatanak accepted D123811: [ObjCARC] Drop nullary clang.arc.attachedcall bundles in autoupgrade..

LGTM

Apr 16 2022, 12:00 PM · Restricted Project, Restricted Project

Apr 13 2022

ahatanak added a comment to D123566: [sanitizer] Don't run malloc hooks for stacktraces.

It looks like this is causing a test to fail:
https://green.lab.llvm.org/green/job/clang-san-iossim/5229/consoleFull#711521816a1ca8a51-895e-46c6-af87-ce24fa4cd561

Apr 13 2022, 12:38 PM · Restricted Project, Restricted Project

Mar 29 2022

ahatanak added a comment to D122425: Pass -disable-llvm-passes to avoid running llvm passes.

I removed -O1 from the command line:
https://github.com/llvm/llvm-project/commit/6ec79a15cbe9539faf121b5ad39f195dc611fc09

Mar 29 2022, 3:57 PM · Restricted Project, Restricted Project
ahatanak committed rG6ec79a15cbe9: Remove -O1 from command line of nrvo.cpp (authored by ahatanak).
Remove -O1 from command line of nrvo.cpp
Mar 29 2022, 3:54 PM · Restricted Project, Restricted Project

Mar 28 2022

ahatanak added a comment to D122425: Pass -disable-llvm-passes to avoid running llvm passes.

Sorry, I didn't notice you left a comment until after committing the patch. I agree that -O1 can be removed.

Mar 28 2022, 12:28 PM · Restricted Project, Restricted Project
ahatanak committed rGb6dab4ebac59: Pass -disable-llvm-passes to avoid running llvm passes (authored by ahatanak).
Pass -disable-llvm-passes to avoid running llvm passes
Mar 28 2022, 11:16 AM · Restricted Project, Restricted Project
ahatanak closed D122425: Pass -disable-llvm-passes to avoid running llvm passes.
Mar 28 2022, 11:16 AM · Restricted Project, Restricted Project
ahatanak added a comment to D122425: Pass -disable-llvm-passes to avoid running llvm passes.

Yes, this test was susceptible to changes made to llvm passes and the pass pipeline.

Mar 28 2022, 10:57 AM · Restricted Project, Restricted Project

Mar 24 2022

ahatanak committed rG350d43f1efd7: Fix a bug where an extended vector of __fp16 was being converted to a (authored by ahatanak).
Fix a bug where an extended vector of __fp16 was being converted to a
Mar 24 2022, 6:08 PM · Restricted Project, Restricted Project
ahatanak requested review of D122425: Pass -disable-llvm-passes to avoid running llvm passes.
Mar 24 2022, 12:18 PM · Restricted Project, Restricted Project

Mar 22 2022

ahatanak committed rG818e72d1b09b: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in (authored by ahatanak).
[NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in
Mar 22 2022, 6:40 PM · Restricted Project
ahatanak closed D122199: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in TargetInfo.cpp.
Mar 22 2022, 6:40 PM · Restricted Project, Restricted Project

Mar 21 2022

ahatanak requested review of D122199: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in TargetInfo.cpp.
Mar 21 2022, 6:37 PM · Restricted Project, Restricted Project

Mar 11 2022

ahatanak committed rGaa4ea0ee5441: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in a couple (authored by ahatanak).
[NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in a couple
Mar 11 2022, 9:31 AM · Restricted Project
ahatanak closed D121135: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in a couple more files.
Mar 11 2022, 9:30 AM · Restricted Project, Restricted Project

Mar 8 2022

ahatanak committed rG9bb8c80beaa0: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in (authored by ahatanak).
[NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in
Mar 8 2022, 9:45 AM · Restricted Project
ahatanak closed D121153: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in CGBuiltin.cpp.
Mar 8 2022, 9:45 AM · Restricted Project, Restricted Project

Mar 7 2022

ahatanak requested review of D121153: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in CGBuiltin.cpp.
Mar 7 2022, 1:02 PM · Restricted Project, Restricted Project
ahatanak requested review of D121135: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in a couple more files.
Mar 7 2022, 9:55 AM · Restricted Project, Restricted Project

Mar 3 2022

ahatanak committed rG3717b9661fd6: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in (authored by ahatanak).
[NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in
Mar 3 2022, 8:55 AM · Restricted Project
ahatanak closed D120856: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in CGBlocks.cpp.
Mar 3 2022, 8:55 AM · Restricted Project, Restricted Project

Mar 2 2022

ahatanak requested review of D120856: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in CGBlocks.cpp.
Mar 2 2022, 4:38 PM · Restricted Project, Restricted Project
ahatanak committed rGd112cc27569b: [NFC][Clang][OpaquePtr] Remove the call to Address::deprecated in (authored by ahatanak).
[NFC][Clang][OpaquePtr] Remove the call to Address::deprecated in
Mar 2 2022, 8:58 AM · Restricted Project
ahatanak closed D120757: [NFC][Clang][OpaquePtr] Remove the call to Address::deprecated in CreatePointerBitCastOrAddrSpaceCast.
Mar 2 2022, 8:58 AM · Restricted Project, Restricted Project

Mar 1 2022

Herald added a project to D120757: [NFC][Clang][OpaquePtr] Remove the call to Address::deprecated in CreatePointerBitCastOrAddrSpaceCast: Restricted Project.

Yes, check-clang passes.

Mar 1 2022, 12:35 PM · Restricted Project, Restricted Project
ahatanak requested review of D120757: [NFC][Clang][OpaquePtr] Remove the call to Address::deprecated in CreatePointerBitCastOrAddrSpaceCast.
Mar 1 2022, 11:28 AM · Restricted Project, Restricted Project

Feb 3 2022

ahatanak accepted D118904: [clang][CodeGen] Use memory type representation in `va_arg`.

LGTM

Feb 3 2022, 2:26 PM · Restricted Project

Jan 26 2022

ahatanak added a comment to D118214: [ObjCARC] Require the function argument in the clang.arc.attachedcall bundle..

The ObjC ARC changes look good.

Jan 26 2022, 7:03 PM · Restricted Project, Restricted Project

Jan 11 2022

ahatanak committed rGe5df9cc098b5: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial (authored by ahatanak).
[CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial
Jan 11 2022, 11:22 AM
ahatanak closed D116948: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial when generating copy/dispose helper functions.
Jan 11 2022, 11:22 AM · Restricted Project
ahatanak updated the diff for D116948: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial when generating copy/dispose helper functions.

Update comments.

Jan 11 2022, 7:40 AM · Restricted Project

Jan 10 2022

ahatanak added inline comments to D116948: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial when generating copy/dispose helper functions.
Jan 10 2022, 9:20 PM · Restricted Project
ahatanak added inline comments to D116948: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial when generating copy/dispose helper functions.
Jan 10 2022, 8:02 PM · Restricted Project
ahatanak updated the diff for D116948: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial when generating copy/dispose helper functions.

Build the map (Captures) after building the vector (SortedCaptures).

Jan 10 2022, 6:35 PM · Restricted Project
ahatanak requested review of D116948: [CodeGen] Treat ObjC `__unsafe_unretained` and class types as trivial when generating copy/dispose helper functions.
Jan 10 2022, 8:18 AM · Restricted Project

Dec 16 2021

ahatanak added a comment to D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file.

This commit seems to have caused a test to fail: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/26118/testReport/

Dec 16 2021, 3:58 PM · Restricted Project, Restricted Project

Dec 13 2021

ahatanak accepted D115230: [X86] Use bundle for CALL_RVMARKER expansion..
Dec 13 2021, 1:01 PM · Restricted Project
ahatanak added a comment to D115230: [X86] Use bundle for CALL_RVMARKER expansion..

Since the strings are used in other places (e.g., PreISelIntrinsicLowering.cpp) too, you could place them in a header in llvm/IR or llvm/Analysis. But I think it's okay to do so in a separate patch.

Dec 13 2021, 1:01 PM · Restricted Project

Dec 10 2021

ahatanak added a comment to D115230: [X86] Use bundle for CALL_RVMARKER expansion..

Updated to only use bundles during expansion for Darwin platforms. This keeps it in sync with TargetMachine (for now the bundle expansion pass is only scheduled on Darwin platforms).

Dec 10 2021, 1:41 PM · Restricted Project

Nov 15 2021

ahatanak added a comment to D90434: [CodeGen] Correct codegen for self-capturing __block var.

@ille, are you still working on this patch?

Nov 15 2021, 7:27 PM · Restricted Project

Nov 12 2021

ahatanak committed rG7611e16fce9c: [clang][objc][codegen] Skip emitting ObjC category metadata when the (authored by guitard0g).
[clang][objc][codegen] Skip emitting ObjC category metadata when the
Nov 12 2021, 4:25 PM
ahatanak closed D113455: [clang][objc][codegen] Skip emitting ObjC category metadata when the category is empty.
Nov 12 2021, 4:25 PM · Restricted Project
ahatanak accepted D113455: [clang][objc][codegen] Skip emitting ObjC category metadata when the category is empty.

LGTM

Nov 12 2021, 4:10 PM · Restricted Project
ahatanak accepted D113636: format_arg attribute does not support nullable instancetype return type.

LGTM

Nov 12 2021, 11:54 AM · Restricted Project

Nov 11 2021

ahatanak added inline comments to D113455: [clang][objc][codegen] Skip emitting ObjC category metadata when the category is empty.
Nov 11 2021, 10:52 PM · Restricted Project

Nov 8 2021

ahatanak committed rG1fe8993ad819: [ObjC][ARC] Replace uses of ObjC intrinsics that are arguments of (authored by ahatanak).
[ObjC][ARC] Replace uses of ObjC intrinsics that are arguments of
Nov 8 2021, 9:20 PM
ahatanak committed rGd61eb6c5d97b: [ObjC][ARC] Use operand bundle "clang.arc.attachedcall" on x86-64 (authored by ahatanak).
[ObjC][ARC] Use operand bundle "clang.arc.attachedcall" on x86-64
Nov 8 2021, 6:40 PM
ahatanak committed rG8f8d9f743d31: [ObjC][ARC] Handle operand bundle "clang.arc.attachedcall" on targets (authored by ahatanak).
[ObjC][ARC] Handle operand bundle "clang.arc.attachedcall" on targets
Nov 8 2021, 6:40 PM
ahatanak closed D111331: [ObjC][ARC] Use operand bundle "clang.arc.attachedcall" on x86-64.
Nov 8 2021, 6:40 PM · Restricted Project
ahatanak closed D111334: [ObjC][ARC] Handle operand bundle "clang.arc.attachedcall" on targets that don't use the inline asm marker.
Nov 8 2021, 6:40 PM · Restricted Project
ahatanak committed rGf2c7c3c7c7b1: [ObjC][ARC] Invalidate an entry of UnderlyingObjCPtrCache when the (authored by ahatanak).
[ObjC][ARC] Invalidate an entry of UnderlyingObjCPtrCache when the
Nov 8 2021, 2:41 PM

Nov 4 2021

ahatanak added a comment to D112850: [clang] 'unused-but-set-variable' warning should not apply to __block objective-c pointers.

The lifetime of an object won't be extended in the following case since the variable isn't captured by a block:

Nov 4 2021, 11:57 AM · Restricted Project
ahatanak accepted D112850: [clang] 'unused-but-set-variable' warning should not apply to __block objective-c pointers.

LGTM

Nov 4 2021, 11:44 AM · Restricted Project

Oct 28 2021

ahatanak accepted D112670: __attribute__((format_arg(__NSString__, N))) does not support instancetype in NSString interface.

LGTM

Oct 28 2021, 8:24 PM · Restricted Project
ahatanak added inline comments to D112670: __attribute__((format_arg(__NSString__, N))) does not support instancetype in NSString interface.
Oct 28 2021, 6:01 PM · Restricted Project

Oct 27 2021

ahatanak accepted D112569: -Wformat-nonliteral should not trigger for format strings passed to blocks with __attribute__((format)).

LGTM

Oct 27 2021, 2:35 PM · Restricted Project

Oct 26 2021

ahatanak added inline comments to D112569: -Wformat-nonliteral should not trigger for format strings passed to blocks with __attribute__((format)).
Oct 26 2021, 7:29 PM · Restricted Project

Oct 20 2021

ahatanak committed rG2caf7571e102: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from (authored by gAlfonso-bit).
[Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from
Oct 20 2021, 10:35 AM
ahatanak closed D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.
Oct 20 2021, 10:35 AM · Restricted Project

Oct 11 2021

ahatanak updated the diff for D111331: [ObjC][ARC] Use operand bundle "clang.arc.attachedcall" on x86-64.

Improve comment.

Oct 11 2021, 9:16 PM · Restricted Project
ahatanak updated the summary of D111334: [ObjC][ARC] Handle operand bundle "clang.arc.attachedcall" on targets that don't use the inline asm marker.
Oct 11 2021, 9:13 PM · Restricted Project

Oct 7 2021

ahatanak added a comment to D111334: [ObjC][ARC] Handle operand bundle "clang.arc.attachedcall" on targets that don't use the inline asm marker.

No, only arm64 and x86-64 can correctly handle the operand bundle in the backend. I should mention that this only changes the middle-end passes and we still need to make changes to the backend to handle arbitrary targets.

Oct 7 2021, 2:54 PM · Restricted Project
ahatanak requested review of D111334: [ObjC][ARC] Handle operand bundle "clang.arc.attachedcall" on targets that don't use the inline asm marker.
Oct 7 2021, 12:04 PM · Restricted Project
ahatanak requested review of D111331: [ObjC][ARC] Use operand bundle "clang.arc.attachedcall" on x86-64.
Oct 7 2021, 12:02 PM · Restricted Project
ahatanak committed rG392a2a554cde: Refactor code in ObjCARC.cpp. NFC (authored by ahatanak).
Refactor code in ObjCARC.cpp. NFC
Oct 7 2021, 11:26 AM
ahatanak accepted D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType.

id is a typedef and @class is an ObjCInterface now, so it looks like it's safe to remove ObjCObjectPointer case then.

Oct 7 2021, 10:45 AM · Restricted Project

Sep 28 2021

ahatanak committed rGc6edf26f9a28: [docs ]Fix indentation (authored by ahatanak).
[docs ]Fix indentation
Sep 28 2021, 11:32 AM

Sep 26 2021

ahatanak added a reviewer for D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType: rjmccall.

I'm not sure why ObjCObjectPointerType was originally a specifier, but this patch looks safe to me. ObjCObjectPointerType is never passed to TypePrinter::printBefore and QualType GetBaseType, which are the two functions that use isSpecifierType, AFAICT.

Sep 26 2021, 9:06 PM · Restricted Project

Sep 13 2021

ahatanak added a comment to D108243: Put code that avoids heapifying local blocks behind a flag.

I was just asking for test cases as I thought it was already a driver option, but it turns out it wasn't. I agree that this shouldn't be a driver option.

Sep 13 2021, 11:28 AM · Restricted Project

Sep 10 2021

ahatanak accepted D108243: Put code that avoids heapifying local blocks behind a flag.

Can you add a driver test, which tests both -fobjc-avoid-heapify-local-blocks and -fno-objc-avoid-heapify-local-blocks?

Sep 10 2021, 5:00 PM · Restricted Project
ahatanak added a comment to D108243: Put code that avoids heapifying local blocks behind a flag.

Do you need arc-blocks-avoid-heapify.m? It seems like the other tests already cover all the cases we care about.

Sep 10 2021, 1:41 PM · Restricted Project

Sep 9 2021

ahatanak committed rG17c2948d0443: [clang-scan-deps] Add an API for clang dependency scanner to perform (authored by ahatanak).
[clang-scan-deps] Add an API for clang dependency scanner to perform
Sep 9 2021, 8:53 AM
ahatanak closed D109485: [clang-scan-deps] Add an API for clang dependency scanner to perform module lookup by name alone.
Sep 9 2021, 8:53 AM · Restricted Project

Sep 8 2021

ahatanak requested review of D109485: [clang-scan-deps] Add an API for clang dependency scanner to perform module lookup by name alone.
Sep 8 2021, 11:03 PM · Restricted Project
ahatanak committed rGdea6f71af0fd: [ObjC][ARC] Use the addresses of the ARC runtime functions instead of (authored by ahatanak).
[ObjC][ARC] Use the addresses of the ARC runtime functions instead of
Sep 8 2021, 12:02 PM
ahatanak closed D103000: [ObjC][ARC] Use the addresses of the ARC runtime functions instead of integer 0/1 for the operand of bundle "clang.arc.attachedcall".
Sep 8 2021, 12:02 PM · Restricted Project
ahatanak committed rG59cc39ae141f: [ObjC][ARC] Use the addresses of the ARC runtime functions instead of (authored by ahatanak).
[ObjC][ARC] Use the addresses of the ARC runtime functions instead of
Sep 8 2021, 12:02 PM
ahatanak closed D102996: [ObjC][ARC] Use the addresses of the ARC runtime functions instead of integer 0/1 for the operand of bundle "clang.arc.attachedcall".
Sep 8 2021, 12:01 PM · Restricted Project

Aug 31 2021

ahatanak updated the diff for D103000: [ObjC][ARC] Use the addresses of the ARC runtime functions instead of integer 0/1 for the operand of bundle "clang.arc.attachedcall".

Rebase and ping.

Aug 31 2021, 1:04 PM · Restricted Project

Aug 27 2021

ahatanak committed rG8f859cc34966: Use std::less instead of operator < in less_first and less_second (authored by ahatanak).
Use std::less instead of operator < in less_first and less_second
Aug 27 2021, 1:00 PM