User Details
- User Since
- Dec 4 2013, 1:37 PM (485 w, 4 d)
Mon, Mar 13
LGTM
Thu, Mar 9
clang marks the called function foo in p1.cpp as nounwind here: https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CodeGenFunction.cpp#L1284
Tue, Mar 7
Tue, Feb 28
Feb 24 2023
Remove AddressImpl altogether.
Feb 23 2023
I don't have a test case for this change because there is a bug that prevents using the maximum allowed alignment (see https://github.com/llvm/llvm-project/issues/60752).
Feb 17 2023
Feb 16 2023
Feb 15 2023
Add triple to the test and add release note for the fix.
Fix type and add comment. Remove unnecessary cast.
@tahonermann @cor3ntin have you had a chance to take a look at the updated patch?
Feb 14 2023
Add comment.
Feb 9 2023
- Set the KnownNonNull bit correctly when Address::withAlignment is called.
- Pass NotKnownNonNull to the call to Addr.withPointer when the address of thread local storage is created.
Address review comments.
Feb 7 2023
I agree that pushing an empty scope without initializing any of its members seems wrong.
Fix indentation.
Instead of pushing an empty lambda scope, switch to the enclosing context if the variable is used in a default argument expression of a lambda call operator.
Feb 6 2023
@efriedma do you have any comments?
Feb 2 2023
I'm still don't understand what the problem is about cleaning up the lambda scope.
Feb 1 2023
Doesn't Sema::FunctionScopeRAII pop the lambda scope when it goes out of scope?
Jan 27 2023
Pass a KnownNonNull_t flag to Address::withPointer.
Fix a few typos that were causing compile errors.
There are more places where we know contextually the pointer can't be null and can set the bit to KnownNonNull or set the bit of an LValue or Address using an existing Address's KnownNonNull bit.
Add a bit to Address and LValue that tracks whether the pointer is known not to be null.
Jan 26 2023
Jan 25 2023
Jan 23 2023
I'm not familiar with the WinEH stuff, but the other parts (the code that adds bundles, etc.) LGTM.
Jan 5 2023
LGTM
Jan 4 2023
Dec 19 2022
Check that the destructor is called conditionally.
Dec 16 2022
I read the patches and review comments in https://reviews.llvm.org/D42776, but I don't remember why I added that assert. Maybe I was just trying to ensure the version number passed to getTemporary was the one that was used to create the temporary. For example, if a temporary was created using version X and later retrieved using version Y because of some bug in constant evaluation, the assertion would fail.
Dec 14 2022
Dec 9 2022
Dec 7 2022
abc87ad4ed6cc5e6568751f375d1c646edb502f7 should fix the failing test.
Dec 6 2022
Address review comments.
Yes, I think that's okay. We are tracking this internally, so this can be committed as-is.
Dec 5 2022
Add another environment variable CC_PRINT_HEADERS_FILTERING, which can be used to specify whether header information should be filtered or not.
Dec 2 2022
Dec 1 2022
Nov 29 2022
I confirmed ARC optimizer hasn't removed the retain/release pairs in both functions at least since October 2017. The retain/release pair in @"\01-[Top0 _getX]" can be removed. I'm not sure about the one in @"\01-[A z]".
Nov 28 2022
ARC optimizer was previously removing the retain/release pair, but it's not clear to me why it was safe to do so. There is a load that loads an ivar of the object before the call to @llvm.objc.release, so the object has to be kept alive at least until that point.
Nov 17 2022
Address review comments. Also, change check string in test case to fix pre-merge checks that were failing.
Nov 16 2022
Address review comments.
Nov 15 2022
Nov 14 2022
Nov 13 2022
Nov 8 2022
Oct 26 2022
Probably not NFC according to https://llvm.org/docs/Lexicon.html, but LGTM.
Oct 24 2022
LGTM with minor comments.
Oct 17 2022
LGTM
Oct 14 2022
LGTM
Oct 12 2022
Oct 7 2022
This LGTM for apple's runtime assuming it knows how to handle the new string.