Page MenuHomePhabricator

ahatanak (Akira Hatanaka)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 4 2013, 1:37 PM (319 w, 2 d)

Recent Activity

Tue, Jan 14

ahatanak accepted D71682: Relax the rules around objc_alloc and objc_alloc_init optimizations..

LGTM

Tue, Jan 14, 9:45 AM · Restricted Project
ahatanak added inline comments to D71682: Relax the rules around objc_alloc and objc_alloc_init optimizations..
Tue, Jan 14, 9:36 AM · Restricted Project

Mon, Jan 13

ahatanak added inline comments to D71682: Relax the rules around objc_alloc and objc_alloc_init optimizations..
Mon, Jan 13, 4:03 PM · Restricted Project

Thu, Jan 9

ahatanak committed rG4a4ae8ba5058: Include ptrauth key and diversity information in the mangled name of non… (authored by ahatanak).
Include ptrauth key and diversity information in the mangled name of non…
Thu, Jan 9, 5:17 PM
ahatanak committed rGa0544ee89256: Use hasOffsetApplied to initialize member HasOffsetApplied (authored by ahatanak).
Use hasOffsetApplied to initialize member HasOffsetApplied
Thu, Jan 9, 5:13 PM
ahatanaka <ahatanaka@apple.com> committed rG6201ae66b8f6: Don't forget to parse ptrauth options when the input is a precompiled file (authored by ahatanak).
Don't forget to parse ptrauth options when the input is a precompiled file
Thu, Jan 9, 5:04 PM
ahatanak committed rGf2d0c6207fce: Fix check strings in test case (authored by ahatanak).
Fix check strings in test case
Thu, Jan 9, 5:04 PM
ahatanak committed rG103495925b28: Merge commit 'refs/am/changes/5bcd34a03ff343674c106b9a6a0406bf249b9b31_apple/ma… (authored by ahatanak).
Merge commit 'refs/am/changes/5bcd34a03ff343674c106b9a6a0406bf249b9b31_apple/ma…
Thu, Jan 9, 4:59 PM
ahatanak committed rG2fe2a3f92312: Fix build error. (authored by ahatanak).
Fix build error.
Thu, Jan 9, 4:59 PM
ahatanak committed rGe941450d3889: Merge commit 'refs/am/changes/f978ea498309adaebab8fbf1cd6e520e7e0e11f1_apple/ma… (authored by ahatanak).
Merge commit 'refs/am/changes/f978ea498309adaebab8fbf1cd6e520e7e0e11f1_apple/ma…
Thu, Jan 9, 4:59 PM
ahatanak committed rGd10fb7faf76a: Merge commit 'refs/am/changes/e1578fd2b79fe5af5f80c0c166a8abd0f816c022_apple/ma… (authored by ahatanak).
Merge commit 'refs/am/changes/e1578fd2b79fe5af5f80c0c166a8abd0f816c022_apple/ma…
Thu, Jan 9, 4:45 PM
ahatanak committed rG83ab1e51c975: Merge commit 'refs/am/changes/60573ae6fe509b618dc6a2c5c55d921bccd77608_apple/ma… (authored by ahatanak).
Merge commit 'refs/am/changes/60573ae6fe509b618dc6a2c5c55d921bccd77608_apple/ma…
Thu, Jan 9, 4:45 PM
ahatanak committed rGded65a9a0b8c: Include Attr.h to fix build error (authored by ahatanak).
Include Attr.h to fix build error
Thu, Jan 9, 4:45 PM
ahatanak committed rG3253afd59eaf: Merge commit 'refs/am/changes/6c2b2b9e20abb27ab5c1ae255c1862785b793c1f_apple/ma… (authored by ahatanak).
Merge commit 'refs/am/changes/6c2b2b9e20abb27ab5c1ae255c1862785b793c1f_apple/ma…
Thu, Jan 9, 4:43 PM
ahatanak committed rG67071b622015: Merge commit 'refs/am/changes/fdf80e86a52849813d05da4b6c25884c06ba9e98_apple/ma… (authored by ahatanak).
Merge commit 'refs/am/changes/fdf80e86a52849813d05da4b6c25884c06ba9e98_apple/ma…
Thu, Jan 9, 4:43 PM
ahatanak committed rG0fb1d330d6c2: Merge commit 'refs/am/changes/7f9b5138470db1dc58f3bc05631284c653c9ed7a_apple/ma… (authored by ahatanak).
Merge commit 'refs/am/changes/7f9b5138470db1dc58f3bc05631284c653c9ed7a_apple/ma…
Thu, Jan 9, 4:41 PM
ahatanak committed rGa490780f4504: Merge commit 'refs/am/changes/cdbed2dd856c14687efd741c2d8321686102acb8_apple/ma… (authored by ahatanak).
Merge commit 'refs/am/changes/cdbed2dd856c14687efd741c2d8321686102acb8_apple/ma…
Thu, Jan 9, 4:38 PM
ahatanak committed rGf579ea359d35: Pass reference to CodeGenFunction after changes in open source (authored by ahatanak).
Pass reference to CodeGenFunction after changes in open source
Thu, Jan 9, 4:34 PM
ahatanak committed rG8fd287546e5d: Merge commit 'refs/am/changes/f139ae3d9379746164e8056c45817041417dfd4c_apple/ma… (authored by ahatanak).
Merge commit 'refs/am/changes/f139ae3d9379746164e8056c45817041417dfd4c_apple/ma…
Thu, Jan 9, 4:34 PM
ahatanak committed rG899060b9b556: Merge commit 'refs/am/changes/bc840b21e1612adb603b6c17be0329e3737bb943_apple/ma… (authored by ahatanak).
Merge commit 'refs/am/changes/bc840b21e1612adb603b6c17be0329e3737bb943_apple/ma…
Thu, Jan 9, 4:33 PM
ahatanak committed rGb2f2db63739f: Merge commit 'refs/am/changes/6e51ceba536d88f882737c9c4f9ff0ffb0004bfd_apple/ma… (authored by ahatanak).
Merge commit 'refs/am/changes/6e51ceba536d88f882737c9c4f9ff0ffb0004bfd_apple/ma…
Thu, Jan 9, 4:32 PM
ahatanak committed rGa826d4e500a6: Merge commit 'refs/am/changes/f1e3988aa6016188c376b9bcca1afc7559f9fbc0_apple/ma… (authored by ahatanak).
Merge commit 'refs/am/changes/f1e3988aa6016188c376b9bcca1afc7559f9fbc0_apple/ma…
Thu, Jan 9, 4:31 PM

Mon, Jan 6

ahatanak committed rG20f005d25f48: [CodeGen][ObjC] Push the properties of a protocol before pushing the properties… (authored by ahatanak).
[CodeGen][ObjC] Push the properties of a protocol before pushing the properties…
Mon, Jan 6, 4:22 PM
ahatanak committed rGc6fd16af2be9: Use FileCheck instead of grep (authored by ahatanak).
Use FileCheck instead of grep
Mon, Jan 6, 3:52 PM

Dec 18 2019

ahatanak committed rGa6d57a8cd4cf: Use hasOffsetApplied to initialize member HasOffsetApplied (authored by ahatanak).
Use hasOffsetApplied to initialize member HasOffsetApplied
Dec 18 2019, 2:00 PM

Dec 17 2019

ahatanak added a comment to rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector".

I'm still not sure why __fp16, which is a storage-only type, is used for the element type of float16x4_t if we want to avoid promotion to a float vector type.

Dec 17 2019, 6:55 PM

Dec 13 2019

ahatanak committed rGa0a670614a36: Call objc_retainBlock before passing a block as a variadic argument (authored by ahatanak).
Call objc_retainBlock before passing a block as a variadic argument
Dec 13 2019, 1:18 PM
ahatanak closed D71431: Call objc_retainBlock before passing a block as a variadic argument.
Dec 13 2019, 1:18 PM · Restricted Project
ahatanak added inline comments to D71431: Call objc_retainBlock before passing a block as a variadic argument.
Dec 13 2019, 1:00 PM · Restricted Project
ahatanak updated the diff for D71431: Call objc_retainBlock before passing a block as a variadic argument.

Explain why this change is needed in ARC documentation.

Dec 13 2019, 12:42 PM · Restricted Project

Dec 12 2019

ahatanaka <ahatanaka@apple.com> committed rG3cd11f96b3d9: Don't add optnone or noinline if the function is already marked as… (authored by ahatanak).
Don't add optnone or noinline if the function is already marked as…
Dec 12 2019, 3:55 PM
ahatanak committed rG88d5c0055251: Merge commit 'refs/am/changes/c1d2927cc64731520e60ecd1fc0e0eeabdfbac40_apple/ma… (authored by ahatanak).
Merge commit 'refs/am/changes/c1d2927cc64731520e60ecd1fc0e0eeabdfbac40_apple/ma…
Dec 12 2019, 3:35 PM
ahatanak committed rGfccc03fdc27b: Fix merge error. (authored by ahatanak).
Fix merge error.
Dec 12 2019, 3:35 PM
ahatanak committed rG3a81b82ff41d: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by ahatanak).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 1:46 PM
ahatanak committed rG6bdec82d103f: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by ahatanak).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 1:45 PM
ahatanak committed rGfde68e5481c0: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by ahatanak).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 1:39 PM
ahatanak committed rG610643a54e8c: Fix more merge errors that were introduced in… (authored by ahatanak).
Fix more merge errors that were introduced in…
Dec 12 2019, 12:49 PM
ahatanak committed rG11b8bbe3024a: Fix more merge errors that were introduced in… (authored by ahatanak).
Fix more merge errors that were introduced in…
Dec 12 2019, 12:49 PM
ahatanak committed rGc394085138dd: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by ahatanak).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 12:49 PM
ahatanak committed rG2e4b15fc6bde: Remove duplicate function definitions and fix merge error in… (authored by ahatanak).
Remove duplicate function definitions and fix merge error in…
Dec 12 2019, 12:49 PM
ahatanak created D71431: Call objc_retainBlock before passing a block as a variadic argument.
Dec 12 2019, 12:48 PM · Restricted Project
ahatanak committed rG5ec09527b9d5: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by ahatanak).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 12:48 PM
ahatanak committed rGa045c8edd99f: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by ahatanak).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 12:43 PM

Dec 11 2019

ahatanak committed rG7292c2823063: Fix an error in the block ABI documentation sample code (authored by ahatanak).
Fix an error in the block ABI documentation sample code
Dec 11 2019, 11:21 PM

Dec 9 2019

ahatanak added a reverting change for rG88f5bf77f928: [compiler-rt] Add a critical section when flushing gcov counters: rG78a7af456dbb: Revert "[compiler-rt] Add a critical section when flushing gcov counters".
Dec 9 2019, 8:03 PM
ahatanak committed rG78a7af456dbb: Revert "[compiler-rt] Add a critical section when flushing gcov counters" (authored by ahatanak).
Revert "[compiler-rt] Add a critical section when flushing gcov counters"
Dec 9 2019, 8:03 PM
ahatanak added a comment to D70910: [compiler-rt] Add a critical section when flushing gcov counters.

I've reverted this patch:

Dec 9 2019, 8:03 PM · Restricted Project, Restricted Project
ahatanak added a comment to D70910: [compiler-rt] Add a critical section when flushing gcov counters.

This has broken http://lab.llvm.org:8080/green/job/clang-stage1-RA/4401.

Dec 9 2019, 2:09 PM · Restricted Project, Restricted Project

Dec 6 2019

ahatanak committed rGa7bdab2e9d59: [clang-tidy] Pass -faligned-allocation on the compiler command line to fix… (authored by ahatanak).
[clang-tidy] Pass -faligned-allocation on the compiler command line to fix…
Dec 6 2019, 12:34 PM

Dec 3 2019

ahatanak closed D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs.

Fixed in d8136f14f125fb27f2326f397df0964bf62078ca

Dec 3 2019, 11:58 PM · Restricted Project
ahatanak committed rGd8136f14f125: [CodeGen][ObjC] Emit a primitive store to store a __strong field in… (authored by ahatanak).
[CodeGen][ObjC] Emit a primitive store to store a __strong field in…
Dec 3 2019, 11:49 PM
ahatanak updated the diff for D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs.

Call EmitStoreThroughLValue and EmitLoadOfLValue only when the lvalue is a bitfield.

Dec 3 2019, 7:13 PM · Restricted Project
ahatanak added inline comments to D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs.
Dec 3 2019, 7:13 PM · Restricted Project
ahatanak committed rGf139ae3d9379: [NFC] Pass a reference to CodeGenFunction to methods of LValue and AggValueSlot (authored by ahatanak).
[NFC] Pass a reference to CodeGenFunction to methods of LValue and AggValueSlot
Dec 3 2019, 3:24 PM
ahatanak added inline comments to rG8a5b7c35709d: [NFC] Pass a reference to CodeGenFunction to methods of LValue and AggValueSlot.
Dec 3 2019, 1:21 PM
ahatanak committed rG9f37c0e703c0: Revert "[NFC] Pass a reference to CodeGenFunction to methods of LValue and" (authored by ahatanak).
Revert "[NFC] Pass a reference to CodeGenFunction to methods of LValue and"
Dec 3 2019, 1:12 PM
ahatanak added a reverting change for rG8a5b7c35709d: [NFC] Pass a reference to CodeGenFunction to methods of LValue and AggValueSlot: rG9f37c0e703c0: Revert "[NFC] Pass a reference to CodeGenFunction to methods of LValue and".
Dec 3 2019, 1:12 PM
ahatanak committed rG8a5b7c35709d: [NFC] Pass a reference to CodeGenFunction to methods of LValue and AggValueSlot (authored by ahatanak).
[NFC] Pass a reference to CodeGenFunction to methods of LValue and AggValueSlot
Dec 3 2019, 11:38 AM

Dec 2 2019

ahatanak added a comment to D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs.

Note that passing isInit=true to EmitStoreThroughLValue to make it emit llvm.objc.retain would be incorrect since the callee destructs the struct argument.

Dec 2 2019, 6:12 PM · Restricted Project
ahatanak created D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs.
Dec 2 2019, 6:05 PM · Restricted Project

Dec 1 2019

ahatanak added a comment to rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector".

The test is failing because float16x4_t is defined as a vector of __fp16 in arm_neon.h and Sema promotes vectors of __fp16 to vectors of float since __fp16 is a storage-only type. The test used to pass because of a bug in function isVector, which was fixed in the commit that was reverted.

Dec 1 2019, 10:25 PM

Nov 22 2019

ahatanak updated subscribers of rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector".
Nov 22 2019, 3:11 PM
ahatanak updated subscribers of rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector".

@az and @SjoerdMeijer, can we add -fnative-half-type to the command line of arm-v8.2a-neon-intrinsics.c and aarch64-v8.2a-neon-intrinsics.c? I think the fp16 intrinsics can only be used when there is native hardware support for the type. If we do so, we will probably have to make changes to the driver too.

Nov 22 2019, 3:11 PM
ahatanak added a reverting change for rGa6150b48cea0: [Sema] Use the canonical type in function isVector: rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector".
Nov 22 2019, 1:57 PM
ahatanak committed rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector" (authored by ahatanak).
Revert "[Sema] Use the canonical type in function isVector"
Nov 22 2019, 1:57 PM
ahatanak committed rGa6150b48cea0: [Sema] Use the canonical type in function isVector (authored by ahatanak).
[Sema] Use the canonical type in function isVector
Nov 22 2019, 1:02 PM

Nov 18 2019

ahatanak added a comment to D70370: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls.

I think I agree with you. isSafeBetweenRVCalls seems too conservative. I can't think of a case where we aren't allowed to remove the pair of instructions because the instructions you listed exist between the pair (and that includes opaque calls). But John probably knows better whether that is safe or not.

Nov 18 2019, 7:40 PM · Restricted Project
ahatanak added a comment to D70370: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls.

It wasn't clear to me, but is the pair deleted only if there are no instructions that return false for isSafeBetweenRVCalls in between?

Nov 18 2019, 11:45 AM · Restricted Project

Nov 15 2019

ahatanak committed rG4516dc1c20d1: Don't add optnone or noinline if the function is already marked as… (authored by ahatanak).
Don't add optnone or noinline if the function is already marked as…
Nov 15 2019, 3:51 PM

Oct 30 2019

ahatanak committed rGc1d2927cc647: Run clang-format on lib/CodeGen/CGCall.h and fix indentation (authored by ahatanak).
Run clang-format on lib/CodeGen/CGCall.h and fix indentation
Oct 30 2019, 6:11 PM

Oct 29 2019

ahatanak committed rG8bcff4ec58cf: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by ahatanak).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 4:10 PM
ahatanak committed rG29f25828f3bc: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by ahatanak).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 3:45 PM
ahatanak committed rG924d6df55026: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by ahatanak).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 3:22 PM
ahatanak committed rG927163c38e2d: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by ahatanak).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 3:22 PM
ahatanak committed rG817171782cb5: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by ahatanak).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 3:19 PM
ahatanak committed rGd02e1bd7dd43: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by ahatanak).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 3:11 PM
ahatanak committed rGd0c92fd0f1ca: Fix expected warning after r313945. (authored by ahatanak).
Fix expected warning after r313945.
Oct 29 2019, 3:11 PM
ahatanak committed rG9fa0b9560178: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by ahatanak).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 1:42 PM
ahatanak committed rG3a35af71ba7b: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by ahatanak).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 1:41 PM
ahatanak committed rG975f5d49cc61: Merge branch 'mirror/master' into upstream-with-swift (authored by ahatanak).
Merge branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 12:28 PM
ahatanak committed rG1388c31fa736: Merge branch 'mirror/master' into upstream-with-swift (authored by ahatanak).
Merge branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 12:28 PM
ahatanak committed rGfb20e63e99da: Merge branch 'mirror/master' into upstream-with-swift (authored by ahatanak).
Merge branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 12:28 PM
ahatanak committed rG2a0d91f8cfa5: Merge branch 'mirror/master' into upstream-with-swift (authored by ahatanak).
Merge branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 12:27 PM
ahatanak committed rG6471943c81aa: Merge branch 'mirror/master' into upstream-with-swift (authored by ahatanak).
Merge branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 12:26 PM

Oct 24 2019

ahatanak committed rG31b752cbf0db: [ObjC][ARC] Check whether the return and parameter types of the old and new… (authored by ahatanak).
[ObjC][ARC] Check whether the return and parameter types of the old and new…
Oct 24 2019, 1:13 PM

Oct 9 2019

ahatanak committed rL374247: Request commit access for ahatanak.
Request commit access for ahatanak
Oct 9 2019, 3:23 PM

Sep 19 2019

ahatanak committed rG75fbb171c309: [ObjC][ARC] Skip debug instructions when computing the insert point of… (authored by ahatanak).
[ObjC][ARC] Skip debug instructions when computing the insert point of…
Sep 19 2019, 1:59 PM
ahatanak committed rL372352: [ObjC][ARC] Skip debug instructions when computing the insert point of.
[ObjC][ARC] Skip debug instructions when computing the insert point of
Sep 19 2019, 1:58 PM

Sep 6 2019

ahatanak committed rG3f2c9917a431: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership… (authored by ahatanak).
[Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership…
Sep 6 2019, 5:35 PM
ahatanak committed rG090510608da4: [Sema] Diagnose default-initialization, destruction, and copying of non-trivial… (authored by ahatanak).
[Sema] Diagnose default-initialization, destruction, and copying of non-trivial…
Sep 6 2019, 5:35 PM
ahatanak committed rL371276: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership.
[Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership
Sep 6 2019, 5:33 PM
ahatanak closed D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.
Sep 6 2019, 5:33 PM · Restricted Project, Restricted Project
ahatanak committed rL371275: [Sema] Diagnose default-initialization, destruction, and copying of.
[Sema] Diagnose default-initialization, destruction, and copying of
Sep 6 2019, 5:33 PM
ahatanak added inline comments to D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.
Sep 6 2019, 3:39 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.

Rename function and fix comments.

Sep 6 2019, 3:39 PM · Restricted Project, Restricted Project

Sep 5 2019

ahatanak updated the diff for D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.

Rename function to ignoreForTrivialityComputation.

Sep 5 2019, 5:09 PM · Restricted Project, Restricted Project

Sep 4 2019

ahatanak added inline comments to D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.
Sep 4 2019, 6:57 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.

Address review comments.

Sep 4 2019, 6:54 PM · Restricted Project, Restricted Project
ahatanak added inline comments to D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.
Sep 4 2019, 12:14 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header.

Address review comments.

Sep 4 2019, 12:14 PM · Restricted Project, Restricted Project