ahatanak (Akira Hatanaka)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 4 2013, 1:37 PM (220 w, 3 h)

Recent Activity

Today

ahatanak added inline comments to D41228: [ObjC] Enable __strong pointers in structs under ARC.
Wed, Feb 21, 12:04 PM
ahatanak updated the diff for D41228: [ObjC] Enable __strong pointers in structs under ARC.

Address review comments.

Wed, Feb 21, 12:04 PM

Fri, Feb 16

ahatanak committed rL325321: [Sema] Take into account the current context when checking the.
[Sema] Take into account the current context when checking the
Fri, Feb 16, 12:50 AM
ahatanak committed rC325321: [Sema] Take into account the current context when checking the.
[Sema] Take into account the current context when checking the
Fri, Feb 16, 12:50 AM
ahatanak closed D36918: [Sema] Take into account the current context when checking the accessibility of a member function pointer.
Fri, Feb 16, 12:50 AM

Thu, Feb 15

ahatanak added inline comments to D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments.
Thu, Feb 15, 11:33 PM
ahatanak updated the diff for D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments.

Address review comments.

Thu, Feb 15, 11:32 PM
ahatanak added inline comments to D41228: [ObjC] Enable __strong pointers in structs under ARC.
Thu, Feb 15, 7:36 AM
ahatanak updated the diff for D41228: [ObjC] Enable __strong pointers in structs under ARC.

Address review comments.

Thu, Feb 15, 7:36 AM

Wed, Feb 14

ahatanak added a comment to D10831: Attach attribute "trap-func-name" to IR function.

AMDGPUAnnotateKernelFeatures::addFeatureAttributes looks for an llvm.trap instruction and adds attribute "amdgpu-queue-ptr" to the function if it finds one.

Wed, Feb 14, 9:42 PM

Mon, Feb 12

ahatanak updated the diff for D41228: [ObjC] Enable __strong pointers in structs under ARC.

Address review comments and feedback I got from John offline.

Mon, Feb 12, 10:44 PM
ahatanak added a comment to D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments.

OK, I see. It's pretty easy to come up with an example.

Mon, Feb 12, 6:49 PM
ahatanak added inline comments to D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments.
Mon, Feb 12, 6:39 PM
ahatanak added inline comments to D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments.
Mon, Feb 12, 3:06 PM
ahatanak updated the diff for D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments.

Address Erik's and Roman's review comments.

Mon, Feb 12, 3:06 PM

Fri, Feb 9

ahatanak committed rL324765: Remove "CHECK: entry" in test case..
Remove "CHECK: entry" in test case.
Fri, Feb 9, 11:28 AM
ahatanak committed rC324765: Remove "CHECK: entry" in test case..
Remove "CHECK: entry" in test case.
Fri, Feb 9, 11:28 AM

Tue, Feb 6

ahatanak committed rL324425: [Sema][ObjC] Use SmallSetVector to fix a failing test on the reverse.
[Sema][ObjC] Use SmallSetVector to fix a failing test on the reverse
Tue, Feb 6, 3:49 PM
ahatanak committed rC324425: [Sema][ObjC] Use SmallSetVector to fix a failing test on the reverse.
[Sema][ObjC] Use SmallSetVector to fix a failing test on the reverse
Tue, Feb 6, 3:49 PM

Mon, Feb 5

ahatanak committed rL324269: Add support for attribute 'trivial_abi'..
Add support for attribute 'trivial_abi'.
Mon, Feb 5, 12:25 PM
ahatanak committed rC324269: Add support for attribute 'trivial_abi'..
Add support for attribute 'trivial_abi'.
Mon, Feb 5, 12:25 PM
ahatanak closed D41039: Add support for attribute "trivial_abi".
Mon, Feb 5, 12:25 PM
ahatanak closed D41039: Add support for attribute "trivial_abi".
Mon, Feb 5, 12:25 PM

Wed, Jan 31

ahatanak committed rC323943: [CodeGen] Fix an assertion failure in CGRecordLowering..
[CodeGen] Fix an assertion failure in CGRecordLowering.
Wed, Jan 31, 7:06 PM
ahatanak committed rL323943: [CodeGen] Fix an assertion failure in CGRecordLowering..
[CodeGen] Fix an assertion failure in CGRecordLowering.
Wed, Jan 31, 7:06 PM
ahatanak created D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments.
Wed, Jan 31, 6:24 PM

Tue, Jan 30

ahatanak committed rC323814: Revert "CodeGen: annotate ObjC ARC functions with ABI constraints".
Revert "CodeGen: annotate ObjC ARC functions with ABI constraints"
Tue, Jan 30, 12:24 PM
ahatanak committed rL323814: Revert "CodeGen: annotate ObjC ARC functions with ABI constraints".
Revert "CodeGen: annotate ObjC ARC functions with ABI constraints"
Tue, Jan 30, 12:21 PM

Fri, Jan 26

ahatanak committed rL323578: [CodeGen] Use the non-virtual alignment when emitting the base.
[CodeGen] Use the non-virtual alignment when emitting the base
Fri, Jan 26, 4:38 PM
ahatanak committed rC323578: [CodeGen] Use the non-virtual alignment when emitting the base.
[CodeGen] Use the non-virtual alignment when emitting the base
Fri, Jan 26, 4:38 PM
ahatanak closed D42521: [CodeGen] Use the non-virtual alignment when emitting the base class subobject constructor.
Fri, Jan 26, 4:38 PM

Thu, Jan 25

ahatanak created D42521: [CodeGen] Use the non-virtual alignment when emitting the base class subobject constructor.
Thu, Jan 25, 12:09 AM

Jan 22 2018

ahatanak added a comment to D41039: Add support for attribute "trivial_abi".

Yes, please document this in itanium-cxx-abi. Thanks!

Jan 22 2018, 10:01 AM

Jan 19 2018

ahatanak committed rL323009: [ObjCARC] Do not turn a call to @objc_autoreleaseReturnValue into a call.
[ObjCARC] Do not turn a call to @objc_autoreleaseReturnValue into a call
Jan 19 2018, 3:54 PM

Jan 17 2018

ahatanak added a comment to D41039: Add support for attribute "trivial_abi".

I think I've addressed all the review comments. Any other comments from anyone?

Jan 17 2018, 11:48 AM

Jan 12 2018

ahatanak added inline comments to D41228: [ObjC] Enable __strong pointers in structs under ARC.
Jan 12 2018, 10:36 AM

Jan 10 2018

ahatanak updated the diff for D41039: Add support for attribute "trivial_abi".

In CXXRecordDecl::addedMember, set HasTrivialSpecialMembersForCall if Method->isTrivialForCall() returns true. This fixes a bug where CXXRecordDecl::hasNonTrivialDestructorForCall would return false for the implicit destructor even when the parent class had attribute trivial_abi.

Jan 10 2018, 11:17 PM
ahatanak updated the diff for D41228: [ObjC] Enable __strong pointers in structs under ARC.

In EmitCallArg and EmitParmDecl, use the existing code for Microsoft C++ ABI to determine whether the argument should be destructed in the callee. Also, add a test case that checks the destructor for a non-trivial C struct is called on the EH path.

Jan 10 2018, 4:06 PM
ahatanak added inline comments to D41039: Add support for attribute "trivial_abi".
Jan 10 2018, 2:45 PM
ahatanak updated the diff for D41039: Add support for attribute "trivial_abi".

Partially revert the changes I made to CodeGenFunction::EmitParmDecl add IRGen test case for exception handling.

Jan 10 2018, 2:34 PM

Jan 9 2018

ahatanak added inline comments to D41039: Add support for attribute "trivial_abi".
Jan 9 2018, 12:12 AM
ahatanak updated the diff for D41039: Add support for attribute "trivial_abi".

Add more tests for template instantiation of "trivial_abi" classes.

Jan 9 2018, 12:04 AM

Jan 8 2018

ahatanak updated the diff for D41039: Add support for attribute "trivial_abi".

Address review comments.

Jan 8 2018, 11:40 AM
ahatanak added a comment to D41039: Add support for attribute "trivial_abi".

I'll trust Richard on the tricky Sema/AST bits. The functionality of the patch looks basically acceptable to me, although I'm still not thrilled about the idea of actually removing the attribute from the AST rather than just letting it not have effect. But we could clean that up later if it's significantly simpler to do it this way.

Jan 8 2018, 1:05 AM
ahatanak updated the diff for D41039: Add support for attribute "trivial_abi".

Address review comments.

Jan 8 2018, 12:55 AM

Jan 5 2018

ahatanak added inline comments to D41311: [CodeGen] Fix crash when a function taking transparent union is redeclared..
Jan 5 2018, 10:12 PM
ahatanak added a comment to D41311: [CodeGen] Fix crash when a function taking transparent union is redeclared..

It doesn't look like this patch would break IRGen for functions that receive fp16 types. fp16 is passed as i32 or float (without promotion) on ARM and as half on ARM64. It should work fine.

Jan 5 2018, 10:09 PM
ahatanak updated the diff for D41039: Add support for attribute "trivial_abi".

Rename variable to HasTrivialABIOverride.

Jan 5 2018, 7:28 PM
ahatanak added inline comments to D41039: Add support for attribute "trivial_abi".
Jan 5 2018, 7:25 PM
ahatanak updated the diff for D41039: Add support for attribute "trivial_abi".
Jan 5 2018, 7:21 PM
ahatanak updated the diff for D41039: Add support for attribute "trivial_abi".

Check whether the argument is passed indirectly before pushing the cleanup.

Jan 5 2018, 3:21 PM
ahatanak added inline comments to D41039: Add support for attribute "trivial_abi".
Jan 5 2018, 3:04 PM
ahatanak added inline comments to D41039: Add support for attribute "trivial_abi".
Jan 5 2018, 2:26 PM
ahatanak updated the diff for D41039: Add support for attribute "trivial_abi".
Jan 5 2018, 2:21 PM
ahatanak updated the diff for D41039: Add support for attribute "trivial_abi".
  • Serialize/deserialize the bits I added to FunctionDecl and CXXRecordDecl.
  • Enable passing non-trivial structs when clang abi-compat version is 4.0 or lower.
  • Fix a bug in Sema::CheckCompletedCXXClass where the CXXRecordDecl flags were not being set when the class had a defaulted special function. Fixed it by renaming finishedUserProvidedMethod to setTrivialForCallFlags and calling it in Sema::CheckCompletedCXXClass.
Jan 5 2018, 12:35 PM
ahatanak added a comment to D41039: Add support for attribute "trivial_abi".

Sorry, the patch I've just uploaded was missing some changes I made.

Jan 5 2018, 12:25 PM
ahatanak updated the diff for D41039: Add support for attribute "trivial_abi".
Jan 5 2018, 12:21 PM
ahatanak added inline comments to D41039: Add support for attribute "trivial_abi".
Jan 5 2018, 10:21 AM
ahatanak added inline comments to D41039: Add support for attribute "trivial_abi".
Jan 5 2018, 10:12 AM
ahatanak updated the diff for D41039: Add support for attribute "trivial_abi".

Address review comments.

Jan 5 2018, 9:54 AM

Jan 4 2018

ahatanak updated the diff for D41039: Add support for attribute "trivial_abi".

No worries. Upload the patch again.

Jan 4 2018, 5:27 PM
ahatanak updated the diff for D41039: Add support for attribute "trivial_abi".

I've only fixed the places where the bits to track the triviality of special functions are set or reset, so this is still a WIP. I'll update the patch again later today, but let me know if anyone has any feedback in the meantime.

Jan 4 2018, 1:13 PM

Dec 28 2017

ahatanak accepted D41601: Ignore the DISPATCH_NOESCAPE if not defined.

Looks good

Dec 28 2017, 2:22 PM

Dec 27 2017

ahatanak added a comment to D41601: Ignore the DISPATCH_NOESCAPE if not defined.

Thanks for fixing this.

Dec 27 2017, 8:04 PM

Dec 22 2017

ahatanak added inline comments to D41228: [ObjC] Enable __strong pointers in structs under ARC.
Dec 22 2017, 3:52 PM
ahatanak updated the diff for D41228: [ObjC] Enable __strong pointers in structs under ARC.

Rename functions. Check whether a non-trivial type passed to Sema::isValidVarArgType is a struct.

Dec 22 2017, 3:50 PM

Dec 21 2017

ahatanak added inline comments to D41228: [ObjC] Enable __strong pointers in structs under ARC.
Dec 21 2017, 1:12 PM

Dec 20 2017

ahatanak added inline comments to D41228: [ObjC] Enable __strong pointers in structs under ARC.
Dec 20 2017, 8:52 PM
ahatanak updated the diff for D41228: [ObjC] Enable __strong pointers in structs under ARC.
  • Improved IRGen for copying trivial fields in a non-trivial C struct. IRGen in CGNonTrivialStruct.cpp now calls a single memcpy if there are consecutive trivial fields in a struct (it does something similar to what FieldMemcpyizer does)
Dec 20 2017, 7:09 PM

Dec 19 2017

ahatanak added inline comments to D41228: [ObjC] Enable __strong pointers in structs under ARC.
Dec 19 2017, 1:08 PM
ahatanak added inline comments to D41228: [ObjC] Enable __strong pointers in structs under ARC.
Dec 19 2017, 12:54 PM
ahatanak updated the diff for D41228: [ObjC] Enable __strong pointers in structs under ARC.

Address review comments. Changed the mangling of special functions to make it a bit easier to read.

Dec 19 2017, 12:47 PM

Dec 18 2017

ahatanak updated the diff for D41228: [ObjC] Enable __strong pointers in structs under ARC.

Update patch.

Dec 18 2017, 6:28 PM
ahatanak added a comment to D41228: [ObjC] Enable __strong pointers in structs under ARC.

Address review comments.

Dec 18 2017, 6:26 PM

Dec 15 2017

ahatanak updated the diff for D41228: [ObjC] Enable __strong pointers in structs under ARC.

Insert an underscore before src-alignment in the BNF rule for alignment-info.

Dec 15 2017, 6:46 PM
ahatanak updated the diff for D41228: [ObjC] Enable __strong pointers in structs under ARC.

Fixed a bug where the code gets stuck in an infinite loop when a struct with an array field is passed to FieldInfoToString. Encoded the offset of an array in a struct into the function name. Also, added comments that describe the structure of the mangled function name.

Dec 15 2017, 6:41 PM
ahatanak added a comment to D41228: [ObjC] Enable __strong pointers in structs under ARC.

I just found that the code that creates the mangled name for a special function is not correct. Two structs with different record layouts can end up having functions that have the same name.

Dec 15 2017, 2:07 PM

Dec 14 2017

ahatanak created D41228: [ObjC] Enable __strong pointers in structs under ARC.
Dec 14 2017, 1:24 AM

Dec 11 2017

ahatanak added a comment to D41039: Add support for attribute "trivial_abi".

I had a discussion with Duncan today and he pointed out that perhaps we shouldn't allow users to annotate a struct with "trivial_abi" if one of its subobjects is non-trivial and is not annotated with "trivial_abi" since that gives users too much power.

Dec 11 2017, 1:38 PM

Dec 8 2017

ahatanak committed rC320215: [CodeGen][X86] Fix handling of __fp16 vectors..
[CodeGen][X86] Fix handling of __fp16 vectors.
Dec 8 2017, 4:03 PM
ahatanak committed rL320215: [CodeGen][X86] Fix handling of __fp16 vectors..
[CodeGen][X86] Fix handling of __fp16 vectors.
Dec 8 2017, 4:03 PM
ahatanak closed D40112: [CodeGen][X86] Fix handling of __fp16 vectors by committing rL320215: [CodeGen][X86] Fix handling of __fp16 vectors..
Dec 8 2017, 4:03 PM
ahatanak closed D40112: [CodeGen][X86] Fix handling of __fp16 vectors by committing rC320215: [CodeGen][X86] Fix handling of __fp16 vectors..
Dec 8 2017, 4:03 PM
ahatanak created D41039: Add support for attribute "trivial_abi".
Dec 8 2017, 3:37 PM
ahatanak added a comment to D36918: [Sema] Take into account the current context when checking the accessibility of a member function pointer.

ping

Dec 8 2017, 12:17 PM
ahatanak added a comment to D36915: [Sema] Diagnose local variables and parameters captured by lambda and block expressions in a default argument.

ping

Dec 8 2017, 12:16 PM

Dec 6 2017

ahatanak added inline comments to D40864: [Darwin] Add a new -mstack-probe option and enable by default.
Dec 6 2017, 11:45 AM

Dec 5 2017

ahatanak added inline comments to D40864: [Darwin] Add a new -mstack-probe option and enable by default.
Dec 5 2017, 10:14 PM

Dec 4 2017

ahatanak added a comment to D40112: [CodeGen][X86] Fix handling of __fp16 vectors.

Any other comments from anyone?

Dec 4 2017, 8:56 AM

Dec 1 2017

ahatanak updated subscribers of D40686: [MS] Fix __movs intrinsics.

I agree that the test should check the assembly instructions emitted are valid, so an assembly test makes sense.

Dec 1 2017, 10:29 AM

Nov 30 2017

ahatanak added a comment to D40686: [MS] Fix __movs intrinsics.

The changes in intrin.h look good.

Nov 30 2017, 9:41 PM

Nov 27 2017

ahatanak committed rL319123: Insert padding before the __cxa_exception header to ensure the thrown.
Insert padding before the __cxa_exception header to ensure the thrown
Nov 27 2017, 4:37 PM
ahatanak added inline comments to D40112: [CodeGen][X86] Fix handling of __fp16 vectors.
Nov 27 2017, 12:08 PM

Nov 25 2017

ahatanak accepted D39913: [ObjC] warn about availability attributes missing from a method's declaration when they're specified for a method's definition .

LGTM

Nov 25 2017, 12:10 AM

Nov 15 2017

ahatanak created D40112: [CodeGen][X86] Fix handling of __fp16 vectors.
Nov 15 2017, 4:46 PM

Nov 13 2017

ahatanak added a comment to D39913: [ObjC] warn about availability attributes missing from a method's declaration when they're specified for a method's definition .

Is it not necessary to print a diagnostic when a non-member function declaration is missing an availability attribute?

Nov 13 2017, 7:34 PM

Nov 9 2017

ahatanak added a comment to D39870: [sanitizer] Allow sanitizers to redefine implementation of signal interceptors.

This caused a bot failure:

Nov 9 2017, 4:22 PM

Nov 8 2017

ahatanak accepted D39776: [libcxx] Mark test cxa_deleted_virtual.pass.cpp as failing for previous libcxx versions..

LGTM

Nov 8 2017, 6:55 AM

Nov 7 2017

ahatanak accepted D39762: [ObjC] Boxed strings should use the nullability from stringWithUTF8String's return type.

LGTM

Nov 7 2017, 5:44 PM
ahatanak added a comment to D28907: [SLP] Fix for PR30787: Failure to beneficially vectorize 'copyable' elements in integer binary ops..

I don't know what is wrong, but it looks like an assertion is failing when SLPVectorizerPass is run:

Nov 7 2017, 3:21 PM