I'm still not sure why __fp16, which is a storage-only type, is used for the element type of float16x4_t if we want to avoid promotion to a float vector type.

Dec 17 2019, 6:55 PM

Dec 13 2019

ahatanak committed rGa0a670614a36: Call objc_retainBlock before passing a block as a variadic argument (authored by ahatanak).

Call objc_retainBlock before passing a block as a variadic argument

Dec 13 2019, 1:18 PM

ahatanak closed D71431: Call objc_retainBlock before passing a block as a variadic argument.

Dec 13 2019, 1:18 PM · Restricted Project

ahatanak added inline comments to D71431: Call objc_retainBlock before passing a block as a variadic argument.

Dec 13 2019, 1:00 PM · Restricted Project

ahatanak updated the diff for D71431: Call objc_retainBlock before passing a block as a variadic argument.

Explain why this change is needed in ARC documentation.

Dec 13 2019, 12:42 PM · Restricted Project

Dec 12 2019

ahatanaka <ahatanaka@apple.com> committed rG3cd11f96b3d9: Don't add optnone or noinline if the function is already marked as… (authored by ahatanak).

Don't add optnone or noinline if the function is already marked as…

Dec 12 2019, 3:55 PM

ahatanak committed rG88d5c0055251: Merge commit 'refs/am/changes/c1d2927cc64731520e60ecd1fc0e0eeabdfbac40_apple/ma… (authored by ahatanak).

Merge commit 'refs/am/changes/c1d2927cc64731520e60ecd1fc0e0eeabdfbac40_apple/ma…

Dec 12 2019, 3:35 PM

ahatanak committed rGfccc03fdc27b: Fix merge error. (authored by ahatanak).

Fix merge error.

Dec 12 2019, 3:35 PM

ahatanak committed rG3a81b82ff41d: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by ahatanak).

Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift

Dec 12 2019, 1:46 PM

ahatanak committed rG6bdec82d103f: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by ahatanak).

Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift

Dec 12 2019, 1:45 PM

ahatanak committed rGfde68e5481c0: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by ahatanak).

Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift

Dec 12 2019, 1:39 PM

ahatanak committed rG610643a54e8c: Fix more merge errors that were introduced in… (authored by ahatanak).

Fix more merge errors that were introduced in…

Dec 12 2019, 12:49 PM

ahatanak committed rG11b8bbe3024a: Fix more merge errors that were introduced in… (authored by ahatanak).

Fix more merge errors that were introduced in…

Dec 12 2019, 12:49 PM

ahatanak committed rGc394085138dd: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by ahatanak).

Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift

Dec 12 2019, 12:49 PM

ahatanak committed rG2e4b15fc6bde: Remove duplicate function definitions and fix merge error in… (authored by ahatanak).

Remove duplicate function definitions and fix merge error in…

Dec 12 2019, 12:49 PM

ahatanak created D71431: Call objc_retainBlock before passing a block as a variadic argument.

Dec 12 2019, 12:48 PM · Restricted Project

ahatanak committed rG5ec09527b9d5: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by ahatanak).

Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift

Dec 12 2019, 12:48 PM

ahatanak committed rGa045c8edd99f: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by ahatanak).

Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift

Dec 12 2019, 12:43 PM

Dec 11 2019

ahatanak committed rG7292c2823063: Fix an error in the block ABI documentation sample code (authored by ahatanak).

Fix an error in the block ABI documentation sample code

Dec 11 2019, 11:21 PM

Dec 9 2019

ahatanak added a reverting change for rG88f5bf77f928: [compiler-rt] Add a critical section when flushing gcov counters: rG78a7af456dbb: Revert "[compiler-rt] Add a critical section when flushing gcov counters".

Dec 9 2019, 8:03 PM

ahatanak committed rG78a7af456dbb: Revert "[compiler-rt] Add a critical section when flushing gcov counters" (authored by ahatanak).

Revert "[compiler-rt] Add a critical section when flushing gcov counters"

Dec 9 2019, 8:03 PM

ahatanak added a comment to D70910: [compiler-rt] Add a critical section when flushing gcov counters.

I've reverted this patch:

Dec 9 2019, 8:03 PM · Restricted Project, Restricted Project

ahatanak added a comment to D70910: [compiler-rt] Add a critical section when flushing gcov counters.

This has broken http://lab.llvm.org:8080/green/job/clang-stage1-RA/4401.

Dec 9 2019, 2:09 PM · Restricted Project, Restricted Project

Dec 6 2019

ahatanak committed rGa7bdab2e9d59: [clang-tidy] Pass -faligned-allocation on the compiler command line to fix… (authored by ahatanak).

[clang-tidy] Pass -faligned-allocation on the compiler command line to fix…

Dec 6 2019, 12:34 PM

Dec 3 2019

ahatanak closed D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs.

Fixed in d8136f14f125fb27f2326f397df0964bf62078ca

Dec 3 2019, 11:58 PM · Restricted Project

ahatanak committed rGd8136f14f125: [CodeGen][ObjC] Emit a primitive store to store a __strong field in… (authored by ahatanak).

[CodeGen][ObjC] Emit a primitive store to store a __strong field in…

Dec 3 2019, 11:49 PM

ahatanak updated the diff for D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs.

Call EmitStoreThroughLValue and EmitLoadOfLValue only when the lvalue is a bitfield.

Dec 3 2019, 7:13 PM · Restricted Project

ahatanak added inline comments to D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs.

Dec 3 2019, 7:13 PM · Restricted Project

ahatanak committed rGf139ae3d9379: [NFC] Pass a reference to CodeGenFunction to methods of LValue and AggValueSlot (authored by ahatanak).

[NFC] Pass a reference to CodeGenFunction to methods of LValue and AggValueSlot

Dec 3 2019, 3:24 PM

ahatanak added inline comments to rG8a5b7c35709d: [NFC] Pass a reference to CodeGenFunction to methods of LValue and AggValueSlot.

Dec 3 2019, 1:21 PM

ahatanak committed rG9f37c0e703c0: Revert "[NFC] Pass a reference to CodeGenFunction to methods of LValue and" (authored by ahatanak).

Revert "[NFC] Pass a reference to CodeGenFunction to methods of LValue and"

Dec 3 2019, 1:12 PM

ahatanak added a reverting change for rG8a5b7c35709d: [NFC] Pass a reference to CodeGenFunction to methods of LValue and AggValueSlot: rG9f37c0e703c0: Revert "[NFC] Pass a reference to CodeGenFunction to methods of LValue and".

Dec 3 2019, 1:12 PM

ahatanak committed rG8a5b7c35709d: [NFC] Pass a reference to CodeGenFunction to methods of LValue and AggValueSlot (authored by ahatanak).

[NFC] Pass a reference to CodeGenFunction to methods of LValue and AggValueSlot

Dec 3 2019, 11:38 AM

Dec 2 2019

ahatanak added a comment to D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs.

Note that passing isInit=true to EmitStoreThroughLValue to make it emit llvm.objc.retain would be incorrect since the callee destructs the struct argument.

Dec 2 2019, 6:12 PM · Restricted Project

ahatanak created D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs.

Dec 2 2019, 6:05 PM · Restricted Project

Dec 1 2019

ahatanak added a comment to rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector".

The test is failing because float16x4_t is defined as a vector of __fp16 in arm_neon.h and Sema promotes vectors of __fp16 to vectors of float since __fp16 is a storage-only type. The test used to pass because of a bug in function isVector, which was fixed in the commit that was reverted.

Dec 1 2019, 10:25 PM

Nov 22 2019

ahatanak updated subscribers of rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector".

Nov 22 2019, 3:11 PM

ahatanak updated subscribers of rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector".

@az and @SjoerdMeijer, can we add -fnative-half-type to the command line of arm-v8.2a-neon-intrinsics.c and aarch64-v8.2a-neon-intrinsics.c? I think the fp16 intrinsics can only be used when there is native hardware support for the type. If we do so, we will probably have to make changes to the driver too.

Nov 22 2019, 3:11 PM

ahatanak added a reverting change for rGa6150b48cea0: [Sema] Use the canonical type in function isVector: rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector".

Nov 22 2019, 1:57 PM

ahatanak committed rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector" (authored by ahatanak).

Revert "[Sema] Use the canonical type in function isVector"

Nov 22 2019, 1:57 PM

ahatanak committed rGa6150b48cea0: [Sema] Use the canonical type in function isVector (authored by ahatanak).

[Sema] Use the canonical type in function isVector

Nov 22 2019, 1:02 PM

Nov 18 2019

ahatanak added a comment to D70370: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls.

I think I agree with you. isSafeBetweenRVCalls seems too conservative. I can't think of a case where we aren't allowed to remove the pair of instructions because the instructions you listed exist between the pair (and that includes opaque calls). But John probably knows better whether that is safe or not.

Nov 18 2019, 7:40 PM · Restricted Project

ahatanak added a comment to D70370: llvm/ObjCARC: Eliminate inlined AutoreleaseRV calls.

It wasn't clear to me, but is the pair deleted only if there are no instructions that return false for isSafeBetweenRVCalls in between?

Nov 18 2019, 11:45 AM · Restricted Project