Page MenuHomePhabricator

ahatanak (Akira Hatanaka)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 4 2013, 1:37 PM (262 w, 6 d)

Recent Activity

Yesterday

ahatanak added a comment to D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context..

Sorry, please ignore my previous comment. I was looking at the wrong place.

Tue, Dec 18, 3:15 PM · Restricted Project
ahatanak added a comment to D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context..

Here are a couple of examples I found running the regression tests:

Tue, Dec 18, 12:52 PM · Restricted Project

Fri, Dec 14

ahatanak added inline comments to D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context..
Fri, Dec 14, 10:56 PM · Restricted Project
ahatanak updated the diff for D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context..

Call CheckPlaceholderExpr instead of pushing an unevaluated evaluation context.

Fri, Dec 14, 10:49 PM · Restricted Project
ahatanak added a comment to D55544: Warning: objc-encodings-larger-than=.

The patch looks largely fine to me.

Fri, Dec 14, 4:41 PM · Restricted Project

Thu, Dec 13

ahatanak created D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context..
Thu, Dec 13, 11:20 AM · Restricted Project
ahatanak added a comment to D55659: [Sema][ObjC] Disallow non-trivial C struct fields in unions.

Just to clarify, this patch doesn't change clang's handling of C++ unions that have non-static data members with non-trivial special member functions.

Thu, Dec 13, 9:51 AM · Restricted Project
ahatanak created D55659: [Sema][ObjC] Disallow non-trivial C struct fields in unions.
Thu, Dec 13, 9:33 AM · Restricted Project

Mon, Dec 10

ahatanak added a comment to D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called.

ping

Mon, Dec 10, 8:50 AM

Sun, Dec 9

ahatanak accepted D55348: Change the objc ARC optimizer to use the new objc.* intrinsics.

LGTM

Sun, Dec 9, 11:19 PM

Tue, Dec 4

ahatanak accepted D55233: Add objc_retain and objc_release intrinsics and codegen them to their runtime methods.

LGTM

Tue, Dec 4, 10:04 AM

Mon, Dec 3

ahatanak added inline comments to D55233: Add objc_retain and objc_release intrinsics and codegen them to their runtime methods.
Mon, Dec 3, 4:37 PM

Fri, Nov 30

ahatanak updated the diff for D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called.

I've reverted the changes I made to test/SemaCUDA/call-host-fn-from-device.cu since r342749 fixed the overload resolution bug.

Fri, Nov 30, 3:19 PM

Nov 14 2018

ahatanak added a comment to D54539: [CodeGen] Replace '@' characters in block descriptors' symbol names with '\1' on ELF targets..

This should not be changing the actual @-encoding value. If we want to use the @-encoding in the symbol name, we can change it when naming the symbol, provided that \1 is not legal in the @encoding.

Nov 14 2018, 2:37 PM · Restricted Project
ahatanak created D54539: [CodeGen] Replace '@' characters in block descriptors' symbol names with '\1' on ELF targets..
Nov 14 2018, 12:53 PM · Restricted Project

Nov 5 2018

ahatanak committed rL346212: Cast to uint64_t instead of to unsigned..
Cast to uint64_t instead of to unsigned.
Nov 5 2018, 11:15 PM
ahatanak committed rC346212: Cast to uint64_t instead of to unsigned..
Cast to uint64_t instead of to unsigned.
Nov 5 2018, 11:15 PM
ahatanak committed rL346211: os_log: Allow specifying mask type in format string..
os_log: Allow specifying mask type in format string.
Nov 5 2018, 11:07 PM
ahatanak committed rC346211: os_log: Allow specifying mask type in format string..
os_log: Allow specifying mask type in format string.
Nov 5 2018, 11:07 PM
ahatanak committed rL346210: os_log: Add a new privacy annotation "sensitive"..
os_log: Add a new privacy annotation "sensitive".
Nov 5 2018, 10:28 PM
ahatanak committed rC346210: os_log: Add a new privacy annotation "sensitive"..
os_log: Add a new privacy annotation "sensitive".
Nov 5 2018, 10:28 PM
ahatanak committed rC346209: os_log: Minor code cleanups. NFC..
os_log: Minor code cleanups. NFC.
Nov 5 2018, 9:43 PM
ahatanak committed rL346209: os_log: Minor code cleanups. NFC..
os_log: Minor code cleanups. NFC.
Nov 5 2018, 9:43 PM

Oct 30 2018

ahatanak added a comment to D53860: [SemaCXX] Don't check base's dtor is accessible.

http://wg21.link/p0968r0#2227 says:

Oct 30 2018, 11:19 AM

Oct 20 2018

ahatanak committed rCTE344856: Check that __MAC_OS_X_VERSION_MIN_REQUIRED is defined before checking.
Check that __MAC_OS_X_VERSION_MIN_REQUIRED is defined before checking
Oct 20 2018, 10:38 AM
ahatanak committed rL344856: Check that __MAC_OS_X_VERSION_MIN_REQUIRED is defined before checking.
Check that __MAC_OS_X_VERSION_MIN_REQUIRED is defined before checking
Oct 20 2018, 10:37 AM

Oct 19 2018

ahatanak committed rC344833: [CodeGen] Use the mangle context owned by CodeGenModule to correctly.
[CodeGen] Use the mangle context owned by CodeGenModule to correctly
Oct 19 2018, 10:47 PM
ahatanak committed rL344833: [CodeGen] Use the mangle context owned by CodeGenModule to correctly.
[CodeGen] Use the mangle context owned by CodeGenModule to correctly
Oct 19 2018, 10:47 PM
ahatanak committed rCTE344827: Disable unittests/clangd/JSONTransportTests.cpp on versions of macosx.
Disable unittests/clangd/JSONTransportTests.cpp on versions of macosx
Oct 19 2018, 7:14 PM
ahatanak committed rL344827: Disable unittests/clangd/JSONTransportTests.cpp on versions of macosx.
Disable unittests/clangd/JSONTransportTests.cpp on versions of macosx
Oct 19 2018, 7:13 PM

Oct 11 2018

ahatanak added a comment to D53154: [CodeGen] Handle extern references to OBJC_CLASS_$_*.

LGTM

Oct 11 2018, 11:24 PM

Oct 1 2018

ahatanak committed rC343556: [CodeGen] Before entering the loop that copies a non-trivial array field.
[CodeGen] Before entering the loop that copies a non-trivial array field
Oct 1 2018, 6:02 PM
ahatanak committed rL343556: [CodeGen] Before entering the loop that copies a non-trivial array field.
[CodeGen] Before entering the loop that copies a non-trivial array field
Oct 1 2018, 6:02 PM
ahatanak committed rL343542: Distinguish `__block` variables that are captured by escaping blocks.
Distinguish `__block` variables that are captured by escaping blocks
Oct 1 2018, 2:54 PM
ahatanak committed rC343542: Distinguish `__block` variables that are captured by escaping blocks.
Distinguish `__block` variables that are captured by escaping blocks
Oct 1 2018, 2:54 PM
ahatanak committed rL343531: Revert r343518..
Revert r343518.
Oct 1 2018, 1:31 PM
ahatanak committed rC343531: Revert r343518..
Revert r343518.
Oct 1 2018, 1:31 PM
ahatanak committed rL343518: Distinguish `__block` variables that are captured by escaping blocks.
Distinguish `__block` variables that are captured by escaping blocks
Oct 1 2018, 11:52 AM
ahatanak committed rC343518: Distinguish `__block` variables that are captured by escaping blocks.
Distinguish `__block` variables that are captured by escaping blocks
Oct 1 2018, 11:52 AM

Sep 8 2018

ahatanak committed rL341757: Revert r341754..
Revert r341754.
Sep 8 2018, 10:24 PM
ahatanak committed rC341757: Revert r341754..
Revert r341754.
Sep 8 2018, 10:24 PM
ahatanak committed rC341754: Distinguish `__block` variables that are captured by escaping blocks.
Distinguish `__block` variables that are captured by escaping blocks
Sep 8 2018, 1:06 PM
ahatanak committed rL341754: Distinguish `__block` variables that are captured by escaping blocks.
Distinguish `__block` variables that are captured by escaping blocks
Sep 8 2018, 1:06 PM
ahatanak closed D51564: Distinguish `__block` variables that are captured by escaping blocks from those that aren't.
Sep 8 2018, 1:06 PM

Sep 6 2018

ahatanak committed rL341629: [Sema] Check that the destructor for each element of class type is.
[Sema] Check that the destructor for each element of class type is
Sep 6 2018, 7:39 PM
ahatanak committed rC341629: [Sema] Check that the destructor for each element of class type is.
[Sema] Check that the destructor for each element of class type is
Sep 6 2018, 7:39 PM
ahatanak closed D45898: [SemaCXX] Mark destructor as referenced .
Sep 6 2018, 7:39 PM

Sep 5 2018

ahatanak added inline comments to D51564: Distinguish `__block` variables that are captured by escaping blocks from those that aren't.
Sep 5 2018, 10:32 AM
ahatanak updated the diff for D51564: Distinguish `__block` variables that are captured by escaping blocks from those that aren't.

Address review comments. Fix bugs in the handling of __block variables that have reference types.

Sep 5 2018, 10:32 AM

Sep 4 2018

ahatanak added inline comments to D45898: [SemaCXX] Mark destructor as referenced .
Sep 4 2018, 11:07 AM
ahatanak updated the diff for D45898: [SemaCXX] Mark destructor as referenced .

Point the diagnostic at either the relevant init list element or at the close brace.

Sep 4 2018, 11:07 AM

Aug 31 2018

ahatanak created D51564: Distinguish `__block` variables that are captured by escaping blocks from those that aren't.
Aug 31 2018, 6:11 PM
ahatanak updated the diff for D45898: [SemaCXX] Mark destructor as referenced .

Move the call that checks the element's destructor into InitListChecker::CheckStructUnionTypes.

Aug 31 2018, 5:36 PM
ahatanak added a comment to D50783: [CodeGen] Merge identical block descriptor global variables.

The GNUstep documentation I found replaces '@' with '\1'. Would that fix the problem?

Aug 31 2018, 11:36 AM

Aug 30 2018

ahatanak added a comment to D45898: [SemaCXX] Mark destructor as referenced .

ping

Aug 30 2018, 6:45 PM

Aug 28 2018

ahatanak committed rC340854: Define variables in test case rather than using values from functions.
Define variables in test case rather than using values from functions
Aug 28 2018, 11:19 AM
ahatanak committed rL340854: Define variables in test case rather than using values from functions.
Define variables in test case rather than using values from functions
Aug 28 2018, 11:19 AM

Aug 23 2018

ahatanak added a comment to D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called.
In D47757#1211276, @tra wrote:

I've confirmed that the patch does not break anything in our CUDA code, so it's good to go as far as CUDA is concerned.

Aug 23 2018, 4:05 PM

Aug 22 2018

ahatanak committed rC340408: [CodeGen] Look at the type of a block capture field rather than the type.
[CodeGen] Look at the type of a block capture field rather than the type
Aug 22 2018, 6:42 AM
ahatanak committed rL340408: [CodeGen] Look at the type of a block capture field rather than the type.
[CodeGen] Look at the type of a block capture field rather than the type
Aug 22 2018, 6:42 AM
ahatanak closed D51025: [CodeGen] Fix handling of variables captured by a block that is nested inside a lambda.
Aug 22 2018, 6:42 AM

Aug 21 2018

ahatanak accepted D51043: [clang][NFC] Fix typo in the name of a note.

Thanks. Yes, it's a typo.

Aug 21 2018, 8:52 AM

Aug 20 2018

ahatanak created D51025: [CodeGen] Fix handling of variables captured by a block that is nested inside a lambda.
Aug 20 2018, 11:53 PM

Aug 17 2018

ahatanak added a comment to D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called.

The code you showed does compile with or without -fcuda-is-device after applying my patch.

Aug 17 2018, 2:08 PM
ahatanak added a comment to D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called.
In D47757#1204561, @tra wrote:

It's a regression. There's a decent chance it breaks someone and this patch, if committed by itself, will end up being rolled back.

Aug 17 2018, 12:57 PM
ahatanak added a comment to D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called.

@tra and @rsmith: Can we move forward and fix the incorrect cuda diagnostics in a separate patch?

Aug 17 2018, 11:46 AM
ahatanak committed rC340041: [CodeGen] Merge identical block descriptor global variables..
[CodeGen] Merge identical block descriptor global variables.
Aug 17 2018, 8:47 AM
ahatanak committed rL340041: [CodeGen] Merge identical block descriptor global variables..
[CodeGen] Merge identical block descriptor global variables.
Aug 17 2018, 8:47 AM
ahatanak closed D50783: [CodeGen] Merge identical block descriptor global variables.
Aug 17 2018, 8:47 AM
ahatanak closed D50783: [CodeGen] Merge identical block descriptor global variables.
Aug 17 2018, 8:47 AM

Aug 16 2018

ahatanak updated the diff for D50783: [CodeGen] Merge identical block descriptor global variables.

Mark the block descriptor global variable as unnamed_addr.

Aug 16 2018, 7:36 PM
ahatanak added inline comments to D50783: [CodeGen] Merge identical block descriptor global variables.
Aug 16 2018, 4:24 PM
ahatanak updated the diff for D50783: [CodeGen] Merge identical block descriptor global variables.

Try harder to shorten the names of block descriptor global variables.

Aug 16 2018, 3:57 PM

Aug 15 2018

ahatanak added a comment to D50783: [CodeGen] Merge identical block descriptor global variables.

A few points I forgot to mention:

Aug 15 2018, 9:38 AM
ahatanak created D50783: [CodeGen] Merge identical block descriptor global variables.
Aug 15 2018, 8:23 AM

Aug 13 2018

ahatanak committed rL339633: [CodeGen] Before returning a copy/dispose helper function, bitcast it to.
[CodeGen] Before returning a copy/dispose helper function, bitcast it to
Aug 13 2018, 5:16 PM
ahatanak committed rC339633: [CodeGen] Before returning a copy/dispose helper function, bitcast it to.
[CodeGen] Before returning a copy/dispose helper function, bitcast it to
Aug 13 2018, 5:16 PM
ahatanak committed rL339632: Fix check strings in test/CodeGenObjC/arc-blocks.m in preperation for.
Fix check strings in test/CodeGenObjC/arc-blocks.m in preperation for
Aug 13 2018, 5:16 PM
ahatanak committed rC339632: Fix check strings in test/CodeGenObjC/arc-blocks.m in preperation for.
Fix check strings in test/CodeGenObjC/arc-blocks.m in preperation for
Aug 13 2018, 5:16 PM
ahatanak committed rL339613: Convert if/else to a switch. NFC..
Convert if/else to a switch. NFC.
Aug 13 2018, 2:00 PM
ahatanak committed rC339613: Convert if/else to a switch. NFC..
Convert if/else to a switch. NFC.
Aug 13 2018, 2:00 PM

Aug 10 2018

ahatanak committed rC339452: Make changes to the check strings so that the test I modified in r339438.
Make changes to the check strings so that the test I modified in r339438
Aug 10 2018, 10:08 AM
ahatanak committed rL339452: Make changes to the check strings so that the test I modified in r339438.
Make changes to the check strings so that the test I modified in r339438
Aug 10 2018, 10:07 AM
ahatanak committed rL339438: [CodeGen] Merge equivalent block copy/helper functions..
[CodeGen] Merge equivalent block copy/helper functions.
Aug 10 2018, 8:10 AM
ahatanak committed rC339438: [CodeGen] Merge equivalent block copy/helper functions..
[CodeGen] Merge equivalent block copy/helper functions.
Aug 10 2018, 8:10 AM
ahatanak closed D50152: [CodeGen] Merge equivalent block copy/helper functions.
Aug 10 2018, 8:10 AM

Aug 9 2018

ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Replace the two flags, EHOnly and DisposeCannotThrow, passed to pushCaptureCleanup with a single flag ForCopyHelper.

Aug 9 2018, 9:00 PM
ahatanak updated the diff for D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called.

Call MarkFunctionReferenced to mark the function __builtin_operator_new or __builtin_operator_delete will call as referenced.

Aug 9 2018, 7:02 PM
ahatanak added inline comments to D50152: [CodeGen] Merge equivalent block copy/helper functions.
Aug 9 2018, 5:52 PM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Define functions inline in the header file.

Aug 9 2018, 5:51 PM
ahatanak added a comment to D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called.

ping

Aug 9 2018, 10:02 AM
ahatanak added inline comments to D50152: [CodeGen] Merge equivalent block copy/helper functions.
Aug 9 2018, 7:50 AM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Address review comments.

Aug 9 2018, 7:49 AM

Aug 8 2018

ahatanak added inline comments to D50152: [CodeGen] Merge equivalent block copy/helper functions.
Aug 8 2018, 7:49 PM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Address review comments.

Aug 8 2018, 7:49 PM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Modify getBlockVarCopyInits and setBlockVarCopyInits to get and set both the copy expression and the boolean flag that indicates whether the expression can throw or not.

Aug 8 2018, 2:40 PM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Change the value type of BlockVarCopyInits to PointerIntPair<Expr *, 1, bool>. The boolean flag indicates whether the copy expression can throw. Serialize/deserialize the copy expression and the boolean flag and add a regression test to test/PCH.

Aug 8 2018, 11:33 AM

Aug 7 2018

ahatanak added a comment to D50152: [CodeGen] Merge equivalent block copy/helper functions.

Since BlockVarCopyInits is a map with key VarDecl *, I think we want to add a flag to VarDecl (NonParmVarDeclBits) that indicates whether the copy expression can throw or not. Or is there a reason to store the bit in BlockDecl::Capture instead?

Aug 7 2018, 7:46 PM
ahatanak added a comment to D50152: [CodeGen] Merge equivalent block copy/helper functions.

I thought it was okay to skip the work done by ResolveExceptionSpec in IRGen as long as the exception specifications that are needed have already been resolved in Sema. But calling Sema::canThrow in Sema::CheckCompleteVariableDeclaration and storing the result in BlockDecl::Capture is clearly the better solution since it doesn't introduce the complexity introduced in the updated patch.

Aug 7 2018, 11:49 AM
ahatanak updated the diff for D50152: [CodeGen] Merge equivalent block copy/helper functions.

Remove a stale comment and add an assertion to check the destructor's exception specification has been resolved.

Aug 7 2018, 11:03 AM