Page MenuHomePhabricator

ahatanak (Akira Hatanaka)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 4 2013, 1:37 PM (485 w, 4 d)

Recent Activity

Mon, Mar 13

ahatanak accepted D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable..

LGTM

Mon, Mar 13, 9:05 AM · Restricted Project, Restricted Project

Thu, Mar 9

ahatanak added a comment to D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind.

clang marks the called function foo in p1.cpp as nounwind here: https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CodeGenFunction.cpp#L1284

Thu, Mar 9, 7:09 AM · Restricted Project, Restricted Project

Tue, Mar 7

ahatanak added inline comments to D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable..
Tue, Mar 7, 1:58 PM · Restricted Project, Restricted Project
ahatanak added inline comments to D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable..
Tue, Mar 7, 1:51 PM · Restricted Project, Restricted Project

Tue, Feb 28

ahatanak added inline comments to D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable..
Tue, Feb 28, 2:44 PM · Restricted Project, Restricted Project

Feb 24 2023

ahatanak added a reverting change for rGb1613f05ae0c: [NFC] Store Address's alignment into PointerIntPairs: rGe419e22ff6fd: [CodeGen] Stop storing alignment information into pointers in Address.
Feb 24 2023, 10:37 AM
ahatanak committed rGe419e22ff6fd: [CodeGen] Stop storing alignment information into pointers in Address (authored by ahatanak).
[CodeGen] Stop storing alignment information into pointers in Address
Feb 24 2023, 10:37 AM · Restricted Project, Restricted Project
ahatanak added a reverting change for D117262: [NFC] Store Address's alignment into PointerIntPairs: rGe419e22ff6fd: [CodeGen] Stop storing alignment information into pointers in Address.
Feb 24 2023, 10:37 AM · Restricted Project
ahatanak closed D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers.
Feb 24 2023, 10:37 AM · Restricted Project, Restricted Project
ahatanak updated the diff for D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers.

Remove AddressImpl altogether.

Feb 24 2023, 8:37 AM · Restricted Project, Restricted Project

Feb 23 2023

ahatanak added a comment to D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers.

I don't have a test case for this change because there is a bug that prevents using the maximum allowed alignment (see https://github.com/llvm/llvm-project/issues/60752).

Feb 23 2023, 4:41 PM · Restricted Project, Restricted Project
ahatanak added a reverting change for rGb1613f05ae0c: [NFC] Store Address's alignment into PointerIntPairs: D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers.
Feb 23 2023, 4:39 PM
ahatanak requested review of D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers.
Feb 23 2023, 4:39 PM · Restricted Project, Restricted Project
ahatanak added a reverting change for D117262: [NFC] Store Address's alignment into PointerIntPairs: D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers.
Feb 23 2023, 4:39 PM · Restricted Project

Feb 17 2023

ahatanak added inline comments to D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.
Feb 17 2023, 3:58 PM · Restricted Project, Restricted Project

Feb 16 2023

ahatanak committed rGcda4a0e918b5: [Sema] Relax a failing assertion in TransformBlockExpr (authored by ahatanak).
[Sema] Relax a failing assertion in TransformBlockExpr
Feb 16 2023, 6:41 PM · Restricted Project, Restricted Project
ahatanak closed D144016: [Sema] Relax a failing assertion in TransformBlockExpr.
Feb 16 2023, 6:40 PM · Restricted Project, Restricted Project
ahatanak added inline comments to D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.
Feb 16 2023, 6:23 PM · Restricted Project, Restricted Project
ahatanak updated subscribers of D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.
Feb 16 2023, 6:17 PM · Restricted Project, Restricted Project

Feb 15 2023

ahatanak added inline comments to D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.
Feb 15 2023, 5:11 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D144016: [Sema] Relax a failing assertion in TransformBlockExpr.

Add triple to the test and add release note for the fix.

Feb 15 2023, 1:16 PM · Restricted Project, Restricted Project
ahatanak committed rG57865bc5ad27: [CodeGen] Add a flag to `Address` and `Lvalue` that is used to keep (authored by ahatanak).
[CodeGen] Add a flag to `Address` and `Lvalue` that is used to keep
Feb 15 2023, 10:17 AM · Restricted Project, Restricted Project
ahatanak closed D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.
Feb 15 2023, 10:17 AM · Restricted Project, Restricted Project
ahatanak updated the diff for D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.

Fix type and add comment. Remove unnecessary cast.

Feb 15 2023, 10:07 AM · Restricted Project, Restricted Project
ahatanak added a comment to D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument.

@tahonermann @cor3ntin have you had a chance to take a look at the updated patch?

Feb 15 2023, 9:42 AM · Restricted Project, Restricted Project

Feb 14 2023

ahatanak updated the diff for D144016: [Sema] Relax a failing assertion in TransformBlockExpr.

Add comment.

Feb 14 2023, 7:08 PM · Restricted Project, Restricted Project
ahatanak requested review of D144016: [Sema] Relax a failing assertion in TransformBlockExpr.
Feb 14 2023, 8:06 AM · Restricted Project, Restricted Project

Feb 9 2023

ahatanak added inline comments to D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.
Feb 9 2023, 6:34 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.
  • Set the KnownNonNull bit correctly when Address::withAlignment is called.
  • Pass NotKnownNonNull to the call to Addr.withPointer when the address of thread local storage is created.
Feb 9 2023, 6:27 PM · Restricted Project, Restricted Project
ahatanak added inline comments to D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.
Feb 9 2023, 8:25 AM · Restricted Project, Restricted Project
ahatanak added inline comments to D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.
Feb 9 2023, 7:54 AM · Restricted Project, Restricted Project
ahatanak updated the diff for D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.

Address review comments.

Feb 9 2023, 7:54 AM · Restricted Project, Restricted Project

Feb 7 2023

ahatanak added a comment to D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument.

I agree that pushing an empty scope without initializing any of its members seems wrong.

Feb 7 2023, 1:12 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument.

Fix indentation.

Feb 7 2023, 12:50 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument.

Instead of pushing an empty lambda scope, switch to the enclosing context if the variable is used in a default argument expression of a lambda call operator.

Feb 7 2023, 12:44 PM · Restricted Project, Restricted Project

Feb 6 2023

ahatanak added a comment to D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.

@efriedma do you have any comments?

Feb 6 2023, 7:24 PM · Restricted Project, Restricted Project

Feb 2 2023

ahatanak added a comment to D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument.

I'm still don't understand what the problem is about cleaning up the lambda scope.

Feb 2 2023, 9:52 AM · Restricted Project, Restricted Project

Feb 1 2023

ahatanak added a comment to D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument.

Doesn't Sema::FunctionScopeRAII pop the lambda scope when it goes out of scope?

Feb 1 2023, 2:44 PM · Restricted Project, Restricted Project
ahatanak requested review of D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument.
Feb 1 2023, 2:02 PM · Restricted Project, Restricted Project

Jan 27 2023

ahatanak updated the diff for D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.

Pass a KnownNonNull_t flag to Address::withPointer.

Jan 27 2023, 4:02 PM · Restricted Project, Restricted Project
ahatanak added inline comments to D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.
Jan 27 2023, 2:34 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.

Fix a few typos that were causing compile errors.

Jan 27 2023, 11:33 AM · Restricted Project, Restricted Project
ahatanak added a comment to D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.

There are more places where we know contextually the pointer can't be null and can set the bit to KnownNonNull or set the bit of an LValue or Address using an existing Address's KnownNonNull bit.

Jan 27 2023, 10:44 AM · Restricted Project, Restricted Project
ahatanak updated the diff for D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.

Add a bit to Address and LValue that tracks whether the pointer is known not to be null.

Jan 27 2023, 10:40 AM · Restricted Project, Restricted Project

Jan 26 2023

ahatanak added inline comments to D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.
Jan 26 2023, 12:45 PM · Restricted Project, Restricted Project

Jan 25 2023

ahatanak requested review of D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null.
Jan 25 2023, 2:50 PM · Restricted Project, Restricted Project

Jan 23 2023

ahatanak accepted D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens.

I'm not familiar with the WinEH stuff, but the other parts (the code that adds bundles, etc.) LGTM.

Jan 23 2023, 6:41 AM · Restricted Project, Restricted Project, Restricted Project

Jan 5 2023

ahatanak added inline comments to D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file.
Jan 5 2023, 11:05 PM · Restricted Project, Restricted Project
ahatanak committed rG34aa2e24c89a: Save the result of getenv() to a string (authored by ahatanak).
Save the result of getenv() to a string
Jan 5 2023, 11:00 PM · Restricted Project, Restricted Project
ahatanak committed rG143ec502e985: [Sema] Fix a bug where clang doesn't detect uses of unavailable decls (authored by ahatanak).
[Sema] Fix a bug where clang doesn't detect uses of unavailable decls
Jan 5 2023, 8:36 PM · Restricted Project, Restricted Project
ahatanak closed D127442: [Sema] Fix a bug where clang doesn't detect uses of unavailable decls in C++ base or member initializers.
Jan 5 2023, 8:36 PM · Restricted Project, Restricted Project
ahatanak committed rGea0cd51a4958: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C (authored by ahatanak).
[CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C
Jan 5 2023, 8:03 PM · Restricted Project, Restricted Project
ahatanak closed D136639: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C struct property is set using dot notation.
Jan 5 2023, 8:03 PM · Restricted Project, Restricted Project
ahatanak added a comment to D136639: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C struct property is set using dot notation.

Oh, I see. That's a really unfortunate way to end up emitting this code pattern, since ignoring the result is so common. To fix that, we'd have to either figure out the result was unused in Sema or do a relatively complex analysis in IRGen, though.

Jan 5 2023, 7:46 PM · Restricted Project, Restricted Project
ahatanak accepted D139713: [Sema] Fix crash when evaluating nested call with value-dependent arg.
LGTM
Jan 5 2023, 4:45 PM · Restricted Project, Restricted Project

Jan 4 2023

ahatanak committed rG665e47777df1: [ObjC][ARC] Fix non-deterministic behavior in ProvenanceAnalysis (authored by ahatanak).
[ObjC][ARC] Fix non-deterministic behavior in ProvenanceAnalysis
Jan 4 2023, 9:30 PM · Restricted Project, Restricted Project

Dec 19 2022

ahatanak added inline comments to D136639: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C struct property is set using dot notation.
Dec 19 2022, 8:24 AM · Restricted Project, Restricted Project
ahatanak updated the diff for D136639: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C struct property is set using dot notation.

Check that the destructor is called conditionally.

Dec 19 2022, 8:15 AM · Restricted Project, Restricted Project

Dec 16 2022

ahatanak added inline comments to D136639: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C struct property is set using dot notation.
Dec 16 2022, 6:50 PM · Restricted Project, Restricted Project
ahatanak added a comment to D139713: [Sema] Fix crash when evaluating nested call with value-dependent arg.

I read the patches and review comments in https://reviews.llvm.org/D42776, but I don't remember why I added that assert. Maybe I was just trying to ensure the version number passed to getTemporary was the one that was used to create the temporary. For example, if a temporary was created using version X and later retrieved using version Y because of some bug in constant evaluation, the assertion would fail.

Dec 16 2022, 6:03 PM · Restricted Project, Restricted Project

Dec 14 2022

ahatanak committed rG46b9d5797651: Return early if FileID is invalid. NFC (authored by ahatanak).
Return early if FileID is invalid. NFC
Dec 14 2022, 9:29 PM · Restricted Project, Restricted Project

Dec 9 2022

ahatanak added inline comments to D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens.
Dec 9 2022, 11:55 AM · Restricted Project, Restricted Project, Restricted Project

Dec 7 2022

ahatanak added a comment to D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file.

abc87ad4ed6cc5e6568751f375d1c646edb502f7 should fix the failing test.

Dec 7 2022, 4:20 PM · Restricted Project, Restricted Project
ahatanak committed rGabc87ad4ed6c: Remove slash in check string to fix the test that is failng on windows (authored by ahatanak).
Remove slash in check string to fix the test that is failng on windows
Dec 7 2022, 4:19 PM · Restricted Project, Restricted Project
ahatanak committed rG3738ce05a70c: Add support for a backdoor driver option that enables emitting header (authored by ahatanak).
Add support for a backdoor driver option that enables emitting header
Dec 7 2022, 3:32 PM · Restricted Project, Restricted Project
ahatanak closed D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file.
Dec 7 2022, 3:31 PM · Restricted Project, Restricted Project

Dec 6 2022

ahatanak updated the diff for D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file.

Address review comments.

Dec 6 2022, 7:01 PM · Restricted Project, Restricted Project
ahatanak added a comment to D138796: ObjCARC: Try to fix faulty tests.

I confirmed ARC optimizer hasn't removed the retain/release pairs in both functions at least since October 2017. The retain/release pair in @"\01-[Top0 _getX]" can be removed. I'm not sure about the one in @"\01-[A z]".

Great progress; seems to me like the regression is old enough it might not be an easy fix. Are you okay with the tests being cleaned up to reflect reality in the meantime?

Yes, I think that's okay. We are tracking this internally, so this can be committed as-is.

Dec 6 2022, 12:38 PM · Restricted Project, Restricted Project
ahatanak added inline comments to D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file.
Dec 6 2022, 12:06 PM · Restricted Project, Restricted Project

Dec 5 2022

ahatanak updated the diff for D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file.

Add another environment variable CC_PRINT_HEADERS_FILTERING, which can be used to specify whether header information should be filtered or not.

Dec 5 2022, 7:19 AM · Restricted Project, Restricted Project

Dec 2 2022

ahatanak committed rG1127e479e850: Don't revisit the subexpressions of PseudoObjectExpr when building a (authored by ahatanak).
Don't revisit the subexpressions of PseudoObjectExpr when building a
Dec 2 2022, 11:42 AM · Restricted Project, Restricted Project
ahatanak closed D139171: Don't revisit the subexpressions of PseudoObjectExpr when building a ParentMap.
Dec 2 2022, 11:42 AM · Restricted Project, Restricted Project

Dec 1 2022

ahatanak requested review of D139171: Don't revisit the subexpressions of PseudoObjectExpr when building a ParentMap.
Dec 1 2022, 11:25 PM · Restricted Project, Restricted Project

Nov 29 2022

ahatanak added a comment to D138796: ObjCARC: Try to fix faulty tests.

I confirmed ARC optimizer hasn't removed the retain/release pairs in both functions at least since October 2017. The retain/release pair in @"\01-[Top0 _getX]" can be removed. I'm not sure about the one in @"\01-[A z]".

Nov 29 2022, 9:30 AM · Restricted Project, Restricted Project

Nov 28 2022

ahatanak added a comment to D138796: ObjCARC: Try to fix faulty tests.

ARC optimizer was previously removing the retain/release pair, but it's not clear to me why it was safe to do so. There is a load that loads an ivar of the object before the call to @llvm.objc.release, so the object has to be kept alive at least until that point.

Nov 28 2022, 11:36 AM · Restricted Project, Restricted Project

Nov 17 2022

ahatanak added inline comments to D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file.
Nov 17 2022, 6:30 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file.

Address review comments. Also, change check string in test case to fix pre-merge checks that were failing.

Nov 17 2022, 6:29 PM · Restricted Project, Restricted Project

Nov 16 2022

ahatanak added a comment to D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file.

Mostly looks good. Is this expected to work with Clang modules at all?

Nov 16 2022, 10:12 PM · Restricted Project, Restricted Project
ahatanak updated the diff for D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file.

Address review comments.

Nov 16 2022, 6:59 PM · Restricted Project, Restricted Project

Nov 15 2022

ahatanak committed rG81e33602f78d: [Sema] Use the value category of the base expression when creating an (authored by ahatanak).
[Sema] Use the value category of the base expression when creating an
Nov 15 2022, 5:16 PM · Restricted Project, Restricted Project
ahatanak added a reverting change for rG220d08d942ab: [Objective-C patch] Patch to fix a crash in IRGen because of incorrect AST when…: rG81e33602f78d: [Sema] Use the value category of the base expression when creating an.
Nov 15 2022, 5:16 PM
ahatanak closed D138058: [Sema] Use the value category of the base expression when creating an ExtVectorElementExpr.
Nov 15 2022, 5:15 PM · Restricted Project, Restricted Project
ahatanak committed rG063a43b4fd9f: [ObjC] Fix an assertion failure in EvaluateLValue (authored by ahatanak).
[ObjC] Fix an assertion failure in EvaluateLValue
Nov 15 2022, 2:42 PM · Restricted Project, Restricted Project
ahatanak added a reverting change for rG220d08d942ab: [Objective-C patch] Patch to fix a crash in IRGen because of incorrect AST when…: D138058: [Sema] Use the value category of the base expression when creating an ExtVectorElementExpr.
Nov 15 2022, 12:46 PM
ahatanak requested review of D138058: [Sema] Use the value category of the base expression when creating an ExtVectorElementExpr.
Nov 15 2022, 12:46 PM · Restricted Project, Restricted Project

Nov 14 2022

ahatanak requested review of D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file.
Nov 14 2022, 5:22 PM · Restricted Project, Restricted Project

Nov 13 2022

ahatanak added inline comments to D137083: [ObjCARC] Replace parts of ObjCARCAA with intrinsic attributes.
Nov 13 2022, 8:35 PM · Restricted Project, Restricted Project

Nov 8 2022

ahatanak committed rG295861514e0d: [ObjC][ARC] Fix non-deterministic behavior in ProvenanceAnalysis (authored by ahatanak).
[ObjC][ARC] Fix non-deterministic behavior in ProvenanceAnalysis
Nov 8 2022, 3:07 PM · Restricted Project, Restricted Project

Oct 26 2022

ahatanak accepted D136805: [NFC] Make format() more amenable to format attributes.

Probably not NFC according to https://llvm.org/docs/Lexicon.html, but LGTM.

Oct 26 2022, 6:03 PM · Restricted Project, Restricted Project

Oct 24 2022

ahatanak accepted D132413: [NFC] Make format() more amenable to format attributes.

LGTM with minor comments.

Oct 24 2022, 9:40 PM · Restricted Project, Restricted Project
ahatanak requested review of D136639: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C struct property is set using dot notation.
Oct 24 2022, 2:29 PM · Restricted Project, Restricted Project
ahatanak added inline comments to D132413: [NFC] Make format() more amenable to format attributes.
Oct 24 2022, 12:18 PM · Restricted Project, Restricted Project

Oct 17 2022

ahatanak accepted D135706: [libc++] Fix std::function's handling of blocks under Objc ARC.

LGTM

Oct 17 2022, 3:35 PM · Restricted Project, Restricted Project

Oct 14 2022

ahatanak added inline comments to D135376: [Transforms/ObjCARC] Fix non-deterministic output of `ObjCARCOptPass`.
Oct 14 2022, 10:48 AM · Restricted Project, Restricted Project
ahatanak committed rG28f7087c9163: [CodeGen][ObjC] Call synthesized copy constructor/assignment operator (authored by ahatanak).
[CodeGen][ObjC] Call synthesized copy constructor/assignment operator
Oct 14 2022, 10:42 AM · Restricted Project, Restricted Project
ahatanak closed D131701: [CodeGen][ObjC] Call synthesized copy constructor/assignment operator functions in getter/setter functions of non-trivial C struct properties.
Oct 14 2022, 10:41 AM · Restricted Project, Restricted Project
ahatanak accepted D135376: [Transforms/ObjCARC] Fix non-deterministic output of `ObjCARCOptPass`.

LGTM

Oct 14 2022, 9:28 AM · Restricted Project, Restricted Project

Oct 12 2022

ahatanak added inline comments to D135376: [Transforms/ObjCARC] Fix non-deterministic output of `ObjCARCOptPass`.
Oct 12 2022, 10:07 AM · Restricted Project, Restricted Project
ahatanak added inline comments to D135376: [Transforms/ObjCARC] Fix non-deterministic output of `ObjCARCOptPass`.
Oct 12 2022, 7:46 AM · Restricted Project, Restricted Project

Oct 7 2022

ahatanak accepted D135273: [Clang][ObjC] Add optionality to property attribute strings..

This LGTM for apple's runtime assuming it knows how to handle the new string.

Oct 7 2022, 7:44 PM · Restricted Project, Restricted Project