- User Since
- Dec 4 2013, 1:37 PM (262 w, 6 d)
Sorry, please ignore my previous comment. I was looking at the wrong place.
Here are a couple of examples I found running the regression tests:
Fri, Dec 14
Call CheckPlaceholderExpr instead of pushing an unevaluated evaluation context.
The patch looks largely fine to me.
Thu, Dec 13
Just to clarify, this patch doesn't change clang's handling of C++ unions that have non-static data members with non-trivial special member functions.
Mon, Dec 10
Sun, Dec 9
Tue, Dec 4
Mon, Dec 3
Fri, Nov 30
I've reverted the changes I made to test/SemaCUDA/call-host-fn-from-device.cu since r342749 fixed the overload resolution bug.
Nov 14 2018
Nov 5 2018
Oct 30 2018
Oct 20 2018
Oct 19 2018
Oct 11 2018
Oct 1 2018
Sep 8 2018
Sep 6 2018
Sep 5 2018
Address review comments. Fix bugs in the handling of __block variables that have reference types.
Sep 4 2018
Point the diagnostic at either the relevant init list element or at the close brace.
Aug 31 2018
Move the call that checks the element's destructor into InitListChecker::CheckStructUnionTypes.
The GNUstep documentation I found replaces '@' with '\1'. Would that fix the problem?
Aug 30 2018
Aug 28 2018
Aug 23 2018
Aug 22 2018
Aug 21 2018
Thanks. Yes, it's a typo.
Aug 20 2018
Aug 17 2018
The code you showed does compile with or without -fcuda-is-device after applying my patch.
Aug 16 2018
Mark the block descriptor global variable as unnamed_addr.
Try harder to shorten the names of block descriptor global variables.
Aug 15 2018
A few points I forgot to mention:
Aug 13 2018
Aug 10 2018
Aug 9 2018
Replace the two flags, EHOnly and DisposeCannotThrow, passed to pushCaptureCleanup with a single flag ForCopyHelper.
Call MarkFunctionReferenced to mark the function __builtin_operator_new or __builtin_operator_delete will call as referenced.
Define functions inline in the header file.
Address review comments.
Aug 8 2018
Address review comments.
Modify getBlockVarCopyInits and setBlockVarCopyInits to get and set both the copy expression and the boolean flag that indicates whether the expression can throw or not.
Change the value type of BlockVarCopyInits to PointerIntPair<Expr *, 1, bool>. The boolean flag indicates whether the copy expression can throw. Serialize/deserialize the copy expression and the boolean flag and add a regression test to test/PCH.
Aug 7 2018
Since BlockVarCopyInits is a map with key VarDecl *, I think we want to add a flag to VarDecl (NonParmVarDeclBits) that indicates whether the copy expression can throw or not. Or is there a reason to store the bit in BlockDecl::Capture instead?
I thought it was okay to skip the work done by ResolveExceptionSpec in IRGen as long as the exception specifications that are needed have already been resolved in Sema. But calling Sema::canThrow in Sema::CheckCompleteVariableDeclaration and storing the result in BlockDecl::Capture is clearly the better solution since it doesn't introduce the complexity introduced in the updated patch.
Remove a stale comment and add an assertion to check the destructor's exception specification has been resolved.