This is an archive of the discontinued LLVM Phabricator instance.

[2/8][RISCV] Add rounding mode control variant for vfwadd, vfwsub
ClosedPublic

Authored by eopXD on Jul 6 2023, 10:58 AM.

Details

Summary

Depends on D154628

For the cover letter of the patch-set, please checkout D154628.

This is the 2nd patch of the patch-set.

Diff Detail

Event Timeline

eopXD created this revision.Jul 6 2023, 10:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2023, 10:58 AM
eopXD requested review of this revision.Jul 6 2023, 10:58 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 6 2023, 10:58 AM
eopXD retitled this revision from [RISCV] Add rounding mode control variant for vfwadd, vfwsub to [2/8][RISCV] Add rounding mode control variant for vfwadd, vfwsub.Jul 6 2023, 11:09 AM
eopXD edited the summary of this revision. (Show Details)
craig.topper added inline comments.Jul 6 2023, 12:04 PM
llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
14

RISCV.h already includes this.

2523

This is a lot of code duplication. Can't we add a couple ifs to the existing code?

eopXD updated this revision to Diff 538001.Jul 6 2023, 11:14 PM
eopXD marked 2 inline comments as done.

Address comment from Craig:

  • Remove unnecessary added header
  • Reduce code duplication
eopXD updated this revision to Diff 538003.Jul 6 2023, 11:31 PM

Update test case for vfwsub under clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated

craig.topper accepted this revision.Jul 10 2023, 12:26 PM

LGTM

llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
2521

This conflicts with D154245

This revision is now accepted and ready to land.Jul 10 2023, 12:26 PM
eopXD updated this revision to Diff 539430.Jul 12 2023, 2:04 AM

Change:

  • Rebase upon latest main and updated parent revisions
This revision was landed with ongoing or failed builds.Jul 13 2023, 12:42 AM
This revision was automatically updated to reflect the committed changes.