This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add support for XCVsimd extension in CV32E40P
ClosedPublic

Authored by melonedo on Jun 25 2023, 6:18 AM.

Details

Summary

Implement XCVsimd intrinsics for CV32E40P according to the specification.

This commit is part of a patch-set to upstream the 7 vendor specific extensions of CV32E40P.

Contributors: @CharKeaney, @jeremybennett, @lewis-revill, @liaolucy, Nandni Jamnadas, @PaoloS, @simoncook, @xmj.

Diff Detail

Event Timeline

melonedo created this revision.Jun 25 2023, 6:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 25 2023, 6:18 AM
melonedo requested review of this revision.Jun 25 2023, 6:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 25 2023, 6:18 AM
melonedo updated this revision to Diff 534334.Jun 25 2023, 6:32 AM

Rebase to main

melonedo updated this revision to Diff 536692.Jul 3 2023, 2:21 AM

Update immediate type of cv.avgu/srl/sra/sll

melonedo edited the summary of this revision. (Show Details)Jul 4 2023, 12:49 AM
simoncook added inline comments.Jul 7 2023, 12:50 AM
llvm/lib/Target/RISCV/RISCVFeatures.td
811

nit for consistency: I notice the XCVmac above has V in capitals, but this one doesn't

asb added inline comments.Jul 9 2023, 6:24 AM
llvm/docs/RISCVUsage.rst
275

I think per the discussion in another thread, this should actually be 1.0.

melonedo updated this revision to Diff 538966.Jul 11 2023, 1:57 AM

RV->CV; update version; add "CORE-V" to feature description

melonedo edited the summary of this revision. (Show Details)Jul 11 2023, 2:01 AM
melonedo added a subscriber: PaoloS.
melonedo updated this revision to Diff 541348.Jul 18 2023, 12:16 AM

Various corrections based on D155283

Fix spelling of "CORE-V"; add xcvsimd to RISCVISAInfo.cpp and its tests.

melonedo updated this revision to Diff 541349.Jul 18 2023, 12:22 AM

Fix capitalization of FeatureVendorXCVsimd

melonedo updated this revision to Diff 542780.Jul 21 2023, 12:18 AM

Switch cv.and/or/xor to signed according to spec to allow 0xffff-like patterns

craig.topper added inline comments.Jul 24 2023, 1:37 PM
llvm/docs/RISCVUsage.rst
283

Put this above XSfcie?

284

Is it CORE-V or Core-V? Previous extensions said "by OpenHW Group" rather than "by Core-V".

melonedo updated this revision to Diff 543791.Jul 24 2023, 7:48 PM
melonedo marked 4 inline comments as done.

Edit RISCVUsage.rst

craig.topper added inline comments.Jul 24 2023, 7:52 PM
llvm/lib/Target/RISCV/RISCVInstrInfoXCV.td
187

This needs to be rebased. The Opcode field no longer exists. You should assign Inst{6-0} directly

melonedo updated this revision to Diff 543799.Jul 24 2023, 8:06 PM

Adjust opcode field and rebase to main

This revision is now accepted and ready to land.Jul 24 2023, 8:13 PM
This revision was automatically updated to reflect the committed changes.
llvm/test/MC/RISCV/attribute-arch.s