This is an archive of the discontinued LLVM Phabricator instance.

Adopt Properties to store operations inherent Attributes in the LLVM dialect
ClosedPublic

Authored by mehdi_amini on Apr 13 2023, 9:59 PM.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 13 2023, 9:59 PM
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
mehdi_amini requested review of this revision.Apr 13 2023, 9:59 PM
ftynse added inline comments.Apr 22 2023, 2:07 PM
mlir/test/Target/LLVMIR/llvmir.mlir
3

I don't think we should be dropping the entire translation test. Are we missing syntax updates to keep this working?

ftynse requested changes to this revision.Apr 22 2023, 2:07 PM
This revision now requires changes to proceed.Apr 22 2023, 2:07 PM

Rebase after improving diagnostic on invalid IR

mehdi_amini added inline comments.Apr 23 2023, 10:33 PM
mlir/test/Target/LLVMIR/llvmir.mlir
3

This was a mistake to commit this change, I pruned the file for debugging at some point. Reverted now.

Fix more tests (still one WIP)

rriddle accepted this revision.Apr 23 2023, 10:56 PM
ftynse accepted this revision.Apr 24 2023, 12:38 AM
ftynse added inline comments.
mlir/test/Dialect/Tosa/invalid.mlir
141 ↗(On Diff #516274)

Tosa change looks irrelevant here. Mismerge?

This revision is now accepted and ready to land.Apr 24 2023, 12:38 AM
This revision was landed with ongoing or failed builds.May 8 2023, 4:29 AM
This revision was automatically updated to reflect the committed changes.