This is an archive of the discontinued LLVM Phabricator instance.

Differential D148934

Adopt Properties to store operations inherent Attributes in the Shape dialect
ClosedPublic

Authored by mehdi_amini on Apr 21 2023, 9:37 AM.

Details

Reviewers
rriddle
jpienaar
nicolasvasilache
Commits
rGc85bcb4751b2: Adopt Properties to store operations inherent Attributes in the Shape dialect
Summary

This is part of an on-going migration to adopt Properties inside MLIR.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 21 2023, 9:37 AM
Herald added 1 blocking reviewer(s): jpienaar. · View Herald TranscriptApr 21 2023, 9:37 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bviyer, Moerafaat, zero9178 and 20 others. · View Herald Transcript
mehdi_amini requested review of this revision.Apr 21 2023, 9:37 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 21 2023, 9:38 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
mehdi_amini added a child revision: D148935: Adopt Properties to store operations inherent Attributes in the SparseTensor dialect.Apr 21 2023, 9:40 AM
mehdi_amini added a parent revision: D148933: Adopt Properties to store operations inherent Attributes in the SCF dialect.
Harbormaster completed remote builds in B227231: Diff 515796.Apr 21 2023, 11:15 AM
mehdi_amini updated this revision to Diff 516013.Apr 21 2023, 8:22 PM

Rebase

Harbormaster completed remote builds in B227408: Diff 516013.Apr 21 2023, 10:09 PM
jpienaar accepted this revision.Apr 22 2023, 6:13 AM
This revision is now accepted and ready to land.Apr 22 2023, 6:13 AM
mehdi_amini updated this revision to Diff 516267.Apr 23 2023, 10:33 PM

Rebase after improving diagnostic on invalid IR

Harbormaster completed remote builds in B227622: Diff 516267.Apr 24 2023, 12:00 AM
mehdi_amini updated this revision to Diff 516677.Apr 25 2023, 12:20 AM

Rebase

Harbormaster completed remote builds in B227931: Diff 516677.Apr 25 2023, 2:24 AM
This revision was landed with ongoing or failed builds.May 10 2023, 4:16 PM
Closed by commit rGc85bcb4751b2: Adopt Properties to store operations inherent Attributes in the Shape dialect (authored by mehdi_amini). · Explain Why
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rGc85bcb4751b2: Adopt Properties to store operations inherent Attributes in the Shape dialect.

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
Shape/
IR/
1 line

Diff 521143

mlir/include/mlir/Dialect/Shape/IR/ShapeBase.td

Show All 35 Linesdef ShapeDialect : Dialect {
}]; }];
let cppNamespace = "::mlir::shape"; let cppNamespace = "::mlir::shape";
let dependentDialects = ["arith::ArithDialect", "tensor::TensorDialect"]; let dependentDialects = ["arith::ArithDialect", "tensor::TensorDialect"];
let useDefaultTypePrinterParser = 1; let useDefaultTypePrinterParser = 1;
let hasConstantMaterializer = 1; let hasConstantMaterializer = 1;
let hasOperationAttrVerify = 1; let hasOperationAttrVerify = 1;
let usePropertiesForAttributes = 1;
} }
class Shape_Type<string name, string typeMnemonic> : TypeDef<ShapeDialect, name> { class Shape_Type<string name, string typeMnemonic> : TypeDef<ShapeDialect, name> {
let mnemonic = typeMnemonic; let mnemonic = typeMnemonic;
} }
def Shape_ShapeType : Shape_Type<"Shape", "shape"> { def Shape_ShapeType : Shape_Type<"Shape", "shape"> {
let description = [{ let description = [{
▲ Show 20 Lines • Show All 90 Lines • Show Last 20 Lines