This is an archive of the discontinued LLVM Phabricator instance.

Differential D148935

Adopt Properties to store operations inherent Attributes in the SparseTensor dialect
ClosedPublic

Authored by mehdi_amini on Apr 21 2023, 9:38 AM.

Details

Reviewers
rriddle
jpienaar
aartbik
nicolasvasilache
Commits
rG13681450728e: Adopt Properties to store operations inherent Attributes in the SparseTensor…
Summary

This is part of an on-going migration to adopt Properties inside MLIR.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 21 2023, 9:38 AM
Herald added a reviewer: aartbik. · View Herald TranscriptApr 21 2023, 9:38 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bviyer, hanchung, jsetoain and 23 others. · View Herald Transcript
mehdi_amini requested review of this revision.Apr 21 2023, 9:38 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 21 2023, 9:38 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
mehdi_amini added a child revision: D148936: Adopt Properties to store operations inherent Attributes in the SPIRV dialect.Apr 21 2023, 9:40 AM
mehdi_amini added a parent revision: D148934: Adopt Properties to store operations inherent Attributes in the Shape dialect.
mehdi_amini updated this revision to Diff 516014.Apr 21 2023, 8:23 PM

Rebase

Harbormaster completed remote builds in B227409: Diff 516014.Apr 21 2023, 10:09 PM
mehdi_amini updated this revision to Diff 516268.Apr 23 2023, 10:33 PM

Rebase after improving diagnostic on invalid IR

rriddle accepted this revision.Apr 23 2023, 11:09 PM
This revision is now accepted and ready to land.Apr 23 2023, 11:09 PM
Harbormaster completed remote builds in B227623: Diff 516268.Apr 23 2023, 11:49 PM
aartbik accepted this revision.Apr 24 2023, 9:58 AM
mehdi_amini updated this revision to Diff 516678.Apr 25 2023, 12:20 AM

Rebase

Harbormaster completed remote builds in B227932: Diff 516678.Apr 25 2023, 2:19 AM
This revision was landed with ongoing or failed builds.May 10 2023, 4:16 PM
Closed by commit rG13681450728e: Adopt Properties to store operations inherent Attributes in the SparseTensor… (authored by mehdi_amini). · Explain Why
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rG13681450728e: Adopt Properties to store operations inherent Attributes in the SparseTensor….

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
SparseTensor/
IR/
1 line

Diff 521144

mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorBase.td

Show First 20 Lines • Show All 79 Lines • ▼ Show 20 Lines let description = [{
Proceedings of the IEEE/ACM International Symposium on Code Generation Proceedings of the IEEE/ACM International Symposium on Code Generation
and Optimization, 2019. and Optimization, 2019.
* [Kjolstad20] Fredrik Berg Kjolstad. Sparse Tensor Algebra Compilation. * [Kjolstad20] Fredrik Berg Kjolstad. Sparse Tensor Algebra Compilation.
PhD thesis, MIT, February, 2020. PhD thesis, MIT, February, 2020.
}]; }];
let useDefaultAttributePrinterParser = 1; let useDefaultAttributePrinterParser = 1;
let useDefaultTypePrinterParser = 1; let useDefaultTypePrinterParser = 1;
let usePropertiesForAttributes = 1;
} }
#endif // SPARSETENSOR_BASE #endif // SPARSETENSOR_BASE